D19075: Fix FindEGL

hausmann accepted this revision. hausmann added a comment. This revision is now accepted and ready to land. Thank you:) REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D19075 To: tcberner, #automotive, hausmann, #freebsd Cc:

D18960: Add compile check to FindEGL

hausmann created this revision. hausmann added a reviewer: vkrause. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. hausmann requested review of this revision. REVISION SUMMARY Perform additional sanity checking REPOSITORY

D18960: Add compile check to FindEGL

This revision was automatically updated to reflect the committed changes. Closed by commit R240:0b47899c1b92: Add compile check to FindEGL (authored by hausmann). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18960?vs=51512=51574 REVISION DETAIL

D18960: Add compile check to FindEGL

hausmann added a comment. Ooops. Could you paste the error from the cmake error output? I'm curious which part of the EGL compile test fails. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18960 To: hausmann, vkrause, apol Cc: tcberner, kossebau,

D19075: Fix FindEGL

hausmann requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19075 To: tcberner, #automotive, hausmann, #freebsd Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham,

D19075: Fix FindEGL

hausmann added a comment. Yeah I think find_path should use the same style as the test program (EGL/egl.h). It is the style of inclusion as per the specification. I think that’s better than the ../ approach. REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D19075: Fix FindEGL

hausmann added a comment. I think that it should be NAMES EGL/egl.h REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D19075 To: tcberner, #automotive, hausmann, #freebsd Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D24182: Fix FindEGL when using Emscripten

hausmann closed this revision. hausmann added a comment. Thanks, landed in 3b0bf71a72789eb2b79310b4f67602115e347f56 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24182 To: hausmann, vkrause, tcberner, alexmerry Cc: kde-frameworks-devel,

D24182: Fix FindEGL when using Emscripten

hausmann created this revision. hausmann added reviewers: vkrause, tcberner, alexmerry. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. hausmann requested review of this revision. REVISION SUMMARY When using the Emscripten