Hi,
building on CentOS 6.8, I noticed some frameworks (namely KAuth,
KSyntaxHighlighting) don't actually build with cmake 2.8 -- it seems to
be related with moc'ing the Q_GADGET macro. Still, they specify cmake
2.8 as the minimum required cmake version.
Do we
- attempt to fix this with cmake
brauch accepted this revision.
brauch added a comment.
This revision is now accepted and ready to land.
Ok then, even if it breaks on WinXP occasionally, I guess the impact is
negligible.
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3392
EMAIL PREFERENCES
brauch added a comment.
Hm, there is at least one race condition here: thread A does old =
::SetErrorMode(...), then if before it resets it thread B does the same, then
the old mode might never be restored. We can put a mutex but of course there
might be another piece of code which does the
brauch accepted this revision.
brauch added a comment.
This revision is now accepted and ready to land.
Er, oops.
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3091
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk, #frameworks,
brauch requested changes to this revision.
brauch added a comment.
This revision now requires changes to proceed.
Since it fixes the issue and looks sensible to me, +1
REVISION DETAIL
https://phabricator.kde.org/D3091
EMAIL PREFERENCES
brauch added a comment.
The user who originally reported the issue confirms that this patch fixes it.
REVISION DETAIL
https://phabricator.kde.org/D3091
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk, #frameworks, brauch
Cc: nalvarez, broulik
brauch added a comment.
The other interesting question is why we even query for free disk space on
all drives, but I guess this patch still makes sense in any case.
REVISION DETAIL
https://phabricator.kde.org/D3091
EMAIL PREFERENCES
> On March 28, 2016, 8:22 p.m., Sven Brauch wrote:
> > Hmm. Do we really need code for that? Can't you simply assign those buttons
> > to the forward / backward actions as shortcuts? Try setting them as
> > alternate shortcuts by default.
>
> Anthony Fieroni wrote
> On March 28, 2016, 8:22 p.m., Sven Brauch wrote:
> > Hmm. Do we really need code for that? Can't you simply assign those buttons
> > to the forward / backward actions as shortcuts? Try setting them as
> > alternate shortcuts by default.
>
> Anthony Fieroni wrote
assign those buttons to
the forward / backward actions as shortcuts? Try setting them as alternate
shortcuts by default.
- Sven Brauch
On March 28, 2016, 8:20 p.m., Anthony Fieroni wrote:
>
> ---
> This is an automatically generat
Hey Alexander,
Thanks for caring and sorry for breaking the string freeze; I missed
that. I reverted the commit and I will resubmit it after the 5.8 release
is out.
On 05/03/16 01:01, Alexander Potashev wrote:
> [2] is clearly a feature, but it was not submitted to reviewboard
> before pushing
marked as submitted.
Review request for KDE Frameworks.
Changes
---
Submitted with commit b45544f3d4dd9cb1873b92a609f45a68f5f6e471 by Sven Brauch
to branch master.
Bugs: 350785
https://bugs.kde.org/show_bug.cgi?id=350785
Repository: knotifications
Description
---
See bug
/kstatusnotifieritem.cpp c48f4d0
Diff: https://git.reviewboard.kde.org/r/126212/diff/
Testing
---
Now prints an error message instead of crashing.
Thanks,
Sven Brauch
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman
----
On Dec. 1, 2015, 12:53 a.m., Sven Brauch wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126212/
> -
is broken, but it's just an env var and it's hard
to track down.
Diffs
-
src/kstatusnotifieritem.cpp c48f4d0
Diff: https://git.reviewboard.kde.org/r/126212/diff/
Testing
---
Now prints an error message instead of crashing.
Thanks,
Sven Brauch
to this issue is broken, but it's just an env var and it's hard
to track down.
Diffs (updated)
-
src/kstatusnotifieritem.cpp c48f4d0
Diff: https://git.reviewboard.kde.org/r/126212/diff/
Testing
---
Now prints an error message instead of crashing.
Thanks,
Sven Brauch
is broken, but it's just an env var and it's hard
to track down.
Diffs
-
src/kstatusnotifieritem.cpp c48f4d0
Diff: https://git.reviewboard.kde.org/r/126212/diff/
Testing
---
Now prints an error message instead of crashing.
Thanks,
Sven Brauch
those files into a
new mime type and add that to the KDevelop plugin as well (it supports
specifying multiple mime types already), but since the files are valid QML
syntax, I don't see a need for that.
- Sven Brauch
On Jan. 30, 2015, 2:48 p.m., Denis Steckelmacher wrote
Actually I just found it doesn't build with VS2012 either, ugh. And I
expected the fixes to be easier, but it seems I still have to fix the
unit test full of brace initializers for 2012 to work.
I will fix that, after all it's my fault it looks like this. Just tell
me what features I can't use.
/diff/
Testing
---
Just some quick manual tests, it seems to still work as intended.
Thanks,
Sven Brauch
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117695/#review57494
---
Ping, any new opinions on this?
- Sven Brauch
On May 3
Diff: https://git.reviewboard.kde.org/r/117695/diff/
Testing
---
Just some quick manual tests, it seems to still work as intended.
Thanks,
Sven Brauch
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
/#review56439
---
On April 23, 2014, 11:15 a.m., Sven Brauch wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117695
546d3e6aadc57f24c3fa766ce235addc0f02e3c3
Diff: https://git.reviewboard.kde.org/r/117695/diff/
Testing
---
Just some quick manual tests, it seems to still work as intended.
Thanks,
Sven Brauch
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https
quick manual tests, it seems to still work as intended.
Thanks,
Sven Brauch
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117695/#review56220
---
On April 22, 2014, 9:06 p.m., Sven Brauch wrote
101 - 126 of 126 matches
Mail list logo