Review Request 128792: Fix choose other icon

, the this will run on top of it as modal too. Signed-off-by: Tomaz Canabrava <tomaz.canabr...@gmail.com> Diffs - src/kicondialog.cpp d75ad970504bff5ae1cb785e6a06f9f9da58a1ff Diff: https://git.reviewboard.kde.org/r/128792/diff/ Testing --- now the dialog to choose the othe

Re: Review Request 128792: Fix choose other icon

on dolphin, same thing happened. This patch makes sure that if one of the widgets are modal, the this will run on top of it as modal too. Signed-off-by: Tomaz Canabrava <tomaz.canabr...@gmail.com> Diffs - src/kicondialog.cpp d75ad970504bff5ae1cb785e6a06f9f9da58a1ff Diff:

Re: Please cleanup your scratch and clone repositories

Done. On Sun, Nov 27, 2016 at 9:39 AM, Ben Cooksley wrote: > On Sat, Nov 26, 2016 at 7:53 AM, Ben Cooksley wrote: > > Hi all, > > Hi all, > > > > > To help Sysadmin assess how these types of repositories would be used > > under Phabricator, it would be

D5400: new class, KActionRunner

tcanabrava created this revision. Restricted Application added a project: Frameworks. REVISION SUMMARY KActionRunner is a class that has a KRunner like behavior for the actions in a KActionCollection. The idea is that if a user knows what he's looking for, it's much simpler to write part of

D5400: new class, KActionRunner

tcanabrava added a comment. In https://phabricator.kde.org/D5400#101353, @ltoscano wrote: > General issue: KCompletion is a tier2 framework, and this introduces a dependency on KXmlGui, tier3. I wasn't aware of that - I'll move this to KXmlGui as it makes sense. REPOSITORY

Re: Making Purpose part of KF5

On Thu, Nov 9, 2017 at 5:10 PM, Aleix Pol wrote: > Hi, > I would like to include Purpose [1] into the frameworks umbrella. > It's been around for a while now, used by few applications and > reasonably stable. > > Any thoughts? > +1 I actually included it in kdesrc-build quite

D5400: new class, KActionRunner

tcanabrava abandoned this revision. REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D5400 To: tcanabrava, #frameworks, ltoscano Cc: ltoscano, michaelh, ngraham

D15739: [Places panel] Don't show Root by default

tcanabrava accepted this revision. tcanabrava added a comment. This revision is now accepted and ready to land. too many +1 to not be accepted. REPOSITORY R241 KIO BRANCH remote-root-from-places-panel (branched from master) REVISION DETAIL https://phabricator.kde.org/D15739 To:

D17977: Improve reliability and semantic correctless of dupe test

tcanabrava added inline comments. INLINE COMMENTS > dupetest.cpp:87-88 > } > for (auto dir : ICON_DIRS) { > -dupesForDirectory(PROJECT_SOURCE_DIR + QStringLiteral("/") + > dir); > +for (auto type : ICON_TYPES) { > +

D19956: ki18n: updating memory manager and removing compile warnings

tcanabrava added a comment. -1 gettext is c code, should not use c++ includes. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D19956 To: carneirogustavo, andreagenor, tcanabrava, patrickelectric Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

Re: CI system maintainability

On Thu, Mar 28, 2019 at 10:09 AM Luca Beltrame wrote: > > In data giovedì 28 marzo 2019 09:50:47 CET, Kevin Ottens ha scritto: > > I'd argue we're loosing more with the current state of PIM than we'd loose > > with mandatory reviews. > > Perhaps, instead of an all-or-nothing approach, why not a

D19960: bluez-qt: remove warnings

tcanabrava added a comment. ping? REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D19960 To: carneirogustavo, andreagenor, tcanabrava, patrickelectric Cc: pino, kde-frameworks-devel, michaelh, ngraham, bruns

D19956: ki18n: updating memory manager and removing compile warnings

tcanabrava resigned from this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D19956 To: carneirogustavo, andreagenor, patrickelectric Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D15076: Build failures with KSyntaxHighlighting 5.49

tcanabrava resigned from this revision. REPOSITORY R55 Cantor REVISION DETAIL https://phabricator.kde.org/D15076 To: asemke, #kde_edu, #cantor, #frameworks Cc: bcooksley, elvisangelaccio, dfaure, cgiboudeaux, mpyne, cullmann, kde-edu, narvaez, apol

D22147: Better use of Qt APIs in Plasma::Theme

tcanabrava added inline comments. INLINE COMMENTS > svg.cpp:339-364 > if (!elementSizeHints.isEmpty()) { > QSize bestFit(-1, -1); > > -Q_FOREACH (QSize hint, elementSizeHints) { > +for (const QSize : elementSizeHints) { > > if

D22147: Better use of Qt APIs in Plasma::Theme

tcanabrava added inline comments. INLINE COMMENTS > svg.cpp:342-349 > +for (const QSize : elementSizeHints) { > > if (hint.width() >= s.width() * ratio && hint.height() >= > s.height() * ratio && > (!bestFit.isValid() || >

D23200: Fixes a crash in Peruse triggered by baloo

tcanabrava updated this revision to Diff 63863. tcanabrava added a comment. - Remove debug line - return null instead of asserting REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23200?vs=63858=63863 BRANCH fixCrashWithEmptyFolder REVISION DETAIL

D23200: Fixes a crash in Peruse triggered by baloo

tcanabrava created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. tcanabrava requested review of this revision. REPOSITORY R293 Baloo BRANCH fixCrashWithEmptyFolder REVISION DETAIL https://phabricator.kde.org/D23200

D23200: Fixes a crash in Peruse triggered by baloo

This revision was automatically updated to reflect the committed changes. Closed by commit R293:7190e177f537: Fixes a crash in Peruse triggered by baloo (authored by tcanabrava). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23200?vs=63863=64799 REVISION

D25149: Add a new Template for KCM's.

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY Add a new template for KCM's TEST PLAN Created a new project via KAppTemplate, compiled, run the kcm stuvb

D25149: Add a new Template for KCM's.

tcanabrava updated this revision to Diff 69296. tcanabrava added a comment. - Update readme REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25149?vs=69295=69296 BRANCH kcm_template REVISION DETAIL https://phabricator.kde.org/D25149

D25149: Add a new Template for KCM's.

tcanabrava edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25149 To: tcanabrava Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: D25084: Allow a Multiple instances to become Unique

https://invent.kde.org/kde/konsole/merge_requests/45 But it’s not related to this path, it’s just another bug On Fri, 1 Nov 2019 at 07:06 David Edmundson wrote: > davidedmundson added a comment. View Revision > > > I think I just need to verify if the name

D25084: Allow a Multiple instances to become Unique

tcanabrava added a comment. Point taken, I’ll rework the patch for a regexp of servicenane + ‘-‘ + pid, this will fix your second point. About your first point, do you think it’s a problem? Just speculating, if an app opens as multiple and then another instance tries to open as

Re: D25084: Allow a Multiple instances to become Unique

im Open to redo the patch but I don’t see the problems you guys see. The only thing this patch does is to quit early if you trigger a unique application *after* a multiple one has been spawned. See: Konsole (register as multiple) Konsole —new-tab (register as single) But instead of adding a tab

Re: D25084: Allow a Multiple instances to become Unique

Point taken, I’ll rework the patch for a regexp of servicenane + ‘-‘ + pid, this will fix your second point. About your first point, do you think it’s a problem? Just speculating, if an app opens as multiple and then another instance tries to open as unique, it should reuse the existing one or

D25084: Allow a Multiple instances to become Unique

tcanabrava added a comment. im Open to redo the patch but I don’t see the problems you guys see. The only thing this patch does is to quit early if you trigger a unique application *after* a multiple one has been spawned. See: Konsole (register as multiple) Konsole —new-tab

D25149: Add a new Template for KCM's.

tcanabrava added a comment. In D25149#559075 , @davidedmundson wrote: > A very sensible idea. ++ > > > templates/kcm-qml/qml-plasmoid.png > > What's this about? We need a better icon. it's the icon for the `Plasmoid` template.

D25149: Add a new Template for KCM's.

tcanabrava updated this revision to Diff 69400. tcanabrava added a comment. - Add KConfigXT REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25149?vs=69296=69400 BRANCH arcpatch-D25149 REVISION DETAIL

D25084: Allow a Multiple instances to become Unique

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY This fixes an issue with konsole when launched as Multiple Applications but once you typed --new-tab (that

D25149: Add a new template for KCMs

tcanabrava added inline comments. INLINE COMMENTS > ervin wrote in kcm.cpp:43 > Shouldn't be needed anymore (and likely wrong in most cases). What's the correct form then? No need to connect the settings *at all*? > ervin wrote in main.qml:39 > What about disabling it if the setting is

D25149: Add a new template for KCMs

tcanabrava updated this revision to Diff 69941. tcanabrava marked an inline comment as done. tcanabrava added a comment. - Adapt to ManagedConfigModule REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25149?vs=69649=69941 BRANCH

D25149: Add a new template for KCMs

tcanabrava updated this revision to Diff 69942. tcanabrava added a comment. - Handle immutability REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25149?vs=69941=69942 BRANCH arcpatch-D25149 REVISION DETAIL

D25149: Add a new template for KCMs

tcanabrava updated this revision to Diff 69649. tcanabrava marked 2 inline comments as done. tcanabrava added a comment. - Add KConfigXT - Remove wrong icon REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25149?vs=69400=69649 BRANCH

D25084: Allow a Multiple instances to become Unique

tcanabrava added a comment. > I'm open to counter-arguments and counter-examples. Actually, do we know of any other app than konsole which supports both Multiple and Unique modes? I would prefer to have only one mode. Tab & Split drag 'n drop only work in Single Instances, so if

D25149: Add a new template for KCMs

tcanabrava updated this revision to Diff 71009. tcanabrava marked an inline comment as done. tcanabrava added a comment. - Fix indentation REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25149?vs=69942=71009 BRANCH arcpatch-D25149

D25149: Add a new template for KCMs

tcanabrava marked 6 inline comments as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25149 To: tcanabrava, #plasma, #frameworks, mart, ervin Cc: #plasma, GB_2, yurchor, davidedmundson, ognarb, ervin, kde-frameworks-devel, LeGast00n,

D25149: Add a new template for KCMs

tcanabrava marked 2 inline comments as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D25149 To: tcanabrava, #plasma, #frameworks, mart, ervin Cc: #plasma, GB_2, yurchor, davidedmundson, ognarb, ervin, kde-frameworks-devel, LeGast00n,

D25084: Allow a Multiple instances to become Unique

tcanabrava added a comment. Yes, that's exactly what would happen, I think I just need to verify if the name would be the same as the name minus the uuid. because if you open an app on ::Multiple and later the same app on ::Unique, merging them seems sane. REPOSITORY R271 KDBusAddons

D25084: Allow a Multiple instances to become Unique

tcanabrava added a subscriber: GB_2. tcanabrava added a comment. https://invent.kde.org/kde/konsole/merge_requests/45 But it’s not related to this path, it’s just another bug REPOSITORY R271 KDBusAddons BRANCH multiple_to_unique REVISION DETAIL https://phabricator.kde.org/D25084

D26129: Remove Iterator based loops for range based loops

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. TEST PLAN Compiled and run the unittests REPOSITORY R237 KConfig BRANCH rangeBasedFor REVISION DETAIL

D26128: Simplify defaultValue method: Return Early, Use Default Initialization, and Assert.

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. TEST PLAN Recompiled and run the unittests REPOSITORY R237 KConfig BRANCH simplifyDefaultValue REVISION DETAIL

D26131: Braces around for, break early.

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. TEST PLAN Recompiled, Run Unittests REPOSITORY R237 KConfig BRANCH nitpicksLiteralString REVISION DETAIL

D26127: Simplify cppType method: Return Early, Use a Map and Assert.

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. TEST PLAN Recompiled and runned the unittests REPOSITORY R237 KConfig BRANCH simplifyCppType REVISION DETAIL

D26130: Simplify return logic

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY Don't create a temporary to edit and return, return something directly, this way we can benefit from RTO

D26133: Enable Auto Save

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY Some applications don't want the `wait for apply / ok / cancel` and prefer to automatically save the settings

D26133: Enable Auto Save

tcanabrava updated this revision to Diff 71920. tcanabrava added a comment. - Use a timer of 1s to trigger the save REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26133?vs=71916=71920 BRANCH enableAutoSave REVISION DETAIL

D26126: Simplify param method: Return Early, Use a Map and Assert.

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. TEST PLAN Recompiled and runned the unittests REPOSITORY R237 KConfig BRANCH simplifyParam REVISION DETAIL

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 72166. tcanabrava added a comment. - Port more header functions - Move CreateItemAcessors and CreateSignals - Remove indentation level - Move NonDPointerMembers and DPointerMembers REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

Re: D26126: Simplify param method: Return Early, Use a Map and Assert.

I’m not. I’m concerned that the introduction of thread safety by adding a static member will make the compiler slower. On Mon, 23 Dec 2019 at 15:42 Aleix Pol Gonzalez wrote: > apol added a comment. View Revision > > Why are you concerned about thread safety

D26126: Simplify param method: Return Early, Use a Map and Assert.

tcanabrava added a subscriber: GB_2. tcanabrava added a comment. I’m not. I’m concerned that the introduction of thread safety by adding a static member will make the compiler slower. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26126 To: tcanabrava Cc: GB_2,

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 72171. tcanabrava added a comment. - Finish header / Move basename to the ParameterConfiguration REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=72166=72171 BRANCH megaRefactor REVISION DETAIL

D26867: New class: KConfigTypeInformation

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY This class handles transformations and queries for xml types to cpp types. Use KConfigTypeInformation to

D26867: New class: KConfigTypeInformation

tcanabrava updated this revision to Diff 74231. tcanabrava added a comment. - Fix position of reference on parameter REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26867?vs=74224=74231 BRANCH rewrite_maps REVISION DETAIL

D26868: Move newItem to private method in KConfigSourceGenerator

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY This is only used here, should only be exposed here. TEST PLAN Run unittests REPOSITORY R237 KConfig

D26368: Add an isImmutable to know if a property is immutable

tcanabrava added a comment. I like it, but considering that this adds a new method, I'd like to see it exposed to Qml too o the generated code if GenerateProperties is set to true, currently we write this kind of code in Qml: enabled:

D26876: Remove the Enum hack: finish lists with a comma, it's valid c++

tcanabrava updated this revision to Diff 74596. tcanabrava marked an inline comment as done. tcanabrava added a comment. - Use qAsConst REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26876?vs=74253=74596 BRANCH remove_enum_hack REVISION DETAIL

D26876: Remove the Enum hack: finish lists with a comma, it's valid c++

tcanabrava added a comment. update / rebased. INLINE COMMENTS > ervin wrote in KConfigHeaderGenerator.cpp:252 > I lost track of constness here so I might be wrong, shouldn't this use > qAsConst in this context? yeah. REPOSITORY R237 KConfig BRANCH remove_enum_hack REVISION DETAIL

D26368: Add an isImmutable to know if a property is immutable

tcanabrava added a comment. it's a +1 for me. @dfaure and @ervin ? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26368 To: meven, ervin, #frameworks Cc: dfaure, tcanabrava, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26868: Move newItem to private method in KConfigSourceGenerator

tcanabrava added a comment. In D26868#602162 , @kossebau wrote: > In D26868#602150 , @dfaure wrote: > > > There is indeed a QString overload for concatenating QLatin1String, but it will have to be

D26126: Simplify param method: Return Early, Use a Map and Assert.

tcanabrava abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26126 To: tcanabrava, ervin, dfaure Cc: dfaure, ervin, GB_2, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D26128: Simplify defaultValue method: Return Early, Use Default Initialization, and Assert.

tcanabrava abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26128 To: tcanabrava, ervin Cc: ervin, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26130: Simplify return logic

tcanabrava abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26130 To: tcanabrava, patrickelectric, ervin Cc: ervin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26127: Simplify cppType method: Return Early, Use a Map and Assert.

tcanabrava abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26127 To: tcanabrava, ervin Cc: ervin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26129: Remove Iterator based loops for range based loops

tcanabrava abandoned this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26129 To: tcanabrava, ervin Cc: ervin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26868: Move newItem to private method in KConfigSourceGenerator

tcanabrava updated this revision to Diff 74600. tcanabrava added a comment. - Fix code style REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26868?vs=74234=74600 BRANCH simplify_newEntry REVISION DETAIL https://phabricator.kde.org/D26868 AFFECTED

D26133: Enable Auto Save

tcanabrava added a comment. > That's why personally I think it's fine to assume people need to opt-in for GenerateProperties if they want the feature, it's closely related after all. I disagree here. my application can be a simple QWidget based and have a KConfigXT enabled

Re: D26877: Simplify calls to whitespace() and use it in more places.

I like indentedStream. On Sun, 2 Feb 2020 at 11:36 David Faure wrote: > dfaure requested changes to this revision. > dfaure added a comment. > This revision now requires changes to proceed. View Revision > > > I don't like it either. It doesn't "read" well.

D26877: Simplify calls to whitespace() and use it in more places.

tcanabrava added a subscriber: ervin. tcanabrava added a comment. I like indentedStream. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26877 To: tcanabrava, dfaure, ervin Cc: ervin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26131: Braces around for, break early.

tcanabrava updated this revision to Diff 74258. tcanabrava added a comment. - use std::any_of REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26131?vs=71913=74258 BRANCH arcpatch-D26131 REVISION DETAIL https://phabricator.kde.org/D26131 AFFECTED

D26877: Simplify calls to whitespace() and use it in more places.

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY whitespace now returns a textStream so we don't need to stream() << whitespace() Use whitespace where we had

D26876: Remove the Enum hack: finish lists with a comma, it's valid c++

tcanabrava created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. tcanabrava requested review of this revision. TEST PLAN Run tests REPOSITORY R237 KConfig BRANCH remove_enum_hack REVISION DETAIL https://phabricator.kde.org/D26876

D26876: Remove the Enum hack: finish lists with a comma, it's valid c++

tcanabrava added reviewers: ervin, dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26876 To: tcanabrava, ervin, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26868: Move newItem to private method in KConfigSourceGenerator

tcanabrava added reviewers: ervin, dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26868 To: tcanabrava, ervin, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26877: Simplify calls to whitespace() and use it in more places.

tcanabrava added reviewers: dfaure, ervin. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26877 To: tcanabrava, dfaure, ervin Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26867: New class: KConfigTypeInformation

tcanabrava added reviewers: ervin, dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26867 To: tcanabrava, ervin, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26131: Braces around for, break early.

tcanabrava added reviewers: ervin, dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26131 To: tcanabrava, ervin, dfaure Cc: ervin, patrickelectric, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26133: Enable Auto Save

tcanabrava added a comment. I agree with the comments, but I'm a bit lost on how to implement that in KCoreConfigSkeleton: the isSaveNeeded reads the value of the variable and return if it's different from the reference variable. (that I tougth it was a reference *value*, to find out that

D26961: Be more helpfully verbose when we can't start an action

tcanabrava accepted this revision. This revision is now accepted and ready to land. REPOSITORY R283 KAuth BRANCH master REVISION DETAIL https://phabricator.kde.org/D26961 To: davidedmundson, tcanabrava Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26573: Add missing Import Env Variable

This revision was automatically updated to reflect the committed changes. Closed by commit R240:ee0531749057: Add missing Import Env Variable (authored by tcanabrava). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26573?vs=74512=74513 REVISION

D26573: Add missing Import Env Variable

tcanabrava updated this revision to Diff 74512. tcanabrava added a comment. - Fix Variable REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26573?vs=73237=74512 BRANCH add_missing_env_var REVISION DETAIL https://phabricator.kde.org/D26573

D26573: Add missing Import Env Variable

tcanabrava created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. tcanabrava requested review of this revision. REVISION SUMMARY Without this, in Qt 5.14 I get an android-like QQC2 theme This used to work on Qt

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73290. tcanabrava added a comment. - Rebase on master REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=72715=73290 BRANCH arcpatch-D26202 REVISION DETAIL https://phabricator.kde.org/D26202 AFFECTED

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73310. tcanabrava added a comment. - Fix whitespace on the reference code / genreator REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=73301=73310 BRANCH arcpatch-D26202 REVISION DETAIL

D26202: WIP: Refactor KConfigXT

tcanabrava added a comment. Looking at the review you it's a bis strange to see that I'v touched some test reference generated code, I did this only on *whitespace only changes* where the new whitespace made more sense than the old one. there is *one* bug I havent fixed on this code that I

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73292. tcanabrava added a comment. - Fix many small whitespace issues REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=73290=73292 BRANCH arcpatch-D26202 REVISION DETAIL

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73301. tcanabrava added a comment. - More whiteespaces fixed - Fix *space only* issues with the test reference headers - More whitespace fixes, only six files to go - Way more tests passing - space fixes REPOSITORY R237 KConfig CHANGES SINCE

D26202: WIP: Refactor KConfigXT

tcanabrava added inline comments. INLINE COMMENTS > tcanabrava wrote in kconfig_compiler.cpp:753 > that was a bit harder than I want, but done. Inside of the code generation > there was code that manipulated the ParseResult. I think this is one of the > good spots that show that this rewrite

D26202: WIP: Refactor KConfigXT

tcanabrava marked 8 inline comments as done. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26202: WIP: Refactor KConfigXT

tcanabrava marked 22 inline comments as done. tcanabrava added inline comments. INLINE COMMENTS > dfaure wrote in kconfigcompiler_test.cpp:129 > Why did you remove this? It's just a more user-friendly version of the > QVERIFY on the next line, so it can't possibly have failed while the next >

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73336. tcanabrava marked 4 inline comments as done. tcanabrava added a comment. - Rename KConfigCodeGenerator to KconfigCodeGeneratorBase - Simplify diff file saving - Add License Headers - Documentation, Privatization, Unused method / variable

D26202: WIP: Refactor KConfigXT

tcanabrava marked an inline comment as done. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26202 To: tcanabrava, #frameworks, ervin, bport, dfaure Cc: bport, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73608. tcanabrava added a comment. - Rebase REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=73557=73608 BRANCH arcpatch-D26202 REVISION DETAIL https://phabricator.kde.org/D26202 AFFECTED FILES

D26202: WIP: Refactor KConfigXT

tcanabrava added inline comments. INLINE COMMENTS > dfaure wrote in kconfigcompiler_test.cpp:129 > OK, this needs a hint for the person debugging regressions then. Something > like > > QVERIFY2(content == contentRef, "Failure, see foo.diff"); This is done now within the appendFileDiff

D26202: WIP: Refactor KConfigXT

This revision was automatically updated to reflect the committed changes. Closed by commit R237:98c32e29f504: WIP: Refactor KConfigXT (authored by tcanabrava). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26202?vs=73608=73688 REVISION DETAIL

D26751: ECMAddAppIcon: Add sc in regex to extract extension from valid names

tcanabrava accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH sc_appicon REVISION DETAIL https://phabricator.kde.org/D26751 To: patrickelectric, tcanabrava Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2,

D26202: WIP: Refactor KConfigXT

tcanabrava updated this revision to Diff 73846. tcanabrava added a comment. - Revert "Revert "WIP: Refactor KConfigXT"" - Add Reference files for Broken KDevelop Configuration - Fix generating of empty configuration files REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D26752: ECMAddAppIcon: Do not warn about mac icons if isnt a mac build

tcanabrava accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH warning_icons REVISION DETAIL https://phabricator.kde.org/D26752 To: patrickelectric, apol, tcanabrava Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n,

D26202: WIP: Refactor KConfigXT

tcanabrava added a comment. who knew? This actually was not a false positive: the kdevelop build failure was a bug in kdevelop. I already opened a ticket: https://invent.kde.org/kde/kdevelop/merge_requests/90 but at the same time I added code to handle the case of broken / empty

D26202: WIP: Refactor KConfigXT

tcanabrava added a comment. Aparently the kmymoney issue was the same: empty kconfig file. I just successfully compiled kdevelop and kmymoney. I'll let the computer to compile the whole kde applications from scratch tonigth to see if it will fail somewhere. REPOSITORY R237 KConfig

  1   2   >