D19049: Namespace find_file call

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY KAuth uses the same name, getting our cached result then. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETA

D19054: Port cross-compilation support to KF5_HOST_TOOLING

vkrause created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This is more consistent with this is done in other frameworks, and more importantly it w

D19054: Port cross-compilation support to KF5_HOST_TOOLING

vkrause added a comment. In D19054#413147 , @ltoscano wrote: > I trust @vkrause that this complicated part works, but I need to ask @habacker too, as he contributed part of the cross-compiling code. > > If anyone else from the #windows

D19048: Namespace find_file result

This revision was automatically updated to reflect the committed changes. Closed by commit R283:22b9884a55f0: Namespace find_file result (authored by vkrause). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19048?vs=51784&id=51843 REVISION DETAIL https://phab

D19049: Namespace find_file call

This revision was automatically updated to reflect the committed changes. Closed by commit R244:c9f878d46878: Namespace find_file call (authored by vkrause). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19049?vs=51785&id=51844 REVISION DETAIL https://

D18947: Bring FindUDev.cmake up to ECM standards

vkrause updated this revision to Diff 51845. vkrause added a comment. Add IMPORTED_COMPILE_DEFINITIONS property. REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18947?vs=51485&id=51845 BRANCH arcpatch-D18947 REVISION DETAIL https://phabricator.kde.org/D1

D18947: Bring FindUDev.cmake up to ECM standards

vkrause updated this revision to Diff 51848. vkrause added a comment. Fix typos. REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18947?vs=51845&id=51848 BRANCH arcpatch-D18947 REVISION DETAIL https://phabricator.kde.org/D18947 AFFECTED FILES CMakeList

D18943: Add Fontconfig find modudle

vkrause updated this revision to Diff 51849. vkrause added a comment. Search for pkgconfig quietly. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18943?vs=51524&id=51849 BRANCH arcpatch-D18943 REVISION DETAIL https://phabricator.kde.org/D

D18947: Bring FindUDev.cmake up to ECM standards

This revision was automatically updated to reflect the committed changes. Closed by commit R245:7464b55f0638: Bring FindUDev.cmake up to ECM standards (authored by vkrause). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18947?vs=51848&id=51853 REVISION DETAIL

D19005: android: don't default to gcc anymore

vkrause added a comment. In D19005#414313 , @apol wrote: > In D19005#412258 , @vkrause wrote: > > > Actually having tested this, "deprecated_value" looks wrong there, shouldn't this be "default_valu

D19223: Fix releaseme checkout when this is included in a sub-directory

vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This fixes the Marble build on binary factory. REPOSITORY R240 Extra CMake Modules BRAN

D19223: Fix releaseme checkout when this is included in a sub-directory

This revision was automatically updated to reflect the committed changes. Closed by commit R240:6daec3f14576: Fix releaseme checkout when this is included in a sub-directory (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1922

D19054: Port cross-compilation support to KF5_HOST_TOOLING

This revision was automatically updated to reflect the committed changes. Closed by commit R238:d6ccdc0fff46: Port cross-compilation support to KF5_HOST_TOOLING (authored by vkrause). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19054?vs=51797&id=52360 RE

D18731: Replace KIconThemes dependency with equivalent QIcon usage

This revision was automatically updated to reflect the committed changes. Closed by commit R294:d29a5d644913: Replace KIconThemes dependency with equivalent QIcon usage (authored by vkrause). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18731?vs=50870&id=

D19215: Install DefinitionDownloader header

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19215 To: davschul, cullmann, vkrause Cc: dhaumann, kwrite-devel, kde-frameworks-devel, bmortimer, domson, michaelh, genethomas,

D19286: Add unit test for definitionsForFileName() and definitionsForMimeType()

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH test-definitions-getters REVISION DETAIL https://phabricator.kde.org/D19286 To: dhaumann, cullmann, davschul, vkrause Cc: kwrite-devel, kde-frameworks-devel, domson,

D19432: [text thumbnailer] Use KSyntaxHighlighting for text rendering

vkrause added inline comments. INLINE COMMENTS > kossebau wrote in textcreator.cpp:169 > @vkrause Can you help here and tell what one is intended to use? I think default background color here refers to what your palette gives you. The background color defined by highlighting is typically only u

D19453: Fix repository deletion warning

vkrause created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. vkrause requested review of this revision. REVISION SUMMARY Since 6166da75 the inval

D18943: Add Fontconfig find modudle

vkrause added a comment. ping? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18943 To: vkrause Cc: kossebau, apol, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

Re: [reposted from kde-devel] Building KDE statically

On Saturday, 2 March 2019 00:23:38 CET Jonathan Schultz wrote: > If anyone is interested, here is a brief report on something I have been > working on in my spare time. > > TLDR: Here are some scripts to build KDE frameworks and okular statically > using gcc/musl and cross-building for mingw: > ht

D19453: Fix repository deletion warning

This revision was automatically updated to reflect the committed changes. Closed by commit R216:29e081b94b84: Fix repository deletion warning (authored by vkrause). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19453?vs=52919&id=52943 REVISION DE

D19486: Add UDev find module

vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This one is originally coming from Solid, but there are several more copies in our reposi

D18943: Add Fontconfig find modudle

This revision was automatically updated to reflect the committed changes. Closed by commit R240:e3b6c8708c48: Add Fontconfig find modudle (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18943?vs=51849&id=53050#toc REPOSITORY R240 Extra CMake Modules CHANGES SINCE

D19486: Add UDev find module

vkrause updated this revision to Diff 53055. vkrause added a comment. Add backward compatibility variables. REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19486?vs=53047&id=53055 BRANCH master REVISION DETAIL https://phabricator.kde.org/D1

D18943: Add Fontconfig find modudle

vkrause added a comment. In D18943#423969 , @matthieugras wrote: > This commit breaks plasma-desktop compilation for me (on ubuntu && arch => undefined refrence in plasma-desktop/kcms/kfontinst). Confirmed on a clean rebuild here too. So

D18943: Add Fontconfig find modudle

vkrause added a comment. D19499 fixes that here REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18943 To: vkrause, cgiboudeaux Cc: matthieugras, kossebau, apol, cgiboudeaux, kde-frameworks-devel, kde-buildsystem, mich

D19499: Restore FindFontconfig backward compatibility for plasma-desktop

vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY I don't understand where plasma-desktop actually finds that old find module, but this fix

D19499: Restore FindFontconfig backward compatibility for plasma-desktop

This revision was automatically updated to reflect the committed changes. Closed by commit R240:514835418c9d: Restore FindFontconfig backward compatibility for plasma-desktop (authored by vkrause). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D194

D18943: Add Fontconfig find modudle

vkrause added a comment. In D18943#424041 , @kossebau wrote: > In D18943#424029 , @vkrause wrote: > > > What I don't understand though is which FindFontconfig this used to find, there is non in plas

D19486: Add UDev find module

This revision was automatically updated to reflect the committed changes. Closed by commit R240:8999b7bd6f6d: Add UDev find module (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19486?vs=53055&id=53160#toc REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UP

D19527: Remove find modules provided by ECM

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This matters specifically here as kdelibs4support installs them and adds them to the module search path, which can int

D19527: Remove find modules provided by ECM

vkrause updated this revision to Diff 53218. vkrause added a comment. Also remove FindPulseAudio. The Sasl2 one misses compatibility variables in ECM it seems. REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19527?vs=53163&id=53218 BRANCH master

D19532: Don't crash when no contexts are present

vkrause added a comment. In D19532#425432 , @cullmann wrote: > Ok with that. > Volker, ok, too? > I think the if(...isLoaded) removal is a diff artifact, that was never in the original code bug just in the first try here. Yep, repla

D19581: Fix build with cmake < 3.7

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D19581 To: wbauer, vkrause Cc: kwrite-devel, kde-frameworks-devel, cullmann, gennad, bmortimer, domson, michaelh, genethomas, ngra

D19652: Add cross-compilation support for kpackagetool5

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R290 KPackage BRANCH master REVISION DETAIL https://phabricator.kde.org/D19652 AFFECTED FILES CMakeLists.txt KF5Pac

D19652: Add cross-compilation support for kpackagetool5

This revision was automatically updated to reflect the committed changes. Closed by commit R290:d32f2d4e5ab2: Add cross-compilation support for kpackagetool5 (authored by vkrause). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19652?vs=53590&id=53680 REVISI

D19697: Fixes the build failure when using ECM Android toolchain

vkrause added a comment. Are we sure this doesn't need to be conditional on the API level? Ie. only have those dummy declarations available on API levels before they were introduced on Android? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D19697 To: sh-zam Cc

D19697: Fixes the build failure when using ECM Android toolchain

vkrause added a comment. The CI is building this successfully though, with API level 21: https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20AndroidQt5.12/ REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D19697 To: sh-zam Cc: vkrause, apol, kde-fra

D19697: Fixes the build failure when using ECM Android toolchain

vkrause added a comment. I can reproduce with -DCMAKE_ANDROID_API=26 here, while anything below builds fine. This seems to fix it: diff --git a/src/lib/util/kuser_unix.cpp b/src/lib/util/kuser_unix.cpp index c42ea99..216dfb7 100644 --- a/src/lib/util/kuser_unix.cpp +++ b/src

D19697: Fixes the build failure when using ECM Android toolchain

vkrause added a comment. Are you sure? pwd.h of the NDK contains the following here: #if __ANDROID_API__ >= 26 struct passwd* getpwent(void) __INTRODUCED_IN(26); void setpwent(void) __INTRODUCED_IN(26); void endpwent(void) __INTRODUCED_IN(26); #endif /* __ANDROID_API

D19734: Fix compilation with Android API level >= 26

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Starting with API level 26, these methods are actually available and we don't need our dummy declarations anymore. RE

D19734: Fix compilation with Android API level >= 26

This revision was automatically updated to reflect the committed changes. Closed by commit R244:35b0d2adf013: Fix compilation with Android API level >= 26 (authored by vkrause). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19734?vs=53814&id=53901 REVISI

D19891: Use https for the pastebin backend and publicly accessible documentation

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D19891 AFFECTED FILES README.md src/

D19895: Use https for links in the UI and documentation

vkrause created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D19895 AFFECTED FILES

D19891: Use https for the pastebin backend and publicly accessible documentation

This revision was automatically updated to reflect the committed changes. Closed by commit R495:fbd859319a80: Use https for the pastebin backend and publicly accessible documentation (authored by vkrause). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D19895: Use https for links in the UI and documentation

vkrause updated this revision to Diff 54435. vkrause added a comment. Update konqueror.org link. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19895?vs=54356&id=54435 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19895 AFFECTED FILES docs

D19990: Switch URLs to https

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Also remove two apparently dead services from the KMoreTools preset. REPOSITORY R304 KNewStuff BRANCH master REVI

D19992: Update URLs to use https

vkrause created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY I haven't touched affected localized content in here, assuming that will be updated via

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This is supposed to trigger a unit test failure when using http: rather than https: URLs.

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

vkrause added inline comments. INLINE COMMENTS > cgiboudeaux wrote in KDECMakeSettings.cmake:189 > FindPython3.cmake only exists in CMake >= 3.12.0 Right, the feature is just silently ignored in older versions. We can probably switch that to PythonIterp if we want this for older versions as wel

D19996: WIP Add a global test for insecure http: URLs used in code or documentation

vkrause added inline comments. INLINE COMMENTS > cgiboudeaux wrote in KDECMakeSettings.cmake:189 > PythonInterp is also not a solution :) See 6c1db934e > > in ki18n. > > CMake 3.5.0 was found acceptable for most framew

D19992: Update URLs to use https

vkrause updated this revision to Diff 54626. vkrause added a comment. Update build from source link. REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19992?vs=54600&id=54626 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19992 AFFECTED FI

D19992: Update URLs to use https

This revision was automatically updated to reflect the committed changes. Closed by commit R238:b690b99104e3: Update URLs to use https (authored by vkrause). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19992?vs=54626&id=54643 REVISION DETAIL https://ph

D19895: Use https for links in the UI and documentation

This revision was automatically updated to reflect the committed changes. Closed by commit R241:a2ac37917303: Use https for links in the UI and documentation (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19895?vs=54435&id=54648 REVISION DE

D19978: Allow to set custom hints for notifications

vkrause added a comment. Technically this looks ok to me, might be useful to have a little bit more context in the documentation and/or commit message though REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D19978 To: nicolasfella, broulik Cc: vkrause, kde-fram

D19978: Allow to set custom hints for notifications

vkrause added a comment. +1 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D19978 To: nicolasfella, broulik Cc: vkrause, kde-frameworks-devel, michaelh, ngraham, bruns

D20018: Update URLs to use https

vkrause created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Largely using the tools from D19996 . REPOSITORY R2

D20018: Update URLs to use https

vkrause updated this revision to Diff 54798. vkrause added a comment. Integrate review comments. REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20018?vs=54674&id=54798 BRANCH arcpatch-D20018 REVISION DETAIL https://phabricator.kde.org/D20018 AFFECTED

D20018: Update URLs to use https

This revision was automatically updated to reflect the committed changes. Closed by commit R264:ca4cca65c756: Update URLs to use https (authored by vkrause). REPOSITORY R264 KApiDox CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20018?vs=54798&id=54801 REVISION DETAIL https://phab

D19990: Switch URLs to https

vkrause added a comment. Yep, those were checked, which is also why some of those are still on http. See also D19996 for the tools used for this. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D19990 To: vkrau

D19990: Switch URLs to https

This revision was automatically updated to reflect the committed changes. Closed by commit R304:b05ec5ed5c0c: Switch URLs to https (authored by vkrause). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19990?vs=54598&id=54943#toc REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE htt

Re: CI system maintainability

On Thursday, 28 March 2019 09:50:47 CET Kevin Ottens wrote: > Hello, > > On Thursday, 28 March 2019 09:41:29 CET Luca Beltrame wrote: > > In data giovedì 28 marzo 2019 09:29:22 CET, Kevin Ottens ha scritto: > > > at your screen or pair with you" in the past. Clearly this compromise > > > gets > >

Re: CI system maintainability

On Thursday, 28 March 2019 16:32:34 CET Luca Beltrame wrote: > In data giovedì 28 marzo 2019 15:15:23 CET, Nate Graham ha scritto: > > In this case, it seems like the problem is that there are certain > > individuals or teams that are pushing risky, breaking changes without code > > review, and the

Re: CI system maintainability

On Thursday, 28 March 2019 16:11:12 CET Friedrich W. H. Kossebau wrote: > Am Donnerstag, 28. März 2019, 14:33:59 CET schrieb laurent Montel: > > For example I works all days on kde (pim or other) when I wake up, or at > > noon after my lunch or the evening, I will not wait several days for a > > re

Re: CI system maintainability

On Friday, 29 March 2019 08:59:59 CET Kevin Ottens wrote: > On Thursday, 28 March 2019 21:53:06 CET Alexander Neundorf wrote: > > Having mandatory reviews for a central and complex component like akonadi > > looks like a very good and obvious idea. > > Yep. Looking at the 18.12 -> 19.04 timeframe

Re: CI system maintainability

On Friday, 29 March 2019 20:54:54 CET Ben Cooksley wrote: > On Fri, Mar 29, 2019 at 6:45 AM Johannes Zarl-Zierl > > I fear that a mandatory reviews would add too juch strain on smaller > > teams. If there's just one person with an intimate knowledge of the > > code-base, plus two co-developers, the

D20127: Fix finding the host tools targets file in the Android docker environment

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This worked on Yocto, the Android setup is apparently a bit more picky. Same approach is taken by KCoreAddons too. RE

D20127: Fix finding the host tools targets file in the Android docker environment

This revision was automatically updated to reflect the committed changes. Closed by commit R290:cee6a3d1755d: Fix finding the host tools targets file in the Android docker environment (authored by vkrause). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20127

D19527: Remove find modules provided by ECM

This revision was automatically updated to reflect the committed changes. Closed by commit R239:48d9c36738d0: Remove find modules provided by ECM (authored by vkrause). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19527?vs=53218&id=55113 REVISION DE

D20158: Allow to set urgency for notifications

vkrause added a comment. Nicely fits with the Android backend too, although that has one extra level (low, medium, high, urgent). REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: kde-framew

D20158: Allow to set urgency for notifications

vkrause added a comment. I was looking at https://developer.android.com/training/notify-user/channels#importance which also has IMPORTANCE_LOW mapped to "medium". But yes, it's basically just about finding a suitable mapping, even if we don't cover every possible level on Android. REPOSITO

D20158: Allow to set urgency for notifications

vkrause added a comment. Yep, code looks good to me too, so +1 on this :) REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

New framework: KContacts

Hi, I'd like to propose KContacts for review to move from KDE PIM to KF5. KContacts is essentially an implementation of the vCard standard, covering the data model as well as parsing and creating of vCard files. As the recent CI issue showed it's used outside of KDE PIM as well, therefore we wo

New framework: KCalCore

Hi, I'd like to propose KCalCore for review to move from KDE PIM to KF5. KCalCore is an implementation of the iCalendar standard based on libical, covering the data model, input/output and the rather complex recurrence algorithms defined in that standard. It's used outside of KDE PIM as well,

D20158: Allow to set urgency for notifications

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20158 To: broulik, #plasma, #frameworks, vkrause, ogoffart, mck182 Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D20374: [KNotifications] Update when flags, urls, or urgency change

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20374 To: broulik, #plasma, vkrause Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: New framework: KContacts

Thanks for having a look at this Albert! On Sunday, 7 April 2019 18:46:46 CEST Albert Astals Cid wrote: > El dissabte, 6 d’abril de 2019, a les 18:01:09 CEST, Volker Krause va escriure: > > Hi, > > > > I'd like to propose KContacts for review to move from KDE PIM

Re: New framework: KCalCore

On Sunday, 7 April 2019 18:54:19 CEST Albert Astals Cid wrote: > El diumenge, 7 d’abril de 2019, a les 14:45:09 CEST, Volker Krause va escriure: > > Hi, > > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > Does exceptions.h need a d-p

Re: New framework: KCalCore

On Sunday, 7 April 2019 16:24:13 CEST Alexander Potashev wrote: > вс, 7 апр. 2019 г. в 15:45, Volker Krause : > > Hi, > > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > > > KCalCore is an implementation of the iCalendar stand

Re: New framework: KContacts

On Tuesday, 9 April 2019 03:11:57 CEST Aleix Pol wrote: > On Sat, Apr 6, 2019 at 6:02 PM Volker Krause wrote: > > Hi, > > > > I'd like to propose KContacts for review to move from KDE PIM to KF5. > > > > KContacts is essentially an implementation of the

Re: New framework: KCalCore

On Monday, 8 April 2019 02:44:46 CEST Alexander Potashev wrote: > вс, 7 апр. 2019 г. в 17:24, Alexander Potashev : > > вс, 7 апр. 2019 г. в 15:45, Volker Krause : > > > Hi, > > > > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. &

Re: grantlee commit access

On Monday, 15 April 2019 23:20:58 CEST David Faure wrote: > Thanks for the merge of the Qt 5.13 build fix. > > I would certainly welcome grantlee as a KF5 framework, I think it makes > things easier from a KDE point of view, and it reduces the bus factor in > terms of who can actually push to the

Re: New framework: KCalCore

On Sunday, 14 April 2019 13:31:41 CEST David Faure wrote: > On dimanche 7 avril 2019 14:45:09 CEST Volker Krause wrote: > > Hi, > > > > I'd like to propose KCalCore for review to move from KDE PIM to KF5. > > > > KCalCore is an implementation of the iCale

Re: New framework: KCalCore

On Sunday, 14 April 2019 20:30:07 CEST Alexander Potashev wrote: > вт, 9 апр. 2019 г. в 20:10, Volker Krause : > > On Sunday, 7 April 2019 16:24:13 CEST Alexander Potashev wrote: > > > вс, 7 апр. 2019 г. в 15:45, Volker Krause : > > > > Hi, > > > > >

D20158: Allow to set urgency for notifications

vkrause added a comment. In D20158#452099 , @broulik wrote: > @vkrause I just noticed xdg portal notification spec (the ones used for sandboxed flatpak apps) has four urgency levels: low, normal, *high*, critical. > Do you think it would be us

D20648: [KNotification] Add HighUrgency

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D20648 To: broulik, #frameworks, dfaure, vkrause, ogoffart, nicolasfella Cc: kde-frameworks-devel,

D13358: Add new class that is a model of numbers between two values

vkrause added a comment. ping? this is needed for scratch/davidedmundson/kirigami-addons REPOSITORY R275 KItemModels BRANCH master REVISION DETAIL https://phabricator.kde.org/D13358 To: davidedmundson, vkrause Cc: broulik, markg, kde-frameworks-devel, michaelh, ngraham, bruns

D20766: Use appropriate background color for text previews

vkrause added subscribers: cullmann, dhaumann. vkrause added a comment. In D20766#454891 , @kossebau wrote: > So, switching also the Plasma Theme to "Breeze Dark", I started to be able to reproduce: seems that the default text color is influenced

Deprecating KDEWebKit?

Hi, I have recently seen a several people in #kde-devel struggling with doing the recommended kdesrc-build based frameworks build due to kdewebkit failing. That's not really surprising as getting the necessary QtWebKit isn't actually trivial as it's no longer officially released, and unofficial

D20939: Aztec: Fix padding if the last partial codeword is all one bits

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY Wikipedia says "after bit stuffing, the data string is padded to the next codeword boundary by appending 1 bits. If th

D20939: Aztec: Fix padding if the last partial codeword is all one bits

vkrause added reviewers: svuorela, nicolasfella. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D20939 To: vkrause, svuorela, nicolasfella Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20939: Aztec: Fix padding if the last partial codeword is all one bits

This revision was automatically updated to reflect the committed changes. Closed by commit R280:608370e85a77: Aztec: Fix padding if the last partial codeword is all one bits (authored by vkrause). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20939?vs=57321&id

D21328: Add qml import for KItemModels

vkrause added a comment. +1 too, having the QML bindings as part of the corresponding framework is IMHO the way to go, compared to the KDeclarative approach. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D21328 To: davidedmundson Cc: vkrause, apol, kde-framewor

D21368: Add syntax definition for the Common Intermediate Language

vkrause created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. vkrause requested review of this revision. REVISION SUMMARY Nothing fancy, a lot of details could probably improved, e.g. regarding the use of '.' as delimiter

D21368: Add syntax definition for the Common Intermediate Language

This revision was automatically updated to reflect the committed changes. Closed by commit R216:70a9e380e3b2: Add syntax definition for the Common Intermediate Language (authored by vkrause). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21368?vs=

D21400: Downgrade KDEWebKit from Tier 3 to Porting Aids

vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY QtWebKit is dead, even the "revived" version has no changes since more than a year. REPOSITORY R300 KDEWebKit BRAN

D21681: ECMPackageConfigHelpers -> CMakePackageConfigHelpers

vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D21681 To: aacid, vkrause Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D5338: Add syntax highlighting file for Doxyfile

vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Thank you, was missing this as well :) Just one nitpick: please make the license attribute more precise, e.g. "LGPLv2+". And if you happen to have a file around you can share, please add

D5344: Relax constraints for processing QGroupBoxes

vkrause created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY So far this was only accepting QGroupBoxes containing only auto-exclusive buttons. Now we also accept QGroupBoxes that contain non-buttons,

D5344: Relax constraints for processing QGroupBoxes

vkrause closed this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D5344 To: vkrause, dvratil, dfaure Cc: #frameworks

<    1   2   3   4   5   6   7   8   9   10   >