D7297: Add Pony highlighting

2017-08-15 Thread jonathan poelen
jpoelen updated this revision to Diff 18194. jpoelen added a comment. Restricted Application added a project: Frameworks. - Pony: Support for attributes and best behavior for function definitions. Add license and removed autotests/foldingtest.pony REPOSITORY R216 Syntax Highlighting

D7297: Add Pony highlighting

2017-08-15 Thread jonathan poelen
jpoelen updated this revision to Diff 18196. jpoelen added a comment. Pony: Support for attributes and best behavior for function definitions. Add license and removed autotests/foldingtest.pony REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D7297: Add Pony highlighting

2017-08-13 Thread jonathan poelen
jpoelen added a reviewer: Framework: Syntax Hightlighting. jpoelen edited projects, added Framework: Syntax Hightlighting; removed Frameworks. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7297 To: jpoelen, #framework_syntax_hightlighting Cc: #frameworks,

D7297: Add Pony highlighting

2017-08-13 Thread jonathan poelen
jpoelen created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R216 Syntax Highlighting BRANCH pony REVISION DETAIL https://phabricator.kde.org/D7297 AFFECTED FILES

D6288: isocpp.xml: replace P printf-like format with p

2017-08-13 Thread jonathan poelen
jpoelen abandoned this revision. jpoelen added a comment. This commit is already merged. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6288 To: jpoelen Cc: #frameworks

D6328: add unit test for isocpp

2017-06-21 Thread jonathan poelen
jpoelen created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R216 Syntax Highlighting BRANCH ioscpp-test REVISION DETAIL https://phabricator.kde.org/D6328 AFFECTED FILES

D6288: isocpp.xml: replace P printf-like format with p

2017-06-19 Thread jonathan poelen
jpoelen created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY 'P' format does not exist, 'p' format is missing. TEST PLAN printf("%p", pointer); REPOSITORY R216 Syntax Highlighting BRANCH

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

2017-06-06 Thread jonathan poelen
jpoelen updated this revision to Diff 15238. jpoelen edited the summary of this revision. jpoelen added a comment. - Update test reference data REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6128?vs=15237=15238 BRANCH upstream REVISION

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

2017-06-06 Thread jonathan poelen
jpoelen updated this revision to Diff 15239. jpoelen added a comment. Previous diff on bad branch REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6128?vs=15238=15239 BRANCH upstream REVISION DETAIL https://phabricator.kde.org/D6128

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

2017-06-06 Thread jonathan poelen
jpoelen updated this revision to Diff 15240. jpoelen added a comment. - cmake test: add an expression with nested parenthesis REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6128?vs=15239=15240 BRANCH upstream REVISION DETAIL

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

2017-06-06 Thread jonathan poelen
jpoelen added a reviewer: Framework: Syntax Hightlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6128 To: jpoelen, #framework_syntax_hightlighting Cc: #frameworks

D6128: CMake: OR/AND not highlighted after expr in () If you type in "if((A AND B) OR C)", "OR" is not highlighted.

2017-06-06 Thread jonathan poelen
jpoelen created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R216 Syntax Highlighting BRANCH upstream REVISION DETAIL https://phabricator.kde.org/D6128 AFFECTED FILES data/syntax/cmake.xml To:

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

2017-06-06 Thread jonathan poelen
jpoelen retitled this revision from "CMake: OR/AND not highlighted after expr in () If you type in "if((A AND B) OR C)", "OR" is not highlighted." to "Bug 360656 - CMake: OR/AND not highlighted after expr in ()". jpoelen edited the summary of this revision. jpoelen edited the test plan for this

D12569: Pony: fix identifier and keyword

2018-04-27 Thread jonathan poelen
jpoelen created this revision. jpoelen added a reviewer: dhaumann. jpoelen added a project: Framework: Syntax Highlighting. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. jpoelen requested review of this revision. REVISION SUMMARY -

D12689: Lua: updated for Lua5.3

2018-05-13 Thread jonathan poelen
jpoelen added a comment. There is indeed a problem with Kate, but it works with KSyntaxHighlighting. I will look in what part of doxygenlua.xml the problem is. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D12689 To: jpoelen, dhaumann,

D12854: Awk: fix regex in a function and update syntax for gawk

2018-05-13 Thread jonathan poelen
jpoelen created this revision. jpoelen added a project: Framework: Syntax Highlighting. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jpoelen requested review of this revision. REVISION SUMMARY - fix `match(str, /it's a

D12854: Awk: fix regex in a function and update syntax for gawk

2018-05-13 Thread jonathan poelen
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D12854 To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, vkrause,

D12860: DoxygenLua: fix closing comment blocks

2018-05-13 Thread jonathan poelen
jpoelen edited the test plan for this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D12860 To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12860: DoxygenLua: fix closing comment blocks

2018-05-13 Thread jonathan poelen
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D12860 To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12860: DoxygenLua: fix closing comment blocks

2018-05-13 Thread jonathan poelen
jpoelen created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jpoelen requested review of this revision. REVISION SUMMARY Kate-editor needs the context to be marked dynamic to use a placeholder in a dynamic

D12854: Awk: fix regex in a function and update syntax for gawk

2018-05-13 Thread jonathan poelen
jpoelen updated this revision to Diff 34098. jpoelen added a comment. - Awk: add collating symbols and equivalence classes REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12854?vs=34076=34098 BRANCH awk REVISION DETAIL

D12689: Lua: updated for Lua5.3

2018-05-21 Thread jonathan poelen
jpoelen added a comment. @dhaumann The difference is in the `dynamic` attribute of a context. Kate propagates the captures only if the value is `true` whereas SyntaxHighlighting never looks at that value and only uses the `dynamic` attribute of the rules. Personally, I find that having

D13394: C++: update for c++20 and fix some syntax errors

2018-06-16 Thread jonathan poelen
jpoelen updated this revision to Diff 36229. jpoelen added a comment. - C++: test with clang:: in an attribute REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13394?vs=35729=36229 BRANCH cpp REVISION DETAIL

D13394: C++: update for c++20 and fix some syntax errors

2018-06-18 Thread jonathan poelen
jpoelen added inline comments. INLINE COMMENTS > dhaumann wrote in gcc.xml:576-577 > These can be WordDetect as well, right? It does not work because of ':'. But Putting it in `weakDeliminator` will break things. For this to work, it would need `additionalDeliminator` and `weakDeliminator`

D13395: Pony: fix single quote escape and a possible infinite loop with #

2018-06-06 Thread jonathan poelen
jpoelen created this revision. jpoelen added a reviewer: dhaumann. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix-pony REVISION

D13394: C++: update for c++20 and fix some syntax errors

2018-06-06 Thread jonathan poelen
jpoelen created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jpoelen requested review of this revision. REVISION SUMMARY - new keywords, attributes and standard macros - hexadecimal floatting point (c++17)

D13394: C++: update for c++20 and fix some syntax errors

2018-06-06 Thread jonathan poelen
jpoelen edited the summary of this revision. jpoelen added a reviewer: dhaumann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13394: C++: update for c++20 and fix some syntax errors

2018-06-23 Thread jonathan poelen
jpoelen added a comment. I do not have a developer account, but I can do it. This is not a problem because I will contribute again. REPOSITORY R216 Syntax Highlighting BRANCH cpp REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann, cullmann Cc: cullmann,

D13829: Lua: fix multi-line string

2018-07-01 Thread jonathan poelen
jpoelen created this revision. jpoelen added a reviewer: dhaumann. Restricted Application added a project: Frameworks. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. jpoelen requested review of this revision. REVISION SUMMARY Strings that end with

D12689: Lua: updated for Lua5.3

2018-05-03 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: dhaumann, Framework: Syntax Highlighting. jpoelen added projects: Framework: Syntax Highlighting, Frameworks. Restricted Application added a subscriber: Frameworks. jpoelen requested review of this revision. REVISION SUMMARY Add of: -

D10621: Highlighting Indexer: list of suggestions

2018-02-17 Thread jonathan poelen
jpoelen created this revision. jpoelen added a reviewer: dhaumann. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. jpoelen requested review of this revision. REVISION SUMMARY Proposes mergers of rules and the replacement of: -

D10621: Highlighting Indexer: list of suggestions

2018-02-17 Thread jonathan poelen
jpoelen added a project: Framework: Syntax Highlighting. jpoelen added a subscriber: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10621 To: jpoelen, dhaumann Cc: #framework_syntax_highlighting, dhaumann, #frameworks,

D10646: Support case-insensitive WordDetect

2018-02-19 Thread jonathan poelen
jpoelen added a comment. It seems that KTextEditor does not have the problem because KateHlWordDetect is based on KateHlStringDetect which uses the inSensitive parameter. INLINE COMMENTS > rule_p.h:249 > QString m_word; > +Qt::CaseSensitivity m_caseSensitivity; > }; Yes, but it

D10646: Support case-insensitive WordDetect

2018-02-18 Thread jonathan poelen
jpoelen created this revision. jpoelen added a reviewer: dhaumann. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH word_insensitive REVISION

D14434: add functions to access keywords

2018-07-27 Thread jonathan poelen
jpoelen added a comment. This follows https://mail.kde.org/pipermail/kde-frameworks-devel/2018-July/066564.html REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14434 To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: kde-frameworks-devel,

D14434: add functions to access keywords

2018-07-27 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: kwrite-devel. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting

D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting

2018-08-04 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. jpoelen requested review of this revision. REPOSITORY R216

D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting

2018-08-04 Thread jonathan poelen
jpoelen added a comment. Yes, I can start tomorrow. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14603 To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause Cc: cullmann, kwrite-devel, dhaumann, kde-frameworks-devel,

D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting

2018-08-04 Thread jonathan poelen
jpoelen added a comment. I copied all the keywords in the css.xml file and it's a shame. I think that Keyword could refer to those of other files with `##` as for IncludeRules. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14603 To: jpoelen,

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-08-05 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. jpoelen requested review of this revision. REVISION

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-08-05 Thread jonathan poelen
jpoelen edited the summary of this revision. jpoelen edited the test plan for this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14632 To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, vkrause,

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-08-06 Thread jonathan poelen
jpoelen added a comment. I just thought of `Definition::keywordLists()` which does not list the keywords used by this new syntax. - Should we add the lists used as and when parsing? - Move the functionality on the tag ``? (``, ` name##language `) - Other? REPOSITORY R216

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-08-06 Thread jonathan poelen
jpoelen edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14632 To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

2018-08-13 Thread jonathan poelen
jpoelen added a comment. There have been changes in the xml files that will cause conflicts. I would look in the next few days. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D11470 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc:

D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting

2018-08-13 Thread jonathan poelen
jpoelen added a comment. Ok, i'm doing this in the week. REPOSITORY R216 Syntax Highlighting BRANCH scss REVISION DETAIL https://phabricator.kde.org/D14603 To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause, cullmann Cc: cullmann, kwrite-devel, dhaumann,

D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting

2018-08-19 Thread jonathan poelen
jpoelen added a comment. Yes, my compilation folder was pointing to my fork on github from which I make the patches (as I do not have the right version for ECM, I have a script that does among other things a new CMakeLists.txt in another folder and adds symbolic links for project files).

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

2018-08-19 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:3ebb3c09e512: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle) (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11470?vs=32861=40010#toc

D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting

2018-08-19 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:113ebe28645a: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14603?vs=39067=40004#toc REPOSITORY

D14137: CSS: update syntax and fix some errors

2018-07-15 Thread jonathan poelen
jpoelen created this revision. jpoelen added a reviewer: dhaumann. jpoelen added projects: Frameworks, Framework: Syntax Highlighting. Restricted Application added a project: Kate. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. jpoelen

D14137: CSS: update syntax and fix some errors

2018-07-16 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:423239c45ec5: CSS: update syntax and fix some errors (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14137?vs=37815=37912

D14137: CSS: update syntax and fix some errors

2018-07-16 Thread jonathan poelen
jpoelen added a comment. It is done. So much emotion :') REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14137 To: jpoelen, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause,

D13394: C++: update for c++20 and fix some syntax errors

2018-07-14 Thread jonathan poelen
jpoelen added a comment. Thank you, but I already made the request and it was accepted last night. I will do the next push :) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann, cullmann Cc: kwrite-devel, cullmann,

D14282: CSS: fix test reference of the previous commit

2018-07-23 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:a82af177bc2f: CSS: fix test reference of the previous commit (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14282?vs=38217=38277

D14283: C++: fix standard floating-point literals

2018-07-23 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:7a2ae6be229b: C++: fix standard floating-point literals (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14283?vs=38218=38276

D14283: C++: fix standard floating-point literals

2018-07-22 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: kwrite-devel. jpoelen requested review of this revision. REVISION SUMMARY BUG: 389693 REPOSITORY

D14282: CSS: fix test reference of the previous commit

2018-07-22 Thread jonathan poelen
jpoelen created this revision. jpoelen added a reviewer: dhaumann. Restricted Application added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix_cxx REVISION DETAIL https://phabricator.kde.org/D14282 AFFECTED FILES

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-09-09 Thread jonathan poelen
jpoelen updated this revision to Diff 41298. jpoelen added a comment. include rule in keyword list to import those from another file REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14632?vs=39138=41298 BRANCH kwinclude REVISION DETAIL

D10621: Highlighting Indexer: list of suggestions

2018-03-12 Thread jonathan poelen
jpoelen added a comment. I've already planned to fix all the suggestions, but I lost a lot of time updating the `sql*.xml` files and came across a very strange bug related to QRegularExpression by adding some tests. At the moment, I do not know if it's my tool to test, my version of Qt that

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

2018-04-22 Thread jonathan poelen
jpoelen updated this revision to Diff 32852. jpoelen added a comment. - SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle) - add sql tests - update kateversion to 5.0 and allows multiple spaces for "end if", "end case" and "end loop" REPOSITORY R216 Syntax

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

2018-04-22 Thread jonathan poelen
jpoelen updated this revision to Diff 32861. jpoelen added a comment. I am completely lost with `arc diff`. The command adds files that I did not normally modify in this branch and specifiying a reference commit does not seem to work. I ended up doing everything through a new branch,

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

2018-04-22 Thread jonathan poelen
jpoelen updated this revision to Diff 32855. jpoelen added a comment. - diff with the proper branch CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11470?vs=32853=32855 BRANCH new_sql_oracle REVISION DETAIL https://phabricator.kde.org/D11470 AFFECTED FILES

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

2018-04-22 Thread jonathan poelen
jpoelen updated this revision to Diff 32853. jpoelen added a comment. - autotests/input/highlight.sh.syntax and autotests/input/highlight.sh are restored REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11470?vs=32852=32853 BRANCH

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

2018-04-22 Thread jonathan poelen
jpoelen updated this revision to Diff 32860. jpoelen added a comment. - SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle) - add sql tests - update kateversion to 5.0 and allows multiple spaces for "end if", "end case" and "end loop" -

D10621: Highlighting Indexer: list of suggestions

2018-03-24 Thread jonathan poelen
jpoelen updated this revision to Diff 30448. jpoelen added a comment. New suggestions: - Regex "^xyz\b" -> WordDetect with column=0 - Regex "^xyz" with xyz a string of more than 2 characters -> StringDetext with column=0 Output: - Double quote are no longer escaped -

D10621: Highlighting Indexer: list of suggestions

2018-03-17 Thread jonathan poelen
jpoelen added a comment. I just tried with a format containing 5000 `` rules. This gives 2000 to 6000 more allocation than with WordDetect. Same for StringDetect vs Detect2Chars. At the speed level, for a single rule and a file with 13 * 8000 `aa `, WordDetect is 10% faster, but there

D10621: Highlighting Indexer: list of suggestions

2018-03-18 Thread jonathan poelen
jpoelen updated this revision to Diff 29869. jpoelen added a comment. More suggestions and fixes some false positives. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10621?vs=27439=29869 BRANCH suggest REVISION DETAIL

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

2018-03-18 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. Restricted Application added a project: Frameworks. jpoelen requested review of this revision. REVISION SUMMARY Previously, the variables prefixed by if / case / loop / end are a mix of keywords

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

2018-03-18 Thread jonathan poelen
jpoelen updated this revision to Diff 29866. jpoelen added a comment. File mode restored for autotests/input/highlight.sh and autotests/input/highlight.sh.syntax REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11470?vs=29865=29866 BRANCH sql

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

2018-03-18 Thread jonathan poelen
jpoelen added a comment. There is a bug on which I fell while completing the tests: the output is not stable. Several successive calls to `./bin/kate-syntax-highlighter $PROJ/autotests/input/test.sql` give a different result. `valgrind` returns a lot of "Conditional jump or move

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

2018-04-25 Thread jonathan poelen
jpoelen added a comment. The page on Phabricator is much better than before. My problem was about creating a branch without the `-t` option which requires me to specify a commit/branch to do the diff. I also realized later that I was reloading a page from the revision history, so I

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-09-30 Thread jonathan poelen
jpoelen updated this revision to Diff 42628. jpoelen added a comment. - fix the recursion detection and handling of nested included keyword lists REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14632?vs=41872=42628 BRANCH kwinclude REVISION

D10621: Highlighting Indexer: list of suggestions

2019-01-09 Thread jonathan poelen
jpoelen added a comment. I agree that some rules are excessive or even false, but the last time I watched (it was several months ago now), some regexes suggested to be DetectString seemed to have writing errors (mainly `\\` count as 2 characters in xml) and some more or less useful

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-09-15 Thread jonathan poelen
jpoelen added a comment. Sorry to answer so late, I had trouble logging in. I think I misinterpreted the use of `includedDefinitions()`. For me, this function lists the languages ​included by the rules and which influence the colors. While the inclusion of a keyword list has no

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-09-16 Thread jonathan poelen
jpoelen added a comment. `resolveIncludeKeywords()` would then use `loadKeywords()` instead of `load()` ? This should be enough. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14632 To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann Cc:

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-09-17 Thread jonathan poelen
jpoelen updated this revision to Diff 41872. jpoelen added a comment. - restore operators list - lazy load keyword lists REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14632?vs=41298=41872 BRANCH kwinclude REVISION DETAIL

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-09-17 Thread jonathan poelen
jpoelen added a comment. (I inadvertently edit the operators list in the previous commit) Finally, I added a parameter to `load()` and `loadHighlighting()` rather than a new function because there was a lot of code duplication. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D21421: Tcsh: fix operators and keywords

2019-05-27 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:4d2329e3f63e: Tcsh: fix operators and keywords (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21421?vs=58696=58742 REVISION

D21421: Tcsh: fix operators and keywords

2019-05-27 Thread jonathan poelen
jpoelen added a comment. I forgot to ask about running the tests. Is it normal that system syntax files take precedence if we have an `index.katesyntax`? Currently I have to run the tests by setting the environment variable `XDG_DATA_DIRS`. REPOSITORY R216 Syntax Highlighting BRANCH

D21421: Tcsh: fix operators and keywords

2019-05-26 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - missing `foreach` and `end` - fix folding with

D21587: Lua: update for Lua54 and end of function as Keyword rather than Control

2019-06-04 Thread jonathan poelen
jpoelen edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21587 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, michaelh,

D21586: Add syntax definition for ninja build

2019-06-04 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH ninja (branched from

D21585: C++: update for C++20

2019-06-04 Thread jonathan poelen
jpoelen updated this revision to Diff 59156. jpoelen added a comment. oops, missing version increase REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21585?vs=59152=59156 BRANCH cpp2a (branched from master) REVISION DETAIL

D21508: Jam: various improvements and fixes

2019-06-04 Thread jonathan poelen
jpoelen updated this revision to Diff 59150. jpoelen added a comment. - fix module - remove hard coded color REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21508?vs=58930=59150 BRANCH fix_jam (branched from master) REVISION DETAIL

D21585: C++: update for C++20

2019-06-04 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - new attributes: assert, ensures and expects - new

D21587: Lua: update for Lua54 and end of function as Keyword rather than Control

2019-06-04 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY function foo() if x then end <--- Control

D21587: Lua: update for Lua54 and end of function as Keyword rather than Control

2019-06-04 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:602bbc7b7397: Lua: update for Lua54 and end of function as Keyword rather than Control (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D21508: Jam: various improvements and fixes

2019-06-04 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:6864c25f1d54: Jam: various improvements and fixes (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21508?vs=59150=59164 REVISION

D21585: C++: update for C++20

2019-06-04 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:9ba02971123d: C++: update for C++20 (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21585?vs=59156=59162 REVISION DETAIL

D21508: Jam: various improvements and fixes

2019-05-30 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - fix `x=`: is a rule named `x=`, not a variable - fix `exe onx`: is a rule

D21586: Add syntax definition for ninja build

2019-06-08 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:a72b6b5e53ec: Add syntax definition for ninja build (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21586?vs=59240=59421

D21421: Tcsh: fix operators and keywords

2019-05-30 Thread jonathan poelen
jpoelen added a comment. OK I understand. Initially I had not changed the version number of txsh.xml and it is based on the reference in `/usr/share/org.kde.syntax-highlighting/syntax/index.katesyntax` rather than in the repository. And the fact that the versions in the index file were

D21508: Jam: various improvements and fixes

2019-06-01 Thread jonathan poelen
jpoelen added a comment. I left it because it goes well with dark or light themes, but I removed it. Is the policy the same for bold, underlined and italic as for color? Because a basic applied distinction between Comment and CommentTitle seems to me preferable. I imagine not, but I would

D21586: Add syntax definition for ninja build

2019-06-05 Thread jonathan poelen
jpoelen updated this revision to Diff 59240. jpoelen added a comment. I am confused, the generation of index.katesyntax fails because the list "variables" does not exist (there is no variable predefined in this context). We may be in a situation where a change of branch does not recompile

D21586: Add syntax definition for ninja build

2019-06-29 Thread jonathan poelen
jpoelen added a comment. After reflection (:D), I think the constraint is weak, the creation of new syntax is rare compared to the rest. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21586 To: jpoelen, #framework_syntax_highlighting, dhaumann,

D23136: Jam: Fix local with variable without initilisation and highlight SubRule

2019-08-13 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix_jam (branched from master) REVISION DETAIL

D23137: C++: contracts are not in C++20

2019-08-13 Thread jonathan poelen
jpoelen updated this revision to Diff 63689. jpoelen added a comment. - increase version REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23137?vs=63686=63689 BRANCH cpp_no_contract (branched from master) REVISION DETAIL

D23137: C++: contracts are not in C++20

2019-08-13 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY For C ++ 23 or C ++ 26 with perhaps a syntax change REPOSITORY R216 Syntax

D23134: fix additionalDeliminator attribute

2019-08-13 Thread jonathan poelen
jpoelen added a comment. I don't understand why there's so much difference in what's displayed :/ REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23134 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D23134: fix additionalDeliminator attribute

2019-08-13 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY The initialization of the `Rule::m_wordDelimiter` cache was done before the

D23135: Gettext: fix "previous untranslated string" and other improvements/fixes

2019-08-13 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - fix #| (previous untranslated string) - fix hexadecimal entity - fix html tag

  1   2   >