D13394: C++: update for c++20 and fix some syntax errors

jpoelen added a comment. Thank you, but I already made the request and it was accepted last night. I will do the next push :) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann, cullmann Cc: kwrite-devel, cullmann, kde-frameworks

D13829: Lua: fix multi-line string

jpoelen created this revision. jpoelen added a reviewer: dhaumann. Restricted Application added a project: Frameworks. Restricted Application edited subscribers, added: kde-frameworks-devel; removed: Frameworks. jpoelen requested review of this revision. REVISION SUMMARY Strings that end with \

D13394: C++: update for c++20 and fix some syntax errors

jpoelen added a comment. I do not have a developer account, but I can do it. This is not a problem because I will contribute again. REPOSITORY R216 Syntax Highlighting BRANCH cpp REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann, cullmann Cc: cullmann, kde-fram

D13394: C++: update for c++20 and fix some syntax errors

jpoelen added inline comments. INLINE COMMENTS > dhaumann wrote in gcc.xml:576-577 > These can be WordDetect as well, right? It does not work because of ':'. But Putting it in `weakDeliminator` will break things. For this to work, it would need `additionalDeliminator` and `weakDeliminator`

D13394: C++: update for c++20 and fix some syntax errors

jpoelen updated this revision to Diff 36229. jpoelen added a comment. - C++: test with clang:: in an attribute REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13394?vs=35729&id=36229 BRANCH cpp REVISION DETAIL https://phabricator.kde.org/D1

D13395: Pony: fix single quote escape and a possible infinite loop with #

jpoelen created this revision. jpoelen added a reviewer: dhaumann. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix-pony REVISION DETA

D13394: C++: update for c++20 and fix some syntax errors

jpoelen edited the summary of this revision. jpoelen added a reviewer: dhaumann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D13394 To: jpoelen, dhaumann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13394: C++: update for c++20 and fix some syntax errors

jpoelen created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jpoelen requested review of this revision. REVISION SUMMARY - new keywords, attributes and standard macros - hexadecimal floatting point (c++17)

D12689: Lua: updated for Lua5.3

jpoelen added a comment. @dhaumann The difference is in the `dynamic` attribute of a context. Kate propagates the captures only if the value is `true` whereas SyntaxHighlighting never looks at that value and only uses the `dynamic` attribute of the rules. Personally, I find that having t

D12854: Awk: fix regex in a function and update syntax for gawk

jpoelen updated this revision to Diff 34098. jpoelen added a comment. - Awk: add collating symbols and equivalence classes REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12854?vs=34076&id=34098 BRANCH awk REVISION DETAIL https://phabricato

D12860: DoxygenLua: fix closing comment blocks

jpoelen edited the test plan for this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D12860 To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12860: DoxygenLua: fix closing comment blocks

jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D12860 To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12860: DoxygenLua: fix closing comment blocks

jpoelen created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jpoelen requested review of this revision. REVISION SUMMARY Kate-editor needs the context to be marked dynamic to use a placeholder in a dynamic ru

D12689: Lua: updated for Lua5.3

jpoelen added a comment. There is indeed a problem with Kate, but it works with KSyntaxHighlighting. I will look in what part of doxygenlua.xml the problem is. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D12689 To: jpoelen, dhaumann, #framework_syntax

D12854: Awk: fix regex in a function and update syntax for gawk

jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D12854 To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: kde-frameworks-devel, michaelh, genethomas, ngraham, bruns, cullmann, vkrause,

D12854: Awk: fix regex in a function and update syntax for gawk

jpoelen created this revision. jpoelen added a project: Framework: Syntax Highlighting. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. jpoelen requested review of this revision. REVISION SUMMARY - fix `match(str, /it's a regex

D12689: Lua: updated for Lua5.3

jpoelen created this revision. jpoelen added reviewers: dhaumann, Framework: Syntax Highlighting. jpoelen added projects: Framework: Syntax Highlighting, Frameworks. Restricted Application added a subscriber: Frameworks. jpoelen requested review of this revision. REVISION SUMMARY Add of: -

D12569: Pony: fix identifier and keyword

jpoelen created this revision. jpoelen added a reviewer: dhaumann. jpoelen added a project: Framework: Syntax Highlighting. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - mis

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen added a comment. The page on Phabricator is much better than before. My problem was about creating a branch without the `-t` option which requires me to specify a commit/branch to do the diff. I also realized later that I was reloading a page from the revision history, so I alwa

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen updated this revision to Diff 32861. jpoelen added a comment. I am completely lost with `arc diff`. The command adds files that I did not normally modify in this branch and specifiying a reference commit does not seem to work. I ended up doing everything through a new branch, sor

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen updated this revision to Diff 32860. jpoelen added a comment. - SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle) - add sql tests - update kateversion to 5.0 and allows multiple spaces for "end if", "end case" and "end loop" - autotests/input/highlig

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen updated this revision to Diff 32855. jpoelen added a comment. - diff with the proper branch CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11470?vs=32853&id=32855 BRANCH new_sql_oracle REVISION DETAIL https://phabricator.kde.org/D11470 AFFECTED FILES autotests/foldin

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen updated this revision to Diff 32853. jpoelen added a comment. - autotests/input/highlight.sh.syntax and autotests/input/highlight.sh are restored REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11470?vs=32852&id=32853 BRANCH new_sql_o

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen updated this revision to Diff 32852. jpoelen added a comment. - SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle) - add sql tests - update kateversion to 5.0 and allows multiple spaces for "end if", "end case" and "end loop" REPOSITORY R216 Syntax H

D10621: Highlighting Indexer: list of suggestions

jpoelen updated this revision to Diff 30448. jpoelen added a comment. New suggestions: - Regex "^xyz\b" -> WordDetect with column=0 - Regex "^xyz" with xyz a string of more than 2 characters -> StringDetext with column=0 Output: - Double quote are no longer escaped - "^\\s*"

D10621: Highlighting Indexer: list of suggestions

jpoelen updated this revision to Diff 29869. jpoelen added a comment. More suggestions and fixes some false positives. REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10621?vs=27439&id=29869 BRANCH suggest REVISION DETAIL https://phabricato

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen added a comment. There is a bug on which I fell while completing the tests: the output is not stable. Several successive calls to `./bin/kate-syntax-highlighter $PROJ/autotests/input/test.sql` give a different result. `valgrind` returns a lot of "Conditional jump or move depends

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen updated this revision to Diff 29866. jpoelen added a comment. File mode restored for autotests/input/highlight.sh and autotests/input/highlight.sh.syntax REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11470?vs=29865&id=29866 BRANCH s

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. Restricted Application added a project: Frameworks. jpoelen requested review of this revision. REVISION SUMMARY Previously, the variables prefixed by if / case / loop / end are a mix of keywords an

D10621: Highlighting Indexer: list of suggestions

jpoelen added a comment. I just tried with a format containing 5000 `` rules. This gives 2000 to 6000 more allocation than with WordDetect. Same for StringDetect vs Detect2Chars. At the speed level, for a single rule and a file with 13 * 8000 `aa `, WordDetect is 10% faster, but there is

D10621: Highlighting Indexer: list of suggestions

jpoelen added a comment. I've already planned to fix all the suggestions, but I lost a lot of time updating the `sql*.xml` files and came across a very strange bug related to QRegularExpression by adding some tests. At the moment, I do not know if it's my tool to test, my version of Qt that

D10646: Support case-insensitive WordDetect

jpoelen added a comment. It seems that KTextEditor does not have the problem because KateHlWordDetect is based on KateHlStringDetect which uses the inSensitive parameter. INLINE COMMENTS > rule_p.h:249 > QString m_word; > +Qt::CaseSensitivity m_caseSensitivity; > }; Yes, but it is

D10646: Support case-insensitive WordDetect

jpoelen created this revision. jpoelen added a reviewer: dhaumann. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH word_insensitive REVISION DETAIL

D10621: Highlighting Indexer: list of suggestions

jpoelen added a project: Framework: Syntax Highlighting. jpoelen added a subscriber: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D10621 To: jpoelen, dhaumann Cc: #framework_syntax_highlighting, dhaumann, #frameworks, michael

D10621: Highlighting Indexer: list of suggestions

jpoelen created this revision. jpoelen added a reviewer: dhaumann. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. jpoelen requested review of this revision. REVISION SUMMARY Proposes mergers of rules and the replacement of: - RegEx

D7297: Add Pony highlighting

jpoelen updated this revision to Diff 18196. jpoelen added a comment. Pony: Support for attributes and best behavior for function definitions. Add license and removed autotests/foldingtest.pony REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D729

D7297: Add Pony highlighting

jpoelen updated this revision to Diff 18194. jpoelen added a comment. Restricted Application added a project: Frameworks. - Pony: Support for attributes and best behavior for function definitions. Add license and removed autotests/foldingtest.pony REPOSITORY R216 Syntax Highlighting CHANGE

D7297: Add Pony highlighting

jpoelen added a reviewer: Framework: Syntax Hightlighting. jpoelen edited projects, added Framework: Syntax Hightlighting; removed Frameworks. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D7297 To: jpoelen, #framework_syntax_hightlighting Cc: #frameworks,

D6288: isocpp.xml: replace P printf-like format with p

jpoelen abandoned this revision. jpoelen added a comment. This commit is already merged. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6288 To: jpoelen Cc: #frameworks

D7297: Add Pony highlighting

jpoelen created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R216 Syntax Highlighting BRANCH pony REVISION DETAIL https://phabricator.kde.org/D7297 AFFECTED FILES autotests/folding/highlight.pony.fol

D6328: add unit test for isocpp

jpoelen created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R216 Syntax Highlighting BRANCH ioscpp-test REVISION DETAIL https://phabricator.kde.org/D6328 AFFECTED FILES autotests/folding/highlight.c

D6288: isocpp.xml: replace P printf-like format with p

jpoelen created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY 'P' format does not exist, 'p' format is missing. TEST PLAN printf("%p", pointer); REPOSITORY R216 Syntax Highlighting BRANCH ioscpp

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

jpoelen added a reviewer: Framework: Syntax Hightlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D6128 To: jpoelen, #framework_syntax_hightlighting Cc: #frameworks

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

jpoelen updated this revision to Diff 15240. jpoelen added a comment. - cmake test: add an expression with nested parenthesis REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6128?vs=15239&id=15240 BRANCH upstream REVISION DETAIL https://pha

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

jpoelen updated this revision to Diff 15239. jpoelen added a comment. Previous diff on bad branch REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6128?vs=15238&id=15239 BRANCH upstream REVISION DETAIL https://phabricator.kde.org/D6128 AFFE

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

jpoelen updated this revision to Diff 15238. jpoelen edited the summary of this revision. jpoelen added a comment. - Update test reference data REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6128?vs=15237&id=15238 BRANCH upstream REVISION DE

D6128: Bug 360656 - CMake: OR/AND not highlighted after expr in ()

jpoelen retitled this revision from "CMake: OR/AND not highlighted after expr in () If you type in "if((A AND B) OR C)", "OR" is not highlighted." to "Bug 360656 - CMake: OR/AND not highlighted after expr in ()". jpoelen edited the summary of this revision. jpoelen edited the test plan for this r

D6128: CMake: OR/AND not highlighted after expr in () If you type in "if((A AND B) OR C)", "OR" is not highlighted.

jpoelen created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R216 Syntax Highlighting BRANCH upstream REVISION DETAIL https://phabricator.kde.org/D6128 AFFECTED FILES data/syntax/cmake.xml To: jpoel

<    1   2