D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H

loh.tar added a comment. > For my taste is that hint not really right/useful. That should not be shown when the document begin/end was wrapped but when the initially staring point reached. I think that may also fix the case example in https://bugs.kde.org/show_bug.cgi?id=398731

D18125: KateStatusBar: Add dictionary button

loh.tar updated this revision to Diff 52307. loh.tar added a comment. - Remove '-w_accents -variant_0' and such from dict-code to keep it small and clean - Fix to show correct dict when cursor is at end of a range - Add signal caretChangedRange to ViewPrivate, much less overhead this way

D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H

loh.tar added a comment. For my taste is that hint not really right/useful. That should not be shown when the document begin/end was wrapped but when the initially staring point reached. May try to fix that when got some +1 REPOSITORY R39 KTextEditor REVISION DETAIL

D19193: KateSearchBar: Show also search has wrapped hint in nextMatchForSelection() aka Ctrl-H

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL

D19131: [RFC] DocumentPrivate: Fix "auto-rewrap" in static wrap mode

loh.tar updated this revision to Diff 52158. loh.tar edited the summary of this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Do not wrap in some cases with block selection - Auto wrap once wrapped line again also when static wrap is

D19131: [RFC] DocumentPrivate: Fix "auto-rewrap" in static wrap mode

loh.tar updated this revision to Diff 52072. loh.tar edited the summary of this revision. loh.tar added a comment. Fix mentioned misplaced cursor. The reason was a special treatment for past-end-of-line cursors. The fix changed/fixed also that now the cursor is moved by one not two

D19131: [RFC] DocumentPrivate: Fix "auto-rewrap" in static wrap mode

loh.tar created this revision. loh.tar added reviewers: cullmann, KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY This patch is very similar to D17949

D19051: [RFC]DocumentPrivate: Auto unwrap line when text is removed

loh.tar created this revision. loh.tar added reviewers: KTextEditor, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Such patch seems to be missing to achieve the desired

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

loh.tar updated this revision to Diff 51680. loh.tar edited the summary of this revision. loh.tar edited the test plan for this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Add autotest - Don't wrap twice when static wrap is set to

D18894: [RFC] General config interface

loh.tar added a comment. Contrary to my announcement to use an enum as key I chosed the string for maximum simplicity. Yes, this way you notice a typo only at runtime, but in any case you have to know how some stuff has to be written. An enum key offer not only complile time checks but

D18894: [RFC] General config interface

loh.tar created this revision. loh.tar added reviewers: cullmann, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Remove unneeded bool configIsRunning, add m_

D18116: Add TODO KF6 note

loh.tar updated this revision to Diff 50875. loh.tar added a comment. - Move to correct function Good catch :-) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18116?vs=50759=50875 REVISION DETAIL https://phabricator.kde.org/D18116 AFFECTED FILES

D18125: KateStatusBar: Add dictionary button

loh.tar updated this revision to Diff 50763. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Apply nullptr check - Add non preferred dict to menu chose by user - Reorder actions - Remove gone "Spellcheck Selection" action REPOSITORY R39

D18116: Add TODO KF6 note

loh.tar added a comment. In D18116#403838 , @cullmann wrote: > Just to be sure: > > We can apply D18117 and don't need to change here anything or? It seems so :-) REPOSITORY R39 KTextEditor

D18116: Add TODO KF6 note

loh.tar updated this revision to Diff 50759. loh.tar retitled this revision from "Don't show document load trouble twice" to "Add TODO KF6 note ". loh.tar edited the summary of this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Revert

D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection"

loh.tar added a comment. For my taste could be "Spelling (from cursor)" the only offered action (logic). Always to check from the start is rarely useful, but I guess no one like that idea. The current patch should cause no harm, except that someone need to reassign some shortcut or

D18663: KateSpellCheckDialog: Remove action "Spellcheck Selection"

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ...and add logic to "Spelling.." and "Spelling (from cursor)"

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

loh.tar updated this revision to Diff 50648. loh.tar added a comment. - Move logic into document - Tiny docu fix + cosmettic CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17949?vs=50104=50648 REVISION DETAIL https://phabricator.kde.org/D17949 AFFECTED FILES

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

loh.tar added a comment. I often struggle with QtCreator but I can't remember what happens there, sorry. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17661 To: loh.tar, #ktexteditor, #vdg, cullmann Cc: dhaumann, cullmann, kwrite-devel, kde-frameworks-devel,

D18317: Display an error message if loading a dictionary fails

loh.tar added a comment. My observations: - There is no hint when you activate auto spell check (yes, it's out of this scope) - Before showing the combobox by "Change Dictionary" the popup appears - The combobox shows then some other setting, here it was the first entry - When open

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

loh.tar added a comment. > also don't change the behavior of wordwrapping that is used by the view compared to what we would get by calling wordwrap on the document directly It's somehow not the case. The document has no such function. It's similar to ViewPrivate::smartNewline() or

D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection

loh.tar added a comment. > If you want to get this behavior for Markdown Even I had mentioned Markdown as example, I would prefer to have this as general behavior. Not only because I don't know anything about that highlight stuff and can't implement it this way. I often write some

D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection

loh.tar added a comment. There is an `enum KSyntaxHighlighting::Theme::TextStyle::Operator` but I can't find a function to test for that. Beside that I guess it would not work anyway. If it's an operator or not need a call to some "update highlight" to investigate the context. Ideas?

D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection

loh.tar added a comment. > the selection becomes wrapped in two ? - is that right? Yes > if we only want this for, say, markdown, then it should be a per-highlightfile list of chars that trigger this special behavior How that? > if I have foo + bar and I select the +

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

loh.tar updated this revision to Diff 50104. loh.tar edited the summary of this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Update 'What's This' hint to reflect new behaviour and to be more precise - Update 'What's This' hint of dyn

D17949: ViewPrivate: Make 'Apply Word Wrap' more comfortable

loh.tar updated this revision to Diff 50082. loh.tar retitled this revision from "ViewPrivate: Make applyWordWrap() more comfortable" to "ViewPrivate: Make 'Apply Word Wrap' more comfortable". loh.tar added a comment. - Use std::unique_ptr for the cursor - Oops!? Use 'if' instead of

D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection

loh.tar updated this revision to Diff 50061. loh.tar edited the summary of this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - const QChar as value, not reference - Add , ; - + ^ ° § & just for completeness REPOSITORY R39 KTextEditor

D18116: Don't show document load trouble twice

loh.tar updated this revision to Diff 50027. loh.tar added a comment. - Don't set m_openingErrorMessage in KateBuffer::openFile - m_openingErrorMessage is now nowhere set CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18116?vs=49031=50027 REVISION DETAIL

D18125: KateStatusBar: Add dictionary button

loh.tar added a comment. > m_dictionaryGroup->checkedAction() might be null. Oops! Thanks. > For the naming: Given we show the encodings with their short-names, too, I can live with de_DE or stuff like that. Is it OK to add some cutting like that? Currently is that extra stuff

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar added a comment. > are you interested in that challenge, too? Um...atm? No. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17459 To: loh.tar, #ktexteditor, #vdg, cullmann Cc: dhaumann, anthonyfieroni, brauch, cullmann, abetts, kwrite-devel,

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

loh.tar added a comment. > But on the other side: how does one reproduce this? Hm, I had just follow the descriptions in the report. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17857 To: loh.tar, #ktexteditor Cc: cullmann, dhaumann, kwrite-devel,

D18317: Don't fail if defaultLanguage dictionary can't be loaded

loh.tar added a comment. Well, I'm not a Sonnet Guru, more a normal user. Sorry if it sounds so. I can't give a detailed point how to solve some particular issue. My comment is more about what I would expect or what I would try to achieve. I didn't investigate from where is

D18317: Don't fail if defaultLanguage dictionary can't be loaded

loh.tar added a comment. Just my thoughts: - I think there shouldn't be the (default) dictionary changed by some smart logic. Just hint the user that the setting is not applicable. - To set the dict to the system locale seems to me the less smartest trick. If everybody want such

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 49754. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Fix to pass autotest 97% tests passed, 2 tests failed out of 67 Total Test time (real) = 137.70 sec The following tests FAILED: 24 -

D18164: Review KateGotoBar

loh.tar updated this revision to Diff 49665. loh.tar added a comment. - Connect/Disconnect - Remove m_gotoRange->setFocus Like this? :-/ I noticed bad behavior and have remove these setFocus, test it if its OK. On edit was always the focus set to the spinbox. CHANGES SINCE LAST

D18164: Review KateGotoBar

loh.tar updated this revision to Diff 49653. loh.tar edited the summary of this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Morph updateData() into a slot - connect to Document::textChanged signal REPOSITORY R39 KTextEditor

D18125: KateStatusBar: Add dictionary button

loh.tar added a subscriber: cullmann. loh.tar added a comment. @cullmann @dhaumann A short not how to progress would be nice. - Keep codes as they are - Shorten codes as suggested - Replace codes by flags/ensign (no idea how) - Add (unneeded) label - Show (unneeded long) full name

D18164: Review KateGotoBar

loh.tar updated this revision to Diff 49636. loh.tar added a comment. - Fix typo of member vars - Add missing setView(m_view) - Remove FIXME hint about timer, however would a comment for me nice - Use QString() Things which could be improved or not - The up/down buttons are a

D17949: ViewPrivate: Make applyWordWrap() more comfortable

loh.tar added a comment. Interesting. Didn't know that such function exist. Well, it may help to read the handbook... Is there no GUI way to access such stuff? "Read the handbook" lala... Well, word/text wrapping is a field which has many room for improvements. - Adjust as block

D18164: Review KateGotoBar

loh.tar added a comment. > I have the feeling it adds more clutter than it helps by default: Code clutter or what? The functionality is lovely and I can't see in which way It may someone jar > I thinkis quite fast. For a keyboard-virtuoso for sure. I'm one of those who use

D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines

loh.tar added a comment. > can you please rephrase the title of this review to make it understandable? Of course, if I could, I would have done it :-) "Remove all what is not nice text" ? It may help you to read all posts to get a hint of my intention. It turned out that this here ist

D17949: ViewPrivate: Make applyWordWrap() more comfortable

loh.tar added subscribers: cullmann, dhaumann. loh.tar added a comment. > please add proper tests for this functionality No idea how Because there are a couple of bug reports where often the response was like "No, can't be done" need this a closer look from @dhaumann and @cullmann

D17852: ViewInternal: Fix 'Go to matching bracket' in override mode

loh.tar updated this revision to Diff 49530. loh.tar added a comment. Add autotest CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17852?vs=48340=49530 REVISION DETAIL https://phabricator.kde.org/D17852 AFFECTED FILES autotests/src/kateview_test.cpp

D17693: DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection

loh.tar updated this revision to Diff 49452. loh.tar retitled this revision from "DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection" to "DocumentPrivate: Treat some chars also as "auto bracket" only when we have a selection". loh.tar edited

D17730: Review KateStatusBar

loh.tar added a comment. > I like the new status bar. Thanks :-) > In "modified" state it would be cool to be able to click to save the document Yes, that was also my idea. IIRC I had somewhere asked but got no response. Will do it soon. > Move the modified label from far

D17137: KTextEditor: File menu: Put Save, Print and Export in submenus

loh.tar added a comment. Sadly is the benefit, to reduce the menu entries, not "optimal". In the pics you have now 3 sub-entries for one "Variant" entry, effectively only 2 less per topic. I may like it if these "Variant-Action" could be avoided and merged with one of the

D18164: Review KateGotoBar

loh.tar updated this revision to Diff 49243. loh.tar added a comment. - Use 120 as wheel-delta threshold - Use member instead of static local > If not do it right you can end up in partial value when it used finer-resolution wheels and mishmash. I have problems to see that hazard,

D18164: Review KateGotoBar

loh.tar added a comment. I was about to move StatusBarButton into kateviewhelpers, so that this button can used elsewhere too, like here. But got stuck. However, I think such button would be handy. Perhaps also a KateViewBarLayout. Here shot regarding 'Change label text to be less

D18125: KateStatusBar: Add dictionary button

loh.tar added a comment. I'm very much against such a label, and against the full name. "UTF-8" has also no label and that's good. The only stuff where a description label is needed are these line/column/word hints. Without a label are you almost lost to know which is what. However,

D18164: Review KateGotoBar

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Set minimum value of spin-box to 1 - Don't force minimum

D18125: KateStatusBar: Add dictionary button

loh.tar updated this revision to Diff 49099. loh.tar added a comment. - Add missing signals to watch dict changes - Ensure button is set on first show Looks fixed, give it a try. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18125?vs=49078=49099 REVISION DETAIL

D18125: KateStatusBar: Add dictionary button

loh.tar added a comment. > Isn't en_US too cryptic? Well, yes. > I suggest to use the just added KLanguageName (see D10446 ). With this, you can get a nice name like "English (USA)". Alternatively, you may use

D18125: KateStatusBar: Add dictionary button

loh.tar added a comment. The shown dictionary is sometimes "wrong" - Mark a word by double-click and choose a dictionary different from the default for that word - Click/move into the word -> The shown dictionary fit - Double-Click that word again -> The shown dictionary is the

D18125: KateStatusBar: Add dictionary button

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ...to indicate the current dictionary and for the handy access

D17852: ViewInternal: Fix 'Go to matching bracket' in override mode

loh.tar added a comment. Nice trick ;-) Can't promise to do it, will see REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17852 To: loh.tar, #ktexteditor Cc: dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking,

D17730: Review KateStatusBar

loh.tar added a comment. > It was stated that it broke tests, should this be addressed now? As shown in the pic, the bar forces no width anymore (at least it seems so) Your comments at the bug report are interesting, but I'm not sure to do it. I had Christoph promised to add options to

D18116: Don't show document load trouble twice

loh.tar added a comment. I have it only poor tested with our big S file, so no test was made with other trouble causing stuff. This need a patch in Kate, will try to link that KateBuffer::openFile - There is no distingues from 1. "create new file by command line" and 2.

D18116: Don't show document load trouble twice

loh.tar created this revision. loh.tar added reviewers: KTextEditor, cullmann, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Since there are fancy "in view" messages

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. In D17999#389148 , @cullmann wrote: > "Paste by mouse at cursor position" should be ok, then I will push this, ok? Well, a last close look is nerver bad. REVISION DETAIL https://phabricator.kde.org/D17999 To:

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar updated this revision to Diff 48999. loh.tar added a comment. Back to "Paste by mouse at cursor position" CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17999?vs=48778=48999 REVISION DETAIL https://phabricator.kde.org/D17999 AFFECTED FILES

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. Sure, can do it. Which one have it to be ? - Paste clipboard contents at cursor location - Paste clipboard contents at cursor position - Paste by mouse at cursor position (This one was liked by Dominik, IIRC) REVISION DETAIL

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. To avoid further comments I like to add that I don't like to do the requested change. Please improve it later, if needed. REVISION DETAIL https://phabricator.kde.org/D17999 To: loh.tar, #ktexteditor, dhaumann Cc: cullmann, dhaumann, ngraham, kwrite-devel,

D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines

loh.tar added inline comments. INLINE COMMENTS > katedocument.cpp:4016 > // behavior when deleting from the start of a line, just when > explicitly > // calling the join command > Kate::TextLine tl = kateTextLine(line + 1); Can one point me why this is

D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines

loh.tar updated this revision to Diff 48994. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. Try to be smart REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17128?vs=48486=48994 REVISION DETAIL

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. I agree, it's on the first sight pretty clear. But then can you force this "style" for every bool option. In the above linked pic is this obviously only used for Normal vs Vi-Mode [1] A drawback of that "style" may that you can't say for sure "which is what" in

D17310: Use a Kile Icon that is similar to the original

loh.tar added a comment. Yes looks nice. Would be good as icon for the Kile Handbook, for the application I would omit/avoid the "Notebook" look. REPOSITORY R266 Breeze Icons BRANCH improve-kile-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D17310 To:

D17730: Review KateStatusBar

loh.tar updated this revision to Diff 48813. loh.tar edited the summary of this revision. loh.tar added a comment. - Remove not supported Rich Text from [BLOCK] hint - Add word count info to line label F6530066: pic.png CHANGES SINCE LAST UPDATE

D12295: Supporting nested brackets for Kate autobrackets

loh.tar added a comment. I didn't test it even more but think on it from time to time. If my slightly negative comment was OK or too fast judged. And yes it may. On the other hand I ask me if the approach to track each key stroke and change the behavior on that record is right or a

D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

loh.tar added a comment. > Will wait for further advice Still waiting if I have to undo these reference stuff. (Yes your are busy. Just only wanted it to emphasize) Besides, I like to add some more chars to this special handling: _ : # @ ~ * ! $ % / \ Some of these may

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. In D17999#387370 , @dhaumann wrote: > Hm, didn't you switch the meaning... I hope you mean @ngraham :-) I just typed overslept what he wrote...yes he has. Before I only kill that "mouse" I like to ask the native

D17730: Review KateStatusBar

loh.tar updated this revision to Diff 48781. loh.tar added a comment. Allow StatusBarButton to shrink Ah! Strange! :-/ But somehow the more usual behavior, these "crunching" is unlikely. Couldn't find a hint where it is done in Kate, but after some digging around I have some solution

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar added a comment. Please provide also a tooltip/whats-this text, if useful. My QtDesigner did not show the needed widget stuff, so the text is not set. A look at that bug report may give more hints/ideas REPOSITORY R39 KTextEditor REVISION DETAIL

D17730: Review KateStatusBar

loh.tar added a comment. @zetazeta wrote > I find it annoying that the status bar imposes a limit on the minimum width of the window @dhaumann wrote > Maybe with this patch, the status bar grows and forces a different width me wrote > The bar can shrink almost endless

D17999: ViewConfig: Add option to paste at cursor position by mouse

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY With this option is the cursor not moved to the mouse position

D17970: Fix broken Emmet

loh.tar added a comment. May I ask a stupid question? Is the entire function needed? That's looks to me somehow like image/picture stuff but I don't find picture stuff in the Tool->Emmet menu. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17970 To: loh.tar,

D17730: Review KateStatusBar

loh.tar added a comment. That can I not really imagine :-/ Wouldn't that not somehow to be notice in normal use? Let's try this. Shot without bar, Now choose "Show bar", The window didn't change. (Sorry, no tool at hand to paste pics together) The bar can shrink almost endless.

D17970: Fix broken Emmet

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Improve warning message with line number BUG: 386151

D17970: Fix broken Emmet

loh.tar added a comment. Well, if it is fixed I can't say. At least the error is gone and "Increment/Decrement" works. May some guru investigate if its fixed. Obviously is there a problem with these string constants. REPOSITORY R39 KTextEditor REVISION DETAIL

D17956: DocumentPrivate: Fix broken doc links in qCWarning

loh.tar updated this revision to Diff 48671. loh.tar added a comment. Requested modified link CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17956?vs=48655=48671 REVISION DETAIL https://phabricator.kde.org/D17956 AFFECTED FILES src/document/katedocument.cpp To: loh.tar,

D17956: DocumentPrivate: Fix broken doc links in qCWarning

loh.tar added a comment. How about to change this logging into a warning message in the view? Or will it displayed(?) I have noticed these while investigating https://bugs.kde.org/show_bug.cgi?id=397956 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17956

D17956: DocumentPrivate: Fix broken doc links in qCWarning

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL

D17730: Review KateStatusBar

loh.tar added a comment. > Do we loose this property by using real buttons instead of labels as this patch proposes? I don't think so. The buttons are not entire new, only some labels are now ALSO buttons. REPOSITORY R39 KTextEditor REVISION DETAIL

D17949: ViewPrivate: Make applyWordWrap() more comfortable

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Don't wrap entire document when nothing is selected but wrap

D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines

loh.tar added a comment. It's almost untested, will try to use it on daily basis. After think a little about it, I came to this variant. Code lines are unlikely to "join", so why test for comments? A little off topic: Would it OK to modify the wrap stuff that it behaves differently?

D17128: WIP DocumentPrivate: Remove all from next line which may annoying when joining lines

loh.tar updated this revision to Diff 48486. loh.tar retitled this revision from "DocumentPrivate: Remove comment mark when joining lines" to "WIP DocumentPrivate: Remove all from next line which may annoying when joining lines". loh.tar edited the summary of this revision. loh.tar added a

D17730: Review KateStatusBar

loh.tar added a comment. Harr, one more issue :-/ F6516314: 1546186710.png Idea how to fix this? I had in the past often such trouble, but so far I remember no solution. So my fix would be to remove the emphasis. Is it OK to update this diff

D17730: Review KateStatusBar

loh.tar added a comment. One idea: Now you have only to click once to change some setting, not twice (double-click). So if these test simulate a clicks... REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To: loh.tar, #ktexteditor, cullmann Cc: zetazeta,

D17730: Review KateStatusBar

loh.tar added a comment. I'm pretty baffled. What does the status bar which may break some input (mode) ? These report says nothing to me. Well, ok, the vi-mode can enabled/disabled :-/ REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To: loh.tar,

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar updated this revision to Diff 48391. loh.tar added a comment. - Revert d-stuff - Remove BCI stuff I'm still looking for a better name for "m_cancelFindOrReplace", suggestions? CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17459?vs=47966=48391 REVISION DETAIL

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

loh.tar added a comment. In D17857#383865 , @dhaumann wrote: > Is this related to bug https://bugs.kde.org/show_bug.cgi?id=306745 ? I don't think so. Here is it auto-bracket stuff, there general "is visible" stuff :-) (Yeah, my English

D17459: SearchBar: Add Cancel button to stop long running tasks

loh.tar added a comment. Do I have to revert this d-stuff? If so, some other tweak, or just as it was? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17459 To: loh.tar, #ktexteditor, #vdg, cullmann Cc: anthonyfieroni, brauch, cullmann, abetts, kwrite-devel,

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

loh.tar added a comment. As always poor tested and only in "normal mode", not vi INLINE COMMENTS > katedocument.cpp:3073 > const auto insertedAt(view->cursorPosition()); > -view->setCursorPosition(cursorPos); >

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at end of file

loh.tar retitled this revision from "DocumentPrivate: Don't scroll view when add auto-bracket at aned of file" to "DocumentPrivate: Don't scroll view when add auto-bracket at end of file". loh.tar edited the test plan for this revision. REPOSITORY R39 KTextEditor REVISION DETAIL

D17730: Review KateStatusBar

loh.tar updated this revision to Diff 48387. loh.tar retitled this revision from "[WIP] Review KateStatusBar " to "Review KateStatusBar ". loh.tar edited the summary of this revision. loh.tar added a comment. - Remove seemingly unneeded spacing. Well, there is a change but tiny and perhaps

D17730: [WIP] Review KateStatusBar

loh.tar updated this revision to Diff 48374. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Fix remaining signal/slot, Thanks for the hint! :-) > Beside that, I tried the patch, the status bar looks nice ;=) :-) > I would have no

D17857: DocumentPrivate: Don't scroll view when add auto-bracket at aned of file

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ...when 'Allow scrolling past the end of the document' is set

D17852: ViewInternal: Fix 'Go to matching bracket' in override mode

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY BUG: 402594 REPOSITORY R39 KTextEditor REVISION DETAIL

D17730: [WIP] Review KateStatusBar

loh.tar updated this revision to Diff 48334. loh.tar edited the summary of this revision. loh.tar added a comment. - Change to new signal/slot style (Idea how to fix the two missing ones?) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17730?vs=48285=48334 REVISION DETAIL

D17730: [WIP] Review KateStatusBar

loh.tar updated this revision to Diff 48285. loh.tar retitled this revision from "[WIP] Review KateStatusBar (based on D17729)" to "[WIP] Review KateStatusBar ". loh.tar edited the summary of this revision. loh.tar added a comment. - Introduce StatusBarButton - Don't gray out

D17730: [WIP] Review KateStatusBar (based on D17729)

loh.tar added a comment. > ..as soon as you split (and as the statusbar dictates the minimum size), you will get in trouble. My first thought was, "Oops, right!" But while I verifying this I notice that the status bar has the full width of the window, not only the split view.

<    1   2   3   4   5   >