D12295: Supporting nested brackets for Kate autobrackets

2018-12-27 Thread loh tar
loh.tar added a comment. His original post with some more text/hints/questions https://mail.kde.org/pipermail/kwrite-devel/2018-April/000345.html He got the advice from @brauch to post here. For me a little bit hard to follow, not only there but also here. I could apply this

D17730: [WIP] Review KateStatusBar (based on D17729)

2018-12-27 Thread loh tar
loh.tar added a comment. > For the "should we use buttons": I think I tried that in the past and it did look horrible in many styles, but perhaps I am wrong ;) I see. May it in the meantime not an issue anymore, due to new designs elsewhere? And what's up with the existing buttons, they

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

2018-12-27 Thread loh tar
loh.tar added a comment. @cullmann wrote: > Actually, if there is a astyle commandline that enforces the right style, could you paste it here? Um (?) I had in mind it was on the Kate HP but couln'd find it now. But it's there

D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

2018-12-26 Thread loh tar
loh.tar added a comment. > Btw., have you perhaps played a bit with the https://phabricator.kde.org/D12295 patch? No, but noticed it sometime in the past > If you use it, could you try that patch, too? Will try it REPOSITORY R39 KTextEditor REVISION DETAIL

D17730: [WIP] Review KateStatusBar (based on D17729)

2018-12-26 Thread loh tar
loh.tar updated this revision to Diff 48237. loh.tar edited the test plan for this revision. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - All in one diff - Rebased on master - Removed test plan - Will update Summary/Title before you commit

D17730: [WIP] Review KateStatusBar (based on D17729)

2018-12-26 Thread loh tar
loh.tar updated this revision to Diff 48236. loh.tar edited the summary of this revision. loh.tar added a comment. - Only show lineColLabel context menu when click on it and not somewhere on the bar As "usual" without all other patches. > No idea how the spell-checking code handles

D17730: [WIP] Review KateStatusBar (based on D17729)

2018-12-23 Thread loh tar
loh.tar added a comment. > My main intent is to add somehow a spell check button/hint Here a snapshot how it looks currently F6503235: 1545570321.png Sadly stuck I now, every help is appreciated I like to show on the button the current

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

2018-12-23 Thread loh tar
loh.tar updated this revision to Diff 48054. loh.tar added a comment. - Run astyle again, this time with "--align-pointer=name" - Omit changes done in the signal/slot connect code because these need a port to the new style. Well, was somehow pointless because these code is changed anyway

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

2018-12-23 Thread loh tar
loh.tar added a comment. - It's a prearrangement for more changes D17730 - In the meantime I noticed that these astyle command did not move/fix to place "*&" to the right. I will update/fix this before someone like to commit REPOSITORY R39

D17733: ViewPrivate: Don't hide 'Clear Dictionary Ranges' action

2018-12-22 Thread loh tar
loh.tar created this revision. loh.tar added reviewers: KTextEditor, VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Toggle the action instead enable/disable ensure the user

D17730: [WIP] Review KateStatusBar (based on D17729)

2018-12-22 Thread loh tar
loh.tar updated this revision to Diff 48000. loh.tar edited the summary of this revision. loh.tar added a comment. - KateStatusBar: Move the modified-label from far right to far left Once again without all other patches REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17730: [WIP] Review KateStatusBar (based on D17729)

2018-12-22 Thread loh tar
loh.tar added a comment. How about to change the "action-labels" to buttons? Thisway would it be less "quirky" and we would have a feedback that there is an action available when hovered by mouse REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To:

D17730: [WIP] Review KateStatusBar (based on D17729)

2018-12-22 Thread loh tar
loh.tar added a comment. Oops, have now the first commit omitted in this update. Perhaps not too bad this way(?) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To: loh.tar, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh,

D17730: [WIP] Review KateStatusBar (based on D17729)

2018-12-22 Thread loh tar
loh.tar updated this revision to Diff 47998. loh.tar edited the summary of this revision. loh.tar added a comment. - KateStatusBar: Don't treat click in empty area as click on mode-label REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17730: [WIP] Review KateStatusBar (based on D17729)

2018-12-22 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - KateStatusBar: Do actions on labels by single click instead

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

2018-12-22 Thread loh tar
loh.tar added a comment. Nothing else was done REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17729 To: loh.tar, #ktexteditor, dhaumann Cc: kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17729: KateStatusBar: Reformatted by astyle command to follow coding style

2018-12-22 Thread loh tar
loh.tar created this revision. loh.tar added reviewers: KTextEditor, dhaumann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-21 Thread loh tar
loh.tar updated this revision to Diff 47966. loh.tar added a comment. Improve the readability and prevent unwanted lookup by caching d(this) as dd REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17459?vs=47963=47966 REVISION DETAIL

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-21 Thread loh tar
loh.tar added inline comments. INLINE COMMENTS > anthonyfieroni wrote in katesearchbar.cpp:860-865 > Maybe not an issue, but you can try to cache value preventing unwanted lookup > > auto dd = d(this); > dd->... Only here or everywhere? At this particular place may that optimized by the

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-21 Thread loh tar
loh.tar added a comment. I have tried to run two S jobs at the same time on the same document, seems to works nicely - view 1 -> S "tab" -> "-" - view 2 -> S "0" -> "+" I had canceled both jobs and then resume, that's why at the pic are already replacents to see while the job is

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-21 Thread loh tar
loh.tar updated this revision to Diff 47963. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Fix crash when the document will closed while a S job is running - Fix crash when the view will closed while a S job is running These fixes seems to

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-20 Thread loh tar
loh.tar updated this revision to Diff 47907. loh.tar added a comment. Fixed/Simplified as suggested - I noticed a reproducible crash when e.g. Kate will closed while a S is running. Happens also when a split view is closed (so far so good) and then Kate will closed . I will try to solve

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-20 Thread loh tar
loh.tar updated this revision to Diff 47891. loh.tar added a comment. - Workaround to keep binary compatibility > It's exported class you cannot... Argh! How can I see this quickly the next time? KTEXTEDITOR_EXPORT ? - Seams still to work so far, but looks not so lovely -

D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

2018-12-20 Thread loh tar
loh.tar added a comment. > the change from QChar to const QChar & does not improve the amount of copied data. Argh! OK. Was just an impulse to do it as usual and to follow isStartBracket(..) and isBracket(..) Will wait for further advice REPOSITORY R39 KTextEditor REVISION DETAIL

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-19 Thread loh tar
loh.tar edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D17459 To: loh.tar, #ktexteditor, #vdg, cullmann Cc: brauch, cullmann, abetts, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars, dhaumann

D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

2018-12-19 Thread loh tar
loh.tar added a comment. Should you dislike the auto bracket code changes can I remove them from this patch. They are not needed for this one and only be the byproduct of my code studying. As always, poor tested :-) REPOSITORY R39 KTextEditor REVISION DETAIL

D17693: DocumentPrivate: Treat angle bracket < and backtick ` also as "auto bracket" when we have a selection

2018-12-19 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY The first attempt was to add these chars to the auto bracket

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-19 Thread loh tar
loh.tar updated this revision to Diff 47843. loh.tar added a comment. - Fix too much stretching of Cancel|Find/Replace button (I misunderstood probably Andres above :-) - Add S progress hint, Rename showInfoMessage(..) -> showResultMessage() and move logic in what text to show Notes:

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

2018-12-18 Thread loh tar
loh.tar added a comment. - No sure if there must be something at other places considered - This is my second version where the wrap is done ether at the static setting or the view width, whatever is smaller. At first is was always wrapped at the static setting. Then I thought it may this

D17661: ViewConfig: Add 'Dynamic Wrap At Static Marker' option

2018-12-18 Thread loh tar
loh.tar created this revision. loh.tar added reviewers: KTextEditor, VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Without this patch is in "Dynamic Wrap Mode" the text

D17631: class Message: Use inclass member initialization

2018-12-16 Thread loh tar
loh.tar accepted this revision. loh.tar added a comment. This revision is now accepted and ready to land. I'm surprised. Obviously have you change something previous (?) REPOSITORY R39 KTextEditor BRANCH message_inclass_member_initializationa REVISION DETAIL

D17624: KTextEditor::Message: Review documentation

2018-12-16 Thread loh tar
loh.tar added a comment. Sorry for the hassle, will revert the update > Further, I would prefer autoHideDelay instead of just delay. Are you refering here to the header or the code part? The old name in the header was "autoHideTimeR" which is pretty wrong. So have I to change this

D17624: KTextEditor::Message: Review documentation

2018-12-16 Thread loh tar
loh.tar updated this revision to Diff 47678. loh.tar added a comment. -Rename member autoHide->delay to fit accepted change in header file just an offer CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17624?vs=47673=47678 REVISION DETAIL https://phabricator.kde.org/D17624

D17624: KTextEditor::Message: Review documentation

2018-12-16 Thread loh tar
loh.tar updated this revision to Diff 47673. loh.tar added a comment. - Fix optionally/optional + be I like to suggest that some more eyes take a look at that :-) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17624?vs=47669=47673 REVISION DETAIL

D17624: KTextEditor::Message: Review documentation

2018-12-16 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Reduce redundant text - Change some argument names in the

D17310: Improve Kile icon with LaTeX font

2018-12-16 Thread loh tar
loh.tar added a comment. The used traffic cone by VLC is for me also nondescript, but that's their icon and therefore we know it. My point is only that your new icon should be somehow similar to the stuff used by Kile, and not to try to describe what we can do with Kile. Should I miss

D17609: KTextEditor: Add action for static word wrap

2018-12-15 Thread loh tar
loh.tar created this revision. loh.tar added reviewers: KTextEditor, VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - Move "Show Static Word Wrap Marker" code some lines up

D17609: KTextEditor: Add action for static word wrap

2018-12-15 Thread loh tar
loh.tar added a comment. - Not well tested - Slot code may not fit coding style but looks not bad to me - No Ampersand & short cut set as done by other actions REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17609 To: loh.tar, #ktexteditor, #vdg Cc:

D17310: Improve Kile icon with LaTeX font

2018-12-14 Thread loh tar
loh.tar added a comment. For me is these root sign nondescript. When the orig old blue symbol is not desired, how about to freshen it up? How? I don't know. Perhaps Black & White just as all your other offers on these rectangular sheet of paper? Furthermore exist these splash-screen. So

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-11 Thread loh tar
loh.tar updated this revision to Diff 47408. loh.tar added a comment. - Use new (dis)connect style in touched functions - Clean-Up no longer needed MovingRange Thanks for the explaining. Sounds like QScopedPointer(?) I have not used any of them now because it looked to me to have not

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-11 Thread loh tar
loh.tar added a comment. In D17459#375429 , @cullmann wrote: > I am atm a bit busy Thanks for the hint > For the input range, I think it would make sense to store it as std::unique_ptr to have it taking care of "edits" in-between

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-11 Thread loh tar
loh.tar updated this revision to Diff 47380. loh.tar added a comment. - Fix to remember loop state CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17459?vs=47379=47380 REVISION DETAIL https://phabricator.kde.org/D17459 AFFECTED FILES src/search/katesearchbar.cpp

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-11 Thread loh tar
loh.tar updated this revision to Diff 47379. loh.tar added a comment. - Fix crash in replace mode CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17459?vs=47362=47379 REVISION DETAIL https://phabricator.kde.org/D17459 AFFECTED FILES src/search/katesearchbar.cpp

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-11 Thread loh tar
loh.tar updated this revision to Diff 47362. loh.tar edited the summary of this revision. loh.tar added a comment. - Code cosmetic - Add singleShot stuff That's my first draft of that requested singleShot approach, help is now appreciated. - Replace crashes due to (I think) these

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-10 Thread loh tar
loh.tar added a comment. > everything could have happened, e.g. the search bar got deleted because the view got delete OK, but I still do not see why that will be different with that singleShot approach. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17459

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-10 Thread loh tar
loh.tar added a comment. Hmpf! Some googling didn't help. Just some thoughts. - Adding a couple of checks where ever just to block in case of a running S could be a little cumbersome - What we need would be an QObject::processEvents, so that only the Cancle button is a live but no

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-10 Thread loh tar
loh.tar added a comment. > That always leads to evil things, like e.g. what happens if you press the X button of the view/window during that. I assume you have read that article a longer time ago and have these paragraph regarding `Manual event processing` in mind. > This

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-10 Thread loh tar
loh.tar updated this revision to Diff 47275. loh.tar added a comment. - Check every 500 lines or 100 machtes, whatever is first - Fix false check due to wrong math as long no match was found REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-09 Thread loh tar
loh.tar added a comment. > I would probably not make the button that big There are two reasons why it is so big: 1. It's handy. You do not have to move the mouse, no matter which button was clicked 2. It "covers" both buttons to avoid a re-start of any such action without

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-09 Thread loh tar
loh.tar added a comment. Not well tested but looks so far pretty promising. The only thing what I not really like is these modulo check when to ask for user input. How about a QTimer with 200/300ms? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17459 To:

D17459: SearchBar: Add Cancel button to stop long running tasks

2018-12-09 Thread loh tar
loh.tar created this revision. loh.tar added reviewers: KTextEditor, VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY Without this patch could it happens that Kate run an

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

2018-12-09 Thread loh tar
loh.tar added a comment. Um, I'm bit confused when I now look at the diff 1/2 here??? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17030 To: loh.tar, #frameworks, #vdg, ngraham, cullmann Cc: cullmann, ngraham, kde-frameworks-devel, michaelh, bruns

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

2018-12-09 Thread loh tar
loh.tar updated this revision to Diff 47194. loh.tar added a comment. - Add @since hint to speller.h - Add some blank lines to speller.h to be looking a little bit nicer REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17030?vs=45842=47194 REVISION DETAIL

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

2018-12-09 Thread loh tar
loh.tar added a comment. In D17030#373912 , @cullmann wrote: > Ah, one thing: Could you add some @since 5.xxx to the new function in speller.h? Only in speller? In settings_p.h are also two new, but there was no docu, so I also wrote

D17441: tune editing actions for large number of small edits

2018-12-09 Thread loh tar
loh.tar added a comment. > Yes, there is now a limit for how many highlightings are done. > If its too much, we skip that, else the rendering will break everthing down ;=) Doing these highliting "on the fly" (only what is/became visible) is probably not possible(?) BTW: Thanks a

D17437: SearchBar: Avoid malfunction with very large files

2018-12-09 Thread loh tar
loh.tar added a comment. In this state was this patch only a simple attempt to avoid the worst case. With your new improvements is it much less likely to happen, but still possible. I do not like to insist of this patch it's only an offer, which could be improved. BTW I'm working on

D17441: tune editing actions for large number of small edits

2018-12-09 Thread loh tar
loh.tar added a comment. > This needs now some user testing ;=) Done as previous, with that testfile. Seams to work so far. Find is still quick, these TAB S takes around 2min. The only curiosity I noticed is that no highliting take effect when there are too much hits(?) Search some

D17441: tune editing actions for large number of small edits

2018-12-09 Thread loh tar
loh.tar added inline comments. INLINE COMMENTS > cullmann wrote in katetextblock.cpp:290 > Ok, doesn't work due to the issue that we might delete the range via notifier > in checkValidity() :P Noob question: Would QPointer help? if (range && range->isValidityCheckRequired()) { REPOSITORY

D17441: tune editing actions for large number of small edits

2018-12-08 Thread loh tar
loh.tar added a comment. I have tried this one. Yes, works much more better! Nice to see that my own (unloved) patch wake your interest to dig into that issue :-) As usual understand I most of your talk here not really, and these perf protocols give me no light on the first sight.

D17437: SearchBar: Avoid malfunction with very large files

2018-12-08 Thread loh tar
loh.tar added a comment. Would be good you take the time and do that test @cullmann When you then think it is still useful to soften that limit let me know how. To become that code more smart as you suggest I have right now not the mood, sorry. I think this patch is good enough to avaoid

D17437: SearchBar: Avoid malfunction with very large files

2018-12-08 Thread loh tar
loh.tar added a comment. - The mentioned crash could I not reproduce, but after 5 million hits and a felt eternity I had killed Kate - There is an issue now with the wrap message, where is now the same close button. Any ideas what's wrong? - I like to suggest to get rid of most of that S

D17437: SearchBar: Avoid malfunction with very large files

2018-12-08 Thread loh tar
loh.tar created this revision. loh.tar added reviewers: KTextEditor, VDG. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY This is only a workaround to avoid cases where Kate can

D17128: DocumentPrivate: Remove comment mark when joining lines

2018-12-08 Thread loh tar
loh.tar added a comment. Thanks for your input Dominik. In the meanwhile I noticed (again) these "Smart-Return" function (I noticed, and used that a couple of years for a short time period, but forgot that somehow) A reverse version of that should be nice. And somehow the possibility to

D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style

2018-12-08 Thread loh tar
loh.tar added a comment. In D17382#372925 , @dhaumann wrote: > sorry for the delay :( What? No, it was pretty fast :-) But I have a couple of Sonnet stuff where no progress happens :-/ REPOSITORY R39 KTextEditor REVISION DETAIL

D9077: Bug 377342 Question

2018-12-08 Thread loh tar
loh.tar added subscribers: cullmann, loh.tar. loh.tar added a comment. Herald edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. @cullmann I thing you could give a short hint But perhaps is @christofg no longer interested to work on this issue REPOSITORY

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

2018-12-07 Thread loh tar
loh.tar edited the summary of this revision. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17030 To: loh.tar, #frameworks, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

2018-12-07 Thread loh tar
loh.tar added a comment. #Frameworks Ping! (?) REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17030 To: loh.tar, #frameworks, #vdg, ngraham Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style

2018-12-06 Thread loh tar
loh.tar added a comment. Without any special "Oh, that would be nice", I will stop now with further S - I have tried to clean up a little bit the two header files, but that's more difficult than thought - m_cursor => cursorPosition() is also not so easy - There was no comment

D17382: KateViewInternal: Rename getMouse/Cursor() => mouse/cursorPosition() to fit coding style

2018-12-06 Thread loh tar
loh.tar created this revision. loh.tar added reviewers: KTextEditor, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL

D17257: KateViewInternal: S

2018-12-05 Thread loh tar
loh.tar added a comment. @cullmann Did you notice this? The other patches did you apply very quick, so I hope I didn't unsettle you with my comments. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17257 To: loh.tar, #ktexteditor, cullmann Cc: kwrite-devel,

D17028: Loader: Avoid Q_FOREACH

2018-11-30 Thread loh tar
loh.tar added a comment. >> @cfeck wrote: > > It looked strange on the list of names of all committers. A look at your page indicates that you are doing some public relations? Should you copy some data from an auto generated list, feel free to remove me. REPOSITORY R246 Sonnet

D17028: Loader: Avoid Q_FOREACH

2018-11-30 Thread loh tar
loh.tar added a comment. > ..but I cannot remember we didn't ask contributors for their real name for contributions. Um, what? I was asked. I hope it's ok as it is. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17028 To: loh.tar, davidedmundson Cc: cfeck,

D17028: Loader: Avoid Q_FOREACH

2018-11-30 Thread loh tar
loh.tar added a comment. Well, neither of that. My "online me" is loh.tar but that was rejected by Phabricator, so the dot had to go. Lastly used ngraham uppercase letters, what looks even more strange to me :-) Should you intend to commit this, thanks in advance! May you look at D17055

D17028: Loader: Avoid Q_FOREACH

2018-11-30 Thread loh tar
loh.tar added a comment. @davidedmundson May I ask how does this here will progress? You seemed to request a change which was not clear to me, but it's anyway "green flagged". REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17028 To: loh.tar, davidedmundson Cc:

D17257: KateViewInternal: S

2018-11-30 Thread loh tar
loh.tar added a comment. Only 'm_view->' => 'view()' has plenty of hits, the others only a few. Please do a grep for m_startPos. To replace these few would require a changed or added function. Last note: I hope you test all these changes thoroughly. At the last mentioned

D17257: KateViewInternal: S

2018-11-30 Thread loh tar
loh.tar created this revision. loh.tar added reviewers: KTextEditor, cullmann. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - 'm_view->' => 'view()' - 'm_startPos.line()' =>

D17237: KTextEditor::ViewPrivate: S

2018-11-29 Thread loh tar
loh.tar added a comment. I can split it if you like in two diff - 'm_doc->' => 'doc()->' ~100 hits, perhaps not the best idea? A search for doc() has 24 hits (without this patch) - 'm_viewInternal->m_cursor' => 'cursorPosition()' ~10 hits Next would be look for inline candidates,

D17237: KTextEditor::ViewPrivate: S

2018-11-29 Thread loh tar
loh.tar created this revision. loh.tar added reviewers: cullmann, KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY - 'm_doc->' => 'doc()->' -

D17193: KateViewInternal: Remove unneeded functions

2018-11-29 Thread loh tar
loh.tar updated this revision to Diff 46473. loh.tar edited the summary of this revision. loh.tar edited the test plan for this revision. loh.tar added a comment. - Prefer function calls for member excess - Merge KateViewInternal::updateView with KateViewInternal::doUpdateView - Add

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

2018-11-28 Thread loh tar
loh.tar added a comment. Bug302689 - Impossible to delete unwanted dictionaries https://bugs.kde.org/show_bug.cgi?id=302689 Does not quite fit, but relieves the symptoms. Enough to close that? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17030 To: loh.tar,

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

2018-11-28 Thread loh tar
loh.tar added a comment. No, but that's fine. One thing less where I can make mistakes :-) Should your next question be regarding author ship, take a look at edbf2e36c805 Thanks. REPOSITORY R246 Sonnet

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

2018-11-28 Thread loh tar
loh.tar added a comment. Um, no(?) In that case I would have named this patch "Add stretch to ensure Dump button is expanding" Sorry, next time I try to describe the pics more precise. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17026 To: loh.tar, #frameworks,

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

2018-11-28 Thread loh tar
loh.tar edited the test plan for this revision. loh.tar added a reviewer: VDG. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17026 To: loh.tar, #frameworks, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17193: KateViewInternal: Remove unneeded functions

2018-11-28 Thread loh tar
loh.tar updated this revision to Diff 46411. loh.tar added a comment. I think that's all. Well, it looks less beneficial as previous anticipated by me, but I think it's still the right direction. Just a view questions regarding the mix in the KTextEditor::ViewPrivate code how to

D17013: Show menu bar, how to re-enable, common shortcut dialog

2018-11-27 Thread loh tar
loh.tar added a comment. Hi, I accidentally went by. How about to add an icon to some (main) toolbar, if any is present? That would the need to show such a message reduce to cases where no tool bar is available. If that icon was added, and not already there, could that pop up a small

D17193: KateViewInternal: Remove unneeded functions

2018-11-27 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. TEST PLAN This is only an example snippet to show that obviously something

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

2018-11-26 Thread loh tar
loh.tar edited the test plan for this revision. loh.tar added a reviewer: VDG. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17030 To: loh.tar, #frameworks, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17128: DocumentPrivate: Remove comment mark when joining lines

2018-11-25 Thread loh tar
loh.tar added a comment. > I am not sure if the normal join lines should try to be that clever. But consider the "auto comment" feature after you hit "Return", it's also somehow "special clever" but very useful. This tries to add the corresponding functionality. Well, the true opposite

D17056: Dialog: Use DictionaryComboBox instead of plain QComboBox

2018-11-24 Thread loh tar
loh.tar added a reviewer: Frameworks. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17056 To: loh.tar, #frameworks Cc: mludwig, kde-frameworks-devel, michaelh, ngraham, bruns

D17055: Avoid Q_FOREACH

2018-11-24 Thread loh tar
loh.tar added a reviewer: davidedmundson. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17055 To: loh.tar, davidedmundson Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17030: DictionaryComboBox: Keep user preferred dictionaries on top

2018-11-24 Thread loh tar
loh.tar added a reviewer: Frameworks. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17030 To: loh.tar, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17026: DictionaryComboBoxTest: Add stretch to avoid expanding Dump button

2018-11-24 Thread loh tar
loh.tar added a reviewer: Frameworks. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D17026 To: loh.tar, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17128: DocumentPrivate: Remove comment mark when joining lines

2018-11-23 Thread loh tar
loh.tar added a comment. This works so far in most cases I have tried. - C/C++, // and /* */ works, but sadly not Oxygen style comments. Guess the single star is not as special marked. Could that be fixed in the highlight stuff? - Bash, # works - Ruby, # works - Python, # works

D17128: DocumentPrivate: Remove comment mark when joining lines

2018-11-23 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. loh.tar added a project: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ...from the next line

D17123: KTextEditor::ViewPrivate: Avoid warning "Text requested for invalid range"

2018-11-23 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: KTextEditor. loh.tar added a project: Frameworks. Herald added a project: Kate. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ...when cut or copy a line without

D17103: SpellCheckBar: Use DictionaryComboBox instead of plain QComboBox

2018-11-22 Thread loh tar
loh.tar added a comment. It would be nice someone could explain, or point me where to read, why there is no (more) direct use of Sonnet stuff in KTextEditor/Kate. 1. KTextEditor::SpellCheckBar looks (almost) the same as Sonnet::Dialog but has differently ingredients. I had expect, after

D17103: SpellCheckBar: Use DictionaryComboBox instead of plain QComboBox

2018-11-22 Thread loh tar
loh.tar created this revision. loh.tar added a reviewer: cullmann. loh.tar added a project: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY This patch alone is

D17028: Loader: Avoid Q_FOREACH

2018-11-20 Thread loh tar
loh.tar added inline comments. INLINE COMMENTS > davidedmundson wrote in loader.cpp:273 > > Probably, yes. But Qt docu always says, "thanks to implicit sharing copying > > a container is very fast" > > That's mixing up docs. > > foreach() always does a const copy of the list. This is a cheap

D17056: Dialog: Use DictionaryComboBox instead of plain QComboBox

2018-11-20 Thread loh tar
loh.tar created this revision. Herald added a project: Frameworks. loh.tar requested review of this revision. REVISION SUMMARY This patch alone is reasonable but become really important with the aim of D17030 REPOSITORY R246 Sonnet REVISION DETAIL

D17055: Avoid Q_FOREACH

2018-11-20 Thread loh tar
loh.tar created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. loh.tar requested review of this revision. REVISION SUMMARY VoikkoDict, HunspellClient, HSpellDict, GuessLanguage, parsetrigrams REPOSITORY R246 Sonnet REVISION DETAIL

<    1   2   3   4   5   >