Re: 5.87 respin request

2021-10-04 Thread Ahmad Samir
On 10/4/21 14:01, David Faure wrote: On lundi 4 octobre 2021 13:22:22 CEST Ahmad Samir wrote: On 10/3/21 08:29, Ahmad Samir wrote: Please include https://invent.kde.org/frameworks/kwidgetsaddons/-/commit/99d8dca607327ebf 0b6d2f3cff089207c61d7276 Fixes https://bugs.kde.org/show_bug.cgi?id

Re: 5.87 respin request

2021-10-04 Thread Ahmad Samir
On 10/3/21 08:29, Ahmad Samir wrote: Please include https://invent.kde.org/frameworks/kwidgetsaddons/-/commit/99d8dca607327ebf0b6d2f3cff089207c61d7276 Fixes https://bugs.kde.org/show_bug.cgi?id=442332 Regards, Ahmad Samir And https://invent.kde.org/frameworks/kwidgetsaddons/-/commit

5.87 respin request

2021-10-03 Thread Ahmad Samir
Please include https://invent.kde.org/frameworks/kwidgetsaddons/-/commit/99d8dca607327ebf0b6d2f3cff089207c61d7276 Fixes https://bugs.kde.org/show_bug.cgi?id=442332 Regards, Ahmad Samir

Re: KF API Documentation proposed, small, addition

2021-09-10 Thread Ahmad Samir
On 09/09/2021 23:34, Friedrich W. H. Kossebau wrote: Am Donnerstag, 9. September 2021, 23:23:29 CEST schrieb Ahmad Samir: On 09/09/2021 22:47, Friedrich W. H. Kossebau wrote: Am Donnerstag, 9. September 2021, 22:35:05 CEST schrieb Ahmad Samir: On 09/09/2021 22:24, Friedrich W. H. Kossebau

Re: KF API Documentation proposed, small, addition

2021-09-09 Thread Ahmad Samir
On 09/09/2021 22:47, Friedrich W. H. Kossebau wrote: Am Donnerstag, 9. September 2021, 22:35:05 CEST schrieb Ahmad Samir: On 09/09/2021 22:24, Friedrich W. H. Kossebau wrote: Am Donnerstag, 9. September 2021, 21:45:33 CEST schrieb Ahmad Samir: On 30/08/2021 16:35, Friedrich W. H. Kossebau

Re: KF API Documentation proposed, small, addition

2021-09-09 Thread Ahmad Samir
On 09/09/2021 22:24, Friedrich W. H. Kossebau wrote: Am Donnerstag, 9. September 2021, 21:45:33 CEST schrieb Ahmad Samir: On 30/08/2021 16:35, Friedrich W. H. Kossebau wrote: Thanks for pushing this here. Am Montag, 30. August 2021, 14:17:42 CEST schrieb Ahmad Samir: Open question: in which

Re: KF API Documentation proposed, small, addition

2021-09-09 Thread Ahmad Samir
On 30/08/2021 16:35, Friedrich W. H. Kossebau wrote: Thanks for pushing this here. Am Montag, 30. August 2021, 14:17:42 CEST schrieb Ahmad Samir: I would like to add the following to: https://community.kde.org/Frameworks/Frameworks_Documentation_Policy#Documen t_the_Classes One can use

Please include this in 5.86

2021-09-05 Thread Ahmad Samir
Fixes KMountPoint::findByPath(): https://invent.kde.org/frameworks/kio/-/commit/147193f5661173d24d75f6558e5607d3418f6c71 Thanks, Ahmad Samir

KF API Documentation proposed, small, addition

2021-08-30 Thread Ahmad Samir
/typewriter font face, typically e.g. @c true, @c false, @c setSomeValue(); for multiple words you'll have to use: multiple words * @copydoc to copy the docs of a different method, e.g. if one method overloads another -- Ahmad Samir

Heads-up: kioslaves .so libs have been renamed

2021-07-30 Thread Ahmad Samir
-dir, as most of us do) or from your kdesrc-build installation; so you may want to clear up that situation. That leads to interesting issue, as kioslave5 binary could pick either kf5/kio/file.so or kf5/kio/kio_file.so and you get weird results. Have a good day. -- Ahmad Samir

Re: Porting notes / deprecation docs

2021-07-10 Thread Ahmad Samir
t in my usual editor of choice). FWIW, there is supposed to be a KF6 meeting soon[1]. Not sure if we'll start this week or the next one though. [1] https://mail.kde.org/pipermail/kde-frameworks-devel/2021-July/118028.html Thanks! Cheers, Frederik -- Ahmad Samir

Re: Weekly KF6 meeting poll

2021-07-10 Thread Ahmad Samir
On 09/07/2021 19:08, Ahmad Samir wrote: On 29/06/2021 16:48, Ahmad Samir wrote: Hello, as was discussed during the KF6 BoF at Akademy, David Edmundson (aka "David 2", not to be confused with "David 1" aka "4" or David 3, aka "the David who still has all

Re: Weekly KF6 meeting poll

2021-07-09 Thread Ahmad Samir
On 29/06/2021 16:48, Ahmad Samir wrote: Hello, as was discussed during the KF6 BoF at Akademy, David Edmundson (aka "David 2", not to be confused with "David 1" aka "4" or David 3, aka "the David who still has all the hair on his head"... sorry,

Weekly KF6 meeting poll

2021-06-29 Thread Ahmad Samir
ll as a way to find a more suitable time for the weekly KF6 meeting (that we used to have on Saturdays 13:00 UTC), apparently the link might have gone too far under the radar in the KF6 meeting notes that were posted to this ML by Volker. So here it is, please vote: https://doodle.com/poll/94646r75keyxgqkx Have a good day. -- Ahmad Samir

Re: KF5 modules development branches now build in C++17 mode (but keep public headers compatible)

2021-06-20 Thread Ahmad Samir
, it does make sense to disable compiler specific extensions. Cheers, Albert > -- Ahmad Samir

Pushing and creating a merge request from the command line

2021-06-17 Thread Ahmad Samir
a good day. -- Ahmad Samir

Weekly meeting reminder

2021-06-12 Thread Ahmad Samir
/project/board/310/, we're supposed to whittle it down if we want to finally, branch for KF6, no rush, but it should hopefully happen at some point, preferably during our lifetimes. :) All are welcome to join, even if you just want to listen/see how things are done in KDE. Have a good day. -- Ahmad

KF6 weekly meeting

2021-06-05 Thread Ahmad Samir
things are done in KDE. Have a good day. -- Ahmad Samir

KF6 weekly meeting

2021-05-29 Thread Ahmad Samir
stuff are discussed, maybe there is a task there that has your name on it, something that intrigues you and you'd like to work on ...etc. Have a good day. -- Ahmad Samir

KF6 weekly meeting

2021-05-22 Thread Ahmad Samir
to take this chance to thank Luigi, who somehow can keep track of all the tasks being discussed and posts the meeting notes on this ML every week o/). Have a good day. -- Ahmad Samir

T14471: Make Qt 5.15.0 to 5.15.2 for frameworks

2021-05-19 Thread Ahmad Samir
ahmadsamir added a comment. Anything other than the methods that were added for "portability at the expense of performance", should be OK, famous last words™. :) I've been bitten twice by the QStringView API in Qt5, it has too many surprises, basically because upstream decided to make

KF6 weekly meeting reminder

2021-05-15 Thread Ahmad Samir
trying to chisel away at the ever growing KF6 tasks board https://phabricator.kde.org/project/board/310/ Have a good day. -- Ahmad Samir

Re: Including instead of , does it upset POSIX?

2021-04-21 Thread Ahmad Samir
On 21/04/2021 15:34, Ahmad Samir wrote: On 21/04/2021 15:20, Harald Sitter wrote: To conclude this our verdict is to always use the modern headers? I am re-checking the rest of the frameworks that failed the first time around; Albert already reported that it built for him locally

Re: Including instead of , does it upset POSIX?

2021-04-21 Thread Ahmad Samir
and if the CI doesn't barf on any of it, then my conclusion is it's OK so far. -- Ahmad Samir

Re: Including instead of , does it upset POSIX?

2021-04-15 Thread Ahmad Samir
. Thanks for re-checking. Cheers, Albert -- Ahmad Samir

Re: Including instead of , does it upset POSIX?

2021-04-15 Thread Ahmad Samir
On 14/04/2021 22:20, Albert Astals Cid wrote: El dimecres, 14 d’abril de 2021, a les 15:13:09 (CEST), Ahmad Samir va escriure: Hello :) A week or so ago I created an MR to include instead of in KIO[1]. From /usr/include/c++/10/cerrno: /** @file cerrno * This is a Standard C

Including instead of , does it upset POSIX?

2021-04-14 Thread Ahmad Samir
we use stuff specifically with the expectation that they will behave as documented from a POSIX or linux POV (such as signal safety in kcrash) [1] https://invent.kde.org/frameworks/kio/-/merge_requests/397 -- Ahmad Samir

Saturday, 2021-04-11 KF6 meeting notes

2021-04-11 Thread Ahmad Samir
drawback on using a list of KCMs instead of a single KCM. What we forgot to do is pick the tasks for discussion for the next meeting, so if you have suggestions please post them somewhere (on this ML would work best). -- Ahmad Samir

Request for wide spread testing

2021-03-30 Thread Ahmad Samir
day. -- Ahmad Samir

clang-format section added to the coding style guide

2021-03-29 Thread Ahmad Samir
so that it doesn't mangle your code) Have a good day. :) -- Ahmad Samir

D27224: add Kongress icon

2021-01-31 Thread Ahmad Samir
ahmadsamir added a comment. Hello. FWIW, I would also close/abandon this diff :) (nice icon BTW). REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27224 To: mbruchert, dkardarakos, #vdg, ndavis Cc: ahmadsamir, ndavis, kde-frameworks-devel, LeGast00n, cblack,

Re: RFC: Switching to min Qt version 5.14 for KF on December 14th

2020-12-17 Thread Ahmad Samir
5.13 is essentially unavailable" That's why team jumped to 5.14 directly, don't know the details however. [...] -- Ahmad Samir

T8349: Improve Places panel usability and presentation

2020-10-18 Thread Ahmad Samir
ahmadsamir added subscribers: sitter, ahmadsamir. ahmadsamir added a comment. ATM, the behaviour is that if you go to /foo/bar/baz/ and "bar" is present in the places panel, then while you're at baz or any of its sub-folders then "bar" is highlighted in the places panel, i.e the "closest"

Re: Dropping the moderation by default flag

2020-10-15 Thread Ahmad Samir
sent an email there and it was postponed due to moderation. Given that kde-core-devel and kde-frameworks-devel are similar, could you please set that same setting for kde-core-devel too? Thanks. :) -- Ahmad Samir

"Approve"ing an MR

2020-10-04 Thread Ahmad Samir
d by bshah at https://gitlab.com/gitlab-org/gitlab/-/issues/231351 Have a good day :) -- Ahmad Samir

Re: KIO on Android Failure

2020-08-18 Thread Ahmad Samir
to guard it with !defind(Q_OS_ANDROID). Should hopefully be fixed by https://invent.kde.org/frameworks/kio/-/merge_requests/107 . -- Ahmad Samir

D28460: Add KCModuleData as base class for plugin

2020-08-14 Thread Ahmad Samir
ahmadsamir closed this revision. ahmadsamir added a comment. Has been moved to https://invent.kde.org/frameworks/kcmutils/-/merge_requests/10 REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D28460 To: bport, #plasma, ervin Cc: ahmadsamir, meven, broulik,

D28460: Add KCModuleData as base class for plugin

2020-08-14 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > kcmoduleloader.cpp:164 > + > +QVariantList args2(args.cbegin(), args.cend()); > + Hello. This breaks the build for Qt 5.12 on the CI, (the min. required version in KF is still 5.12):

D28774: [KFontRequester] Port from QFontDialog to KFontChooserDialog

2020-07-30 Thread Ahmad Samir
ahmadsamir added a comment. In D28774#676000 , @volkov wrote: > Why not add support for `QPlatformTheme::FontDialog` in `KdePlatformTheme::createPlatformDialogHelper()`? Sorry about the late reply; I had looked into the platformtheme

D28880: [KWallet] Port last usage of QRegExp to QRegularExpression

2020-06-12 Thread Ahmad Samir
ahmadsamir added a comment. @blaze, (I couldn't find your user name at invent.kde.org); FYI: https://invent.kde.org/network/falkon/-/merge_requests/7 REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D28880 To: ahmadsamir, #frameworks, dfaure, blaze Cc:

D29017: WIP: Introduce three new methods that return all "entries" in a folder

2020-06-07 Thread Ahmad Samir
ahmadsamir abandoned this revision. REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D29017 To: ahmadsamir, #frameworks, dfaure Cc: blaze, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29017: WIP: Introduce three new methods that return all "entries" in a folder

2020-06-07 Thread Ahmad Samir
ahmadsamir reopened this revision. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. Move to gitlab https://invent.kde.org/frameworks/kwallet/-/merge_requests/2 REPOSITORY R311 KWallet REVISION DETAIL https://phabricator.kde.org/D29017 To: ahmadsamir, #frameworks,

D29810: Don't use the setenv function after fork

2020-06-07 Thread Ahmad Samir
ahmadsamir added a comment. In D29810#674824 , @jpalecek wrote: > In D29810#674815 , @dfaure wrote: > > > This breaks FreeBSD compilation. Please check:

D29017: WIP: Introduce three new methods that return all "entries" in a folder

2020-06-05 Thread Ahmad Samir
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R311:1a19afb6a06d: WIP: Introduce three new methods that return all entries in a folder (authored by ahmadsamir).

D29017: WIP: Introduce three new methods that return all "entries" in a folder

2020-06-05 Thread Ahmad Samir
ahmadsamir added a comment. In D29017#664279 , @blaze wrote: > Check this commit message https://phabricator.kde.org/R32:f56cdda54b7f88b119f2c7cfb2f534b4fe74478f Sorry for the delay. We applied a workable hack in

D29362: [KCharSelect] Initially give focus to the search lineedit

2020-05-31 Thread Ahmad Samir
ahmadsamir added a comment. Moved to https://invent.kde.org/frameworks/kwidgetsaddons/-/merge_requests/2 REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29362 To: ahmadsamir, #frameworks, cfeck Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D29362: [KCharSelect] Initially give focus to the search lineedit

2020-05-31 Thread Ahmad Samir
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R236:c0c93cc0fcb5: [KCharSelect] Initially give focus to the search lineedit (authored by ahmadsamir). REPOSITORY R236

D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

2020-05-29 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > kopenwithdialog.cpp:1009 > +if (QDir::isAbsolutePath(binaryName)) { > +QFileInfo fi(binaryName); > +if (fi.exists() && !fi.isExecutable()) { It's created on the next line. Anyway my initial comment

D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

2020-05-29 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > broulik wrote in kopenwithdialog.cpp:1008 > Actually, that doesn't exist https://doc.qt.io/qt-5.15/qfileinfo.html#isAbsolute ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29445 To: broulik, #frameworks, #vdg Cc:

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

2020-05-23 Thread Ahmad Samir
ahmadsamir added a comment. This wasn't landed on master, but rather phabricator is confused by me pushing to work/ branch on gitlab :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29782 To: ahmadsamir, #frameworks, dfaure, sitter Cc: kde-frameworks-devel,

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

2020-05-23 Thread Ahmad Samir
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R241:f2984ff28e72: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs (authored by ahmadsamir). CHANGED

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

2020-05-20 Thread Ahmad Samir
ahmadsamir added a comment. I guess a proper fix will need to revert part of this to have the KModuleInfo ctor that took a KService not use KPluginInfo internally; better still, of course, is having the KPluginInfo ctor work for the case of X-KDE-ServiceTypes=SystemSettingsExternalApp, (I

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

2020-05-20 Thread Ahmad Samir
ahmadsamir added a comment. systemsettings uses KCModuleInfo::service() to check whether the moduleinfo is valid[1], the problem is creating a KPluginInfo from the KService based on a .desktop file with X-KDE-ServiceTypes=SystemSettingsExternalApp fails because it doesn't seem to have valid

D28673: [PackageUrlInterceptor] Make QRegularExpression static

2020-05-19 Thread Ahmad Samir
ahmadsamir commandeered this revision. ahmadsamir added a reviewer: broulik. ahmadsamir added a comment. Should be handled by https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/2 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D28673: [PackageUrlInterceptor] Make QRegularExpression static

2020-05-19 Thread Ahmad Samir
ahmadsamir abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28673 To: ahmadsamir, #plasma, broulik Cc: ahmadsamir, bruns, pino, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham

D29800: Fix URL being passed as argument when launching a .desktop file

2020-05-17 Thread Ahmad Samir
ahmadsamir added a comment. In D29800#672399 , @fvogt wrote: > Landed to invent - hopefully correctly: https://invent.kde.org/frameworks/kio/commit/84e9372f4fa2636f57dc456ac2fa2be271d6a7ec LGTM. REPOSITORY R241 KIO REVISION DETAIL

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

2020-05-17 Thread Ahmad Samir
ahmadsamir added a comment. In D29558#672395 , @dfaure wrote: > Not committed after all. It was committed, as I had it when I did git pull, but you lucked out, it seemed to have been eaten by the migration to gitlab somehow; I had to

D29787: Fix krununittest

2020-05-17 Thread Ahmad Samir
ahmadsamir added a comment. In D29787#672139 , @dfaure wrote: > Let's hope the CI has xterm installed I doubt it. Maybe we'll need to pick "ls" instead, even if that will look weird. The CI seems to have xterm available as the unit

D29787: Fix krununittest

2020-05-16 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R241:ef7708d1f5ec: Fix krununittest (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29787?vs=82975=83011 REVISION DETAIL

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

2020-05-16 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R241:bed09e39fe24: [kio_file] Handle renaming file A to a on FAT32 filesystems (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29610?vs=82750=83010

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

2020-05-16 Thread Ahmad Samir
ahmadsamir added a comment. I've just realised, we won't get an error with an http url; in that case we return the url the statjob was called on as-is and cancel the job. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29782 To: ahmadsamir, #frameworks, dfaure, sitter

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

2020-05-16 Thread Ahmad Samir
ahmadsamir added a comment. In D29782#672157 , @dfaure wrote: > Can you add a unittest for a KIO::mostLocalUrl() in testtrash.cpp (which is :local, so it should work) I don't see where the trash ioslave sets UDS_LOCAL_PATH; I think it

D29787: Fix krununittest

2020-05-15 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY After 6452a34cf01d03d316 ,

D29782: [StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs

2020-05-15 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 82974. ahmadsamir retitled this revision from "[StatJob] Change mostLocalUrl to only handle protocols with Class=:local" to "[StatJob] Make mostLocalUrl ignore remote (ftp, http...etc) URLs". ahmadsamir edited the summary of this revision. ahmadsamir

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

2020-05-15 Thread Ahmad Samir
ahmadsamir added a comment. In D29385#671987 , @dfaure wrote: > That's the point, a NFS mount *is* a local URL, so we do use QFile for it. And then it takes forever because the kernel has to talk over a socket to answer us. > Yes this is

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

2020-05-15 Thread Ahmad Samir
ahmadsamir added a comment. In D29385#671980 , @dfaure wrote: > It's 3 times faster on my local SSD. > > Now think of a NFS mount on a server from another country I was thinking mostly of QFile when url.isLocalFile() is true, but

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

2020-05-15 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in openurljob.cpp:261 > LOL we're like an old couple, the explicit discussion doesn't actually need > to happen anymore ;) > > OK for everyone else, we're debating whether it's ok to use blocking > local-file I/O like QFile or

D29782: [StatJob] Change mostLocalUrl to only handle protocols with Class=:local

2020-05-15 Thread Ahmad Samir
ahmadsamir planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29782 To: ahmadsamir, #frameworks, dfaure, sitter Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

2020-05-15 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > kossebau wrote in openurljob.h:120 > You meant, according to > https://community.kde.org/Frameworks/Frameworks_Documentation_Policy#Document_Public_and_Protected_Members > :) I got the info from a commit in kwidgetsaddons where you "fixed" a

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

2020-05-15 Thread Ahmad Samir
ahmadsamir accepted this revision. ahmadsamir added a subscriber: kossebau. ahmadsamir added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > openurljob.h:120 > + * > + * @param b whether to only show the "open with" dialog. > + */ It seems that we

D29782: [StatJob] Change mostLocalUrl to only handle protocols with Class=:local

2020-05-15 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, sitter. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Previously mostLocalUrl would check that !url.isLocalFile(), that meant a statjob would be fired for

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

2020-05-15 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in file_unix.cpp:1052 > I'm confused. We want to solve renaming 'a' to 'A' when 'A' does *not* exist. > > QFile::rename will not overwrite an existing file, so it will do nothing if > dest exists. const QByteArray dest1 =

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

2020-05-13 Thread Ahmad Samir
ahmadsamir added a comment. In D29610#667858 , @dfaure wrote: > OK for now, to fix the unittests. The *real* fix however is to use QFile::rename in kio_file so that this failure to rename doesn't even happen in the first place. > > In this

D29610: [kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems

2020-05-13 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 82750. ahmadsamir retitled this revision from "[CopyJob] Use stricter conditions when using QFile::rename in slotResultRenaming" to "[kio_file] Handle renaming file 'A' to 'a' on FAT32 filesystems". ahmadsamir edited the summary of this revision.

D29610: [CopyJob] Use stricter conditions when using QFile::rename in slotResultRenaming

2020-05-10 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY The code now uses QFile::rename() only if direct renaming fails and we're moving a file/dir e.g. 'A' to 'a' on a

D29547: KRun: deprecate all static 'run*' methods, with full porting instructions

2020-05-10 Thread Ahmad Samir
ahmadsamir accepted this revision. ahmadsamir added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > dfaure wrote in krun.h:216 > I did, but Friedrich had a less confusing suggestion: > > @deprecated since 5.6. Since 5.71 use ApplicationLauncherJob, otherwise

D29547: KRun: deprecate all static 'run*' methods, with full porting instructions

2020-05-10 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > krun.h:216 > + * @deprecated since 5.6, use runApplication instead. > + * @deprecated since 5.71, use ApplicationLauncherJob instead. > + * @code I don't think you want both @deprecated? > krun.h:229 > */ > -

D29599: [CopyJob] Try to fix windows build

2020-05-10 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R241:d026227574b8: [CopyJob] Try to fix windows build (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29599?vs=82444=82447 REVISION DETAIL

D29599: [CopyJob] Try to fix windows build

2020-05-10 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY The windows build is failing on the CI because of S_IWUSR; include kioglobal_p.h to try and fix that.

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

2020-05-09 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in copyjob.cpp:444 > I'm a bit confused. My explanation here points to kio_desktop and kio_remote > (and was apparently clear), and the API docs for UDS_LOCAL_PATH say > > /// A local file path if the ioslave display files

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

2020-05-09 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R241:1cac602d9966: [CopyJob] Check free space for remote urls before copying and other improvements (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

2020-05-09 Thread Ahmad Samir
ahmadsamir added a comment. @dfaure please don't forget to flesh out the UDS_LOCAL_PATH docs https://phabricator.kde.org/D29485#inline-169199 REPOSITORY R241 KIO BRANCH l-freespace-remote-2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D29485 To: ahmadsamir,

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

2020-05-09 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in copyjob.cpp:477 > I'm assuming the TODO was about "What if I'm using a NFS mount and the > connection breaks at the time of KDiskFreeSpaceInfo, i.e. what should we do > about error handling". > > But I think the current code

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

2020-05-09 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 82334. ahmadsamir added a comment. Remove comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29485?vs=82305=82334 BRANCH l-freespace-remote-2 (branched from master) REVISION DETAIL

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

2020-05-09 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in copyjob.cpp:477 > This comment is now completely out of context. It used to be about NFS/SMB, > now this information has gone and one is left wondering why kind of > connections we're talking about (connection to the

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

2020-05-08 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 82305. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. "existingDest" is a better name for the var relating to m_asMethod REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29485?vs=82285=82305

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

2020-05-08 Thread Ahmad Samir
ahmadsamir marked an inline comment as done. ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in copyjob.cpp:430 > This is the same as "actualDest" too, so its definition could be moved > further up and shared with this too. > > (Not that the name is perfect --- when copying

D29528: [OpenUrlJob] Improve comments/docs

2020-05-08 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R241:1b9b239eb262: [OpenUrlJob] Improve comments/docs (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29528?vs=82286=82304 REVISION DETAIL

D29537: [CopyJob] Get rid of an old TODO and use QFile::rename()

2020-05-08 Thread Ahmad Samir
This revision was automatically updated to reflect the committed changes. Closed by commit R241:cb89bab36a5a: [CopyJob] Get rid of an old TODO and use QFile::rename() (authored by ahmadsamir). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29537?vs=82288=82303

D29537: [CopyJob] Get rid of an old TODO and use QFile::rename()

2020-05-08 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. TEST PLAN Renaming a dir A to a on a FAT32 partition still works REPOSITORY R241 KIO BRANCH l-qfile-rename (branched from

D29528: [OpenUrlJob] Improve comments/docs

2020-05-08 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 82286. ahmadsamir marked an inline comment as done. ahmadsamir added a comment. Address comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29528?vs=82260=82286 BRANCH l-late (branched from master) REVISION

D29528: [OpenUrlJob] Improve comments/docs

2020-05-08 Thread Ahmad Samir
ahmadsamir marked 2 inline comments as done. ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in openurljob.cpp:590 > That one was on purpose. I find this version less readable, mixing a test and > an actual action (with error handling). Fair point. REPOSITORY R241 KIO

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

2020-05-08 Thread Ahmad Samir
ahmadsamir updated this revision to Diff 82285. ahmadsamir marked 2 inline comments as done. ahmadsamir added a comment. Address comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29485?vs=82113=82285 BRANCH l-freespace-remote-2 (branched from master)

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

2020-05-08 Thread Ahmad Samir
ahmadsamir marked 2 inline comments as done. ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in copyjob.cpp:430 > Here you kept a comment that said "we want to check", but the check already > happened. > I'd say just remove the two lines of comments. > The code is clearer

D29528: [OpenUrlJob] Improve comments/docs

2020-05-08 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REPOSITORY R241 KIO BRANCH l-late (branched from master) REVISION DETAIL https://phabricator.kde.org/D29528 AFFECTED FILES

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

2020-05-08 Thread Ahmad Samir
ahmadsamir added a comment. In D29385#664552 , @dfaure wrote: > -void KIO::OpenUrlJob::setRunFlags(KIO::ApplicationLauncherJob::RunFlags runFlags) > +void KIO::OpenUrlJob::setDeleteTemporaryFile(bool b) > > The more I think about it, the

D25339: update lineHeight if boundingRect indicates a larger value.

2020-05-07 Thread Ahmad Samir
ahmadsamir added a comment. In D25339#665827 , @xuetianweng wrote: > [...] > As for higher line, it might not as bad as you thought as it actually might improve readability for many people. I agree with this statement :).

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

2020-05-06 Thread Ahmad Samir
ahmadsamir added a comment. I couldn't seem to test the m_privilegeExecutionEnabled stuff, i.e. using dolphin, the paste action is disabled if the dir isn't owned by me. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29485 To: ahmadsamir, #frameworks, dfaure, meven,

D29485: [CopyJob] Check free space for remote urls before copying and other improvements

2020-05-06 Thread Ahmad Samir
ahmadsamir created this revision. ahmadsamir added reviewers: Frameworks, dfaure, meven, sitter. Herald added a project: Frameworks. ahmadsamir requested review of this revision. REVISION SUMMARY Use KIO::FileSystemFreeSpaceJob to check free space for remote urls. Thanks to sitter for

D29445: [KOpenWithDialog] When pointing at a non-executable file print more meaningful error

2020-05-05 Thread Ahmad Samir
ahmadsamir added inline comments. INLINE COMMENTS > dfaure wrote in kopenwithdialog.cpp:1006 > Right, hence the isEmpty() here. This check passes if 1) it doesn't exist, or > 2) it's not executable. I was wondering how the QString returned by KIO::DesktopExecParser::executablePath() would

  1   2   3   4   5   6   7   8   9   10   >