Re: portal drag and drop helpers and where to put them

2022-04-11 Thread Albert Astals Cid
El dimecres, 6 d’abril de 2022, a les 13:28:50 (CEST), Harald Sitter va escriure: > https://invent.kde.org/frameworks/kcoreaddons/-/merge_requests/212 > > To get sandboxed apps to work with drag and drop we need to have drags > take a roundtrip through xdg-desktop-portal and unfortunately enough

Re: RFC: Erroring out if the platform you're building the Framework is not supported

2022-03-06 Thread Albert Astals Cid
El dimecres, 16 de febrer de 2022, a les 21:16:43 (CET), Christoph Cullmann (cullmann.io) va escriure: > On 2022-02-16 16:22, Allen Winter wrote: > > On Wednesday, February 16, 2022 9:42:18 AM EST Albert Astals Cid wrote: > >> Supported == listed in metainfo.yaml > >>

RFC: Erroring out if the platform you're building the Framework is not supported

2022-02-16 Thread Albert Astals Cid
Supported == listed in metainfo.yaml https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/245 What do you think? I know parsing yaml like that isn't great but it seems to work for something as simple as what I want there. I guess it's probably a bit annoying for places like

Re: Requiring ECM 5.85 makes apps stop compiling

2022-02-14 Thread Albert Astals Cid
El dilluns, 14 de febrer de 2022, a les 16:53:42 (CET), Christoph Cullmann (cullmann.io) va escriure: > On 2022-02-14 16:32, Albert Astals Cid wrote: > > It introduces code breaking defines, some of them even of questionable > > benefit for an application like QT_NO_KEYWORDS &

Requiring ECM 5.85 makes apps stop compiling

2022-02-14 Thread Albert Astals Cid
It introduces code breaking defines, some of them even of questionable benefit for an application like QT_NO_KEYWORDS I don't understand how such a breaking commit was accepted. Who is going to fix all the applications in KDE to build after that? Apps that I've tried and failed: * okular *

Re: KF 5.91: 24 modules with failing unit tests (Re: Please fix failing unit tests with Windows platform)

2022-02-06 Thread Albert Astals Cid
El diumenge, 6 de febrer de 2022, a les 10:40:22 (CET), Friedrich W. H. Kossebau va escriure: > Am Montag, 24. Januar 2022, 01:06:40 CET schrieb Friedrich W. H. Kossebau: > > Hi, > > > > since a long time there are lots of failing unit tests across multiple > > repositories. Could the Windows

Re: Please fix failing unit tests with Windows platform

2022-01-23 Thread Albert Astals Cid
El dilluns, 24 de gener de 2022, a les 1:06:40 (CET), Friedrich W. H. Kossebau va escriure: > Hi, > > since a long time there are lots of failing unit tests across multiple > repositories. Could the Windows platform maintainers/stakeholders please look > soonish into either fixing those tests

Re: Gitlab CI: failed unit tests vs. currently passing CI

2022-01-23 Thread Albert Astals Cid
El diumenge, 23 de gener de 2022, a les 1:59:01 (CET), Ben Cooksley va escriure: > On Sun, Jan 23, 2022 at 12:29 PM Albert Astals Cid wrote: > > > El diumenge, 23 de gener de 2022, a les 0:09:23 (CET), Ben Cooksley va > > escriure: > > > On Sun, Jan 23, 2022 at

Re: Gitlab CI: failed unit tests vs. currently passing CI

2022-01-22 Thread Albert Astals Cid
El diumenge, 23 de gener de 2022, a les 0:09:23 (CET), Ben Cooksley va escriure: > On Sun, Jan 23, 2022 at 11:29 AM Albert Astals Cid wrote: > > > El dissabte, 22 de gener de 2022, a les 6:11:29 (CET), Ben Cooksley va > > escriure: > > > EXCLUDE_DEPRECATED_BEFORE_AND_

Re: Gitlab CI: failed unit tests vs. currently passing CI

2022-01-22 Thread Albert Astals Cid
El diumenge, 23 de gener de 2022, a les 0:09:23 (CET), Ben Cooksley va escriure: > On Sun, Jan 23, 2022 at 11:29 AM Albert Astals Cid wrote: > > > El dissabte, 22 de gener de 2022, a les 6:11:29 (CET), Ben Cooksley va > > escriure: > > > EXCLUDE_DEPRECATED_BEFORE_AND_

Re: Gitlab CI: failed unit tests vs. currently passing CI

2022-01-22 Thread Albert Astals Cid
El dissabte, 22 de gener de 2022, a les 6:11:29 (CET), Ben Cooksley va escriure: > EXCLUDE_DEPRECATED_BEFORE_AND_ATOn Sat, Jan 22, 2022 at 1:31 PM Friedrich > W. H. Kossebau wrote: > > > Hi, > > > > seems that Gitlab CI is currently configured to show the green "Success" > > checkmark for

Re: Announcing General Availability of Gitlab CI for Linux, FreeBSD and Android

2021-11-28 Thread Albert Astals Cid
El dissabte, 27 de novembre de 2021, a les 19:30:08 (CET), Ben Cooksley va escriure: > Hi all, > > As mentioned in the subject, i'm happy to announce the general availability > of native Gitlab CI for all KDE projects for Linux, FreeBSD and Android. > > For those who would like to get their

Re: Fwd: KDE CI: Administration » Dependency Build Applications kf5-qt5 FreeBSDQt5.15 - Build # 127 - Still Failing!

2021-11-18 Thread Albert Astals Cid
El dijous, 18 de novembre de 2021, a les 18:37:37 (CET), Volker Krause va escriure: > I looked into this and it seems the problem had already been addressed prior > to your email, so all I ended up doing is pressing the rebuild button. > > > The change starting this was

What is our plan for Qt6 and QXmlPatterns?

2021-10-27 Thread Albert Astals Cid
QXmlPatterns has been deprecated for a long time and the current plan is that there will no Qt6 release of it. We use it in quite some places https://lxr.kde.org/search?%21v=kf5-qt5&_filestring=CMakeLists.txt&_string=XmlPatterns For those that don't want to click the link artikulate

Re: KF6 meeting notes 2021-10-26

2021-10-26 Thread Albert Astals Cid
El dimarts, 26 d’octubre de 2021, a les 18:05:42 (CEST), Volker Krause va escriure: > !! Meeting will move to 17:00 CET next week (due to DST change in continental > Europe) > > Threaded KIO workers: > * David F is removing the POP3 kioslave to enable that This is not what kmail/akonadi use to

Re: KDE CI: Plasma » plasma-framework » kf5-qt5 FreeBSDQt5.15 - Build # 644 - Still Failing!

2021-10-18 Thread Albert Astals Cid
El dilluns, 18 d’octubre de 2021, a les 13:59:24 (CEST), Vlad Zahorodnii va escriure: > On 10/18/21 14:25, Aleix Pol wrote: > > Does anyone know why we are having this problem all of a sudden? I > > cannot reproduce on my system. > > Plasma Workspace is failing the same: > >

Re: Problem with frameworks 5.86.0 and Konqueror

2021-09-19 Thread Albert Astals Cid
El diumenge, 19 de setembre de 2021, a les 21:24:59 (CEST), Stefano Crocco va escriure: > On domenica 19 settembre 2021 13:16:28 CEST Stefano Crocco wrote: > > On domenica 19 settembre 2021 12:42:22 CEST David Faure wrote: > > > On dimanche 19 septembre 2021 10:22:38 CEST Stefano Crocco wrote: >

bluez-qt: GATT Client functionality patch waiting for review

2021-08-10 Thread Albert Astals Cid
Can someone please review https://invent.kde.org/frameworks/bluez-qt/-/merge_requests/13 ? Seems like a nice bunch of functionality that would make sense to support. Cheers, Albert

Re: KDE CI SignTool Error: No certificates were found that met all the given criteria.

2021-07-15 Thread Albert Astals Cid
Why is this sent to kde-frameworks-devel? Cheers, Albert El dijous, 15 de juliol de 2021, a les 13:12:12 (CEST), Ralf Habacker va escriure: > Hi > > building kmymoney releases on KDE CI are currently broken by an > installation issue >

Re: KF5 modules development branches now build in C++17 mode (but keep public headers compatible)

2021-06-20 Thread Albert Astals Cid
El diumenge, 20 de juny de 2021, a les 12:16:33 (CEST), Friedrich W. H. Kossebau va escriure: > Hi, > > small heads-up for everyone: as of yesterday, KDEFrameworksCompilerSettings > from current ECM development branch now sets > set(CMAKE_CXX_STANDARD 17) >

Re: Problem with ksycoca not being regenerated under flatpak

2021-06-20 Thread Albert Astals Cid
El diumenge, 13 de desembre de 2020, a les 22:15:26 (CEST), Albert Astals Cid va escriure: > El dissabte, 12 de desembre de 2020, a les 22:59:58 CET, David Faure va > escriure: > > Time flies, sorry for the delay. > > > > On samedi 12 septembre 2020 19:44:45 CET

Re: KF6 meeting notes 2021-06-12

2021-06-15 Thread Albert Astals Cid
El dimarts, 15 de juny de 2021, a les 18:17:27 (CEST), Volker Krause va escriure: > On Dienstag, 15. Juni 2021 12:45:21 CEST Luigi Toscano wrote: > > David Faure ha scritto: > > > On dimanche 13 juin 2021 20:32:42 CEST Luigi Toscano wrote: > > >> -> we need need input about dfaure presence and

Re: Including instead of , does it upset POSIX?

2021-04-14 Thread Albert Astals Cid
El dimecres, 14 d’abril de 2021, a les 23:28:36 (CEST), Ahmad Samir va escriure: > On 14/04/2021 22:20, Albert Astals Cid wrote: > > El dimecres, 14 d’abril de 2021, a les 15:13:09 (CEST), Ahmad Samir va > > escriure: > >> Hello :) > >> > >> A week or

Re: Including instead of , does it upset POSIX?

2021-04-14 Thread Albert Astals Cid
El dimecres, 14 d’abril de 2021, a les 15:13:09 (CEST), Ahmad Samir va escriure: > Hello :) > > A week or so ago I created an MR to include instead of in > KIO[1]. > > From /usr/include/c++/10/cerrno: > /** @file cerrno > * This is a Standard C++ Library file. You should @c \#include

Should syntax-higlighting get 5.79.1 released with the control flow color fix?

2021-02-15 Thread Albert Astals Cid
Hi all, Should we do a new release of syntax-highlighting with 341b6e8c64d1fa8df16fe9c65e185cea3c6a7901 ? 5.79.0 missed it by minutes and given 7a2260a9933cd9838e7dc8ae30c3def2173ba166 was not in any release either, i think it'd make sense to get 5.79.1 out so we don't get complains that we

Re: Need xcb/xkb help for severe kglobalaccel_x11 issue

2021-01-30 Thread Albert Astals Cid
El diumenge, 31 de gener de 2021, a les 0:53:17 CET, David Faure va escriure: > On dimanche 31 janvier 2021 00:39:38 CET Albert Astals Cid wrote: > > El dissabte, 30 de gener de 2021, a les 18:32:32 CET, David Faure va > escriure: > > > For years, I've noticed that when r

Re: Need xcb/xkb help for severe kglobalaccel_x11 issue

2021-01-30 Thread Albert Astals Cid
El dissabte, 30 de gener de 2021, a les 18:32:32 CET, David Faure va escriure: > For years, I've noticed that when resuming a laptop from sleep, kglobalaccel > and X11 > use 100% CPU for a few minutes, making everything crawl for a while. Does this happen on a short sleep too or needs a long

Re: github pull requests are piling up

2020-12-29 Thread Albert Astals Cid
El dijous, 24 de desembre de 2020, a les 11:02:16 CET, Albert Astals Cid va escriure: > We're at 52 at this point > > https://github.com/pulls?q=is%3Aopen+is%3Apr+user%3AKDE > > Sadly my bot broke and fixing it is not possible for me in the time i can > dedicate to it (it's w

github pull requests are piling up

2020-12-24 Thread Albert Astals Cid
We're at 52 at this point https://github.com/pulls?q=is%3Aopen+is%3Apr+user%3AKDE Sadly my bot broke and fixing it is not possible for me in the time i can dedicate to it (it's written in go which I'm not very proficient at and it seems that there have been github and google appengine API

Re: KDE review for KWeatherCore

2020-12-21 Thread Albert Astals Cid
El dilluns, 21 de desembre de 2020, a les 7:16:09 CET, hanyoung va escriure: > KWeatherCore: https://invent.kde.org/libraries/kweathercore is a library for > querying weather forecast data. > During the development of KWeather, we found the need to have a weather > library. > KWeatherCore is the

Re: T13975: Move hanyoung/libkweather to frameworks/kweathercore

2020-12-20 Thread Albert Astals Cid
Where has this been discussed? This is a 1 month old library with no external review whatsoever, I don't see how it can be ready to be part of KDE Frameworks. Cheers, Albert El diumenge, 20 de desembre de 2020, a les 11:48:30 CET, Han Young va escriure: > hanyoung created this task. >

Re: RFC: Switching to min Qt version 5.14 for KF on December 14th

2020-12-18 Thread Albert Astals Cid
El divendres, 18 de desembre de 2020, a les 18:51:32 CET, Albert Astals Cid va escriure: > El divendres, 18 de desembre de 2020, a les 6:44:41 CET, Friedrich W. H. > Kossebau va escriure: > > Am Donnerstag, 17. Dezember 2020, 21:06:23 CET schrieb David Faure: > > > In gener

Re: RFC: Switching to min Qt version 5.14 for KF on December 14th

2020-12-18 Thread Albert Astals Cid
El divendres, 18 de desembre de 2020, a les 6:44:41 CET, Friedrich W. H. Kossebau va escriure: > Am Donnerstag, 17. Dezember 2020, 21:06:23 CET schrieb David Faure: > > In general I might have asked for a more conservative approach; but > > currently anything we do to help with preparing the Qt 6

Re: RFC: Switching to min Qt version 5.14 for KF on December 14th

2020-12-17 Thread Albert Astals Cid
El dijous, 17 de desembre de 2020, a les 21:16:57 CET, Ahmad Samir va escriure: > On 17/12/2020 22:06, David Faure wrote: > [...] > > > > Right. That's a reason to fix something indeed, but there are still two ways > > to fix that, if it was the only reason : either raise min req to Qt 5.14, or >

Re: KACL from KIO isn't really POSIX-compliant

2020-12-16 Thread Albert Astals Cid
El dimecres, 2 de desembre de 2020, a les 10:36:30 CET, Gleb Popov va escriure: > Hello everyone. > > I tried compiling kio/src/core/kacl.cpp on FreeBSD, which does support > POSIX ACLs, and failed. This is because KACL's code uses non-standard > Linux-specific acl_* functions. I tried

Re: Problem with ksycoca not being regenerated under flatpak

2020-12-13 Thread Albert Astals Cid
El dissabte, 12 de desembre de 2020, a les 22:59:58 CET, David Faure va escriure: > Time flies, sorry for the delay. > > On samedi 12 septembre 2020 19:44:45 CET Albert Astals Cid wrote: > > flatpak mounts all files as if created on January 1st 1970. > > Isn't that a bug i

Re: RFC: Switching to min Qt version 5.14 for KF on December 14th

2020-12-06 Thread Albert Astals Cid
El diumenge, 6 de desembre de 2020, a les 14:20:47 CET, Friedrich W. H. Kossebau va escriure: > Hi, > > you might have seen I asked* whether anyone knows a real world requirement to > stick with Qt 5.13 as new current minimum required Qt version for current KF > releases. So far no-one had to

Re: PSA: Frameworks depends on Qt 5.13 now

2020-11-26 Thread Albert Astals Cid
El divendres, 27 de novembre de 2020, a les 0:21:04 CET, Nicolas Fella va escriure: > Hi, > > per our Qt dependency policy [0] Frameworks depends on Qt 5.13 6 months > after the release of Qt 5.15, which is now. > > Have fun with the new stuff. And i think i broke all the CI updating the

Re: KCGroups in KDEreview

2020-11-20 Thread Albert Astals Cid
El divendres, 20 de novembre de 2020, a les 14:55:16 CET, Henri Chain va escriure: > Hello everyone, > > KCgroups has been moved to KDEReview ! > What is that, you ask ? It's a library that wraps the systemd dbus API to > expose a higher-level concept of desktop application and allow control of

Re: RSIBreak / KIdleTime on Wayland

2020-11-15 Thread Albert Astals Cid
El dissabte, 14 de novembre de 2020, a les 12:46:41 CET, Dominik Waurenschk va escriure: > Hi, I just came across the issue that RSIBreak is unable to count down in > wayland, after 1 second it always resets its timer. > > I investigated the code and found that it calls KIdleTime, which in turn

Re: Help using KArchive with GZIP files

2020-11-02 Thread Albert Astals Cid
El dilluns, 2 de novembre de 2020, a les 22:23:44 CET, Gabriel Domínguez Camarero va escriure: > Hello I am gabridc, Hello Gabriel, this KDE Frameworks devel is for discussion around development *of* KDE Frameworks not *with* KDE Frameworks, your question belongs to kde-de...@kde.org > > >

Problem with ksycoca not being regenerated under flatpak

2020-09-12 Thread Albert Astals Cid
flatpak mounts all files as if created on January 1st 1970. This has the unfortunate effect that when we add new plugins to a flatpak (i.e. we just added markdown preview support in kate), they are not seen because ksycoca doesn't feel the need to regenerate itself (the sycoca file for flatpak

Re: General information for KDE Frameworks developers

2020-09-09 Thread Albert Astals Cid
El dimecres, 9 de setembre de 2020, a les 15:31:27 CEST, David Faure va escriure: > Here are some notes from the KF6 BoF at Akademy, as well as general > information that I realized might not be known to all the relevant developers. > > * There's a nice board with many tasks related to

Re: Dropping the moderation by default flag

2020-08-10 Thread Albert Astals Cid
El dimecres, 22 de juliol de 2020, a les 17:47:26 CEST, Volker Krause va escriure: > On Tuesday, 21 July 2020 21:16:00 CEST Albert Astals Cid wrote: > > Hi, this list has an unusual setting [for kde mailing lists] inherited from > > kde-core-devel that is that even subscribed peopl

Dropping the moderation by default flag

2020-07-21 Thread Albert Astals Cid
Hi, this list has an unusual setting [for kde mailing lists] inherited from kde-core-devel that is that even subscribed people get moderated, and then the list moderator can decide to clear the moderate flag for each person one by one. I'm proposing to change that because: * it's non

Re: xml_mimetypes5 and kcoreaddons

2020-07-19 Thread Albert Astals Cid
El diumenge, 19 de juliol de 2020, a les 13:56:14 CEST, David Faure va escriure: > On mercredi 15 juillet 2020 12:24:34 CEST Harald Sitter wrote: > > On Wed, Jul 15, 2020 at 12:39 AM David Faure wrote: > > > On mardi 14 juillet 2020 19:35:41 CEST Albert Astals Cid wrote: > &g

Re: xml_mimetypes5 and kcoreaddons

2020-07-15 Thread Albert Astals Cid
El dimecres, 15 de juliol de 2020, a les 12:24:34 CEST, Harald Sitter va escriure: > On Wed, Jul 15, 2020 at 12:39 AM David Faure wrote: > > > > On mardi 14 juillet 2020 19:35:41 CEST Albert Astals Cid wrote: > > > El dimarts, 14 de juliol de 2020, a les 15:14:38 C

Re: xml_mimetypes5 and kcoreaddons

2020-07-14 Thread Albert Astals Cid
El dimarts, 14 de juliol de 2020, a les 15:14:38 CEST, Jonathan Riddell va escriure: > We're playing with translations in neon packages and looking at kcoreaddons > the tars have > xml_mimetypes5 > But we can't see anything in the code which uses this. Do these > translations get used? Yes, the

Re: Deprecate KRandomSequence ?

2020-07-04 Thread Albert Astals Cid
El dilluns, 29 de juny de 2020, a les 22:27:44 CEST, Albert Astals Cid va escriure: > QRandomGenerator is very similar in which you can give it a seed and get > randomness out of it. > > Things that QRandomGenerator doesn't have: > * getBool(); -> should be easy enough to

Re: Deprecate KRandomSequence ?

2020-06-30 Thread Albert Astals Cid
El dimarts, 30 de juny de 2020, a les 22:17:56 CEST, Johan Ouwerkerk va escriure: > On Tue, Jun 30, 2020 at 7:32 PM Albert Astals Cid wrote: > > > > > > > > If an application was relying on the random application sequence, it > > > probably has bigger prob

Re: Deprecate KRandomSequence ?

2020-06-30 Thread Albert Astals Cid
El dimarts, 30 de juny de 2020, a les 1:21:48 CEST, Aleix Pol va escriure: > On Mon, Jun 29, 2020 at 10:27 PM Albert Astals Cid wrote: > > > > QRandomGenerator is very similar in which you can give it a seed and get > > randomness out of it. > > > > Things t

Deprecate KRandomSequence ?

2020-06-29 Thread Albert Astals Cid
QRandomGenerator is very similar in which you can give it a seed and get randomness out of it. Things that QRandomGenerator doesn't have: * getBool(); -> should be easy enough to port to bounded(2) == 1 * randomize(QList) -> We could add namespace function in KRandom * modulate() -> Couldn't

Re: New Framework Review: KDAV

2020-06-14 Thread Albert Astals Cid
El diumenge, 14 de juny de 2020, a les 10:17:01 CEST, Ben Cooksley va escriure: > On Sun, Jun 14, 2020 at 8:03 PM Volker Krause wrote: > > > > With both 20.04.2 and 5.71.0 out I think it's now time to do this move. > > > > What extra steps do we need to take now that the framework/application > >

D26342: Allow overriding to disable auto language detection

2020-06-13 Thread Albert Astals Cid
aacid added a comment. In D26342#675164 , @sdepiets wrote: > In D26342#675142 , @dfaure wrote: > > > This actually breaks language auto-detection for me in the KMail composer. > > > > Testcase:

Re: Opening files by mimetype instead of by file extension

2020-06-10 Thread Albert Astals Cid
El dimecres, 10 de juny de 2020, a les 11:52:03 CEST, David Faure va escriure: > On mercredi 10 juin 2020 00:52:16 CEST Albert Astals Cid wrote: > > As far as I can see QFileDialog only supports listing by file extension. > > > > On the other hand it seems in GTK+ land you

Opening files by mimetype instead of by file extension

2020-06-09 Thread Albert Astals Cid
As far as I can see QFileDialog only supports listing by file extension. On the other hand it seems in GTK+ land you can get an open file dialog listing by mimetype, so I've got one bug about "you're worse than XXX because you can't do this" Is there something we could do at the KDE Frameworks

Re: KRunProxy

2020-06-06 Thread Albert Astals Cid
El dissabte, 6 de juny de 2020, a les 19:00:59 CEST, David Faure va escriure: > In order to switch kdeclarative to > -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054700 > we need to port KRunProxy away from KRun, or to deprecate KRunProxy. > > AFAICS it exposes an object named KRun to QML files, but

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

2020-06-04 Thread Albert Astals Cid
aacid added a comment. In D29826#674634 , @aacid wrote: > oh i think i'm too late :D Let's wait for the fix to actually land and then i'll propose that change REPOSITORY R263 KXmlGui REVISION DETAIL

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

2020-06-04 Thread Albert Astals Cid
aacid added a comment. oh i think i'm too late :D INLINE COMMENTS > kmainwindow.cpp:253 > +// TODO: remove this once we depend on Qt 5.15.1, where this is fixed > +#if QT_VERSION >= QT_VERSION_CHECK(5, 12, 0) > +if (QIcon::fallbackThemeName().isEmpty()) { should this be #if

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

2020-06-04 Thread Albert Astals Cid
aacid added a comment. It didn't really land on Qt 5.15 yet, so we may need to update the comment to say 5.15.1 or something https://codereview.qt-project.org/c/qt/qtbase/+/302581 But as said i think this is reasonable for now REPOSITORY R263 KXmlGui REVISION DETAIL

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

2020-05-24 Thread Albert Astals Cid
aacid added a comment. Personally I'm happy enough with this, i guess wait a few days and if noone disagrees, land it REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D29826 To: poboiko, aacid, mart, broulik Cc: mart, kde-frameworks-devel, LeGast00n, cblack,

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

2020-05-23 Thread Albert Astals Cid
aacid added a comment. Do you think we should mention something like // TODO Remove once we can depend on a Qt version that has https://codereview.qt-project.org/c/qt/qtbase/+/301588 Or maybe i'm being too optimistic in getting that landed ^_^  REPOSITORY R263 KXmlGui REVISION

D22488: invoke QIcon::setFallbackThemeName a bit later

2020-05-23 Thread Albert Astals Cid
aacid added a comment. In D22488#673575 , @poboiko wrote: > UPD: seems like it doesn't. I've added couple qDebug lines, to `QIcon::fromTheme()` method and near `QIcon::setFallbackThemeName()` with your patch, and then ran okular and dolphin.

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

2020-05-23 Thread Albert Astals Cid
aacid added a comment. In D29826#673572 , @poboiko wrote: > Thanks for looking into it! :) > > In D29826#673543 , @aacid wrote: > > > I don't think moving this code from KIconThemes to

D22488: invoke QIcon::setFallbackThemeName a bit later

2020-05-22 Thread Albert Astals Cid
aacid added a comment. Now i understand this is causing relatively several issues, sorry for dropping the ball, so we should probably fix for users before Qt 5.15.1 What about something like diff --git a/src/kicontheme.cpp b/src/kicontheme.cpp index 4f5d9d5..62fc9d7 100644

D22488: invoke QIcon::setFallbackThemeName a bit later

2020-05-22 Thread Albert Astals Cid
aacid added a comment. https://codereview.qt-project.org/c/qt/qtbase/+/301588 REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D22488 To: mart, #frameworks, #plasma Cc: aacid, mlaurent, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22488: invoke QIcon::setFallbackThemeName a bit later

2020-05-22 Thread Albert Astals Cid
aacid added a comment. Wouldn't it make more sense to fix in Qt? Something like diff --git a/src/gui/image/qicon.cpp b/src/gui/image/qicon.cpp index 41fe649fc5..f86ad3c760 100644 --- a/src/gui/image/qicon.cpp +++ b/src/gui/image/qicon.cpp @@ -1260,7 +1260,7 @@

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

2020-05-22 Thread Albert Astals Cid
aacid added a comment. Not sure if you're subscribed to https://phabricator.kde.org/D22488 see my last comment there i think it's the way to go REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D29826 To: poboiko, aacid, mart, broulik Cc: mart, kde-frameworks-devel,

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

2020-05-22 Thread Albert Astals Cid
aacid added a comment. I don't think moving this code from KIconThemes to kmainwindow makes sense, what about all the apps that use KIconThemes but no KMainWindow? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D29826 To: poboiko, aacid, mart, broulik Cc: mart,

D29577: Stop using deprecated methods

2020-05-09 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29577 To: aacid, dfaure Cc: kossebau, kde-frameworks-devel, kfm-devel, dfaure, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde,

D29577: Stop using deprecated methods

2020-05-09 Thread Albert Astals Cid
aacid added a subscriber: kossebau. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29577 To: aacid Cc: kossebau, kde-frameworks-devel, kfm-devel, dfaure, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde,

D29577: Stop using deprecated methods

2020-05-09 Thread Albert Astals Cid
aacid created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY They are no-ops REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL

D29390: Respect QIcon::fallbackSearchpaths()

2020-05-03 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > aacid wrote in kiconloader.cpp:1142 > Would it make sense trying to use QIconLoader::lookupFallbackIcon ? This way > we "upstream" Qt behaviour? For example you're supporting svgz while Qt > doesn't. Which would mean different

D29390: Respect QIcon::fallbackSearchpaths()

2020-05-03 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > kiconloader.cpp:1142 > +for (const QString : fallbackPaths) { > +const QStringList extensions = QStringList() << > QStringLiteral(".png") << QStringLiteral(".svg") << QStringLiteral(".svgz") > << QStringLiteral(".xpm"); > +

D26342: Allow overriding to disable auto language detection

2020-05-03 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R246:422fac8a6f92: Allow overriding to disable auto language detection (authored by sdepiets, committed by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26342?vs=81177=81805#toc

D26342: Allow overriding to disable auto language detection

2020-05-03 Thread Albert Astals Cid
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Noone seems to really disagree. Let's merge it. @sdepiets I hope this doesn't break everything ;) REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL

D29369: Use UI marker context in more tr() calls

2020-05-03 Thread Albert Astals Cid
aacid added a comment. +0.5 REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D29369 To: kossebau, #frameworks, #localization Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29370: Use UI marker context in more tr() calls

2020-05-03 Thread Albert Astals Cid
aacid added a comment. +0.5 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29370 To: kossebau, #frameworks, #localization, broulik Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29369: Use UI marker context in more tr() calls

2020-05-03 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > kbookmarkmenu.cpp:288 > > -QString title = tr("Open Folder in Tabs"); > +const QString title = tr("Open Folder in Tabs", "@action:inmenu"); > @title:inmenu? REPOSITORY R294 KBookmarks REVISION DETAIL

D29368: Use UI marker context in more tr() calls

2020-05-03 Thread Albert Astals Cid
aacid added a comment. +0.5 REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D29368 To: kossebau, #frameworks, #localization Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29367: Use UI marker context in more tr() calls

2020-05-03 Thread Albert Astals Cid
aacid added a comment. +0.5 REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D29367 To: kossebau, #frameworks, #localization, davidedmundson Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29347: KAuthorized: export method to reload restrictions

2020-05-03 Thread Albert Astals Cid
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. a, for using in a different repo, ok. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D29347 To: dfaure, aacid, apol, mdawson Cc:

D29363: Use UI marker context in more tr() calls

2020-05-02 Thread Albert Astals Cid
aacid added a comment. The descriptions seem reasonable. The problem with this is that it makes all strings untranslated and i'm not sure it's worth the effort. My hope is that at this point anything that was actually ambiguous would have been reported by the translators and fixed.

D29347: KAuthorized: export method to reload restrictions

2020-05-02 Thread Albert Astals Cid
aacid added a comment. So how you're going to use it from unittests? declaring the function there? maybe better to declare it to some of the _p.h headers ? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D29347 To: dfaure, aacid, apol, mdawson Cc:

Re: Information regarding upcoming Gitlab Migration: clarifications

2020-04-30 Thread Albert Astals Cid
El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va escriure: > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić wrote: > > > > > We have made a big fuss in the past about having different projects > > > that do the same thing and now we'll have that but also we'll have > > > several

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Albert Astals Cid
El dilluns, 27 d’abril de 2020, a les 3:40:01 CEST, Bhushan Shah va escriure: > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > replies] > > Hello Community members, > > In view of upcoming Gitlab migration, we sysadmin team wants to share > the recommended structuring for

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Albert Astals Cid
El dilluns, 27 d’abril de 2020, a les 13:19:07 CEST, Ben Cooksley va escriure: > On Mon, Apr 27, 2020 at 11:12 PM Olivier Churlaud > wrote: > > > > Hi, > > > > Le lundi 27 avril 2020, 12:38:42 CEST Aleix Pol a écrit : > > > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > > > > >

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Albert Astals Cid
El dilluns, 27 d’abril de 2020, a les 13:58:02 CEST, Bhushan Shah va escriure: > In part I am mostly re-iterating what Ben already mentioned in different > messages. > > On Mon, Apr 27, 2020 at 12:38:42PM +0200, Aleix Pol wrote: > > Does this mean that to clone it we'll have to go "git clone > >

D24367: Some sanity verification

2020-04-26 Thread Albert Astals Cid
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Looks good to me :) REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D24367 To: sandsmark, aacid, cfeck Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

D26342: Allow overriding to disable auto language detection

2020-04-25 Thread Albert Astals Cid
aacid added a comment. You need to update the \since markers? After that i guess you can commit unless anyone really disagrees? @mludwig @cullmann ? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D26342 To: sdepiets, #frameworks, cullmann, mlaurent, mludwig

D25267: Improve XCF support

2020-04-14 Thread Albert Astals Cid
aacid added a comment. In D25267#647547 , @sandsmark wrote: > In D25267#647148 , @aacid wrote: > > > Seems like the windows build is broken :/ > > > >

D25267: Improve XCF support

2020-04-13 Thread Albert Astals Cid
aacid added a comment. In D25267#647129 , @sandsmark wrote: > I messed up and it got linked to the wrong phabricator review... Here it is anyways: > >

D25267: Improve XCF support

2020-04-12 Thread Albert Astals Cid
aacid added a comment. the files are not uploaded correctly to phabricator so i can't check they work. Given we just released KF 5.69 *yesterday* i'm going to go crazy and say commit this and we have a "whole month" to fix regressions if it has any... REPOSITORY R287 KImageFormats

D27632: Implement UString operator= to make gcc happy

2020-04-12 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R314:e637e721e40e: Implement UString operator= to make gcc happy (authored by aacid). REPOSITORY R314 KJs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27632?vs=76323=79911 REVISION DETAIL

D26342: Allow overriding to disable auto language detection

2020-03-23 Thread Albert Astals Cid
aacid added a comment. In D26342#632842 , @sdepiets wrote: > In D26342#623729 , @aacid wrote: > > > Would it make sense to enshrine this behaviour with an autotest? > > > Sorry what do you mean

D28151: Autotest file showing wrong File path

2020-03-19 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28151 To: usta, meven, aacid Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

2020-03-12 Thread Albert Astals Cid
aacid added a comment. Looks reasonable to me, but i'm not a huge expert here either, i guess you can commit given you are the expert. Or maybe wait a few days in case someone else has commits? REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D27966 To: dfaure,

D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

2020-03-11 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > dfaure wrote in partloader.h:59 > This is an excellent point, thanks for this feedback. > > Loading a part from a given KPluginMetadata is extremely simple, though: > > KPluginLoader loader(md.fileName()); > m_part =

D27997: Fix cmake warning

2020-03-11 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH warning REVISION DETAIL https://phabricator.kde.org/D27997 To: apol, #frameworks, aacid Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

2020-03-10 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > partloader.h:59 > + */ > +KPARTS_EXPORT QVector partsForMimeType(const QString > ); > + What's the use for this? The function below doesn't let me chose which one i want (i guess it always uses the one with the most preference?), so why

  1   2   3   4   5   6   7   8   9   10   >