Problem with ksycoca not being regenerated under flatpak

2020-09-12 Thread Albert Astals Cid
flatpak mounts all files as if created on January 1st 1970. This has the unfortunate effect that when we add new plugins to a flatpak (i.e. we just added markdown preview support in kate), they are not seen because ksycoca doesn't feel the need to regenerate itself (the sycoca file for flatpak

Re: General information for KDE Frameworks developers

2020-09-09 Thread Albert Astals Cid
El dimecres, 9 de setembre de 2020, a les 15:31:27 CEST, David Faure va escriure: > Here are some notes from the KF6 BoF at Akademy, as well as general > information that I realized might not be known to all the relevant developers. > > * There's a nice board with many tasks related to

Re: Dropping the moderation by default flag

2020-08-10 Thread Albert Astals Cid
El dimecres, 22 de juliol de 2020, a les 17:47:26 CEST, Volker Krause va escriure: > On Tuesday, 21 July 2020 21:16:00 CEST Albert Astals Cid wrote: > > Hi, this list has an unusual setting [for kde mailing lists] inherited from > > kde-core-devel that is that even subscribed peopl

Dropping the moderation by default flag

2020-07-21 Thread Albert Astals Cid
Hi, this list has an unusual setting [for kde mailing lists] inherited from kde-core-devel that is that even subscribed people get moderated, and then the list moderator can decide to clear the moderate flag for each person one by one. I'm proposing to change that because: * it's non

Re: xml_mimetypes5 and kcoreaddons

2020-07-19 Thread Albert Astals Cid
El diumenge, 19 de juliol de 2020, a les 13:56:14 CEST, David Faure va escriure: > On mercredi 15 juillet 2020 12:24:34 CEST Harald Sitter wrote: > > On Wed, Jul 15, 2020 at 12:39 AM David Faure wrote: > > > On mardi 14 juillet 2020 19:35:41 CEST Albert Astals Cid wrote: > &g

Re: xml_mimetypes5 and kcoreaddons

2020-07-15 Thread Albert Astals Cid
El dimecres, 15 de juliol de 2020, a les 12:24:34 CEST, Harald Sitter va escriure: > On Wed, Jul 15, 2020 at 12:39 AM David Faure wrote: > > > > On mardi 14 juillet 2020 19:35:41 CEST Albert Astals Cid wrote: > > > El dimarts, 14 de juliol de 2020, a les 15:14:38 C

Re: xml_mimetypes5 and kcoreaddons

2020-07-14 Thread Albert Astals Cid
El dimarts, 14 de juliol de 2020, a les 15:14:38 CEST, Jonathan Riddell va escriure: > We're playing with translations in neon packages and looking at kcoreaddons > the tars have > xml_mimetypes5 > But we can't see anything in the code which uses this. Do these > translations get used? Yes, the

Re: Deprecate KRandomSequence ?

2020-07-04 Thread Albert Astals Cid
El dilluns, 29 de juny de 2020, a les 22:27:44 CEST, Albert Astals Cid va escriure: > QRandomGenerator is very similar in which you can give it a seed and get > randomness out of it. > > Things that QRandomGenerator doesn't have: > * getBool(); -> should be easy enough to

Re: Deprecate KRandomSequence ?

2020-06-30 Thread Albert Astals Cid
El dimarts, 30 de juny de 2020, a les 22:17:56 CEST, Johan Ouwerkerk va escriure: > On Tue, Jun 30, 2020 at 7:32 PM Albert Astals Cid wrote: > > > > > > > > If an application was relying on the random application sequence, it > > > probably has bigger prob

Re: Deprecate KRandomSequence ?

2020-06-30 Thread Albert Astals Cid
El dimarts, 30 de juny de 2020, a les 1:21:48 CEST, Aleix Pol va escriure: > On Mon, Jun 29, 2020 at 10:27 PM Albert Astals Cid wrote: > > > > QRandomGenerator is very similar in which you can give it a seed and get > > randomness out of it. > > > > Things t

Deprecate KRandomSequence ?

2020-06-29 Thread Albert Astals Cid
QRandomGenerator is very similar in which you can give it a seed and get randomness out of it. Things that QRandomGenerator doesn't have: * getBool(); -> should be easy enough to port to bounded(2) == 1 * randomize(QList) -> We could add namespace function in KRandom * modulate() -> Couldn't

Re: New Framework Review: KDAV

2020-06-14 Thread Albert Astals Cid
El diumenge, 14 de juny de 2020, a les 10:17:01 CEST, Ben Cooksley va escriure: > On Sun, Jun 14, 2020 at 8:03 PM Volker Krause wrote: > > > > With both 20.04.2 and 5.71.0 out I think it's now time to do this move. > > > > What extra steps do we need to take now that the framework/application > >

D26342: Allow overriding to disable auto language detection

2020-06-13 Thread Albert Astals Cid
aacid added a comment. In D26342#675164 , @sdepiets wrote: > In D26342#675142 , @dfaure wrote: > > > This actually breaks language auto-detection for me in the KMail composer. > > > > Testcase:

Re: Opening files by mimetype instead of by file extension

2020-06-10 Thread Albert Astals Cid
El dimecres, 10 de juny de 2020, a les 11:52:03 CEST, David Faure va escriure: > On mercredi 10 juin 2020 00:52:16 CEST Albert Astals Cid wrote: > > As far as I can see QFileDialog only supports listing by file extension. > > > > On the other hand it seems in GTK+ land you

Opening files by mimetype instead of by file extension

2020-06-09 Thread Albert Astals Cid
As far as I can see QFileDialog only supports listing by file extension. On the other hand it seems in GTK+ land you can get an open file dialog listing by mimetype, so I've got one bug about "you're worse than XXX because you can't do this" Is there something we could do at the KDE Frameworks

Re: KRunProxy

2020-06-06 Thread Albert Astals Cid
El dissabte, 6 de juny de 2020, a les 19:00:59 CEST, David Faure va escriure: > In order to switch kdeclarative to > -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054700 > we need to port KRunProxy away from KRun, or to deprecate KRunProxy. > > AFAICS it exposes an object named KRun to QML files, but

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

2020-06-04 Thread Albert Astals Cid
aacid added a comment. In D29826#674634 , @aacid wrote: > oh i think i'm too late :D Let's wait for the fix to actually land and then i'll propose that change REPOSITORY R263 KXmlGui REVISION DETAIL

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

2020-06-04 Thread Albert Astals Cid
aacid added a comment. oh i think i'm too late :D INLINE COMMENTS > kmainwindow.cpp:253 > +// TODO: remove this once we depend on Qt 5.15.1, where this is fixed > +#if QT_VERSION >= QT_VERSION_CHECK(5, 12, 0) > +if (QIcon::fallbackThemeName().isEmpty()) { should this be #if

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

2020-06-04 Thread Albert Astals Cid
aacid added a comment. It didn't really land on Qt 5.15 yet, so we may need to update the comment to say 5.15.1 or something https://codereview.qt-project.org/c/qt/qtbase/+/302581 But as said i think this is reasonable for now REPOSITORY R263 KXmlGui REVISION DETAIL

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

2020-05-24 Thread Albert Astals Cid
aacid added a comment. Personally I'm happy enough with this, i guess wait a few days and if noone disagrees, land it REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D29826 To: poboiko, aacid, mart, broulik Cc: mart, kde-frameworks-devel, LeGast00n, cblack,

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

2020-05-23 Thread Albert Astals Cid
aacid added a comment. Do you think we should mention something like // TODO Remove once we can depend on a Qt version that has https://codereview.qt-project.org/c/qt/qtbase/+/301588 Or maybe i'm being too optimistic in getting that landed ^_^  REPOSITORY R263 KXmlGui REVISION

D22488: invoke QIcon::setFallbackThemeName a bit later

2020-05-23 Thread Albert Astals Cid
aacid added a comment. In D22488#673575 , @poboiko wrote: > UPD: seems like it doesn't. I've added couple qDebug lines, to `QIcon::fromTheme()` method and near `QIcon::setFallbackThemeName()` with your patch, and then ran okular and dolphin.

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

2020-05-23 Thread Albert Astals Cid
aacid added a comment. In D29826#673572 , @poboiko wrote: > Thanks for looking into it! :) > > In D29826#673543 , @aacid wrote: > > > I don't think moving this code from KIconThemes to

D22488: invoke QIcon::setFallbackThemeName a bit later

2020-05-22 Thread Albert Astals Cid
aacid added a comment. Now i understand this is causing relatively several issues, sorry for dropping the ball, so we should probably fix for users before Qt 5.15.1 What about something like diff --git a/src/kicontheme.cpp b/src/kicontheme.cpp index 4f5d9d5..62fc9d7 100644

D22488: invoke QIcon::setFallbackThemeName a bit later

2020-05-22 Thread Albert Astals Cid
aacid added a comment. https://codereview.qt-project.org/c/qt/qtbase/+/301588 REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D22488 To: mart, #frameworks, #plasma Cc: aacid, mlaurent, broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22488: invoke QIcon::setFallbackThemeName a bit later

2020-05-22 Thread Albert Astals Cid
aacid added a comment. Wouldn't it make more sense to fix in Qt? Something like diff --git a/src/gui/image/qicon.cpp b/src/gui/image/qicon.cpp index 41fe649fc5..f86ad3c760 100644 --- a/src/gui/image/qicon.cpp +++ b/src/gui/image/qicon.cpp @@ -1260,7 +1260,7 @@

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

2020-05-22 Thread Albert Astals Cid
aacid added a comment. Not sure if you're subscribed to https://phabricator.kde.org/D22488 see my last comment there i think it's the way to go REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D29826 To: poboiko, aacid, mart, broulik Cc: mart, kde-frameworks-devel,

D29826: [KMainWindow] Invoke QIcon::setFallbackThemeName (later)

2020-05-22 Thread Albert Astals Cid
aacid added a comment. I don't think moving this code from KIconThemes to kmainwindow makes sense, what about all the apps that use KIconThemes but no KMainWindow? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D29826 To: poboiko, aacid, mart, broulik Cc: mart,

D29577: Stop using deprecated methods

2020-05-09 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29577 To: aacid, dfaure Cc: kossebau, kde-frameworks-devel, kfm-devel, dfaure, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde,

D29577: Stop using deprecated methods

2020-05-09 Thread Albert Astals Cid
aacid added a subscriber: kossebau. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29577 To: aacid Cc: kossebau, kde-frameworks-devel, kfm-devel, dfaure, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack, fbampaloukas, alexde,

D29577: Stop using deprecated methods

2020-05-09 Thread Albert Astals Cid
aacid created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY They are no-ops REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL

D29390: Respect QIcon::fallbackSearchpaths()

2020-05-03 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > aacid wrote in kiconloader.cpp:1142 > Would it make sense trying to use QIconLoader::lookupFallbackIcon ? This way > we "upstream" Qt behaviour? For example you're supporting svgz while Qt > doesn't. Which would mean different

D29390: Respect QIcon::fallbackSearchpaths()

2020-05-03 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > kiconloader.cpp:1142 > +for (const QString : fallbackPaths) { > +const QStringList extensions = QStringList() << > QStringLiteral(".png") << QStringLiteral(".svg") << QStringLiteral(".svgz") > << QStringLiteral(".xpm"); > +

D26342: Allow overriding to disable auto language detection

2020-05-03 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R246:422fac8a6f92: Allow overriding to disable auto language detection (authored by sdepiets, committed by aacid). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D26342?vs=81177=81805#toc

D26342: Allow overriding to disable auto language detection

2020-05-03 Thread Albert Astals Cid
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Noone seems to really disagree. Let's merge it. @sdepiets I hope this doesn't break everything ;) REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL

D29369: Use UI marker context in more tr() calls

2020-05-03 Thread Albert Astals Cid
aacid added a comment. +0.5 REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D29369 To: kossebau, #frameworks, #localization Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29370: Use UI marker context in more tr() calls

2020-05-03 Thread Albert Astals Cid
aacid added a comment. +0.5 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29370 To: kossebau, #frameworks, #localization, broulik Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29369: Use UI marker context in more tr() calls

2020-05-03 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > kbookmarkmenu.cpp:288 > > -QString title = tr("Open Folder in Tabs"); > +const QString title = tr("Open Folder in Tabs", "@action:inmenu"); > @title:inmenu? REPOSITORY R294 KBookmarks REVISION DETAIL

D29368: Use UI marker context in more tr() calls

2020-05-03 Thread Albert Astals Cid
aacid added a comment. +0.5 REPOSITORY R284 KCompletion REVISION DETAIL https://phabricator.kde.org/D29368 To: kossebau, #frameworks, #localization Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29367: Use UI marker context in more tr() calls

2020-05-03 Thread Albert Astals Cid
aacid added a comment. +0.5 REPOSITORY R276 KItemViews REVISION DETAIL https://phabricator.kde.org/D29367 To: kossebau, #frameworks, #localization, davidedmundson Cc: aacid, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29347: KAuthorized: export method to reload restrictions

2020-05-03 Thread Albert Astals Cid
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. a, for using in a different repo, ok. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D29347 To: dfaure, aacid, apol, mdawson Cc:

D29363: Use UI marker context in more tr() calls

2020-05-02 Thread Albert Astals Cid
aacid added a comment. The descriptions seem reasonable. The problem with this is that it makes all strings untranslated and i'm not sure it's worth the effort. My hope is that at this point anything that was actually ambiguous would have been reported by the translators and fixed.

D29347: KAuthorized: export method to reload restrictions

2020-05-02 Thread Albert Astals Cid
aacid added a comment. So how you're going to use it from unittests? declaring the function there? maybe better to declare it to some of the _p.h headers ? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D29347 To: dfaure, aacid, apol, mdawson Cc:

Re: Information regarding upcoming Gitlab Migration: clarifications

2020-04-30 Thread Albert Astals Cid
El dijous, 30 d’abril de 2020, a les 21:31:02 CEST, Ben Cooksley va escriure: > On Fri, May 1, 2020 at 6:04 AM Ivan Čukić wrote: > > > > > We have made a big fuss in the past about having different projects > > > that do the same thing and now we'll have that but also we'll have > > > several

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Albert Astals Cid
El dilluns, 27 d’abril de 2020, a les 3:40:01 CEST, Bhushan Shah va escriure: > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for > replies] > > Hello Community members, > > In view of upcoming Gitlab migration, we sysadmin team wants to share > the recommended structuring for

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Albert Astals Cid
El dilluns, 27 d’abril de 2020, a les 13:19:07 CEST, Ben Cooksley va escriure: > On Mon, Apr 27, 2020 at 11:12 PM Olivier Churlaud > wrote: > > > > Hi, > > > > Le lundi 27 avril 2020, 12:38:42 CEST Aleix Pol a écrit : > > > On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah wrote: > > > > > > > >

Re: Information regarding upcoming Gitlab Migration

2020-04-27 Thread Albert Astals Cid
El dilluns, 27 d’abril de 2020, a les 13:58:02 CEST, Bhushan Shah va escriure: > In part I am mostly re-iterating what Ben already mentioned in different > messages. > > On Mon, Apr 27, 2020 at 12:38:42PM +0200, Aleix Pol wrote: > > Does this mean that to clone it we'll have to go "git clone > >

D24367: Some sanity verification

2020-04-26 Thread Albert Astals Cid
aacid accepted this revision. aacid added a comment. This revision is now accepted and ready to land. Looks good to me :) REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D24367 To: sandsmark, aacid, cfeck Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

D26342: Allow overriding to disable auto language detection

2020-04-25 Thread Albert Astals Cid
aacid added a comment. You need to update the \since markers? After that i guess you can commit unless anyone really disagrees? @mludwig @cullmann ? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D26342 To: sdepiets, #frameworks, cullmann, mlaurent, mludwig

D25267: Improve XCF support

2020-04-14 Thread Albert Astals Cid
aacid added a comment. In D25267#647547 , @sandsmark wrote: > In D25267#647148 , @aacid wrote: > > > Seems like the windows build is broken :/ > > > >

D25267: Improve XCF support

2020-04-13 Thread Albert Astals Cid
aacid added a comment. In D25267#647129 , @sandsmark wrote: > I messed up and it got linked to the wrong phabricator review... Here it is anyways: > >

D25267: Improve XCF support

2020-04-12 Thread Albert Astals Cid
aacid added a comment. the files are not uploaded correctly to phabricator so i can't check they work. Given we just released KF 5.69 *yesterday* i'm going to go crazy and say commit this and we have a "whole month" to fix regressions if it has any... REPOSITORY R287 KImageFormats

D27632: Implement UString operator= to make gcc happy

2020-04-12 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R314:e637e721e40e: Implement UString operator= to make gcc happy (authored by aacid). REPOSITORY R314 KJs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27632?vs=76323=79911 REVISION DETAIL

D26342: Allow overriding to disable auto language detection

2020-03-23 Thread Albert Astals Cid
aacid added a comment. In D26342#632842 , @sdepiets wrote: > In D26342#623729 , @aacid wrote: > > > Would it make sense to enshrine this behaviour with an autotest? > > > Sorry what do you mean

D28151: Autotest file showing wrong File path

2020-03-19 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D28151 To: usta, meven, aacid Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

2020-03-12 Thread Albert Astals Cid
aacid added a comment. Looks reasonable to me, but i'm not a huge expert here either, i guess you can commit given you are the expert. Or maybe wait a few days in case someone else has commits? REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D27966 To: dfaure,

D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

2020-03-11 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > dfaure wrote in partloader.h:59 > This is an excellent point, thanks for this feedback. > > Loading a part from a given KPluginMetadata is extremely simple, though: > > KPluginLoader loader(md.fileName()); > m_part =

D27997: Fix cmake warning

2020-03-11 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH warning REVISION DETAIL https://phabricator.kde.org/D27997 To: apol, #frameworks, aacid Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27966: KParts: add PartLoader as replacement to KMimeTypeTrader for parts

2020-03-10 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > partloader.h:59 > + */ > +KPARTS_EXPORT QVector partsForMimeType(const QString > ); > + What's the use for this? The function below doesn't let me chose which one i want (i guess it always uses the one with the most preference?), so why

D26342: Allow overriding to disable auto language detection

2020-03-07 Thread Albert Astals Cid
aacid added a comment. Would it make sense to enshrine this behaviour with an autotest? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D26342 To: sdepiets, #frameworks, cullmann, mlaurent, mludwig Cc: aacid, mludwig, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D26342: Allow overriding to disable auto language detection

2020-03-07 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > backgroundchecker.cpp:147 > { > +d->autoDetectLanguageDisabled = true; > d->currentDict = speller; question from someone that has never really used this setSpeller API. Is this behaviour change for sure 100% of the times wanted? If not

D26342: Allow overriding to disable auto language detection

2020-02-29 Thread Albert Astals Cid
aacid added a comment. without having used Sonnet much, this seems the wrong API to me. Are you saying that it can happen that you tell Sonnet "use this language" and it goes and say "nah i'll ignore you and do my thing". It seems to me that what would make sense is that the "use

D27633: Port to KPluginLoader

2020-02-28 Thread Albert Astals Cid
aacid added a comment. In D27633#619369 , @aacid wrote: > In D27633#619365 , @aacid wrote: > > > I think this broke

D27633: Port to KPluginLoader

2020-02-28 Thread Albert Astals Cid
aacid added a comment. In D27633#619365 , @aacid wrote: > I think this broke https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console guess ¿KAccountsDPlugin now requires parameters to the constructor

D27633: Port to KPluginLoader

2020-02-28 Thread Albert Astals Cid
aacid added a comment. I think this broke https://build.kde.org/job/Applications/job/ktp-common-internals/job/kf5-qt5%20SUSEQt5.12/20/console guess ¿KAccountsDPlugin now requires parameters to the constructor and is thus not a valid Q_INTERFACE? @nicolasfella can you please look at it?

D27632: Implement UString operator= to make gcc happy

2020-02-24 Thread Albert Astals Cid
aacid added a subscriber: porten. REPOSITORY R314 KJs REVISION DETAIL https://phabricator.kde.org/D27632 To: aacid Cc: porten, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27632: Implement UString operator= to make gcc happy

2020-02-24 Thread Albert Astals Cid
aacid created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. aacid requested review of this revision. REVISION SUMMARY otherwise complains that there's a copy constructor but not an assignment operator REPOSITORY R314 KJs BRANCH

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

2020-02-22 Thread Albert Astals Cid
aacid added a comment. Any particular reason you added me? REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D27039 To: davidre, #frameworks, aacid Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

Re: Banning QNetworkAccessManager

2020-02-20 Thread Albert Astals Cid
El dijous, 20 de febrer de 2020, a les 14:29:47 CET, Allen Winter va escriure: > On Wednesday, February 19, 2020 6:09:02 PM EST Albert Astals Cid wrote: > > El dimecres, 19 de febrer de 2020, a les 9:28:22 CET, Volker Krause va > > escriure: > > > Additionally, improved d

Re: Banning QNetworkAccessManager

2020-02-19 Thread Albert Astals Cid
El dimecres, 19 de febrer de 2020, a les 9:28:22 CET, Volker Krause va escriure: > Additionally, improved documentation, a possible KNAM and/or driving the QNAM > changes upstream can still be done alongside this obviously. Also for Qt5 which will probably never be changed a clazy warning and

Re: Banning QNetworkAccessManager

2020-02-19 Thread Albert Astals Cid
El dimecres, 19 de febrer de 2020, a les 8:05:01 CET, Ben Cooksley va escriure: > The easiest path forward is to simply ban QNetworkAccessManager. Stop saying that, that's not going to happen. Cheers, Albert > > > > > Regards, > > Volker > > Regards, > Ben >

Re: 2 kirigami fixes for a point release

2020-02-18 Thread Albert Astals Cid
El dimarts, 18 de febrer de 2020, a les 4:03:05 CET, Nate Graham va escriure: > On 2020-02-16 14:43, Albert Astals Cid wrote: > > Maybe i explain myself wrongly, i'm not blaming distros at all. > > > > They made a decision, we/I may agree with them or not, that's *my/our*

D27459: Port QLinkedList which is deprecated in qt5.15

2020-02-17 Thread Albert Astals Cid
aacid added a comment. Are we sure we can lose the features of QLinkedList here? maybe makes more sense to use std::list that has the same features as QLinkedList? REPOSITORY R263 KXmlGui BRANCH port_QLinkedList (branched from master) REVISION DETAIL

Re: 2 kirigami fixes for a point release

2020-02-16 Thread Albert Astals Cid
El diumenge, 16 de febrer de 2020, a les 22:34:51 CET, David Faure va escriure: > On dimanche 16 février 2020 22:17:17 CET Albert Astals Cid wrote: > > This is their fault, they as a distribution have decided to support a random > > KDE Frameworks version for longer than we do

Re: 2 kirigami fixes for a point release

2020-02-16 Thread Albert Astals Cid
El dissabte, 15 de febrer de 2020, a les 20:35:23 CET, Nate Graham va escriure: > On 2020-02-15 11:55, Ben Cooksley wrote: > > My point above was that the version you decide to freeze on should > > only be the version you depend on during development. > > The version you depend on when you release

D27419: Update Japanese holidays

2020-02-15 Thread Albert Astals Cid
aacid added a comment. No, she (i think) does not have commit access. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D27419 To: nhiga, dvratil, winterz, cgiboudeaux Cc: aacid, #kde_pim, kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2, dcaliste,

D25698: New query mechanism for applications: KApplicationTrader

2020-02-04 Thread Albert Astals Cid
aacid added a comment. For me it can go in, but i'm not really really netiher a Frameworks developer nor potentially a user of this class, so i'd feel more confortable if someone else also +1'ed On the other hand you're the mega-manintainer of everything, so i guess it can go in :)

D26873: KStandardAction: add method for SwitchApplicationLanguage action creation

2020-01-29 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH addconveniencemethodforlanguageswitchaction REVISION DETAIL https://phabricator.kde.org/D26873 To: kossebau, #frameworks, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2,

D26990: Allow setting ItemsModel engine to either KNSCore or KNSQuick engine

2020-01-29 Thread Albert Astals Cid
aacid added a comment. Seems reasonable to me. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D26990 To: leinir, #knewstuff, aacid, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D21721: Bring KNewStuffQuick to feature parity with KNewStuff(Widgets)

2020-01-28 Thread Albert Astals Cid
aacid added a comment. FWIW this broke artikulate since you changed the expected entry for engine: in KNS.ItemsModel REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D21721 To: leinir, #knewstuff, #vdg, #frameworks, ahiemstra Cc: aacid, cfeck, davidedmundson,

D26167: Update holidays and add flagdays and namedays for Sweden

2020-01-28 Thread Albert Astals Cid
This revision was automatically updated to reflect the committed changes. Closed by commit R175:2d9ea97d1cdd: Update holidays and add flagdays and namedays for Sweden (authored by riiga, committed by aacid). REPOSITORY R175 KHolidays CHANGES SINCE LAST UPDATE

D25698: New query mechanism for applications: KApplicationTrader

2020-01-19 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > kapplicationtrader.h:56 > + * true for all services, this would return the complete list of all > + * installed applications (slow). > + * why is it slow? Looking at the code we have to go trhough all apps anyway since what we do is

D25698: New class KApplicationTrader, to replace KMimeTypeTrader and KServiceTypeTrader

2020-01-17 Thread Albert Astals Cid
aacid added inline comments. INLINE COMMENTS > kapplicationtrader.h:57 > + * > + * The @p constraint language is rather full. The most common > + * keywords are AND, OR, NOT, IN, and EXIST, all used in an all this "constraint" definition needs updating REVISION DETAIL

D26205: KWallet: Port QRegExp to QRegularExpression

2020-01-15 Thread Albert Astals Cid
aacid added a comment. In D26205#595080 , @ahmadsamir wrote: > In D26205#595034 , @blaze wrote: > > >

Re: KApplicationTrader API

2020-01-12 Thread Albert Astals Cid
El diumenge, 12 de gener de 2020, a les 11:50:03 CET, David Faure va escriure: > I wrote a KApplicationTrader class in https://phabricator.kde.org/D25698 > and I need input on API. > > Use case: the user types "km" in krunner. > In order to find all applications that contain "km" (case

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

2020-01-05 Thread Albert Astals Cid
aacid added a comment. Why are we using a string instead of an enum? It's not like this is KXMLGui where people can define their own actions, is it? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26424 To: nicolasfella, #frameworks, dfaure Cc: dhaumann, aacid,

D26424: [kdiroperator] Add method for accessing actions without KActionCollection

2020-01-04 Thread Albert Astals Cid
aacid added a comment. What's the point of removing the KXMLGui dependency? I mean it's not like you will be able to do Kate or KDevelop without kxmlgui, no? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26424 To: nicolasfella, #frameworks, dfaure Cc: aacid,

D26410: Port KLanguageButton from KConfig to QSettings

2020-01-04 Thread Albert Astals Cid
aacid requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26410 To: nicolasfella, #frameworks, davidedmundson, aacid Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26376: [Kuit] Use const and QList::at() as need be

2020-01-02 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH l-toKeyCombo-micro-opti (branched from master) REVISION DETAIL https://phabricator.kde.org/D26376 To: ahmadsamir, apol, aacid Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

2020-01-01 Thread Albert Astals Cid
aacid accepted this revision. This revision is now accepted and ready to land. REPOSITORY R238 KDocTools BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL https://phabricator.kde.org/D26317 To: mlaurent, dfaure, aacid Cc: ltoscano, aacid, anthonyfieroni,

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

2019-12-31 Thread Albert Astals Cid
aacid added a comment. Ah, it works fine in 5.14. I was going to say we must report to Qt immediately that they broke source compatibility and that was unacceptable but then i realized that the old non namespaced version works just fine, it's just deprecated. I'm going to go back

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

2019-12-31 Thread Albert Astals Cid
aacid added a comment. But it is already namespaced in older Qt too, so no ifdef needed REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D26317 To: mlaurent, dfaure Cc: aacid, anthonyfieroni, kde-frameworks-devel, kde-doc-english, LeGast00n, gennad, fbampaloukas,

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

2019-12-31 Thread Albert Astals Cid
aacid added a comment. Isn't it better to just use `Qt::endl` ? I think it's much clearer to understand `Qt::endl` than `QLatin1Char('\n')` But if we prefer to change to use \n it should be merged into the existing strings, doesn't make much sense to do `outStream << "" <<

Re: Exemptions to try KF "grow" vs. consistent experience (Re: Submitting Grantlee as a KF5 Framework)

2019-12-28 Thread Albert Astals Cid
El divendres, 27 de desembre de 2019, a les 11:03:25 CET, Volker Krause va escriure: > On Thursday, 26 December 2019 19:25:09 CET Albert Astals Cid wrote: > > El dimarts, 24 de desembre de 2019, a les 13:05:23 CET, Friedrich W. H. > Kossebau va escriure: > > > Am Montag, 23.

Re: Exemptions to try KF "grow" vs. consistent experience (Re: Submitting Grantlee as a KF5 Framework)

2019-12-26 Thread Albert Astals Cid
El dimarts, 24 de desembre de 2019, a les 13:05:23 CET, Friedrich W. H. Kossebau va escriure: > Am Montag, 23. Dezember 2019, 09:57:57 CET schrieb Volker Krause: > > On Sunday, 22 December 2019 09:46:02 CET Dominik Haumann wrote: > > > Hi all, > > > > > > in any case, maybe the discussed points

D26197: Display fully qualified class/namespace name as page header

2019-12-24 Thread Albert Astals Cid
aacid added a comment. I've no idea about the code, but looks sensible to me, so take this as a +2 if noone reviews in a while i guess :) REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D26197 To: davidre Cc: aacid, jucato, kde-frameworks-devel, kde-doc-english,

D25974: Fix Invalid-enum-value assignment

2019-12-24 Thread Albert Astals Cid
aacid added a comment. Thanks for taking care of it, i was busy yesterday with pre-xmas stuff REPOSITORY R270 KCodecs REVISION DETAIL https://phabricator.kde.org/D25974 To: aacid, dfaure Cc: dfaure, security-team, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Frameworks minimum Qt version raised to 5.12

2019-12-21 Thread Albert Astals Cid
I just executed the policy that says last three Qt versions, i.e. 5.12, 5.13 and 5.14 Cheers, Albert P.S: Since we have the new Qt LTS exception to the policy we won't be raising the minimum requirement until Qt 5.16 is released (assuming Qt 5.15 is LTS and there is a Qt 5.16) and then we

D25974: Fix Invalid-enum-value assignment

2019-12-14 Thread Albert Astals Cid
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R270:a890441e38ee: Fix Invalid-enum-value assignment (authored by aacid). CHANGED PRIOR TO COMMIT

D25937: pic: Fix Invalid-enum-value undefined behaviour

2019-12-14 Thread Albert Astals Cid
aacid closed this revision. REPOSITORY R287 KImageFormats REVISION DETAIL https://phabricator.kde.org/D25937 To: aacid, dfaure Cc: dfaure, security-team, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

  1   2   3   4   5   6   7   8   9   10   >