D25193: use more modern for construct

2019-11-07 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R303 KInit BRANCH master REVISION DETAIL https://phabricator.kde.org/D25193 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25192: Replace for with maths with range for

2019-11-07 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D25192 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25164: MobileTextActionsToolBar check if controlRoot is undefined before using it

2019-11-06 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D25164 To: meven, #plasma, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25159: Fix linking to libssh 0.9.1

2019-11-05 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Fixes the build for me too, patch looks good. Thanks! REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25159 To: arojas, apol Cc: apol, asturmlechner,

D25143: Basic cross-compiling support for parsetrigrams

2019-11-05 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. LGTM, thanks for looking into this! REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D25143 To: vkrause, cullmann, apol Cc: apol, cullmann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

2019-11-05 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D24843 To: kmaterka, apol, davidedmundson, #plasma, #frameworks, broulik, nicolasfella Cc:

D25154: actually set a dependency between kcrashtest and test_crasher

2019-11-05 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R285 KCrash BRANCH test-dep REVISION DETAIL https://phabricator.kde.org/D25154 To: sitter, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25153: disable kcrashtest and its helper executable test_crasher on windows

2019-11-05 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R285 KCrash BRANCH master REVISION DETAIL https://phabricator.kde.org/D25153 To: sitter, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25117: file ioslave: stop copying as soon as the ioslave is killed

2019-11-02 Thread Aleix Pol Gonzalez
apol added a comment. +1 makes a lot of sense overall. INLINE COMMENTS > filecopyjob.h:74 > bool doResume() override; > -bool doKill() override; > I don't think this change is ABI compatible (though after reading the docs, I'm not 100% sure).

D25115: Add guard for missing kirigami

2019-11-02 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D25115 To: davidedmundson, #plasma, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25113: ftp ioslave: remove redundant variable

2019-11-02 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25113 To: meven, #frameworks, kossebau, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25107: Add install dir for systemd units

2019-11-02 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D25107 To: davidedmundson, apol Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh,

D22946: Include API to generically implement --replace arguments

2019-10-31 Thread Aleix Pol Gonzalez
apol marked an inline comment as done. REPOSITORY R271 KDBusAddons REVISION DETAIL https://phabricator.kde.org/D22946 To: apol, #frameworks, davidedmundson Cc: davidedmundson, broulik, kossebau, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22946: Include API to generically implement --replace arguments

2019-10-31 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 69147. apol added a comment. Rebase and get inspiration from 5bf091ee07ac44ed1bf1e75a4d07847edb86c5d6 as suggested by David REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE

D24726: Fix null pointer reference when extraction fails

2019-10-31 Thread Aleix Pol Gonzalez
apol added a comment. Have you looked into creating a unit test for this? REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D24726 To: pvuorela, davidllewellynjones, dfaure, aacid Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

2019-10-30 Thread Aleix Pol Gonzalez
apol added a comment. This is really interesting, I can expect this to make the whole thing much faster. INLINE COMMENTS > file_unix.cpp:55 > +// On Linux, write() (and similar system calls) will transfer at most > +// 0x7000 (2,147,479,552) bytes, returning the number of bytes > +//

D25061: kconfig_compiler: Move the KSharedConfig::Ptr when using them

2019-10-30 Thread Aleix Pol Gonzalez
apol accepted this revision. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D25061 To: aacid, ervin, apol Cc: kde-frameworks-devel, ervin, apol, LeGast00n, GB_2, michaelh, ngraham, bruns

D24742: Make non-ignorable SSL errors explicit

2019-10-29 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24742 To: vkrause, #frameworks, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25025: decodeBCJ2: Fix assert with broken files

2019-10-28 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R243 KArchive BRANCH master REVISION DETAIL https://phabricator.kde.org/D25025 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25023: Make kconfig_compiler generate code with const

2019-10-28 Thread Aleix Pol Gonzalez
apol added a comment. I don't know if we can do that. There's been some changes we've pulled back assuming people could be installing + exporting classes generated from kconfig_compiler. :/ REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D25023 To: aacid Cc: apol,

D25003: [KDesktopFile] Add a property and propertyKde functions to access custom properties

2019-10-28 Thread Aleix Pol Gonzalez
apol added a comment. Hi Meven, I guess I didn't make myself clear, sorry about that. This is not what I meant. What I meant was here D24956 you can query the desktop entry directly, we don't need to expose access to it. REPOSITORY R237 KConfig

D24736: Grab the keyboard when KeySequenceItem is recording

2019-10-28 Thread Aleix Pol Gonzalez
apol accepted this revision. REPOSITORY R296 KDeclarative BRANCH grabkeyboard (branched from master) REVISION DETAIL https://phabricator.kde.org/D24736 To: davidre, #frameworks, davidedmundson, apol Cc: apol, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24736: Grab the keyboard when KeySequenceItem is recording

2019-10-28 Thread Aleix Pol Gonzalez
apol added a comment. +1 Makes sense to me. REPOSITORY R296 KDeclarative BRANCH grabkeyboard (branched from master) REVISION DETAIL https://phabricator.kde.org/D24736 To: davidre, #frameworks, davidedmundson Cc: apol, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24999: [KIO::stat] Add a KF6 TODO to make details a Bitmask

2019-10-28 Thread Aleix Pol Gonzalez
apol added a comment. you may want to explain a bit more what you mean there. it could make sense to keep the TODO in the .cpp file, no need to get it on every user REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24999 To: meven, #frameworks, dfaure Cc: apol,

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

2019-10-28 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH enableallqtkfdeprecationwarningsforframeworks REVISION DETAIL https://phabricator.kde.org/D24990 To: kossebau, #frameworks, #build_system, apol Cc:

D24978: Add KService::noGlobalShortcut corresponding to X-KDE-NoGlobalShortcut

2019-10-28 Thread Aleix Pol Gonzalez
apol added a comment. This doesn't look like some API we'd be using very often. Would it make sense to just have kglobalsettings access it through KService::property? INLINE COMMENTS > kservice.cpp:739 > +{ > +if > (qvariant_cast(property(QStringLiteral("X-KDE-NoGlobalShortcut"), >

D24974: KService: fix kded compilation with -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00

2019-10-27 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R309 KService BRANCH master REVISION DETAIL https://phabricator.kde.org/D24974 To: dfaure, kossebau, vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24938: Fix memory leak in KXzFilter::init

2019-10-24 Thread Aleix Pol Gonzalez
apol added a comment. +1 makes sense REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D24938 To: aacid Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24909: [PC3/button] Elide text always

2019-10-24 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D24909 To: davidedmundson, #plasma, apol Cc: kde-frameworks-devel, LeGast00n,

D24898: Add KLocalizedString::untranslatedText

2019-10-24 Thread Aleix Pol Gonzalez
apol added a comment. LGTM REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D24898 To: aacid Cc: apol, ilic, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23682: Make use of KPluginMetaData where we can

2019-10-22 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 68546. apol added a comment. Unrelated change REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23682?vs=68544=68546 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23682 AFFECTED FILES

D23682: Make use of KPluginMetaData where we can

2019-10-22 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 68544. apol added a comment. Adopt new deprecation macros REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23682?vs=65328=68544 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23682

D24859: Add a .desktop file for kdeinit

2019-10-22 Thread Aleix Pol Gonzalez
apol added a comment. Same as D24858 REPOSITORY R303 KInit REVISION DETAIL https://phabricator.kde.org/D24859 To: meven, apol, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24858: Add X-KDE-Wayland-Interfaces to kwalletd desktop file

2019-10-22 Thread Aleix Pol Gonzalez
apol added a comment. These are not necessary for kwallet as far as I know. To fix this warning we'd have to look into where applications are requesting these and have these interfaces only requested when they're necessary. REPOSITORY R311 KWallet REVISION DETAIL

D24676: Port the KSSLD D-Bus interface from KSslError to QSslError

2019-10-21 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D24676 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24824: Remove outdated comment about [$e] expansion

2019-10-21 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D24824 To: davidedmundson, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24671: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-20 Thread Aleix Pol Gonzalez
apol added a comment.  sorry about slow reviews. The patch looks good. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D24671 To: kossebau, #frameworks, #plasma, mart, apol Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24742: Make non-ignorable SSL errors explicit

2019-10-17 Thread Aleix Pol Gonzalez
apol added a comment. LGTM otherwise INLINE COMMENTS > ksslcertificatemanager.cpp:537 > +}); > return {}; > } `return ret; ` ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24742 To: vkrause Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24725: Fix grammar

2019-10-17 Thread Aleix Pol Gonzalez
apol retitled this revision from "GIT_SILENT Fix grammar" to "Fix grammar". REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D24725 To: ahmadsamir, #frameworks, mpyne Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24725: Fix grammar

2019-10-17 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH text-fix (branched from master) REVISION DETAIL https://phabricator.kde.org/D24725 To: ahmadsamir, #frameworks, mpyne, apol Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24629: RFC: Introduce KClockSkewNotifier class

2019-10-14 Thread Aleix Pol Gonzalez
apol added a comment. It feels weird to create a class directly into KF5 when it hasn't even started to be used. It could make sense to develop it within some of the apps and when we are sure the API is stable and it wants to be used on other components/products, we can promote it to the

D24630: Replace all qWarning and related calls with categorised logging

2019-10-14 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH categorised_logging REVISION DETAIL https://phabricator.kde.org/D24630 To: ahiemstra, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a common KDE style file

2019-10-11 Thread Aleix Pol Gonzalez
apol added a comment. I'm not sure how this works, but would it be possible to have a target that only works on a patch? You usually want to make sure what you modified didn't diverge from the code. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568

D24382: Port (most of) the interface of KSslCertificateRule to QSslError

2019-10-11 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH next REVISION DETAIL https://phabricator.kde.org/D24382 To: vkrause, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24559: simplify the url parsing

2019-10-11 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH simplify-proxy-load REVISION DETAIL https://phabricator.kde.org/D24559 To: sitter, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24490: Make kconfig_compiler generate ctors with the optional parent arg

2019-10-11 Thread Aleix Pol Gonzalez
apol added a comment. ok, let's just land this for now. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24490 To: ervin, #plasma, #frameworks, dfaure, mart, apol Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24554: Don't build static library when BUILD_TESTING=OFF

2019-10-11 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D24554 To: arojas, #frameworks, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

2019-10-11 Thread Aleix Pol Gonzalez
apol accepted this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24494 To: ervin, #plasma, #frameworks, dfaure, mart, davidedmundson, apol Cc: apol, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22362: Port keystates to use QtWayland's generator

2019-10-10 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 67671. apol added a comment. Unnecessary change REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22362?vs=67670=67671 BRANCH arcpatch-D22362 REVISION DETAIL https://phabricator.kde.org/D22362 AFFECTED FILES

D22362: Port keystates to use QtWayland's generator

2019-10-10 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 67670. apol added a comment. Just don't use KWayland::Global Lets generated code do its thing already REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22362?vs=61478=67670 BRANCH arcpatch-D22362 REVISION DETAIL

D22362: Port keystates to use QtWayland's generator

2019-10-10 Thread Aleix Pol Gonzalez
apol added a comment. In D22362#493722 , @davidedmundson wrote: > As some background: > > At a recent Plasma sprint, one comment was that adding protocols to KWayland was an absolute pain involving writing a tonne of boiler plate. My

D24490: Make kconfig_compiler generate ctors with the optional parent arg

2019-10-10 Thread Aleix Pol Gonzalez
apol added a comment. #if FRAMEWORK_VERSION < 6 defaultValue = false #else defaultValue = true #endif Or at least #if FRAMEWORK_VERSION >= 6 #pragma message Consider enabling ParentInConstructor by default #endif It's just a thought, not necessary. REPOSITORY R237

D24494: Add convenience for defaults/dirty states to KCoreConfigSkeleton

2019-10-10 Thread Aleix Pol Gonzalez
apol added a comment. Looks better, it could make sense to add a KF6 TODO/Warning. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24494 To: ervin, #plasma, #frameworks, dfaure, mart Cc: apol, kossebau, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2,

D24490: Make kconfig_compiler generate ctors with the optional parent arg

2019-10-10 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. It could make sense to tweak it so in KF6 `ParentInConstructor=true` it's true by default. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24490 To: ervin, #plasma, #frameworks, dfaure, mart, apol Cc: kossebau,

D24490: Make kconfig_compiler generate ctors with the optional parent arg

2019-10-08 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Right, makes sense. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D24490 To: ervin, #plasma, #frameworks, dfaure, mart, apol Cc: apol, kde-frameworks-devel,

D24490: Make kconfig_compiler generate ctors with the optional parent arg

2019-10-08 Thread Aleix Pol Gonzalez
apol added a comment. +1 in spirit. INLINE COMMENTS > test_notifiers.cpp.ref:7 > +TestNotifiers::TestNotifiers( int Number, QObject *parent ) >: KConfigSkeleton( QStringLiteral( "test7rc" ) ) >, mParamNumber(Number) Maybe it would be better to use the parent argument in

D24294: Port KSslCertificateManager to QSslError

2019-10-07 Thread Aleix Pol Gonzalez
apol added a comment. I may be missing some context but this doesn't seem to be porting anything only adding a nonIgnorableErrors function that ignores whatever it gets. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24294 To: vkrause, dfaure Cc: apol,

D23682: Make use of KPluginMetaData where we can

2019-10-07 Thread Aleix Pol Gonzalez
apol added a comment. ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23682 To: apol, #plasma Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24010: Fix generating properties that start with an uppercase letter

2019-10-03 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R237:a23acd2f1535: Fix generating properties that start with an uppercase letter (authored by apol). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24010?vs=67204=67294

D23266: Export Plasma core lib log category, add a category to a qWarning

2019-10-03 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. Go for it, can change later too. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D23266 REVISION DETAIL https://phabricator.kde.org/D23266 To: meven, #frameworks, broulik, davidedmundson, apol Cc: apol,

D24398: Rewrite ugly for with pointer arithmetic into range for

2019-10-03 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH master REVISION DETAIL https://phabricator.kde.org/D24398 To: aacid, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24010: Fix generating properties that start with an uppercase letter

2019-10-02 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 67204. apol added a comment. Update test, it seems like tests aren't comparing with .ref now :( REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24010?vs=66271=67204 BRANCH master REVISION DETAIL

D24252: Make OK button configurable in KMessageBox::sorry/detailedSorry

2019-10-01 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH 2019_09_okbutton_configurable REVISION DETAIL https://phabricator.kde.org/D24252 To: dfaure, cfeck, vkrause, apol Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2,

D23512: Avoid overloading KCModule::changed

2019-10-01 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R265 KConfigWidgets BRANCH master REVISION DETAIL https://phabricator.kde.org/D23512 To: davidedmundson, apol Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24159: new module ECMSourceVersionControl

2019-10-01 Thread Aleix Pol Gonzalez
apol added a comment. +1 REPOSITORY R240 Extra CMake Modules BRANCH vcs REVISION DETAIL https://phabricator.kde.org/D24159 To: sitter, kde-buildsystem, dfaure Cc: apol, kossebau, kde-frameworks-devel, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D23682: Make use of KPluginMetaData where we can

2019-09-30 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > broulik wrote in dataengine.cpp:70 > Where is this constructor used? Unsure, but we can't remove symbols anyway... REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23682 To: apol, #plasma Cc: broulik,

D24072: properly install whole plasmacomponent3

2019-09-19 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/components3 REVISION DETAIL https://phabricator.kde.org/D24072 To: mart, #plasma, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24050: Deploy default avatar via qrc

2019-09-18 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH avatar REVISION DETAIL https://phabricator.kde.org/D24050 To: nicolasfella, apol Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23766: FakeInput: add support for keyboard key press and release

2019-09-17 Thread Aleix Pol Gonzalez
apol added a comment. The patch looks good to me, is there a reason why it wasn't accepted? REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D23766 To: jgrulich, davidedmundson, apol, #plasma, romangg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D24025: Don't use KCrash on Android

2019-09-17 Thread Aleix Pol Gonzalez
apol added a comment. In D24025#533418 , @vkrause wrote: > I think the line between dummy and #ifdef is in the commit message: if we don't want something on Android #ifdef is IMHO the way to go, if we merely don't have something yet, let's go

D24025: Don't use KCrash on Android

2019-09-17 Thread Aleix Pol Gonzalez
apol added a comment. Why not? it could be useful. The alternative is darkness over what happened there. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24025 To: nicolasfella, dfaure Cc: apol, broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24024: Bundle plugin files on Android

2019-09-17 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D24024 To: nicolasfella, apol, vkrause Cc: kde-frameworks-devel, LeGast00n, laraque, GB_2, jackyalcine, vatra, michaelh, ognarb, ngraham, bruns,

D24010: Fix generating properties that start with an uppercase letter

2019-09-16 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 66271. apol added a comment. Also make the property lowercase QML doesn't like properties that start uppercase REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24010?vs=66270=66271 BRANCH master REVISION DETAIL

D24010: Fix generating properties that start with an uppercase letter

2019-09-16 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY We were not adjusting the property name to the getter letter-casing. TEST PLAN See

D23994: [KPeople] Port away from deprecated methods in Qt 5.14

2019-09-16 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Thank you! REPOSITORY R307 KPeople BRANCH master REVISION DETAIL https://phabricator.kde.org/D23994 To: dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23990: [kcmutils] Port away from deprecated methods in Qt 5.14

2019-09-16 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Looks good :) REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D23990 To: dfaure, apol, ngraham, davidedmundson Cc: kde-frameworks-devel, LeGast00n,

D23968: Use app specific location for DB on Android

2019-09-16 Thread Aleix Pol Gonzalez
apol added a comment. In D23968#532237 , @nicolasfella wrote: > I thought the same thing, but I'm not sure if changing that could break some apps I don't see how many apps would be using a writtableLocation they can't write into. :/

D23970: Port away from deprecated methods in Qt 5.14

2019-09-15 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D23970 To: dfaure, davidedmundson, broulik, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D23968: Use app specific location for DB on Android

2019-09-15 Thread Aleix Pol Gonzalez
apol added a comment. Then maybe Qt shouldn't offer it? It's supposed to be writtable after all... REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D23968 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23828: Disable DBus pieces on Android

2019-09-11 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH dbus REVISION DETAIL https://phabricator.kde.org/D23828 To: nicolasfella, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23827: Add manual tests for PC3

2019-09-11 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. cool! REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D23827 To: davidedmundson, #plasma, apol Cc: apol, kde-frameworks-devel,

D23777: Fix diff

2019-09-07 Thread Aleix Pol Gonzalez
apol added a comment. Please fix commit message. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23777 To: GB_2 Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23411: Fix crash in writer collection and cleanup

2019-09-07 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > writer.h:63 > > +WriterPrivate *d; > friend class WriterCollection; Why's this change? > writercollection.cpp:133 > +Writer writer; > +writer.d->m_plugin = plugin; > +

D23764: Make it possible to delete contacts from backends

2019-09-07 Thread Aleix Pol Gonzalez
apol accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople BRANCH master REVISION DETAIL https://phabricator.kde.org/D23764 To: jbbgameich, apol, #plasma:_mobile Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23722: Warn if KPackage is invalid

2019-09-05 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Let's consider it an iteration though. INLINE COMMENTS > broulik wrote in configmodule.cpp:174 > Is "mainscript" mandatory? > > In any case, if your package has the incorrect folder

D23722: Warn if KPackage is invalid

2019-09-04 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > configmodule.cpp:174 > + > if (!package.filePath("mainscript").isEmpty()) { > d->_qmlObject->setSource(package.fileUrl("mainscript")); maybe put it after checking the mainscript? the "no QML file provided" error is more accurate. We

D23682: Make use of KPluginMetaData where we can

2019-09-03 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 65328. apol marked 6 inline comments as done. apol added a comment. Forgot these REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23682?vs=65327=65328 BRANCH master REVISION DETAIL

D23682: Make use of KPluginMetaData where we can

2019-09-03 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 65327. apol added a comment. address comments REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23682?vs=65261=65327 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23682 AFFECTED FILES

D22968: Make it possible to modify contacts

2019-09-02 Thread Aleix Pol Gonzalez
apol abandoned this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22968 To: apol, #frameworks, jbbgameich, bshah Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22968: Make it possible to modify contacts

2019-09-02 Thread Aleix Pol Gonzalez
apol added a comment. Committed as https://commits.kde.org/kpeople/7cf00a2cb27dcc11c8cd5b06423ce69c41537c82. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22968 To: apol, #frameworks, jbbgameich, bshah Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D23682: Make use of KPluginMetaData where we can

2019-09-02 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Instead of relying on the older KPluginInfo which is slower (parses de metadata twice) and

D23674: Use QString::count(QChar)+1 over QString::splitRef().length()

2019-09-02 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > normalvimode.cpp:3848 > } else { > -cAfter.setColumn(textLines.last().length() - 0); > -cAfter.setLine(cAfter.line() + textLines.length() - 1); > +const int lastLineLength = pastedText.size() - >

D23625: Use QString::count(QChar) over QString::split().length() - 1

2019-09-02 Thread Aleix Pol Gonzalez
apol added inline comments. INLINE COMMENTS > normalvimode.cpp:3844 > KTextEditor::Cursor cAfter = pasteLocation; > -const QStringList textLines = pastedText.split(QStringLiteral("\n")); > +const QStringList textLines = pastedText.split(QLatin1Char('\n')); > if

D23588: remove unnecessary check

2019-08-30 Thread Aleix Pol Gonzalez
apol created this revision. apol added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY setDevicePixelRatio already checks if it needs to enable m_textureChanged. TEST PLAN

D23587: Skip test on wayland

2019-08-30 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes. Closed by commit R242:ea88d2aa51d2: Skip test on wayland (authored by apol). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23587?vs=65007=65008 REVISION DETAIL

D23587: Skip test on wayland

2019-08-30 Thread Aleix Pol Gonzalez
apol created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY It's using some API that isn't available TEST PLAN Noise gone REPOSITORY R242 Plasma Framework (Library) BRANCH

D23586: Improve code that detects useful elements in an Svg file

2019-08-30 Thread Aleix Pol Gonzalez
apol created this revision. apol added reviewers: Plasma, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. apol requested review of this revision. REVISION SUMMARY Detect any that contains a "-[a-z]" (i.e. a dash and a lowercase letter. So far

D22968: Make it possible to modify contacts

2019-08-29 Thread Aleix Pol Gonzalez
apol marked an inline comment as done. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22968 To: apol, #frameworks, jbbgameich, bshah Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22968: Make it possible to modify contacts

2019-08-29 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 64963. apol added a comment. Don't get creative naming classes on the qml plugin REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22968?vs=64834=64963 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22968

D23551: CMake config files: use as min dep version the Qt version we built against

2019-08-28 Thread Aleix Pol Gonzalez
apol added a comment. This will only work one-way. If the "wrong" Qt is older, but it's not necessarily the case. Also cmake may be linking against the "right" Qt but then use the "wrong" one at runtime. I'm not convinced. REPOSITORY R263 KXmlGui REVISION DETAIL

  1   2   3   4   5   6   7   8   9   10   >