D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

anemeth added a comment. In D18798#418072 , @ngraham wrote: > In D18798#418056 , @pino wrote: > > > Also, please do not resort to psychological tricks like "torture our users", as if this is any wors

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

anemeth added a comment. In D18798#407428 , @elvisangelaccio wrote: > Wait, do we need to add this workaround to every popup menu around? What about 3d-party apps? > > Can't we fix the actual bug in Qt/breeze/whatever instead? I beli

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

anemeth added a comment. I will wait for someone from the frameworks team to review this before landing it. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D18798 To: anemeth, #frameworks, kde-frameworks-devel, ngraham Cc: ngraham, kde-frameworks-devel,

D18798: [KIO/drag and drop] Fix file and folder drag and drop popup menu transparency

anemeth retitled this revision from "Fix file and folder drag and drop popup menu transparency" to "[KIO/drag and drop] Fix file and folder drag and drop popup menu transparency". anemeth added a reviewer: kde-frameworks-devel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org

D18798: Fix file and folder drag and drop popup menu transparency

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added a reviewer: Frameworks. anemeth added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D18798 To: anemeth, #frameworks Cc: ngraham, kde-frameworks-

D18798: Fix file and folder drag and drop popup menu transparency

anemeth created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. anemeth requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D18798 AFFECTED FILES src/widgets/dropjob.cpp To:

D12545: Set focus on the filename line edit when a file is selected

anemeth abandoned this revision. anemeth added a comment. @ngraham I'm sorry, but because of my new job I don't have much free time left so I can't actively develop anymore. I'd really like if someone took over this patch. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org

D12848: Set fix steps for icon sizes

anemeth updated this revision to Diff 34064. anemeth added a comment. - Remove unused function REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12848?vs=34063&id=34064 BRANCH standard-icon-sizes (branched from master) REVISION DETAIL https://phabricator.kde

D12848: Set fix steps for icon sizes

anemeth edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12848 To: anemeth, #frameworks, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D12848: Set fix steps for icon sizes

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Frameworks, VDG. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12848 To: anemeth, #frameworks, #vdg Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D12848: Set fix steps for icon sizes

anemeth added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12848 To: anemeth, #frameworks, #vdg Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D12848: Set fix steps for icon sizes

anemeth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. anemeth requested review of this revision. REPOSITORY R241 KIO BRANCH standard-icon-sizes (branched from master) REVISION DETAIL https://phabr

D12538: Allow accepting by double-click in save dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:c537a717363c: Allow accepting by double-click in save dialog (authored by anemeth). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33914&id=33930 REVISION DET

D12538: Allow accepting by double-click in save dialog

anemeth marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: kde-frameworks-devel, ltoscano, rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Allow accepting by double-click in save dialog

anemeth updated this revision to Diff 33914. anemeth added a comment. - Remove QFileInfo REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33900&id=33914 BRANCH arcpatch-D12538 (branched from master) REVISION DETAIL https://phabricator.kde.org/D1253

D12538: Allow accepting by double-click in save dialog

anemeth added inline comments. INLINE COMMENTS > rkflx wrote in kfilewidget.cpp:1866 > Well, how should that line look like then? I'm having a lot of trouble finding the correct syntax... And the compiler is giving me 100 lines of cryptic error message. Could you help me out on this one? REPOSI

D12538: Allow accepting by double-click in save dialog

anemeth updated this revision to Diff 33900. anemeth added a comment. Restricted Application added a subscriber: kde-frameworks-devel. - Merge branch 'master' of git://anongit.kde.org/kio into arcpatch-D12538 - Double clicking to save only works on files REPOSITORY R241 KIO CHANGES SINCE

D12328: Enable preview by default in the filepicker dialog

This revision was automatically updated to reflect the committed changes. Closed by commit R241:bec7f9d6a1ef: Enable preview by default in the filepicker dialog (authored by anemeth). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12328?vs=33167&id=33717 REVISION

D12321: Hide file preview when icon is too small

anemeth closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, elvisangelaccio Cc: elvisangelaccio, markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

anemeth closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg, ngraham, elvisangelaccio, rkflx Cc: cfeck, broulik, ngraham, #frameworks, michaelh, bruns

D12321: Hide file preview when icon is too small

anemeth added a comment. In D12321#256791 , @ngraham wrote: > Reverted. Alex, now that you have a fancy contributor account, you can land this yourself on 5/6/18, or else offer up a version of this without the tooltip change and petition to get

D12545: Set focus on the filename line edit when a file is selected

anemeth added a comment. In D12545#254473 , @rkflx wrote: > I could imagine a different spin here: [⇥] should switch focus from the item view to the name line edit, which it currently does not. (And as the dialog starts with focus on the name li

D12538: Always prompt for overwrite on double-click in save dialog

anemeth added a comment. In D12538#254871 , @rkflx wrote: > However, for double click mode and Save, descending into directories is kinda broken. You might want to fix that before shipping… REPOSITORY R241 KIO REVISION DETAIL https://phabri

D12538: Always prompt for overwrite on double-click in save dialog

anemeth edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: ltoscano, rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Always prompt for overwrite on double-click in save dialog

anemeth marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: ltoscano, rkflx, broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Always prompt for overwrite on double-click in save dialog

anemeth updated this revision to Diff 3. anemeth added a comment. - Merge branch 'master' of https://github.com/KDE/kio into doubleclick_save - reword comment - move function definition REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33204&id=33

D12321: Hide file preview when icon is too small

anemeth updated this revision to Diff 1. anemeth added a comment. - Changed tooltip for disabled preview button REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12321?vs=0&id=1 BRANCH conditional_preview (branched from master) REVISION DETAIL ht

D12321: Hide file preview when icon is too small

anemeth marked an inline comment as done. anemeth added inline comments. INLINE COMMENTS > elvisangelaccio wrote in kdiroperator.cpp:2595 > Maybe we can also add an hint about how to actually show the previews? (i.e. > the fact that the user needs to increase the icon size). Do you have a sugge

D12321: Hide file preview when icon is too small

anemeth updated this revision to Diff 0. anemeth added a comment. - Merge branch 'master' of https://github.com/KDE/kio into conditional_preview - change static_cast to qobject_cast REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12321?vs=33101&id=0 B

D12544: Don't select file extension

anemeth marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH select_filename_only (branched from master) REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg, ngraham, rkflx Cc: elvisangelaccio, rkflx, ngraham, #frameworks, michaelh, bruns

D12544: Don't select file extension

anemeth updated this revision to Diff 33325. anemeth added a comment. Remove some comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12544?vs=33173&id=33325 BRANCH select_filename_only (branched from master) REVISION DETAIL https://phabricator.kde.or

D12538: Select item without clicking the Open/Save button

anemeth updated this revision to Diff 33204. anemeth added a comment. Add comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33203&id=33204 BRANCH doubleclick_save (branched from master) REVISION DETAIL https://phabricator.kde.org/D12538 AFF

D12538: Select item without clicking the Open/Save button

anemeth added a comment. @rkflx thanks for digging through those old commits. I added that code again, but for saving only. Unfortunately I could not test it with single click because the setting has vanished (??) F5824410: aaa.PNG REPOSITORY

D12538: Select item without clicking the Open/Save button

anemeth updated this revision to Diff 33203. anemeth added a comment. Only doubleclick triggers save overwrite REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33165&id=33203 BRANCH doubleclick_save (branched from master) REVISION DETAIL https://ph

D12544: Don't select file extension

anemeth added a comment. Turns out this was already implemented before, but was not currently utilized. These 3000+ lines files are hard to overwiev... I removed these checks: `&& !locationEdit->isVisible()` I assume at one point the filename line edit was once set to hide/show on demand

D12544: Don't select file extension

anemeth updated this revision to Diff 33173. anemeth added a comment. Only enable it for save dialog REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12544?vs=33162&id=33173 BRANCH select_filename_only (branched from master) REVISION DETAIL https://phabrica

D12328: Enable preview by default in the filepicker dialog

anemeth marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D12328 To: anemeth, #frameworks, #vdg, rkflx Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12328: Enable preview by default in the filepicker dialog

anemeth updated this revision to Diff 33167. anemeth added a comment. - Rename .upd file - Add Version=5 to .upd file CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12328?vs=33103&id=33167 BRANCH preview_default (branched from master) REVISION DETAIL https://phabricator.kde.o

D12544: Don't select file extension

anemeth added a comment. There will be some problems with files that have multiple extensions, for example .tar.gz or .tar.bz We could create a list of the most common multiextension filetypes, but I only know these two and Google isn't helpful. Can some of you help me out here? Should

D12538: Select item without clicking the Open/Save button

anemeth updated this revision to Diff 33165. anemeth removed a subscriber: rkflx. anemeth added a comment. Moved filename line edit focus to D12545 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33159&id=33165 BRAN

D12544: Don't select file extension

anemeth added a comment. In D12544#254419 , @ngraham wrote: > Why don't we do it here, since it's more related--or even in a separate patch, since now that I test without the patch, it seems that it's actually an unrelated pre-existing bug.

D12545: Set focus on the filename line edit when a file is selected

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Frameworks, VDG. anemeth added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12545 To: anemeth, #frameworks, #vdg Cc: ngraham, #fram

D12545: Set focus on the filename line edit when a file is selected

anemeth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. anemeth requested review of this revision. REPOSITORY R241 KIO BRANCH focus_lineedit (branched from master) REVISION DETAIL https://phabricator.kde.org/

D12544: Don't select file extension

anemeth added a comment. In D12544#254411 , @ngraham wrote: > Nice! But I notice that even though the correct part of the text is selected, the field doesn't actually receive focus. Well, that was (will be) included in D12538

D12544: Don't select file extension

anemeth updated this revision to Diff 33162. anemeth added a comment. - Clarify comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12544?vs=33161&id=33162 BRANCH select_filename_only (branched from master) REVISION DETAIL https://phabricator.kde.org/D

D12544: Don't select file extension

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Frameworks, VDG. anemeth added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg Cc: ngraham, #fram

D12544: Don't select file extension

anemeth edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12544 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12544: Don't select file extension

anemeth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. anemeth requested review of this revision. REPOSITORY R241 KIO BRANCH select_filename_only (branched from master) REVISION DETAIL https://phabricator.kd

D12538: Select item without clicking the Open/Save button

anemeth updated this revision to Diff 33159. anemeth added a comment. Sorry, now fixed REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33157&id=33159 BRANCH doubleclick_save (branched from master) REVISION DETAIL https://phabricator.kde.org/D12538

D12538: Select item without clicking the Open/Save button

anemeth updated this revision to Diff 33157. anemeth added a comment. Remove unintentional changes REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33156&id=33157 BRANCH doubleclick_save (branched from master) REVISION DETAIL https://phabricator.kd

D12538: Select item without clicking the Open/Save button

anemeth added a comment. Whoops, some unintentional changes made it in, will fix soon... REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg, ngraham Cc: broulik, jtamate, ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

anemeth updated this revision to Diff 33156. anemeth added a comment. Focus filename lineEdit on highlight REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12538?vs=33137&id=33156 BRANCH doubleclick_save (branched from master) REVISION DETAIL https://phabri

D12538: Select item without clicking the Open/Save button

anemeth added a comment. In D12538#254239 , @jtamate wrote: > I'm one of those that choose a file and add a "_2" to the filenames. ;-) > > Please, please, ask the KDE Usability Project about this change. This patch is part of task T85

D12538: Select item without clicking the Open/Save button

anemeth edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12538 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12538: Select item without clicking the Open/Save button

anemeth retitled this revision from "Select item without clicking the open/save button" to "Select item without clicking the Open/Save button". anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Frameworks, VDG. anemeth added a sub

D12538: Select item without clicking the open/save button

anemeth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. anemeth requested review of this revision. REPOSITORY R241 KIO BRANCH doubleclick_save (branched from master) REVISION DETAIL https://phabricator.kde.or

D12385: Thumbnail smooth scaling in filepicker

anemeth added a comment. Ping. We are scaling 128px icons to lower sizes. In this case smooth transformation does not really affect performance. Can someone confirm that this is the right approach? REPOSITORY R241 KIO BRANCH image_smooth_downscale (branched from master) REVISION DE

D12328: Enable preview by default in the filepicker dialog

anemeth added a comment. The .upd is being automatically copied to `/usr/share/apps/kconf_update/` In the kconf_update log file `/home/alex/.kde4/share/apps/kconf_update/log/update.log` I found the following entry: 2018-04-25T21:41:56 Checking update-file '/usr/share/apps/kconf_upda

D12328: Enable preview by default in the filepicker dialog

anemeth updated this revision to Diff 33103. anemeth added a comment. - Actually add kconf_update files CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12328?vs=33102&id=33103 BRANCH preview_default (branched from master) REVISION DETAIL https://phabricator.kde.org/D12328 AFFEC

D12328: Enable preview by default in the filepicker dialog

anemeth updated this revision to Diff 33102. anemeth added a comment. - Merge branch 'conditional_preview' into preview_default - Added kconf_update CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12328?vs=33099&id=33102 BRANCH preview_default (branched from master) REVISION DET

D12328: Enable preview by default in the filepicker dialog

anemeth marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D12328 To: anemeth, #frameworks, #vdg, rkflx Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12328: Enable preview by default in the filepicker dialog

anemeth marked an inline comment as not done. REVISION DETAIL https://phabricator.kde.org/D12328 To: anemeth, #frameworks, #vdg, rkflx Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12321: Hide file preview when icon is too small

anemeth marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, markg Cc: markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, michaelh, bruns

D12321: Hide file preview when icon is too small

anemeth updated this revision to Diff 33101. anemeth added a comment. - Rebase on master - Remember preview state when dialog is closed - Remove trailing whitespaces left in REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12321?vs=33098&id=33101 BRANCH co

D12328: Enable preview by default in the filepicker dialog

anemeth marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D12328 To: anemeth, #frameworks, #vdg, rkflx Cc: abetts, rkflx, ngraham, #frameworks, michaelh, bruns

D12328: Enable preview by default in the filepicker dialog

anemeth updated this revision to Diff 33099. anemeth added a comment. Rebase on D12321 CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12328?vs=32611&id=33099 BRANCH preview_default (branched from master) REVISION DETAIL https://phabricator.k

D12321: Hide file preview when icon is too small

anemeth marked 2 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, markg Cc: markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, michaelh, bruns

D12321: Hide file preview when icon is too small

anemeth marked an inline comment as done. anemeth added inline comments. INLINE COMMENTS > rkflx wrote in kdiroperator.cpp:2589-2591 > Could you explain why you need to change `showPreviewsEnabledBeforeZoom` > here? As far as I can see this variable just caches the config value, and > thus shou

D12321: Hide file preview when icon is too small

anemeth marked 8 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12321 To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, markg Cc: markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, michaelh, bruns

D12321: Hide file preview when icon is too small

anemeth updated this revision to Diff 33098. anemeth added a comment. Implement changes suggested by @rkflx REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12321?vs=32872&id=33098 BRANCH conditional_preview (branched from master) REVISION DETAIL https://ph

D12521: KFileWidget use hidpi icons

anemeth abandoned this revision. anemeth added a comment. In D12521#253806 , @elvisangelaccio wrote: > Every application that opens a file dialog is supposed to do this in their own startup code (usually in `main()`). Looks like this is

D12521: KFileWidget use hidpi icons

anemeth added a comment. In D12521#253761 , @broulik wrote: > A widget setting an attribute on the application is bad Where should I set it? I can't find a mainwindow class in kio REPOSITORY R241 KIO BRANCH qt_scaling (branched fro

D12521: KFileWidget use hidpi icons

anemeth retitled this revision from "KFileWidget fix hidpi icons" to "KFileWidget use hidpi icons". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12521 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12521: KFileWidget fix hidpi icons

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Frameworks, VDG. anemeth added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12521 To: anemeth, #frameworks, #vdg Cc: ngraham, #fram

D12521: KFileWidget fix hidpi icons

anemeth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. anemeth requested review of this revision. REPOSITORY R241 KIO BRANCH qt_scaling (branched from master) REVISION DETAIL https://phabricator.kde.org/D125

D12321: Hide file preview when icon is too small

anemeth added a comment. In D12321#252299 , @rkflx wrote: > Also, as you may have noticed, the file dialog does not show previews of SVGs for any size, making your point moot. Actually with D12389 appl

D12321: Hide file preview when icon is too small

anemeth added a comment. In D12321#252238 , @markg wrote: > You are overwriting a setting that the user had explicitly set (show preview). That will result in a "huh, why is the preview off all of a sudden?" responses which will lead to bug repo

D12321: Hide file preview when icon is too small

anemeth added a comment. In D12321#252245 , @rkflx wrote: > That's simply a bug with the patch: Enable previews, set small icon set, click Cancel, reopen dialog, set large icon size. Previews should still be enabled, but they are not. I

D12328: Enable preview by default in the filepicker dialog

anemeth added a comment. I manually copied the .upd file to `/home/alex/.kde/share/apps/kconf_update` and to `/usr/share/apps/kconf_update` but it doesn't seem like kconf_update is doing its thing. What am I doing wrong? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/

D12321: Hide file preview when icon is too small

anemeth updated this revision to Diff 32872. anemeth added a comment. Change tooltip when preview button is disabled/enabled. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12321?vs=32602&id=32872 BRANCH conditional_preview (branched from master) REVISION D

D12306: Filepicker dialog proper grid icon layout

anemeth added a comment. The same thing with the scrollbar area constantly reserved can be reproduced on Windows in a standalone Qt app using QListView, so it is definitely a Qt issue. It could be fixed by creating a new widget for this, but I'm not up for that task. F5816535: Képkivá

D12385: Thumbnail smooth scaling in filepicker

anemeth added a comment. I hit the resizing performance issue without this patch too, so it's unrelated to this. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg Cc: cfeck, broulik, ngraham, #frameworks, michaelh, bruns

D12306: Filepicker dialog proper grid icon layout

anemeth updated this revision to Diff 32680. anemeth added a comment. Revert centered icons when there is only one column, fix comment REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12306?vs=32614&id=32680 BRANCH grid_layout (branched from master) REVISION

D12389: Filepicker reads thumbs preview from Dolphin settings

anemeth edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12389 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12389: Filepicker reads thumbs preview from Dolphin settings

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Frameworks, VDG. anemeth added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12389 To: anemeth, #frameworks, #vdg Cc: ngraham, #fram

D12389: Filepicker reads thumbs preview from Dolphin settings

anemeth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. anemeth requested review of this revision. REPOSITORY R241 KIO BRANCH dolphin_thumbs (branched from master) REVISION DETAIL https://phabricator.kde.org/

D12385: Thumbnail smooth scaling in filepicker

anemeth added a comment. BTW I don't know what caused the performance issue when moving the slider before, maybe something heavy was running in the background, but I can't reproduce the problem anymore. F5815440: 2018-04-20 21-45-19.webm REPOSITORY

D12385: Thumbnail smooth scaling in filepicker

anemeth updated this revision to Diff 32675. anemeth added a comment. Remove debug REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12385?vs=32674&id=32675 BRANCH image_smooth_downscale (branched from master) REVISION DETAIL https://phabricator.kde.org/D123

D12385: Thumbnail smooth scaling in filepicker

anemeth updated this revision to Diff 32674. anemeth added a comment. Revert resize change. Turns out the image we got here is already downsized to around 128x128 and we further downsize it (if needed), dependent on the icon size. Working with this small images the smooth scaling should

D12385: Thumbnail smooth scaling in filepicker

anemeth updated this revision to Diff 32672. anemeth added a comment. Remove debug REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12385?vs=32671&id=32672 BRANCH image_smooth_downscale (branched from master) REVISION DETAIL https://phabricator.kde.org/D123

D12385: Thumbnail smooth scaling in filepicker

anemeth updated this revision to Diff 32671. anemeth added a comment. @ngraham good advice Smooth scale the fast downscaled image for good performance REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12385?vs=32657&id=32671 BRANCH image_smooth_downscale (bra

D12385: Thumbnail smooth scaling in filepicker

anemeth planned changes to this revision. anemeth added a comment. In D12385#250511 , @broulik wrote: > What's the performance penalty of that? Does the file dialog request the correct size from the preview job? It shouldn't have to end up in thi

D12385: Thumbnail smooth scaling in filepicker

anemeth added a subscriber: ngraham. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg Cc: ngraham, #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

anemeth edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg Cc: #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

anemeth edited the summary of this revision. anemeth edited the test plan for this revision. anemeth added reviewers: Frameworks, VDG. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D12385 To: anemeth, #frameworks, #vdg Cc: #frameworks, michaelh, bruns

D12385: Thumbnail smooth scaling in filepicker

anemeth updated this revision to Diff 32657. anemeth added a comment. Remove accidental left in change REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12385?vs=32655&id=32657 BRANCH image_smooth_downscale (branched from master) REVISION DETAIL https://phab

D12385: Thumbnail smooth scaling in filepicker

anemeth created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. anemeth requested review of this revision. REPOSITORY R241 KIO BRANCH image_smooth_downscale (branched from master) REVISION DETAIL https://phabricator.

D12306: Filepicker dialog proper grid icon layout

anemeth updated this revision to Diff 32614. anemeth added a comment. Move scrollbar width correction to viewPortWidth. @rkflx the 3px is causing flickering on Oxygen, 4px does not. Also I can't reproduce the missing last column issue for Oxygen. The itemsInRow == 1 part is for when th

D12328: Enable preview by default in the filepicker dialog

anemeth updated this revision to Diff 32611. anemeth added a comment. - Add kconf_update files REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12328?vs=32603&id=32611 REVISION DETAIL https://phabricator.kde.org/D12328 AFFECTED FILES CMakeLists.txt kconf_

D12328: Enable preview by default in the filepicker dialog

anemeth added a comment. In D12328#249648 , @rkflx wrote: > Could not run this yet, but IIRC deleting a key does not need a separate script, you should be able to do it inline in the `upd` with `RemoveKey`. how about this then: F5813690

  1   2   >