T12173: KService: provide solution to migrate away from KServiceTypeTrader/KMimeTypeTrader for loading plugins and parts

2021-01-09 Thread Alexander Lohnau
alex added a comment. > KRunner uses KServiceTypeTrader to load plugins. This is non-trivial to port because of the DBus runners It is ported and the old methods are deprecated TASK DETAIL https://phabricator.kde.org/T12173 To: alex Cc: alex, #frameworks, nicolasfella, dfaure, mart,

Proposing reroll of KNewStuff for Frameworks 5.76

2020-11-09 Thread Alexander Lohnau
Hello,   I would like to request a reroll of KNewStuff to include c15fbc05dbc275ef1bd85f1578c078f6a873909c, which fixes a severe issue for day to day use cases. Without it entries could end being marked as uninstalled when a KCM is reopened, while they are actually installed. Also entries

D29281: Deprecate defunct functions

2020-07-14 Thread Alexander Lohnau
alex added a comment. Ufff, never thought sth. simple like deprecating a few functions could cause such an issue! @davidre Thanks a lot for fixing this! REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29281 To: alex, #plasma, broulik, davidedmundson, vkrause,

D29050: KRunner fix prepare/teardown signals

2020-05-27 Thread Alexander Lohnau
alex closed this revision. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc: davidedmundson, cfeck, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, michaelh, ZrenBot,

D29281: Deprecate defunct functions

2020-05-23 Thread Alexander Lohnau
alex closed this revision. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29281 To: alex, #plasma, broulik, davidedmundson, vkrause, meven Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29281: Deprecate defunct functions

2020-05-22 Thread Alexander Lohnau
alex marked an inline comment as done. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29281 To: alex, #plasma, broulik, davidedmundson, vkrause, meven Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29281: Deprecate defunct functions

2020-05-22 Thread Alexander Lohnau
alex updated this revision to Diff 83119. alex added a comment. Fix typo in version number REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29281?vs=83115=83119 BRANCH deprecations (branched from master) REVISION DETAIL

D29281: Deprecate defunct functions

2020-05-22 Thread Alexander Lohnau
alex added inline comments. INLINE COMMENTS > meven wrote in querymatch.cpp:338 > Did you really need to remove this code ? The question this method should answer is: Does this match have a configuration interface? And the answer is no, because the functionality does not exist anymore. And if

D29281: Deprecate defunct functions

2020-05-22 Thread Alexander Lohnau
alex added inline comments. INLINE COMMENTS > kossebau wrote in abstractrunner.h:154 > Should be "5.0", not "5,0" here in the API dox text and elsewhere, no? (dot > instead of comma) Yes. I accidentally did it this way, because in German you use a comma :D > kossebau wrote in

D29281: Deprecate defunct functions

2020-05-22 Thread Alexander Lohnau
alex marked 9 inline comments as done. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29281 To: alex, #plasma, broulik, davidedmundson, vkrause, meven Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29281: Deprecate defunct functions

2020-05-22 Thread Alexander Lohnau
alex updated this revision to Diff 83115. alex added a comment. Fix comma, KRUNNER_DEPRECATED_VERSION_BELATED macro REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29281?vs=83110=83115 BRANCH deprecations (branched from master) REVISION DETAIL

D29281: Deprecate defunct functions

2020-05-22 Thread Alexander Lohnau
alex added a reviewer: meven. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29281 To: alex, #plasma, broulik, davidedmundson, vkrause, meven Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29050: KRunner fix prepare/teardown signals

2020-05-22 Thread Alexander Lohnau
alex added a comment. Now I understand where it is called and how it works exactly. May I ship this? REPOSITORY R308 KRunner BRANCH krunner_signal_bugfix (branched from master) REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc: davidedmundson,

D29050: KRunner fix prepare/teardown signals

2020-05-22 Thread Alexander Lohnau
alex edited the summary of this revision. REPOSITORY R308 KRunner BRANCH krunner_signal_bugfix (branched from master) REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc: davidedmundson, cfeck, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D29281: Deprecate defunct functions

2020-05-22 Thread Alexander Lohnau
alex updated this revision to Diff 83110. alex added a comment. Change deprecation version from 5.70 to 5.71 REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29281?vs=81546=83110 BRANCH deprecations (branched from master) REVISION DETAIL

D29050: KRunner fix prepare/teardown signals

2020-05-22 Thread Alexander Lohnau
alex added a comment. > Repo is called milou Thanks! REPOSITORY R308 KRunner BRANCH krunner_signal_bugfix (branched from master) REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc: davidedmundson, cfeck, kde-frameworks-devel, Orage,

D29050: KRunner fix prepare/teardown signals

2020-05-22 Thread Alexander Lohnau
alex added a comment. But can you please explain, where in the QML code the actual KRunner backend is used? Maybe then I can understand it better . REPOSITORY R308 KRunner BRANCH krunner_signal_bugfix (branched from master) REVISION DETAIL https://phabricator.kde.org/D29050 To:

D29050: KRunner fix prepare/teardown signals

2020-05-22 Thread Alexander Lohnau
alex added a comment. Thanks and I get why it is hard to review. Could @broulik please help/have a look at this. A issue I have with understanding some of the KRunner stuff is that I don't know where exactly the runner "backend" is used (from the QML side of things). Thanks 

D29050: KRunner fix prepare/teardown signals

2020-05-20 Thread Alexander Lohnau
alex edited the summary of this revision. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc: cfeck, kde-frameworks-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, michaelh, ZrenBot,

D29050: KRunner fix prepare/teardown signals

2020-05-20 Thread Alexander Lohnau
alex retitled this revision from "WIP KRunner fix prepare/teardown signals" to "KRunner fix prepare/teardown signals". REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc: cfeck, kde-frameworks-devel, Orage, LeGast00n,

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-19 Thread Alexander Lohnau
alex abandoned this revision. alex added a comment. Abandoning this in favor of https://invent.kde.org/frameworks/kconfigwidgets/-/merge_requests/1 and a follow up PR. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D29201 To: alex, #plasma, ngraham, meven,

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-19 Thread Alexander Lohnau
alex added inline comments. INLINE COMMENTS > meven wrote in kpluginselector.cpp:855 > Seems like a property would make sense, after all it is about it, or a ref to > the KCModuleInfo I have created a PR on Gitlab for this REPOSITORY R295 KCMUtils REVISION DETAIL

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-16 Thread Alexander Lohnau
alex added inline comments. INLINE COMMENTS > meven wrote in kpluginselector.cpp:855 > moduleInfo is part of the ctor here, so the fileName is already available > indirectly. > A good thing would be to avoid having an option for such a niche usage > although legitimate. > moduleInfo is part

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-13 Thread Alexander Lohnau
alex added inline comments. INLINE COMMENTS > meven wrote in kpluginselector.cpp:855 > Adding a fileName field to KCModuleProxy would make more sense to me, and do > it by default. > Plus KCModuleProxy has already access to the fileName since it receives > moduleInfo. > But I am not a

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-12 Thread Alexander Lohnau
alex added a comment. Friendly Ping  REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D29201 To: alex, #plasma, ngraham, meven, broulik, mart Cc: mart, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29123: Do not mark entry as uninstalled if uninstallation script failed

2020-05-11 Thread Alexander Lohnau
This revision was automatically updated to reflect the committed changes. Closed by commit R304:a2ecdd333c49: Do not mark entry as uninstalled if uninstallation script failed (authored by alex). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D29123: Do not mark entry as uninstalled if uninstallation script failed

2020-05-11 Thread Alexander Lohnau
alex marked 4 inline comments as done. REPOSITORY R304 KNewStuff BRANCH arcpatch-D29123_1 REVISION DETAIL https://phabricator.kde.org/D29123 To: alex, #knewstuff, meven, ngraham, leinir Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29123: Do not mark entry as uninstalled if uninstallation script failed

2020-05-07 Thread Alexander Lohnau
alex updated this revision to Diff 82228. alex added a comment. Update docs I adjusted your suggestion a bit, the signalEntryChanged gets also emitted, when the user cancels the uninstallation :-). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D29455: KNS: Deprecate isRemote method and handle parse error properly

2020-05-07 Thread Alexander Lohnau
This revision was automatically updated to reflect the committed changes. Closed by commit R304:9575f2defb27: KNS: Deprecate isRemote method and handle parse error properly (authored by alex). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D29451: KNS: Do not mark entry as installed if install script failed

2020-05-07 Thread Alexander Lohnau
This revision was automatically updated to reflect the committed changes. Closed by commit R304:2838e55acd17: KNS: Do not mark entry as installed if install script failed (authored by alex). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D29451: KNS: Do not mark entry as installed if install script failed

2020-05-07 Thread Alexander Lohnau
alex updated this revision to Diff 82180. alex added a comment. Use qOverload No problem :-) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29451?vs=82177=82180 BRANCH arcpatch-D29451 REVISION DETAIL https://phabricator.kde.org/D29451

D29451: KNS: Do not mark entry as installed if install script failed

2020-05-07 Thread Alexander Lohnau
alex updated this revision to Diff 82177. alex added a comment. Fix connect Thanks, I wasn't aware of that until now :-) REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29451?vs=82100=82177 BRANCH arcpatch-D29451 REVISION DETAIL

D29123: Do not mark entry as uninstalled if uninstallation script failed

2020-05-06 Thread Alexander Lohnau
alex updated this revision to Diff 82114. alex added a comment. Ensure bic REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29123?vs=81918=82114 BRANCH arcpatch-D29123_1 REVISION DETAIL https://phabricator.kde.org/D29123 AFFECTED FILES

D29123: Do not mark entry as uninstalled if uninstallation script failed

2020-05-06 Thread Alexander Lohnau
alex added inline comments. INLINE COMMENTS > leinir wrote in installation.h:124 > Hmm... i find myself wondering what effect this has on BIC... something tells > me it might not be so great... Specifically, >

D29451: KNS: Do not mark entry as installed if install script failed

2020-05-06 Thread Alexander Lohnau
alex updated this revision to Diff 82100. alex added a comment. Make lambda inline, capture variables REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29451?vs=82004=82100 BRANCH handle_install_script_error (branched from master) REVISION DETAIL

D29455: KNS: Deprecate isRemote method and handle parse error properly

2020-05-06 Thread Alexander Lohnau
alex marked 2 inline comments as done. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29455 To: alex, #knewstuff, ngraham, leinir Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29455: KNS: Deprecate isRemote method and handle parse error properly

2020-05-06 Thread Alexander Lohnau
alex updated this revision to Diff 82098. alex marked an inline comment as done. alex added a comment. Typo and error message If the error message is on two lines they aren't very readable, but that is an issue for another day :-). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D29455: KNS: Deprecate isRemote method and handle parse error properly

2020-05-05 Thread Alexander Lohnau
alex updated this revision to Diff 82024. alex retitled this revision from "KNS: Remove isRemote method and handle parse error properly" to "KNS: Deprecate isRemote method and handle parse error properly". alex added a comment. Make isRemote deprecated REPOSITORY R304 KNewStuff CHANGES

D29447: Fix showing updates when the option is selected

2020-05-05 Thread Alexander Lohnau
alex added a comment. No problem, always happy to help  REPOSITORY R304 KNewStuff BRANCH fix-show-only-updates (branched from master) REVISION DETAIL https://phabricator.kde.org/D29447 To: leinir, #knewstuff, #plasma, bugseforuns, ngraham, #frameworks Cc: alex, kde-frameworks-devel,

D29455: KNS: Remove isRemote method and handle parse error properly

2020-05-05 Thread Alexander Lohnau
alex created this revision. alex added reviewers: KNewStuff, ngraham, leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY The isRemote check and the FIXMEs are removed, instead the result from the

D29447: Fix showing updates when the option is selected

2020-05-05 Thread Alexander Lohnau
alex added inline comments. INLINE COMMENTS > itemsmodel.cpp:71 > +bool duplicate{false}; > +for (const EntryInternal : qAsConst(m_entries)) { > +if (existingEntry == entry) { On second thought why not just use: `bool duplicate = m_entries.contains(entry);` REPOSITORY R304

D29451: KNS: Do not mark entry as installed if install script failed

2020-05-05 Thread Alexander Lohnau
alex edited the summary of this revision. alex edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29451 To: alex, #knewstuff, ngraham, leinir Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29451: KNS: Do not mark entry as installed if install script failed

2020-05-05 Thread Alexander Lohnau
alex created this revision. alex added reviewers: KNewStuff, ngraham, leinir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY If the install script failed/was aborted the entry gets marked as

D29050: WIP KRunner fix prepare/teardown signals

2020-05-05 Thread Alexander Lohnau
alex added a comment. How should I proceed with this patch? REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29447: Fix showing updates when the option is selected

2020-05-05 Thread Alexander Lohnau
alex added inline comments. INLINE COMMENTS > itemsmodel.cpp:71 > +bool duplicate{false}; > +for (const EntryInternal& existingEntry : m_entries) { > +if (existingEntry == entry) { Use qAsConst(m_entries) and space before & not after :-) REPOSITORY R304 KNewStuff REVISION

D29123: Do not mark entry as uninstalled if uninstallation script failed

2020-05-04 Thread Alexander Lohnau
alex updated this revision to Diff 81918. alex added a comment. Merge branch master REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29123?vs=81476=81918 BRANCH arcpatch-D29123_1 REVISION DETAIL https://phabricator.kde.org/D29123 AFFECTED FILES

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-04 Thread Alexander Lohnau
alex updated this revision to Diff 81873. alex added a comment. Increase @since to 5.71 REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29201?vs=81856=81873 BRANCH service_path_append (branched from master) REVISION DETAIL

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-04 Thread Alexander Lohnau
alex added a reviewer: mart. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D29201 To: alex, #plasma, ngraham, meven, broulik, mart Cc: mart, apol, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-04 Thread Alexander Lohnau
alex updated this revision to Diff 81856. alex added a comment. Linebreak REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29201?vs=81855=81856 BRANCH service_path_append (branched from master) REVISION DETAIL https://phabricator.kde.org/D29201

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-04 Thread Alexander Lohnau
alex updated this revision to Diff 81855. alex added a comment. Improve documentation Is that what you had in mind :-) ? And should I maybe add a comment to make this the default in KF6? REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-03 Thread Alexander Lohnau
alex added a comment. > Would it make sense to always pass it? Would it regress in any way? It would make sense, but it would change the existing behavior. If you use the method setConfigurationArguments then you expect your argument list to be the list of arguments you specified + an

D29123: Do not mark entry as uninstalled if uninstallation script failed

2020-05-03 Thread Alexander Lohnau
alex marked 2 inline comments as done. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29123 To: alex, #knewstuff, meven, ngraham, leinir Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-03 Thread Alexander Lohnau
alex added a dependent revision: D29384: KCM Runners: Use setAppendServiceFile method for plugin selector. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D29201 To: alex, #plasma, ngraham, meven, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-03 Thread Alexander Lohnau
alex updated this revision to Diff 81799. alex added a comment. Little typo :-) REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29201?vs=81798=81799 BRANCH service_path_append (branched from master) REVISION DETAIL https://phabricator.kde.org/D29201

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-03 Thread Alexander Lohnau
alex updated this revision to Diff 81798. alex added a comment. Rename method REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29201?vs=81239=81798 BRANCH service_path_append (branched from master) REVISION DETAIL https://phabricator.kde.org/D29201

D29201: KCMUtils: Add option to append service file to list of arguments

2020-05-03 Thread Alexander Lohnau
alex edited the summary of this revision. alex added reviewers: meven, broulik. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D29201 To: alex, #plasma, ngraham, meven, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29101: KNewStuff: Fix file path and process call

2020-05-02 Thread Alexander Lohnau
This revision was automatically updated to reflect the committed changes. Closed by commit R304:4c6b3afcd80a: KNewStuff: Fix file path and process call (authored by alex). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29101?vs=81467=81753 REVISION DETAIL

D29101: KNewStuff: Fix file path and process call

2020-05-02 Thread Alexander Lohnau
alex added a comment. Ups, that makes sense ^^ Thanks! REPOSITORY R304 KNewStuff BRANCH arcpatch-D29101 REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent, leinir, anthonyfieroni Cc: anthonyfieroni,

D29101: KNewStuff: Fix file path and process call

2020-05-02 Thread Alexander Lohnau
alex added a comment. Friendly ping regarding the question :-) REPOSITORY R304 KNewStuff BRANCH arcpatch-D29101 REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent, leinir Cc: anthonyfieroni,

D29175: DBus Runner: Add service property to request actions once

2020-05-02 Thread Alexander Lohnau
alex added inline comments. INLINE COMMENTS > meven wrote in dbusrunnertest.cpp:206 > You should have added a QSignalSpy to check prepare was called, and another > for requestAction to check it has been called only once. The concept behind this test is, that the runner is just loaded. If the

D29175: DBus Runner: Add service property to request actions once

2020-05-01 Thread Alexander Lohnau
This revision was automatically updated to reflect the committed changes. Closed by commit R308:7b6222d8a10b: DBus Runner: Add service property to request actions once (authored by alex). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29175?vs=81623=81687

D29175: DBus Runner: Add service property to request actions once

2020-05-01 Thread Alexander Lohnau
alex added a dependent revision: D29320: Baloo Runner: Use X-Plasma-Request-Actions-Once property in service. REPOSITORY R308 KRunner BRANCH request_actions_once (branched from master) REVISION DETAIL https://phabricator.kde.org/D29175 To: alex, #plasma, meven, ngraham, broulik Cc:

D29050: WIP KRunner fix prepare/teardown signals

2020-04-30 Thread Alexander Lohnau
alex added a comment. > Adding a test would be the best way to demonstrate the issue and the fix. I debugged this and the debugger said that the `matchSessionComplete` method got called somewhere from QML, but I don't know from where. I also know only basic QML and the way the QML

D29175: DBus Runner: Add service property to request actions once

2020-04-30 Thread Alexander Lohnau
alex updated this revision to Diff 81623. alex added a comment. Create test REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29175?vs=81165=81623 BRANCH request_actions_once (branched from master) REVISION DETAIL https://phabricator.kde.org/D29175

D29050: WIP KRunner fix prepare/teardown signals

2020-04-30 Thread Alexander Lohnau
alex edited the test plan for this revision. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29281: Deprecate defunct functions

2020-04-29 Thread Alexander Lohnau
alex updated this revision to Diff 81546. alex added a comment. Wrap macro about single method, change deprecation text And thanks for the feedback and explanations :-). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29281?vs=81543=81546 BRANCH

D29281: Deprecate defunct functions

2020-04-29 Thread Alexander Lohnau
alex updated this revision to Diff 81543. alex added a comment. Wrap implementations REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29281?vs=81539=81543 BRANCH deprecations (branched from master) REVISION DETAIL https://phabricator.kde.org/D29281

D29281: Deprecate defunct functions

2020-04-29 Thread Alexander Lohnau
alex added inline comments. INLINE COMMENTS > kossebau wrote in abstractrunner.h:154 > The text in the API dox can stay "Since 5.0". > > The only crititical thing where the number of an older, already released > version should not be used is the KRUNNER_ENABLE_DEPRECATED_SINCE macro. >

D29281: Deprecate defunct functions

2020-04-29 Thread Alexander Lohnau
alex updated this revision to Diff 81539. alex added a comment. Use mordern macros Thanks :-) REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29281?vs=81528=81539 BRANCH deprecations (branched from master) REVISION DETAIL

D29281: Deprecate defunct functions

2020-04-29 Thread Alexander Lohnau
alex updated this revision to Diff 81528. alex added a comment. Add missing KRUNNER_DEPRECATED REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29281?vs=81527=81528 BRANCH deprecations (branched from master) REVISION DETAIL

D29281: Deprecate defunct functions

2020-04-29 Thread Alexander Lohnau
alex created this revision. alex added reviewers: Plasma, broulik, davidedmundson, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY As in T12163 explained

D29123: Do not mark entry as uninstalled if uninstallation script failed

2020-04-28 Thread Alexander Lohnau
alex updated this revision to Diff 81476. alex added a comment. Display more technical information in error message REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29123?vs=81076=81476 BRANCH arcpatch-D29123 REVISION DETAIL

D29101: KNewStuff: Fix file path and process call

2020-04-28 Thread Alexander Lohnau
alex updated this revision to Diff 81467. alex added a comment. Get program in exclusive line And should this go to release/20.04? REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29101?vs=81062=81467 BRANCH arcpatch-D29101 REVISION DETAIL

D29201: KCMUtils: Add option to append service file to list of arguments

2020-04-26 Thread Alexander Lohnau
alex created this revision. alex added reviewers: Plasma, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY By setting the new variable to true the service path gets appended to the list of

D29175: DBus Runner: Add service property to request actions once

2020-04-26 Thread Alexander Lohnau
alex added a comment. No, they are independent. I just mentioned this to avoid confusion when debugging. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29175 To: alex, #plasma, meven, ngraham, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

D29050: WIP KRunner fix prepare/teardown signals

2020-04-25 Thread Alexander Lohnau
alex retitled this revision from "WIP KRunner: Fix Bug 420311" to "WIP KRunner fix prepare/teardown signals". REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29175: DBus Runner: Add service property to request actions once

2020-04-25 Thread Alexander Lohnau
alex created this revision. alex added reviewers: Plasma, meven, ngraham, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY With the `X-Plasma-Request-Actions-Once` property the plugin can

D29123: Do not mark entry as uninstalled if uninstallation script failed

2020-04-24 Thread Alexander Lohnau
alex added inline comments. INLINE COMMENTS > leinir wrote in installation.cpp:632 > This will want to be more... question like... "The thing failed" isn't really > a question, not sure how the user's supposed to make an informed choice based > on that... Perhaps something like "The

D29101: KNewStuff: Fix file path and process call

2020-04-24 Thread Alexander Lohnau
alex added a dependent revision: D29123: Do not mark entry as uninstalled if uninstallation script failed. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent Cc: kde-frameworks-devel,

D29123: Do not mark entry as uninstalled if uninstallation script failed

2020-04-24 Thread Alexander Lohnau
alex edited the summary of this revision. alex added a dependency: D29101: KNewStuff: Fix file path and process call. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29123 To: alex, #knewstuff, meven, ngraham, leinir Cc: leinir, kde-frameworks-devel, LeGast00n,

D29123: Do not mark entry as uninstalled if uninstallation script failed

2020-04-24 Thread Alexander Lohnau
alex updated this revision to Diff 81076. alex retitled this revision from "WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed" to "Do not mark entry as uninstalled if uninstallation script failed". alex edited the summary of this revision. alex added a comment.

D29123: WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed

2020-04-24 Thread Alexander Lohnau
alex updated this revision to Diff 81075. alex added a comment. Merge branch 'bugfix_uninstall' REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29123?vs=80976=81075 BRANCH bugfix_install_uninstall_messages (branched from master) REVISION DETAIL

D29101: KNewStuff: Fix file path and process call

2020-04-24 Thread Alexander Lohnau
alex retitled this revision from "WIP Fix file path and process call" to "KNewStuff: Fix file path and process call". REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent Cc:

D29101: WIP BUG: 420312 Fix file path and process call

2020-04-24 Thread Alexander Lohnau
alex edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29101 To: alex, #knewstuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29101: WIP BUG: 420312 Fix file path and process call

2020-04-24 Thread Alexander Lohnau
alex updated this revision to Diff 81062. alex added a comment. Use KShell to split args REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29101?vs=80907=81062 BRANCH bugfix_uninstall (branched from master) REVISION DETAIL

D28582: KRunner: Show error message for Actions in dbus runner

2020-04-23 Thread Alexander Lohnau
alex added a comment. I am also going to try a friendly ping here :-). REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D28582 To: alex, #plasma, davidedmundson, broulik, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29123: WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed

2020-04-23 Thread Alexander Lohnau
alex marked 3 inline comments as done. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29123 To: alex, #knewstuff, meven, ngraham, leinir Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29123: WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed

2020-04-23 Thread Alexander Lohnau
alex updated this revision to Diff 80976. alex added a comment. Use internal question system PS: I am not sure on which branch this should land, thats why I haven't edited the translations. REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE

D29123: WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed

2020-04-23 Thread Alexander Lohnau
alex added a comment. No problem :-). And good to know that the concept of this patch makes sense ^^. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D29123 To: alex, #knewstuff, meven, ngraham, leinir Cc: leinir, kde-frameworks-devel, LeGast00n, cblack, michaelh,

D29123: WIP BUG: 420312. Do not mark entry as uninstalled if uninstallation script failed

2020-04-23 Thread Alexander Lohnau
alex created this revision. alex added reviewers: KNewStuff, meven, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY As described in the bug report the uninstallation failed, but the service

D29101: WIP BUG: 420312 Fix file path and process call

2020-04-22 Thread Alexander Lohnau
alex created this revision. alex added reviewers: KNewStuff, ngraham, nicolasfella, elvisangelaccio, meven, mlaurent. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY The bug was caused by two issues:

D28574: KRunner: Improve code snippet

2020-04-22 Thread Alexander Lohnau
This revision was automatically updated to reflect the committed changes. Closed by commit R308:b503fc4578b8: KRunner: Improve code snippet (authored by alex). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28574?vs=79342=80842 REVISION DETAIL

D29050: WIP KRunner: Fix Bug 420311

2020-04-21 Thread Alexander Lohnau
alex edited the summary of this revision. REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29050: WIP KRunner: Fix Bug 420311

2020-04-21 Thread Alexander Lohnau
alex created this revision. alex added reviewers: meven, ngraham, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY BUG: 420311. Because the teardown was rquested and checked the prepped

D27597: KRunner: Refactor deprecated toSet() method

2020-04-19 Thread Alexander Lohnau
alex abandoned this revision. alex added a comment. This gets already handled/discussed in D28135 REPOSITORY R308 KRunner REVISION DETAIL https://phabricator.kde.org/D27597 To: alex, mlaurent, apol, #plasma Cc: ahmadsamir, kde-frameworks-devel,

D28582: KRunner: Show error message for Actions in dbus runner

2020-04-05 Thread Alexander Lohnau
alex updated this revision to Diff 79377. alex added a comment. Update comment REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28582?vs=79376=79377 BRANCH dbusrunner_cleanup (branched from master) REVISION DETAIL https://phabricator.kde.org/D28582

D28582: KRunner: Show error message for Actions in dbus runner

2020-04-05 Thread Alexander Lohnau
alex updated this revision to Diff 79376. alex added a comment. Update if condition REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28582?vs=79375=79376 BRANCH dbusrunner_cleanup (branched from master) REVISION DETAIL

D28582: KRunner: Show error message for Actions in dbus runner

2020-04-05 Thread Alexander Lohnau
alex created this revision. alex added reviewers: Plasma, davidedmundson, broulik, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY KRunner now shows error messages for the Actions dbus

D28574: KRunner: Improve code snippet

2020-04-04 Thread Alexander Lohnau
alex created this revision. alex added reviewers: Plasma, davidedmundson, broulik, ngraham. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. alex requested review of this revision. REVISION SUMMARY The code snippet now uses the Qt5 syntax for the signals and

D27591: KAbstractFileItemActionPlugin: Add missing quotes in code example

2020-03-22 Thread Alexander Lohnau
This revision was automatically updated to reflect the committed changes. Closed by commit R241:86832ca00e7b: KAbstractFileItemActionPlugin: Add missing quotes in code example (authored by alex). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27591?vs=76203=78255

  1   2   >