D15645: Add scheme selection menu with a "System" entry.

amhndu abandoned this revision. amhndu added a comment. Superseded by D25877 REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D15645 To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio, ngraham, pino Cc: pino, ngraham,

D15645: Add scheme selection menu with a "System" entry.

amhndu added a comment. Sorry about the delay, got caught up in things. So here's the situation: Currently, the menu's actions store the scheme path as the data and applications that currently use this menu (eg. KDevelop and Kate), just store this scheme path in their config. So if we

D15645: Add scheme selection menu with a "System" entry.

amhndu added a comment. Thanks for picking this up again! I'm definitely interested to resume but I've been a little busy this week. I can take a look again this weekend. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D15645 To: amhndu, #frameworks,

D15645: Add scheme selection menu with a "System" entry.

amhndu marked an inline comment as done. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D15645 To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio, ngraham, pino Cc: pino, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15645: Add scheme selection menu with a "System" entry.

amhndu updated this revision to Diff 44342. amhndu added a comment. > kcolorschemedemo.cpp does not actually seem to build an executable. It should build `kcolorschemedemo` in `kconfigwidgets/bin` (also has `kcolorschemedemo` target in make) > Regardless, wouldn't it make sense to

D15645: Add scheme selection menu with a "System" entry.

amhndu marked an inline comment as done. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D15645 To: amhndu, #frameworks, broulik, cfeck, elvisangelaccio, ngraham Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15645: Add scheme selection menu with a "System" entry.

amhndu updated this revision to Diff 44279. amhndu edited the summary of this revision. amhndu added a comment. Fixed error in colorschemedemo test. Sorry about that, I must've forgotton to commit it. REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D15645: Add scheme selection menu with a "System" entry.

amhndu added a comment. Ping. Can someone please review ? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D15645 To: amhndu, #frameworks Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15645: Add scheme selection menu with a "System" entry.

amhndu retitled this revision from "[WIP] Add scheme selection menu with a "System" entry." to "Add scheme selection menu with a "System" entry.". amhndu edited the summary of this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D15645 To: amhndu,

D15645: [WIP] Add scheme selection menu with a "System" entry.

amhndu updated this revision to Diff 42166. amhndu marked 4 inline comments as done. amhndu added a comment. Updated with styling suggestions. REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15645?vs=42108=42166 BRANCH system-default REVISION

D15645: [WIP] Add scheme selection menu with a "System" entry.

amhndu marked 2 inline comments as done. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D15645 To: amhndu, #frameworks Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D15645: [WIP] Add scheme selection menu with a "System" entry.

amhndu updated this revision to Diff 42108. amhndu added a comment. Move duplicate code from the two createSelectionMenu methods into one generic createSelectionMenu in KColorSchemeMangerPrivate REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE

D15645: [WIP] Add scheme selection menu with a "System" entry.

amhndu added a comment. Should I also add the other overloads like `createSchemeSelectionMenu` does ? INLINE COMMENTS > broulik wrote in kcolorschememanager.cpp:214-228 > All of this is duplicated from`createSchemeSelectionMenu`, it should be split > into a separate method so it can be

D15645: [WIP] Add scheme selection menu with a "System" entry.

amhndu added a reviewer: Frameworks. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D15645 To: amhndu, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15645: [WIP] Add scheme selection menu with a "System" entry.

amhndu created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. amhndu requested review of this revision. REVISION SUMMARY The scheme selection menu does not offer any hint for the current system scheme. This also makes it hard to "reset"