D25170: make the libssh finder ensure the new ssh target is set

2019-11-07 Thread Andreas Schneider
asn added a comment. Thanks Harald, this is an awesome idea! https://www.libssh.org/2019/11/07/libssh-0-9-2/ REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25170 To: sitter Cc: asn, heikobecker, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice,

D25159: Fix linking to libssh 0.9.1

2019-11-06 Thread Andreas Schneider
asn added a comment. I've created https://gitlab.com/libssh/libssh-mirror/merge_requests/71 This means the right code would be then. if (TARGET ssh) # libssh 0.9+ target_link_libraries(kio_sftp ssh) endif() REPOSITORY R320 KIO Extras REVISION DETAIL

D25159: Fix linking to libssh 0.9.1

2019-11-05 Thread Andreas Schneider
asn added a comment. The plan is to have ssh as the target name and nothing else and support BUILD_SHARED_LIBS. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25159 To: arojas, apol, sitter Cc: sitter, asn, apol, asturmlechner, kde-frameworks-devel, kfm-devel,

D25159: Fix linking to libssh 0.9.1

2019-11-05 Thread Andreas Schneider
asn added a comment. We moved from a manually generated libssh-config.cmake to install(EXPORTS libssh-config) and it does things completely different. I'm currently trying to fix it. However better don't apply this as ssh_shared will vanish as a target. I wonder how I can define

D16538: [sftp] Add additional sftpProtocol::openConnection() for libssh 0.8.3+

2018-11-10 Thread Andreas Schneider
This revision was automatically updated to reflect the committed changes. Closed by commit R320:5043f66d17e1: [sftp] Add additional sftpProtocol::openConnection() for libssh 0.8.3+ (authored by asn). Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel,

D16387: [sftp] put request chunk debugging into own category

2018-10-23 Thread Andreas Schneider
asn added a comment. LGTM REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D16387 To: sitter, asn, broulik, ngraham Cc: kde-frameworks-devel, kfm-devel, sourabhboss, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15675: [sftp] Reformat sftpProtocol::GetRequest::GetRequest()

2018-09-24 Thread Andreas Schneider
asn updated this revision to Diff 42243. asn added a comment. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. Remove former revision REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D15646: [sftp] Remove unused variable type

2018-09-21 Thread Andreas Schneider
asn abandoned this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15646 To: asn, sitter, ngraham Cc: kde-frameworks-devel, kfm-devel, feverfew, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp

D15646: [sftp] Remove unused variable type

2018-09-21 Thread Andreas Schneider
asn added a comment. Could you please talk to me the next time before you're going to push patches from a branch I'm working on? Communication helps to avoid double work. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D15646 To: asn, sitter, ngraham Cc:

D15646: [sftp] Remove unused variable type

2018-09-21 Thread Andreas Schneider
asn created this revision. asn added reviewers: sitter, ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. asn requested review of this revision. REVISION SUMMARY Signed-off-by: Andreas Schneider REPOSITORY R320 KIO Extras

Re: Review Request 123081: sftp ioslave: Check for stat...@openssh.com extension in sftpProtocol::fileSystemFreeSpace

2015-03-20 Thread Andreas Schneider
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123081/#review77829 --- Ship it! Ship It! - Andreas Schneider On March 20, 2015