D18878: Force NT1 protocol when listing smb:// network

2019-02-09 Thread Andrew Crouthamel
acrouthamel added a comment. How do dependencies work here? Does this force SMB1 to be installed and enabled in Dolphin now? I ask because many companies have disabled and removed version 1 due to the security issues. REPOSITORY R320 KIO Extras REVISION DETAIL

D18768: Extend Open Document thumbnailer to Office Open XML

2019-02-05 Thread Andrew Crouthamel
acrouthamel added a comment. Thanks for expanding the thumbnailer lately, awesome work with this and the eBook one. :) REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18768 To: broulik, #plasma, #vdg, #frameworks Cc: acrouthamel, kde-frameworks-devel, kfm-devel,

D18563: Don't create directory tree when a new folder has a '/' in the name

2019-01-29 Thread Andrew Crouthamel
acrouthamel added a comment. -1 from me. I would prefer we stick to Unix methodologies. KDE software is also known to be the more feature-rich and customizable options out there, and as mentioned commonly linked to power users. We would be wise to not introduce a feature

D16299: fallback to dnssd service discovery if smb listDir failed on root

2018-11-21 Thread Andrew Crouthamel
acrouthamel added a comment. In D16299#363498 , @sitter wrote: > If someone has a thought to offer on this please do. > Personally I am somewhat leaning towards assuming that systems should be properly configured. The problem with setting the

D16852: Add Documents to the default list of Places

2018-11-19 Thread Andrew Crouthamel
acrouthamel added a comment. In D16852#362344 , @ngraham wrote: > you could tackle the patch to make Dolphin's default window size a tad taller. I'll poke around. REPOSITORY R241 KIO BRANCH add-documents (branched from master)

D16852: Add Documents to the default list of Places

2018-11-19 Thread Andrew Crouthamel
acrouthamel added a comment. I had submitted this with the intention of being a follow-up to D15739 , as that would clear a slot for this. I think right now, T9795 is outside my skill set. I'd be glad to make D15739

D16852: Add Documents to the default list of Places

2018-11-17 Thread Andrew Crouthamel
acrouthamel added a comment. In D16852#360940 , @elvisangelaccio wrote: > @acrouthamel Please open another diff with your patch thats updates the dolphin test, so I can try easily try it out Ok, I created D16967

D16852: Add Documents to the default list of Places

2018-11-17 Thread Andrew Crouthamel
acrouthamel added a dependent revision: D16967: Add Documents shortcut detection. REPOSITORY R241 KIO BRANCH add-documents (branched from master) REVISION DETAIL https://phabricator.kde.org/D16852 To: acrouthamel, #frameworks, #dolphin, ngraham Cc: davidc, elvisangelaccio,

D16852: Add Documents to the default list of Places

2018-11-15 Thread Andrew Crouthamel
acrouthamel added a comment. I checked out the test log and see the following, yet I honestly can't figure out why it is off by one, since any line referencing hasDocumentsFolder is a ++ line for the count. Do I need to run this test on a new user account or something? FAIL! :

D15739: [Places panel] Don't show Root by default

2018-11-08 Thread Andrew Crouthamel
acrouthamel added a comment. In D15739#331468 , @broulik wrote: > +1 it's an entry I always hide when I setup someone's computer > > > you can still get to / on your machine in one click using the appropriate disk entry on the bottom of the

D16633: Add root version of drive-harddisk

2018-11-04 Thread Andrew Crouthamel
acrouthamel added a comment. > I did not add drive-harddisk-home in this commit because it was simply too difficult to make an easily readable symbol for home on the 16px version. What about ~ or $ ? Tilde would probably be the best, and you could exaggerate

D15931: [Places panel] use more appropriate network icon

2018-10-03 Thread Andrew Crouthamel
acrouthamel added a comment. +1 from me, makes sense. I say that as a guy who stares at server racks all day. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D15931 To: ngraham, #vdg Cc: acrouthamel, kde-frameworks-devel, michaelh, ngraham, bruns

D15866: Reduce emblem size for very small icons to prevent obscuring too much of the icon

2018-10-01 Thread Andrew Crouthamel
acrouthamel added a comment. What are the different possible emblems that can be applied automatically by the mount process? What if for small sizes, we just use simple shapes and colors. Like a green circle for mounted, and a yellow triangle for something else, and a red square for

D15739: [Places panel] Don't show Root by default

2018-09-24 Thread Andrew Crouthamel
acrouthamel added a comment. +1 Seeing "Root" written as such, also makes me think of `/root`, which makes no sense to have there. The odds of needing quick access to `/` via Dolphin are extremely rare, and there is already a link anyway. People are used to clicking the primary drive

D15644: Bug 395349

2018-09-21 Thread Andrew Crouthamel
acrouthamel added a comment. Yeah I think that is a mistake. D42047 which precedes the current diff, makes much more sense. REVISION DETAIL https://phabricator.kde.org/D15644 To: lsartorelli, ngraham, #plasma, #frameworks Cc: acrouthamel, ngraham, plasma-devel, ragreen, Pitel, ZrenBot,

D15406: Manually resize KCMUtilDialog to sizeHint()

2018-09-11 Thread Andrew Crouthamel
acrouthamel added a comment. I've tested this patch on my system. Although it does not resolve the scaling issue I experience, it does not cause any regressions I see. Ship it! :) REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL https://phabricator.kde.org/D15406 To:

D15406: Manually resize KCMUtilDialog to sizeHint()

2018-09-11 Thread Andrew Crouthamel
acrouthamel added a comment. In D15406#324063 , @ngraham wrote: > @acrouthamel, could you test this patch to make sure it doesn't regress anything for High DPI users? I can test it out tonight. REPOSITORY R295 KCMUtils BRANCH

D15340: Add Solarized Light and Dark themes

2018-09-10 Thread Andrew Crouthamel
acrouthamel added a comment. I just realized the output was HTML. Ok, I can see what is going on now. If you could let me know if I am missing the "code-editor" though, that would be great! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15340 To:

D15340: Add Solarized Light and Dark themes

2018-09-10 Thread Andrew Crouthamel
acrouthamel added a comment. In D15340#322631 , @dhaumann wrote: > Sure, please use kdesrc-build as described here: > https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source > > Once setup, you can build everything by invoking

D15340: Add Solarized Light and Dark themes

2018-09-08 Thread Andrew Crouthamel
acrouthamel added a comment. In D15340#322453 , @dhaumann wrote: > Btw, we forgot to add the themes to the Qt resource file, see also D15358 > > You can test the theme with the demo app in

D15340: Add Solarized Light and Dark themes

2018-09-08 Thread Andrew Crouthamel
acrouthamel added a comment. Thanks, I'll make sure to add to that file if I add more themes. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15340 To: acrouthamel, #kate, #framework_syntax_highlighting, dhaumann Cc: dhaumann, kwrite-devel,

D15340: Add Solarized Light and Dark themes

2018-09-08 Thread Andrew Crouthamel
acrouthamel added a comment. In D15340#322112 , @dhaumann wrote: > Looks good to me. > > Related: in order to have better unit testing, would you be willing to add a unit test to

D15340: Add Solarized Light and Dark themes

2018-09-08 Thread Andrew Crouthamel
This revision was automatically updated to reflect the committed changes. Closed by commit R216:6d26c25fcfda: Add Solarized Light and Dark themes (authored by acrouthamel). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15340?vs=41179=41216

D15337: Fix Solarized Light and Dark color schemes

2018-09-07 Thread Andrew Crouthamel
acrouthamel closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15337 To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting, dhaumann Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking,

D15337: Fix Solarized Light and Dark color schemes

2018-09-07 Thread Andrew Crouthamel
acrouthamel added a comment. Thanks, I can. I'm getting an error in Arcanist, so let me diagnose that and I'll land it. REPOSITORY R39 KTextEditor BRANCH fix-solarized-colors REVISION DETAIL https://phabricator.kde.org/D15337 To: acrouthamel, #kate, #ktexteditor,

D15337: Fix Solarized Light and Dark color schemes

2018-09-07 Thread Andrew Crouthamel
acrouthamel added a comment. In D15337#322043 , @dhaumann wrote: > Solarized dark still only has 28 colors, right? Can you add the missing ones? Man, I'm looking forward to this JSON system in the future. LOL. Ok, fixed again. I counted

D15337: Fix Solarized Light and Dark color schemes

2018-09-07 Thread Andrew Crouthamel
acrouthamel updated this revision to Diff 41181. acrouthamel added a comment. - Added three missing definitions REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15337?vs=41177=41181 BRANCH fix-solarized-colors REVISION DETAIL

D15337: Fix Solarized Light and Dark color schemes

2018-09-07 Thread Andrew Crouthamel
acrouthamel edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15337 To: acrouthamel, #kate, #ktexteditor, #framework_syntax_highlighting Cc: dhaumann, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,

D15337: Fix Solarized Light and Dark color schemes

2018-09-07 Thread Andrew Crouthamel
acrouthamel added a comment. @dhaumann, I've added these colors to KSyntaxHighlighting over here: D15340 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D15337 To: acrouthamel, #kate, #ktexteditor,

D15340: Add Solarized Light and Dark themes

2018-09-07 Thread Andrew Crouthamel
acrouthamel edited the summary of this revision. acrouthamel added reviewers: Kate, Framework: Syntax Highlighting. acrouthamel added a project: Framework: Syntax Highlighting. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D15340 To: acrouthamel, #kate,

D15340: Add Solarized Light and Dark themes

2018-09-07 Thread Andrew Crouthamel
acrouthamel created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. acrouthamel requested review of this revision. REVISION SUMMARY This adds Solarized Light and Dark themes, with the same color scheme selected in

D15337: Fix Solarized Light and Dark color schemes

2018-09-07 Thread Andrew Crouthamel
acrouthamel marked 2 inline comments as done. acrouthamel added a comment. You were right again. For some reason that Others= disappeared from my ~/.config/katesyntaxhighlightingrc so I didn't notice it. Even though it was defined and displaying fine in the GUI. Weird. I also made a few

D15337: Fix Solarized Light and Dark color schemes

2018-09-07 Thread Andrew Crouthamel
acrouthamel updated this revision to Diff 41177. acrouthamel added a comment. - Fixed Others definition REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15337?vs=41176=41177 BRANCH fix-solarized-colors REVISION DETAIL

D15337: Fix Solarized Light and Dark color schemes

2018-09-07 Thread Andrew Crouthamel
acrouthamel updated this revision to Diff 41176. acrouthamel added a comment. - Some Marker color tweaks to ensure Solarized interaction rule adherence REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15337?vs=41172=41176 BRANCH fix-solarized-colors

D15337: Fix Solarized Light and Dark color schemes

2018-09-07 Thread Andrew Crouthamel
acrouthamel updated this revision to Diff 41172. acrouthamel added a comment. - Fixed Light scheme Error color REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15337?vs=41171=41172 BRANCH fix-solarized-colors REVISION DETAIL

D15337: Fix Solarized Light and Dark color schemes

2018-09-07 Thread Andrew Crouthamel
acrouthamel updated this revision to Diff 41171. acrouthamel marked an inline comment as done. acrouthamel added a comment. - Solarized Light Region Marker fix and small Dark tweak. REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15337?vs=41170=41171

D15337: Fix Solarized Light and Dark color schemes

2018-09-07 Thread Andrew Crouthamel
acrouthamel marked an inline comment as done. acrouthamel added a comment. I've fixed the section. I'm actually working on the KSyntaxHighlighting themes now, you'll see those in another patch. INLINE COMMENTS > dhaumann wrote in katesyntaxhighlightingrc:104 > Am I mistaken, or did you

D15337: Fix Solarized Light and Dark color schemes

2018-09-07 Thread Andrew Crouthamel
acrouthamel updated this revision to Diff 41170. acrouthamel added a comment. - Fixed section code REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15337?vs=41168=41170 BRANCH fix-solarized-colors REVISION DETAIL https://phabricator.kde.org/D15337

D15337: Fix Solarized Light and Dark color schemes

2018-09-07 Thread Andrew Crouthamel
acrouthamel edited the summary of this revision. acrouthamel edited the test plan for this revision. acrouthamel added reviewers: Kate, KTextEditor, Framework: Syntax Highlighting. acrouthamel added a project: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL

D15337: Fix Solarized Light and Dark color schemes

2018-09-07 Thread Andrew Crouthamel
acrouthamel created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. acrouthamel requested review of this revision. REVISION SUMMARY Solarized Light contrast was low. Upon investigation it was determined much of the color

D15213: Provide icons for 2x scaling

2018-09-06 Thread Andrew Crouthamel
acrouthamel added a comment. I love all of these HIDPI fixes lately. REPOSITORY R266 Breeze Icons BRANCH 2xIcons REVISION DETAIL https://phabricator.kde.org/D15213 To: rizzitello, #vdg, #plasma, broulik, ngraham Cc: acrouthamel, ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D11768: Add Desktop and Downloads to the default list of Places

2018-08-31 Thread Andrew Crouthamel
acrouthamel added a comment. Herald added a subscriber: kde-frameworks-devel. Hey Nate, is there a reason why Documents was not added with this patch? I always end up adding it. I was reading through D10245#201638 and the discussion seemed in favor

D6313: Support Icon Scale from Icon naming specification 0.13

2018-04-03 Thread Andrew Crouthamel
acrouthamel added a comment. In D6313#239212 , @cfeck wrote: > In other words, the icon theme designer can now decide if he makes HiDPI only bigger or more detailed by symlinking to either the less detailed or the more detailed svg, without

D6313: Support Icon Scale from Icon naming specification 0.13

2018-04-03 Thread Andrew Crouthamel
acrouthamel added a comment. @ngraham, in the initial description @broulik forced a @2x folder via symlink to test. Otherwise no change will be observed. :) REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #vdg

D6313: Support Icon Scale from Icon naming specification 0.13

2018-04-02 Thread Andrew Crouthamel
acrouthamel added a comment. In D6313#238697 , @rkflx wrote: > In D6313#238605 , @acrouthamel wrote: > > > @2x-compatible > > > How will this work for 4x / 2.7x / 1.4x / etc. scaling? Of course

D6313: Support Icon Scale from Icon naming specification 0.13

2018-04-02 Thread Andrew Crouthamel
acrouthamel added a comment. I think both of us missed this part at the bottom of @broulik's description: > This way you designers can now create dedicated 2x SVGs for those usecases, ie. we can have a 16px icon as well as a 16px@2x icon rather than it just taking the 32px icon which

D6313: Support Icon Scale from Icon naming specification 0.13

2018-04-02 Thread Andrew Crouthamel
acrouthamel added a comment. I'm just saying if you prefer colored over symbolic line art, that is something for #Breeze or #vdg to work out. Not that they are really taking advantage of anything. The bug

D11838: Turn on line numbers by default

2018-04-02 Thread Andrew Crouthamel
acrouthamel added a comment. I wouldn't mind seeing it on in KDevelop. From using it though, I really don't need them much in it. Especially since when debugging I can just click on an error and it will take me to the line. Kate would be nice to have it on. KWrite, probably not, since

D6313: Support Icon Scale from Icon naming specification 0.13

2018-04-02 Thread Andrew Crouthamel
acrouthamel added a comment. @ngraham and @hein, while I agree that in some instances I like the colored hi-res icons showing, this issue causes a mixture of icons to be displayed depending on the app. The examples here show a nice homogeneous selection of icons that change from A to B, so

D11390: new icons for disconnected/disabled devices

2018-03-16 Thread Andrew Crouthamel
acrouthamel added a comment. They look great! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11390 To: mart, #plasma, #vdg, andreask Cc: acrouthamel, andreask, #frameworks, michaelh, ngraham

D6313: Support Icon Scale from Icon naming specification 0.13

2018-03-16 Thread Andrew Crouthamel
acrouthamel added a comment. Thanks for working on this again, it really helps. :) REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D6313 To: broulik, kde-frameworks-devel, #plasma, #vdg Cc: rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck,

D6313: WIP: Support device pixel ratio in icon loader and engine

2018-03-13 Thread Andrew Crouthamel
acrouthamel added a comment. Hey there, any movement on this? I've been submitting some patches to fix icon scaling in apps and have noticed how they switch from monochrome to colored (hires) versions when fixed. Getting the underlying issue fixed would be great as more people buy