marked as submitted.
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Changes
---
Submitted with commit d4d4796620eb850ee6d305d9bd3478e6b7cb216d by Albert Astals
Cid on behalf of Andrey Cygankov to branch master.
Repository: kxmlgui
Description
---
Fix all Clazy warnings
/normalvimode.cpp c0eaf40
src/vimode/modes/visualvimode.cpp c58277b
src/vimode/searcher.cpp 133ff9b
Diff: https://git.reviewboard.kde.org/r/126765/diff/
Testing
---
Built without errors.
All tests passed.
Thanks,
Andrey Cygankov
___
Kde
marked as submitted.
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Changes
---
Submitted with commit 706bf6f39319f6c2b79ad82c689d7506747b98c7 by Aleix Pol on
behalf of Andrey Cygankov to branch master.
Repository: kded
Description
---
Fix all Clazy warnings in KDED
marked as submitted.
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Changes
---
Submitted with commit 1939360c50cba1241b01108fc32e73ef88c1d83d by Aleix Pol on
behalf of Andrey Cygankov to branch master.
Repository: kservice
Description
---
Fix some Clazy warnings
.
Thanks,
Andrey Cygankov
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
: kded
Description
---
Fix all Clazy warnings in KDED.
Diffs
-
src/kded.cpp 0eb6380
Diff: https://git.reviewboard.kde.org/r/126769/diff/
Testing
---
Built without errors.
No tests available.
Thanks,
Andrey Cygankov
___
Kde
ktoolbar.cpp 8fcb9cb
src/kxmlguifactory_p.cpp 5e1a0d6
tests/kwindowtest.cpp 0555a56
Diff: https://git.reviewboard.kde.org/r/126770/diff/
Testing
---
Build without errors.
Tests passed.
Thanks,
Andrey Cygankov
___
Kde-frameworks-devel mailing
patch: Failed kmimeassociationstest
With patch: Failed kmimeassociationstest
Thanks,
Andrey Cygankov
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
:
> > `/home/kde-devel/frameworks/kitemviews/src/kwidgetitemdelegatepool.cpp:48:1:
> > warning: KWidgetItemDelegateEventListener is missing a Q_OBJECT macro
> > [-Wclazy-missing-qobject]`
>
> Andrey Cygankov wrote:
> Strangely, I had not noticed the warning in the log .
/selectionpmwidget.cpp f5b353a
Diff: https://git.reviewboard.kde.org/r/126735/diff/
Testing
---
Build without errors.
Tests passed.
Thanks,
Andrey Cygankov
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
ing
---
Build without errors.
Tests passed.
Thanks,
Andrey Cygankov
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
. I get to the PC - see the
log again.
- Andrey
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126737/#review91067
-------
:
> > `/home/kde-devel/frameworks/kitemviews/src/kwidgetitemdelegatepool.cpp:48:1:
> > warning: KWidgetItemDelegateEventListener is missing a Q_OBJECT macro
> > [-Wclazy-missing-qobject]`
>
> Andrey Cygankov wrote:
> Strangely, I had not noticed the warning in the
:
> > `/home/kde-devel/frameworks/kitemviews/src/kwidgetitemdelegatepool.cpp:48:1:
> > warning: KWidgetItemDelegateEventListener is missing a Q_OBJECT macro
> > [-Wclazy-missing-qobject]`
>
> Andrey Cygankov wrote:
> Strangely, I had not noticed the warning in the log .
marked as submitted.
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Changes
---
Submitted with commit 7f896240d3be09e33d76a8ae8be953c498c662e7 by Aleix Pol on
behalf of Andrey Cygankov to branch master.
Repository: kpeople
Description
---
Fix some Clazy warnings
n automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126737/#review91076
-------
On Янв. 14, 2016, 10:40 п.п., Andrey Cygankov wrote:
>
> ---
> This is
marked as submitted.
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Changes
---
Submitted with commit 27427ffebdd82141dc071423b6ef37c8a69119b0 by Aleix Pol on
behalf of Andrey Cygankov to branch master.
Repository: kfilemetadata
Description
---
Fixed all Clazy warnings
marked as submitted.
Review request for KDE Frameworks, Aleix Pol Gonzalez and Sergio Martins.
Changes
---
Submitted with commit 69b721e73b421c1950ca32f1e774471060f2d4fe by Aleix Pol on
behalf of Andrey Cygankov to branch master.
Repository: kitemviews
Description
---
Fix Clazy
iff: https://git.reviewboard.kde.org/r/126737/diff/
Testing
---
Build without errors.
Tests passed.
Thanks,
Andrey Cygankov
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
> On Янв. 14, 2016, 12:07 д.п., Aleix Pol Gonzalez wrote:
> > These look good. You wrote "most". Which warnings couldn't you fix?
>
> Andrey Cygankov wrote:
> log file sent
>
> Aleix Pol Gonzalez wrote:
>
> `/home/andrey/dev/projects/k
marked as submitted.
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Changes
---
Submitted with commit 1e487951342a79eff5c680d29c7e9ed852a47dc4 by Aleix Pol on
behalf of Andrey Cygankov to branch master.
Repository: kitemmodels
Description
---
Fixed most Clazy warnings
:
> > `/home/kde-devel/frameworks/kitemviews/src/kwidgetitemdelegatepool.cpp:48:1:
> > warning: KWidgetItemDelegateEventListener is missing a Q_OBJECT macro
> > [-Wclazy-missing-qobject]`
>
> Andrey Cygankov wrote:
> Strangely, I had not noticed the warning in the log .
/selectionpmwidget.cpp f5b353a
Diff: https://git.reviewboard.kde.org/r/126735/diff/
Testing
---
Build without errors.
Tests passed.
Thanks,
Andrey Cygankov
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo
:
> > `/home/kde-devel/frameworks/kitemviews/src/kwidgetitemdelegatepool.cpp:48:1:
> > warning: KWidgetItemDelegateEventListener is missing a Q_OBJECT macro
> > [-Wclazy-missing-qobject]`
>
> Andrey Cygankov wrote:
> Strangely, I had not noticed the warning in the log .
/knotificationrestrictions.cpp c979a78
src/notifybypopup.cpp e3090ba
src/notifybypopupgrowl.cpp 504ad90
Diff: https://git.reviewboard.kde.org/r/126734/diff/
Testing
---
Built without errors.
No tests available.
Thanks,
Andrey Cygankov
___
Kde
ritemdbus_.cpp ?
- Andrey
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126734/#review91034
---
On Янв. 13, 2016, 11:30
/kstatusnotifieritemdbus_p.cpp b6933b3
src/notifybypopup.cpp e3090ba
src/notifybypopupgrowl.cpp 504ad90
Diff: https://git.reviewboard.kde.org/r/126734/diff/
Testing
---
Built without errors.
No tests available.
Thanks,
Andrey Cygankov
___
Kde-frameworks-devel
errors.
Tests passed.
Thanks,
Andrey Cygankov
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
/knotificationrestrictions.cpp c979a78
src/kstatusnotifieritem.cpp f9bf460
src/notifybypopup.cpp e3090ba
src/notifybypopupgrowl.cpp 504ad90
Diff: https://git.reviewboard.kde.org/r/126734/diff/
Testing
---
Built without errors.
No tests available.
Thanks,
Andrey Cygankov
78c4b37
src/extractors/office2007extractor.cpp 548763d
src/extractors/officeextractor.cpp efad5d4
tests/dump.cpp 6adb3a9
Diff: https://git.reviewboard.kde.org/r/126736/diff/
Testing
---
Build without errors.
Tests passed.
Thanks,
Andrey Cygankov
/126735/diff/
Testing
---
Build without errors.
Tests passed.
Thanks,
Andrey Cygankov
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
reply, visit:
https://git.reviewboard.kde.org/r/126735/#review91040
---
On Янв. 14, 2016, 12:05 д.п., Andrey Cygankov wrote:
>
> ---
> This is an automatically generated e-ma
> On Янв. 8, 2016, 1:20 д.п., Aleix Pol Gonzalez wrote:
> > I did it myself because you're a GCI student, but besides compilation, you
> > should have checked if tests still pass and specified so in the testing
> > field.
> >
> > The change looks, good. T
src/widgets/persondetailsview.cpp 7e4e24f
Diff: https://git.reviewboard.kde.org/r/126670/diff/
Testing
---
Compiling without errors.
Thanks,
Andrey Cygankov
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org
cpp 5c3d3e1
> src/personpluginmanager.cpp f5396d9
> src/widgets/actions.cpp ffaf16f
> src/widgets/mergedelegate.cpp 01c988d
> src/widgets/persondetailsview.cpp 7e4e24f
>
> Diff: https://git.reviewboard.kde.org/r/126670/diff/
>
>
> Testing
> ---
>
&g
marked as submitted.
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Changes
---
Submitted with commit d9e679e4f60d2c21c2d256c1a343a38b2dfa9a6f by Aleix Pol on
behalf of Andrey Cygankov to branch master.
Repository: kcoreaddons
Description
---
Fix some Clazy warnings
---
Compiling without errors.
Thanks,
Andrey Cygankov
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
s an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126531/#review90163
-------
On Дек. 27, 2015, 5:50 п.п., Andrey Cygankov wrote:
>
> ---
>
without errors.
Thanks,
Andrey Cygankov
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
---
Compiling without errors.
Thanks,
Andrey Cygankov
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
marked as submitted.
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Changes
---
Submitted with commit 6e58d0592b8dc70384223ea2a598f7cf776685be by Aleix Pol on
behalf of Andrey Cygankov to branch master.
Repository: kemoticons
Description
---
Fix some Clazy warnings
26392/diff/
Testing
---
Compiling without errors
Thanks,
Andrey Cygankov
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
ed e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126392/#review90049
---
On Дек. 24, 2015, 11:58 д.п., Andrey Cygankov wrote:
>
> ---
> This is an automatically generate
marked as submitted.
Review request for KDE Frameworks and Aleix Pol Gonzalez.
Changes
---
Submitted with commit c0c8cd8bca239722d67e1d2e6d4c59ca50671d52 by Aleix Pol on
behalf of Andrey Cygankov to branch master.
Repository: kinit
Description
---
Fix some Clazy warnings in kinit
n automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126392/#review89994
---
On Дек. 18, 2015, 7:32 п.п., Andrey Cygankov wrote:
>
> ---
> This is an a
/klauncher/klauncher_main.cpp 432e19a
src/wrapper.cpp 95b7ec2
Diff: https://git.reviewboard.kde.org/r/126440/diff/
Testing
---
Compiling without errors.
Automated tests pass.
Thanks,
Andrey Cygankov
___
Kde-frameworks-devel mailing list
Kde
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126392/#review89786
---
Hey, when my patch will be reviewed?
- Andrey Cygankov
dia.org/wiki/De_Morgan's_laws
Yes , I realized the error , correct it soon.
- Andrey
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126392/#review89700
-----
src/lib/text/kmacroexpander.cpp 0d05ffd
src/lib/text/kstringhandler.cpp 826ddcb
src/lib/text/ktexttohtml.cpp d58f5c0
src/lib/util/kshell.cpp 11892ce
Diff: https://git.reviewboard.kde.org/r/126392/diff/
Testing
---
Compiling without errors
Thanks,
Andrey Cygankov
/lib/text/kstringhandler.cpp 826ddcb
src/lib/text/ktexttohtml.cpp d58f5c0
src/lib/util/kshell.cpp 11892ce
Diff: https://git.reviewboard.kde.org/r/126392/diff/
Testing
---
Compiling without errors
Thanks,
Andrey Cygankov
___
Kde
50 matches
Mail list logo
