D22708: [WIP] Add a kded module infra for fuse mount services

2019-07-25 Thread Andrius da Costa Ribas
andriusr added inline comments.

INLINE COMMENTS

> CMakeLists.txt:19
>  add_subdirectory(kcms)
> +add_subdirectory(mountserviced)
>  

should we restrict platforms here? (e.g.: NOT WIN32, NOT ANDROID). There are 
fuse wrappers such as winfsp's or dokany's, but possibly those should not work 
there.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D22708

To: chinmoyr
Cc: andriusr, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns


D22554: Finer No-Dbus on Windows

2019-07-19 Thread Andrius da Costa Ribas
andriusr added inline comments.

INLINE COMMENTS

> CMakeLists.txt:79
> +  endif()
>  endif()
>  

extra `endif()` ?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D22554

To: brute4s99, nicolasfella, broulik
Cc: andriusr, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, 
bruns


D22105: WIP : Fix SFTP Plugin of KIO for Windows

2019-06-26 Thread Andrius da Costa Ribas
andriusr added inline comments.

INLINE COMMENTS

> kio_sftp.cpp:2257
> +#ifdef Q_OS_WIN
> +// TODO ADD CODE FOR HANDLING FILETYPE - SYMLINK IN WIN
> +#else

I'm not sure what is intended to achieve here, the remote file _can_ be a 
symlink, and IIRC when we had sftp on dolphin in KDE4 those symlinks were shown 
as such.

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D22105

To: brute4s99, albertvaka, vonreth, sredman
Cc: andriusr, kde-frameworks-devel, kfm-devel, fprice, LeGast00n, fbampaloukas, 
alexde, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, 
andrebarros, bruns, emmanuelp, mikesomov


D15739: [Places panel] Don't show Root by default

2019-06-24 Thread Andrius da Costa Ribas
andriusr added a comment.


  In D15739#485978 , @fvogt wrote:
  
  > In D15739#485976 , @ngraham 
wrote:
  >
  > > In D15739#485975 , @fvogt 
wrote:
  > >
  > > > No, there's in fact no devices section at all as it would be empty. The 
live cd itself is marked as ignored as there's nothing useful on there and it 
can't be ejected and the other layers are mounted from loop devices which 
udisks apparently ignores as well.
  > >
  > >
  > > That seems like a bug in the way the devices list is populated or 
displayed. There can't be no devices, that's silly.
  >
  >
  > Well, the only mount of interest is the overlay mount of /, which is not 
backed by any (block) device but rather by two filesystems. AFAICT udisks 
doesn't care about this kind of mount, not sure what solid does.
  >
  > Showing an overlay mount as "Device" is also somewhat wrong IMO.
  
  
  On Windows, we show "subst" drives as a Device, which is a bit similar to 
that, if solid could list those "virtual" devices so they're available on the 
places panel it would be useful for easy access to those mountpoints imho.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D15739

To: meven, #dolphin, #vdg, tcanabrava, ngraham, elvisangelaccio
Cc: andriusr, fvogt, meven, elvisangelaccio, Codezela, davidc, tcanabrava, 
ndavis, romangg, bruns, davidedmundson, abetts, svenmauch, broulik, 
acrouthamel, kde-frameworks-devel, LeGast00n, michaelh, ngraham


D18563: Don't create directory tree when a new folder has a '/' in the name

2019-01-30 Thread Andrius da Costa Ribas
andriusr added a comment.


  Also, Windows does not allow filenames with either `\` or `/`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: andriusr, emateli, cfeck, acrouthamel, markg, ndavis, dfaure, 
elvisangelaccio, pino, kde-frameworks-devel, michaelh, ngraham, bruns


D18563: Don't create directory tree when a new folder has a '/' in the name

2019-01-30 Thread Andrius da Costa Ribas
andriusr added inline comments.

INLINE COMMENTS

> ngraham wrote in knewfilemenu.cpp:907
> If Windows allows slashes in the filename, shouldn't they just be a part of 
> the filename and not create a directory tree? If so, then we don't even need 
> this `#ifdef` condition at all; `KIO::mkdir(url);` will take care of the 
> behavior on each individual platform

if this is a QUrl, then `/` is the separator on every platform (e.g.: 
`file://C:/WINDOWS/System32`)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18563

To: shubham, ngraham, #frameworks, #dolphin, dfaure, elvisangelaccio, pino
Cc: andriusr, emateli, cfeck, acrouthamel, markg, ndavis, dfaure, 
elvisangelaccio, pino, kde-frameworks-devel, michaelh, ngraham, bruns


Re: A new tier1 for icontheme.rcc handling

2018-01-20 Thread Andrius da Costa Ribas
+1 for the name kiconsupport as Ben suggested.


Em 19 de jan de 2018 21:49, "Ben Cooksley"  escreveu:

On Thu, Jan 18, 2018 at 8:45 PM, Hannah von Reth  wrote:
> Hi everyone.

Hi Hannah,

>
> Only some few of you will be aware of KIconThemes ability to load binary
> icon themes automagically.
>
> https://cgit.kde.org/kiconthemes.git/tree/src/kicontheme.cpp#n48
>
> The code looks for a icontheme.rcc and sets it as default theme.
>
> On Windows and Mac we rely on that code as it is more feasible to
> install that one
> file with an single application installer. This code also ensures that
> the theme path is set,
> which on Linux is done by the qpa.
>
> The problem with the current solution is that it only allows one single
> theme and is in a tier3
> framework.
>
> I recently talked to David Faure and we agreed that it would be best to
> put those few line of code into a new
> created tier1 framework, with an explicit call instead of the magical
> loading.
>
> The explicit call would allow to specify the theme loaded and we  can
> still maintain the current behaviour by putting a call to
> that new framework into KIconThemes.
>
> Now we need a name for that tier1 framework and ideally someone who
> steps up for the once in a lifetime chance to become
> maintainer of a glorious new tier1 framework.

While I can't be the maintainer for the framework, to get the ball
rolling may I suggest the name of 'kiconsupport' for the Framework?

>
> Cheers,
>
> Hannah
>

Cheers,
Ben


Re: Review Request 127729: Explicitly define NOMINMAX to avoid conflict with the 'max' macro definition

2016-04-23 Thread Andrius da Costa Ribas


> On Abril 23, 2016, 11:40 p.m., Michael Pyne wrote:
> > This is a duplicate of RR 127598, which is about to get marked as 'change 
> > then commit' (I missed that it was updated a few days ago when my email was 
> > futzy :( ).

Thanks! I'm discarding this one, then.


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127729/#review94797
---


On Abril 23, 2016, 11:54 p.m., Andrius da Costa Ribas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127729/
> ---
> 
> (Updated Abril 23, 2016, 11:54 p.m.)
> 
> 
> Review request for KDE Frameworks and kdewin.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> Although there is currently no problem on building kcoreaddons, when building 
> okular (and possibly other apps) the compiler gets confused when it reaches 
> std::numeric_limits::max() as  is also included and it 
> defines a 'max' macro.
> 
> 
> Diffs
> -
> 
>   src/lib/util/kuser.h 3c9ff00 
> 
> Diff: https://git.reviewboard.kde.org/r/127729/diff/
> 
> 
> Testing
> ---
> 
> Okular is buildable on MSVC after this patch. No further testing done.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127729: Explicitly define NOMINMAX to avoid conflict with the 'max' macro definition

2016-04-23 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127729/
---

(Updated Abril 23, 2016, 11:54 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and kdewin.


Repository: kcoreaddons


Description
---

Although there is currently no problem on building kcoreaddons, when building 
okular (and possibly other apps) the compiler gets confused when it reaches 
std::numeric_limits::max() as  is also included and it defines 
a 'max' macro.


Diffs
-

  src/lib/util/kuser.h 3c9ff00 

Diff: https://git.reviewboard.kde.org/r/127729/diff/


Testing
---

Okular is buildable on MSVC after this patch. No further testing done.


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127714: Enable ICO and EXE thumbnails again.

2016-04-23 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127714/
---

(Updated April 23, 2016, 8:21 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and kdewin.


Changes
---

Submitted with commit fe9116847d6f2e36c1ec04e2af0cfac2553336fd by Andrius da 
Costa Ribas to branch master.


Repository: kio-extras


Description
---

These had been disabled when moving into frameworks.


Diffs
-

  thumbnail/CMakeLists.txt 6a6ecc7 
  thumbnail/windowsexecreator.cpp f823597 
  thumbnail/windowsimagecreator.cpp cb110f3 

Diff: https://git.reviewboard.kde.org/r/127714/diff/


Testing
---

Tested using MSVC 2015 64bit.

Also, faked a non-win32 setup to ensure the icoutils version is also working 
(with wrestool binary from (**aaargh!!**) cygwin).


File Attachments


Native Version
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/22/62d1333b-5f3f-44e9-8e16-5761d73f590f__dolphin_winico2.png
Icoutils Version
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/22/433e0df6-b9ff-4687-b555-9f7163b7433f__dolphin_wresico2.png


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 127714: Enable ICO and EXE thumbnails again.

2016-04-22 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127714/
---

(Updated Abril 22, 2016, 7:55 p.m.)


Review request for KDE Frameworks and kdewin.


Changes
---

Added screenshots (note: Icoutils version doesn't support all icon formats).


Repository: kio-extras


Description
---

These had been disabled when moving into frameworks.


Diffs
-

  thumbnail/CMakeLists.txt 6a6ecc7 
  thumbnail/windowsexecreator.cpp f823597 
  thumbnail/windowsimagecreator.cpp cb110f3 

Diff: https://git.reviewboard.kde.org/r/127714/diff/


Testing
---

Tested using MSVC 2015 64bit.

Also, faked a non-win32 setup to ensure the icoutils version is also working 
(with wrestool binary from (**aaargh!!**) cygwin).


File Attachments (updated)


Native Version
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/22/62d1333b-5f3f-44e9-8e16-5761d73f590f__dolphin_winico2.png
Icoutils Version
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/04/22/433e0df6-b9ff-4687-b555-9f7163b7433f__dolphin_wresico2.png


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 127714: Enable ICO and EXE thumbnails again.

2016-04-22 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127714/
---

Review request for KDE Frameworks and kdewin.


Repository: kio-extras


Description
---

These had been disabled when moving into frameworks.


Diffs
-

  thumbnail/CMakeLists.txt 6a6ecc7 
  thumbnail/windowsexecreator.cpp f823597 
  thumbnail/windowsimagecreator.cpp cb110f3 

Diff: https://git.reviewboard.kde.org/r/127714/diff/


Testing
---

Tested using MSVC 2015 64bit.

Also, faked a non-win32 setup to ensure the icoutils version is also working 
(with wrestool binary from (**aaargh!!**) cygwin).


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Problem using Vc with CMake 3.0 and kf5

2015-05-23 Thread Andrius da Costa Ribas
I'm not sure if I understood the issue. If we need to pass the -I
parameters to vc_compile_for_all_implementations, then something like
https://git.reviewboard.kde.org/r/115110/diff/1/ might work.
 Em 23/05/2015 09:07, Aleix Pol aleix...@kde.org escreveu:

 On Sat, May 23, 2015 at 11:51 AM, Boudewijn Rempt b...@valdyas.org
 wrote:
  Sorry for the extensive cross-posting in advance, please when replying,
 do a
  reply-all.
 
  Just so everyone is on the same page: Vc is a template library that
 makes it
  easy to build vectorized code using a single source file. Krita uses Vc
 to
  optimize blending colors, creating masks and much more. Krita uses the
 most
  recent Vc release, 0.7.4: http://code.compeng.uni-frankfurt.de/news/27
 
  We're currently porting Krita to Qt5 and KF5 and the way KF5 and Vc
 handle
  include directories is a big roadblock for us:
  https://git.reviewboard.kde.org/r/123179/ .
 
  In a nutshell: Vc builds many different object files from single cpp
 file.
  It does this by creating a custom command for each target vectorization
  extension. To do that, it needs to access the contents of
  INCLUDE_DIRECTORIES, like this (in VcMacros.cmake:
 
 http://code.compeng.uni-frankfurt.de/projects/vc/repository/entry/cmake/VcMacros.cmake?rev=0.7
 )
 
 get_directory_property(_inc INCLUDE_DIRECTORIES)
 foreach(_i ${_inc})
list(APPEND _flags -I${_i})
 endforeach()
 
  In the end the command is generated like this:
 
   add_custom_command(OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/${_out}
  COMMAND ${CMAKE_CXX_COMPILER} ${_flags} ${_extra_flags}
  -DVC_IMPL=${_impl}
  ${_outfile_flag}${_out}
  ${CMAKE_CURRENT_SOURCE_DIR}/${_vc_compile_src}
  MAIN_DEPENDENCY
 ${CMAKE_CURRENT_SOURCE_DIR}/${_vc_compile_src}
  IMPLICIT_DEPENDS CXX
  ${CMAKE_CURRENT_SOURCE_DIR}/${_vc_compile_src}
  COMMENT Building CXX object ${_out}
  WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
  VERBATIM
  )
  KF5 uses cmake generator expressions to derive the include directories
 from
  the target_link_libraries lines. This means that when we try to build our
  per-extensions object files we get this:
 
 
 
  [  0%] Building CXX object
  KoOptimizedCompositeOpFactoryPerArch_AVX.cpp.o
  cd /home/boud/kde/build/calligra/libs/pigment  /usr/bin/c++
 -std=c++0x
  -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts
  -Wformat-security -Wno-long-long -Wpointer-arith -Wundef
 -Wnon-virtual-dtor
  -Woverloaded-virtual -Werror=return-type
 -D__GNUC_UBUNTU_VERSION__=0xf040a
  -Wabi -fabi-version=0 -ffp-contract=fast -mtune=core2 -fPIC
  -I/home/boud/kde/src/calligra/interfaces -I/home/boud/kde/build/calligra
  -I/home/boud/kde/src/calligra -I/home/boud/kde/src/calligra/libs/version
  -I/home/boud/kde/build/calligra/libs/version
  -I/home/boud/kde/src/calligra/libs/koplugin
  -I/home/boud/kde/src/calligra/libs/version
  -I/home/boud/kde/build/calligra/libs/version
  -I/home/boud/kde/src/calligra/libs/pigment
  -I/home/boud/kde/src/calligra/libs/pigment/compositeops
  -I/home/boud/kde/src/calligra/libs/pigment/resources -I/usr/include
  -I/usr/include -I/usr/include/OpenEXR -I/usr/include -mavx -DVC_IMPL=AVX
 -c
  -oKoOptimizedCompositeOpFactoryPerArch_AVX.cpp.o
 
 /home/boud/kde/src/calligra/libs/pigment/compositeops/KoOptimizedCompositeOpFactoryPerArch.cpp
 
 
 /home/boud/kde/src/calligra/libs/pigment/compositeops/KoOptimizedCompositeOpFactoryPerArch.cpp:22:19:
  fatal error: QString: No such file or directory
   #include QString
 ^
  compilation terminated.
  libs/pigment/CMakeFiles/pigmentcms.dir/build.make:72: recipe for
 target
  'libs/pigment/KoOptimizedCompositeOpFactoryPerArch_AVX.cpp.o' failed
 
  On other words, INCLUDE_DIRECTORIES is empty, there's no Qt5, no Kf5 to
 be
  found.
 
  If we manually set include directories like this:
 
  if (HAVE_VC)
  message(. ${KDE4_INCLUDES})
  include_directories(${KDE4_INCLUDES} ${Qt5Core_INCLUDE_DIRS}
  ${Qt5Gui_INCLUDE_DIRS} ${Qt5Xml_INCLUDE_DIRS} ${PIGMENT_INCLUDES}
  ${Boost_INCLUDE_DIR})
  endif()
 
  We end up with the entire include line for the contents of KDE4_INCLUDES
  ($TARGET_PROPERTY:KF5::KDELibs4Support,INTERFACE_INCLUDE_DIRECTORIES)
  expanded to a string with quotes around it:
 
 [  0%] Building CXX object
 KoOptimizedCompositeOpFactoryPerArch_AVX.cpp.o
  cd /home/boud/kde/build/calligra/libs/pigment  /usr/bin/c++
 -std=c++0x
  -fno-exceptions -Wall -Wextra -Wcast-align -Wchar-subscripts
  -Wformat-security -Wno-long-long -Wpointer-arith -Wundef
 -Wnon-virtual-dtor
  -Woverloaded-virtual -Werror=return-type
 -D__GNUC_UBUNTU_VERSION__=0xf040a
  -Wabi -fabi-version=0 -ffp-contract=fast -mtune=core2 -fPIC
  -I/home/boud/kde/src/calligra/interfaces -I/home/boud/kde/build/calligra
  -I/home/boud/kde/src/calligra -I/home/boud/kde/src/calligra/libs/version
  

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2015-04-19 Thread Andrius da Costa Ribas


 On Nov. 10, 2014, 9:41 p.m., David Faure wrote:
  lib/konq/src/konq_historyentry.h, line 57
  https://git.reviewboard.kde.org/r/121080/diff/1/?file=327432#file327432line57
 
  const ref, no?
 
 Andrius da Costa Ribas wrote:
 before I try to fix the pending issues: what are we going to decide?
 
 - Should we create KDE_DUMMY_QHASH_FUNCTION macro again? (which header)
 - Should it apply to MSVC-only or should it be ifdef-free?
 
 David Faure wrote:
 Clearly this is not KDE specific. Any QListcustom type requires this on 
 MSVC, right? Then I would strongly suggest a solution within Qt itself, *if* 
 a central solution such as a macro is indeed needed. But thinking about it, a 
 one-line dummy impl that returns 0 doesn't really seem worth a macro to me.
 I.e. why not do like qitemselectionmodel.h does, everywhere where this is 
 needed?
 
 But I am still surprised that Qt only needs this in qitemselectionmodel.h
 Take this for instance:
 src/corelib/io/qstorageinfo.h:static QListQStorageInfo 
 mountedVolumes();
 Why doesn't this require a qHash(QStorageInfo)?
 If I explicitly call toSet() on such a list, I do get a compile error (on 
 Linux) due to the missing qHash implementation. 
 http://www.davidfaure.fr/2015/storageview.diff
 So MSVC doesn't *always* instanciate the toSet() method, but only in some 
 cases?
 Or are we looking at an old MSVC issue which doesn't exist anymore with 
 more recent MSVC versions? i.e. did you try removing this block (in 
 konq_historyentry.h) altogether to check it's still needed?

There is some historic reference here: 
http://marc.info/?l=kde-core-develm=113069150408826w=2

MSVC 2013 still has the same beahviour.


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121080/#review70214
---


On Nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121080/
 ---
 
 (Updated Nov. 8, 2014, 10:26 p.m.)
 
 
 Review request for KDE Base Apps, KDE Frameworks and kdewin.
 
 
 Repository: kde-baseapps
 
 
 Description
 ---
 
 Since we're not using kdemacros.h here anymore, KDE_DUMMY_QHASH_FUNCTION is 
 not available. Implement it instead.
 
 
 Diffs
 -
 
   lib/konq/src/konq_historyentry.h de34d6b 
 
 Diff: https://git.reviewboard.kde.org/r/121080/diff/
 
 
 Testing
 ---
 
 It builds (MSVC2013 - 64bit) after this patch (along other patches I'm 
 sending to review today). Kdebase-apps is still not very functional, though 
 (missing icons and weird UI).
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 121079: Fix building dolphin tests on MSVC

2015-04-19 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121079/
---

(Updated Abril 19, 2015, 3:13 p.m.)


Status
--

This change has been discarded.


Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

MSVC complains about missing symbols from their respective moc files on linking 
step.


Diffs
-

  dolphin/src/tests/CMakeLists.txt 60f6517 

Diff: https://git.reviewboard.kde.org/r/121079/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 121079: Fix building dolphin tests on MSVC

2015-04-19 Thread Andrius da Costa Ribas


 On Fev. 12, 2015, 10:54 p.m., Albert Astals Cid wrote:
  Patch doesn't apply, please rebase

superseded by RR https://git.reviewboard.kde.org/r/123270/, discarding this one.


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121079/#review75951
---


On Nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121079/
 ---
 
 (Updated Nov. 8, 2014, 10:26 p.m.)
 
 
 Review request for KDE Base Apps, KDE Frameworks and kdewin.
 
 
 Repository: kde-baseapps
 
 
 Description
 ---
 
 MSVC complains about missing symbols from their respective moc files on 
 linking step.
 
 
 Diffs
 -
 
   dolphin/src/tests/CMakeLists.txt 60f6517 
 
 Diff: https://git.reviewboard.kde.org/r/121079/diff/
 
 
 Testing
 ---
 
 It builds (MSVC2013 - 64bit) after this patch (along other patches I'm 
 sending to review today). Kdebase-apps is still not very functional, though 
 (missing icons and weird UI).
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2015-04-04 Thread Andrius da Costa Ribas


 On Nov. 10, 2014, 9:41 p.m., David Faure wrote:
  lib/konq/src/konq_historyentry.h, line 57
  https://git.reviewboard.kde.org/r/121080/diff/1/?file=327432#file327432line57
 
  const ref, no?

before I try to fix the pending issues: what are we going to decide?

- Should we create KDE_DUMMY_QHASH_FUNCTION macro again? (which header)
- Should it apply to MSVC-only or should it be ifdef-free?


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121080/#review70214
---


On Nov. 8, 2014, 10:26 p.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/121080/
 ---
 
 (Updated Nov. 8, 2014, 10:26 p.m.)
 
 
 Review request for KDE Base Apps, KDE Frameworks and kdewin.
 
 
 Repository: kde-baseapps
 
 
 Description
 ---
 
 Since we're not using kdemacros.h here anymore, KDE_DUMMY_QHASH_FUNCTION is 
 not available. Implement it instead.
 
 
 Diffs
 -
 
   lib/konq/src/konq_historyentry.h de34d6b 
 
 Diff: https://git.reviewboard.kde.org/r/121080/diff/
 
 
 Testing
 ---
 
 It builds (MSVC2013 - 64bit) after this patch (along other patches I'm 
 sending to review today). Kdebase-apps is still not very functional, though 
 (missing icons and weird UI).
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 120648: Encode the URIs which end up in DTD files

2015-04-03 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review78445
---



cmake/uriencode.cmake (line 15)
https://git.reviewboard.kde.org/r/120648/#comment53670

I've tried changing this to:

execute_process(COMMAND perl -MURI::Escape -e print 
uri_escape_utf8(\${escaped_uri}\, \^A-Za-z0-9\\-\\._~\\/:\);
(...)

it works here, but I'm not sure if it'd be the proper fix.


- Andrius da Costa Ribas


On Fev. 28, 2015, 10:02 p.m., Luigi Toscano wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120648/
 ---
 
 (Updated Fev. 28, 2015, 10:02 p.m.)
 
 
 Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, 
 and kdewin.
 
 
 Repository: kdoctools
 
 
 Description
 ---
 
 The URI need to be encoded, because some valid characters for
 filenames are not valid according RFC 2396.
 Easy way to trigger the issue: when the path contains spaces,
 as it happens on MacOSX builds.
 
 See also https://git.reviewboard.kde.org/r/120649/ for the twin review on 
 kdelibs4support.
 
 
 Diffs
 -
 
   cmake/uriencode.cmake PRE-CREATION 
   src/CMakeLists.txt 341ecf4 
 
 Diff: https://git.reviewboard.kde.org/r/120648/diff/
 
 
 Testing
 ---
 
 It compiles, but I can't properly test Mac and Windows scenarios
 
 
 Thanks,
 
 Luigi Toscano
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 120648: Encode the URIs which end up in DTD files

2015-04-03 Thread Andrius da Costa Ribas


 On Abril 3, 2015, 3:35 p.m., Andrius da Costa Ribas wrote:
  src/CMakeLists.txt, line 20
  https://git.reviewboard.kde.org/r/120648/diff/2/?file=320785#file320785line20
 
  It's already committed (but there's been a long time since I hadn't 
  build anything), but now I see that DocBookXML4_DTD_DIR is used only inside 
  the else(NOT WIN32) part, is this what's been intended? Also, this 
  doesn't work when the original DocBookXML4_DTD_DIR is an absolute Windows 
  path V: becomes V%3A and xmllint fails to recognise it as an absolute 
  path (see below) and CMake would fail to install to such location. (maybe 
  we should prepend it with file:// ?)
  
  
  
  
  file:///V:/build/frameworks/kdoctools/work/msvc2013-RelWithDebInfo-master/src/customization/dtd/kdedbx45.dtd:102:
   warning: failed to load external
  
  ///V:/build/frameworks/kdoctools/work/msvc2013-RelWithDebInfo-master/src/customization/dtd/v%3A/share/xml/docbook/schema/dtd/4.5/docbookx.dtd
  %DocBookDTD;
 
 Luigi Toscano wrote:
 - DocBookXML4_DTD_DIR is properly touched both for non WIN32 (line 4) and 
 WIN32 (lines 4 and 20). The WIN32 logic is a bit complicated, but basically 
 it rewrites again the generated ${_custom_dtd_kdex} file using the DTD path 
 which is knows during the installation. Or something like that.
 - Oh, that's the feedback I was looking for. Can you please copy the 
 exact content of the path to docbookx.dtd as referenced into kdedbx45.dtd?

!ENTITY % DocBookDTD   PUBLIC
  -//OASIS//DTD DocBook XML V4.5//EN
  v%3A/share/xml/docbook/schema/dtd/4.5/docbookx.dtd 
%DocBookDTD;


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review78442
---


On Fev. 28, 2015, 10:02 p.m., Luigi Toscano wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120648/
 ---
 
 (Updated Fev. 28, 2015, 10:02 p.m.)
 
 
 Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, 
 and kdewin.
 
 
 Repository: kdoctools
 
 
 Description
 ---
 
 The URI need to be encoded, because some valid characters for
 filenames are not valid according RFC 2396.
 Easy way to trigger the issue: when the path contains spaces,
 as it happens on MacOSX builds.
 
 See also https://git.reviewboard.kde.org/r/120649/ for the twin review on 
 kdelibs4support.
 
 
 Diffs
 -
 
   cmake/uriencode.cmake PRE-CREATION 
   src/CMakeLists.txt 341ecf4 
 
 Diff: https://git.reviewboard.kde.org/r/120648/diff/
 
 
 Testing
 ---
 
 It compiles, but I can't properly test Mac and Windows scenarios
 
 
 Thanks,
 
 Luigi Toscano
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 120648: Encode the URIs which end up in DTD files

2015-04-03 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120648/#review78442
---



src/CMakeLists.txt (line 20)
https://git.reviewboard.kde.org/r/120648/#comment53667

It's already committed (but there's been a long time since I hadn't build 
anything), but now I see that DocBookXML4_DTD_DIR is used only inside the 
else(NOT WIN32) part, is this what's been intended? Also, this doesn't work 
when the original DocBookXML4_DTD_DIR is an absolute Windows path V: becomes 
V%3A and xmllint fails to recognise it as an absolute path (see below) and 
CMake would fail to install to such location. (maybe we should prepend it with 
file:// ?)


file:///V:/build/frameworks/kdoctools/work/msvc2013-RelWithDebInfo-master/src/customization/dtd/kdedbx45.dtd:102:
 warning: failed to load external

///V:/build/frameworks/kdoctools/work/msvc2013-RelWithDebInfo-master/src/customization/dtd/v%3A/share/xml/docbook/schema/dtd/4.5/docbookx.dtd
%DocBookDTD;


- Andrius da Costa Ribas


On Fev. 28, 2015, 10:02 p.m., Luigi Toscano wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120648/
 ---
 
 (Updated Fev. 28, 2015, 10:02 p.m.)
 
 
 Review request for Build System, KDE Software on Mac OS X, KDE Frameworks, 
 and kdewin.
 
 
 Repository: kdoctools
 
 
 Description
 ---
 
 The URI need to be encoded, because some valid characters for
 filenames are not valid according RFC 2396.
 Easy way to trigger the issue: when the path contains spaces,
 as it happens on MacOSX builds.
 
 See also https://git.reviewboard.kde.org/r/120649/ for the twin review on 
 kdelibs4support.
 
 
 Diffs
 -
 
   cmake/uriencode.cmake PRE-CREATION 
   src/CMakeLists.txt 341ecf4 
 
 Diff: https://git.reviewboard.kde.org/r/120648/diff/
 
 
 Testing
 ---
 
 It compiles, but I can't properly test Mac and Windows scenarios
 
 
 Thanks,
 
 Luigi Toscano
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 121077: Check before using -Wno-deprecated-declarations.

2015-02-12 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121077/
---

(Updated feb. 12, 2015, 10:56 p.m.)


Status
--

This change has been discarded.


Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

A simple cmake check to avoid errors on MSVC.


Diffs
-

  dolphin/src/CMakeLists.txt c074908 

Diff: https://git.reviewboard.kde.org/r/121077/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 121081: QT_WA

2015-02-12 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121081/
---

(Updated Feb. 12, 2015, 10:53 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

QT_WA is not available on Qt5. We also only use the Unicode version, anyways.


Diffs
-

  lib/konq/src/konq_copytomenu.cpp 7f97c12 

Diff: https://git.reviewboard.kde.org/r/121081/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Supporting MSVC2010 in ktexteditor framework

2015-01-29 Thread Andrius da Costa Ribas
+1 for VC12 (I'm using msvc 2013)

--
Andrius.

2015-01-29 6:49 GMT-02:00 Ivan Čukić ivan.cu...@kde.org:

 Hi all,

 So, the thread died out again.

 Who is in favour of the following:
 - Require MSVC10 like (aka status quo)
 - Require MSVC11
 - Require MSVC12

 (it would be nice to get the input from kde windows guys as well)

 Cheerio,
 Ivan




 On 17 November 2014 at 14:41, Kai Uwe Broulik k...@privat.broulik.de
 wrote:
 
- initializer lists
   Unsupported on VS2012.
 
  Again, seems to be that CTP thingie, damn. (though, again, the
 initializer
  lists should also be tested - maybe they also work if the number of
 arguments
  is less than ...)
 
  I've had problems with them even on VS2013, like return QHashint,
 QByteArray({ {FooRole, foo} });
  For QAbstractListModel::roleNames() which worked fine in recent clang
 and gcc.
  ___
  Kde-frameworks-devel mailing list
  Kde-frameworks-devel@kde.org
  https://mail.kde.org/mailman/listinfo/kde-frameworks-devel



 --
 Cheerio,
 Ivan

 --
 While you were hanging yourself on someone else's words
 Dying to believe in what you heard
 I was staring straight into the shining sun
 ___
 Kde-frameworks-devel mailing list
 Kde-frameworks-devel@kde.org
 https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 120878: Remove unused header

2015-01-10 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120878/
---

(Updated Jan. 10, 2015, 4:09 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, kdewin and Plasma.


Repository: krunner


Description
---

Since scripting/runnerscript.cpp is not compiled, we get a linking error by 
exporting but not defining RunnerScript.


Diffs
-

  src/abstractrunner.cpp 4da0394 

Diff: https://git.reviewboard.kde.org/r/120878/diff/


Testing
---

Tested building using MSVC 64bit


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 120878: Remove unused header

2015-01-09 Thread Andrius da Costa Ribas


 On Jan. 9, 2015, 11:53 a.m., David Edmundson wrote:
  I should have asked, do you have commit access or do you need someone to 
  merge this?

I do have commit access, but I am okay if anyone commits it too. I just had 
little time to do so.


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120878/#review73573
---


On Out. 29, 2014, 2:27 a.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/120878/
 ---
 
 (Updated Out. 29, 2014, 2:27 a.m.)
 
 
 Review request for KDE Frameworks, kdewin and Plasma.
 
 
 Repository: krunner
 
 
 Description
 ---
 
 Since scripting/runnerscript.cpp is not compiled, we get a linking error by 
 exporting but not defining RunnerScript.
 
 
 Diffs
 -
 
   src/abstractrunner.cpp 4da0394 
 
 Diff: https://git.reviewboard.kde.org/r/120878/diff/
 
 
 Testing
 ---
 
 Tested building using MSVC 64bit
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: OSX/CI: QSP patch ( was KF5 Update Meeting Minutes 2014-w28 )

2015-01-03 Thread Andrius da Costa Ribas
Hi, there is some background context in review requests 115752 and 115210
(especially the last comment in this one) , but there was no final
conclusion, so this can be considered a workaround to keep coherent to what
was being done with KDE4 on Windows.

Regarding oxygen, we'd probably change it later into breeze. Oxygen works
fine (Qt fallbacks to ugly win9x when it's not available).

Cheers,
Andrius.

2014-12-28 8:41 GMT-02:00 René JV Bertin rjvber...@gmail.com:

 Hi

 Interesting. Would you mind giving some context, arguments behind choices
 and things like that?

 Also, do I understand correctly that you set Oxygen as the default style?
 Does it work correctly on Ms Windows?

 On 28 Dec 2014, at 01:24, Andrius da Costa Ribas andrius...@gmail.com
 wrote:

 In our Windows Emerge scripts QStandardPaths is already being patched for
 a while:


 http://quickgit.kde.org/?p=emerge.gita=blobh=e716bf675669139059a96db6be76cc3470487d64hb=b64cc189fa1918894653f185068e1786b31bd02ef=portage%2Flibs%2Fqt5%2Fqtbase%2Fqtbase-20130714.patch



 2014-12-15 19:12 GMT-02:00 Marko Käning mk-li...@email.de:

 Hi David,

 back to our discussion during this summer:

 On 10 Jul 2014, at 11:57 , David Faure fa...@kde.org wrote:
  Wrong approach. XDG is a freedesktop thing which doesn't apply to Mac.
 
  This should be fixed the other way around:
  1) finding out how Mac OS lets people configure the location for their
 files,
  or if this isn't configurable, coming up with QT_* environment
 variables.
  2) patching QStandardPaths to use these
  3) setting these vars in the CT scripts


 Since a fortnight we’re discussing the QStandardPaths patch needed for
 the OSX/CI
 system [0] on KDE-MAC [1,2] and it would be good if you’d join this
 discussion now,
 as Ben also wants to come up with a patch for Windows very soon.
 (Ian actually had already included you in his last post [3] to thread
 [1].)

 Can we have this discussion on KDE-MAC (or on both lists), as Ian and
 René aren’t
 subscribed to K-F-D?!

 Regards,
 Marko




 [0]
 http://quickgit.kde.org/?p=clones%2Fwebsites%2Fbuild-kde-org%2Fkaning%2Fmp-osx-ci.gita=blobh=27deb1cb8f8f70ea949fc241e049d9b47a10f6dfhb=8126ab8cb976f42a4ebe5d3b7d2cb7a3d42217d1f=patches%2Fqt5%2Fkf5-qt5%2Fpatch-qstandardpaths_mac.cpp.diff

 [1] http://mail.kde.org/pipermail/kde-mac/2014-December/002590.html

 [2] http://mail.kde.org/pipermail/kde-mac/2014-December/002705.html

 [3] http://mail.kde.org/pipermail/kde-mac/2014-December/002737.html
 ___
 Kde-frameworks-devel mailing list
 Kde-frameworks-devel@kde.org
 https://mail.kde.org/mailman/listinfo/kde-frameworks-devel



___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: OSX/CI: QSP patch ( was KF5 Update Meeting Minutes 2014-w28 )

2014-12-27 Thread Andrius da Costa Ribas
In our Windows Emerge scripts QStandardPaths is already being patched for a
while:

http://quickgit.kde.org/?p=emerge.gita=blobh=e716bf675669139059a96db6be76cc3470487d64hb=b64cc189fa1918894653f185068e1786b31bd02ef=portage%2Flibs%2Fqt5%2Fqtbase%2Fqtbase-20130714.patch



2014-12-15 19:12 GMT-02:00 Marko Käning mk-li...@email.de:

 Hi David,

 back to our discussion during this summer:

 On 10 Jul 2014, at 11:57 , David Faure fa...@kde.org wrote:
  Wrong approach. XDG is a freedesktop thing which doesn't apply to Mac.
 
  This should be fixed the other way around:
  1) finding out how Mac OS lets people configure the location for their
 files,
  or if this isn't configurable, coming up with QT_* environment variables.
  2) patching QStandardPaths to use these
  3) setting these vars in the CT scripts


 Since a fortnight we’re discussing the QStandardPaths patch needed for the
 OSX/CI
 system [0] on KDE-MAC [1,2] and it would be good if you’d join this
 discussion now,
 as Ben also wants to come up with a patch for Windows very soon.
 (Ian actually had already included you in his last post [3] to thread [1].)

 Can we have this discussion on KDE-MAC (or on both lists), as Ian and René
 aren’t
 subscribed to K-F-D?!

 Regards,
 Marko




 [0]
 http://quickgit.kde.org/?p=clones%2Fwebsites%2Fbuild-kde-org%2Fkaning%2Fmp-osx-ci.gita=blobh=27deb1cb8f8f70ea949fc241e049d9b47a10f6dfhb=8126ab8cb976f42a4ebe5d3b7d2cb7a3d42217d1f=patches%2Fqt5%2Fkf5-qt5%2Fpatch-qstandardpaths_mac.cpp.diff

 [1] http://mail.kde.org/pipermail/kde-mac/2014-December/002590.html

 [2] http://mail.kde.org/pipermail/kde-mac/2014-December/002705.html

 [3] http://mail.kde.org/pipermail/kde-mac/2014-December/002737.html
 ___
 Kde-frameworks-devel mailing list
 Kde-frameworks-devel@kde.org
 https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 121075: Also export inner KBookmarkOwner::FutureBookmark

2014-12-06 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121075/
---

(Updated Dec. 6, 2014, 8:20 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and kdewin.


Repository: kbookmarks


Description
---

Konqueror references KBookmarkOwner::FutureBookmark, which is not properly 
exported, causing the build to fail.


Diffs
-

  src/kbookmarkowner.h 4d6fe0b 

Diff: https://git.reviewboard.kde.org/r/121075/diff/


Testing
---

It builds (MSVC2013 - 64bit), and Konqueror builds after this patch (along 
other patches I'm sending to review today). Kdebase-apps is still not very 
functional, though (missing icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 121076: Do not require KF5::Su on Windows

2014-11-19 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121076/
---

(Updated Nov. 20, 2014, 3:29 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

kdepasswd, which requires it, is already disabled on Windows. There is also 
konq-plugins/shellcmdplugins which was also disabled on Windows, but 
konq-plugins is entirely disabled now.


Diffs
-

  CMakeLists.txt f02b069 

Diff: https://git.reviewboard.kde.org/r/121076/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 121078: Fix exports.

2014-11-19 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121078/
---

(Updated Nov. 20, 2014, 3:29 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

Use CMake's generate_export_header whenever possible, and fix some inconsistent 
exports.
Also, use Q_DECL_EXPORT consistently across occurrences of kdemain for kdeinit 
apps (removing kdemacros.h where KDE_EXPORT was being in use).


Diffs
-

  dolphin/src/views/dolphinfileitemlistwidget.h 5f7c181 
  dolphin/src/views/dolphinitemlistview.h 7fd72e5 
  dolphin/src/views/versioncontrol/updateitemstatesthread.h 9b744d5 
  dolphin/src/views/versioncontrol/versioncontrolobserver.h 034ef8b 
  dolphin/src/views/viewmodecontroller.h 9ea717a 
  dolphin/src/views/viewproperties.h d3ea428 
  keditbookmarks/kbookmarkmodel/CMakeLists.txt 2f83af2 
  keditbookmarks/kbookmarkmodel/kbookmarkmodel_export.h b759bf9 
  keditbookmarks/main.cpp bc64193 
  konqueror/client/kfmclient.cpp 276452b 
  konqueror/src/CMakeLists.txt 6831c88 
  konqueror/src/konq_statusbarmessagelabel.h a115d39 
  konqueror/src/konqmain.cpp 7a73231 
  konqueror/src/konqprivate_export.h 2dec78b 
  dolphin/src/libdolphin_export.h ff0f125 
  dolphin/src/main.cpp 91d32a0 
  dolphin/src/kitemviews/private/kitemlistviewlayouter.h 0efcab1 
  dolphin/src/CMakeLists.txt c074908 
  dolphin/src/kitemviews/kfileitemlistview.h 9f07c9d 
  dolphin/src/kitemviews/kfileitemlistwidget.h b7061d3 
  dolphin/src/kitemviews/kfileitemmodel.h 535e0f3 
  dolphin/src/kitemviews/kfileitemmodelrolesupdater.h e8b186a 
  dolphin/src/kitemviews/kitemlistcontainer.h 55a9a11 
  dolphin/src/kitemviews/kitemlistcontroller.h 99df531 
  dolphin/src/kitemviews/kitemlistgroupheader.h 66fe929 
  dolphin/src/kitemviews/kitemlistheader.h fe2d0ac 
  dolphin/src/kitemviews/kitemlistselectionmanager.h c4decd3 
  dolphin/src/kitemviews/kitemliststyleoption.h 782dd0e 
  dolphin/src/kitemviews/kitemlistview.h cc0754f 
  dolphin/src/kitemviews/kitemlistviewaccessible.h 674f1d1 
  dolphin/src/kitemviews/kitemlistwidget.h 07fc789 
  dolphin/src/kitemviews/kitemmodelbase.h 283cfa5 
  dolphin/src/kitemviews/kstandarditem.h 59190bf 
  dolphin/src/kitemviews/kstandarditemlistgroupheader.h 871c93d 
  dolphin/src/kitemviews/kstandarditemlistview.h eb07c7f 
  dolphin/src/kitemviews/kstandarditemlistwidget.h 7683f84 
  dolphin/src/kitemviews/kstandarditemmodel.h 9d1db1a 
  dolphin/src/kitemviews/private/kbaloorolesprovider.h f1ad5c7 
  dolphin/src/kitemviews/private/kfileitemmodeldirlister.h 94a0e39 
  dolphin/src/kitemviews/private/kfileitemmodelfilter.h e4fb0a2 
  dolphin/src/kitemviews/private/kitemlistheaderwidget.h b99f45f 
  dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.h 661178d 
  dolphin/src/kitemviews/private/kitemlistrubberband.h aea58af 
  dolphin/src/kitemviews/private/kitemlistselectiontoggle.h 8a1a857 
  dolphin/src/kitemviews/private/kitemlistsizehintresolver.h a0ad033 
  dolphin/src/kitemviews/private/kitemlistsmoothscroller.h ea56822 
  dolphin/src/kitemviews/private/kitemlistviewanimation.h e2e5338 
  dolphin/src/kitemviews/private/kpixmapmodifier.h 4f863c3 

Diff: https://git.reviewboard.kde.org/r/121078/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 121075: Also export inner KBookmarkOwner::FutureBookmark

2014-11-08 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121075/
---

Review request for KDE Frameworks and kdewin.


Repository: kbookmarks


Description
---

Konqueror references KBookmarkOwner::FutureBookmark, which is not properly 
exported, causing the build to fail.


Diffs
-

  src/kbookmarkowner.h 4d6fe0b 

Diff: https://git.reviewboard.kde.org/r/121075/diff/


Testing
---

It builds (MSVC2013 - 64bit), and Konqueror builds after this patch (along 
other patches I'm sending to review today). Kdebase-apps is still not very 
functional, though (missing icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 121076: Do not require KF5::Su on Windows

2014-11-08 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121076/
---

Review request for KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

kdepasswd, which requires it, is already disabled on Windows. There is also 
konq-plugins/shellcmdplugins which was also disabled on Windows, but 
konq-plugins is entirely disabled now.


Diffs
-

  CMakeLists.txt f02b069 

Diff: https://git.reviewboard.kde.org/r/121076/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 121076: Do not require KF5::Su on Windows

2014-11-08 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121076/
---

(Updated Nov. 8, 2014, 10:14 p.m.)


Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

kdepasswd, which requires it, is already disabled on Windows. There is also 
konq-plugins/shellcmdplugins which was also disabled on Windows, but 
konq-plugins is entirely disabled now.


Diffs
-

  CMakeLists.txt f02b069 

Diff: https://git.reviewboard.kde.org/r/121076/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 121077: Check before using -Wno-deprecated-declarations.

2014-11-08 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121077/
---

Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

A simple cmake check to avoid errors on MSVC.


Diffs
-

  dolphin/src/CMakeLists.txt c074908 

Diff: https://git.reviewboard.kde.org/r/121077/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 121078: Fix exports.

2014-11-08 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121078/
---

Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

Use CMake's generate_export_header whenever possible, and fix some inconsistent 
exports.
Also, use Q_DECL_EXPORT consistently across occurrences of kdemain for kdeinit 
apps (removing kdemacros.h where KDE_EXPORT was being in use).


Diffs
-

  dolphin/src/views/dolphinfileitemlistwidget.h 5f7c181 
  dolphin/src/views/dolphinitemlistview.h 7fd72e5 
  dolphin/src/views/versioncontrol/updateitemstatesthread.h 9b744d5 
  dolphin/src/views/versioncontrol/versioncontrolobserver.h 034ef8b 
  dolphin/src/views/viewmodecontroller.h 9ea717a 
  dolphin/src/views/viewproperties.h d3ea428 
  keditbookmarks/kbookmarkmodel/CMakeLists.txt 2f83af2 
  keditbookmarks/kbookmarkmodel/kbookmarkmodel_export.h b759bf9 
  keditbookmarks/main.cpp bc64193 
  konqueror/client/kfmclient.cpp 276452b 
  konqueror/src/CMakeLists.txt 6831c88 
  konqueror/src/konq_statusbarmessagelabel.h a115d39 
  konqueror/src/konqmain.cpp 7a73231 
  konqueror/src/konqprivate_export.h 2dec78b 
  dolphin/src/libdolphin_export.h ff0f125 
  dolphin/src/main.cpp 91d32a0 
  dolphin/src/kitemviews/private/kitemlistviewlayouter.h 0efcab1 
  dolphin/src/CMakeLists.txt c074908 
  dolphin/src/kitemviews/kfileitemlistview.h 9f07c9d 
  dolphin/src/kitemviews/kfileitemlistwidget.h b7061d3 
  dolphin/src/kitemviews/kfileitemmodel.h 535e0f3 
  dolphin/src/kitemviews/kfileitemmodelrolesupdater.h e8b186a 
  dolphin/src/kitemviews/kitemlistcontainer.h 55a9a11 
  dolphin/src/kitemviews/kitemlistcontroller.h 99df531 
  dolphin/src/kitemviews/kitemlistgroupheader.h 66fe929 
  dolphin/src/kitemviews/kitemlistheader.h fe2d0ac 
  dolphin/src/kitemviews/kitemlistselectionmanager.h c4decd3 
  dolphin/src/kitemviews/kitemliststyleoption.h 782dd0e 
  dolphin/src/kitemviews/kitemlistview.h cc0754f 
  dolphin/src/kitemviews/kitemlistviewaccessible.h 674f1d1 
  dolphin/src/kitemviews/kitemlistwidget.h 07fc789 
  dolphin/src/kitemviews/kitemmodelbase.h 283cfa5 
  dolphin/src/kitemviews/kstandarditem.h 59190bf 
  dolphin/src/kitemviews/kstandarditemlistgroupheader.h 871c93d 
  dolphin/src/kitemviews/kstandarditemlistview.h eb07c7f 
  dolphin/src/kitemviews/kstandarditemlistwidget.h 7683f84 
  dolphin/src/kitemviews/kstandarditemmodel.h 9d1db1a 
  dolphin/src/kitemviews/private/kbaloorolesprovider.h f1ad5c7 
  dolphin/src/kitemviews/private/kfileitemmodeldirlister.h 94a0e39 
  dolphin/src/kitemviews/private/kfileitemmodelfilter.h e4fb0a2 
  dolphin/src/kitemviews/private/kitemlistheaderwidget.h b99f45f 
  dolphin/src/kitemviews/private/kitemlistkeyboardsearchmanager.h 661178d 
  dolphin/src/kitemviews/private/kitemlistrubberband.h aea58af 
  dolphin/src/kitemviews/private/kitemlistselectiontoggle.h 8a1a857 
  dolphin/src/kitemviews/private/kitemlistsizehintresolver.h a0ad033 
  dolphin/src/kitemviews/private/kitemlistsmoothscroller.h ea56822 
  dolphin/src/kitemviews/private/kitemlistviewanimation.h e2e5338 
  dolphin/src/kitemviews/private/kpixmapmodifier.h 4f863c3 

Diff: https://git.reviewboard.kde.org/r/121078/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 121079: Fix building dolphin tests on MSVC

2014-11-08 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121079/
---

Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

MSVC complains about missing symbols from their respective moc files on linking 
step.


Diffs
-

  dolphin/src/tests/CMakeLists.txt 60f6517 

Diff: https://git.reviewboard.kde.org/r/121079/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2014-11-08 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121080/
---

Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

Since we're not using kdemacros.h here anymore, KDE_DUMMY_QHASH_FUNCTION is not 
available. Implement it instead.


Diffs
-

  lib/konq/src/konq_historyentry.h de34d6b 

Diff: https://git.reviewboard.kde.org/r/121080/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 121081: QT_WA

2014-11-08 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121081/
---

Review request for KDE Base Apps, KDE Frameworks and kdewin.


Repository: kde-baseapps


Description
---

QT_WA is not available on Qt5. We also only use the Unicode version, anyways.


Diffs
-

  lib/konq/src/konq_copytomenu.cpp 7f97c12 

Diff: https://git.reviewboard.kde.org/r/121081/diff/


Testing
---

It builds (MSVC2013 - 64bit) after this patch (along other patches I'm sending 
to review today). Kdebase-apps is still not very functional, though (missing 
icons and weird UI).


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 120878: Remove unused header

2014-10-28 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120878/
---

Review request for KDE Frameworks, kdewin and Plasma.


Repository: krunner


Description
---

Since scripting/runnerscript.cpp is not compiled, we get a linking error by 
exporting but not defining RunnerScript.


Diffs
-

  src/abstractrunner.cpp 4da0394 

Diff: https://git.reviewboard.kde.org/r/120878/diff/


Testing
---

Tested building using MSVC 64bit


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: platforms

2014-10-13 Thread Andrius da Costa Ribas
It can be cleaned up ... other WinCE specifics had already been cleaned up
in frameworks.

2014-10-13 20:59 GMT-03:00 Jeremy Whiting jpwhit...@kde.org:

 Do we support building and using frameworks on Windows CE anymore? I
 don't see it on
 http://qt-project.org/doc/qt-4.8/supported-platforms.html so I guess
 not, is that correct? If not I can clean up some old ifdefs in
 knewstuff sources.

 thanks,
 Jeremy
 ___
 Kde-frameworks-devel mailing list
 Kde-frameworks-devel@kde.org
 https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 117012: Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed camelcase header under $

2014-04-26 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/
---

(Updated April 26, 2014, 10:41 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and kdewin.


Repository: kjsembed


Description
---

Currently kjsembed CMake file tries to install both 
${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed (directory) and 
${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed (camel case header). This is not 
allowed in a case-insensitive filesystem, causing the install step to fail on 
Windows.


Diffs
-

  src/kjsembed/CMakeLists.txt e0ab74c 

Diff: https://git.reviewboard.kde.org/r/117012/diff/


Testing
---

Tested using MSVC 2013


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 117011: Use bin/../share on Windows as a workaround

2014-04-24 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117011/
---

(Updated April 24, 2014, 9:57 p.m.)


Status
--

This change has been discarded.


Review request for KDE Frameworks and kdewin.


Repository: kdoctools


Description
---

This is a workaround for kdoctools for the same problem discussed in review 
#115210. In particular, emerge installs docbook-dtd data under %KDEROOT%\share.


Diffs
-

  src/xslt.cpp db67599 

Diff: https://git.reviewboard.kde.org/r/117011/diff/


Testing
---

Tested using MSVC 2013. KJsEmbed, which depends on this, builds after this 
patch (KJsEmbed still has an unrelated problem on install step).


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

2014-04-23 Thread Andrius da Costa Ribas


 On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote:
  Until now we had no problems with the data installed to bin/../share  and 
  this setup would make it impossible to have multiple independent  kde 
  setups on one system.
 
 Alexander Richardson wrote:
 I know. The problem is QStandardPaths with 
 QStandardPaths::GenericDataLocation only looks in %ALLUSERSPROFILE% and I 
 think %APPDATA%. KF5 based KDE software won't work otherwise since it can't 
 find the data. I think the better way of fixing this is patching Qt, but for 
 now this works.
 
 Patrick Spendrin wrote:
 Can you keep that patch locally for now and we try and come up with a 
 patch for Qt instead? We cannot restrict ourselves at that point I think.
 
 Alexander Richardson wrote:
 Sure no problem. I'll drop this request
 
 David Faure wrote:
 So what do you recommend instead, for QStandardPaths? Checking some 
 non-standard environment variable? or?
 
 Alexander Richardson wrote:
 I would go for the environment variable. Something like 
 QSTANDARDPATHS_EXTRA_DATA_DIRS that is checked in addition to the default 
 dirs.
 
 Would also be useful for other cases: e.g. in the okteta unit tests I set 
 XDG_DATA_DIRS so that my test data gets found by QStandardPaths (I know there 
 is QFINDTESTDATA, but that won't work in that case).
 
 It would also be nice if there were some cross-platform solution like 
 QStandardpaths::addDirectory(QStandardPaths::StandardLocation, const QString 
 path) to inject (like KStandardDirs::addResourceDir).
 
 Patrick von Reth wrote:
 I don't like the idea of using the env var as this would require the user 
 to setup the variables or a kde process to set them up.
 We also would get an undefined behaviour if the env var is not set.
 I think kde is not the only qt project ported to windows wich uses the 
 bin/../share location on windows, so why not only add this path with a low 
 priority to QStrandardpathes?

 
 David Faure wrote:
 I agree that the env var would be quite inconvenient, which is why I was 
 dubious about that approach.
 
 A method to add paths wouldn't help either (how would all apps do it?)
 
 bin/../share means go up one level from the location of the executable 
 and enter share? I thought Windows apps didn't use a bin/ dir actually, but 
 were rather in the toplevel?
 Anyhow I'd be fine with that, especially if you can find any 
 documentation of this outside of kde (to explain the reasoning in the Qt 
 change request).
 
 Andrius da Costa Ribas wrote:
 As far as I can see:
 
 1 - Most GNU apps and libs ported from *nix to Windows use $PREFIX/bin, 
 $PREFIX/share etc... and PREFIX is not standard on windows (those apps 
 normally don't use %PROGRAMFILES%)
  * Other autoconf-based apps and libs also follow this structure
  * even those using %PROGRAMFILES% also follow this structure (e.g. for 
 GIMP 2, $PREFIX is %PROGRAMFILES%\GIMP 2\, having bin, lib, share... inside 
 it)
 2 - Most CMake-based apps also follow a similar pattern, relative to 
 $CMAKE_INSTALL_PREFIX, having no specific if(WIN32) to install to a 
 different directory structure
  * Cmake itself is distributed in this kind of structure 
 (http://www.cmake.org/files/v2.8/cmake-2.8.12.2.zip)
 
 I think those can explain the reasoning needed for a Qt request.
 
 David Faure wrote:
 Yes, a single monolithic can somehow find out about its own PREFIX (e.g. 
 by writing it into the registry at install time, right? Or indeed from the 
 path where the .exe is being started, simply).
 
 But the issue here is what if you install several apps (and possibly 
 several frameworks), and they need to find each other's stuff...


That's the exact same situation of using XDG_DATA_DIRS on *nix. For KDE-Windows 
we install all packages into the same prefix for a given KDE set up.


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115210/#review47983
---


On Jan. 22, 2014, 2:53 p.m., Alexander Richardson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115210/
 ---
 
 (Updated Jan. 22, 2014, 2:53 p.m.)
 
 
 Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
 kdewin.
 
 
 Repository: extra-cmake-modules
 
 
 Description
 ---
 
 Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows
 
 Otherwise QStandardPaths will always fail with e.g. GenericDataLocation
 
 
 Diffs
 -
 
   kde-modules/KDEInstallDirs.cmake 46e15c17d488d56f146aba0c2d420f74a22b9152 
 
 Diff: https://git.reviewboard.kde.org/r/115210/diff/
 
 
 Testing
 ---
 
 
 Thanks

Re: Review Request 115210: Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows

2014-04-20 Thread Andrius da Costa Ribas


 On Jan. 22, 2014, 8:22 a.m., Patrick von Reth wrote:
  Until now we had no problems with the data installed to bin/../share  and 
  this setup would make it impossible to have multiple independent  kde 
  setups on one system.
 
 Alexander Richardson wrote:
 I know. The problem is QStandardPaths with 
 QStandardPaths::GenericDataLocation only looks in %ALLUSERSPROFILE% and I 
 think %APPDATA%. KF5 based KDE software won't work otherwise since it can't 
 find the data. I think the better way of fixing this is patching Qt, but for 
 now this works.
 
 Patrick Spendrin wrote:
 Can you keep that patch locally for now and we try and come up with a 
 patch for Qt instead? We cannot restrict ourselves at that point I think.
 
 Alexander Richardson wrote:
 Sure no problem. I'll drop this request
 
 David Faure wrote:
 So what do you recommend instead, for QStandardPaths? Checking some 
 non-standard environment variable? or?
 
 Alexander Richardson wrote:
 I would go for the environment variable. Something like 
 QSTANDARDPATHS_EXTRA_DATA_DIRS that is checked in addition to the default 
 dirs.
 
 Would also be useful for other cases: e.g. in the okteta unit tests I set 
 XDG_DATA_DIRS so that my test data gets found by QStandardPaths (I know there 
 is QFINDTESTDATA, but that won't work in that case).
 
 It would also be nice if there were some cross-platform solution like 
 QStandardpaths::addDirectory(QStandardPaths::StandardLocation, const QString 
 path) to inject (like KStandardDirs::addResourceDir).
 
 Patrick von Reth wrote:
 I don't like the idea of using the env var as this would require the user 
 to setup the variables or a kde process to set them up.
 We also would get an undefined behaviour if the env var is not set.
 I think kde is not the only qt project ported to windows wich uses the 
 bin/../share location on windows, so why not only add this path with a low 
 priority to QStrandardpathes?

 
 David Faure wrote:
 I agree that the env var would be quite inconvenient, which is why I was 
 dubious about that approach.
 
 A method to add paths wouldn't help either (how would all apps do it?)
 
 bin/../share means go up one level from the location of the executable 
 and enter share? I thought Windows apps didn't use a bin/ dir actually, but 
 were rather in the toplevel?
 Anyhow I'd be fine with that, especially if you can find any 
 documentation of this outside of kde (to explain the reasoning in the Qt 
 change request).

As far as I can see:

1 - Most GNU apps and libs ported from *nix to Windows use $PREFIX/bin, 
$PREFIX/share etc... and PREFIX is not standard on windows (those apps normally 
don't use %PROGRAMFILES%)
 * Other autoconf-based apps and libs also follow this structure
 * even those using %PROGRAMFILES% also follow this structure (e.g. for GIMP 2, 
$PREFIX is %PROGRAMFILES%\GIMP 2\, having bin, lib, share... inside it)
2 - Most CMake-based apps also follow a similar pattern, relative to 
$CMAKE_INSTALL_PREFIX, having no specific if(WIN32) to install to a different 
directory structure
 * Cmake itself is distributed in this kind of structure 
(http://www.cmake.org/files/v2.8/cmake-2.8.12.2.zip)

I think those can explain the reasoning needed for a Qt request.


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115210/#review47983
---


On Jan. 22, 2014, 2:53 p.m., Alexander Richardson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115210/
 ---
 
 (Updated Jan. 22, 2014, 2:53 p.m.)
 
 
 Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
 kdewin.
 
 
 Repository: extra-cmake-modules
 
 
 Description
 ---
 
 Always set DATA_INSTALL_DIR to %ALLUSERSPROFILE% on Windows
 
 Otherwise QStandardPaths will always fail with e.g. GenericDataLocation
 
 
 Diffs
 -
 
   kde-modules/KDEInstallDirs.cmake 46e15c17d488d56f146aba0c2d420f74a22b9152 
 
 Diff: https://git.reviewboard.kde.org/r/115210/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Alexander Richardson
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 117012: Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed camelcase header under $

2014-04-20 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/
---

(Updated April 21, 2014, 1:59 a.m.)


Review request for KDE Frameworks and kdewin.


Changes
---

place all includes under include/KJsEmbed (instead of having another kjsembed 
subdir) and remove 
$INSTALL_INTERFACE:${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed from 
target_include_directories.


Summary (updated)
-

Place KJsEmbed headers directly under ${INCLUDE_INSTALL_DIR}/KJsEmbed instead 
of under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed [was: Place KJsEmbed 
camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed]


Repository: kjsembed


Description
---

Currently kjsembed CMake file tries to install both 
${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed (directory) and 
${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed (camel case header). This is not 
allowed in a case-insensitive filesystem, causing the install step to fail on 
Windows.


Diffs (updated)
-

  src/kjsembed/CMakeLists.txt e0ab74c 

Diff: https://git.reviewboard.kde.org/r/117012/diff/


Testing
---

Tested using MSVC 2013


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed

2014-03-30 Thread Andrius da Costa Ribas


 On March 27, 2014, 3:47 p.m., Kevin Ottens wrote:
  src/kjsembed/CMakeLists.txt, line 75
  https://git.reviewboard.kde.org/r/117012/diff/1/?file=256496#file256496line75
 
  Agreed, that should be the preferred way.
  
  Note that some other frameworks probably carry the same mistake

I'll update the patch as per Cristophe's and Aleix's comments.

From what I can see from the frameworks I've built on Windows at the moment 
(all tier1 and most tier2), most of them has 
include/KF5/FrameworkName/headers, except:
Attica (include/KF5/Attica/Attica/headers)
KDNSSD (include/KF5/KDNSSD/DNSSD/headers)
Solid (include/KF5/Solid/Solid/headers)
ThreadWeaver (include/KF5/ThreadWeaver/ThreadWeaver/headers)
*Sonnet (include/Kf5/SonnetCore/Sonnet/headers and 
include/Kf5/SonnetUi/Sonnet/headers)
*KDocTools (include/KF5/XsltKde/headers)

Can we consider fixing those too? (I'm just not sure about the ones I marked 
with *)


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/#review54308
---


On March 24, 2014, 1:33 a.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117012/
 ---
 
 (Updated March 24, 2014, 1:33 a.m.)
 
 
 Review request for KDE Frameworks and kdewin.
 
 
 Repository: kjsembed
 
 
 Description
 ---
 
 Currently kjsembed CMake file tries to install both 
 ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed (directory) and 
 ${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed (camel case header). This is not 
 allowed in a case-insensitive filesystem, causing the install step to fail on 
 Windows.
 
 
 Diffs
 -
 
   src/kjsembed/CMakeLists.txt e0ab74c 
 
 Diff: https://git.reviewboard.kde.org/r/117012/diff/
 
 
 Testing
 ---
 
 Tested using MSVC 2013
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 117011: Use bin/../share on Windows as a workaround

2014-03-23 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117011/
---

Review request for KDE Frameworks and kdewin.


Repository: kdoctools


Description
---

This is a workaround for kdoctools for the same problem discussed in review 
#115210. In particular, emerge installs docbook-dtd data under %KDEROOT%\share.


Diffs
-

  src/xslt.cpp db67599 

Diff: https://git.reviewboard.kde.org/r/117011/diff/


Testing
---

Tested using MSVC 2013. KJsEmbed, which depends on this, builds after this 
patch (KJsEmbed still has an unrelated problem on install step).


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 117012: Place KJsEmbed camelcase header under ${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed

2014-03-23 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117012/
---

Review request for KDE Frameworks and kdewin.


Repository: kjsembed


Description
---

Currently kjsembed CMake file tries to install both 
${INCLUDE_INSTALL_DIR}/KJsEmbed/kjsembed (directory) and 
${INCLUDE_INSTALL_DIR}/KJsEmbed/KJsEmbed (camel case header). This is not 
allowed in a case-insensitive filesystem, causing the install step to fail on 
Windows.


Diffs
-

  src/kjsembed/CMakeLists.txt e0ab74c 

Diff: https://git.reviewboard.kde.org/r/117012/diff/


Testing
---

Tested using MSVC 2013


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115378: Resolve some FIXMEs related to MSVC and Intel

2014-01-29 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115378/#review48547
---


Looks good, but I can't test it right now.



kde-modules/KDECompilerSettings.cmake
https://git.reviewboard.kde.org/r/115378/#comment34310

if(MSVC) is used everywhere else


- Andrius da Costa Ribas


On Jan. 29, 2014, 1:39 p.m., Alex Merry wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115378/
 ---
 
 (Updated Jan. 29, 2014, 1:39 p.m.)
 
 
 Review request for Build System, Extra Cmake Modules, KDE Frameworks, and 
 Andrius da Costa Ribas.
 
 
 Repository: extra-cmake-modules
 
 
 Description
 ---
 
 Resolve some FIXMEs related to MSVC and Intel
 
 In particular, MSVC (and Intel on Windows) have no equivalent of the
 -std flag to set the language standard, and Intel does not appear to
 produce the warnings that were disabled for MSVC.
 
 
 Diffs
 -
 
   kde-modules/KDECompilerSettings.cmake 
 bcc11284d36830963af66f203bc5ea0397afa611 
 
 Diff: https://git.reviewboard.kde.org/r/115378/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Alex Merry
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: C standard

2014-01-28 Thread Andrius da Costa Ribas
MSVC (at least vc2010) is C89 for C code, changing it to C99 on GCC may
lead to changes that break MSVC build (since almost everything is mostly
tested on linux/gcc only).

--
Andrius


2014-01-28 Alex Merry k...@randomguy3.me.uk

 Currently, KDECompilerSettings.cmake in ECM sets -std=iso9899:1990 for C
 code (C90).  Question: do we want to change this to -std=c99?

 Bear in mind that our minimum GCC version (4.2) does not completely
 support this standard.  In particular, the semantics for inline
 functions don't match C99's until GCC 4.3, and there are some corner
 cases for variable length arrays and complex numbers that are not fixed
 until GCC 4.5.

 Obviously, this won't affect that much code, since most of it is C++
 (for which, incidentally, we set -std=c++0x, ie: C++11).

 Alex
 ___
 Kde-frameworks-devel mailing list
 Kde-frameworks-devel@kde.org
 https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115372: Improve the compiler version checks (including requiring GCC 4.5)

2014-01-28 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115372/#review48510
---



kde-modules/KDECompilerSettings.cmake
https://git.reviewboard.kde.org/r/115372/#comment34293

It'd be nice to add an
else()
message(WARNING Unsupported compiler ${CMAKE_CXX_COMPILER_ID})



kde-modules/KDECompilerSettings.cmake
https://git.reviewboard.kde.org/r/115372/#comment34294

elseif() would fit better here.



kde-modules/KDECompilerSettings.cmake
https://git.reviewboard.kde.org/r/115372/#comment34295

else: warn about unsupported compiler



kde-modules/KDECompilerSettings.cmake
https://git.reviewboard.kde.org/r/115372/#comment34297

Unrelated, but for MSVC there are no additional flags. ICL supports the 
same features as MSVC, there is /Qstd=c++11 but only for the features ICL 
supports but MSVC doesn't.
So, this FIXME can be removed.



kde-modules/KDECompilerSettings.cmake
https://git.reviewboard.kde.org/r/115372/#comment34296

Unrelated, but I've check the MSDN examples for these warnings and icl 
raises none of them for these, so these can be done for MSVC only.


- Andrius da Costa Ribas


On Jan. 28, 2014, 11:22 p.m., Alex Merry wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115372/
 ---
 
 (Updated Jan. 28, 2014, 11:22 p.m.)
 
 
 Review request for Build System, Extra Cmake Modules and KDE Frameworks.
 
 
 Repository: extra-cmake-modules
 
 
 Description
 ---
 
 Improve the compiler version checks
 
 - Only warn if the compiler is not recent enough (it may still work...)
 - Bump up the GCC version to 4.5 (on Linux, at least) to match Qt
 - Add checks for Windows (both MSVC and MinGW) that match Qt
 
 
 Diffs
 -
 
   kde-modules/KDECompilerSettings.cmake 
 a4683b04459a2dca1bc5daab0c69c06acbf33ce0 
 
 Diff: https://git.reviewboard.kde.org/r/115372/diff/
 
 
 Testing
 ---
 
 Built KCoreAddons with gcc 4.8.2 on Linux.  Got no warning.
 
 
 Thanks,
 
 Alex Merry
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115344: With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined

2014-01-27 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115344/#review48418
---


We use to do so in the CMake files (as more than one source file may use it).

- Andrius da Costa Ribas


On Jan. 27, 2014, 9:32 p.m., Alexander Richardson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115344/
 ---
 
 (Updated Jan. 27, 2014, 9:32 p.m.)
 
 
 Review request for KDE Frameworks and kdewin.
 
 
 Repository: kunitconversion
 
 
 Description
 ---
 
 With MSVC M_PI only gets defined if _USE_MATH_DEFINES is defined
 
 Is it okay to put the define in the source file, or should I rather put it in 
 the CMake code?
 
 
 Diffs
 -
 
   src/angle.cpp 4df1981930e6459a7d2486caffaee6fd439976d0 
 
 Diff: https://git.reviewboard.kde.org/r/115344/diff/
 
 
 Testing
 ---
 
 didn't compile before, does now
 
 
 Thanks,
 
 Alexander Richardson
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 113670: Link kde4support privately to QtX11Extras, QtSvg and QtTest

2013-11-08 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113670/#review43271
---


Please use X11 stuff conditionally (Q_WS_X11).

- Andrius da Costa Ribas


On Nov. 7, 2013, 8:33 p.m., Alexander Richardson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/113670/
 ---
 
 (Updated Nov. 7, 2013, 8:33 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 Link kde4support privately to QtX11Extras, QtSvg and QtTest
 
 Otherwise every user of the target KF5::KDE4Support will also have
 Qt5::X11Extras Qt5::Svg Qt5::Test linked.
 
 This can cause linker errors like ld: cannot find -lQt5::Test
 
 REVIEW: 113670
 
 
 Diffs
 -
 
   tier4/kde4support/src/kdeui/kxerrorhandler.cpp 
 3f4765d03559c99833c573fe0e0072bc9973b973 
   tier4/kde4support/src/kdeui/kxerrorhandler.h 
 babf931e8a750d405885f02443f4910356511429 
   tier4/kde4support/src/CMakeLists.txt 
 cbfac3e9e4363cb66d0941c9048d8f501311084c 
 
 Diff: http://git.reviewboard.kde.org/r/113670/diff/
 
 
 Testing
 ---
 
 I previously got the following error compiling okteta, now it works:
 /usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: 
 cannot find -lQt5::X11Extras
 /usr/lib64/gcc/x86_64-suse-linux/4.7/../../../../x86_64-suse-linux/bin/ld: 
 cannot find -lQt5::Svg
 
 QtX11Info and QtSvg are not used in any installed headers, so IMO this should 
 be fine
 qtest_kde.h does actually include QtTest headers, but only uses these types 
 inside macros. And I guess any user of that header already also links to 
 QtTest
 
 
 Thanks,
 
 Alexander Richardson
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 113395: Enable KConfig on Windows

2013-10-25 Thread Andrius da Costa Ribas


 On Oct. 23, 2013, 1:25 a.m., Andrius da Costa Ribas wrote:
  tier1/kconfig/src/core/kconfigini.cpp, line 425
  http://git.reviewboard.kde.org/r/113395/diff/1/?file=204894#file204894line425
 
  Files have no owner on Windows. QFileInfo::ownerId() always returns -2 
  on Windows and so would do kdewin's getuid, so here we probably should 
  follow the if part, not the else one.
 
 Andrius da Costa Ribas wrote:
 Oops. Double comment ... I thought the first one hadn't been saved ;)
 
 Alexander Richardson wrote:
 Looks like files do have owners: 
 http://msdn.microsoft.com/en-us/library/windows/desktop/aa446629%28v=vs.85%29.aspx
 
 I guess the correct solution would be to get the owner SID using 
 GetSecurityInfo and then GetTokenInformation to get the current SID and then 
 compare that.

Yes, the SID is the equivalent, however it won't match what Qt does on Windows:
http://doc-snapshot.qt-project.org/qt5-nosubdir/qfileinfo.html#ownerId


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113395/#review42192
---


On Oct. 23, 2013, 12:03 a.m., Alexander Richardson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/113395/
 ---
 
 (Updated Oct. 23, 2013, 12:03 a.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 KConfig now also compiles on Windows
 
 
 the qt3support function QDir::convertSeparators no longer exists
 
 
 remove dependency on unistd.h on Windows
 
 
 fix linking of KSharedConfig on MSVC2012
 
 Without disabling the copy constructor we get an undefined referece to
 KConfig::KConfig(const KConfig)
 
 
 Diffs
 -
 
   tier1/CMakeLists.txt bc5bdaa46414c6c449920f38b0e16cdd1d9d1b9a 
   tier1/kconfig/CMakeLists.txt 4cebdf010c73baf5381e9601072a59ba3f1c0a9f 
   tier1/kconfig/autotests/kconfigtest.cpp 
 022809e9b9ec700206d472ed4cfa5ed82058bc34 
   tier1/kconfig/src/core/kauthorized.cpp 
 c814b729dc9b6e9efd9b3922fa02249abf460989 
   tier1/kconfig/src/core/kconfig.cpp 2d5f4897f2bee8c881205ec3e0ef20f5d9d03564 
   tier1/kconfig/src/core/kconfiggroup.cpp 
 b42ca12e02af1cf173cee97d338cc895b4c822ed 
   tier1/kconfig/src/core/kconfigini.cpp 
 5a7702a76f70d97fe48de8bb16f2a052e993d907 
   tier1/kconfig/src/core/kdesktopfile.cpp 
 7518994ac7a72dc782d9df394e5b466a0cbac5fc 
   tier1/kconfig/src/core/ksharedconfig.h 
 b461999b29a6c966c6a8734b316dbbee11ecdc6c 
 
 Diff: http://git.reviewboard.kde.org/r/113395/diff/
 
 
 Testing
 ---
 
 This is a series of 4 small commits as one patch. I can squash them into one 
 commit if that is preferred.
 
 Everything compiles with VS2012 (64 bit). To get kconfig_compiler to generate 
 the tests I had to add the Qt 5.2 beta binaries dir to PATH since that 
 contains QtCore.dll, etc.
 
 Test don't work due to Windows lacking rpath or LD_LIBRARY_PATH, i.e. the 
 necessary libraries are not found.
 I see two possible solutions: 
 -CMake sets $PATH to include the needed libraries (have to make sure the 
 newly compiled ones are before the installed ones)
 -A wrapper executable sets the DLL search paths and then launches the tests
 
 I don't have the time to solve that problem now, if anyone does:
 
 http://msdn.microsoft.com/en-us/library/windows/desktop/ms682586%28v=vs.85%29.aspx
 http://msdn.microsoft.com/en-us/library/windows/desktop/ms686203%28v=vs.85%29.aspx
 http://msdn.microsoft.com/en-us/library/windows/desktop/hh310513%28v=vs.85%29.aspx
 
 
 Thanks,
 
 Alexander Richardson
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 113395: Enable KConfig on Windows

2013-10-22 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113395/#review42192
---



tier1/kconfig/src/core/kconfigini.cpp
http://git.reviewboard.kde.org/r/113395/#comment30726

Not actually a TODO... fi.ownerId() will always return -2 on Windows (files 
have no owners on Win). Also kdewin's getuid would also return -2.



tier1/kconfig/src/core/kconfigini.cpp
http://git.reviewboard.kde.org/r/113395/#comment30727

Files have no owner on Windows. QFileInfo::ownerId() always returns -2 on 
Windows and so would do kdewin's getuid, so here we probably should follow the 
if part, not the else one.


- Andrius da Costa Ribas


On Oct. 23, 2013, 12:03 a.m., Alexander Richardson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/113395/
 ---
 
 (Updated Oct. 23, 2013, 12:03 a.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 KConfig now also compiles on Windows
 
 
 the qt3support function QDir::convertSeparators no longer exists
 
 
 remove dependency on unistd.h on Windows
 
 
 fix linking of KSharedConfig on MSVC2012
 
 Without disabling the copy constructor we get an undefined referece to
 KConfig::KConfig(const KConfig)
 
 
 Diffs
 -
 
   tier1/CMakeLists.txt bc5bdaa46414c6c449920f38b0e16cdd1d9d1b9a 
   tier1/kconfig/CMakeLists.txt 4cebdf010c73baf5381e9601072a59ba3f1c0a9f 
   tier1/kconfig/autotests/kconfigtest.cpp 
 022809e9b9ec700206d472ed4cfa5ed82058bc34 
   tier1/kconfig/src/core/kauthorized.cpp 
 c814b729dc9b6e9efd9b3922fa02249abf460989 
   tier1/kconfig/src/core/kconfig.cpp 2d5f4897f2bee8c881205ec3e0ef20f5d9d03564 
   tier1/kconfig/src/core/kconfiggroup.cpp 
 b42ca12e02af1cf173cee97d338cc895b4c822ed 
   tier1/kconfig/src/core/kconfigini.cpp 
 5a7702a76f70d97fe48de8bb16f2a052e993d907 
   tier1/kconfig/src/core/kdesktopfile.cpp 
 7518994ac7a72dc782d9df394e5b466a0cbac5fc 
   tier1/kconfig/src/core/ksharedconfig.h 
 b461999b29a6c966c6a8734b316dbbee11ecdc6c 
 
 Diff: http://git.reviewboard.kde.org/r/113395/diff/
 
 
 Testing
 ---
 
 This is a series of 4 small commits as one patch. I can squash them into one 
 commit if that is preferred.
 
 Everything compiles with VS2012 (64 bit). To get kconfig_compiler to generate 
 the tests I had to add the Qt 5.2 beta binaries dir to PATH since that 
 contains QtCore.dll, etc.
 
 Test don't work due to Windows lacking rpath or LD_LIBRARY_PATH, i.e. the 
 necessary libraries are not found.
 I see two possible solutions: 
 -CMake sets $PATH to include the needed libraries (have to make sure the 
 newly compiled ones are before the installed ones)
 -A wrapper executable sets the DLL search paths and then launches the tests
 
 I don't have the time to solve that problem now, if anyone does:
 
 http://msdn.microsoft.com/en-us/library/windows/desktop/ms682586%28v=vs.85%29.aspx
 http://msdn.microsoft.com/en-us/library/windows/desktop/ms686203%28v=vs.85%29.aspx
 http://msdn.microsoft.com/en-us/library/windows/desktop/hh310513%28v=vs.85%29.aspx
 
 
 Thanks,
 
 Alexander Richardson
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 113395: Enable KConfig on Windows

2013-10-22 Thread Andrius da Costa Ribas


 On Oct. 23, 2013, 1:25 a.m., Andrius da Costa Ribas wrote:
  tier1/kconfig/src/core/kconfigini.cpp, line 425
  http://git.reviewboard.kde.org/r/113395/diff/1/?file=204894#file204894line425
 
  Files have no owner on Windows. QFileInfo::ownerId() always returns -2 
  on Windows and so would do kdewin's getuid, so here we probably should 
  follow the if part, not the else one.

Oops. Double comment ... I thought the first one hadn't been saved ;)


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113395/#review42192
---


On Oct. 23, 2013, 12:03 a.m., Alexander Richardson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/113395/
 ---
 
 (Updated Oct. 23, 2013, 12:03 a.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 KConfig now also compiles on Windows
 
 
 the qt3support function QDir::convertSeparators no longer exists
 
 
 remove dependency on unistd.h on Windows
 
 
 fix linking of KSharedConfig on MSVC2012
 
 Without disabling the copy constructor we get an undefined referece to
 KConfig::KConfig(const KConfig)
 
 
 Diffs
 -
 
   tier1/CMakeLists.txt bc5bdaa46414c6c449920f38b0e16cdd1d9d1b9a 
   tier1/kconfig/CMakeLists.txt 4cebdf010c73baf5381e9601072a59ba3f1c0a9f 
   tier1/kconfig/autotests/kconfigtest.cpp 
 022809e9b9ec700206d472ed4cfa5ed82058bc34 
   tier1/kconfig/src/core/kauthorized.cpp 
 c814b729dc9b6e9efd9b3922fa02249abf460989 
   tier1/kconfig/src/core/kconfig.cpp 2d5f4897f2bee8c881205ec3e0ef20f5d9d03564 
   tier1/kconfig/src/core/kconfiggroup.cpp 
 b42ca12e02af1cf173cee97d338cc895b4c822ed 
   tier1/kconfig/src/core/kconfigini.cpp 
 5a7702a76f70d97fe48de8bb16f2a052e993d907 
   tier1/kconfig/src/core/kdesktopfile.cpp 
 7518994ac7a72dc782d9df394e5b466a0cbac5fc 
   tier1/kconfig/src/core/ksharedconfig.h 
 b461999b29a6c966c6a8734b316dbbee11ecdc6c 
 
 Diff: http://git.reviewboard.kde.org/r/113395/diff/
 
 
 Testing
 ---
 
 This is a series of 4 small commits as one patch. I can squash them into one 
 commit if that is preferred.
 
 Everything compiles with VS2012 (64 bit). To get kconfig_compiler to generate 
 the tests I had to add the Qt 5.2 beta binaries dir to PATH since that 
 contains QtCore.dll, etc.
 
 Test don't work due to Windows lacking rpath or LD_LIBRARY_PATH, i.e. the 
 necessary libraries are not found.
 I see two possible solutions: 
 -CMake sets $PATH to include the needed libraries (have to make sure the 
 newly compiled ones are before the installed ones)
 -A wrapper executable sets the DLL search paths and then launches the tests
 
 I don't have the time to solve that problem now, if anyone does:
 
 http://msdn.microsoft.com/en-us/library/windows/desktop/ms682586%28v=vs.85%29.aspx
 http://msdn.microsoft.com/en-us/library/windows/desktop/ms686203%28v=vs.85%29.aspx
 http://msdn.microsoft.com/en-us/library/windows/desktop/hh310513%28v=vs.85%29.aspx
 
 
 Thanks,
 
 Alexander Richardson
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 112037: Replace most instances of KFileDialog with QFileDialog

2013-08-15 Thread Andrius da Costa Ribas


 On Aug. 13, 2013, 7:25 a.m., Kevin Ottens wrote:
 

Small question: by replacing KFileDialog by QFileDialog do we still provide the 
settings to choose whether to use Native or KDE dialog on Windows? I use the 
KDE one here because of the places panel where I have lots of SFTP/FTP/SMB 
places defined.


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112037/#review37641
---


On Aug. 15, 2013, 3:36 p.m., Teo Mrnjavac wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/112037/
 ---
 
 (Updated Aug. 15, 2013, 3:36 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Description
 ---
 
 KFileDialog is deprecated in favor of QFileDialog. The original intention was 
 to completely replace the former with the latter and move KFileDialog to 
 kde4support.
 kdelibs cleanup task: Move KFileDialog to kde4support once the QUrl static 
 methods are in Qt (see the 5.1 epic)   
 Unfortunately, it turned out that KEncodingFileDialog inherits from 
 KFileDialog, and is still used in a bunch of places, making the complete 
 removal of KFileDialog impractical.
 
 With this all uses of KFileDialog are removed, except for KEncodingFileDialog.
 
 
 Diffs
 -
 
   kfile/kdirselectdialog.cpp dcbcc4cf743bad17cfa520def611445ceb31eb21 
   kio/kfile/kfiledialog.h 216dcc8b41e3a9027b2a94b307d6c6374ee53c51 
   kio/kfile/kpropertiesdialog.cpp 995e962353a09e40f627f2db60ce831b46b6a414 
   kio/kfile/kurlrequester.h bb111271b6d6b7b1fd66a4b5f13d9f0aa499289f 
   kio/kfile/kurlrequester.cpp 523ae7a3bec64a3d997a255899cb15a8fdc5689e 
   kio/kfile/kurlrequesterdialog.h 2e515b23060748e632cc96eed4a2305f67ebb40e 
   kio/kfile/kurlrequesterdialog.cpp b0afd16388dab56b0a1127dd6e8921476196f234 
   kio/kssl/kcm/cacertificatespage.cpp 
 8b35c2a73f0f2caa3e385568d32428fdbb00bba4 
   kparts/browserrun.cpp ff3a5fd1220cf0be3c8775cf97f204f3a26300d0 
   kross/ui/view.cpp 51f31c5bc247d385c685cf91a94c48a0ed855532 
 
 Diff: http://git.reviewboard.kde.org/r/112037/diff/
 
 
 Testing
 ---
 
 Does not break any tests.
 
 
 Thanks,
 
 Teo Mrnjavac
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 105868: KF5 - Q_OS_* not defined

2013-02-06 Thread Andrius da Costa Ribas


 On Feb. 6, 2013, 11:14 p.m., Albert Astals Cid wrote:
  Has this been committed? It has Ship It! but still shows open in 
  reviewboard.

I'm currently having almost no time, I'd be grateful if someone commits it on 
behalf of me.


- Andrius da Costa


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105868/#review26802
---


On Aug. 5, 2012, 10:28 p.m., Andrius da Costa Ribas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/105868/
 ---
 
 (Updated Aug. 5, 2012, 10:28 p.m.)
 
 
 Review request for KDE Frameworks and kdewin.
 
 
 Description
 ---
 
 Q_OS_WIN  Q_OS_MAC not defined at that point, replacing with WIN32 and APPLE.
 
 
 Diffs
 -
 
   kde3support/KDE3SupportMacros.cmake a4f44e2 
   kdecore/CMakeLists.txt e5cbd19 
   kded/CMakeLists.txt fb204e8 
   kdeui/CMakeLists.txt 7849b52 
   kdeui/KDEUIMacros.cmake d5c20d9 
   kinit/CMakeLists.txt 3c283a6 
   tier1/kidletime/src/CMakeLists.txt 973d623 
   tier1/kwindowsystem/src/CMakeLists.txt 96cb3dd 
 
 Diff: http://git.reviewboard.kde.org/r/105868/diff/
 
 
 Testing
 ---
 
 Got undefined references before the fix.
 
 
 Thanks,
 
 Andrius da Costa Ribas
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request: KF5 - Q_OS_* not defined

2012-08-06 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105868/
---

(Updated Aug. 5, 2012, 10:25 p.m.)


Review request for KDE Frameworks and kdewin.


Changes
---

Updated patch to fix other occurrences.


Description
---

Q_OS_WIN  Q_OS_MAC not defined at that point, replacing with WIN32 and APPLE.


Diffs (updated)
-

  kde3support/KDE3SupportMacros.cmake a4f44e2 
  kdecore/CMakeLists.txt e5cbd19 
  kded/CMakeLists.txt fb204e8 
  kdeui/CMakeLists.txt 7849b52 
  kdeui/KDEUIMacros.cmake d5c20d9 
  kinit/CMakeLists.txt 3c283a6 
  tier1/kidletime/src/CMakeLists.txt 973d623 
  tier1/kwindowsystem/src/CMakeLists.txt 96cb3dd 

Diff: http://git.reviewboard.kde.org/r/105868/diff/


Testing
---

Got undefined references before the fix.


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request: KF5 - Q_OS_* not defined

2012-08-06 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105868/
---

(Updated Aug. 5, 2012, 10:28 p.m.)


Review request for KDE Frameworks and kdewin.


Changes
---

Oops ... last one had something wrong.


Description
---

Q_OS_WIN  Q_OS_MAC not defined at that point, replacing with WIN32 and APPLE.


Diffs (updated)
-

  kde3support/KDE3SupportMacros.cmake a4f44e2 
  kdecore/CMakeLists.txt e5cbd19 
  kded/CMakeLists.txt fb204e8 
  kdeui/CMakeLists.txt 7849b52 
  kdeui/KDEUIMacros.cmake d5c20d9 
  kinit/CMakeLists.txt 3c283a6 
  tier1/kidletime/src/CMakeLists.txt 973d623 
  tier1/kwindowsystem/src/CMakeLists.txt 96cb3dd 

Diff: http://git.reviewboard.kde.org/r/105868/diff/


Testing
---

Got undefined references before the fix.


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request: libinqt5 - Windows fixes

2012-08-04 Thread Andrius da Costa Ribas

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105867/
---

Review request for KDE Frameworks and kdewin.


Description
---

General fixes for Windows build. Replaced some references to Qt5 libraries into 
the Qt4 equivalent ones.


Diffs
-

  libinqt5/src/CMakeLists.txt 99f75e5 
  libinqt5/src/qstandardpaths.cpp f97a861 
  libinqt5/src/qstandardpaths_win.cpp 478e614 
  libinqt5/src/qtemporarydir.cpp 6121a83 

Diff: http://git.reviewboard.kde.org/r/105867/diff/


Testing
---

Build OK with MSVC. No further tests because of other issues with other parts 
of KF5 build.


Thanks,

Andrius da Costa Ribas

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel