Re: Frameworks 6.1 tars available

2024-04-08 Thread Antonio Rojas
El viernes, 5 de abril de 2024 13:31:32 (CEST), Jonathan Riddell escribió: > Tars for KDE Frameworks 6.1 are available for pre-release packaging, > release is due next Friday 12 April Hello, Please consider a respin of extra-cmake-modules to include 7e68938f075a0423e3744358be9c4e77c6922104 It

Re: KF6 overlapping files

2023-10-15 Thread Antonio Rojas
El miércoles, 6 de septiembre de 2023 0:13:32 (CEST) Christophe Marin escribió: > On mardi 11 juillet 2023 10:13:16 CEST Jonathan Riddell wrote: > > I thought I'd give an update on current overlapping files since our > > automated setup isn't running just now.. > > As of 15/10, there are still

D26815: Fix python bindings build after ebd14f29f8052ff5119bf97b42e61f404f223615

2020-01-21 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R237:68c1cfd0d8dc: Fix python bindings build after ebd14f29f8052ff5119bf97b42e61f404f223615 (authored by arojas). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D26815: Fix python bindings build after ebd14f29f8052ff5119bf97b42e61f404f223615

2020-01-21 Thread Antonio Rojas
arojas created this revision. arojas added reviewers: nicolasfella, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY The new API breaks python bindings compilation since sip can't understand

D26431: Fix build of python bindings for kcolumnheadersmodel

2020-01-05 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R275:89e24bd88ea7: Fix build of python bindings for kcolumnheadersmodel (authored by arojas). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26431?vs=72789=72791

D26431: Fix build of python bindings for kcolumnheadersmodel

2020-01-05 Thread Antonio Rojas
arojas created this revision. arojas added reviewers: dfaure, ahiemstra, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Replace QModelIndex{} with QModelIndex() to make sip happy.

D26430: Fix Python bindings compilation after 7ab8275bdb56882692846d046a5bbeca5795b009

2020-01-05 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R237:171a2c26d280: Fix Python bindings compilation after 7ab8275bdb56882692846d046a5bbeca5795b009 (authored by arojas). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D26430: Fix Python bindings compilation after 7ab8275bdb56882692846d046a5bbeca5795b009

2020-01-05 Thread Antonio Rojas
arojas created this revision. arojas added reviewers: davidedmundson, broulik, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Exclude the new function from the sip parser TEST PLAN Python

D25833: Expose getter to KConfigWatcher's config

2020-01-04 Thread Antonio Rojas
arojas added a comment. This breaks compilation of python bindings: sip: /build/kconfig/src/build/src/core/sip/PyKF5/KConfigCore/kconfigwatcher.sip:17: ::KConfigWatcher::config() unsupported function return type - provide %MethodCode and a C++ signature REPOSITORY R237 KConfig

D25972: Support PyQt5 compiled with SIP 5

2019-12-15 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R240:7c84be59f686: Support PyQt5 compiled with SIP 5 (authored by arojas). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25972?vs=71563=71574 REVISION

D25972: Support PyQt5 compiled with SIP 5

2019-12-14 Thread Antonio Rojas
arojas marked an inline comment as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D25972 To: arojas, bruns, dfaure Cc: apol, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D25972: Support PyQt5 compiled with SIP 5

2019-12-14 Thread Antonio Rojas
arojas updated this revision to Diff 71563. arojas added a comment. Use HINTS REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25972?vs=71481=71563 REVISION DETAIL https://phabricator.kde.org/D25972 AFFECTED FILES

D25972: Support PyQt5 compiled with SIP 5

2019-12-13 Thread Antonio Rojas
arojas created this revision. arojas added reviewers: bruns, dfaure. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY When PyQt5 is compiled with SIP 5, the sip files are

D25304: Fix the OpenEXR >= 2.4 detection

2019-11-14 Thread Antonio Rojas
arojas added a comment. > The pkgconfig file disagrees: > it contains `libsuffix=-2_4` and later `Libs: -L${libdir} -lIlmImf${libsuffix}` > For me, that library name is correct I didn't say that the suffixed .so shouldn't exist. They are *both* supposed to be installed: the

D25304: Fix the OpenEXR >= 2.4 detection

2019-11-14 Thread Antonio Rojas
arojas added a comment. > I don't see how that commit is related. > openEXR 2.3 installs libXXX.so and 2.4 installs libXXX-2_4.so > > This is expected afaics. No, it's not. That line in openexr is supposed to link libXXX-2_4.so (${verlibname}) to libXXX.so (${baselibname}) but it

D25304: Fix the OpenEXR >= 2.4 detection

2019-11-14 Thread Antonio Rojas
arojas added a comment. This is a bug in openexr. It does actually try to install the unprefixed symlinks, but it doesn't take DESTDIR into account, so it tries to install them to the root filesystem instead of doing so inside DESTDIR as it should. It is fixed in

D25159: Fix linking to libssh 0.9.1

2019-11-05 Thread Antonio Rojas
arojas abandoned this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25159 To: arojas, apol, sitter, fvogt Cc: fvogt, sitter, asn, apol, asturmlechner, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde,

D25159: Fix linking to libssh 0.9.1

2019-11-05 Thread Antonio Rojas
arojas retitled this revision from "Fix linking to libssh 0.9" to "Fix linking to libssh 0.9.1". arojas edited the summary of this revision. arojas edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25159 To: arojas Cc:

D25159: Fix linking to libssh 0.9

2019-11-05 Thread Antonio Rojas
arojas created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY libssh 0.9 no longer defines LIBSSH_LIBRARIES in its cmake config, and exports a ssh_shared target

D24554: Don't build static library when BUILD_TESTING=OFF

2019-10-11 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R245:f436762fb366: Dont build static library when BUILD_TESTING=OFF (authored by arojas). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24554?vs=67674=67705 REVISION

D24554: Don't build static library when BUILD_TESTING=OFF

2019-10-11 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Since the static library is only used for autotests, don't waste CPU cycles when

D24020: Support NetworkManager 1.20 and do actually compile the NM backend

2019-09-22 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R239:ec475441f61e: Support NetworkManager 1.20 and do actually compile the NM backend (authored by arojas). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE

D24020: Support NetworkManager 1.20 and do actually compile the NM backend

2019-09-21 Thread Antonio Rojas
arojas added a reviewer: Frameworks. REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D24020 To: arojas, #frameworks Cc: lbeltrame, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24020: Support NetworkManager 1.20 and do actually compile the NM backend

2019-09-17 Thread Antonio Rojas
arojas updated this revision to Diff 66288. arojas retitled this revision from "Support NetworkManager 1.20" to "Support NetworkManager 1.20 and do actually compile the NM backend". arojas edited the summary of this revision. REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE

D24020: Support NetworkManager 1.20

2019-09-17 Thread Antonio Rojas
arojas added a comment. Indeed, after removing the NM_0_7 check this doesn't even compile... REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D24020 To: arojas Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24020: Support NetworkManager 1.20

2019-09-17 Thread Antonio Rojas
arojas added a comment. Actually I don't think this ever worked - the NM include is guarded by an if(NM_0_7), and this is not defined anywhere REPOSITORY R239 KDELibs4Support REVISION DETAIL https://phabricator.kde.org/D24020 To: arojas Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24020: Support NetworkManager 1.20

2019-09-17 Thread Antonio Rojas
arojas created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY NetworkManager.pc and libnm-util.pc are no longer available in 1.20. The only header that kdelibs4support is using is

D23946: Remove dependency on kdesignerplugin

2019-09-14 Thread Antonio Rojas
arojas added a comment. Does that really justify a hard dependency? It would make more sense for the dependency to be moved to the projects that do use the macro. extra-cmake-modules ships macros that call sip or doxygen and it doesn't hard depend on them. REPOSITORY R239 KDELibs4Support

D23946: Remove dependency on kdesignerplugin

2019-09-14 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: kossebau. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Not sure what the reason was to have it here in the first place, but it doesn't seem

D23815: [KConfig] port away from deprecated methods in Qt 5.14

2019-09-10 Thread Antonio Rojas
arojas added a comment. In D23815#528369 , @mlaurent wrote: > Why you don't add add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x06) in cmake toplevel ? > or 5.14 value ? so we can be sure that it builds without deprecated method until

D23497: Keep 'lib' as default libdir on Arch Linux based systems

2019-08-27 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R240:c806bd48a29f: Keep lib as default LIBDIR on Arch Linux based systems (authored by arojas). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D23483: Fix section hierachy in distributing.md

2019-08-27 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R293:33e042970075: Fix section hierachy in distributing.md (authored by arojas). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23483?vs=64721=64754 REVISION DETAIL

D23497: Keep 'lib' as default libdir on Arch Linux based systems

2019-08-27 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: apol. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Port of upstream commit

D23483: Fix section hierachy in distributing.md

2019-08-27 Thread Antonio Rojas
arojas created this revision. arojas added reviewers: bruns, kossebau. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Fixes QCH build with doxygen 1.8.16, which seems to be more strict

D22918: Include ECMGeneratePriFile after KDEInstallDirs

2019-08-04 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R307:333e21fd4ae1: Include KDE* cmake macros first (authored by arojas). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22918?vs=63057=63065 REVISION DETAIL

D22915: Include ECMGeneratePriFile after KDEInstallDirs

2019-08-04 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R280:003f15910475: Include KDE* cmake macros first (authored by arojas). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22915?vs=63054=63064 REVISION DETAIL

D22916: Include ECMGeneratePriFile after KDEInstallDirs

2019-08-04 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R216:1ad9586d1d90: Include KDE* cmake macros first (authored by arojas). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22916?vs=63056=63063 REVISION

D22919: Include ECMGeneratePriFile after KDEInstallDirs

2019-08-04 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R312:a9aa17a7b681: Include ECMGeneratePriFile after KDEInstallDirs (authored by arojas). REPOSITORY R312 KXmlRpcClient CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22919?vs=63058=63062

D22919: Include ECMGeneratePriFile after KDEInstallDirs

2019-08-04 Thread Antonio Rojas
arojas updated this revision to Diff 63058. arojas added a reviewer: kossebau. arojas added a comment. Implement kossebau's suggestion from D22915 REPOSITORY R312 KXmlRpcClient CHANGES SINCE LAST UPDATE

D22918: Include ECMGeneratePriFile after KDEInstallDirs

2019-08-04 Thread Antonio Rojas
arojas updated this revision to Diff 63057. arojas added a comment. Implement kossebau's suggestion from D22915 REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22918?vs=63045=63057 REVISION DETAIL

D22918: Include ECMGeneratePriFile after KDEInstallDirs

2019-08-04 Thread Antonio Rojas
arojas added a reviewer: kossebau. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22918 To: arojas, apol, kossebau Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22916: Include ECMGeneratePriFile after KDEInstallDirs

2019-08-04 Thread Antonio Rojas
arojas updated this revision to Diff 63056. arojas added a reviewer: kossebau. arojas added a comment. Implement kossebau's suggestion from D22915 REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D22915: Include ECMGeneratePriFile after KDEInstallDirs

2019-08-04 Thread Antonio Rojas
arojas updated this revision to Diff 63054. arojas added a reviewer: kossebau. arojas added a comment. Implement kossebau's suggestion REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22915?vs=63042=63054 REVISION DETAIL https://phabricator.kde.org/D22915

D22919: Include ECMGeneratePriFile after KDEInstallDirs

2019-08-04 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY ECMGeneratePriFile uses KDE_INSTALL_USE_QT_SYS_PATH, which is initialized in

D22918: Include ECMGeneratePriFile after KDEInstallDirs

2019-08-04 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY ECMGeneratePriFile uses KDE_INSTALL_USE_QT_SYS_PATH, which is initialized in

D22916: Include ECMGeneratePriFile after KDEInstallDirs

2019-08-04 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: apol. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. arojas requested review of this revision. REVISION SUMMARY ECMGeneratePriFile uses KDE_INSTALL_USE_QT_SYS_PATH, which is

D22915: Include ECMGeneratePriFile after KDEInstallDirs

2019-08-04 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY ECMGeneratePriFile uses KDE_INSTALL_USE_QT_SYS_PATH, which is initialized in

D22750: CMakeLists.txt: Allow setting UDEV_RULES_INSTALL_DIR when building

2019-07-25 Thread Antonio Rojas
arojas added a comment. Why is this needed? This is working already as is (that's what the CACHE flag is for) REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D22750 To: alistairf, drosca Cc: arojas, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham,

D22314: Don't try to generate python bindings for kmodifierkeyinfoprovider_p.h

2019-07-07 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R273:071048e32a89: Dont try to generate python bindings for kmodifierkeyinfoprovider_p.h (authored by arojas). REPOSITORY R273 KGuiAddons CHANGES SINCE LAST UPDATE

D22314: Don't try to generate python bindings for kmodifierkeyinfoprovider_p.h

2019-07-07 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Since KF 5.60 kmodifierkeyinfoprovider_p.h depends on QSharedData, which is not wrapped

D18222: Don't hardcode dbus policy install dir

2019-05-12 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R283:34501bceed1d: Dont hardcode dbus policy install dir (authored by arojas). REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18222?vs=57942=57959 REVISION DETAIL

D18222: Don't hardcode dbus policy install dir

2019-05-12 Thread Antonio Rojas
arojas retitled this revision from "Install dbus configuration files under DATADIR by default" to "Don't hardcode dbus policy install dir". arojas edited the summary of this revision. REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D18222 To: arojas, #frameworks Cc:

D18222: Install dbus configuration files under DATADIR by default

2019-05-12 Thread Antonio Rojas
arojas updated this revision to Diff 57942. arojas added a comment. Use non-deprecated variable REPOSITORY R283 KAuth CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18222?vs=49376=57942 REVISION DETAIL https://phabricator.kde.org/D18222 AFFECTED FILES

D19821: Fix breeze dialog background with Qt 5.12.2

2019-03-17 Thread Antonio Rojas
arojas added a comment. Apparently tooltips need a fix too https://bbs.archlinux.org/viewtopic.php?pid=1837417#p1837417 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19821 To: fvogt, #plasma Cc: arojas, rikmills, asturmlechner,

D19699: [DataModel] Add nullptr check

2019-03-12 Thread Antonio Rojas
arojas added a comment. There's D19698 already REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19699 To: broulik, #plasma, mlaurent, arojas Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19418: Make it compiles without deprecated method

2019-03-11 Thread Antonio Rojas
arojas added a comment. This is making Plasma crash, see https://bugs.kde.org/show_bug.cgi?id=405351 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D19418 To: mlaurent, dfaure, apol Cc: arojas, kde-frameworks-devel, michaelh, ngraham, bruns

D18680: Fix ENABLE_CLAZY option with clazy >= 1.5

2019-02-02 Thread Antonio Rojas
arojas added a comment. You also need to change '-Xclang -add-plugin -Xclang clang-lazy' to '-Xclang -add-plugin -Xclang clazy' for the plugin to be actually loaded. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D18680 To: elvisangelaccio, apol,

D18222: Install dbus configuration files under DATADIR by default

2019-01-13 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY Packages should install their configuration files under DATADIR, SYSCONFDIR should

D12761: Allow building kio-nfs against standalone libtirpc

2018-11-27 Thread Antonio Rojas
arojas abandoned this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D12761 To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux Cc: kde-frameworks-devel, kfm-devel, cgiboudeaux, ngraham, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales,

D12761: Allow building kio-nfs against standalone libtirpc

2018-11-27 Thread Antonio Rojas
arojas added a comment. @asturmlechner can you post that in a new review request? I'll abandon this one. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D12761 To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux Cc: kde-frameworks-devel, kfm-devel,

D15091: Compile python bindings with the same sip flags used by PyQt

2018-09-30 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R240:05bd97492704: Compile python bindings with the same sip flags used by PyQt (authored by arojas). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D15091: Compile python bindings with the same sip flags used by PyQt

2018-09-21 Thread Antonio Rojas
arojas updated this revision to Diff 42116. arojas added a comment. Rebase REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15091?vs=40570=42116 REVISION DETAIL https://phabricator.kde.org/D15091 AFFECTED FILES

D14915: Bindings: Check if bindings can be generated for a specific python version

2018-08-31 Thread Antonio Rojas
arojas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14915 To: bruns, #frameworks, arojas Cc: arojas, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14914: Bindings: Use python version matching the found clang python module

2018-08-31 Thread Antonio Rojas
arojas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14914 To: bruns, #frameworks, arojas Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D14912: Bindings: Make generator forward compatible with Python 3

2018-08-31 Thread Antonio Rojas
arojas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14912 To: bruns, #frameworks, arojas Cc: arojas, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15091: Compile python bindings with the same sip flags used by PyQt

2018-08-28 Thread Antonio Rojas
arojas updated this revision to Diff 40570. arojas retitled this revision from "Compile python bindings with the same sipname used by PyQt" to "Compile python bindings with the same sip flags used by PyQt". arojas edited the summary of this revision. REPOSITORY R240 Extra CMake Modules

D15091: Compile python bindings with the same sipname used by PyQt

2018-08-28 Thread Antonio Rojas
arojas planned changes to this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15091 To: arojas, #frameworks, bruns Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15091: Compile python bindings with the same sipname used by PyQt

2018-08-28 Thread Antonio Rojas
arojas added a comment. In D15091#316243 , @rdieter wrote: > I was asking mostly because that's what pyqt upstream strongly suggested (to use all sip_flags) when I asked them. Oh, if upstream recommends it then I guess it should cause no

D15091: Compile python bindings with the same sipname used by PyQt

2018-08-27 Thread Antonio Rojas
arojas added a comment. In D15091#316150 , @rdieter wrote: > Why are you simply not using all PYQT_CONFIGURATION["sip_flags"]? Not sure if we really want to do this. For instance, bindings would get tagged with the Qt version that PyQt

D15091: Compile python bindings with the same sipname used by PyQt

2018-08-26 Thread Antonio Rojas
arojas added inline comments. INLINE COMMENTS > bruns wrote in run-sip.py:11 > Is there a gurantee `-n` and its arg are space separated? > > otherwise: > > import re > m = re.search('-n\s*(\S+)', PYQT_CONFIGURATION["sip_flags"]) > if m: > sipArgs = ['-n', m.group(1)] + sipArgs I

D15091: Compile python bindings with the same sipname used by PyQt

2018-08-26 Thread Antonio Rojas
arojas marked an inline comment as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15091 To: arojas, #frameworks, bruns Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15091: Compile python bindings with the same sipname used by PyQt

2018-08-26 Thread Antonio Rojas
arojas updated this revision to Diff 40479. arojas added a comment. Use a regex to account for the case where -n an its arg are not space-separated REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15091?vs=40477=40479 REVISION DETAIL

D15091: Compile python bindings with the same sipname used by PyQt

2018-08-26 Thread Antonio Rojas
arojas created this revision. arojas added reviewers: Frameworks, bruns. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY PyQt>=5.11 is compiled with the 'PyQt5.sip'

D14912: Bindings: Make generator forward compatible with Python 3

2018-08-26 Thread Antonio Rojas
arojas added a comment. In D14912#315763 , @bruns wrote: > Thats on Arch? Yes REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14912 To: bruns, #frameworks Cc: arojas, kde-frameworks-devel,

D14912: Bindings: Make generator forward compatible with Python 3

2018-08-26 Thread Antonio Rojas
arojas added a comment. With this + D14914 + D14915 I can successfully compile bindings without having any python2 package installed. REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D14915: Bindings: Check if bindings can be generated for a specific python version

2018-08-26 Thread Antonio Rojas
arojas added a comment. sip.h is python version agnostic, and in fact we install it under /usr/include. Would it be possible to also check this path? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14915 To: bruns, #frameworks Cc: arojas,

D14912: Bindings: Make generator forward compatible with Python 3

2018-08-25 Thread Antonio Rojas
arojas added a comment. Python3 still can't be used after this change: python2 is explicitely required at FindPythonModuleGeneration.cmake:177 (and all subsequent calls to sip_generator.py are done with ${GPB_PYTHON2_COMMAND}). This can be adjusted in another review though. REPOSITORY

D14912: Bindings: Make generator forward compatible with Python 3

2018-08-18 Thread Antonio Rojas
arojas added a comment. This adds a new build time dependency to all frameworks which support bindings. Any chance to simply port it to python 3 instead? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D14912 To: bruns, #frameworks Cc: arojas,

D13990: Honor BUILD_TESTING

2018-07-19 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R308:a3847124d53f: Honor BUILD_TESTING (authored by arojas). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13990?vs=37370=38061 REVISION DETAIL

D14124: Fix qtplugins in KStandardDirs

2018-07-15 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R239:3ab2e2f5592d: Fix qtplugins in KStandardDirs (authored by arojas). REPOSITORY R239 KDELibs4Support CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14124?vs=37785=37794 REVISION DETAIL

D14124: Fix qtplugins in KStandardDirs

2018-07-15 Thread Antonio Rojas
arojas created this revision. arojas added a reviewer: dfaure. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY PLUGIN_INSTALL_DIR already contains the /plugins/

D13808: Fix KMainWindow saving incorrect widget settings

2018-07-14 Thread Antonio Rojas
arojas added a comment. This has been approved for two weeks and fixes a major issue... could the fix be pushed and then keep working on the auto test later? It already missed 5.48 REPOSITORY R263 KXmlGui BRANCH fix-window-state-save REVISION DETAIL https://phabricator.kde.org/D13808

D13973: Honor BUILD_TESTING

2018-07-10 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R296:fdd04af53dae: Honor BUILD_TESTING (authored by arojas). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13973?vs=37347=37515 REVISION DETAIL

D13982: Honor BUILD_TESTING

2018-07-10 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R242:061588dcd6cc: Honor BUILD_TESTING (authored by arojas). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13982?vs=37359=37514 REVISION DETAIL

D13957: Honor BUILD_TESTING

2018-07-10 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R302:f059164f8aba: Honor BUILD_TESTING (authored by arojas). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13957?vs=37324=37513 REVISION DETAIL

D13944: Honor BUILD_TESTING

2018-07-10 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R238:6303431a9405: Honor BUILD_TESTING (authored by arojas). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13944?vs=37310=37512 REVISION DETAIL

D13965: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R311:fd8f94d86359: Honor BUILD_TESTING (authored by arojas). REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13965?vs=37333=37417 REVISION DETAIL

D13983: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R314:2d4d34b5ef32: Honor BUILD_TESTING (authored by arojas). REPOSITORY R314 KJs CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13983?vs=37361=37416 REVISION DETAIL

D13976: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R292:6e1110f1df1e: Honor BUILD_TESTING (authored by arojas). REPOSITORY R292 KUnitConversion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13976?vs=37350=37415 REVISION DETAIL

D13975: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R291:d962a0d04275: Honor BUILD_TESTING (authored by arojas). REPOSITORY R291 KPty CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13975?vs=37349=37413 REVISION DETAIL

D13959: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R263:3a058181c8ef: Honor BUILD_TESTING (authored by arojas). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13959?vs=37326=37410 REVISION DETAIL

D13964: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R289:4bf77fb4eb99: Honor BUILD_TESTING (authored by arojas). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13964?vs=37332=37411 REVISION DETAIL

D13963: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R288:08d6672f5928: Honor BUILD_TESTING (authored by arojas). REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13963?vs=37331=37409 REVISION DETAIL

D13962: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R245:94b5c7e0dd40: Honor BUILD_TESTING (authored by arojas). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13962?vs=37330=37408 REVISION DETAIL

D13960: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R294:54ed625ac551: Honor BUILD_TESTING (authored by arojas). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13960?vs=37327=37407 REVISION DETAIL

D13956: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R276:0bfc8d73ab03: Honor BUILD_TESTING (authored by arojas). REPOSITORY R276 KItemViews CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13956?vs=37323=37406 REVISION DETAIL

D13955: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R268:55377a85a70f: Honor BUILD_TESTING (authored by arojas). REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13955?vs=37322=37405 REVISION DETAIL

D13954: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R271:4349c759a4e4: Honor BUILD_TESTING (authored by arojas). REPOSITORY R271 KDBusAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13954?vs=37321=37403 REVISION DETAIL

D13953: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R285:d1094af0e34c: Honor BUILD_TESTING (authored by arojas). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13953?vs=37320=37402 REVISION DETAIL

D13952: Honor BUILD_TESTING

2018-07-08 Thread Antonio Rojas
This revision was automatically updated to reflect the committed changes. Closed by commit R278:432169e7acc8: Honor BUILD_TESTING (authored by arojas). REPOSITORY R278 KWindowSystem CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13952?vs=37319=37401 REVISION DETAIL

  1   2   >