D15778: Log wallet open failure errors

2018-09-29 Thread Arjun AK
arjun marked an inline comment as done. arjun added a comment. In D15778#333555 , @bruns wrote: > The preferred way is to use arc, i.e. `arc diff`, ..., `arc land`, which ensures phabricator tags (Reviewed:, Revision, ...) are added to the

D15778: Log wallet open failure errors

2018-09-29 Thread Arjun AK
This revision was automatically updated to reflect the committed changes. Closed by commit R311:c7b064e5a3d5: Log wallet open failure errors (authored by arjun). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D15778?vs=42430=42538#toc REPOSITORY R311 KWallet CHANGES SINCE LAST UPDATE

D15778: Log wallet open failure errors

2018-09-28 Thread Arjun AK
arjun added a comment. I don't see a merge button, Am i supposed to push it via git? REVISION DETAIL https://phabricator.kde.org/D15778 To: arjun, mlaurent Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

2018-09-27 Thread Arjun AK
arjun removed a reviewer: mlaurent. arjun marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D15778 To: arjun Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

2018-09-27 Thread Arjun AK
arjun added a reviewer: mlaurent. REVISION DETAIL https://phabricator.kde.org/D15778 To: arjun, mlaurent Cc: mlaurent, kde-frameworks-devel, michaelh, ngraham, bruns

D15778: Log wallet open failure errors

2018-09-27 Thread Arjun AK
arjun updated this revision to Diff 42430. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15778?vs=42381=42430 REVISION DETAIL https://phabricator.kde.org/D15778 AFFECTED FILES src/runtime/kwalletd/kwalletd.cpp To: arjun, mlaurent Cc: mlaurent, kde-frameworks-devel, michaelh,

D15778: Log wallet open failure errors

2018-09-26 Thread Arjun AK
arjun created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. arjun requested review of this revision. REVISION SUMMARY Hopefully this would end up on syslog and grab the attention of the sysadmin. REPOSITORY R311 KWallet REVISION DETAIL

Re: Review Request 123929: If double-click is on empty area, then invoke back. (kfilewidgets)

2015-05-30 Thread Arjun AK
On May 29, 2015, 6:15 p.m., David Faure wrote: I'm not sure this is a good idea, usability wise. Miss an icon by one pixel, and the effect is to go up, making the whole set of icons disappear? Ashish Bansal wrote: Well about usability there's already discussion going on dolphin RR

Re: Review Request 120388: Do not sync if wallet file does not exist

2015-01-10 Thread Arjun AK
/kwalletbackend.cc b072cec src/runtime/kwalletd/kwalletd.h b94df15 src/runtime/kwalletd/kwalletd.cpp 882eb72 Diff: https://git.reviewboard.kde.org/r/120388/diff/ Testing --- Thanks, Arjun AK ___ Kde-frameworks-devel mailing list Kde-frameworks-devel

Re: Review Request 120388: Do not sync if wallet file does not exist

2014-12-29 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/#review72634 --- On Dec. 11, 2014, 7:46 a.m., Arjun AK wrote

Re: Review Request 120388: Do not sync if wallet file does not exist

2014-12-29 Thread Arjun AK
/kwalletd.cpp 882eb72 Diff: https://git.reviewboard.kde.org/r/120388/diff/ Testing --- Thanks, Arjun AK ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121461: Fix for bug 341773 and minor changes

2014-12-28 Thread Arjun AK
On Dec. 26, 2014, 1:44 p.m., David Faure wrote: This has been reverted for now, it broke the kio_trash unittest, because it doesn't preserve extensions anymore. Please revisit. Arjun AK wrote: Like i said in the ML, what should be done with the following files: `.txt

Re: Review Request 121461: Fix for bug 341773 and minor changes

2014-12-28 Thread Arjun AK
On Dec. 26, 2014, 1:44 p.m., David Faure wrote: This has been reverted for now, it broke the kio_trash unittest, because it doesn't preserve extensions anymore. Please revisit. Arjun AK wrote: Like i said in the ML, what should be done with the following files: `.txt

Re: Review Request 121461: Fix for bug 341773 and minor changes

2014-12-27 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121461/#review72518 --- On Dec. 23, 2014, 11:26 p.m., Arjun AK wrote

Re: Review Request 121461: Fix for bug 341773 and minor changes

2014-12-23 Thread Arjun AK
: https://git.reviewboard.kde.org/r/121461/diff/ Testing --- Thanks, Arjun AK ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121258: Restart KDirWatch after a failed delete operation

2014-12-18 Thread Arjun AK
--- Thanks, Arjun AK ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Change in kio[master]: Add ark's Extract Here option to the context menu even whe...

2014-12-18 Thread Arjun AK (Code Review)
Arjun AK has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/250 Change subject: Add ark's Extract Here option to the context menu even when files are of different types .. Add ark's Extract Here option

Review Request 121461: Fix for bug 341773 and minor changes

2014-12-12 Thread Arjun AK
1` respectively, instead of `1.foo` and `.1.foo`, since they are hidden files and we shouldn't be changing that. Diffs - autotests/globaltest.cpp 06cb500 src/core/global.cpp f18ac10 Diff: https://git.reviewboard.kde.org/r/121461/diff/ Testing --- Thanks, Arjun AK

Re: Review Request 121461: Fix for bug 341773 and minor changes

2014-12-12 Thread Arjun AK
://git.reviewboard.kde.org/r/121461/diff/ Testing --- Thanks, Arjun AK ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121461: Fix for bug 341773 and minor changes

2014-12-12 Thread Arjun AK
://git.reviewboard.kde.org/r/121461/diff/ Testing --- Thanks, Arjun AK ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120388: Do not sync if wallet file does not exist

2014-12-10 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/#review71740 --- Ping. - Arjun AK On Sept. 27, 2014, 5:29 p.m., Arjun AK

Re: Review Request 120388: Do not sync if wallet file does not exist

2014-12-10 Thread Arjun AK
Diff: https://git.reviewboard.kde.org/r/120388/diff/ Testing --- Thanks, Arjun AK ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121258: Restart KDirWatch after a failed delete operation

2014-11-26 Thread Arjun AK
and therefore the file listing does not get updated until you either press F5 or go to a new url Diffs - src/core/deletejob.cpp afc0461 Diff: https://git.reviewboard.kde.org/r/121258/diff/ Testing --- Thanks, Arjun AK ___ Kde-frameworks

Re: Review Request 120926: Remove redundant code from KRun::KRunPrivate::isPromptNeeded()

2014-11-16 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120926/#review70361 --- On Nov. 1, 2014, 4:01 p.m., Arjun AK wrote

Re: Review Request 120926: Remove redundant code from KRun::KRunPrivate::isPromptNeeded()

2014-11-01 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120926/#review69611 --- On Oct. 31, 2014, 11:26 p.m., Arjun AK wrote: --- This is an automatically

Re: Review Request 120926: Remove redundant code from KRun::KRunPrivate::isPromptNeeded()

2014-11-01 Thread Arjun AK
: if (value == alwaysAsk) { run-setShowScriptExecutionPrompt(true); } else { run-setRunExecutables(value == execute); } Diffs (updated) - src/widgets/krun.h cd5bcaa Diff: https://git.reviewboard.kde.org/r/120926/diff/ Testing --- Thanks, Arjun AK

Review Request 120926: Remove redundant code from KRun::KRunPrivate::isPromptNeeded()

2014-10-31 Thread Arjun AK
) { run-setShowScriptExecutionPrompt(true); } else { run-setRunExecutables(value == execute); } Diffs - src/widgets/krun.cpp c623b58 src/widgets/krun_p.h 61660c0 Diff: https://git.reviewboard.kde.org/r/120926/diff/ Testing --- Thanks, Arjun AK

Re: Review Request 120886: Show script execution prompt only if asked to

2014-10-30 Thread Arjun AK
programs. Diffs - src/widgets/krun.h 545c3a9 src/widgets/krun.cpp af5e8dc Diff: https://git.reviewboard.kde.org/r/120886/diff/ Testing --- Thanks, Arjun AK ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

2014-10-29 Thread Arjun AK
/ Testing --- Thanks, Arjun AK ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120886: Show script execution prompt only if asked to

2014-10-29 Thread Arjun AK
://git.reviewboard.kde.org/r/120886/diff/ Testing --- Thanks, Arjun AK ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

2014-10-28 Thread Arjun AK
/CMakeLists.txt 4060cdf src/widgets/executablefileopendialog.cpp PRE-CREATION src/widgets/executablefileopendialog_p.h PRE-CREATION src/widgets/krun.cpp 6ac42da src/widgets/krun_p.h 69e2e98 Diff: https://git.reviewboard.kde.org/r/120666/diff/ Testing --- Thanks, Arjun AK

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

2014-10-28 Thread Arjun AK
--- On Oct. 28, 2014, 1:20 p.m., Arjun AK wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/ --- (Updated Oct

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

2014-10-28 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/#review69246 --- On Oct. 28, 2014, 1:20 p.m., Arjun AK wrote

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

2014-10-28 Thread Arjun AK
/krun.cpp 6ac42da src/widgets/krun_p.h 69e2e98 src/widgets/CMakeLists.txt 4060cdf src/widgets/executablefileopendialog.cpp PRE-CREATION src/widgets/executablefileopendialog_p.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120666/diff/ Testing --- Thanks, Arjun AK

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

2014-10-28 Thread Arjun AK
/ Testing --- Thanks, Arjun AK ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

2014-10-23 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120666/#review68990 --- On Oct. 22, 2014, 9:40 p.m., Arjun AK wrote

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

2014-10-22 Thread Arjun AK
/CMakeLists.txt 4060cdf src/widgets/executablefileopendialog.h PRE-CREATION src/widgets/executablefileopendialog.cpp PRE-CREATION src/widgets/krun.cpp 6ac42da src/widgets/krun_p.h 69e2e98 Diff: https://git.reviewboard.kde.org/r/120666/diff/ Testing --- Thanks, Arjun AK

Review Request 120666: Get user's permission before executing scripts or desktop files

2014-10-20 Thread Arjun AK
/executablefileopendialog.h PRE-CREATION src/widgets/executablefileopendialog.cpp PRE-CREATION src/widgets/krun.cpp 6ac42da src/widgets/krun_p.h 69e2e98 Diff: https://git.reviewboard.kde.org/r/120666/diff/ Testing --- Thanks, Arjun AK ___ Kde

Re: Review Request 120387: 'walletListDirty' signal should be emitted if the 'kwalletd' directory is deleted

2014-10-09 Thread Arjun AK
. If the user had added any new data to the wallets, it would be lost Diffs - src/runtime/kwalletd/kwalletd.cpp 4eb8381 Diff: https://git.reviewboard.kde.org/r/120387/diff/ Testing --- Thanks, Arjun AK ___ Kde-frameworks-devel mailing

Review Request 120387: 'walletListDirty' signal should be emitted if the 'kwalletd' directory is deleted

2014-09-27 Thread Arjun AK
/runtime/kwalletd/kwalletd.cpp 4eb8381 Diff: https://git.reviewboard.kde.org/r/120387/diff/ Testing --- Thanks, Arjun AK ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120388: Do not sync if wallet file does not exist

2014-09-27 Thread Arjun AK
the wallet is closed since the salt has been deleted and therefore the wallet cannot be opened again. Diffs - src/runtime/kwalletd/backend/kwalletbackend.cc b072cec Diff: https://git.reviewboard.kde.org/r/120388/diff/ Testing --- Thanks, Arjun AK

Re: Review Request 120388: Do not sync if wallet file does not exist

2014-09-27 Thread Arjun AK
://git.reviewboard.kde.org/r/120388/#comment47078 Is the return value correct? - Arjun AK On Sept. 27, 2014, 5:29 p.m., Arjun AK wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r

Re: Review Request 120138: kshorturifilter : Treat ///... as /

2014-09-21 Thread Arjun AK
://git.reviewboard.kde.org/r/120138/diff/ Testing --- Thanks, Arjun AK ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120138: kshorturifilter : Treat ///... as /

2014-09-19 Thread Arjun Ak
/r/120138/diff/ Testing --- Thanks, Arjun Ak ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120138: kshorturifilter : Treat ///... as /

2014-09-15 Thread Arjun Ak
--- On Sept. 11, 2014, 2:20 p.m., Arjun Ak wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120138

Re: Review Request 120138: kshorturifilter : Treat ///... as /

2014-09-12 Thread Arjun Ak
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120138/#review66289 --- On Sept. 11, 2014, 2:20 p.m., Arjun Ak wrote: --- This is an automatically generated

Review Request 120138: kshorturifilter : Treat ///... as /

2014-09-11 Thread Arjun Ak
--- ///... should produce `QUrl(file:///)` not `QUrl(file://)` Diffs - autotests/kurifiltertest.cpp b84dcd0 src/urifilters/shorturi/kshorturifilter.cpp 00668d9 Diff: https://git.reviewboard.kde.org/r/120138/diff/ Testing --- Thanks, Arjun Ak