D18148: Use HTTPS, if available, in links visible to users

[Burkhard Lück]

lueck added inline comments.

INLINE COMMENTS

> katedocument.cpp:4592
>  "Please replace with 
> 'remove-trailing-spaces modified;', see "
> -
> "http://docs.kde.org/stable/en/applications/kate/config-variables.html#variable-remove-trailing-spaces;);
> +
> "https://docs.kde.org/stable/en/applications/kate/config-variables.html#variable-remove-trailing-spaces;);
>  m_config->setRemoveSpaces(state ? 1 : 0);

dead link: The requested URL 
/stable5/en/applications/kate/config-variables.html was not found on this 
server.

This link works:
https://docs.kde.org/stable5/en/applications/katepart/config-variables.html#variable-remove-trailing-spaces

> katedocument.cpp:4597
>  "Please replace with 
> 'remove-trailing-spaces all;', see "
> -
> "http://docs.kde.org/stable/en/applications/kate/config-variables.html#variable-remove-trailing-spaces;);
> +
> "https://docs.kde.org/stable/en/applications/kate/config-variables.html#variable-remove-trailing-spaces;);
>  m_config->setRemoveSpaces(state ? 2 : 0);

dead link, see above

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D18148

To: gszymaszek, #ktexteditor
Cc: lueck, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, 
demsking, cullmann, sars, dhaumann

D15131: add acronym ASCII to general.entities

[Burkhard Lück]

This revision was automatically updated to reflect the committed changes.
Closed by commit R238:0d36318396e2: add acronym ASCII to general.entities 
(authored by lueck).

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15131?vs=40578=40597

REVISION DETAIL
  https://phabricator.kde.org/D15131

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D15131: add acronym ASCII to general.entities

[Burkhard Lück]

lueck created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
lueck requested review of this revision.

REVISION SUMMARY
  16 hits in trunk l10n-kf5/documentation

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D15131

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D15105: add JSON to general.entities

[Burkhard Lück]

This revision was automatically updated to reflect the committed changes.
Closed by commit R238:21232062fc8a: add JSON to general.entities (authored by 
lueck).

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15105?vs=40517=40525

REVISION DETAIL
  https://phabricator.kde.org/D15105

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, #documentation, yurchor, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D15105: add JSON to general.entities

[Burkhard Lück]

lueck created this revision.
lueck added a reviewer: Documentation.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
lueck requested review of this revision.

REVISION SUMMARY
  see title

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D15105

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, #documentation
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D13227: update mailto kioslave docbook

[Burkhard Lück]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:84436b0d4874: update mailto kioslave docbook (authored by 
lueck).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13227?vs=35228=40086#toc

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13227?vs=35228=40086

REVISION DETAIL
  https://phabricator.kde.org/D13227

AFFECTED FILES
  docs/kioslave5/mailto/index.docbook

To: lueck, #frameworks, #documentation, yurchor
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D13226: update trash docbook to 5.48

[Burkhard Lück]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:34d6917f46a3: update trash docbook to 5.48 (authored by 
lueck).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13226?vs=35227=36432

REVISION DETAIL
  https://phabricator.kde.org/D13226

AFFECTED FILES
  docs/kcontrol5/trash/index.docbook

To: lueck, #frameworks, #documentation, ngraham
Cc: ngraham, kde-frameworks-devel, kde-doc-english, michaelh, bruns, skadinna

D13227: update mailto kioslave docbook

[Burkhard Lück]

lueck created this revision.
lueck added reviewers: Frameworks, Documentation.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added subscribers: kde-doc-english, kde-frameworks-devel.
lueck requested review of this revision.

REVISION SUMMARY
  correct reference to systemsettings module

TEST PLAN
  checkXML5 index.docbook

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13227

AFFECTED FILES
  docs/kioslave5/mailto/index.docbook

To: lueck, #frameworks, #documentation
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D13226: update trash docbook to 5.48

[Burkhard Lück]

lueck updated this revision to Diff 35227.
lueck added a comment.


  correct wrong frameworks version

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13226?vs=35226=35227

REVISION DETAIL
  https://phabricator.kde.org/D13226

AFFECTED FILES
  docs/kcontrol5/trash/index.docbook

To: lueck, #frameworks, #documentation
Cc: ngraham, kde-frameworks-devel, kde-doc-english, michaelh, bruns, skadinna

D13226: update trash docbook to 5.48

[Burkhard Lück]

lueck retitled this revision from "update trash docbook to .47" to "update 
trash docbook to 5.48".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13226

To: lueck, #frameworks, #documentation
Cc: ngraham, kde-frameworks-devel, kde-doc-english, michaelh, bruns, skadinna

D13226: update trash docbook to .47

[Burkhard Lück]

lueck created this revision.
lueck added reviewers: Frameworks, Documentation.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added subscribers: kde-doc-english, kde-frameworks-devel.
lueck requested review of this revision.

REVISION SUMMARY
  reflect gui changes in https://phabricator.kde.org/D12986

TEST PLAN
  checkXML5 docs/kcontrol5/trash/index.docbook

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13226

AFFECTED FILES
  docs/kcontrol5/trash/index.docbook

To: lueck, #frameworks, #documentation
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D13120: fix i18n issues in framworks/purpose/plugins

[Burkhard Lück]

This revision was automatically updated to reflect the committed changes.
Closed by commit R495:6ff87ba74f80: fix i18n issues in 
framworks/purpose/plugins (authored by lueck).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13120?vs=34875=34964#toc

REPOSITORY
  R495 Purpose Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13120?vs=34875=34964

REVISION DETAIL
  https://phabricator.kde.org/D13120

AFFECTED FILES
  src/plugins/email/CMakeLists.txt
  src/plugins/email/Messages.sh
  src/plugins/imgur/CMakeLists.txt
  src/plugins/imgur/Messages.sh
  src/plugins/kdeconnect/CMakeLists.txt
  src/plugins/kdeconnect/Messages.sh
  src/plugins/kdeconnect/kdeconnectplugin_config.qml
  src/plugins/ktp-sendfile/CMakeLists.txt
  src/plugins/ktp-sendfile/Messages.sh
  src/plugins/nextcloud/Messages.sh
  src/plugins/pastebin/CMakeLists.txt
  src/plugins/pastebin/Messages.sh
  src/plugins/phabricator/Messages.sh
  src/plugins/saveas/CMakeLists.txt
  src/plugins/saveas/Messages.sh
  src/plugins/telegram/Messages.sh
  src/plugins/twitter/Messages.sh
  src/plugins/twitter/contents/config/config.qml
  src/plugins/youtube/CMakeLists.txt
  src/plugins/youtube/Messages.sh

To: lueck, #frameworks, #localization, nicolasfella, apol
Cc: aacid, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D13120: fix i18n issues in framworks/purpose/plugins

[Burkhard Lück]

lueck added a comment.


  In D13120#268343 , @aacid wrote:
  
  > Are you sure you need the backslashes in add_definitions?
  
  
  probably not.
  i simply used what is used in the majority of all modules (frameworks, 
workspace, kde*, pim), except okular an a few others
  and okular is translated, so it should work without backslashes.
  want me to remove the backslashes?

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13120

To: lueck, #frameworks, #localization, nicolasfella, apol
Cc: aacid, apol, kde-frameworks-devel, michaelh, ngraham, bruns

D13120: fix i18n issues in framworks/purpose/plugins

[Burkhard Lück]

lueck created this revision.
lueck added reviewers: Frameworks, Localization, nicolasfella.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
lueck requested review of this revision.

REVISION SUMMARY
  add missing TRANSLATION_DOMAIN to CMakeLists.txt to load the catalogs
  
  email
  
no *.rc + *.u files
rm $EXTRACTRC
  
  kdeconnect i18n() only in qml
  
use i18nd()
  
  nextcloud  i18n() in qml + in cpp
  
no *.rc + *.u files
rm $EXTRACTRC
  
  reviewboard i18n() in qml + in cpp
  
ok
  
  saveas i18n() in qml + in cpp
  
no *.rc + *.u files
rm $EXTRACTRC
  
  imgur i18n() in cpp
  
no *.rc + *.u files
rm $EXTRACTRC
  
  twitter 2 i18n() in qml
  
no *.rc + *.u files
rm $EXTRACTRC
only qml -> use i18nd()
  
  ktp-sendfile 1 i18n() in cpp
  
no *.rc + *.u files
rm $EXTRACTRC
  
  phabricator i18n() in qml + in cpp
  
no *.rc + *.u files
rm $EXTRACTRC
  
  youtube i18n() in qml + in cpp
  
no *.rc + *.u files
rm $EXTRACTRC
  
  pastebin i18n() in cpp
  
no *.rc + *.u files
rm $EXTRACTRC
  
  telegram/Messages.sh, but no i18n()
  
rm Messages.sh

TEST PLAN
  path/to/l10n-kf5/scripts/extract-messages.sh creates all catalogs

REPOSITORY
  R495 Purpose Library

REVISION DETAIL
  https://phabricator.kde.org/D13120

AFFECTED FILES
  src/plugins/email/CMakeLists.txt
  src/plugins/email/Messages.sh
  src/plugins/imgur/CMakeLists.txt
  src/plugins/imgur/Messages.sh
  src/plugins/kdeconnect/CMakeLists.txt
  src/plugins/kdeconnect/Messages.sh
  src/plugins/kdeconnect/kdeconnectplugin_config.qml
  src/plugins/ktp-sendfile/CMakeLists.txt
  src/plugins/ktp-sendfile/Messages.sh
  src/plugins/nextcloud/Messages.sh
  src/plugins/pastebin/CMakeLists.txt
  src/plugins/pastebin/Messages.sh
  src/plugins/phabricator/Messages.sh
  src/plugins/saveas/CMakeLists.txt
  src/plugins/saveas/Messages.sh
  src/plugins/telegram/Messages.sh
  src/plugins/twitter/Messages.sh
  src/plugins/twitter/contents/config/config.qml
  src/plugins/youtube/CMakeLists.txt
  src/plugins/youtube/Messages.sh

To: lueck, #frameworks, #localization, nicolasfella
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13024: add entity OSD to general.entites

[Burkhard Lück]

lueck closed this revision.
lueck added a comment.


  commited with 
https://cgit.kde.org/kdoctools.git/commit/?id=20621d3351844aa96160c3922447a74265c20ab7

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D13024

To: lueck, #documentation, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D13024: add entity OSD to general.entites

[Burkhard Lück]

lueck created this revision.
lueck added a reviewer: Documentation.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added subscribers: kde-doc-english, kde-frameworks-devel.
lueck requested review of this revision.

REVISION SUMMARY
  > 10 hits in trunk l10n-kf5/documentation

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D13024

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, #documentation
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D12971: Add entities CIFS, NFS, Samba, SMB to general.entities

[Burkhard Lück]

This revision was automatically updated to reflect the committed changes.
Closed by commit R238:8debef405f45: Add entities CIFS, NFS, Samba, SMB to 
general.entities (authored by lueck).

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12971?vs=34452=34466

REVISION DETAIL
  https://phabricator.kde.org/D12971

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, #documentation, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D12971: Add entities CIFS, NFS, Samba, SMB to general.entities

[Burkhard Lück]

lueck marked 3 inline comments as done.

REVISION DETAIL
  https://phabricator.kde.org/D12971

To: lueck, #documentation, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D12971: Add entities CIFS, NFS, Samba, SMB to general.entities

[Burkhard Lück]

lueck updated this revision to Diff 34452.
lueck added a comment.


  fix typos spotted by Luigi, thanks

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12971?vs=34450=34452

REVISION DETAIL
  https://phabricator.kde.org/D12971

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, #documentation, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D12971: Add entities CIFS, NFS, Samba, SMB to general.entities

[Burkhard Lück]

lueck added a reviewer: ltoscano.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D12971

To: lueck, #documentation, ltoscano
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D12971: Add entities CIFS, NFS, Samba, SMB to general.entities

[Burkhard Lück]

lueck created this revision.
lueck added a reviewer: Documentation.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added subscribers: kde-doc-english, kde-frameworks-devel.
lueck requested review of this revision.

REVISION SUMMARY
  hits in trunk/l10n-kf5/documentation:
  
  16 x CIFS
  46 x NFS
  61 x Samba
  44 x SMB

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D12971

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, #documentation
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D11810: Add Falkon, Kirigami, macOS, Solid, USB, Wayland, X11, SDDM to general entities

[Burkhard Lück]

This revision was automatically updated to reflect the committed changes.
Closed by commit R238:4b9ee198b95b: Add Falkon, Kirigami, macOS, Solid, USB, 
Wayland, X11, SDDM to general entities (authored by lueck).
Restricted Application edited subscribers, added: kde-doc-english, 
kde-frameworks-devel; removed: Frameworks.

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11810?vs=30968=3

REVISION DETAIL
  https://phabricator.kde.org/D11810

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, ltoscano, #documentation
Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna, 
#frameworks

D11810: Add Falkon, Kirigami, macOS, Solid, USB, Wayland, X11, SDDM to general entities

[Burkhard Lück]

lueck added a comment.


  Please review, thanks

REVISION DETAIL
  https://phabricator.kde.org/D11810

To: lueck, ltoscano, #documentation
Cc: #frameworks, michaelh, ngraham, bruns, skadinna

D11810: Add Falkon, Kirigami, macOS, Solid, USB, Wayland, X11, SDDM to general entities

[Burkhard Lück]

lueck retitled this revision from "Add Falkon, Kirigami, macOS, Solid, USB, 
Wayland, X11 to general entities" to "Add Falkon, Kirigami, macOS, Solid, USB, 
Wayland, X11, SDDM to general entities".

REVISION DETAIL
  https://phabricator.kde.org/D11810

To: lueck, ltoscano, #documentation
Cc: #frameworks, michaelh, ngraham, skadinna

D11810: Add Falkon, Kirigami, macOS, Solid, USB, Wayland, X11 to general entities

[Burkhard Lück]

lueck updated this revision to Diff 30968.
lueck added a comment.


  add entity for sddm

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11810?vs=30949=30968

REVISION DETAIL
  https://phabricator.kde.org/D11810

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, ltoscano, #documentation
Cc: #frameworks, michaelh, ngraham, skadinna

D11810: Add Falkon, Kirigami, macOS, Solid, USB, Wayland, X11 to general entities

[Burkhard Lück]

lueck created this revision.
lueck added reviewers: ltoscano, Documentation.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added a subscriber: Frameworks.
lueck requested review of this revision.

REVISION SUMMARY
  Falkon new browser
  X11 17 hits in l10n-kf5/documentation
  macOS new name since the release of macOS 10.12 Sierra see 
https://en.wikipedia.org/wiki/MacOS
  Solid > 13 hits in l10n-kf5/documentation

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D11810

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, ltoscano, #documentation
Cc: #frameworks, michaelh, ngraham, skadinna

D11619: Add entities for Elisa, Markdown, KParts, DOT, SVG

[Burkhard Lück]

This revision was automatically updated to reflect the committed changes.
Closed by commit R238:3496d899181f: Add entities for Elisa, Markdown, KParts, 
DOT, SVG to general.entities (authored by lueck).

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11619?vs=30411=30938

REVISION DETAIL
  https://phabricator.kde.org/D11619

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, #documentation, ltoscano
Cc: #frameworks, michaelh, ngraham, skadinna

D11619: Add entities for Elisa, Markdown, KParts, DOT, SVG

[Burkhard Lück]

lueck added a reviewer: ltoscano.

REVISION DETAIL
  https://phabricator.kde.org/D11619

To: lueck, #documentation, ltoscano
Cc: #frameworks, michaelh, ngraham, skadinna

D11784: Fix duplicate lgpl-notice/gpl-notice/fdl-notice

[Burkhard Lück]

This revision was automatically updated to reflect the committed changes.
Closed by commit R238:e932059b349b: Fix duplicate 
lgpl-notice/gpl-notice/fdl-notice (authored by lueck).

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11784?vs=30852=30860

REVISION DETAIL
  https://phabricator.kde.org/D11784

AFFECTED FILES
  src/customization/en/entities/gpl-notice.docbook
  src/customization/en/entities/lgpl-notice.docbook

To: lueck, #documentation, ltoscano
Cc: ltoscano, #frameworks, kde-doc-english, michaelh, ngraham, skadinna

D11784: Fix duplicate lgpl-notice/gpl-notice/fdl-notice

[Burkhard Lück]

lueck created this revision.
lueck added a reviewer: Documentation.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added subscribers: kde-doc-english, Frameworks.
lueck requested review of this revision.

REVISION SUMMARY
  revert wrong commit R760462 
  for src/customization/en/entities/lgpl-notice
  and src/customization/en/entities/gpl-notice

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D11784

AFFECTED FILES
  src/customization/en/entities/gpl-notice.docbook
  src/customization/en/entities/lgpl-notice.docbook

To: lueck, #documentation
Cc: #frameworks, kde-doc-english, michaelh, ngraham, skadinna

D11619: Add entities for Elisa, Markdown, KParts, DOT, SVG

[Burkhard Lück]

lueck updated this revision to Diff 30411.
lueck added a comment.


  fix typo

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11619?vs=30340=30411

REVISION DETAIL
  https://phabricator.kde.org/D11619

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, #documentation
Cc: #frameworks, michaelh, ngraham, skadinna

D11619: Add entities for Elisa, Markdown, KParts, DOT, SVG

[Burkhard Lück]

lueck created this revision.
lueck added a reviewer: Documentation.
Restricted Application added projects: Frameworks, Documentation.
Restricted Application added a subscriber: Frameworks.
lueck requested review of this revision.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D11619

AFFECTED FILES
  src/customization/entities/general.entities

To: lueck, #documentation
Cc: #frameworks, michaelh, ngraham, skadinna

D10757: Reset QLocale internals when we have a custom app language

[Burkhard Lück]

lueck added a comment.


  In D10757#212405 , @aacid wrote:
  
  > @lueck can you try this new version *without* 
https://phabricator.kde.org/D10758 and https://phabricator.kde.org/D10759 ? 
This should be enough to get QLocale to update itself.
  
  
  Done that. 
  D10757  without D10758 
 + D10759 
 fixes the bug reported in 
https://bugs.kde.org/show_bug.cgi?id=390623
  Thanks

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10757

To: aacid, apol, ilic
Cc: lueck, #frameworks, michaelh

D10758: Use QLocale instead of QLocale::system

[Burkhard Lück]

lueck added a comment.


  using D10757 , D10758 
, and D10759 
 the bug reported in 
https://bugs.kde.org/show_bug.cgi?id=390623 is fixed for me, thanks a lot

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D10758

To: aacid
Cc: lueck, #frameworks, michaelh

D9989: tools: Make all output messages translatable

[Burkhard Lück]

lueck added a comment.


  In https://phabricator.kde.org/D9989#193705, @michaelh wrote:
  
  > added i18n context
  
  
  OK from i18n pov, thanks

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D9989

To: michaelh, smithjd, #frameworks, vhanda, lueck
Cc: ngraham

D9989: tools: Make all output messages translatable

[Burkhard Lück]

lueck added inline comments.

INLINE COMMENTS

> michaelh wrote in monitorcommand.cpp:66
> Context needed?

yes, please add context about the meaning of %1

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D9989

To: michaelh, smithjd, #frameworks, vhanda, lueck
Cc: ngraham

D9712: balooctl status: translatable message

[Burkhard Lück]

lueck added a comment.


  i18n looks ok, thanks

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D9712

To: michaelh, #frameworks, vhanda, smithjd, lueck
Cc: ltoscano, lbeltrame, elvisangelaccio, lueck, dfaure, ngraham

D9712: balooctl status: produce parseable output

[Burkhard Lück]

lueck added inline comments.

INLINE COMMENTS

> michaelh wrote in statuscommand.cpp:108
> I see. Thank you for the info.
> The only thing translated in this function is the filename. I am new to this, 
> but I think that is the only item that does not need translation. 
> It should be exactly the other way round, right? 
> Regarding my patch: 
> To ease translation, should I break up the strings a little bit?
> Like
> 
>   out << i18n("Basic indexing") << " " < The only thing translated in this function is the filename. I am new to this, 
> but I think that is the only item that does not need translation. 
>  It should be exactly the other way round, right?

"File: %1"will be translated e.g. in german to "Datei: %1" and at runtime %1 is 
replaced by the string value of filePath

> To ease translation, should I break up the strings a little bit?

Please no, word puzzles are evil for translators

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D9712

To: michaelh, #frameworks
Cc: elvisangelaccio, lueck, dfaure, ngraham

D9712: balooctl status: produce parseable output

[Burkhard Lück]

lueck added inline comments.

INLINE COMMENTS

> michaelh wrote in statuscommand.cpp:108
> Question: Is this ever going to be translated?

german translator here:
balooctl has a Messages.sh and extracts 52 messages into the catalog 
balooctl5.pot
a lot of messages in statuscommand.cpp, main.cpp, monitorcommand.cpp 
configcommand.cpp 98 - 52 = 48 are not extracted due to missing i18n() calls
we translate description of cammandline options in all application, therefore 
we should translate all missing messages here as well

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D9712

To: michaelh, #frameworks
Cc: lueck, dfaure, ngraham

D6972: Add CC BY-SA 4.0 International and set it as default

[Burkhard Lück]

lueck accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R238 KDocTools

BRANCH
  add-ccbysa4-translatable

REVISION DETAIL
  https://phabricator.kde.org/D6972

To: ltoscano, jriddell, lueck, yurchor
Cc: jriddell, lueck, #frameworks, #documentation, skadinna

D6972: Add CC BY-SA 4.0 International and set it as default

[Burkhard Lück]

lueck accepted this revision.
lueck added a comment.
This revision is now accepted and ready to land.


  thanks

REPOSITORY
  R238 KDocTools

BRANCH
  add-ccbysa4

REVISION DETAIL
  https://phabricator.kde.org/D6972

To: ltoscano, jriddell, lueck
Cc: jriddell, lueck, #frameworks, #documentation, skadinna

D6972: Add CC BY-SA 4.0 International

[Burkhard Lück]

lueck added inline comments.

INLINE COMMENTS

> template.docbook:20
>  
>  
>  

needs update to new license

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D6972

To: ltoscano
Cc: lueck, #frameworks, #documentation, skadinna

D6800: Add template for a simple kpart-based application

[Burkhard Lück]

lueck added a comment.


  In https://phabricator.kde.org/D6800#128307, @kossebau wrote:
  
  >
  
  
  
  
  > I cannot see though any catalogs which would match the template-string 
catalog names, so seems there is some magic already to prevent that?
  
  
  
l10n-kf5/scripts/extract-messages.sh:
 # skip Messages.sh files of KDevelop's app templates
 grep '{APPNAMELC}[^ ]*.pot' $subdir/Messages.sh 1>/dev/null && continue

REPOSITORY
  R306 KParts

REVISION DETAIL
  https://phabricator.kde.org/D6800

To: kossebau, #frameworks, dfaure
Cc: lueck, ltoscano, aacid

D6331: Make sure that the tsfiles target is generated

[Burkhard Lück]

lueck added a comment.


  locale fr or uk build now, but without the script files beeing installed.
  Looks like ./scripts/autogen.sh needs to be adapted as well

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D6331

To: apol, #frameworks, ltoscano, lueck

D5090: More focus on KIO than Konqueror

[Burkhard Lück]

lueck added inline comments.

INLINE COMMENTS

> smbrodlg.cpp:176-186
> +   return i18n("Windows SharesApplications using the "
> +"SMB kioslave (like Konqueror) are able to access shared Microsoft "
> +"Windows file systems, if properly configured. If there is a "
>  "specific computer from which you want to browse, fill in "
>  "the Browse server field. This is mandatory if you "
>  "are not running Samba locally. The Broadcast address "
>  "and WINS address fields will also be available, if you "

There are no fields named Browse server, Broadcast address, WINS address in the 
dialog, see
https://bugs.kde.org/show_bug.cgi?id=253389

Last occurences of these strings are in
https://websvn.kde.org/tags/KDE/3.3.0/kdebase/kcontrol/kio/ksmboptdlg.cpp?view=markup

ksmboptdialog.cpp was replaced with smbrodlg.cpp without these strings with
https://websvn.kde.org/trunk/kdebase/kcontrol/kio/smbrodlg.cpp?revision=76131=markup=76131

Therefore everything about Browse server, Broadcast address, WINS address  
should be removed.

Otherwise looks good to me.

Thanks

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D5090

To: ltoscano, dfaure
Cc: lueck, #frameworks

[Differential] [Closed] D3939: fix description for option -t in man page

[Burkhard Lück]

lueck closed this revision.
lueck added a comment.


  commited with 
https://commits.kde.org/kpackage/da80b5461de4b341899a7a282c3fae59f868edd4

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D3939

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: lueck, #frameworks, mart, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, andreaska, 
sebas

[Differential] [Request, 7 lines] D3939: fix description for option -t in man page

[Burkhard Lück]

lueck created this revision.
lueck added reviewers: Plasma, Frameworks.
lueck set the repository for this revision to R290 KPackage.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  see https://phabricator.kde.org/D3934

TEST PLAN
  checkXML5 man-kpackagetool5.1.docbook

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D3939

AFFECTED FILES
  docs/kpackagetool/man-kpackagetool5.1.docbook

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: lueck, #plasma, #frameworks
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 129380: remove kcm docbooks which have their code in other repos from plasma-desktop

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129380/
---

(Updated Nov. 13, 2016, 12:06 a.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks and Plasma.


Changes
---

Submitted with commit e9bf567e4531ab01c7d0d73274771797dd397125 by Burkhard Lück 
to branch master.


Bugs: 350619
https://bugs.kde.org/show_bug.cgi?id=350619


Repository: plasma-desktop


Description
---

remove kcm docbooks for cache, proxy, useragent, cookies, netpref, 
webshortcuts, smb
these docbooks will be imported into frameworks/kio from kde-runtime master, 
see https://git.reviewboard.kde.org/r/128912/
remove kcm docbook for filetypes, this docbook will be imported into 
kde-cli-tools from kde-runtime master, see 
https://git.reviewboard.kde.org/r/128914/


Diffs
-

  doc/kcontrol/CMakeLists.txt c057288 
  doc/kcontrol/cache/CMakeLists.txt 7728027 
  doc/kcontrol/cache/index.docbook a03658e 
  doc/kcontrol/cookies/CMakeLists.txt 8f86430 
  doc/kcontrol/cookies/index.docbook a2379b9 
  doc/kcontrol/filetypes/CMakeLists.txt c6a6b24 
  doc/kcontrol/filetypes/index.docbook bf40a12 
  doc/kcontrol/netpref/CMakeLists.txt 42010fd 
  doc/kcontrol/netpref/index.docbook 7db99a6 
  doc/kcontrol/proxy/CMakeLists.txt 37b19c9 
  doc/kcontrol/proxy/index.docbook a7bc293 
  doc/kcontrol/smb/CMakeLists.txt 3285ccf 
  doc/kcontrol/smb/index.docbook f42f9a4 
  doc/kcontrol/useragent/CMakeLists.txt 35165d2 
  doc/kcontrol/useragent/index.docbook 6a816ab 
  doc/kcontrol/webshortcuts/CMakeLists.txt 7324220 
  doc/kcontrol/webshortcuts/index.docbook bde3028 

Diff: https://git.reviewboard.kde.org/r/129380/diff/


Testing
---

builds


Thanks,

Burkhard Lück

Re: Review Request 129380: remove kcm docbooks which have their code in other repos from plasma-desktop

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129380/#review100801
---



filetypes kcm docbook was imported into kde-cli-tools with commit 
775cc72ed9a529de02607e277b379ed6260399ef
kcm docbooks for cache, proxy, useragent, cookies, netpref, webshortcuts, smb 
were imported into kio with commit e0c3945a88fd041f36ff3873f6fe0ca5cfa00158
so nothing blocks this RR anymore and the docbooks should be immediately removed

- Burkhard Lück


On Nov. 11, 2016, 6:43 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129380/
> ---
> 
> (Updated Nov. 11, 2016, 6:43 nachm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Plasma.
> 
> 
> Bugs: 350619
> https://bugs.kde.org/show_bug.cgi?id=350619
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> remove kcm docbooks for cache, proxy, useragent, cookies, netpref, 
> webshortcuts, smb
> these docbooks will be imported into frameworks/kio from kde-runtime master, 
> see https://git.reviewboard.kde.org/r/128912/
> remove kcm docbook for filetypes, this docbook will be imported into 
> kde-cli-tools from kde-runtime master, see 
> https://git.reviewboard.kde.org/r/128914/
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/CMakeLists.txt c057288 
>   doc/kcontrol/cache/CMakeLists.txt 7728027 
>   doc/kcontrol/cache/index.docbook a03658e 
>   doc/kcontrol/cookies/CMakeLists.txt 8f86430 
>   doc/kcontrol/cookies/index.docbook a2379b9 
>   doc/kcontrol/filetypes/CMakeLists.txt c6a6b24 
>   doc/kcontrol/filetypes/index.docbook bf40a12 
>   doc/kcontrol/netpref/CMakeLists.txt 42010fd 
>   doc/kcontrol/netpref/index.docbook 7db99a6 
>   doc/kcontrol/proxy/CMakeLists.txt 37b19c9 
>   doc/kcontrol/proxy/index.docbook a7bc293 
>   doc/kcontrol/smb/CMakeLists.txt 3285ccf 
>   doc/kcontrol/smb/index.docbook f42f9a4 
>   doc/kcontrol/useragent/CMakeLists.txt 35165d2 
>   doc/kcontrol/useragent/index.docbook 6a816ab 
>   doc/kcontrol/webshortcuts/CMakeLists.txt 7324220 
>   doc/kcontrol/webshortcuts/index.docbook bde3028 
> 
> Diff: https://git.reviewboard.kde.org/r/129380/diff/
> 
> 
> Testing
> ---
> 
> builds
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/
---

(Updated Nov. 12, 2016, 2:13 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks and Plasma.


Changes
---

Submitted with commit e0c3945a88fd041f36ff3873f6fe0ca5cfa00158 by Burkhard Lück 
to branch master.


Repository: kio


Description
---

doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
splitted from kde-runtime master using https://github.com/ajdruff/git-splits

Not included in build so far, the docbooks are imported as they were splitted

To be done next:
Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
rename ebrowsing to webshortcuts
reapply a few updates done in plasma-desktop
remove these imported kcontrol docbooks from plasma-desktop
adapt scripty to these changes


Diffs
-

  docs/CMakeLists.txt 350bce3 
  docs/kcontrol5/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/cache/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/cache/index.docbook PRE-CREATION 
  docs/kcontrol5/cookies/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/cookies/index.docbook PRE-CREATION 
  docs/kcontrol5/netpref/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/netpref/index.docbook PRE-CREATION 
  docs/kcontrol5/proxy/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/proxy/index.docbook PRE-CREATION 
  docs/kcontrol5/smb/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/smb/index.docbook PRE-CREATION 
  docs/kcontrol5/trash/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/trash/index.docbook PRE-CREATION 
  docs/kcontrol5/useragent/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/useragent/index.docbook PRE-CREATION 
  docs/kcontrol5/webshortcuts/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/webshortcuts/index.docbook PRE-CREATION 
  src/ioslaves/trash/kcmtrash.desktop c8ff4ac 
  src/kcms/kio/cache.desktop f0bd261 
  src/kcms/kio/cookies.desktop f91b5cd 
  src/kcms/kio/netpref.desktop 963ef3f 
  src/kcms/kio/proxy.desktop c11451d 
  src/kcms/kio/smb.desktop c323614 
  src/kcms/kio/useragent.desktop 856e9cc 
  src/kcms/webshortcuts/webshortcuts.desktop 24fbb2a 

Diff: https://git.reviewboard.kde.org/r/128912/diff/


Testing
---

history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
master


File Attachments


git-log-doc-kcontrol.output
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output
kio-log-docs.txt
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/11/911e5e67-3094-4d47-aa94-95129f5545fe__kio-log-docs.txt


Thanks,

Burkhard Lück

Review Request 129380: remove kcm docbooks which have their code in other repos from plasma-desktop

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129380/
---

Review request for Documentation, KDE Frameworks and Plasma.


Bugs: 350619
https://bugs.kde.org/show_bug.cgi?id=350619


Repository: plasma-desktop


Description
---

remove kcm docbooks for cache, proxy, useragent, cookies, netpref, 
webshortcuts, smb
these docbooks will be imported into frameworks/kio from kde-runtime master, 
see https://git.reviewboard.kde.org/r/128912/
remove kcm docbook for filetypes, this docbook will be imported into 
kde-cli-tools from kde-runtime master, see 
https://git.reviewboard.kde.org/r/128914/


Diffs
-

  doc/kcontrol/CMakeLists.txt c057288 
  doc/kcontrol/cache/CMakeLists.txt 7728027 
  doc/kcontrol/cache/index.docbook a03658e 
  doc/kcontrol/cookies/CMakeLists.txt 8f86430 
  doc/kcontrol/cookies/index.docbook a2379b9 
  doc/kcontrol/filetypes/CMakeLists.txt c6a6b24 
  doc/kcontrol/filetypes/index.docbook bf40a12 
  doc/kcontrol/netpref/CMakeLists.txt 42010fd 
  doc/kcontrol/netpref/index.docbook 7db99a6 
  doc/kcontrol/proxy/CMakeLists.txt 37b19c9 
  doc/kcontrol/proxy/index.docbook a7bc293 
  doc/kcontrol/smb/CMakeLists.txt 3285ccf 
  doc/kcontrol/smb/index.docbook f42f9a4 
  doc/kcontrol/useragent/CMakeLists.txt 35165d2 
  doc/kcontrol/useragent/index.docbook 6a816ab 
  doc/kcontrol/webshortcuts/CMakeLists.txt 7324220 
  doc/kcontrol/webshortcuts/index.docbook bde3028 

Diff: https://git.reviewboard.kde.org/r/129380/diff/


Testing
---

builds


Thanks,

Burkhard Lück

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/
---

(Updated Nov. 11, 2016, 3:39 nachm.)


Review request for Documentation, KDE Frameworks and Plasma.


Repository: kio


Description
---

doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
splitted from kde-runtime master using https://github.com/ajdruff/git-splits

Not included in build so far, the docbooks are imported as they were splitted

To be done next:
Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
rename ebrowsing to webshortcuts
reapply a few updates done in plasma-desktop
remove these imported kcontrol docbooks from plasma-desktop
adapt scripty to these changes


Diffs
-

  docs/CMakeLists.txt 350bce3 
  docs/kcontrol5/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/cache/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/cache/index.docbook PRE-CREATION 
  docs/kcontrol5/cookies/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/cookies/index.docbook PRE-CREATION 
  docs/kcontrol5/netpref/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/netpref/index.docbook PRE-CREATION 
  docs/kcontrol5/proxy/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/proxy/index.docbook PRE-CREATION 
  docs/kcontrol5/smb/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/smb/index.docbook PRE-CREATION 
  docs/kcontrol5/trash/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/trash/index.docbook PRE-CREATION 
  docs/kcontrol5/useragent/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/useragent/index.docbook PRE-CREATION 
  docs/kcontrol5/webshortcuts/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/webshortcuts/index.docbook PRE-CREATION 
  src/ioslaves/trash/kcmtrash.desktop c8ff4ac 
  src/kcms/kio/cache.desktop f0bd261 
  src/kcms/kio/cookies.desktop f91b5cd 
  src/kcms/kio/netpref.desktop 963ef3f 
  src/kcms/kio/proxy.desktop c11451d 
  src/kcms/kio/smb.desktop c323614 
  src/kcms/kio/useragent.desktop 856e9cc 
  src/kcms/webshortcuts/webshortcuts.desktop 24fbb2a 

Diff: https://git.reviewboard.kde.org/r/128912/diff/


Testing
---

history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
master


File Attachments (updated)


git-log-doc-kcontrol.output
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output
kio-log-docs.txt
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/11/11/911e5e67-3094-4d47-aa94-95129f5545fe__kio-log-docs.txt


Thanks,

Burkhard Lück

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

[Burkhard Lück]

> On Nov. 11, 2016, 1:51 nachm., Luigi Toscano wrote:
> > If I understand it correctly, the review include two separate change 
> > (import + fixes), is it correct? Then it's fine by me (pending confirmation 
> > for the shipit), the changes are fine and we can refine it later (better 
> > than the current situation).

Thes are two separate changes, the import + update in one RR, see 
kio-log-docs.txt -> less trouble with scripty


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/#review100778
---


On Nov. 11, 2016, 9:31 vorm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128912/
> ---
> 
> (Updated Nov. 11, 2016, 9:31 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Plasma.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
> doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
> doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
> splitted from kde-runtime master using https://github.com/ajdruff/git-splits
> 
> Not included in build so far, the docbooks are imported as they were splitted
> 
> To be done next:
> Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
> rename ebrowsing to webshortcuts
> reapply a few updates done in plasma-desktop
> remove these imported kcontrol docbooks from plasma-desktop
> adapt scripty to these changes
> 
> 
> Diffs
> -
> 
>   docs/CMakeLists.txt 350bce3 
>   docs/kcontrol5/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/cache/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/cache/index.docbook PRE-CREATION 
>   docs/kcontrol5/cookies/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/cookies/index.docbook PRE-CREATION 
>   docs/kcontrol5/netpref/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/netpref/index.docbook PRE-CREATION 
>   docs/kcontrol5/proxy/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/proxy/index.docbook PRE-CREATION 
>   docs/kcontrol5/smb/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/smb/index.docbook PRE-CREATION 
>   docs/kcontrol5/trash/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/trash/index.docbook PRE-CREATION 
>   docs/kcontrol5/useragent/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/useragent/index.docbook PRE-CREATION 
>   docs/kcontrol5/webshortcuts/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol5/webshortcuts/index.docbook PRE-CREATION 
>   src/ioslaves/trash/kcmtrash.desktop c8ff4ac 
>   src/kcms/kio/cache.desktop f0bd261 
>   src/kcms/kio/cookies.desktop f91b5cd 
>   src/kcms/kio/netpref.desktop 963ef3f 
>   src/kcms/kio/proxy.desktop c11451d 
>   src/kcms/kio/smb.desktop c323614 
>   src/kcms/kio/useragent.desktop 856e9cc 
>   src/kcms/webshortcuts/webshortcuts.desktop 24fbb2a 
> 
> Diff: https://git.reviewboard.kde.org/r/128912/diff/
> 
> 
> Testing
> ---
> 
> history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
> master
> 
> 
> File Attachments
> 
> 
> git-log-doc-kcontrol.output
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/
---

(Updated Nov. 11, 2016, 9:31 vorm.)


Review request for Documentation, KDE Frameworks and Plasma.


Changes
---

Update import because I misssed the trash kcm docbook
move into existing dir docs using subdir kcontrol5 to make make co-installable, 
adapt CMakeLists.txt, change dtd to kf5
rename ebrowsing to webshortcuts
reapply a few updates done in plasma-desktop
proofread, bump date + releaseinfo
adapt X-DocPath in desktop files


Repository: kio


Description
---

doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
splitted from kde-runtime master using https://github.com/ajdruff/git-splits

Not included in build so far, the docbooks are imported as they were splitted

To be done next:
Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
rename ebrowsing to webshortcuts
reapply a few updates done in plasma-desktop
remove these imported kcontrol docbooks from plasma-desktop
adapt scripty to these changes


Diffs (updated)
-

  docs/CMakeLists.txt 350bce3 
  docs/kcontrol5/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/cache/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/cache/index.docbook PRE-CREATION 
  docs/kcontrol5/cookies/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/cookies/index.docbook PRE-CREATION 
  docs/kcontrol5/netpref/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/netpref/index.docbook PRE-CREATION 
  docs/kcontrol5/proxy/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/proxy/index.docbook PRE-CREATION 
  docs/kcontrol5/smb/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/smb/index.docbook PRE-CREATION 
  docs/kcontrol5/trash/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/trash/index.docbook PRE-CREATION 
  docs/kcontrol5/useragent/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/useragent/index.docbook PRE-CREATION 
  docs/kcontrol5/webshortcuts/CMakeLists.txt PRE-CREATION 
  docs/kcontrol5/webshortcuts/index.docbook PRE-CREATION 
  src/ioslaves/trash/kcmtrash.desktop c8ff4ac 
  src/kcms/kio/cache.desktop f0bd261 
  src/kcms/kio/cookies.desktop f91b5cd 
  src/kcms/kio/netpref.desktop 963ef3f 
  src/kcms/kio/proxy.desktop c11451d 
  src/kcms/kio/smb.desktop c323614 
  src/kcms/kio/useragent.desktop 856e9cc 
  src/kcms/webshortcuts/webshortcuts.desktop 24fbb2a 

Diff: https://git.reviewboard.kde.org/r/128912/diff/


Testing
---

history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
master


File Attachments


git-log-doc-kcontrol.output
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output


Thanks,

Burkhard Lück

Re: Review Request 129209: Rename subdir kcontrol to kcontrol5

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129209/
---

(Updated Nov. 8, 2016, 5:15 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation and KDE Frameworks.


Changes
---

Submitted with commit 6b9d09c107e90c667ef3884b7e00796292ad6539 by Burkhard Lück 
to branch master.


Repository: kdelibs4support


Description
---

in distributions the doc packages for kdelibs4support and kde-runtime are 
usually designed to be co-installable, 
but this fails in some distributions due to conflicting file paths, therefore:
 
* subdir kcontrol is renamed to kcontrol5
* install target for kcm_ssl docbook changed to kcontrol5
* X-DocPath changed to kcontrol5/kcm_ssl/index.html


Diffs
-

  docs/CMakeLists.txt f90fa81 
  docs/kcontrol/CMakeLists.txt  
  docs/kcontrol/kcm_ssl/CMakeLists.txt  
  docs/kcontrol/kcm_ssl/details.png  
  docs/kcontrol/kcm_ssl/index.docbook  
  docs/kcontrol/kcm_ssl/module.png  
  docs/kcontrol5/kcm_ssl/CMakeLists.txt 4d3bc75 
  src/kssl/kcm/kcm_ssl.desktop 6ec8be6 

Diff: https://git.reviewboard.kde.org/r/129209/diff/


Testing
---

builds and installs properly


Thanks,

Burkhard Lück

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'

[Burkhard Lück]

> On Nov. 4, 2016, 8:58 vorm., Burkhard Lück wrote:
> > Using checkXML5+meinproc5 with patch on a valid docbook:
> > 
> >   $ ls *html
> >   ls: cannot access '*html': No such file or directory
> >   $ checkXML5 kdegraphics/okular/doc/index.docbook 
> >   $ ls *html
> >   ls: cannot access '*html': No such file or directory
> >   $ meinproc5 --check kdegraphics/okular/doc/index.docbook 
> >   $ ls *html
> >   advanced.html command-line-options.html  configeditor.html   
> > configperformance.html   configure.html   forms.html 
> > inverse_search.html  menugo.html menuview.html  
> > primary-menu-items.html
> >   annotations.html  configaccessibility.html   configgeneral.html  
> > configpresentation.html  credits.html index.html 
> > menubookmarks.html   menuhelp.html   navigating.html
> > settings-menu.html
> >   bookmark-management.html  configannotations.html config-pdf.html 
> > configure-backends.html  fit-window-to-page.html  introduction.html  
> > menuedit.htmlmenutools.html  presentationMode.html  use.html
> > 
> >   -> meinproc5 --check should not generate html files used with "--check"
> > 
> > Using checkXML5+meinproc5 with patch on an invalid docbook:
> > 
> >   $ rm *html
> >   $ checkXML5 kdegraphics/okular/doc/index.docbook 
> > 
> >   -> no output of errors!
> > 
> >   $ ls *html
> >   ls: cannot access '*html': No such file or directory
> >   $ meinproc5 --check kdegraphics/okular/doc/index.docbook 
> >   index.docbook:912: parser error : expected '>'
> >   
> >   ^
> >   meinproc(16611)/default main: Error: `xmllint --noout` outputted text
> > 
> > checkXML5+meinproc5 with patch are still broken
> 
> Ralf Habacker wrote:
> You probably uses revision 1 of this patch. This is fixed with patch 
> revision 2, where checkXML5 redirects meinproc5 stderr output to stderr.

You are right, sorry for the noise.
checkXML5+meinproc5 work now as before


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129314/#review100556
---


On Nov. 4, 2016, 8:18 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129314/
> ---
> 
> (Updated Nov. 4, 2016, 8:18 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Bugs: 371987
> https://bugs.kde.org/show_bug.cgi?id=371987
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Fix 'checkXML5 generates html files in workdir for valid docbooks'.
> 
> BUG:371987
> 
> 
> Diffs
> -
> 
>   src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 
> 
> Diff: https://git.reviewboard.kde.org/r/129314/diff/
> 
> 
> Testing
> ---
> 
> tested on opensuse 13.2
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 129314: Fix 'checkXML5 generates html files in workdir for valid docbooks'

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129314/#review100556
---



Using checkXML5+meinproc5 with patch on a valid docbook:

  $ ls *html
  ls: cannot access '*html': No such file or directory
  $ checkXML5 kdegraphics/okular/doc/index.docbook 
  $ ls *html
  ls: cannot access '*html': No such file or directory
  $ meinproc5 --check kdegraphics/okular/doc/index.docbook 
  $ ls *html
  advanced.html command-line-options.html  configeditor.html   
configperformance.html   configure.html   forms.html 
inverse_search.html  menugo.html menuview.html  
primary-menu-items.html
  annotations.html  configaccessibility.html   configgeneral.html  
configpresentation.html  credits.html index.html 
menubookmarks.html   menuhelp.html   navigating.htmlsettings-menu.html
  bookmark-management.html  configannotations.html config-pdf.html 
configure-backends.html  fit-window-to-page.html  introduction.html  
menuedit.htmlmenutools.html  presentationMode.html  use.html

  -> meinproc5 --check should not generate html files used with "--check"

Using checkXML5+meinproc5 with patch on an invalid docbook:

  $ rm *html
  $ checkXML5 kdegraphics/okular/doc/index.docbook 

  -> no output of errors!

  $ ls *html
  ls: cannot access '*html': No such file or directory
  $ meinproc5 --check kdegraphics/okular/doc/index.docbook 
  index.docbook:912: parser error : expected '>'
  
  ^
  meinproc(16611)/default main: Error: `xmllint --noout` outputted text

checkXML5+meinproc5 with patch are still broken

- Burkhard Lück


On Nov. 4, 2016, 8:18 vorm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129314/
> ---
> 
> (Updated Nov. 4, 2016, 8:18 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Bugs: 371987
> https://bugs.kde.org/show_bug.cgi?id=371987
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Fix 'checkXML5 generates html files in workdir for valid docbooks'.
> 
> BUG:371987
> 
> 
> Diffs
> -
> 
>   src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 
> 
> Diff: https://git.reviewboard.kde.org/r/129314/diff/
> 
> 
> Testing
> ---
> 
> tested on opensuse 13.2
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 129314: Setup targets for cross compiling.

[Burkhard Lück]

> On Nov. 2, 2016, 8:22 nachm., Burkhard Lück wrote:
> > works for me, but let's wait for Luigi's OK

-100
I just noticed checkXML5 does not output any error on invalid xml, makes 
checkXML5 useless


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129314/#review100517
---


On Nov. 2, 2016, 7:55 nachm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129314/
> ---
> 
> (Updated Nov. 2, 2016, 7:55 nachm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Bugs: 371987
> https://bugs.kde.org/show_bug.cgi?id=371987
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Fix 'checkXML5 generates html files in workdir for valid docbooks'.
> 
> BUG:371987
> 
> 
> Diffs
> -
> 
>   KF5DocToolsMacros.cmake d73201dbecaf370898f66f807e6d8856d6f88a8d 
>   src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 
> 
> Diff: https://git.reviewboard.kde.org/r/129314/diff/
> 
> 
> Testing
> ---
> 
> tested on opensuse 13.2
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 129314: Setup targets for cross compiling.

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129314/#review100517
---



works for me, but let's wait for Luigi's OK

- Burkhard Lück


On Nov. 2, 2016, 7:55 nachm., Ralf Habacker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129314/
> ---
> 
> (Updated Nov. 2, 2016, 7:55 nachm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Luigi Toscano.
> 
> 
> Bugs: 371987
> https://bugs.kde.org/show_bug.cgi?id=371987
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> Fix 'checkXML5 generates html files in workdir for valid docbooks'.
> 
> BUG:371987
> 
> 
> Diffs
> -
> 
>   KF5DocToolsMacros.cmake d73201dbecaf370898f66f807e6d8856d6f88a8d 
>   src/checkXML5.cpp 437296a0b582c5b3e11c72712c62188dbcef5aa7 
> 
> Diff: https://git.reviewboard.kde.org/r/129314/diff/
> 
> 
> Testing
> ---
> 
> tested on opensuse 13.2
> 
> 
> Thanks,
> 
> Ralf Habacker
> 
>

Re: Review Request 129209: Rename subdir kcontrol to kcontrol5

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129209/#review100512
---



kdeframeworks ping?

- Burkhard Lück


On Okt. 17, 2016, 2:31 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129209/
> ---
> 
> (Updated Okt. 17, 2016, 2:31 nachm.)
> 
> 
> Review request for Documentation and KDE Frameworks.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> ---
> 
> in distributions the doc packages for kdelibs4support and kde-runtime are 
> usually designed to be co-installable, 
> but this fails in some distributions due to conflicting file paths, therefore:
>  
> * subdir kcontrol is renamed to kcontrol5
> * install target for kcm_ssl docbook changed to kcontrol5
> * X-DocPath changed to kcontrol5/kcm_ssl/index.html
> 
> 
> Diffs
> -
> 
>   docs/CMakeLists.txt f90fa81 
>   docs/kcontrol/CMakeLists.txt  
>   docs/kcontrol/kcm_ssl/CMakeLists.txt  
>   docs/kcontrol/kcm_ssl/details.png  
>   docs/kcontrol/kcm_ssl/index.docbook  
>   docs/kcontrol/kcm_ssl/module.png  
>   docs/kcontrol5/kcm_ssl/CMakeLists.txt 4d3bc75 
>   src/kssl/kcm/kcm_ssl.desktop 6ec8be6 
> 
> Diff: https://git.reviewboard.kde.org/r/129209/diff/
> 
> 
> Testing
> ---
> 
> builds and installs properly
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Review Request 129209: Rename subdir kcontrol to kcontrol5

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129209/
---

Review request for Documentation and KDE Frameworks.


Repository: kdelibs4support


Description
---

in distributions the doc packages for kdelibs4support and kde-runtime are 
usually designed to be co-installable, 
but this fails in some distributions due to conflicting file paths, therefore:
 
* subdir kcontrol is renamed to kcontrol5
* install target for kcm_ssl docbook changed to kcontrol5
* X-DocPath changed to kcontrol5/kcm_ssl/index.html


Diffs
-

  docs/CMakeLists.txt f90fa81 
  docs/kcontrol/CMakeLists.txt  
  docs/kcontrol/kcm_ssl/CMakeLists.txt  
  docs/kcontrol/kcm_ssl/details.png  
  docs/kcontrol/kcm_ssl/index.docbook  
  docs/kcontrol/kcm_ssl/module.png  
  docs/kcontrol5/kcm_ssl/CMakeLists.txt 4d3bc75 
  src/kssl/kcm/kcm_ssl.desktop 6ec8be6 

Diff: https://git.reviewboard.kde.org/r/129209/diff/


Testing
---

builds and installs properly


Thanks,

Burkhard Lück

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

[Burkhard Lück]

> On Sept. 15, 2016, 7:28 vorm., Luigi Toscano wrote:
> > Can they be made co-installable with the ones with kde-runtime, as both 
> > modules can be available at the same time? This is the problem of the 
> > missing support for kcontrol5
> > 
> > It was already done some time ago and I had to revert it:
> > https://marc.info/?t=14207454037=1=1
> > https://marc.info/?l=kde-i18n-doc=142076318528227=1
> 
> Burkhard Lück wrote:
> Sure we can make them co-installable, we just need to decide how to do it
> so far in kf5 we install to ${HTML_INSTALL_DIR}/en SUBDIR kcontrol/ = 
> same subdir as kde4/kde-runtime
> all kcontrol docbooks have the same name in kf5 + kde4 except for 
> cddbretrieval (kde4) / cddbretrieval5 (kf5) and ebrowsing (kde4) / 
> webshortcuts (kf5)
> 
> Options for co-installable:
> 
> 1) append a "5" to every kcm docbook name
> 2) install every kcm docbook to SUBDIR kcontrol5
> 
> Both options require mass renaming X-DocPath, CMakeLists.txt, translation 
> catalogs etc.
> 
> For kioslave docbooks we already use SUBDIR kioslave5, so we should use 
> SUBDIR kcontrol5 to keep consistency

Regarding co-installable:

frameworks/kdelibs4support has docs/kcontrol/kcm_ssl/index.docbook since 5.0.0
debian testing (stretch) and ubuntu 16.10 (yakkety) install 
kcm_ssl/index.docbook in
/usr/share/doc/kde/HTML/en/kcontrol/ from package kde-runtime-data
and
/usr/share/doc/HTML/en/kcontrol/ from package libkf5kdelibs4support-data
i.e. distinguished using an additional subdir "kde" in the install path from 
package kde-runtime-data

So we have apparently no conflict in debian based distributions and apparently 
no conflict in builds from sources (no one complained since frameworks 5.0.0)

Is this really a conflict in rpm based systems e.g. SuSe, RedHat ?


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/#review99183
---


On Sept. 15, 2016, 9:09 vorm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128912/
> ---
> 
> (Updated Sept. 15, 2016, 9:09 vorm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Plasma.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
> doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
> doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
> splitted from kde-runtime master using https://github.com/ajdruff/git-splits
> 
> Not included in build so far, the docbooks are imported as they were splitted
> 
> To be done next:
> Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
> rename ebrowsing to webshortcuts
> reapply a few updates done in plasma-desktop
> remove these imported kcontrol docbooks from plasma-desktop
> adapt scripty to these changes
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/cache/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cache/index.docbook PRE-CREATION 
>   doc/kcontrol/cookies/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cookies/index.docbook PRE-CREATION 
>   doc/kcontrol/ebrowsing/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/ebrowsing/index.docbook PRE-CREATION 
>   doc/kcontrol/netpref/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/netpref/index.docbook PRE-CREATION 
>   doc/kcontrol/proxy/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/proxy/index.docbook PRE-CREATION 
>   doc/kcontrol/smb/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/smb/index.docbook PRE-CREATION 
>   doc/kcontrol/useragent/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/useragent/index.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128912/diff/
> 
> 
> Testing
> ---
> 
> history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
> master
> 
> 
> File Attachments
> 
> 
> git-log-doc-kcontrol.output
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

[Burkhard Lück]

> On Sept. 15, 2016, 7:28 vorm., Luigi Toscano wrote:
> > Can they be made co-installable with the ones with kde-runtime, as both 
> > modules can be available at the same time? This is the problem of the 
> > missing support for kcontrol5
> > 
> > It was already done some time ago and I had to revert it:
> > https://marc.info/?t=14207454037=1=1
> > https://marc.info/?l=kde-i18n-doc=142076318528227=1

Sure we can make them co-installable, we just need to decide how to do it
so far in kf5 we install to ${HTML_INSTALL_DIR}/en SUBDIR kcontrol/ = same 
subdir as kde4/kde-runtime
all kcontrol docbooks have the same name in kf5 + kde4 except for cddbretrieval 
(kde4) / cddbretrieval5 (kf5) and ebrowsing (kde4) / webshortcuts (kf5)

Options for co-installable:

1) append a "5" to every kcm docbook name
2) install every kcm docbook to SUBDIR kcontrol5

Both options require mass renaming X-DocPath, CMakeLists.txt, translation 
catalogs etc.

For kioslave docbooks we already use SUBDIR kioslave5, so we should use SUBDIR 
kcontrol5 to keep consistency


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/#review99183
---


On Sept. 15, 2016, 6:57 vorm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128912/
> ---
> 
> (Updated Sept. 15, 2016, 6:57 vorm.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
> doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
> doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
> splitted from kde-runtime master using https://github.com/ajdruff/git-splits
> 
> Not included in build so far, the docbooks are imported as they were splitted
> 
> To be done next:
> Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
> rename ebrowsing to webshortcuts
> reapply a few updates done in plasma-desktop
> remove these imported kcontrol docbooks from plasma-desktop
> adapt scripty to these changes
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/cache/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cache/index.docbook PRE-CREATION 
>   doc/kcontrol/cookies/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/cookies/index.docbook PRE-CREATION 
>   doc/kcontrol/ebrowsing/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/ebrowsing/index.docbook PRE-CREATION 
>   doc/kcontrol/netpref/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/netpref/index.docbook PRE-CREATION 
>   doc/kcontrol/proxy/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/proxy/index.docbook PRE-CREATION 
>   doc/kcontrol/smb/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/smb/index.docbook PRE-CREATION 
>   doc/kcontrol/useragent/CMakeLists.txt PRE-CREATION 
>   doc/kcontrol/useragent/index.docbook PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128912/diff/
> 
> 
> Testing
> ---
> 
> history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
> master
> 
> 
> File Attachments
> 
> 
> git-log-doc-kcontrol.output
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Review Request 128912: Import kcontrol docbooks for code in kio from kde-runtime master

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128912/
---

Review request for KDE Frameworks.


Repository: kio


Description
---

doc/kcontrol/cache doc/kcontrol/proxy doc/kcontrol/useragent 
doc/kcontrol/cookies/ doc/kcontrol/useragent/ doc/kcontrol/netpref/ 
doc/kcontrol/ebrowsing/ doc/kcontrol/smb/
splitted from kde-runtime master using https://github.com/ajdruff/git-splits

Not included in build so far, the docbooks are imported as they were splitted

To be done next:
Move to existing subdir docs, adapt CMakeLists.txt, change dtd to kf5, 
rename ebrowsing to webshortcuts
reapply a few updates done in plasma-desktop
remove these imported kcontrol docbooks from plasma-desktop
adapt scripty to these changes


Diffs
-

  doc/kcontrol/cache/CMakeLists.txt PRE-CREATION 
  doc/kcontrol/cache/index.docbook PRE-CREATION 
  doc/kcontrol/cookies/CMakeLists.txt PRE-CREATION 
  doc/kcontrol/cookies/index.docbook PRE-CREATION 
  doc/kcontrol/ebrowsing/CMakeLists.txt PRE-CREATION 
  doc/kcontrol/ebrowsing/index.docbook PRE-CREATION 
  doc/kcontrol/netpref/CMakeLists.txt PRE-CREATION 
  doc/kcontrol/netpref/index.docbook PRE-CREATION 
  doc/kcontrol/proxy/CMakeLists.txt PRE-CREATION 
  doc/kcontrol/proxy/index.docbook PRE-CREATION 
  doc/kcontrol/smb/CMakeLists.txt PRE-CREATION 
  doc/kcontrol/smb/index.docbook PRE-CREATION 
  doc/kcontrol/useragent/CMakeLists.txt PRE-CREATION 
  doc/kcontrol/useragent/index.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/128912/diff/


Testing
---

history looks good, see git-log-doc-kcontrol.output, same log in kde-runtime 
master


File Attachments


git-log-doc-kcontrol.output
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/15/94d16f46-6d99-4597-b7a4-3ba4add1dee0__git-log-doc-kcontrol.output


Thanks,

Burkhard Lück

Re: Autocorrection in framework

[Burkhard Lück]

Am Mittwoch, 31. August 2016, 08:48:58 CEST schrieb Kai Uwe Broulik:
> Hi,
> 
> Sonnet maybe?
> 
Quoting Albert Astals Cid on kde-i18n-...@kde.org:
> 
> That en_US.xml file doesn't belong to sonnet (at least not at the moment)
> 
> Sonnet has nothing to do with the autocorrect feature.
> 
> The problem is that both pim and calligra implement their own parsing of
> that file https://lxr.kde.org/source/calligra/calligra/plugins/textediting/
autocorrection/Autocorrect.cpp#0771
> https://lxr.kde.org/source/kde/pim/pimcommon/src/autocorrection/import/
importkmailautocorrection.cpp#0035 
> so there's no "right" place for that file.
> 
> What would make sense is move that parsing code to a framework and then the
> logical place for that en_US.xml file will be that very same framework.
> 

-- 
Burkhard Lück

Re: Review Request 128739: Fix build with Qt < 5.6

[Burkhard Lück]

> On Aug. 23, 2016, 11:27 vorm., Heiko Becker wrote:
> > ?[12:11] ?? commit it if someone can test with the appropriate 
> > Qt versions
> > ...
> > ?[12:13] ?? hmm, I have the right Qt versions. I can download the 
> > pat-
> > ...
> > ?[12:31] ?? heirecka: I ended up applying to patch manually..., and 
> > it compiles fine now :)

Your patch breaks build with Qt 5.6.1 for me

I need this patch on to of yours to get it build:
index 4607966..abc50af 100644
--- a/src/core/guesslanguage.cpp
+++ b/src/core/guesslanguage.cpp
@@ -489,7 +489,7 @@ GuessLanguagePrivate::GuessLanguagePrivate()
 case QChar::Script_WarangCiti:
 names = getNames(QLocale::VarangKshitiScript);
 break;
-#if QT_VERSION >= QT_VERSION_CHECK(5, 6, 0)
+#if QT_VERSION > QT_VERSION_CHECK(5, 6, 1)
 case QChar::Script_Ahom:
 names = getNames(QLocale::AhomScript);
 break;


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128739/#review98566
---


On Aug. 23, 2016, 11:28 vorm., Heiko Becker wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128739/
> ---
> 
> (Updated Aug. 23, 2016, 11:28 vorm.)
> 
> 
> Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Repository: sonnet
> 
> 
> Description
> ---
> 
> Also correct the other #ifdef because like QChar::Script_SignWriting
> 0e1f3aab11a4310595d8651c02ce5f9d60c93252 in qtbase.git introduced the
> other enums as well. That commit was first released with Qt 5.6
> 
> BUG: 366789
> CCMAIL: martin.sandsm...@kde.org
> 
> 
> Diffs
> -
> 
>   src/core/guesslanguage.cpp 5c5239fbe99c9a3ea95bd07dc4d0ec6582897379 
> 
> Diff: https://git.reviewboard.kde.org/r/128739/diff/
> 
> 
> Testing
> ---
> 
> Haven't an old Qt around, tested building with 5.7. though.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
>

Re: Review Request 128638: Move kwallet-query docbook to correct subdir

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128638/
---

(Updated Aug. 11, 2016, 1:29 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Changes
---

Submitted with commit 0b8e243efe73fffd1a7c018e24368170d0f9a11d by Burkhard Lück 
to branch master.


Repository: kwallet


Description
---

move docbook into subdit with matching name in l10n subdir + adapt 
docs/CMakeLists.txt

Rationale:

The Translated docbooks in this frameworks are missing in the tarball, see 
https://todo.kde.org/?controller=task=show_id=520

To find out which subdir of docs/frameworks subdir it should grab translated
docs from, the frameworks release script uses the name of the subdir in the 
sources.

On the other hand the script autogen.sh in l10n-kf5/scripts generates the 
CMakeLists.txt files
with the correct install paths/names for the language docbooks using the 
dirnames in l10n/[lang]/documentation.


Diffs
-

  docs/CMakeLists.txt c4ef9c7 
  docs/kwallet-query/CMakeLists.txt PRE-CREATION 
  docs/kwallet-query/man-kwallet-query.1.docbook PRE-CREATION 
  docs/kwallet-query/using.adoc PRE-CREATION 
  docs/man-kwallet-query.1.docbook eed6e43 
  docs/using.adoc e2e01e4 

Diff: https://git.reviewboard.kde.org/r/128638/diff/


Testing
---

builds and installs the manpage to the same dir as before


Thanks,

Burkhard Lück

Re: Review Request 128652: Fix wording an -> one

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128652/
---

(Updated Aug. 11, 2016, 4:27 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, KDE Utils, Ragnar Thomsen, and Valentin Rusu.


Changes
---

Submitted with commit 7cc97c7f0b3ee4359175ae21d135d6e8f6dd5367 by Burkhard Lück 
to branch master.


Repository: kwallet


Description
---

Change "Please set-up at least an encryption key" to  "Please set-up at least 
one encryption key" as requested in RR https://git.reviewboard.kde.org/r/128378/


Diffs
-

  src/runtime/kwalletd/knewwalletdialog.cpp f0c1b36 

Diff: https://git.reviewboard.kde.org/r/128652/diff/


Testing
---

builds


Thanks,

Burkhard Lück

Review Request 128652: Fix wording an -> one

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128652/
---

Review request for KDE Frameworks, KDE Utils, Ragnar Thomsen, and Valentin Rusu.


Repository: kwallet


Description
---

Change "Please set-up at least an encryption key" to  "Please set-up at least 
one encryption key" as requested in RR https://git.reviewboard.kde.org/r/128378/


Diffs
-

  src/runtime/kwalletd/knewwalletdialog.cpp f0c1b36 

Diff: https://git.reviewboard.kde.org/r/128652/diff/


Testing
---

builds


Thanks,

Burkhard Lück

Review Request 128638: Move kwallet-query docbook to correct subdir

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128638/
---

Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Repository: kwallet


Description
---

move docbook into subdit with matching name in l10n subdir + adapt 
docs/CMakeLists.txt

Rationale:

The Translated docbooks in this frameworks are missing in the tarball, see 
https://todo.kde.org/?controller=task=show_id=520

To find out which subdir of docs/frameworks subdir it should grab translated
docs from, the frameworks release script uses the name of the subdir in the 
sources.

On the other hand the script autogen.sh in l10n-kf5/scripts generates the 
CMakeLists.txt files
with the correct install paths/names for the language docbooks using the 
dirnames in l10n/[lang]/documentation.


Diffs
-

  docs/CMakeLists.txt c4ef9c7 
  docs/kwallet-query/CMakeLists.txt PRE-CREATION 
  docs/kwallet-query/man-kwallet-query.1.docbook PRE-CREATION 
  docs/kwallet-query/using.adoc PRE-CREATION 
  docs/man-kwallet-query.1.docbook eed6e43 
  docs/using.adoc e2e01e4 

Diff: https://git.reviewboard.kde.org/r/128638/diff/


Testing
---

builds and installs the manpage to the same dir as before


Thanks,

Burkhard Lück

Re: Review Request 127906: update qt5options manpage docbook to qt 5.6

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127906/
---

(Updated Juni 14, 2016, 7:22 nachm.)


Status
--

This change has been marked as submitted.


Review request for Documentation, KDE Frameworks and David Faure.


Repository: kdoctools


Description
---

All options in this docbook like

display, session, cmap, ncols, nograb, dograb, sync, fn, bg, fg, btn, name, 
title, visual, inputstyle, im, noxim, reverse, stylesheet

are valid for Qt 3.3 QApplication, see

http://doc.qt.io/archives/3.3/qapplication.html#QApplication


In Qt 5.6 a QApplication automatically supports a few command line options like 
style, stylesheet, widgetcount, reverse, qmljsdebugger
see http://doc.qt.io/qt-5/qapplication.html


Do we really want to provide a manpage docbook for that?


Diffs
-

  docs/qt5options/man-qt5options.7.docbook d5891eb 

Diff: https://git.reviewboard.kde.org/r/127906/diff/


Testing
---


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127906: update qt5options manpage docbook to qt 5.6

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127906/
---

(Updated Juni 14, 2016, 6:41 nachm.)


Review request for Documentation, KDE Frameworks and David Faure.


Changes
---

update fixing issues spotted by David


Repository: kdoctools


Description
---

All options in this docbook like

display, session, cmap, ncols, nograb, dograb, sync, fn, bg, fg, btn, name, 
title, visual, inputstyle, im, noxim, reverse, stylesheet

are valid for Qt 3.3 QApplication, see

http://doc.qt.io/archives/3.3/qapplication.html#QApplication


In Qt 5.6 a QApplication automatically supports a few command line options like 
style, stylesheet, widgetcount, reverse, qmljsdebugger
see http://doc.qt.io/qt-5/qapplication.html


Do we really want to provide a manpage docbook for that?


Diffs (updated)
-

  docs/qt5options/man-qt5options.7.docbook d5891eb 

Diff: https://git.reviewboard.kde.org/r/127906/diff/


Testing
---


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127903: Update kf5options manpage docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127903/
---

(Updated June 14, 2016, 4:51 a.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation and KDE Frameworks.


Changes
---

Submitted with commit a32088478d6241214ffdbc0df5f41a5e5dd95cb0 by Burkhard Lück 
to branch master.


Repository: kdoctools


Description
---

replace the obsolete content with updates
Use case for option desktopfile borrowed von Martin Gräßlins commit log

See Also: qt5options - does that really make sense for a kf5 app?
I really doubt that the qt5options manpage is uptodate


Diffs
-

  docs/kf5options/man-kf5options.7.docbook f79d42c 

Diff: https://git.reviewboard.kde.org/r/127903/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127927: Move kcm_ssl kcm docs to subdir docs/kcontrol

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127927/
---

(Updated June 13, 2016, 2:03 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Changes
---

Submitted with commit da90ceae257821b215bc6dd232cb7c83a9592eae by Burkhard Lück 
to branch master.


Repository: kdelibs4support


Description
---

move directory + adapt/add CMakeLists.txt files

this change is necessary to fetch translated kcm_ssl docs 
withaout hacks either in frameworks release script or in autogen.sh
into the frameworks tarball.

See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation

Together with commiting this change I'll adapt Scripty.


Diffs
-

  docs/CMakeLists.txt b1e2a72 
  docs/kcm_ssl/CMakeLists.txt 4d3bc75 
  docs/kcm_ssl/details.png e0d7074 
  docs/kcm_ssl/index.docbook f5d3ef1 
  docs/kcm_ssl/module.png 2f69c6e 
  docs/kcontrol/CMakeLists.txt PRE-CREATION 
  docs/kcontrol/kcm_ssl/CMakeLists.txt PRE-CREATION 
  docs/kcontrol/kcm_ssl/details.png PRE-CREATION 
  docs/kcontrol/kcm_ssl/index.docbook PRE-CREATION 
  docs/kcontrol/kcm_ssl/module.png PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127927/diff/


Testing
---

builds and installs the kcm docs to the same installdir as before


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127940: Rename docs/plasmapkg directory to docs/plasmapkg2

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127940/
---

(Updated June 13, 2016, 3:56 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Changes
---

Submitted with commit eaef2f166a75642558bac645045aa532a36de263 by Burkhard Lück 
to branch master.


Repository: plasma-framework


Description
---

rename directory + adapt CMakeLists.txt file

this change is necessary to fetch translated manpage docs 
without hacks either in frameworks release script or in autogen.sh
into the frameworks tarball.

See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation

Together with commiting this change I'll adapt Scripty.


Diffs
-

  docs/CMakeLists.txt 2acc3f0 
  docs/plasmapkg/CMakeLists.txt a78d3bd 
  docs/plasmapkg/man-plasmapkg2.1.docbook 0952bd2 
  docs/plasmapkg2/CMakeLists.txt PRE-CREATION 
  docs/plasmapkg2/man-plasmapkg2.1.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127940/diff/


Testing
---

builds and installs the manpage to the same installdir as before


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127939: Move src/runtime/kwallet-query/doc/ to docs/

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127939/
---

(Updated June 13, 2016, 1:52 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Changes
---

Submitted with commit 887dc1032277e26b68efab0750e9e3faabea5c33 by Burkhard Lück 
to branch master.


Repository: kwallet


Description
---

move directory + adapt CMakeLists.txt files

this change is necessary to fetch translated kioslave docs 
without hacks either in frameworks release script or in autogen.sh
into the frameworks tarball.

See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation

Together with commiting this change I'll adapt Scripty.


Diffs
-

  CMakeLists.txt 4b19dd4 
  docs/CMakeLists.txt PRE-CREATION 
  docs/man-kwallet-query.1.docbook PRE-CREATION 
  docs/using.adoc PRE-CREATION 
  src/runtime/kwallet-query/CMakeLists.txt 9e02cde 
  src/runtime/kwallet-query/doc/CMakeLists.txt c4ef9c7 
  src/runtime/kwallet-query/doc/man-kwallet-query.1.docbook 1adc418 
  src/runtime/kwallet-query/doc/using.adoc e2e01e4 

Diff: https://git.reviewboard.kde.org/r/127939/diff/


Testing
---

builds and installs the man page to the same installdir as before


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127938: Rename docs/kross directory to docs/kf5kross

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127938/
---

(Updated June 13, 2016, 1:48 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Changes
---

Submitted with commit 7f336f8b905548dd326bfc5b696677d0e6ad752a by Burkhard Lück 
to branch master.


Repository: kross


Description
---

rename directory + adapt CMakeLists.txt file

this change is necessary to fetch translated manpage docs 
without hacks either in frameworks release script or in autogen.sh
into the frameworks tarball.

See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation

Together with commiting this change I'll adapt Scripty.


Diffs
-

  docs/CMakeLists.txt 0b0b85e 
  docs/kf5kross/CMakeLists.txt PRE-CREATION 
  docs/kf5kross/man-kf5kross.1.docbook PRE-CREATION 
  docs/kross/CMakeLists.txt b95a444 
  docs/kross/man-kf5kross.1.docbook 0f50d79 

Diff: https://git.reviewboard.kde.org/r/127938/diff/


Testing
---

builds and installs the docs to the same installdir as before


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127928: Rename docs/kioslave directory to docs/kioslave5

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127928/
---

(Updated June 13, 2016, 1:43 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Changes
---

Submitted with commit 77851d0de4101ba967acc72832cd6e08bcde454d by Burkhard Lück 
to branch master.


Repository: kio


Description
---

rename directory + adapt CMakeLists.txt file

this change is necessary to fetch translated kioslave docs 
without hacks either in frameworks release script or in autogen.sh
into the frameworks tarball.

See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation

Together with commiting this change I'll adapt Scripty.


Diffs
-

  docs/CMakeLists.txt 7d23a35 
  docs/kioslave/CMakeLists.txt 127af91 
  docs/kioslave/data/CMakeLists.txt 3c5edda 
  docs/kioslave/data/index.docbook 2cb24b4 
  docs/kioslave/file/CMakeLists.txt bdcc8dd 
  docs/kioslave/file/index.docbook 38e9d05 
  docs/kioslave/ftp/CMakeLists.txt 2a6b6dd 
  docs/kioslave/ftp/index.docbook 6e7e475 
  docs/kioslave/help/CMakeLists.txt 98cb154 
  docs/kioslave/help/documentationnotfound/CMakeLists.txt 22394d6 
  docs/kioslave/help/documentationnotfound/index.docbook c7d6822 
  docs/kioslave/help/index.docbook 3c5d822 
  docs/kioslave/http/CMakeLists.txt efeaa02 
  docs/kioslave/http/index.docbook c3fbef8 
  docs/kioslave/mailto/CMakeLists.txt 96185b8 
  docs/kioslave/mailto/index.docbook 2878ece 
  docs/kioslave/telnet/CMakeLists.txt 067fd33 
  docs/kioslave/telnet/index.docbook d1bda3d 
  docs/kioslave/webdav/CMakeLists.txt a767168 
  docs/kioslave/webdav/index.docbook 35f1b99 
  docs/kioslave5/CMakeLists.txt PRE-CREATION 
  docs/kioslave5/data/CMakeLists.txt PRE-CREATION 
  docs/kioslave5/data/index.docbook PRE-CREATION 
  docs/kioslave5/file/CMakeLists.txt PRE-CREATION 
  docs/kioslave5/file/index.docbook PRE-CREATION 
  docs/kioslave5/ftp/CMakeLists.txt PRE-CREATION 
  docs/kioslave5/ftp/index.docbook PRE-CREATION 
  docs/kioslave5/help/CMakeLists.txt PRE-CREATION 
  docs/kioslave5/help/documentationnotfound/CMakeLists.txt PRE-CREATION 
  docs/kioslave5/help/documentationnotfound/index.docbook PRE-CREATION 
  docs/kioslave5/help/index.docbook PRE-CREATION 
  docs/kioslave5/http/CMakeLists.txt PRE-CREATION 
  docs/kioslave5/http/index.docbook PRE-CREATION 
  docs/kioslave5/mailto/CMakeLists.txt PRE-CREATION 
  docs/kioslave5/mailto/index.docbook PRE-CREATION 
  docs/kioslave5/telnet/CMakeLists.txt PRE-CREATION 
  docs/kioslave5/telnet/index.docbook PRE-CREATION 
  docs/kioslave5/webdav/CMakeLists.txt PRE-CREATION 
  docs/kioslave5/webdav/index.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127928/diff/


Testing
---

builds and installs the kcm docs to the same installdir as before


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127906: update qt5options manpage docbook to qt 5.6

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127906/
---

(Updated Juni 8, 2016, 4:57 vorm.)


Review request for Documentation, KDE Frameworks and David Faure.


Changes
---

update resolving issues from Luigi Toscano


Repository: kdoctools


Description
---

All options in this docbook like

display, session, cmap, ncols, nograb, dograb, sync, fn, bg, fg, btn, name, 
title, visual, inputstyle, im, noxim, reverse, stylesheet

are valid for Qt 3.3 QApplication, see

http://doc.qt.io/archives/3.3/qapplication.html#QApplication


In Qt 5.6 a QApplication automatically supports a few command line options like 
style, stylesheet, widgetcount, reverse, qmljsdebugger
see http://doc.qt.io/qt-5/qapplication.html


Do we really want to provide a manpage docbook for that?


Diffs (updated)
-

  docs/qt5options/man-qt5options.7.docbook d5891eb 

Diff: https://git.reviewboard.kde.org/r/127906/diff/


Testing
---


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127903: Update kf5options manpage docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127903/
---

(Updated Juni 8, 2016, 4:42 vorm.)


Review request for Documentation and KDE Frameworks.


Changes
---

update fixing issues from Luigi Toscanos review


Repository: kdoctools


Description
---

replace the obsolete content with updates
Use case for option desktopfile borrowed von Martin Gräßlins commit log

See Also: qt5options - does that really make sense for a kf5 app?
I really doubt that the qt5options manpage is uptodate


Diffs (updated)
-

  docs/kf5options/man-kf5options.7.docbook f79d42c 

Diff: https://git.reviewboard.kde.org/r/127903/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127927: Move kcm_ssl kcm docs to subdir docs/kcontrol

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127927/#review96232
---



ping, 5.23 is coming soon

- Burkhard Lück


On Mai 15, 2016, 12:50 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127927/
> ---
> 
> (Updated Mai 15, 2016, 12:50 nachm.)
> 
> 
> Review request for KDE Frameworks, Localization and Translation (l10n) and 
> David Faure.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> ---
> 
> move directory + adapt/add CMakeLists.txt files
> 
> this change is necessary to fetch translated kcm_ssl docs 
> withaout hacks either in frameworks release script or in autogen.sh
> into the frameworks tarball.
> 
> See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation
> 
> Together with commiting this change I'll adapt Scripty.
> 
> 
> Diffs
> -
> 
>   docs/CMakeLists.txt b1e2a72 
>   docs/kcm_ssl/CMakeLists.txt 4d3bc75 
>   docs/kcm_ssl/details.png e0d7074 
>   docs/kcm_ssl/index.docbook f5d3ef1 
>   docs/kcm_ssl/module.png 2f69c6e 
>   docs/kcontrol/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol/kcm_ssl/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol/kcm_ssl/details.png PRE-CREATION 
>   docs/kcontrol/kcm_ssl/index.docbook PRE-CREATION 
>   docs/kcontrol/kcm_ssl/module.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127927/diff/
> 
> 
> Testing
> ---
> 
> builds and installs the kcm docs to the same installdir as before
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127906: update qt5options manpage docbook to qt 5.6

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127906/
---

(Updated Juni 4, 2016, 7:46 nachm.)


Review request for Documentation, KDE Frameworks and David Faure.


Changes
---

update to 5.6 intead of deleting the outdated man page for qt 3.3


Summary (updated)
-

update qt5options manpage docbook to qt 5.6


Repository: kdoctools


Description
---

All options in this docbook like

display, session, cmap, ncols, nograb, dograb, sync, fn, bg, fg, btn, name, 
title, visual, inputstyle, im, noxim, reverse, stylesheet

are valid for Qt 3.3 QApplication, see

http://doc.qt.io/archives/3.3/qapplication.html#QApplication


In Qt 5.6 a QApplication automatically supports a few command line options like 
style, stylesheet, widgetcount, reverse, qmljsdebugger
see http://doc.qt.io/qt-5/qapplication.html


Do we really want to provide a manpage docbook for that?


Diffs (updated)
-

  docs/qt5options/man-qt5options.7.docbook d5891eb 

Diff: https://git.reviewboard.kde.org/r/127906/diff/


Testing
---


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

[Burkhard Lück]

> On Mai 29, 2016, 3:51 nachm., Kai Uwe Broulik wrote:
> > src/kstatusnotifieritem.cpp, line 909
> > <https://git.reviewboard.kde.org/r/126369/diff/4/?file=467228#file467228line909>
> >
> > i18nc please
> 
> René J.V. Bertin wrote:
> I'm not sure what to expect here, what effect is using `i18nc("!")` going 
> to have? AFAIK the exclamation mark is pretty universal, and translating it 
> might reduce the label's effectiveness. I've tried many options to label the 
> Dock icon (that's what we're talking about here) and found no better 
> alternative.
> 
> Kai Uwe Broulik wrote:
> We cannot assume that. Greek does not use the "?" question mark symbol, 
> for example. That's where the "c" comes in, you explain translators that you 
> exactly want ("one symbol")
> 
> Burkhard Lück wrote:
> To say "one symbol" is not sufficient for translators.
> You need to explain what this char is used for, its role in the gui, see 
> http://api.kde.org/frameworks/ki18n/html/prg_guide.html#good_ctxt
> 
> René J.V. Bertin wrote:
> Not to appear stubborn, but in your example, wouldn't a Greek font use 
> the appropriate symbol at the place of the question mark? Or do I need to 
> specify the `U+` Unicode code for that, like I do for the bullet?

You say "the exclamation mark is pretty universal" and that maybe true, but 
what about locales not having something like an exclamation mark?
translation teams have their locale with their specific character set *and* 
style guides how to translate
E. g in the german translation team we never translate an exclamation mark at 
the end of a messages literally, it nearly always is replaced by a period
context like noun or verb or U+ Unicode code have no meaning for translators


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126369/#review95984
---


On Mai 29, 2016, 6:03 nachm., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126369/
> ---
> 
> (Updated Mai 29, 2016, 6:03 nachm.)
> 
> 
> Review request for KDE Software on Mac OS X and KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> OS X has a number of limitations in features used by KNotifications, notably 
> concerning the status notifier item (aka system tray icon).
> 
> This RR will likely evolve to address multiple limitations (at least also the 
> NeedsAttention state); at the moment it only proposes an emulation of 
> `QMenu::addSection`.
> 
> `QMenu::addSection` works by adding a QAction with a "texted separator" at 
> the insertion location. Texted separators do not exist in menu items in the 
> OS X "global" menubar (they become regular separators), and Qt will not 
> provide a platform-specific implementation. Loss of the section title text is 
> maybe not always an issue, but I think it is in the system tray menu. I 
> therefore propose to emulate `QMenu::addSection` by replacing the texted 
> separator with an inactive (disabled) menu item that shows the text, followed 
> by a standard separator. Menus in the notification area are much less subject 
> to interface guidelines, so the presence of an item icon is acceptable and 
> IMO useful for the `titleAction`.
> 
> Testing the NeedsAttention state with the tests/kstatusnotifieritemtest 
> application leads to disappearance of the menubar icon, i.e. the access to 
> the notifier menu becomes invisible rather than blinking (which is what I get 
> on Linux using the same packaging). Adding a few qDebug statements shows that 
> the `attentionIcon` is empty.
> I'd appreciate a crash course how this feature is supposed to work, so I can 
> see if an OS X implementation might be feasible.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 7cf8379 
>   src/CMakeLists.txt 7eb3125 
>   src/knotification.cpp 352cf49 
>   src/kstatusnotifieritem.cpp 27abfb8 
>   src/kstatusnotifieritemprivate_p.h 8fdfd4c 
>   src/notifybypopup.cpp 7d69a36 
>   tests/kstatusnotifieritemtest.cpp 973fc85 
> 
> Diff: https://git.reviewboard.kde.org/r/126369/diff/
> 
> 
> Testing
> ---
> 
> On OS X 10.9.5 with Qt 5.5.1 and frameworks 5.17.0 .
> 
> 
> File Attachments
> 
> 
> the systray icon & menu created by kstatusnotifieritemtest . This application 
> has no icon to show.
>

Re: Review Request 126369: [OS X] adaptation(s) to platform limitations (WIP)

[Burkhard Lück]

> On Mai 29, 2016, 3:51 nachm., Kai Uwe Broulik wrote:
> > src/kstatusnotifieritem.cpp, line 909
> > 
> >
> > i18nc please
> 
> René J.V. Bertin wrote:
> I'm not sure what to expect here, what effect is using `i18nc("!")` going 
> to have? AFAIK the exclamation mark is pretty universal, and translating it 
> might reduce the label's effectiveness. I've tried many options to label the 
> Dock icon (that's what we're talking about here) and found no better 
> alternative.
> 
> Kai Uwe Broulik wrote:
> We cannot assume that. Greek does not use the "?" question mark symbol, 
> for example. That's where the "c" comes in, you explain translators that you 
> exactly want ("one symbol")

To say "one symbol" is not sufficient for translators.
You need to explain what this char is used for, its role in the gui, see 
http://api.kde.org/frameworks/ki18n/html/prg_guide.html#good_ctxt


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126369/#review95984
---


On Mai 29, 2016, 3:41 nachm., René J.V. Bertin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126369/
> ---
> 
> (Updated Mai 29, 2016, 3:41 nachm.)
> 
> 
> Review request for KDE Software on Mac OS X and KDE Frameworks.
> 
> 
> Repository: knotifications
> 
> 
> Description
> ---
> 
> OS X has a number of limitations in features used by KNotifications, notably 
> concerning the status notifier item (aka system tray icon).
> 
> This RR will likely evolve to address multiple limitations (at least also the 
> NeedsAttention state); at the moment it only proposes an emulation of 
> `QMenu::addSection`.
> 
> `QMenu::addSection` works by adding a QAction with a "texted separator" at 
> the insertion location. Texted separators do not exist in menu items in the 
> OS X "global" menubar (they become regular separators), and Qt will not 
> provide a platform-specific implementation. Loss of the section title text is 
> maybe not always an issue, but I think it is in the system tray menu. I 
> therefore propose to emulate `QMenu::addSection` by replacing the texted 
> separator with an inactive (disabled) menu item that shows the text, followed 
> by a standard separator. Menus in the notification area are much less subject 
> to interface guidelines, so the presence of an item icon is acceptable and 
> IMO useful for the `titleAction`.
> 
> Testing the NeedsAttention state with the tests/kstatusnotifieritemtest 
> application leads to disappearance of the menubar icon, i.e. the access to 
> the notifier menu becomes invisible rather than blinking (which is what I get 
> on Linux using the same packaging). Adding a few qDebug statements shows that 
> the `attentionIcon` is empty.
> I'd appreciate a crash course how this feature is supposed to work, so I can 
> see if an OS X implementation might be feasible.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 7cf8379 
>   src/CMakeLists.txt 7eb3125 
>   src/knotification.cpp 352cf49 
>   src/kstatusnotifieritem.cpp 27abfb8 
>   src/notifybypopup.cpp 7d69a36 
>   tests/kstatusnotifieritemtest.cpp 973fc85 
> 
> Diff: https://git.reviewboard.kde.org/r/126369/diff/
> 
> 
> Testing
> ---
> 
> On OS X 10.9.5 with Qt 5.5.1 and frameworks 5.17.0 .
> 
> 
> File Attachments
> 
> 
> the systray icon & menu created by kstatusnotifieritemtest . This application 
> has no icon to show.
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/286037ae-07b3-454a-a226-1748854493a1__kstatusnotifieritemtest-systray.png
> The systray icon and menu created by the KDE4 kwalletmanager (code has an 
> equivalent patch)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/4fc9d4e4-1537-478c-9196-94cbc17b6b7c__kwalletmanager-systray.png
> An Apple systray icon+menu that shows icons (which cannot be hidden)
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fc48a963-2e18-4396-bd38-062d41688118__Apple-systray-menu-with-icons.png
> kstatusnotifieritemtest with added appIcon
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/17/e896e90d-f0a8-43f7-9199-847572832df7__kstatusnotifieritemtest-with-appIcon.png
> kstatusnotifieritemtest-with-appIcon+attention.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2015/12/17/f41081db-8e09-4ea2-95c1-f507c62109d4__kstatusnotifieritemtest-with-appIconattention.png
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127906: Remove qt5options manpage docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127906/#review95890
---



If we want to provide a qt5options manpage we need at least these options:

http://doc.qt.io/qt-5/qapplication.html#QApplication

-style= style, sets the application GUI style. Possible values depend on the 
system configuration. 
If Qt is compiled with additional styles or has additional styles as plugins 
these will be available to the -style command line option.

-style style, is the same as listed above.

-stylesheet= stylesheet, sets the application styleSheet. The value must be a 
path to a file that contains the Style Sheet.

-stylesheet stylesheet, is the same as listed above.

-widgetcount, prints debug message at the end about number of widgets left 
undestroyed and maximum number of widgets existed at the same time

-reverse, sets the application's layout direction to Qt::RightToLeft

-qmljsdebugger=, activates the QML/JS debugger with a specified port. The value 
must be of format port:1234[,block], where block is optional and will make the 
application wait until a debugger connects to it.



http://doc.qt.io/qt-5/qguiapplication.html#QGuiApplication

-platform platformName[:options], specifies the Qt Platform Abstraction (QPA) 
plugin.

-platformpluginpath path, specifies the path to platform plugins.

-platformtheme platformTheme, specifies the platform theme.

-plugin plugin, specifies additional plugins to load. The argument may appear 
multiple times.

-qmljsdebugger=, activates the QML/JS debugger with a specified port. The value 
must be of format port:1234[,block], where block is optional and will make the 
application wait until a debugger connects to it.

-qwindowgeometry geometry, specifies window geometry for the main window using 
the X11-syntax. For example: -qwindowgeometry 100x100+50+50

-qwindowicon, sets the default window icon

-qwindowtitle, sets the title of the first window

-reverse, sets the application's layout direction to Qt::RightToLeft. This 
option is intended to aid debugging and should not be used in production. The 
default value is automatically detected from the user's 
locale (see also QLocale::textDirection()).

-session session, restores the application from an earlier session.


The following standard command line options are available for X11:

-display hostname:screen_number, switches displays on X11.
Overrides the DISPLAY environment variable.

-geometry geometry, same as -qwindowgeometry.


Platform-Specific Arguments

The following parameters are available for -platform windows:

dialogs=[xp|none], xp uses XP-style native dialogs and none disables them.
fontengine=freetype, uses the FreeType font engine.


http://doc.qt.io/qt-5/qcommandlineparser.html

the help option (-h, --help and -? on Windows) This option is handled 
automatically by QCommandLineParser.

Remember to use setApplicationDescription to set the application description, 
which will be displayed when this option is used.

the -v / --version option, which displays the version string of the application.

- Burkhard Lück


On Mai 13, 2016, 2:12 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127906/
> ---
> 
> (Updated Mai 13, 2016, 2:12 nachm.)
> 
> 
> Review request for Documentation, KDE Frameworks and David Faure.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> All options in this docbook like
> 
> display, session, cmap, ncols, nograb, dograb, sync, fn, bg, fg, btn, name, 
> title, visual, inputstyle, im, noxim, reverse, stylesheet
> 
> are valid for Qt 3.3 QApplication, see
> 
> http://doc.qt.io/archives/3.3/qapplication.html#QApplication
> 
> 
> In Qt 5.6 a QApplication automatically supports a few command line options 
> like 
> style, stylesheet, widgetcount, reverse, qmljsdebugger
> see http://doc.qt.io/qt-5/qapplication.html
> 
> 
> Do we really want to provide a manpage docbook for that?
> 
> 
> Diffs
> -
> 
>   docs/CMakeLists.txt 4efee3b 
>   docs/qt5options/CMakeLists.txt 7e31e0f 
>   docs/qt5options/man-qt5options.7.docbook d5891eb 
> 
> Diff: https://git.reviewboard.kde.org/r/127906/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127903: Update kf5options manpage docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127903/#review95887
---



Please review

- Burkhard Lück


On Mai 26, 2016, 3:01 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127903/
> ---
> 
> (Updated Mai 26, 2016, 3:01 nachm.)
> 
> 
> Review request for Documentation and KDE Frameworks.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> replace the obsolete content with updates
> Use case for option desktopfile borrowed von Martin Gräßlins commit log
> 
> See Also: qt5options - does that really make sense for a kf5 app?
> I really doubt that the qt5options manpage is uptodate
> 
> 
> Diffs
> -
> 
>   docs/kf5options/man-kf5options.7.docbook f79d42c 
> 
> Diff: https://git.reviewboard.kde.org/r/127903/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127903: Update kf5options manpage docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127903/
---

(Updated Mai 26, 2016, 3:01 nachm.)


Review request for Documentation and KDE Frameworks.


Changes
---

remove trailing whitespace


Repository: kdoctools


Description
---

replace the obsolete content with updates
Use case for option desktopfile borrowed von Martin Gräßlins commit log

See Also: qt5options - does that really make sense for a kf5 app?
I really doubt that the qt5options manpage is uptodate


Diffs (updated)
-

  docs/kf5options/man-kf5options.7.docbook f79d42c 

Diff: https://git.reviewboard.kde.org/r/127903/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127927: Move kcm_ssl kcm docs to subdir docs/kcontrol

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127927/#review95808
---



@dfaure:
please don't forget to review this RR 127927 and 127928, 127938, 127939, 127940

- Burkhard Lück


On Mai 15, 2016, 12:50 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127927/
> ---
> 
> (Updated Mai 15, 2016, 12:50 nachm.)
> 
> 
> Review request for KDE Frameworks, Localization and Translation (l10n) and 
> David Faure.
> 
> 
> Repository: kdelibs4support
> 
> 
> Description
> ---
> 
> move directory + adapt/add CMakeLists.txt files
> 
> this change is necessary to fetch translated kcm_ssl docs 
> withaout hacks either in frameworks release script or in autogen.sh
> into the frameworks tarball.
> 
> See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation
> 
> Together with commiting this change I'll adapt Scripty.
> 
> 
> Diffs
> -
> 
>   docs/CMakeLists.txt b1e2a72 
>   docs/kcm_ssl/CMakeLists.txt 4d3bc75 
>   docs/kcm_ssl/details.png e0d7074 
>   docs/kcm_ssl/index.docbook f5d3ef1 
>   docs/kcm_ssl/module.png 2f69c6e 
>   docs/kcontrol/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol/kcm_ssl/CMakeLists.txt PRE-CREATION 
>   docs/kcontrol/kcm_ssl/details.png PRE-CREATION 
>   docs/kcontrol/kcm_ssl/index.docbook PRE-CREATION 
>   docs/kcontrol/kcm_ssl/module.png PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/127927/diff/
> 
> 
> Testing
> ---
> 
> builds and installs the kcm docs to the same installdir as before
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127935: Call kdoctools_create_handbook only for index.docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127935/#review95514
---


Ship it!




Ship It!

- Burkhard Lück


On Mai 16, 2016, 5:59 nachm., Luigi Toscano wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127935/
> ---
> 
> (Updated Mai 16, 2016, 5:59 nachm.)
> 
> 
> Review request for Documentation, KDE Frameworks and Elvis Angelaccio.
> 
> 
> Bugs: 357428
> https://bugs.kde.org/show_bug.cgi?id=357428
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> When more documentation files are available in a certain directory, the 
> assumption is that there should always be an index.docbook which
> imports all the other docbook files in the same directory. The call to 
> kdoctools_create_handbook must be created only for index.docbook;
> the macro takes care of the installation of the others docbooks. 
> This should make kdoctools_install work when there are multiple docbooks in 
> the same directory.
> 
> 
> Diffs
> -
> 
>   KF5DocToolsMacros.cmake 54761b6 
> 
> Diff: https://git.reviewboard.kde.org/r/127935/diff/
> 
> 
> Testing
> ---
> 
> Tried kdoctools_install when the (translated) documentation is made of 
> multiple docbooks (like krusader), see the bug for more details.
> 
> 
> Thanks,
> 
> Luigi Toscano
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127940: Rename docs/plasmapkg directory to docs/plasmapkg2

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127940/
---

Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Repository: plasma-framework


Description
---

rename directory + adapt CMakeLists.txt file

this change is necessary to fetch translated manpage docs 
without hacks either in frameworks release script or in autogen.sh
into the frameworks tarball.

See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation

Together with commiting this change I'll adapt Scripty.


Diffs
-

  docs/CMakeLists.txt 2acc3f0 
  docs/plasmapkg/CMakeLists.txt a78d3bd 
  docs/plasmapkg/man-plasmapkg2.1.docbook 0952bd2 
  docs/plasmapkg2/CMakeLists.txt PRE-CREATION 
  docs/plasmapkg2/man-plasmapkg2.1.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127940/diff/


Testing
---

builds and installs the manpage to the same installdir as before


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127939: Move src/runtime/kwallet-query/doc/ to docs/

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127939/
---

Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Repository: kwallet


Description
---

move directory + adapt CMakeLists.txt files

this change is necessary to fetch translated kioslave docs 
without hacks either in frameworks release script or in autogen.sh
into the frameworks tarball.

See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation

Together with commiting this change I'll adapt Scripty.


Diffs
-

  CMakeLists.txt 4b19dd4 
  docs/CMakeLists.txt PRE-CREATION 
  docs/man-kwallet-query.1.docbook PRE-CREATION 
  docs/using.adoc PRE-CREATION 
  src/runtime/kwallet-query/CMakeLists.txt 9e02cde 
  src/runtime/kwallet-query/doc/CMakeLists.txt c4ef9c7 
  src/runtime/kwallet-query/doc/man-kwallet-query.1.docbook 1adc418 
  src/runtime/kwallet-query/doc/using.adoc e2e01e4 

Diff: https://git.reviewboard.kde.org/r/127939/diff/


Testing
---

builds and installs the man page to the same installdir as before


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127938: Rename docs/kross directory to docs/kf5kross

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127938/
---

Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Repository: kross


Description
---

rename directory + adapt CMakeLists.txt file

this change is necessary to fetch translated manpage docs 
without hacks either in frameworks release script or in autogen.sh
into the frameworks tarball.

See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation

Together with commiting this change I'll adapt Scripty.


Diffs
-

  docs/CMakeLists.txt 0b0b85e 
  docs/kf5kross/CMakeLists.txt PRE-CREATION 
  docs/kf5kross/man-kf5kross.1.docbook PRE-CREATION 
  docs/kross/CMakeLists.txt b95a444 
  docs/kross/man-kf5kross.1.docbook 0f50d79 

Diff: https://git.reviewboard.kde.org/r/127938/diff/


Testing
---

builds and installs the docs to the same installdir as before


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127934: Rename docs/kjsembed directory to docs/kjsembed5

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127934/
---

(Updated May 16, 2016, 11:32 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Changes
---

Submitted with commit cdaef1ada478e465ce959039ed46e09d3975acad by Burkhard Lück 
to branch master.


Repository: kjsembed


Description
---

rename directory + adapt CMakeLists.txt file

this change is necessary to fetch translated kioslave docs 
without hacks either in frameworks release script or in autogen.sh
into the frameworks tarball.

See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation

Together with commiting this change I'll adapt Scripty.


Diffs
-

  docs/CMakeLists.txt c4df5bd 
  docs/kjscmd/CMakeLists.txt 993b2bc 
  docs/kjscmd/man-kjscmd5.1.docbook 2c8c1b6 
  docs/kjscmd5/CMakeLists.txt PRE-CREATION 
  docs/kjscmd5/man-kjscmd5.1.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127934/diff/


Testing
---

builds and installs the docs to the same installdir as before


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127933: Rename docs/kjs directory to docs/kjs5

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127933/
---

(Updated May 16, 2016, 11:26 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Changes
---

Submitted with commit 58577a3851f7aa005dcc47215a155ce35a01458a by Burkhard Lück 
to branch master.


Repository: kjs


Description
---

rename directory + adapt CMakeLists.txt file

this change is necessary to fetch translated kioslave docs 
without hacks either in frameworks release script or in autogen.sh
into the frameworks tarball.

See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation

Together with commiting this change I'll adapt Scripty.


Diffs
-

  docs/CMakeLists.txt 0fa6c95 
  docs/kjs/CMakeLists.txt 14ed344 
  docs/kjs/man-kjs5.1.docbook f2e5d83 
  docs/kjs5/CMakeLists.txt PRE-CREATION 
  docs/kjs5/man-kjs5.1.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127933/diff/


Testing
---

builds and installs the kcm docs to the same installdir as before


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127934: Rename docs/kjsembed directory to docs/kjsembed5

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127934/
---

Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Repository: kjsembed


Description
---

rename directory + adapt CMakeLists.txt file

this change is necessary to fetch translated kioslave docs 
without hacks either in frameworks release script or in autogen.sh
into the frameworks tarball.

See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation

Together with commiting this change I'll adapt Scripty.


Diffs
-

  docs/CMakeLists.txt c4df5bd 
  docs/kjscmd/CMakeLists.txt 993b2bc 
  docs/kjscmd/man-kjscmd5.1.docbook 2c8c1b6 
  docs/kjscmd5/CMakeLists.txt PRE-CREATION 
  docs/kjscmd5/man-kjscmd5.1.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127934/diff/


Testing
---

builds and installs the docs to the same installdir as before


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127933: Rename docs/kjs directory to docs/kjs5

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127933/
---

Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Repository: kjs


Description
---

rename directory + adapt CMakeLists.txt file

this change is necessary to fetch translated kioslave docs 
without hacks either in frameworks release script or in autogen.sh
into the frameworks tarball.

See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation

Together with commiting this change I'll adapt Scripty.


Diffs
-

  docs/CMakeLists.txt 0fa6c95 
  docs/kjs/CMakeLists.txt 14ed344 
  docs/kjs/man-kjs5.1.docbook f2e5d83 
  docs/kjs5/CMakeLists.txt PRE-CREATION 
  docs/kjs5/man-kjs5.1.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127933/diff/


Testing
---

builds and installs the kcm docs to the same installdir as before


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127928: Rename docs/kioslave directory to docs/kioslave5

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127928/
---

Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Repository: kio


Description
---

rename directory + adapt CMakeLists.txt file

this change is necessary to fetch translated kioslave docs 
without hacks either in frameworks release script or in autogen.sh
into the frameworks tarball.

See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation

Together with commiting this change I'll adapt Scripty.


Diffs
-

  docs/CMakeLists.txt 7d23a35 
  docs/kioslave/CMakeLists.txt 127af91 
  docs/kioslave/data/CMakeLists.txt 3c5edda 
  docs/kioslave/data/index.docbook 2cb24b4 
  docs/kioslave/file/CMakeLists.txt bdcc8dd 
  docs/kioslave/file/index.docbook 38e9d05 
  docs/kioslave/ftp/CMakeLists.txt 2a6b6dd 
  docs/kioslave/ftp/index.docbook 6e7e475 
  docs/kioslave/help/CMakeLists.txt 98cb154 
  docs/kioslave/help/documentationnotfound/CMakeLists.txt 22394d6 
  docs/kioslave/help/documentationnotfound/index.docbook c7d6822 
  docs/kioslave/help/index.docbook 3c5d822 
  docs/kioslave/http/CMakeLists.txt efeaa02 
  docs/kioslave/http/index.docbook c3fbef8 
  docs/kioslave/mailto/CMakeLists.txt 96185b8 
  docs/kioslave/mailto/index.docbook 2878ece 
  docs/kioslave/telnet/CMakeLists.txt 067fd33 
  docs/kioslave/telnet/index.docbook d1bda3d 
  docs/kioslave/webdav/CMakeLists.txt a767168 
  docs/kioslave/webdav/index.docbook 35f1b99 
  docs/kioslave5/CMakeLists.txt PRE-CREATION 
  docs/kioslave5/data/CMakeLists.txt PRE-CREATION 
  docs/kioslave5/data/index.docbook PRE-CREATION 
  docs/kioslave5/file/CMakeLists.txt PRE-CREATION 
  docs/kioslave5/file/index.docbook PRE-CREATION 
  docs/kioslave5/ftp/CMakeLists.txt PRE-CREATION 
  docs/kioslave5/ftp/index.docbook PRE-CREATION 
  docs/kioslave5/help/CMakeLists.txt PRE-CREATION 
  docs/kioslave5/help/documentationnotfound/CMakeLists.txt PRE-CREATION 
  docs/kioslave5/help/documentationnotfound/index.docbook PRE-CREATION 
  docs/kioslave5/help/index.docbook PRE-CREATION 
  docs/kioslave5/http/CMakeLists.txt PRE-CREATION 
  docs/kioslave5/http/index.docbook PRE-CREATION 
  docs/kioslave5/mailto/CMakeLists.txt PRE-CREATION 
  docs/kioslave5/mailto/index.docbook PRE-CREATION 
  docs/kioslave5/telnet/CMakeLists.txt PRE-CREATION 
  docs/kioslave5/telnet/index.docbook PRE-CREATION 
  docs/kioslave5/webdav/CMakeLists.txt PRE-CREATION 
  docs/kioslave5/webdav/index.docbook PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127928/diff/


Testing
---

builds and installs the kcm docs to the same installdir as before


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 127927: Move kcm_ssl kcm docs to subdir docs/kcontrol

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127927/
---

Review request for KDE Frameworks, Localization and Translation (l10n) and 
David Faure.


Repository: kdelibs4support


Description
---

move directory + adapt/add CMakeLists.txt files

this change is necessary to fetch translated kcm_ssl docs 
withaout hacks either in frameworks release script or in autogen.sh
into the frameworks tarball.

See also https://git.reviewboard.kde.org/r/127904/ for a detailed explanation

Together with commiting this change I'll adapt Scripty.


Diffs
-

  docs/CMakeLists.txt b1e2a72 
  docs/kcm_ssl/CMakeLists.txt 4d3bc75 
  docs/kcm_ssl/details.png e0d7074 
  docs/kcm_ssl/index.docbook f5d3ef1 
  docs/kcm_ssl/module.png 2f69c6e 
  docs/kcontrol/CMakeLists.txt PRE-CREATION 
  docs/kcontrol/kcm_ssl/CMakeLists.txt PRE-CREATION 
  docs/kcontrol/kcm_ssl/details.png PRE-CREATION 
  docs/kcontrol/kcm_ssl/index.docbook PRE-CREATION 
  docs/kcontrol/kcm_ssl/module.png PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/127927/diff/


Testing
---

builds and installs the kcm docs to the same installdir as before


Thanks,

Burkhard Lück

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127906: Remove qt5options manpage docbook

[Burkhard Lück]

> On Mai 13, 2016, 2:16 nachm., Luigi Toscano wrote:
> > Then we need to remove all references to qt5options (for example from 
> > kf5options).
> > We have the question about kf5options which comes immediately after.
> > 
> > It would be interesting to know if the (updated) content of qt5options 
> > could be contributed somehow directly to Qt.

We have only 5 references to qt5options in frameworks manpage docbooks, would 
be easy to remove.

In my RR for kf5options https://git.reviewboard.kde.org/r/127903/ I have 
already asked if the reference to qt5options should be removed.

I have no clue how an updated qt5options manpage docbook and all other formats 
we can generate from that can be used in Qt.


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127906/#review95452
---


On Mai 13, 2016, 2:12 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127906/
> ---
> 
> (Updated Mai 13, 2016, 2:12 nachm.)
> 
> 
> Review request for Documentation, KDE Frameworks and David Faure.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> All options in this docbook like
> 
> display, session, cmap, ncols, nograb, dograb, sync, fn, bg, fg, btn, name, 
> title, visual, inputstyle, im, noxim, reverse, stylesheet
> 
> are valid for Qt 3.3 QApplication, see
> 
> http://doc.qt.io/archives/3.3/qapplication.html#QApplication
> 
> 
> In Qt 5.6 a QApplication automatically supports a few command line options 
> like 
> style, stylesheet, widgetcount, reverse, qmljsdebugger
> see http://doc.qt.io/qt-5/qapplication.html
> 
> 
> Do we really want to provide a manpage docbook for that?
> 
> 
> Diffs
> -
> 
>   docs/CMakeLists.txt 4efee3b 
>   docs/qt5options/CMakeLists.txt 7e31e0f 
>   docs/qt5options/man-qt5options.7.docbook d5891eb 
> 
> Diff: https://git.reviewboard.kde.org/r/127906/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127906: Remove qt5options manpage docbook

[Burkhard Lück]

> On Mai 13, 2016, 2:14 nachm., David Faure wrote:
> > I don't have a strong opinion on whether to keep it or not, but note that 
> > your reasoning is incomplete. A lot of command-line options have moved up 
> > to the base classes QGuiApplication and QCoreApplication.

Thanks for the hint David.

Looking at the default options I found in QGuiApplication I believe still more 
than half of the options we describe in our qt5options manpage from Qt 3.3 are 
invalid.

Tbh we apparently fail already to keep the documentation for our own software 
uptodate (see e.g. https://git.reviewboard.kde.org/r/127903/), 
so we should concentrate on documentation for our software first and skip this 
outdated manpage for now.


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127906/#review95451
---


On Mai 13, 2016, 2:12 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127906/
> ---
> 
> (Updated Mai 13, 2016, 2:12 nachm.)
> 
> 
> Review request for Documentation, KDE Frameworks and David Faure.
> 
> 
> Repository: kdoctools
> 
> 
> Description
> ---
> 
> All options in this docbook like
> 
> display, session, cmap, ncols, nograb, dograb, sync, fn, bg, fg, btn, name, 
> title, visual, inputstyle, im, noxim, reverse, stylesheet
> 
> are valid for Qt 3.3 QApplication, see
> 
> http://doc.qt.io/archives/3.3/qapplication.html#QApplication
> 
> 
> In Qt 5.6 a QApplication automatically supports a few command line options 
> like 
> style, stylesheet, widgetcount, reverse, qmljsdebugger
> see http://doc.qt.io/qt-5/qapplication.html
> 
> 
> Do we really want to provide a manpage docbook for that?
> 
> 
> Diffs
> -
> 
>   docs/CMakeLists.txt 4efee3b 
>   docs/qt5options/CMakeLists.txt 7e31e0f 
>   docs/qt5options/man-qt5options.7.docbook d5891eb 
> 
> Diff: https://git.reviewboard.kde.org/r/127906/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel