Re: Breeze and ECM are incompatible for installing icons

[Carl Schwan]

On Friday, November 3, 2023 12:46:20 AM CET Albert Astals Cid wrote:
> El dijous, 2 de novembre de 2023, a les 14:36:16 (CET), David Jarvie va
> 
> escriure:
> > Breeze installs its icons in a different directory structure from other
> > icon themes, with the result that the ECM cmake command ecm_install_icons
> > doesn't work for Breeze icons. The only way to install an application
> > specific Breeze icon is to hard code its location, for example
> > "${KDE_INSTALL_ICONDIR}/breeze/actions/22/".
> 
> Why are you installing icons in breeze icon theme if you're not the breeze
> icon theme?
> 
> Seems wrong to me.

Yes, it's wrong. We made the same mistake in Tokodon and the correct way to do 
it is to install in the hicolor theme. This allow the theme to overwrite the 
icon if they want and don't force you to hardcode the breeze icon theme.

Re : Re: KF6 meeting notes 2021-12-07

[Carl Schwan]

Le mercredi 8 décembre 2021 à 11:26 AM, David Redondo  a 
écrit :

> Am Dienstag, 7. Dezember 2021, 18:04:19 CET schrieb Volker Krause:
>
> > https://phabricator.kde.org/T11587
> >
> > -   there are bigger plans to rework color scheming, this needs more
> > coordination with the effort to down-tier this for KF6
> > -   would likely mean only storing the color scheme name in kdeglobals
> > rather
> > than actual colors
>
> I actually started a branch to use QSettings instead of KConfig for
> KColorScheme with some changes to the public API that does this.
> https://invent.kde.org/frameworks/kconfigwidgets/-/commits/work/davidre/
> qsettings/
>
> > -   do we need per color cascading or is that rather a bug? compare e.g.
> > to
> > Kate's syntax highlighting themes.
>
> This does away with per color cascading, and imo there's not much use
> case for
> it. When introducing the Header color set extra effort was taken to NOT
> have
>
> cascading for those. Also Plasma will only allow creating full color
> schemes
> from the gui iirc.

Cascading of color scheme doesn't really make sense and is actually causing
problems with the Header when an application allows to overwrite the theme
(e.g. neochat, elisa, ...) but the app theme used doesn't have a Header role
defined, then you get a mix of two themes and it's a bit broken.

There was an attempt to fix this here:
https://invent.kde.org/frameworks/kconfigwidgets/-/merge_requests/52

Re: Respin request Kirigami

[Carl Schwan]

Le lundi 11 octobre 2021 à 12:56 PM, David Faure  a écrit :

> On lundi 11 octobre 2021 12:46:04 CEST Carl Schwan wrote:
>
> > I don't think it is so urgent that we need a 5.87.1 version of
> > Kirigami. So it can't wait a month.
>
> Do you mean "it can't wait" or "it can wait"?

It can wait. Sorry for the confusion :/

>
> 
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5

Re: Respin request Kirigami

[Carl Schwan]

Le lundi 11 octobre 2021 à 11:43 AM, David Faure  a écrit :

> On lundi 4 octobre 2021 12:39:35 CEST Carl Schwan wrote:
>
> > Please include
> > https://invent.kde.org/frameworks/kirigami/-/commit/e7ffa04038307efef10c168
> > 2042e795d4a32a935
> >
> > This fixes some nasty bugs for the Kirigami settings component.
>
> Hello Carl,
> I missed this email.
> Please send respin requests to release-t...@kde.org

Sorry I didn't know. I wil do that the next time.

> I suppose a 5.87.1 version of kirigami is needed then?

I don't think it is so urgent that we need a 5.87.1 version of
Kirigami. So it can't wait a month. It's just impacting Kalendar (not released),
Koko (we already reverted the patch porting to Kirigami.SettingPage) and NeoChat
(we can wait before porting from the existing vendored SettingPage component to 
the
new upstream one).

Regards
Carl

>
> -
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5

Respin request Kirigami

[Carl Schwan]

Hello,

Please include 
https://invent.kde.org/frameworks/kirigami/-/commit/e7ffa04038307efef10c1682042e795d4a32a935

This fixes some nasty bugs for the Kirigami settings component.

Carl Schwan
https://carlschwan.eu

Re: QML API docs for C++ wrapper types?

[Carl Schwan]

Le vendredi 17 septembre 2021 à 3:23 PM, Volker Krause  a 
écrit :

> Hi,
> do we have an example somewhere how to do API docs markup properly for C++
> wrappers for QML APIs?

I don't think we have and it's currently with Doxygen a bit hard to do something
similar to the Qt documentation with a separate list of C++ types and one of QML
types (with a link from the QML types to the C++ types).

I'm not sure that is the best way forward with this issue. This would be two
possibilities:

* Use QDoc. There is already basic support for QDoc inside KApidox thanks to
Jannet. This would need more work and I'm not sure how stuff like dependencies
are handled. More importantly, moving to QDoc is a **lot** of work to port the
doc comments to the QDoc syntax and would need some work in QDoc to also support
doc comments inside .h files (I talked with upstream during the Qt Contributor
submit and they are fine with us adding this feature as an option).

* Continuing using Doxygen. This would be less work, we could use custom
doxygen commands for indicating in a unified way how to import the component.
More problematic would be the case of classes that can be used from both QML
and C++. Should we display in these cases the documentation for both the QML
usage and C++ usage? There are also issues that documenting pure QML construct
(attached properties, nested properties, ...) is hard and the way this is
currently done with DoxyQML is hacky and probably would need first-class
support in Doxygen.

For now in your merge requests, I would probably put some information in
the readme/additional doc page that the library is usable from QML. Your latest
blog post about the Notification QML with some small changes could be a great
starting point for this. It's not perfect but at least it's documented and
can be found.

Cheers,
Carl

>
> Thinking about cases like these:
> https://invent.kde.org/frameworks/knotifications/-/merge_requests/49/
> diffs#aa15f1228c0fb7ecaaa96bb9d8d843ef37033c2b_0_12
> https://invent.kde.org/frameworks/ki18n/-/merge_requests/19/
> diffs#31824e8758f678d4b04f3f329c208c8df64f5e25_0_33
> https://invent.kde.org/frameworks/syntax-highlighting/-/blob/master/src/quick/
> repositorywrapper.h#L20
>
> How can I make those show up as they actually look like from a QML POV, ie.
> with their exported type names etc?
>
> Thanks,
> Volker

Re : KApiDox move from dedicated server to Jenkins

[Carl Schwan]

Le vendredi 10 septembre 2021 à 7:23 PM, Frederik Schwarzer  
a écrit :

> Hi,

Hi :D

> we have been working on getting KApiDox to run on Jenkins. This work has
> been taken way longer than I expected but has now reached a state close
> to finished. :)
>
> So I would like to invite you to check https://api-dev.kde.org/ for any
> show stoppers.

Great work :D

I see on an issue that I would qualify as blocking and it's the lack of the
ECM generated doc: https://api-dev.kde.org/ecm. We are also losing the
kube/sink doc (located at api.kde.org/doc/sink) but it's also available
in readthedocs and ihmo it should be in Doxygen format.

We also are losing the krita/kmymoney/other app private api generation,
but that maybe can be generated in another ci pipeline later. Not sure how
much thses apps' developers are using it.

On the upside, I see that mauikit doc is finally correctly generated using
qdoc. Yeah \o/

Cheers,
Carl
>
> Known issues (not show stoppers):
>
> -   For now the Maintainers field defaults to "KDE Developers" for
> potential GDPR violation reasons, which needs to be figured out later.
> -   Some modules contain formatting issues regarding markdown code blocks.
> These are also there in the current system and need to be checked at
> some point.
> -   The "Older versions" links are broken. Since those docs are not
> generated anymore, we need to figure out a way to have them available
> statically.
>
> If we do not see any bigger issues, I would like to go live with the new
> system in a week or two.
>
> Thanks for your help.
>
> CHeers,
> Frederik

D28861: Sonnet add Malayalam trigram

[Carl Schwan]

ognarb added a subscriber: sandsmark.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D28861

To: aiswaryak, #frameworks
Cc: sandsmark, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29802: Require in-source build

[Carl Schwan]

ognarb accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  require-in-source-build (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29802

To: ngraham, #frameworks, #vdg, ognarb
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

[Carl Schwan]

ognarb added a comment.


  In D29797#672263 , @kossebau wrote:
  
  > Thanks for the (first) review :)
  >
  > Open questions I have are these:
  >  a) how to properly check for the presence of the yaml.safe_load() method? 
and whether to support a fallback to load() otherwise? It was only introduced 
at a certain version of pyyaml
  
  
  Something like this should work
  
try:
result = yaml.safe_load()
except AttributeError:
result = yaml.load()
  
  But I think you should require having a recent enough version of pyyaml for 
safe_load() to work. load() is not great in term of security :(
  
  > b) by supposedly breaking support for Python 2, how to properly catch any 
usage of python2 now?
  
  Already answered by @cblack

REPOSITORY
  R264 KApiDox

BRANCH
  makedepworkwithpython3

REVISION DETAIL
  https://phabricator.kde.org/D29797

To: kossebau, #frameworks, ochurlaud, ognarb, cblack
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

[Carl Schwan]

ognarb accepted this revision.
ognarb added a comment.
This revision is now accepted and ready to land.


  +1 and also +1 for removing python2 support

REPOSITORY
  R264 KApiDox

BRANCH
  makedepworkwithpython3

REVISION DETAIL
  https://phabricator.kde.org/D29797

To: kossebau, #frameworks, ochurlaud, ognarb
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D29511: Label: Add ping-pong logic

[Carl Schwan]

ognarb requested changes to this revision.
ognarb added a comment.
This revision now requires changes to proceed.


  I'm not sure it is a good idea, but at least for me it break the clock in my 
panel.
  
  F8294594: vokoscreenNG-2020-05-07_17-49-49.mkv 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29511

To: patrickelectric, #plasma, #vdg, ognarb
Cc: ognarb, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D28811: Add drawer on mobile and clean code

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R264:e7645ba24570: Add drawer on mobile and clean code 
(authored by ognarb).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28811?vs=80229&id=81051#toc

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28811?vs=80229&id=81051

REVISION DETAIL
  https://phabricator.kde.org/D28811

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/templates/base.html
  src/kapidox/data/templates/subgroup-sidebar.html

To: ognarb, cblack, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D29084: Make the HTML file template more useful

[Carl Schwan]

ognarb added a comment.


  In D29084#654489 , @gszymaszek 
wrote:
  
  > In D29084#654484 , @ognarb wrote:
  >
  > > - Don't include `

D29084: Make the HTML file template more useful

[Carl Schwan]

ognarb accepted this revision.
ognarb added a comment.
This revision is now accepted and ready to land.


  Good idea to improve the default HTML file.
  
  Improvement ideas:
  
  - Don't include `

D29049: add telephant icon

[Carl Schwan]

ognarb added a reviewer: muesli.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D29049

To: mbruchert, muesli
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28811: Add drawer on mobile and clean code

[Carl Schwan]

ognarb added a comment.


  I now generate the CSS from aether-sass. The code can be found 
https://invent.kde.org/websites/aether-sass/-/blob/master/css/aether-sidebar.scss.
  And all tree wikis are using it.
  
  @ochurlaud should I create a sysadmin request for you to get access to the 
repo in invent so that you can edit it if you need?

REPOSITORY
  R264 KApiDox

BRANCH
  flex-grid

REVISION DETAIL
  https://phabricator.kde.org/D28811

To: ognarb, cblack, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D28811: Add drawer on mobile and clean code

[Carl Schwan]

ognarb updated this revision to Diff 80229.
ognarb added a comment.


  - Fix typo in path
  - Add information about there to find the source of the css files

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28811?vs=80228&id=80229

BRANCH
  flex-grid

REVISION DETAIL
  https://phabricator.kde.org/D28811

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/templates/base.html
  src/kapidox/data/templates/subgroup-sidebar.html

To: ognarb, cblack, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D28811: Add drawer on mobile and clean code

[Carl Schwan]

ognarb updated this revision to Diff 80228.
ognarb added a comment.
This revision is now accepted and ready to land.


  - Use version from cdn

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28811?vs=80156&id=80228

BRANCH
  flex-grid

REVISION DETAIL
  https://phabricator.kde.org/D28811

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/templates/base.html
  src/kapidox/data/templates/subgroup-sidebar.html

To: ognarb, cblack, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D28811: Add drawer on mobile and clean code

[Carl Schwan]

ognarb added a comment.


  POC of sharing this code with the wikis: 
https://wikisandbox.kde.org/Welcome_to_KDE_TechBase

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28811

To: ognarb, cblack, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D28811: Add drawer on mobile and clean code

[Carl Schwan]

ognarb planned changes to this revision.
ognarb added a comment.


  In D28811#648700 , @ochurlaud 
wrote:
  
  > I really dislike how you close brackets in css : it's more dense and harder 
to read.
  >
  > You indent sometimes with 1,2 or 3 spaces: it should be consistent.
  >
  > Is it something common to have css declaration within others? It's the 
first time I see that, so I'm confused.
  
  
  The css code is generated from the new scss file. I didn't remove the 
generated CSS code because I didn't want to add sass as a dependency of 
kapidox. I will add this information to the doc.
  
  The command to generate the css code is:
  
sass src/kapidox/data/htmlresource/css/kapidox.scss 
src/kapidox/data/htmlresource/css/kapidox.css
  
  Maybe this file can be moved later to `websites/aether-sass` so that the 
layout with the sidebar can be shared with `websites/aether-sphinx` and 
`websites/aether-mediawiki` and hosted in the KDE cdn.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28811

To: ognarb, cblack, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D28811: Add drawer on mobile and clean code

[Carl Schwan]

ognarb retitled this revision from "WIP: Use CSS grid to improve layout" to 
"Add drawer on mobile and clean code".
ognarb edited the summary of this revision.
ognarb edited the test plan for this revision.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28811

To: ognarb, cblack, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D28811: WIP: Use CSS grid to improve layout

[Carl Schwan]

ognarb edited the summary of this revision.
ognarb added reviewers: cblack, ochurlaud.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28811

To: ognarb, cblack, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D28811: WIP: Use CSS grid to improve layout

[Carl Schwan]

ognarb updated this revision to Diff 80156.
ognarb added a comment.


  Add NoScript support

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28811?vs=80155&id=80156

BRANCH
  flex-grid

REVISION DETAIL
  https://phabricator.kde.org/D28811

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/htmlresource/css/kapidox.scss
  src/kapidox/data/templates/base.html
  src/kapidox/data/templates/subgroup-sidebar.html

To: ognarb
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D28811: WIP: Use CSS grid to improve layout

[Carl Schwan]

ognarb updated this revision to Diff 80155.
ognarb added a comment.


  - Add drawer on mobile (with JS)
  - Fix some layout issues

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28811?vs=80057&id=80155

BRANCH
  flex-grid

REVISION DETAIL
  https://phabricator.kde.org/D28811

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/htmlresource/css/kapidox.scss
  src/kapidox/data/templates/base.html
  src/kapidox/data/templates/subgroup-sidebar.html

To: ognarb
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D28811: WIP: Use CSS grid to improve layout

[Carl Schwan]

ognarb created this revision.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
ognarb requested review of this revision.

REPOSITORY
  R264 KApiDox

BRANCH
  flex-grid

REVISION DETAIL
  https://phabricator.kde.org/D28811

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/htmlresource/css/kapidox.scss
  src/kapidox/data/templates/base.html
  src/kapidox/data/templates/subgroup-sidebar.html

To: ognarb
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna

D28712: Redo api.kde.org to look more like Aether

[Carl Schwan]

ognarb accepted this revision.
ognarb added a comment.


  LGTM

REPOSITORY
  R264 KApiDox

BRANCH
  cblack/aether (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28712

To: cblack, #vdg, ognarb, ochurlaud
Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, bruns, skadinna

D28712: Redo api.kde.org to look more like Aether

[Carl Schwan]

ognarb added a comment.


  Not tested yet but I like the style :) Though to be more consistent with the 
style used in other KDE websites, I would change the background color to #fff 
and use #f8f9fa for the sidebar.
  
  I also saw some alignment issues with the method args:
  
  F8227657: image.png 
  
  I will give a more in-depth review tomorrow.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28712

To: cblack, #vdg, ognarb, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28712: Redo api.kde.org to look more like Aether

[Carl Schwan]

ognarb added a reviewer: ochurlaud.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28712

To: cblack, #vdg, ognarb, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D27851: Add rss icons in action

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:861f6ab52dc3: Add rss icons in action (authored by 
ognarb).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27851?vs=76976&id=76979

REVISION DETAIL
  https://phabricator.kde.org/D27851

AFFECTED FILES
  icons-dark/actions/22/rss.svg
  icons/actions/22/rss.svg

To: ognarb, #vdg, #breeze, ndavis
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2, 
trickyricky26, michaelh, ngraham, bruns

D27851: Add rss icons in action

[Carl Schwan]

ognarb edited the test plan for this revision.
ognarb added a reviewer: ndavis.
ognarb added a project: Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27851

To: ognarb, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2, trickyricky26, 
michaelh, ngraham, bruns

D27851: Add rss icons in action

[Carl Schwan]

ognarb created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ognarb requested review of this revision.

TEST PLAN
  Soon

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27851

AFFECTED FILES
  icons-dark/actions/22/rss.svg
  icons/actions/22/rss.svg

To: ognarb
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27601: KConfig: Convert to SPDX license statements

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> cordlandwehr wrote in kcfg.xsd:20
> Actually, I though quite a time about this and at the end did a comparison of 
> the permissions specifically provided by this statement: use, copy and modify 
> (yet there is no explicit statement of sublicensing and combining with other 
> works). That -- in my understanding -- is the legal equivalent to the BSD-2 
> clause. However, the statement is quite different than the usual BSD 2 
> Clauses. but I am not aware of any license that is phrased in exactly this 
> statement.
> 
> What is your opinion? Otherwise, I would also be fine with omitting it from 
> the change for now and I could contact the authors if they agree and then do 
> this change atomically later.

Searching in google, this looks like a standard license text for dtd files.

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D27601

To: cordlandwehr
Cc: ognarb, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, 
michaelh, ngraham, bruns

D27223: add kirigami-gallery icon

[Carl Schwan]

ognarb added a comment.


  In D27223#612284 , @mbruchert 
wrote:
  
  > I have no Idea why the diff deletes the ktrip icon.
  >  unfortunately I cant fix that because I have no Idea how to do that with 
git.
  
  
  You can try to execute this git command to solve this problem :)
  
git checkout origin/master icons/apps/48/ktrip.svg

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27223

To: mbruchert, mart, #vdg, ndavis
Cc: ognarb, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns

D27434: Improve readme

[Carl Schwan]

ognarb added a comment.


  Maybe you could also mention the license and the maintainers in the README?

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D27434

To: nicolasfella, #frameworks, broulik
Cc: ognarb, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns

D27214: add puremaps icon

[Carl Schwan]

ognarb added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27214

To: mbruchert, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25495: Fix Sonnet autodetect failing on Indian langs

[Carl Schwan]

ognarb added a reviewer: cullmann.
ognarb added a comment.


  Adding a potential reviewer :)

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25495

To: waqar, mludwig, cullmann
Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26010: Update the kiten log

[Carl Schwan]

ognarb edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26010

To: ognarb
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26010: Update the kiten log

[Carl Schwan]

ognarb added a reviewer: Breeze.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D26010

To: ognarb, #breeze
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26010: Update the kiten log

[Carl Schwan]

ognarb created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  Mix the labplot icon and the hiraganas for kiten
  
  Another possibility would be to use the kile icon with the same
  hiragana since jiten = dictionary.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26010

AFFECTED FILES
  icons/apps/48/kiten.svg

To: ognarb
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24443: Add a plugin system

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> dvratil wrote in calendarentry.h:63
> Use `std::unique_ptr const d` for automatic memory 
> management.

This wasn't done, I still see `CalendarEntryPrivate *d;`

> nicolasfella wrote in calendarplugin.h:39
> My idea was to be able to add a d-ptr later if needed without breaking ABI

Will this also work if we are using unique_ptr?

REPOSITORY
  R172 KCalendar Core

REVISION DETAIL
  https://phabricator.kde.org/D24443

To: nicolasfella, #frameworks, #plasma, #kde_pim
Cc: ognarb, kde-pim, dkardarakos, vkrause, dvratil, davidedmundson, dhaumann, 
fbampaloukas, dcaliste, dvasin, rodsevich, winterz, mlaurent, knauss

T11542: Remove KHTML

[Carl Schwan]

ognarb added a revision: D25714: Port away from deprecated KHtml.

TASK DETAIL
  https://phabricator.kde.org/T11542

To: ognarb
Cc: cordlandwehr, ngraham, #konqueror, #plasma, #okular, #kde_applications, 
#frameworks, knauss, davidre, GB_2, ahmadsamir, kpiwowarski, asturmlechner, 
cfeck, cullmann, vkrause, dfaure

D25149: Add a new Template for KCM's.

[Carl Schwan]

ognarb added a comment.


  Another related todo would be to update/rewrite 
https://techbase.kde.org/Development/Tutorials/KCM_HowTo after this template is 
merged and include information about it ;)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25149

To: tcanabrava
Cc: ognarb, ervin, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25123: [WIP] New yakuake logo/icon

[Carl Schwan]

ognarb added a reviewer: hein.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25123

To: mglb, #vdg, #yakuake, hein
Cc: ognarb, ngraham, hein, kde-frameworks-devel, vmarinescu, ryanmccoskrie, 
LeGast00n, GB_2, michaelh, bruns

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

[Carl Schwan]

ognarb added a comment.


  Instead of using uncrustify-kf5, shouldn't we use the clang-format file from 
T11214 ?

REPOSITORY
  R374 KolourPaint

REVISION DETAIL
  https://phabricator.kde.org/D24672

To: ahmadsamir, kde-frameworks-devel
Cc: ognarb, kde-frameworks-devel

D24568: Provide clang-format target with a common KDE style file

[Carl Schwan]

ognarb added a comment.


  There is probably a way to run clang-format only on a patch. See 
http://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting
  
  But should we not prefer running clang format one time, instead of having 
only some part of the code auto-formatted?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann
Cc: apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, 
bencreasy, michaelh, ngraham, bruns

D24568: Provide clang-format target with a common KDE style file

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> KDEClangFormat.cmake:11
> +#
> +# ::
> +#

need doc

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann
Cc: ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> kcategorydrawer.cpp:88
> +textRect.setTop(textRect.top() + 4);
> +textRect.setLeft(textRect.left() + 8);
>  textRect.setHeight(fontMetrics.height());

Instead of using magic number, I would create a constant named padding.

REPOSITORY
  R276 KItemViews

REVISION DETAIL
  https://phabricator.kde.org/D24453

To: davidre, #frameworks, #vdg, #konversation, #kexi, #kde_edu, #kde_pim, 
#kpublictransport, #amarok
Cc: ognarb, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24390: Add more file and directories to exclude filters

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> ngraham wrote in fileexcludefilters.cpp:137
> This one makes me a little nervous since it's a not-very-uncommon English 
> word, not something implicitly technical that we can be safe excluding.
> 
> Is there any other way we could exclude the contents of these folders? Maybe 
> by filename, mimetype, or the naming of sub-folders?

This directory contains only pure PHP code, so not possible by filename or 
minetype. Maybe we could use the fact that a composer.json is always included 
in the same directory?

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24390

To: ognarb, #baloo, ngraham
Cc: ngraham, kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, 
GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, bruns, abrahams

D24390: Add more file and directories to exclude filters

[Carl Schwan]

ognarb added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D24390

To: ognarb, #baloo
Cc: kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D24390: Add more file and directories to exclude filters

[Carl Schwan]

ognarb created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
ognarb requested review of this revision.

TEST PLAN
  None for the moment

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24390

AFFECTED FILES
  src/file/fileexcludefilters.cpp

To: ognarb
Cc: kde-frameworks-devel, #baloo, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D21169: Add app icon for the Kirogi Drone control app

[Carl Schwan]

ognarb added a comment.


  kde.org/applications use the icons from breeze-icons. So I think it's worth 
adding to breeze-icons or improving how the icon are fetched in 
kde.org/applications.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21169

To: trickyricky26, hein, #vdg
Cc: ognarb, ngraham, apol, kde-frameworks-devel, hein, LeGast00n, GB_2, 
michaelh, bruns

D19620: Use a searchbar similar to the one in okular

[Carl Schwan]

ognarb abandoned this revision.
ognarb added a comment.


  I completly forgot about this patch and since KHTML is dead and is getting 
removed from most of our apps, it doesn't makes sence to land this patch.

REPOSITORY
  R313 KHtml

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: dhaumann, GB_2, ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, 
bruns

D24015: Added scripts to create a webfont out of all breeze action icons

[Carl Schwan]

ognarb accepted this revision.
ognarb added a comment.
This revision is now accepted and ready to land.


  LGTM

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24015

To: fabianr, ndavis, ognarb
Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24015: Added scripts to create a webfont out of all breeze action icons

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> Gruntfile.js:13
> +types:  'eot,woff2,ttf,svg',
> +optimize: false
> +}

why not true?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24015

To: fabianr, ndavis
Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22797: Fix typo - GridView -> ScrollView

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:2571616ec547: Fix typo - GridView -> ScrollView 
(authored by ognarb).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22797?vs=62705&id=62708

REVISION DETAIL
  https://phabricator.kde.org/D22797

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/ScrollViewKCM.qml

To: ognarb, #plasma, aacid
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22797: Fix typo - GridView -> ScrollView

[Carl Schwan]

ognarb created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  Probably the result of a bad copy pasta ;)

TEST PLAN
  Not tested

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22797

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/ScrollViewKCM.qml

To: ognarb
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22797: Fix typo - GridView -> ScrollView

[Carl Schwan]

ognarb added a reviewer: Plasma.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22797

To: ognarb, #plasma
Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

[Carl Schwan]

ognarb updated this revision to Diff 59720.
ognarb added a comment.


  Use more round corner.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21656?vs=59707&id=59720

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21656

AFFECTED FILES
  icons-dark/apps/48/kfourinline.svg
  icons/apps/48/kfourinline.svg

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

[Carl Schwan]

ognarb edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

[Carl Schwan]

ognarb edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

[Carl Schwan]

ognarb edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

[Carl Schwan]

ognarb updated this revision to Diff 59707.
ognarb added a comment.


  Change color of some points

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21656?vs=59706&id=59707

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21656

AFFECTED FILES
  icons-dark/apps/48/kfourinline.svg
  icons/apps/48/kfourinline.svg

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

[Carl Schwan]

ognarb updated this revision to Diff 59706.
ognarb added a comment.


  Still works in progress (need to add the gradiend) but some improvement

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21656?vs=59372&id=59706

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21656

AFFECTED FILES
  icons-dark/apps/48/kfourinline.svg
  icons/apps/48/kfourinline.svg

To: ognarb, #vdg
Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21656: Create a breeze icon for kfourinline

[Carl Schwan]

ognarb updated this revision to Diff 59372.
ognarb added a comment.


  Crop shadow

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21656?vs=59371&id=59372

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21656

AFFECTED FILES
  icons-dark/apps/48/kfourinline.svg
  icons/apps/48/kfourinline.svg

To: ognarb, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

[Carl Schwan]

ognarb edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

[Carl Schwan]

ognarb edited the test plan for this revision.
ognarb added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21656

To: ognarb, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21656: Create a breeze icon for kfourinline

[Carl Schwan]

ognarb created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ognarb requested review of this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21656

AFFECTED FILES
  icons-dark/apps/48/kfourinline.svg
  icons/apps/48/kfourinline.svg

To: ognarb
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21574: Update KBruch icon

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R266:86d0782cf4e2: Update KBruch icon (authored by ognarb).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21574?vs=59187&id=59189

REVISION DETAIL
  https://phabricator.kde.org/D21574

AFFECTED FILES
  icons-dark/apps/48/kbruch.svg
  icons/apps/48/kbruch.svg

To: ognarb, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

[Carl Schwan]

ognarb edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21574

To: ognarb, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

[Carl Schwan]

ognarb updated this revision to Diff 59187.
ognarb added a comment.


  - Optimize icon with scour-icon
  - Copy icon to breeze-dark
  - Remove png

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21574?vs=59131&id=59187

BRANCH
  kbruch

REVISION DETAIL
  https://phabricator.kde.org/D21574

AFFECTED FILES
  icons-dark/apps/48/kbruch.svg
  icons/apps/48/kbruch.svg

To: ognarb, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

[Carl Schwan]

ognarb added a comment.


  In D21574#474171 , @ndavis wrote:
  
  > Wait, is this a PNG? This needs to be just an SVG. We don't ship PNGs in 
breeze-icons.
  
  
  Sorry it arc who also uploaded the png that I created for the review, I will 
fix it.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21574

To: ognarb, #vdg, ndavis
Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

[Carl Schwan]

ognarb updated this revision to Diff 59131.
ognarb added a comment.


  Add shadow

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21574?vs=59123&id=59131

BRANCH
  kbruch

REVISION DETAIL
  https://phabricator.kde.org/D21574

AFFECTED FILES
  icons/apps/48/kbruch.png
  icons/apps/48/kbruch.svg

To: ognarb, #vdg
Cc: ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns

D21574: Update KBruch icon

[Carl Schwan]

ognarb edited the test plan for this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21574

To: ognarb, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21574: Update KBruch icon

[Carl Schwan]

ognarb edited the test plan for this revision.
ognarb added a reviewer: VDG.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21574

To: ognarb, #vdg
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21574: Update KBruch icon

[Carl Schwan]

ognarb created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  Inspired from application-edu and cantor icon

TEST PLAN
  Screenshot comming

REPOSITORY
  R266 Breeze Icons

BRANCH
  kbruch

REVISION DETAIL
  https://phabricator.kde.org/D21574

AFFECTED FILES
  icons/apps/48/kbruch.svg

To: ognarb
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D19771: Use placeholder instead of label

[Carl Schwan]

ognarb abandoned this revision.
ognarb added a comment.


  I don't have time and the motivation for this revision anymore.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19771

To: ognarb, #ktexteditor, #vdg
Cc: dhaumann, cullmann, cfeck, loh.tar, ngraham, kwrite-devel, 
kde-frameworks-devel, LeGast00n, domson, michaelh, bruns, demsking, sars

D19771: Use placeholder instead of label

[Carl Schwan]

ognarb added a comment.


  Hi, I try to find time to look into it this weekend ;).

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19771

To: ognarb, #ktexteditor, #vdg
Cc: dhaumann, cullmann, cfeck, loh.tar, ngraham, kwrite-devel, 
kde-frameworks-devel, domson, michaelh, bruns, demsking, sars

D21218: Use Anjuta's icon for Knights, since it works and Anjuta is abandoned at this point

[Carl Schwan]

ognarb added a comment.


  Why not mirror the Anjuta icon and use the same background color as the 
original Knights icon? So that it looks closer to the original.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21218

To: ngraham, #vdg
Cc: ognarb, kde-frameworks-devel, michaelh, ngraham, bruns

D19895: Use https for links in the UI and documentation

[Carl Schwan]

ognarb added a comment.


  I made sure that all the links are still working. So +1

INLINE COMMENTS

> kproxydlg.ui:45
>  Automatic detection is performed using the Web Proxy Auto-Discovery 
> Protocol (WPAD).

> -NOTE: This option might not work properly or not work at 
> all in some UNIX/Linux distributions. If you encounter a problem when using 
> this option, please check the FAQ section at http://konqueror.kde.org.
> +NOTE: This option might not work properly or not work at 
> all in some UNIX/Linux distributions. If you encounter a problem when using 
> this option, please check the FAQ section at https://konqueror.kde.org.
>  

https://konqueror.kde.org redirect to https://konqueror.org/, so maybe it's 
better to change the link to https://konqueror.org/.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19895

To: vkrause, yurchor
Cc: ognarb, yurchor, kde-frameworks-devel, kde-doc-english, gennad, michaelh, 
ngraham, bruns, skadinna

D19771: Use placeholder instead of label

[Carl Schwan]

ognarb added a comment.


  > I'm not aware of why we tend to use three dots instead of the real ellipsis 
character. Possibly because that character can be challenging to type. Best to 
follow the existing convention, I think.
  
  The advantage of using the unicode ellipsis character, is that this character 
carries a semantic meaning instead of just being a multiple of dots and uses a 
proper amount of space between the dot, also the hig use the unicode character. 
The only disadvantage is then used in monospace font.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19771

To: ognarb, #ktexteditor, #vdg
Cc: cfeck, loh.tar, ngraham, kwrite-devel, kde-frameworks-devel, gennad, 
domson, michaelh, bruns, demsking, cullmann, sars, dhaumann

D19771: Use placeholder instead of label

[Carl Schwan]

ognarb added a task: T10258: Use correct search bars and use ellipsis whenever 
needed to follow the KDE HIG.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19771

To: ognarb, #ktexteditor, #vdg
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19620: Use a searchbar similar to the one in okular

[Carl Schwan]

ognarb updated this revision to Diff 53928.
ognarb added a comment.


  Use Unicode ellipsis

REPOSITORY
  R313 KHtml

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19620?vs=53906&id=53928

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

AFFECTED FILES
  src/ui/findbar/khtmlfindbar.cpp
  src/ui/findbar/khtmlfindbar_base.ui

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19771: Use placeholder instead of label

[Carl Schwan]

ognarb planned changes to this revision.
ognarb added a comment.


  Look likes I misread a part of the HIG: Since the placeholder won’t be 
visible anymore as soon as the user types, you should only use it on standalone 
input elements, not in groups of input elements such as forms.
  
  So the change in Search and replace need to be reverted.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19771

To: ognarb, #ktexteditor, #vdg
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19771: Use placeholder instead of label

[Carl Schwan]

ognarb updated this revision to Diff 53922.
ognarb added a comment.


  Use proper Unicode ellipsis

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19771?vs=53919&id=53922

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19771

AFFECTED FILES
  src/search/katesearchbar.cpp
  src/search/searchbarincremental.ui
  src/search/searchbarpower.ui

To: ognarb, #ktexteditor, #vdg
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19771: Use placeholder instead of label

[Carl Schwan]

ognarb added a reviewer: VDG.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19771

To: ognarb, #ktexteditor, #vdg
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19771: Use placeholder instead of label

[Carl Schwan]

ognarb edited the summary of this revision.
ognarb added a reviewer: KTextEditor.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D19771

To: ognarb, #ktexteditor
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19771: Use placeholder instead of label

[Carl Schwan]

ognarb created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  See https://hig.kde.org/style/writing/placeholder.html
  
  Also change Find -> Search in Search and replace module
  
  Screenshot: comming

TEST PLAN
  Compile and run

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19771

AFFECTED FILES
  src/search/katesearchbar.cpp
  src/search/searchbarincremental.ui
  src/search/searchbarpower.ui

To: ognarb
Cc: kwrite-devel, kde-frameworks-devel, gennad, domson, michaelh, ngraham, 
bruns, demsking, cullmann, sars, dhaumann

D19620: Use a searchbar similar to the one in okular

[Carl Schwan]

ognarb edited the summary of this revision.

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

[Carl Schwan]

ognarb edited the summary of this revision.

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

[Carl Schwan]

ognarb edited the summary of this revision.

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

[Carl Schwan]

ognarb updated this revision to Diff 53906.
ognarb added a comment.


  Remove icon to option button

REPOSITORY
  R313 KHtml

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19620?vs=53505&id=53906

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

AFFECTED FILES
  src/ui/findbar/khtmlfindbar.cpp
  src/ui/findbar/khtmlfindbar_base.ui

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19620: Use a searchbar similar to the one in okular

[Carl Schwan]

ognarb edited the summary of this revision.

REPOSITORY
  R313 KHtml

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19620

To: ognarb, #vdg, #frameworks, ndavis, ngraham
Cc: ngraham, ndavis, kde-frameworks-devel, michaelh, bruns

D19557: Update design to look more similar to kde.org

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R238:a67daca8199c: Update design to look more similar to 
kde.org (authored by ognarb).

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53616&id=53617

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/top-kde.jpg

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update design to look more similar to kde.org

[Carl Schwan]

ognarb added a comment.


  In D19557#428634 , @ltoscano wrote:
  
  > Thank you! And sorry for the ping-pong.
  
  
  No problems ;) Thanks for the review.

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update design to look more similar to kde.org

[Carl Schwan]

ognarb edited the summary of this revision.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update design to look more similar to kde.org

[Carl Schwan]

ognarb updated this revision to Diff 53616.
ognarb added a comment.


  Don't change image link and remove kde.png

REPOSITORY
  R238 KDocTools

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19557?vs=53603&id=53616

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19557

AFFECTED FILES
  common/en/kde-default.css
  common/en/kde-docs.css
  common/en/top-kde.jpg

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update design to look more similar to kde.org

[Carl Schwan]

ognarb retitled this revision from "Update css" to "Update design to look more 
similar to kde.org".
ognarb edited the summary of this revision.
ognarb edited the test plan for this revision.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Carl Schwan]

ognarb added a comment.


  In D19557#428618 , @ltoscano wrote:
  
  > In D19557#428617 , @ognarb wrote:
  >
  > > They use the old link for the image, also the jpg version instead of the 
png. I tested with new page and old page and the result is visually the same.
  >
  >
  > But do the existing pages use the old link for the image with the new CSS?
  
  
  Yes the link to the css didn't change, only the content. So even the old page 
links to the new CSS.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna

D19557: Update css

[Carl Schwan]

ognarb added a comment.


  In D19557#428614 , @ltoscano wrote:
  
  > No, wait a minute. What happens with pages which are not regenerated?
  
  
  They use the old link for the image, also the jpg version instead of the png. 
I tested with new page and old page and the result is visually the same.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D19557

To: ognarb, #vdg, #documentation, yurchor, ltoscano
Cc: yurchor, rooty, ltoscano, bruns, abetts, broulik, aacid, 
kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, skadinna