D27263: RFC: Accent colour for KColorScheme

2020-09-29 Thread Carson Black
cblack abandoned this revision.
cblack added a comment.


  https://invent.kde.org/frameworks/kconfigwidgets/-/merge_requests/24

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D27263

To: cblack, #plasma
Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, 
michaelh, bruns


D7563: Add privilegeExecution field to file protocol description

2020-09-20 Thread Carson Black
cblack abandoned this revision.
cblack added a comment.


  Moving this to GitLab: 
https://invent.kde.org/frameworks/kio/-/merge_requests/143

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7563

To: cblack, #frameworks, dfaure, chinmoyr, sitter, ngraham
Cc: cblack, sitter, kkong, kde-frameworks-devel, feverfew, mreeves, mati865, 
ngraham, elvisangelaccio, LeGast00n, michaelh, bruns


D7563: Add privilegeExecution field to file protocol description

2020-08-11 Thread Carson Black
cblack updated this revision to Diff 83347.
cblack marked an inline comment as done.
cblack added a comment.


  i18n the strings

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7563?vs=83344=83347

BRANCH
  arcpatch-D7563

REVISION DETAIL
  https://phabricator.kde.org/D7563

AFFECTED FILES
  src/core/kfileitemlistproperties.cpp
  src/core/kprotocolinfo.cpp
  src/core/kprotocolinfo_p.h
  src/core/kprotocolmanager.cpp
  src/core/kprotocolmanager.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.json
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/kauth/CMakeLists.txt

To: cblack, #frameworks, dfaure, chinmoyr, sitter, ngraham
Cc: cblack, sitter, kkong, kde-frameworks-devel, feverfew, mreeves, mati865, 
ngraham, elvisangelaccio, LeGast00n, michaelh, bruns


D7563: Add privilegeExecution field to file protocol description

2020-08-06 Thread Carson Black
cblack marked an inline comment as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7563

To: cblack, #frameworks, dfaure, chinmoyr, sitter, ngraham
Cc: cblack, sitter, kkong, kde-frameworks-devel, feverfew, mreeves, mati865, 
ngraham, elvisangelaccio, LeGast00n, michaelh, bruns


D7563: Add privilegeExecution field to file protocol description

2020-08-06 Thread Carson Black
cblack updated this revision to Diff 83344.
cblack added a comment.


  Redo that switchcase

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7563?vs=83343=83344

BRANCH
  arcpatch-D7563

REVISION DETAIL
  https://phabricator.kde.org/D7563

AFFECTED FILES
  src/core/kfileitemlistproperties.cpp
  src/core/kprotocolinfo.cpp
  src/core/kprotocolinfo_p.h
  src/core/kprotocolmanager.cpp
  src/core/kprotocolmanager.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.json
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/kauth/CMakeLists.txt

To: cblack, #frameworks, dfaure, chinmoyr, sitter, ngraham
Cc: cblack, sitter, kkong, kde-frameworks-devel, feverfew, mreeves, mati865, 
ngraham, elvisangelaccio, LeGast00n, michaelh, bruns


D7563: Add privilegeExecution field to file protocol description

2020-08-05 Thread Carson Black
cblack updated this revision to Diff 83343.
cblack added a comment.


  Break those cases; this lang ain't got sane case behaviour

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7563?vs=83342=83343

BRANCH
  arcpatch-D7563

REVISION DETAIL
  https://phabricator.kde.org/D7563

AFFECTED FILES
  src/core/kfileitemlistproperties.cpp
  src/core/kprotocolinfo.cpp
  src/core/kprotocolinfo_p.h
  src/core/kprotocolmanager.cpp
  src/core/kprotocolmanager.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.json
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/kauth/CMakeLists.txt

To: cblack, #frameworks, dfaure, chinmoyr, sitter, ngraham
Cc: cblack, sitter, kkong, kde-frameworks-devel, feverfew, mreeves, mati865, 
ngraham, elvisangelaccio, LeGast00n, michaelh, bruns


D7563: Add privilegeExecution field to file protocol description

2020-08-05 Thread Carson Black
cblack updated this revision to Diff 83342.
cblack marked an inline comment as done.
cblack added a comment.


  Add more descriptive authentication details

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7563?vs=80668=83342

BRANCH
  arcpatch-D7563

REVISION DETAIL
  https://phabricator.kde.org/D7563

AFFECTED FILES
  src/core/kfileitemlistproperties.cpp
  src/core/kprotocolinfo.cpp
  src/core/kprotocolinfo_p.h
  src/core/kprotocolmanager.cpp
  src/core/kprotocolmanager.h
  src/ioslaves/file/file.cpp
  src/ioslaves/file/file.json
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/kauth/CMakeLists.txt

To: cblack, #frameworks, dfaure, chinmoyr, sitter, ngraham
Cc: cblack, sitter, kkong, kde-frameworks-devel, feverfew, mreeves, mati865, 
ngraham, elvisangelaccio, LeGast00n, michaelh, bruns


D7563: Add privilegeExecution field to file protocol description

2020-08-05 Thread Carson Black
cblack commandeered this revision.
cblack added a reviewer: ngraham.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7563

To: cblack, #frameworks, dfaure, chinmoyr, sitter, ngraham
Cc: cblack, sitter, kkong, kde-frameworks-devel, feverfew, mreeves, mati865, 
ngraham, elvisangelaccio, LeGast00n, michaelh, bruns


D7563: Add privilegeExecution field to file protocol description

2020-08-05 Thread Carson Black
cblack added a comment.


  In D7563#674682 , @sitter wrote:
  
  > This really cannot land right now IMHO. Dolphin can actually deadlock 
itself because it uses way too much nested event looping and will be entirely 
unresponsive to mouse inputs when certain timers happen to trigger. A trivial 
way to reproduce this is to try and duplicate a file in file:/
  
  
  Can't reproduce, duplication works fine.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D7563

To: ngraham, #frameworks, dfaure, chinmoyr, sitter
Cc: cblack, sitter, kkong, kde-frameworks-devel, feverfew, mreeves, mati865, 
ngraham, elvisangelaccio, LeGast00n, michaelh, bruns


D29436: Use font: instead of font.pointSize: where possible

2020-05-19 Thread Carson Black
cblack accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  use-whole-font (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29436

To: ngraham, #plasma, cblack
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29483: [knewfilemenu] Show inline warning when creating items with leading or trailing spaces

2020-05-18 Thread Carson Black
cblack accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  
show-warnings-for-leading-and-trailing-spaces-when-creating-files-or-folders-and-wow-this-is-a-long-branch-name-at-this-point
 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29483

To: ngraham, #frameworks, #vdg, cfeck, cblack
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29802: Require out-of-source builds

2020-05-17 Thread Carson Black
cblack accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  require-in-source-build (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29802

To: ngraham, #frameworks, #vdg, ognarb, davidre, apol, nicolasfella, ndavis, 
tfella, filipf, cblack
Cc: ltoscano, davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

2020-05-16 Thread Carson Black
cblack added a comment.


  In D29797#672263 , @kossebau wrote:
  
  > Thanks for the (first) review :)
  >
  > Open questions I have are these:
  >  a) how to properly check for the presence of the yaml.safe_load() method? 
and whether to support a fallback to load() otherwise? It was only introduced 
at a certain version of pyyaml
  >  b) by supposedly breaking support for Python 2, how to properly catch any 
usage of python2 now?
  
  
  Best thing to do would be a follow-up patch that uses python3 shebangs. But 
frankly, I wouldn't care about Python 2. It's been EOL for half a year now and 
people have had more than enough time to migrate to Python 3.

REPOSITORY
  R264 KApiDox

BRANCH
  makedepworkwithpython3

REVISION DETAIL
  https://phabricator.kde.org/D29797

To: kossebau, #frameworks, ochurlaud, ognarb, cblack
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna


D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

2020-05-16 Thread Carson Black
cblack accepted this revision.

REPOSITORY
  R264 KApiDox

BRANCH
  makedepworkwithpython3

REVISION DETAIL
  https://phabricator.kde.org/D29797

To: kossebau, #frameworks, ochurlaud, ognarb, cblack
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna


D29667: Export metalist to json file

2020-05-12 Thread Carson Black
This revision was automatically updated to reflect the committed changes.
Closed by commit R264:c8e125d0860e: Export metalist to json file (authored by 
cblack).

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29667?vs=82608=82692

REVISION DETAIL
  https://phabricator.kde.org/D29667

AFFECTED FILES
  src/kapidox/hlfunctions.py

To: cblack, ochurlaud
Cc: bcooksley, kde-frameworks-devel, kde-doc-english, ognarb, LeGast00n, 
cblack, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna


D29667: Export metalist to json file

2020-05-12 Thread Carson Black
cblack added a comment.


  In D29667#669622 , @ochurlaud 
wrote:
  
  > Don't use file as a variable name as it's a python keyword.
  
  
  
  
>>> import keyword
>>> keyword.iskeyword("file")
False
  
  It's not.
  
  > Do you really want to dump those files everywhere?
  
  Yes, it's what allows https://invent.kde.org/cblack/sitelenkijetesantakalu/ 
to serve a dynamic front page from disparate kapidox runs.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D29667

To: cblack, ochurlaud
Cc: bcooksley, kde-frameworks-devel, kde-doc-english, ognarb, LeGast00n, 
cblack, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna


D29667: Export metalist to json file

2020-05-11 Thread Carson Black
cblack updated this revision to Diff 82608.
cblack added a comment.


  Dump output information as well

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29667?vs=82603=82608

BRANCH
  cblack/metadata (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29667

AFFECTED FILES
  src/kapidox/hlfunctions.py

To: cblack, ochurlaud
Cc: bcooksley, kde-frameworks-devel, kde-doc-english, ognarb, LeGast00n, 
cblack, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna


D29667: Export metalist to json file

2020-05-11 Thread Carson Black
cblack created this revision.
cblack added a reviewer: ochurlaud.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
cblack requested review of this revision.

REVISION SUMMARY
  This will allow tooling to better introspect the generated pages.

REPOSITORY
  R264 KApiDox

BRANCH
  cblack/metadata (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29667

AFFECTED FILES
  src/kapidox/hlfunctions.py

To: cblack, ochurlaud
Cc: bcooksley, kde-frameworks-devel, kde-doc-english, ognarb, LeGast00n, 
cblack, gennad, fbampaloukas, michaelh, ngraham, bruns, skadinna


D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

2020-05-10 Thread Carson Black
cblack added inline comments.

INLINE COMMENTS

> kcolorcombo.h:52
>  Q_PROPERTY(QList colors READ colors WRITE setColors)
> +Q_PROPERTY(QList> namedColors READ namedColors 
> WRITE setNamedColors)
>  

Is a simple tuple list really the best way to represent colours? Knowing what 
most designers like, a better data structure would encapsulate named groups of 
optionally named colours.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns


D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

2020-05-10 Thread Carson Black
cblack added inline comments.

INLINE COMMENTS

> kcolorcombo.cpp:90
> +innerColor.getHsv(, , );
> +textColor = v > 128 ? Qt::black : Qt::white;
> +}

I would probably do what Kirigami does for `ColorUtils::brightnessForColor` 
here: `((0.299 * color.red() + 0.587 * color.green() + 0.114 * color.blue()) / 
255) > 0.5 ? Qt::black : Qt::white`

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D29502

To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham
Cc: cblack, broulik, cfeck, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns


D29534: Implement wheel/touchpad scrolling for SpinBox control

2020-05-08 Thread Carson Black
cblack added inline comments.

INLINE COMMENTS

> SpinBox.qml:49
> +if (wheel.angleDelta.y > 0 && control.value <= control.to) {
> +control.value = parseInt(control.value, 10) + 
> control.stepSize
> +valueModified()

`control.value` is already a numeric type as `control` is  a SpinBox, so you 
don't need to `parseInt` here. `control.value =+ control.stepSize`

> SpinBox.qml:50
> +control.value = parseInt(control.value, 10) + 
> control.stepSize
> +valueModified()
> +} else if (wheel.angleDelta.y < 0 && control.value >= 
> control.from) {

I think you would need to explicitly call this on `control`? 
`control.valueModified()`.

> SpinBox.qml:52
> +} else if (wheel.angleDelta.y < 0 && control.value >= 
> control.from) {
> +control.value = parseInt(control.value, 10) - 
> control.stepSize
> +valueModified()

`control.value =- control.stepSize`

> SpinBox.qml:53
> +control.value = parseInt(control.value, 10) - 
> control.stepSize
> +valueModified()
> +}

`control.valueModified()`.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29534

To: ngraham, #vdg, #plasma
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D29511: Label: Add ping-pong logic

2020-05-07 Thread Carson Black
cblack added a comment.


  You should include a video in the test plan since you're creating visual 
changes with motion.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29511

To: patrickelectric, #plasma, #vdg
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D29511: Label: Add ping-pong logic

2020-05-07 Thread Carson Black
cblack added reviewers: Plasma, VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29511

To: patrickelectric, #plasma, #vdg
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29434: Use small font for ExpandableListItem subtitle

2020-05-04 Thread Carson Black
cblack added inline comments.

INLINE COMMENTS

> ExpandableListItem.qml:434
>  visible: text.length > 0
> +font.pointSize: theme.smallestFont.pointSize
>  

`font: theme.smallestFont`

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29434

To: ngraham, #plasma, #vdg, broulik
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D29412: Add smallFont to Kirigami plasma style

2020-05-04 Thread Carson Black
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:68d5995c6352: Add smallFont to Kirigami plasma style 
(authored by cblack).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29412?vs=81897=81898

REVISION DETAIL
  https://phabricator.kde.org/D29412

AFFECTED FILES
  src/declarativeimports/kirigamiplasmastyle/Theme.qml

To: cblack, #kirigami, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29412: Add smallFont to Kirigami plasma style

2020-05-04 Thread Carson Black
cblack created this revision.
cblack added a reviewer: Kirigami.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cblack requested review of this revision.

TEST PLAN
  F8283833: ksnip_20200504-102619.png 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  cblack/smallfont-kirigami (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29412

AFFECTED FILES
  src/declarativeimports/kirigamiplasmastyle/Theme.qml

To: cblack, #kirigami
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29409: Add documentation line on KCM translations

2020-05-04 Thread Carson Black
cblack added inline comments.

INLINE COMMENTS

> configmodule.h:98
> + *
> + * Translation domain will be set to "kcm_componentName" from the KAboutData 
> as described above.
> + *

You probably want to use backticks instead of quotes as this is referring to 
something codewise.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D29409

To: davidedmundson
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D29292: Port KKeySequenceItem to QQC2

2020-04-29 Thread Carson Black
cblack added inline comments.

INLINE COMMENTS

> KeySequenceItem.qml:57
> +ToolTip.visible: hovered
> +ToolTip.delay: 1000
> +ToolTip.text:  _tr.i18n("Click on the button, then enter the 
> shortcut like you would in the program.\nExample for Ctrl+A: hold the Ctrl 
> key and press A.")

Are we able to use some form of units? Hardcoding this seems wrong.

> KeySequenceItem.qml:59
> +ToolTip.text:  _tr.i18n("Click on the button, then enter the 
> shortcut like you would in the program.\nExample for Ctrl+A: hold the Ctrl 
> key and press A.")
> +ToolTip.timeout: 5000
>  

Ditto here, but even hardcoded this looks wrong.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D29292

To: davidedmundson, #plasma
Cc: cblack, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D29232: [WIP][RFC]Introduce the Header color set

2020-04-27 Thread Carson Black
cblack added inline comments.

INLINE COMMENTS

> ndavis wrote in kcolorscheme.h:133
> I think it would be good to explain the issue about enums being converted 
> into plain integers here so that people know why they shouldn't depend on it. 
> Also, is there a way to hide this from the api.kde.org page for kcolorscheme?

`#ifndef K_DOXYGEN`

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D29232: [WIP][RFC]Introduce the Tools color set

2020-04-27 Thread Carson Black
cblack accepted this revision.
cblack added a comment.
This revision is now accepted and ready to land.


  +1 to the approach here. I assume this would probably replace the `WM` set in 
kdeglobals for all practical usage?

REPOSITORY
  R265 KConfigWidgets

BRANCH
  phab/toolsSet

REVISION DETAIL
  https://phabricator.kde.org/D29232

To: mart, #vdg, #plasma, cblack
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D26918: Improve KNotification API docs

2020-04-13 Thread Carson Black
cblack requested changes to this revision.
cblack added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> Mainpage.dox:13
> +In order to perform a notification, you need to create a description file, 
> which contains
> +default parameters of the notification. It needs to be installed to 
> knotifications5/appname.notifyrc
> +in a QStandardPaths::GenericDataLocation directory.

Use @c

> Mainpage.dox:15
> +in a QStandardPaths::GenericDataLocation directory.
> +On Android, this path is qrc:/knotifications5/.
> +

Ditto

> Mainpage.dox:19
> +component name to the KNotification object.
> +@warning Notifications won't be visible otherwise.
> +

Bad documentation style: warning block should be entirely self-contained in 
what it's conveying.

> Mainpage.dox:25
> + This file contains  mainly 3 parts
> +  
> +  \ref global "Global information"

Use markdown syntax, not inline HTML.

> Mainpage.dox:33
> +The global part looks like that
> +
> +[Global]

`@code` and `@endcode` or use markdown

> Mainpage.dox:46
> +This part consists of hints for the configuration widget
> + 
> +[Context/group]

Ditto

> Mainpage.dox:61
> +The definition of the events forms the most important part of the config file
> +
> +[Event/newmail]

Ditto

> Mainpage.dox:110
> +// DOXYGEN_SET_EXCLUDE_PATTERNS += *_p.h */private/* */examples/*
> +// DOXYGEN_SET_PROJECT_NAME = KNotifications
> +// vim:ts=4:sw=4:expandtab:filetype=doxygen

Use `docs/Doxyfile.local` for configuration overrides. Examples exclude is 
unnecessary because it's set as Doxygen's example path.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D26918

To: nicolasfella, #frameworks, broulik, jucato, cblack
Cc: cblack, class, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns


D28766: Add auth-sim-locked and auth-sim-missing

2020-04-11 Thread Carson Black
cblack accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  sim-card (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28766

To: ndavis, #vdg, cblack
Cc: kde-frameworks-devel, salvahg, Orage, LeGast00n, cblack, hannahk, 
frmdstryr, fbampaloukas, emrek, mkraemer, cahfofpai, asghaier, michaelh, 
tbalzer, dkardarakos, ndavis, PureTryOut, lnj, neofytosk, ngraham, bruns, 
alexeymin, jbbgameich, IlyaBizyaev, dvasin, jucato, jessep, Sergobot, sebas


D28765: KSettings::Dialog: add support for KPluginInfos without a KService

2020-04-11 Thread Carson Black
cblack added inline comments.

INLINE COMMENTS

> kcmoduleinfo.h:130
>   * @return a QExplicitlySharedDataPointer to KService created from the 
> modules .desktop file
> + * WARNING: this will be null if this KCModuleInfo was created from a 
> KPluginInfo coming from KPluginMetaData
> + * Prefer using pluginInfo() instead, which works for both kinds.

Use `@warning` instead of `WARNING:` for better markup

`WARNING:`
F8232033: image.png 
`@warning:`
F8232034: image.png 

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D28765

To: dfaure, pino, broulik, mart, davidedmundson
Cc: cblack, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D28734: Port to Aether Bootstrap 4

2020-04-11 Thread Carson Black
cblack closed this revision.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28734

To: cblack, #vdg, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, michaelh, ngraham, bruns, skadinna


D28737: Add sim card device icons

2020-04-10 Thread Carson Black
cblack accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  sim-card (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28737

To: ndavis, #vdg, cblack
Cc: kde-frameworks-devel, Orage, LeGast00n, cblack, hannahk, frmdstryr, 
fbampaloukas, GB_2, emrek, mkraemer, cahfofpai, asghaier, michaelh, tbalzer, 
dkardarakos, ndavis, PureTryOut, lnj, neofytosk, ngraham, bruns, alexeymin, 
jbbgameich, IlyaBizyaev, dvasin, jucato, jessep, Sergobot, sebas


D28734: Port to Aether Bootstrap 4

2020-04-10 Thread Carson Black
cblack updated this revision to Diff 79798.
cblack added a comment.


  Remove unused Bootstrap 3 assets

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28734?vs=79796=79798

BRANCH
  cblack+ognarb/bootstrap-4 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28734

AFFECTED FILES
  src/kapidox/data/htmlresource/3rd-party/bootstrap/LICENSE.txt
  src/kapidox/data/htmlresource/3rd-party/bootstrap/css/bootstrap-theme.css
  src/kapidox/data/htmlresource/3rd-party/bootstrap/css/bootstrap-theme.css.map
  src/kapidox/data/htmlresource/3rd-party/bootstrap/css/bootstrap-theme.min.css
  
src/kapidox/data/htmlresource/3rd-party/bootstrap/css/bootstrap-theme.min.css.map
  src/kapidox/data/htmlresource/3rd-party/bootstrap/css/bootstrap.css
  src/kapidox/data/htmlresource/3rd-party/bootstrap/css/bootstrap.css.map
  src/kapidox/data/htmlresource/3rd-party/bootstrap/css/bootstrap.min.css
  src/kapidox/data/htmlresource/3rd-party/bootstrap/css/bootstrap.min.css.map
  
src/kapidox/data/htmlresource/3rd-party/bootstrap/fonts/glyphicons-halflings-regular.eot
  
src/kapidox/data/htmlresource/3rd-party/bootstrap/fonts/glyphicons-halflings-regular.svg
  
src/kapidox/data/htmlresource/3rd-party/bootstrap/fonts/glyphicons-halflings-regular.ttf
  
src/kapidox/data/htmlresource/3rd-party/bootstrap/fonts/glyphicons-halflings-regular.woff
  
src/kapidox/data/htmlresource/3rd-party/bootstrap/fonts/glyphicons-halflings-regular.woff2
  src/kapidox/data/htmlresource/3rd-party/bootstrap/js/bootstrap.js
  src/kapidox/data/htmlresource/3rd-party/bootstrap/js/bootstrap.min.js
  src/kapidox/data/htmlresource/3rd-party/bootstrap/js/npm.js
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/templates/base.html

To: cblack, #vdg, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna


D28734: Port to Aether Bootstrap 4

2020-04-10 Thread Carson Black
cblack updated this revision to Diff 79796.
cblack added a comment.


  Fix footer text

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28734?vs=79794=79796

BRANCH
  cblack+ognarb/bootstrap-4 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28734

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/templates/base.html

To: cblack, #vdg, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna


D28734: Port to Aether Bootstrap 4

2020-04-10 Thread Carson Black
cblack edited the summary of this revision.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28734

To: cblack, #vdg, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna


D28734: Port to Aether Bootstrap 4

2020-04-10 Thread Carson Black
cblack edited the summary of this revision.

REPOSITORY
  R264 KApiDox

REVISION DETAIL
  https://phabricator.kde.org/D28734

To: cblack, #vdg, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna


D28734: Port to Aether Bootstrap 4

2020-04-10 Thread Carson Black
cblack created this revision.
cblack added reviewers: VDG, ochurlaud.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Output generated by kapidox now uses Aether Bootstrap from the KDE CDN.
  
  F8230701: 
janpontaoski.ddns.net_8000_frameworks_kwayland_html_classKWayland_1_1Server_1_1BufferHandle.html
 (1).png 
  
  F8230699: 
janpontaoski.ddns.net_8000_frameworks_kwayland_html_classKWayland_1_1Server_1_1BufferHandle.html.png
 

REPOSITORY
  R264 KApiDox

BRANCH
  cblack+ognarb/bootstrap-4 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28734

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/templates/base.html

To: cblack, #vdg, ochurlaud
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna


D28712: Redo api.kde.org to look more like Aether

2020-04-10 Thread Carson Black
This revision was automatically updated to reflect the committed changes.
Closed by commit R264:a6c47b24d1df: Redo api.kde.org to look more like Aether 
(authored by cblack).

REPOSITORY
  R264 KApiDox

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28712?vs=79738=79769

REVISION DETAIL
  https://phabricator.kde.org/D28712

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/templates/base.html
  src/kapidox/data/templates/frontpage-sidebar.html
  src/kapidox/data/templates/frontpage.html
  src/kapidox/data/templates/library-sidebar.html
  src/kapidox/data/templates/subgroup-sidebar.html

To: cblack, #vdg, ognarb, ochurlaud
Cc: ngraham, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, bruns, skadinna


D28712: Redo api.kde.org to look more like Aether

2020-04-09 Thread Carson Black
cblack created this revision.
cblack added reviewers: VDG, ognarb.
Herald added projects: Frameworks, Documentation.
Herald added subscribers: kde-doc-english, kde-frameworks-devel.
cblack requested review of this revision.

TEST PLAN
  F8227629: image.png  F8227630: 
image.png  F8227631: image.png 

  
  F8227633: _home_cdblack_workdir_kirigamidocs_build_index.html(Pixel 2 XL) 
(1).png  F8227634: 
_home_cdblack_workdir_kirigamidocs_build_kwindowsystem_html_classKWindowSystem.html(Pixel
 2 XL).png 

REPOSITORY
  R264 KApiDox

BRANCH
  cblack/aether (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28712

AFFECTED FILES
  src/kapidox/data/htmlresource/css/kapidox.css
  src/kapidox/data/templates/base.html
  src/kapidox/data/templates/frontpage-sidebar.html
  src/kapidox/data/templates/frontpage.html
  src/kapidox/data/templates/library-sidebar.html
  src/kapidox/data/templates/subgroup-sidebar.html

To: cblack, #vdg, ognarb
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna


D28444: Add ECMCargo module

2020-04-06 Thread Carson Black
cblack updated this revision to Diff 79521.
cblack added a comment.


  Add STATIC_LIBNAME and DYNAMIC_LIBNAME options

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28444?vs=79430=79521

BRANCH
  cblack/cargo-integration

REVISION DETAIL
  https://phabricator.kde.org/D28444

AFFECTED FILES
  modules/ECMCargo.cmake

To: cblack, #frameworks, #build_system
Cc: apol, IlyaBizyaev, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
cblack, GB_2, bencreasy, michaelh, ngraham, bruns


D27263: RFC: Accent colour for KColorScheme

2020-04-06 Thread Carson Black
cblack updated this revision to Diff 79517.
cblack added a comment.


  Fix typo

REPOSITORY
  R265 KConfigWidgets

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27263?vs=75311=79517

BRANCH
  kcolorscheme-accent (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27263

AFFECTED FILES
  src/kcolorscheme.cpp
  src/kcolorscheme.h

To: cblack, #plasma
Cc: The-Feren-OS-Dev, ngraham, kde-frameworks-devel, ndavis, LeGast00n, cblack, 
GB_2, michaelh, bruns


D28444: WIP/RFC: Add ECMCargo module

2020-04-05 Thread Carson Black
cblack updated this revision to Diff 79430.
cblack added a comment.


  Address feedback

REPOSITORY
  R240 Extra CMake Modules

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28444?vs=78925=79430

BRANCH
  cblack/cargo-integration

REVISION DETAIL
  https://phabricator.kde.org/D28444

AFFECTED FILES
  modules/ECMCargo.cmake

To: cblack, #frameworks, #build_system
Cc: apol, IlyaBizyaev, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
cblack, GB_2, bencreasy, michaelh, ngraham, bruns


D28444: Add ECMCargo module

2020-04-05 Thread Carson Black
cblack retitled this revision from "WIP/RFC: Add ECMCargo module" to "Add 
ECMCargo module".
cblack edited the summary of this revision.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28444

To: cblack, #frameworks, #build_system
Cc: apol, IlyaBizyaev, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
cblack, GB_2, bencreasy, michaelh, ngraham, bruns


D28579: Improve the look of kcachegrind

2020-04-04 Thread Carson Black
cblack accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  kcachegrind (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28579

To: ndavis, #vdg, cblack
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28470: WIP: IconItem: Refactor source handling for different types

2020-04-02 Thread Carson Black
cblack added a comment.


  Splitting into multiple classes seems like a good idea, but "strategy"? Seems 
like an odd choice of name to me.

INLINE COMMENTS

> iconitem.cpp:58
> +
> +class NullStategy : public IconItemStrategy
> +{

Is this class necessary? I feel like this class's behaviour should be what its 
parent does without a child implementation.

> iconitem.cpp:58
> +
> +class NullStategy : public IconItemStrategy
> +{

Also, "Stategy" instead of "Strategy"

> iconitem.cpp:80
> +private:
> +QIcon m_icon;
> +};

Seems unused.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28470

To: kmaterka, #plasma, broulik, apol, davidedmundson
Cc: cblack, kde-frameworks-devel, #plasma, LeGast00n, GB_2, michaelh, ngraham, 
bruns


D28444: WIP/RFC: Add ECMCargo module

2020-03-31 Thread Carson Black
cblack added a comment.


  In D28444#638988 , @IlyaBizyaev 
wrote:
  
  > In D28444#638877 , @cblack wrote:
  >
  > > CMake needs to know when the Rust source has changed so it can rebuild it
  >
  >
  > Changes to Rust code need to be tracked by Cargo, not by CMake
  
  
  CMake needs to know what files Cargo wants to build in order to invoke it 
only when Rust files change. There's no reason to invoke Cargo every time 
`make` is ran when CMake has the ability to keep track of dirty files.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28444

To: cblack, #frameworks, #build_system
Cc: apol, IlyaBizyaev, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
cblack, GB_2, bencreasy, michaelh, ngraham, bruns


D28444: WIP/RFC: Add ECMCargo module

2020-03-31 Thread Carson Black
cblack added a comment.


  In D28444#638540 , @IlyaBizyaev 
wrote:
  
  > In D28444#638430 , @cblack wrote:
  >
  > > more than half of Ikona's CMakeLists.txt is boilerplate dedicated to 
integrating Rust with the rest of the project
  >
  >
  > I don't understand why your function needs a list of Rust files, even 
though those are already handled by Cargo. Looks boilerplate-ish...
  
  
  CMake needs to know when the Rust source has changed so it can rebuild it

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28444

To: cblack, #frameworks, #build_system
Cc: apol, IlyaBizyaev, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
cblack, GB_2, bencreasy, michaelh, ngraham, bruns


D28452: Fix baloo compile

2020-03-30 Thread Carson Black
cblack accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D28452

To: usta, #baloo, ngraham, cblack
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, cblack, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams


D28444: WIP/RFC: Add ECMCargo module

2020-03-30 Thread Carson Black
cblack added a comment.


  In D28444#638435 , @apol wrote:
  
  > Will this make all the boilerplate in ikona disappear?
  
  
  It'll bring it down to the same level as everything else.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28444

To: cblack, #frameworks, #build_system
Cc: apol, IlyaBizyaev, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
cblack, GB_2, bencreasy, michaelh, ngraham, bruns


D28444: WIP/RFC: Add ECMCargo module

2020-03-30 Thread Carson Black
cblack added a comment.


  In D28444#638428 , @apol wrote:
  
  > I wonder if this is covering a very widespread use-case. If there's just 
one application that needs it, it could make sense to keep it there and once 
it's polished, we put it in ECM to share.
  
  
  I feel like one of the reasons KDE doesn't use Rust more is that using it in 
the build system side is pain. Case in point: more than half of Ikona's 
CMakeLists.txt is boilerplate dedicated to integrating Rust with the rest of 
the project. I'd like to get this in ECM to lower the barrier for other KDE 
applications and libraries to utilize Rust.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D28444

To: cblack, #frameworks, #build_system
Cc: apol, IlyaBizyaev, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
cblack, GB_2, bencreasy, michaelh, ngraham, bruns


D28444: WIP/RFC: Add ECMCargo module

2020-03-30 Thread Carson Black
cblack created this revision.
cblack added reviewers: Frameworks, Build System.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
cblack requested review of this revision.

REVISION SUMMARY
  The ECMCargo module allows for easy usage of Rust projects
  in a CMake project. Usage looks like this:
  
ecm_add_cargo_workspace(
  WORKSPACE_DIRECTORY src/rs/
  WORKSPACE_NAME ikona
  FEATURES with-svgcleaner
  DEPENDS src/rs/src/ikona/icons/mod.rs
  src/rs/src/ikona/icontheme/mod.rs
  src/rs/src/ikona/icons/tests.rs
  src/rs/src/ikona/lib.rs
  src/rs/src/capi/capi.rs
  VENDOR_TARBALL ikona.cargo.vendor.tar.xz
  VENDOR_CONFIG cargo-vendor-config.toml
)
...
target_link_libraries(ikona
  PRIVATE Qt5::Core Qt5::Widgets Qt5::Quick Qt5::Concurrent KF5::I18n 
KF5::Kirigami2 KF5::ConfigWidgets "${ikona_artifacts_dir}/libikonars.so")
  
  Todo:
  
  [ ] More thorough testing
  [ ] Documentation

REPOSITORY
  R240 Extra CMake Modules

BRANCH
  cblack/cargo-integration

REVISION DETAIL
  https://phabricator.kde.org/D28444

AFFECTED FILES
  modules/ECMCargo.cmake

To: cblack, #frameworks, #build_system
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, GB_2, bencreasy, 
michaelh, ngraham, bruns


D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-03-27 Thread Carson Black
cblack requested changes to this revision.
cblack added a comment.


  I've changed my mind to agree with @ngraham here—this is too transparent.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack, ngraham
Cc: ngraham, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-03-27 Thread Carson Black
cblack added a comment.


  In D28353#636183 , @niccolove 
wrote:
  
  > In D28353#636164 , @cblack wrote:
  >
  > > Looks visually appealing to me, with one question: How does this look on 
low-end hardware where there's compositing but no blur?
  >
  >
  > Before:
  >  F8201840: Screenshot_20200327_180214.png 

  > After:
  >  F8201842: Screenshot_20200327_180258.png 

  >
  > It is more grayish, but that will no longer be as soon as D28317 
 lands
  
  
  Looks like a downgrade in legibility, but it wasn't too great before either. 
I wouldn't consider it a blocker.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  contrast_and_transparency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-03-27 Thread Carson Black
cblack accepted this revision as: VDG, cblack.
cblack added a comment.
This revision is now accepted and ready to land.


  Looks visually appealing to me, with one question: How does this look on 
low-end hardware where there's compositing but no blur?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  contrast_and_transparency (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-03-27 Thread Carson Black
cblack added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

2020-03-23 Thread Carson Black
cblack accepted this revision as: VDG, cblack.
cblack added a comment.
This revision is now accepted and ready to land.


  Pin icon looks good, but I fail to see how removing edit-delete is a related 
change in this patch.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  pin-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28228

To: ndavis, #vdg, #plasma, cblack
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D28168: Broadcast application menu to resources when registering them

2020-03-20 Thread Carson Black
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:8032cb0f0e9a: Broadcast application menu to resources 
when registering them (authored by cblack).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28168?vs=78119=78133

REVISION DETAIL
  https://phabricator.kde.org/D28168

AFFECTED FILES
  src/server/plasmawindowmanagement_interface.cpp

To: cblack, #kwin, zzag
Cc: kde-frameworks-devel, zzag, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28168: Broadcast application menu to resources when registering them

2020-03-20 Thread Carson Black
cblack created this revision.
cblack added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Previously, KWayland wasn't hanging onto the application menu
  to broadcast it when registering a resource. This fixes that.

REPOSITORY
  R127 KWayland

BRANCH
  cblack/broadcast-appmenu-on-resource-register (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28168

AFFECTED FILES
  src/server/plasmawindowmanagement_interface.cpp

To: cblack, #kwin
Cc: kde-frameworks-devel, zzag, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28164: Add test for application menu in PWM interface

2020-03-20 Thread Carson Black
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:4f4142d3d3a8: Add test for application menu in PWM 
interface (authored by cblack).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28164?vs=78109=78111

REVISION DETAIL
  https://phabricator.kde.org/D28164

AFFECTED FILES
  autotests/client/test_wayland_windowmanagement.cpp

To: cblack, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28164: Add test for application menu in PWM interface

2020-03-20 Thread Carson Black
cblack created this revision.
cblack added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cblack requested review of this revision.

TEST PLAN
  See that the test works as expected.

REPOSITORY
  R127 KWayland

BRANCH
  cblack/appmenu-tests (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28164

AFFECTED FILES
  autotests/client/test_wayland_windowmanagement.cpp

To: cblack, #kwin
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28112: Expose application menu via KWindowInfo

2020-03-18 Thread Carson Black
This revision was automatically updated to reflect the committed changes.
Closed by commit R278:93814b513d45: Expose application menu via KWindowInfo 
(authored by cblack).

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28112?vs=77921=77922

REVISION DETAIL
  https://phabricator.kde.org/D28112

AFFECTED FILES
  autotests/netwininfotestclient.cpp
  src/kwindowinfo.cpp
  src/kwindowinfo.h
  src/kwindowinfo_p.h
  src/netwm_def.h
  src/platforms/xcb/atoms_p.h
  src/platforms/xcb/kwindowinfo.cpp
  src/platforms/xcb/kwindowinfo_p_x11.h
  src/platforms/xcb/netwm.cpp
  src/platforms/xcb/netwm.h
  src/platforms/xcb/netwm_p.h

To: cblack, #plasma, broulik, zzag, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28112: Expose application menu via KWindowInfo

2020-03-18 Thread Carson Black
cblack edited the summary of this revision.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D28112

To: cblack, #plasma, broulik, zzag, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28112: [WIP] Expose application menu via KWindowInfo

2020-03-18 Thread Carson Black
cblack updated this revision to Diff 77921.
cblack added a comment.


  Plonk a space

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28112?vs=77915=77921

BRANCH
  appmenu-x11 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28112

AFFECTED FILES
  autotests/netwininfotestclient.cpp
  src/kwindowinfo.cpp
  src/kwindowinfo.h
  src/kwindowinfo_p.h
  src/netwm_def.h
  src/platforms/xcb/atoms_p.h
  src/platforms/xcb/kwindowinfo.cpp
  src/platforms/xcb/kwindowinfo_p_x11.h
  src/platforms/xcb/netwm.cpp
  src/platforms/xcb/netwm.h
  src/platforms/xcb/netwm_p.h

To: cblack, #plasma, broulik, zzag, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28112: Expose application menu via KWindowInfo

2020-03-18 Thread Carson Black
cblack retitled this revision from "[WIP] Expose application menu via 
KWindowInfo" to "Expose application menu via KWindowInfo".

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D28112

To: cblack, #plasma, broulik, zzag, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28112: Expose application menu via KWindowInfo

2020-03-18 Thread Carson Black
cblack marked 2 inline comments as done.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D28112

To: cblack, #plasma, broulik, zzag, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28112: [WIP] Expose application menu via KWindowInfo

2020-03-18 Thread Carson Black
cblack updated this revision to Diff 77915.
cblack marked 8 inline comments as done.
cblack added a comment.


  Address feedback

REPOSITORY
  R278 KWindowSystem

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28112?vs=77875=77915

BRANCH
  appmenu-x11 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28112

AFFECTED FILES
  autotests/netwininfotestclient.cpp
  src/kwindowinfo.cpp
  src/kwindowinfo.h
  src/kwindowinfo_p.h
  src/netwm_def.h
  src/platforms/xcb/atoms_p.h
  src/platforms/xcb/kwindowinfo.cpp
  src/platforms/xcb/kwindowinfo_p_x11.h
  src/platforms/xcb/netwm.cpp
  src/platforms/xcb/netwm.h
  src/platforms/xcb/netwm_p.h

To: cblack, #plasma, broulik, zzag, #kwin
Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


D28114: Add call-incoming/missed/outgoing

2020-03-18 Thread Carson Black
cblack requested changes to this revision.
cblack added a comment.
This revision now requires changes to proceed.


  The 16px icons should probably drop the phone, as the distinguishing elements 
between them are so small as to impair the ease of telling the icons apart. 
Legibility should be prioritised over metaphor.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D28114

To: ndavis, #vdg, cblack
Cc: cblack, jbbgameich, bshah, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns


D28112: [WIP] Expose application menu via KWindowInfo

2020-03-17 Thread Carson Black
cblack created this revision.
cblack added reviewers: Plasma, broulik.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Application menu information is now available
  via KWindowInfo's APIs on X11.
  
  Note that this is dysfunctional, currently. Written tests
  are failing, and I've identified that the blocks at
  src/platforms/xcb/netwm.cpp lines 4677 and 4687 cause their
  respective tests to fail. However, I can't identify where
  I dun goofed.

REPOSITORY
  R278 KWindowSystem

BRANCH
  appmenu-x11 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28112

AFFECTED FILES
  autotests/netwininfotestclient.cpp
  src/kwindowinfo.cpp
  src/kwindowinfo.h
  src/kwindowinfo_p.h
  src/netwm_def.h
  src/platforms/xcb/atoms_p.h
  src/platforms/xcb/kwindowinfo.cpp
  src/platforms/xcb/kwindowinfo_p_x11.h
  src/platforms/xcb/netwm.cpp
  src/platforms/xcb/netwm.h
  src/platforms/xcb/netwm_p.h

To: cblack, #plasma, broulik
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D28111: Add transmission-tray-icon

2020-03-17 Thread Carson Black
cblack accepted this revision.
cblack added a comment.
This revision is now accepted and ready to land.


  LGTM.

REPOSITORY
  R266 Breeze Icons

BRANCH
  transmission (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28111

To: ndavis, #vdg, cblack
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D27416: Add small icons for KeePassXC

2020-03-17 Thread Carson Black
cblack accepted this revision.
cblack added a comment.
This revision is now accepted and ready to land.


  LGTM now. Good icon 

REPOSITORY
  R266 Breeze Icons

BRANCH
  keepassxc-small

REVISION DETAIL
  https://phabricator.kde.org/D27416

To: wsdfhjxc, #vdg, cblack, ndavis
Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns


D27416: Add small icons for KeePassXC

2020-03-16 Thread Carson Black
cblack requested changes to this revision.
cblack added a comment.
This revision now requires changes to proceed.


  The key in both icons should be pixel aligned to prevent blurry edges at the 
size it's going to be rendered at.
  
  F8180107: image.png 
  
  This should also be in `status/` instead of `apps/` as it's a tray icon.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27416

To: wsdfhjxc, #vdg, cblack
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D28033: Create ExpandableListItem

2020-03-13 Thread Carson Black
cblack added a comment.


  In D28033#627180 , @davidre wrote:
  
  > I would love if we could find a way to show that the item is expandable
  
  
  I would probably use a pointing down arrow without a stem when collapsed, and 
pointing up when open.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28033

To: ngraham, #vdg, #plasma
Cc: cblack, davidre, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-06 Thread Carson Black
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:dddf9d1ac3f2: Add application menu dbus paths to 
org_kde_plasma_window interface (authored by cblack).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27464?vs=76886=77147

REVISION DETAIL
  https://phabricator.kde.org/D27464

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/protocols/plasma-window-management.xml
  src/client/registry.cpp
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h

To: cblack, #kwin, zzag, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27851: Add rss icons in action

2020-03-04 Thread Carson Black
cblack added a comment.


  SVG-wise, optimization here seems suboptimal. There's excess elements that 
could be removed.
  
  Visually, the icon looks like the RSS icon, which is about all you need out 
of an RSS icon.
  
  I do believe we need at least 16px and 22px for monochromatic actions, though.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27851

To: ognarb, #vdg, #breeze
Cc: cblack, kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2, trickyricky26, 
michaelh, ngraham, bruns


D27851: Add rss icons in action

2020-03-04 Thread Carson Black
cblack edited reviewers, added: VDG, Breeze; removed: ndavis.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27851

To: ognarb, #vdg, #breeze, ndavis
Cc: kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2, trickyricky26, 
michaelh, ngraham, bruns


D27848: Remove the tooltip icon

2020-03-04 Thread Carson Black
cblack accepted this revision.
cblack added a comment.
This revision is now accepted and ready to land.


  Visually, LGTM.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27848

To: ngraham, #vdg, #plasma, cblack
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-03 Thread Carson Black
cblack added a dependent revision: D27818: [wayland/AbstractClient] Broadcast 
application menu events.

REPOSITORY
  R127 KWayland

BRANCH
  cblack/appmenu-listener

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-03 Thread Carson Black
cblack updated this revision to Diff 76886.
cblack added a comment.


  Add missing documentation

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27464?vs=76885=76886

BRANCH
  cblack/appmenu-listener

REVISION DETAIL
  https://phabricator.kde.org/D27464

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/protocols/plasma-window-management.xml
  src/client/registry.cpp
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h

To: cblack, #kwin, zzag, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-03 Thread Carson Black
cblack updated this revision to Diff 76885.
cblack added a comment.


  Address feedback

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27464?vs=76811=76885

BRANCH
  cblack/appmenu-listener

REVISION DETAIL
  https://phabricator.kde.org/D27464

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/protocols/plasma-window-management.xml
  src/client/registry.cpp
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h

To: cblack, #kwin, zzag, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-03 Thread Carson Black
cblack added a comment.


  @zzag does anything else look off to you?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag, davidedmundson
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-02 Thread Carson Black
cblack updated this revision to Diff 76811.
cblack added a comment.


  Coding style

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27464?vs=76805=76811

BRANCH
  cblack/appmenu-listener

REVISION DETAIL
  https://phabricator.kde.org/D27464

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/protocols/plasma-window-management.xml
  src/client/registry.cpp
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h

To: cblack, #kwin, zzag
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-02 Thread Carson Black
cblack marked an inline comment as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-02 Thread Carson Black
cblack marked 3 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-02 Thread Carson Black
cblack updated this revision to Diff 76805.
cblack added a comment.


  Tick up PWM version

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27464?vs=76804=76805

BRANCH
  cblack/appmenu-listener

REVISION DETAIL
  https://phabricator.kde.org/D27464

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/protocols/plasma-window-management.xml
  src/client/registry.cpp
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h

To: cblack, #kwin, zzag
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-02 Thread Carson Black
cblack marked 6 inline comments as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-02 Thread Carson Black
cblack updated this revision to Diff 76804.
cblack added a comment.


  Address feedback

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27464?vs=76035=76804

BRANCH
  cblack/appmenu-listener

REVISION DETAIL
  https://phabricator.kde.org/D27464

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/protocols/plasma-window-management.xml
  src/client/registry.cpp
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h

To: cblack, #kwin, zzag
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-03-01 Thread Carson Black
cblack added a comment.


  Would the version number already being 9 in old versions of KWayland cause 
any issues? I have a feeling old KWayland versions may not like it when they're 
sent events they don't recognize, unless libwayland/KWayland handle that 
usecase.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-02-24 Thread Carson Black
cblack added inline comments.

INLINE COMMENTS

> davidedmundson wrote in plasmawindowmanagement_interface.cpp:129
> how is this 9 already?

Git blame shows that it's been 9 since 2018. Looks like someone made a mistake 
a while back?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27589: Try to apply the colorscheme of the current theme to QIcons

2020-02-22 Thread Carson Black
cblack accepted this revision.
cblack added a comment.
This revision is now accepted and ready to land.


  Patch works as advertised and the code LGTM.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  qiconcolor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27589

To: davidre, #plasma, cblack
Cc: cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-02-21 Thread Carson Black
cblack added a comment.


  In D27464#614479 , @davidedmundson 
wrote:
  
  > Good start. The direction makes sense.
  >
  > display.cpp and registry.cpp need updating to the new version number. 
Otherwise we won't be able to use this new method.
  >
  > It'd be great if you could update the unit test too.
  
  
  Pardon, but I don't see anything in display/registry.cpp that looks like it 
takes a version number for the org_kde_plasma_window interface. I only see 
okp_windowmanagement in registry.cpp. Am I missing something?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-02-19 Thread Carson Black
cblack marked an inline comment as done.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-02-19 Thread Carson Black
cblack updated this revision to Diff 76035.
cblack added a comment.


  Use utf8 encoding on client side

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27464?vs=75855=76035

BRANCH
  cblack/appmenu-listener

REVISION DETAIL
  https://phabricator.kde.org/D27464

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/protocols/plasma-window-management.xml
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h

To: cblack, #kwin, zzag
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, 
ngraham, bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-02-17 Thread Carson Black
cblack updated this revision to Diff 75855.
cblack added a comment.


  Figure out how to use arc correctly

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27464?vs=75854=75855

BRANCH
  cblack/appmenu-listener

REVISION DETAIL
  https://phabricator.kde.org/D27464

AFFECTED FILES
  src/client/plasmawindowmanagement.cpp
  src/client/plasmawindowmanagement.h
  src/client/protocols/plasma-window-management.xml
  src/server/plasmawindowmanagement_interface.cpp
  src/server/plasmawindowmanagement_interface.h

To: cblack, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-02-17 Thread Carson Black
cblack planned changes to this revision.
cblack added a comment.


  whoops, I seem to have forgotten how to use arc

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D27464

To: cblack, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27464: Add application menu dbus paths to org_kde_plasma_window interface

2020-02-17 Thread Carson Black
cblack created this revision.
cblack added reviewers: KWin, zzag.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cblack requested review of this revision.

REVISION SUMMARY
  This patch adds an interface allowing a compositor to send
  the service name and object path of a PlasmaWindow's application menu
  to the client.

REPOSITORY
  R127 KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27464

AFFECTED FILES
  .gitignore
  src/CMakeLists.txt
  src/client/CMakeLists.txt
  src/org_kde_kwayland.categories
  src/server/CMakeLists.txt

To: cblack, #kwin, zzag
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27246: add buho icon

2020-02-13 Thread Carson Black
cblack added a comment.


  In D27246#610777 , @ndavis wrote:
  
  > What is buho?
  
  
  Maui's note taking app

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D27246

To: mbruchert, camiloh, #vdg, ndavis
Cc: cblack, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns


D27218: Add icon for org.kde.Ikona

2020-02-12 Thread Carson Black
This revision was automatically updated to reflect the committed changes.
Closed by commit R266:96cf15e1905d: Add icon for org.kde.Ikona (authored by 
cblack).

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27218?vs=75577=75578

REVISION DETAIL
  https://phabricator.kde.org/D27218

AFFECTED FILES
  icons-dark/apps/48/org.kde.Ikona.svg
  icons/apps/48/org.kde.Ikona.svg

To: cblack, #vdg, ndavis
Cc: ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, 
bruns


  1   2   >