D29463: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

[Chris Holland]

Zren added reviewers: Kirigami, mart.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29463

To: Zren, #kirigami, mart
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29463: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

[Chris Holland]

Zren created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
Zren requested review of this revision.

REVISION SUMMARY
  I recently noticed that `Kirigami.Units.devicePixelRatio` was `1.3` even 
though I was at the default 96dpi when writing a widget's config.
  
  F8287886: 2020-05-05___19-00-48.png 
  
  There's 4 different `Units.qml`, and I'm not certain which does what. 2 are 
in `krigiami` and the other 2 are in `plasma-framework`.
  
$ locate /Units.qml | grep /usr/
/usr/lib/qt/qml/org/kde/kirigami.2/Units.qml
/usr/lib/qt/qml/org/kde/kirigami.2/styles/Plasma/Units.qml
/usr/lib/qt/qml/org/kde/kirigami.2/styles/org.kde.desktop/Units.qml
/usr/lib/qt/qml/org/kde/kirigami.2/styles/org.kde.desktop.plasma/Units.qml
  
  
  
  - 2 years ago `kirigami/src/controls/Units.qml` 
 
(`/usr/lib/qt/qml/org/kde/kirigami.2/Units.qml`) was changed from `13/10 = 1.3` 
to multiply by `13*0.75` so that `9.75/10 = 0.975` (then `max(1, 0.975) = 1`).
  
  -
  
  There's 2 files owned by `plasma-framework`. The `/styles/Plasma/Units.qml` 
binds PlasmaCore's `units.devicePixelRatio`, so that leaves 
`/styles/org.kde.desktop.plasma/Units.qml`.
  
$ pacman -Qo 
/usr/lib/qt/qml/org/kde/kirigami.2/styles/org.kde.desktop.plasma/Units.qml
/usr/lib/qt/qml/org/kde/kirigami.2/styles/org.kde.desktop.plasma/Units.qml 
is owned by plasma-framework 5.69.0-2
  
  This patch edits the `org.kde.desktop.plasma` style, and fixes `qmlscene 
KirigamiDevicePixelRatioTest.qml`, and `plasmashell` widget configs, and 
`plasmoidviewer` widget configs.
  
  The Kirigami patch is D29462 

TEST PLAN
  You can edit 
`/usr/lib/qt/qml/org/kde/kirigami.2/styles/org.kde.desktop.plasma/Units.qml` 
then run:
  
  - https://gist.github.com/Zren/621338b8cda7c550d7b43f8ea1ba71a7
  - `qmlscene KirigamiDevicePixelRatioTest.qml`
  
  and `Kirigami.Units.devicePixelRatio` should equal `1`.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29463

AFFECTED FILES
  src/declarativeimports/kirigamiplasmadesktopstyle/Units.qml
  src/declarativeimports/kirigamiplasmastyle/Units.qml

To: Zren
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28874: Taiwanese holidays

[Chris Holland]

Zren added a comment.


  Phab only understands `.diff`. Phab does not recognize `.patch`.
  
git diff --staged > D28874.diff
  
  Or:
  
git diff origin/master > D28874.diff

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28874

To: shrapnel, #vdg, Zren, winterz
Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28874: Taiwanese holidays

[Chris Holland]

Zren added a comment.


  There's a few extra spaces at the end of `"植樹節 "` and `"中秋節 補假 "` too.
  
  Not sure how well you know `git`, but make sure to run `git add 
holidays/plan2/holiday_tw_zh` again after making your changes, before running 
`git diff --staged` to upload the modified diff.

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28874

To: shrapnel, #vdg, Zren, winterz
Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28874: Taiwanese holidays

[Chris Holland]

Zren added a comment.


  Now you're missing `holidays/plan2/holiday_tw_zh` which can still be seen 
here: https://phabricator.kde.org/D28874?id=80260
  
git add holidays/holidays.qrc
git add holidays/plan2/holiday_tw_zh
git diff --staged > D28874.diff

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D28874

To: shrapnel, #vdg, Zren
Cc: winterz, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D24524: Add a common widget config control library starting with ConfigIcon.qml

[Chris Holland]

Zren created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
Zren requested review of this revision.

REVISION SUMMARY
  I'm submitting this to start discussion on creating a common config control 
library.
  
  I've started with a more common use case, an Icon control, to start us off.
  
  - This is based on the kickoff icon control. 
https://github.com/KDE/plasma-desktop/blob/master/applets/kickoff/package/contents/ui/ConfigGeneral.qml
  - I added:
- The preview size and padding can be changed
- The default icon that used when "cleared" can be changed.
- A TextField (Would be easier for power users, but I understand not adding 
it)
- A dedicated browse button (I'm not against removing)
- Preset values in the dropdown (I don't really need it)
  - No idea if creating a new module is best. Nor if the name is okay. 
"configuration" is already in use.
  - `contents/config/config.qml` has `ConfigModel` and `ConfigCategory` under a 
`org.kde.plasma.configuration` module, however it is declared using C++ 
classes. 
https://github.com/KDE/plasma-framework/blob/acdaefa221cc3e4b60542b4805e53ed966ea23b7/autotests/configmodeltest.cpp#L40
  - I'm not sure why `MenuSeparator { visible: false }` leaves leftover 
whitespace.
  
  I currently have a QQC1 library 

 that assigns directly to `plasmoid.configuration[configKey]` without the user 
needing to click "Apply" (Like on Gnome). I'm not expecting "auto-serialize" to 
get merged to KDE however, which is unfortunate. `ConfigIcon { configKey: 
'icon' }` is very nice and compact, and clicking Apply feels pointless.
  
  Screenshots
  ===
  
  F7558454: 2019-10-09___12-45-11.png 
  F7558455: 2019-10-09___14-41-15.png 
  
  Use Cases
  =
  
  - Kicker, Kickoff
  - Present Windows T11776 
  - I use a modified version of this in Tiled Menu. I make the `ColumnLayout` 
the default property so I can optionally add a checkbox below the `TextField`. 
There's no need for this feature if we remove the TextField though. 
https://github.com/Zren/plasma-applet-tiledmenu/blob/master/package/contents/ui/lib/ConfigIcon.qml
 
https://github.com/Zren/plasma-applet-tiledmenu/blob/master/package/contents/ui/config/ConfigGeneral.qml#L73-L81
  
RowLayout
IconPreview
ColumnLayout
RowLayout
TextField
Button
CheckBox

TEST PLAN
  Not yet tested via `cmake` and importing, but the QML is tested in a widget.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24524

AFFECTED FILES
  src/declarativeimports/CMakeLists.txt
  src/declarativeimports/plasmaconfig/ConfigIcon.qml
  src/declarativeimports/plasmaconfig/qmldir

To: Zren
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24522: Add presentwindows icon (old "task view" from windows)

[Chris Holland]

Zren added a comment.


  > `preferences-system-windows-effect-presentwindows`
  
  That would look like the `homerun` icon, which looks like the "windows" logo.
  
  F7557693: 2019-10-09___13-01-07.png 
  
  When you clicked on "Task View" in Windows, the 2 "obscured" windows would 
animate left/right a little to demonstrate that all windows are now visible. 
There isn't really a good way to know when the KWin Effect is active like that 
though to do a similar animation.
  
  Nowadays, Windows has a different icon for their "task history" view.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24522

To: Zren, #vdg, #breeze
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24522: Add presentwindows icon (old "task view" from windows)

[Chris Holland]

Zren created this revision.
Zren added reviewers: VDG, Breeze.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
Zren requested review of this revision.

REVISION SUMMARY
  Needed for T11776 , but only we we want 
the widget for the "Windows" Look and Feel. The "Unity" Look and Feel would not 
need this icon.
  
  - I made the SVG, but it's obviously a copy. Windows doesn't even use this 
icon anymore.
  - https://commons.wikimedia.org/wiki/File:Windows_10_Task_View_Icon.svg
  - Wikipedia's licensing bit: "This image consists only of simple geometric 
shapes or text. It does not meet the threshold of originality needed for 
copyright protection, and is therefore in the public domain. Although it is 
free of copyright restrictions, this image may still be subject to other 
restrictions. See Fonts and typefaces for more information."
  - https://commons.wikimedia.org/wiki/File:Windows_10_Task_View_Icon.png
  - The PNG does have a disclaimer the SVG does not: " This work includes 
material that may be protected as a trademark in some jurisdictions. If you 
want to use it, you have to ensure that you have the legal right to do so and 
that you do not infringe any trademark rights. See our general disclaimer."
  
  F7557038: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24522

AFFECTED FILES
  icons/actions/16/presentwindows.svg
  icons/actions/22/presentwindows.svg
  icons/actions/24/presentwindows.svg

To: Zren, #vdg, #breeze
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D19821: Fix breeze dialog background with Qt 5.12.2

[Chris Holland]

Zren added a comment.


  Another option I believe is to keep the `

D15321: [Calendar] Expose firstDayOfWeek in MonthView for calendar widgets to override the Locale

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R242:e5949866bb8f: [Calendar] Expose firstDayOfWeek in 
MonthView (authored by Zren).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15321?vs=41123&id=48646

REVISION DETAIL
  https://phabricator.kde.org/D15321

AFFECTED FILES
  src/declarativeimports/calendar/qml/MonthView.qml

To: Zren, broulik
Cc: ngraham, broulik, kde-frameworks-devel, michaelh, bruns

D15321: [Calendar] Expose firstDayOfWeek in MonthView for calendar widgets to override the Locale

[Chris Holland]

Zren created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
Zren requested review of this revision.

REVISION SUMMARY
  Users may want to start the week on a Sunday, Saturday, or Monday without 
changing their locale's date formatting.
  
  CCBUG: 390330
  
  -
  
  If accepted, I'll be adding something a cleaned up version of the following 
patch to DigitalClock, Calendar, ... and the rest I guess.
  
  
https://github.com/Zren/plasma-applet-eventcalendar/commit/31c584900f318c8ae148ae9fbcc0ed58eccc5d9d

TEST PLAN
  DigitalClock widget still loaded fine.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15321

AFFECTED FILES
  src/declarativeimports/calendar/qml/MonthView.qml

To: Zren
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D15309: [Calendar] Wrap day name index around

[Chris Holland]

Zren added a comment.


  Nice thinking on using `repeater.count` instead of the hardcoded `7`!
  
  Hmm, was worried `days.count` would trigger `onCountChanged` every time a 
delegate is made (count=1, count=2, etc), but it seems that the `delegate.text` 
is only calculated twice (delegate creation and after onCountChanged=7).
  For reference, before the patch, it only calculates the `delegate.text` once. 
Using a hardcoded `7` also only calls it once, but it's bad practice to have 
magic numbers. I assume it won't reattempt to render the labels since the text 
didn't change.
  
  Thanks for doing the patch broulik.
  
qml: days.count 0
Both point size and pixel size set. Using pixel size.
qml: days.delegate.text 0 Sun
Both point size and pixel size set. Using pixel size.
qml: days.delegate.text 1 Mon
Both point size and pixel size set. Using pixel size.
qml: days.delegate.text 2 Tue
Both point size and pixel size set. Using pixel size.
qml: days.delegate.text 3 Wed
Both point size and pixel size set. Using pixel size.
qml: days.delegate.text 4 Thu
Both point size and pixel size set. Using pixel size.
qml: days.delegate.text 5 Fri
Both point size and pixel size set. Using pixel size.
qml: days.delegate.text 6 Sat
Both point size and pixel size set. Using pixel size.
qml: days.count 7
qml: days.delegate.text 0 Sun
qml: days.delegate.text 1 Mon
qml: days.delegate.text 2 Tue
qml: days.delegate.text 3 Wed
qml: days.delegate.text 4 Thu
qml: days.delegate.text 5 Fri
qml: days.delegate.text 6 Sat
  
  
  
Repeater {
id: days
onCountChanged: console.log('days.count', count)

Components.Label {
text: {
var s = 
Qt.locale(Qt.locale().uiLanguages[0]).dayName((calendarBackend.firstDayOfWeek + 
index) % 7, Locale.ShortFormat)
console.log('days.delegate.text', index, s)
return s
}

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15309

To: broulik, #plasma, Zren
Cc: safaalfulaij, kde-frameworks-devel, michaelh, ngraham, bruns

D15177: Emit signals when a package is installed/uninstalled

[Chris Holland]

Zren added a dependent revision: D12040: Add wallpaperplugin.knsrc + QML 
function to open GHNS dialog.

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D15177

To: davidedmundson, #plasma
Cc: Zren, kde-frameworks-devel, michaelh, ngraham, bruns

D12206: Don't show "Open With" for folders, as was apparently originally intended

[Chris Holland]

Zren added a comment.


  > So you're proposing that folders show the Open With... entry, but omit the 
recently added additional entry that shows the first app?
  
  Hmmm? Ah I missed D11569 . So the 
proposal is we don't show the inline "Open with Gwenview" and only show the 
"Open With > Gwenview"? Like we did before D11569 
?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12206

To: ngraham, #frameworks, rkflx
Cc: Zren, michaelh, ngraham, bruns

D12206: Don't show "Open With" for folders, as was apparently originally intended

[Chris Holland]

Zren added a comment.


  - Open with "Sublime Text" / "Atom"
  - Open with "K4DirStat"
  - Open with "Clementine"
  
  Comix, Gwenview, VLC, $MediaPlayer will usually "autoplay" the next file in a 
folder, so this won't really affect those apps.
  
  Do we really need these apps to define a context menu "Action"?  "Right click 
> Actions > Open with Sublime Text" seems weird.
  
  You also lose the ability for a user to open with any application that 
supports it, rather than just the apps that define it in their 
`share/applications/app.metadata`.
  
  - Oddly, XFCE's Thunar doesn't show an "Open with" menu.
  - Does Gnome's Nautilus not show it either?
  - Does Window's File Explorer not show it?
  - Does OS X's file manager not show it?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12206

To: ngraham, #frameworks, rkflx
Cc: Zren, michaelh, ngraham, bruns

D5971: Expose the symbolic 22px kde icon by moving it to kde-symbolic and symlinking to it

[Chris Holland]

Zren added a reviewer: Breeze.
Zren added a comment.


  Forgot to add reviewers.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D5971

To: Zren, #breeze
Cc: #frameworks, michaelh, ngraham

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

[Chris Holland]

This revision was automatically updated to reflect the committed changes.
Closed by commit R252:35656828f12c: Support downloading the 2nd or 3rd download 
link from a KNS product (authored by Zren).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D8636?vs=21841&id=22014#toc

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8636?vs=21841&id=22014

REVISION DETAIL
  https://phabricator.kde.org/D8636

AFFECTED FILES
  src/kpackage-install-handlers/kns/main.cpp

To: Zren, apol
Cc: #frameworks

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

[Chris Holland]

Zren added a comment.


  Quick note since I just notice you suggested a lowercase `i` in `?linkid=3`, 
should I change it to lowercase or stick with camelcase?

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D8636

To: Zren, apol
Cc: #frameworks

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

[Chris Holland]

Zren added a comment.


  Good idea. This will future proof us in case we ever want 
`?linkName=tiledmenu-v18-kde5.9.plasmoid` or something as well.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D8636

To: Zren, apol
Cc: #frameworks

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

[Chris Holland]

Zren updated this revision to Diff 21841.
Zren edited the summary of this revision.
Zren edited the test plan for this revision.

REPOSITORY
  R252 Framework Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8636?vs=21823&id=21841

REVISION DETAIL
  https://phabricator.kde.org/D8636

AFFECTED FILES
  src/kpackage-install-handlers/kns/main.cpp

To: Zren, apol
Cc: #frameworks

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

[Chris Holland]

Zren added a reviewer: apol.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D8636

To: Zren, apol
Cc: #frameworks

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

[Chris Holland]

Zren edited the test plan for this revision.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D8636

To: Zren
Cc: #frameworks

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

[Chris Holland]

Zren edited the test plan for this revision.

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D8636

To: Zren
Cc: #frameworks

D8636: Add support for downloading the 2nd or 3rd download link from a kde store product when fetching lookandfeel dependencies

[Chris Holland]

Zren created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Implementing the feature request in BUG #385429.
  https://bugs.kde.org/show_bug.cgi?id=385429
  
  LookAndFeels introduced the ability to set dependencies, that are downloaded 
first before installing the look and feel package.
  https://userbase.kde.org/Plasma/Create_a_Look_and_Feel_Package
  
  Eg: X-KPackage-Dependencies=kns://plasmoids.knsrc/api.kde-look.org/1160672
  
  It will call:
  
/usr/lib/x86_64-linux-gnu/libexec/kf5/kpackagehandlers/knshandler 
kns://plasmoids.knsrc/api.kde-look.org/1160672
  
  Previously this file called `engine.install(entry);`
  the second argument (`linkId`) isn't supplied so it defaults to 1.
  
void install(KNSCore::EntryInternal entry, int linkId = 1);
  
  This means it downloads the first link, which for me is the oldest version of 
the widget typically.
  
  https://api.kde-look.org/ocs/v1/content/download/1160672/1
  tells it to download tiledmenu-v05-kde5.5.plasmoid
  
  while
  https://api.kde-look.org/ocs/v1/content/download/1160672/3
  tells it to download the latest version tiledmenu-v18-kde5.9.plasmoid
  
  This patch adds the ability to specify which link to download in the 3rd path 
section.
  
  Eg: `kns://plasmoids.knsrc/api.kde-look.org/1160672/3`

TEST PLAN
  Shorten the command call for testing since knshandler isn't in `$PATH`.
  
alias 
knshandler='/usr/lib/x86_64-linux-gnu/libexec/kf5/kpackagehandlers/knshandler'
  
  
  
knshandler kns://plasmoids.knsrc/api.kde-look.org/1160672
// Installs tiledmenu-v05-kde5.5.plasmoid

knshandler kns://plasmoids.knsrc/api.kde-look.org/1160672/2
// Should error, since we didn't uninstall the previous version. Should log:
// Command ' "kpackagetool5 --install /tmp/tiledmenu-v05-kde5.5.plasmoid 
--type Plasma/Applet" ' failed with code 4

/tmp/tiledmenu-v05-kde5.5.plasmoid

knshandler kns://plasmoids.knsrc/api.kde-look.org/1160672/2
// Should error, since we didn't uninstall the previous version. Should log:
// Command ' "kpackagetool5 --install /tmp/tiledmenu-v11-kde5.6.plasmoid 
--type Plasma/Applet" ' failed with code 4

knshandler kns://plasmoids.knsrc/api.kde-look.org/1160672/3
// Should error, since we didn't uninstall the previous version. Should log:
// Command ' "kpackagetool5 --install /tmp/tiledmenu-v18-kde5.9.plasmoid 
--type Plasma/Applet" ' failed with code 4
  
  knshandler kns://plasmoids.knsrc/api.kde-look.org/1160672/3
  // Should error, since we didn't uninstall the previous version. Should log:
  // Command ' "kpackagetool5 --install /tmp/tiledmenu-v18-kde5.9.plasmoid 
--type Plasma/Applet" ' failed with code 4
  
  knshandler kns://plasmoids.knsrc/api.kde-look.org/1160672/test
  // linkId is not an integer 
QUrl("kns://plasmoids.knsrc/api.kde-look.org/1160672/test") 
("api.kde-look.org", "1160672", "test")
  
  knshandler kns://plasmoids.knsrc/api.kde-look.org/1160672/2/test
  // wrong format in the url path 
QUrl("kns://plasmoids.knsrc/api.kde-look.org/1160672/2/test") 
("api.kde-look.org", "1160672", "2", "test")
  
  knshandler kns://plasmoids.knsrc/api.kde-look.org/
  // wrong format in the url path 
QUrl("kns://plasmoids.knsrc/api.kde-look.org/") ("api.kde-look.org")

REPOSITORY
  R252 Framework Integration

REVISION DETAIL
  https://phabricator.kde.org/D8636

AFFECTED FILES
  src/kpackage-install-handlers/kns/main.cpp

To: Zren
Cc: #frameworks

D5209: Load translations from KPackage files if bundled

[Chris Holland]

Zren added a comment.


  Another note: `plasmoidviewer` is unaffected by this patch. Meaning
  
  - 
`devpath/contents/locale/fr_CA/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo`
  
  will not show translations in plasmoidviewer, but if you install to
  
  - 
`/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo`
  - 
`/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo`
  - 
`/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo`
  - 
`/usr/share/locale/fr_CA/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo`
  - 
`/usr/share/locale/fr/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo`
  
  it will work in plasmoidviewer.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5209

To: davidedmundson, #plasma, mart
Cc: ltoscano, Zren, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D5209: Load translations from KPackage files if bundled

[Chris Holland]

Zren added a comment.


  This worked
  
  - 
`~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo`
  
  These didn't work
  
  - 
`~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/LC_MESSAGES/org.kde.plasma.eventcalendar.mo`
  - 
`~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/LC_MESSAGES/org.kde.plasma.eventcalendar.po`
  - 
`~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.po`
  - 
`~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/org.kde.plasma.eventcalendar.mo`
  - 
`~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/org.kde.plasma.eventcalendar.po`
  - 
`~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/plasma_applet_org.kde.plasma.eventcalendar.po`
  - 
`~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/plasma_applet_org.kde.plasma.eventcalendar.mo`
  
  More importantly, `contents/locale/fr/*` didn't work, which means I need to 
either copy or symlink to fr_BE, fr_CA, fr_CH, fr_FR, and fr_LU.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5209

To: davidedmundson, #plasma, mart
Cc: ltoscano, Zren, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D5209: Load translations from KPackage files if bundled

[Chris Holland]

Zren added a comment.


  Oh awesome. Just found out about this. So this would be added in Frameworks 
5.37 then?
  
  Does this mean:
  
  1. 
`digitalclock.plasmoid/translations/plasma_applet_org.kde.plasma.digitalclock.po`
  2. 
`digitalclock.plasmoid/contents/translations/plasma_applet_org.kde.plasma.digitalclock.po`
  3. 
`digitalclock.plasmoid/translations/fr/LC_MESSAGES/plasma_applet_org.kde.plasma.digitalclock.po`
  4. 
`digitalclock.plasmoid/contents/translations/fr/LC_MESSAGES/plasma_applet_org.kde.plasma.digitalclock.po`
  
  So adding the domain will load `.po` files too? Or do they need to be `.mo` 
files?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D5209

To: davidedmundson, #plasma, mart
Cc: Zren, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D5971: Expose the symbolic 22px kde icon by moving it to kde-symbolic and symlinking to it

[Chris Holland]

Zren updated this revision to Diff 14841.
Zren added a comment.


  Apply to icons-dark too.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5971?vs=14840&id=14841

REVISION DETAIL
  https://phabricator.kde.org/D5971

AFFECTED FILES
  icons-dark/apps/22/kde-symbolic.svg
  icons-dark/apps/22/kde.svg
  icons/apps/22/kde-symbolic.svg
  icons/apps/22/kde.svg

To: Zren
Cc: #frameworks

D5971: Expose the symbolic 22px kde icon by moving it to kde-symbolic and symlinking to it

[Chris Holland]

Zren created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  This lets panels >23px use the symbolic icon for their launcher. Right now 
the 48px version of kde.svg has a blue rounded rectangle background.
  
  An `apps/44/kde-symbolic.svg` doesn't appear to be necessary.
  
  F3764366: 2017-05-25___09-51-39.png 
  
  Should I create a new `apps/symbolic` folder instead?
  
  I need to duplicate my work in icons-dark too don't I?

TEST PLAN
  Ran
  
cd apps/22
git mv kde.svg kde-symbolic.svg
ln -s kde-symbolic.svg kde.svg
  
  Then restarted plasmashell.
  Then chose kde-symbolic for the launcher.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D5971

AFFECTED FILES
  icons/apps/22/kde.svg
  icons/apps/symbolic/kde-symbolic.svg

To: Zren
Cc: #frameworks

Review Request 128872: Revert distribute-randomize, view-calendar + reapply the transform fix

[Chris Holland]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128872/
---

Review request for KDE Frameworks.


Bugs: 367082
https://bugs.kde.org/show_bug.cgi?id=367082


Repository: breeze-icons


Description
---

view-catalog was accidently saved as view-calendar
distribute-remove-overlaps was accidently saved as distribute-randomize


Diffs
-

  icons/actions/24/distribute-randomize.svg 392d1c0 
  icons/actions/24/view-calendar.svg 4ddeeb1 

Diff: https://git.reviewboard.kde.org/r/128872/diff/


Testing
---


Thanks,

Chris Holland