D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2020-11-24 Thread Christoph Cullmann
cullmann added a comment. Hmm, I don't think you need a theme chooser, we just need to watch for the palette change signal and then trigger again the theme name setting based on the background palette. That would be enough to detect bright/dark mode. REPOSITORY R266 Breeze Icons

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2020-10-31 Thread Christoph Cullmann
cullmann added a comment. I think exporting some namespaced function or such that will do the setting of the theme and calling it would be ok for me. This is anyways an "opt-in" approach people must decide to use. Hannah, what do you think? REPOSITORY R266 Breeze Icons REVISION DETAIL

D25339: update lineHeight if boundingRect indicates a larger value.

2020-10-10 Thread Christoph Cullmann
cullmann commandeered this revision. cullmann edited reviewers, added: xuetianweng; removed: cullmann. cullmann added a comment. I think the solution we have in current master is ok enough. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25339 To: cullmann,

D25339: update lineHeight if boundingRect indicates a larger value.

2020-10-10 Thread Christoph Cullmann
cullmann abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25339 To: cullmann, #ktexteditor, dhaumann, #frameworks, rjvbb, xuetianweng Cc: ahmadsamir, brauch, sars, pshinjo, rjvbb, fakefred, anthonyfieroni, kde-frameworks-devel, kwrite-devel,

Re: KUserFeedback => Frameworks?

2020-10-09 Thread Christoph Cullmann
On 2020-09-26 21:52, Christoph Cullmann wrote: Hi, is there any real reason why KUserFeedback is yet no official framework? I just stumbled over this during my try to add it as dependency for the Windows builds of Kate. Given at least the Plasma Desktop itself and Kate uses this now

KUserFeedback => Frameworks?

2020-09-26 Thread Christoph Cullmann
Hi, is there any real reason why KUserFeedback is yet no official framework? I just stumbled over this during my try to add it as dependency for the Windows builds of Kate. Given at least the Plasma Desktop itself and Kate uses this now, wouldn't it make sense to have it in the regular

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

2020-08-22 Thread Christoph Cullmann
autotests/src/script_test_base.cpp(153)] Can you have a look, or forward to someone who can? I think I will mark this one test just as XFAIL, as I think nobody has time to hunt when this regression went in. Greetings Christoph Cheers, David. On lundi 6 juillet 2020 16:28:27 CEST Christoph Cullma

D23410: improve word completion to use highlighting to detect word boundaries

2020-08-11 Thread Christoph Cullmann
cullmann abandoned this revision. cullmann added a comment. At the moment no idea how to fix that without regressions. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23410 To: cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack,

D24568: Provide clang-format target with a KDE Frameworks style file

2020-08-11 Thread Christoph Cullmann
cullmann closed this revision. cullmann added a comment. For my 2 wanted changes, I created a new merge request https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/20 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To:

D24826: Enforce 100 chars line width

2020-08-11 Thread Christoph Cullmann
cullmann added a comment. As said above, I think 100 is a bad idea. Can we close this? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24826 To: romangg, #frameworks, cullmann Cc: winterz, zzag, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack,

D25339: update lineHeight if boundingRect indicates a larger value.

2020-08-11 Thread Christoph Cullmann
cullmann added a comment. I think we went with the solution in https://phabricator.kde.org/D29789, could we close this? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25339 To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb Cc: ahmadsamir,

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

2020-07-11 Thread Christoph Cullmann
On 2020-07-09 10:03, Christoph Cullmann wrote: On 2020-07-08 00:07, David Faure wrote: On mardi 7 juillet 2020 17:58:26 CEST Christoph Cullmann wrote: On 2020-07-07 12:16, David Faure wrote: > Yep :( > > You'll tell Simon and/or QTBUG-*? I will take a look if I can find some exi

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

2020-07-09 Thread Christoph Cullmann
On 2020-07-08 00:07, David Faure wrote: On mardi 7 juillet 2020 17:58:26 CEST Christoph Cullmann wrote: On 2020-07-07 12:16, David Faure wrote: > Yep :( > > You'll tell Simon and/or QTBUG-*? I will take a look if I can find some existing bug or open a new. Simon left Qt, or? Yes bu

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

2020-07-07 Thread Christoph Cullmann
On 2020-07-07 12:16, David Faure wrote: Yep :( You'll tell Simon and/or QTBUG-*? I will take a look if I can find some existing bug or open a new. Simon left Qt, or? Greetings Christoph On lundi 6 juillet 2020 16:28:27 CEST Christoph Cullmann wrote: Hi, this shows again a different V4

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

2020-07-06 Thread Christoph Cullmann
Hi, this shows again a different V4 GC error :/ ==3342==ERROR: AddressSanitizer: SEGV on unknown address 0x0028 (pc 0x7f58d0bb98ec bp 0x615f8000 sp 0x7ffe976de5f0 T0) ==3342==The signal is caused by a READ memory access. ==3342==Hint: address points to the zero page. #0

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2020-06-08 Thread Christoph Cullmann
cullmann added a comment. That depends. If somebody else would test this and we can agree that this is a nicer way to hard-code breeze icons compared to having that code in kiconthemes it would make sense. REPOSITORY R266 Breeze Icons REVISION DETAIL

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

2020-06-07 Thread Christoph Cullmann
On 2020-05-25 16:34, Christoph Cullmann wrote: On 2020-05-25 16:29, David Faure wrote: Isn't this fixed by https://codereview.qt-project.org/c/qt/qtdeclarative/+/300911 ? (This fix happened because I reported this ktexteditor CI ASAN failure to Simon Haussman, who fixed qtdeclarative) IIUC

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

2020-05-25 Thread Christoph Cullmann
, too. I have at the moment here no 5.15 compile/install to test that out. Greetings Christoph Cheers, David. On samedi 23 mai 2020 15:08:28 CEST Christoph Cullmann wrote: Hi, I did a bit research, I think this might be https://bugreports.qt.io/browse/QTBUG-84363 => This makes actually Qt 5

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

2020-05-23 Thread Christoph Cullmann
Hi, I did a bit research, I think this might be https://bugreports.qt.io/browse/QTBUG-84363 => This makes actually Qt 5.14 completely unusable for KTextEditor/Kate/KWrite/. I run into this kind of crashs during normal editing, too :( I still have no 5.15 build with the fix here, will

D28235: Add a simpler example

2020-05-22 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. ;=) Actually, I just missed this request, sorry. I think there is no issue with have an extra example. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL

D29793: Rename Perl6 syntax to Raku

2020-05-18 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think it makes sense to have just "Raku", the world at large (like me) only recognizes Perl 5 as Perl .P REPOSITORY R216 Syntax Highlighting BRANCH rename-perl6-raku REVISION

D29795: Add collaboration guide

2020-05-18 Thread Christoph Cullmann
cullmann added a comment. I think this is very good thing to have. But perhaps we just should add that to the README.md that is prominently shown on e.g. https://invent.kde.org/frameworks/syntax-highlighting The README anyways already contains a "Adding unit tests for a syntax

D29789: Make text always align with font base line

2020-05-18 Thread Christoph Cullmann
cullmann closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D29789 To: xuetianweng, rjvbb, dhaumann, cullmann Cc: brauch, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, sars,

D29789: Make text always align with font base line

2020-05-18 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Hmm, looks better for me, too. Let's go with this at the moment. If it creates issues, we can still revert it again. Thanks for taking care of this. For the option: some

D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

2020-05-15 Thread Christoph Cullmann
cullmann added a comment. Sure, thanks for the improvement! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D29735 To: bewuethr, #framework_syntax_highlighting, dhaumann Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n,

D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

2020-05-15 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:f804af905ef3: Assign Identifier attribute to opening double quote instead of Comment (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D27844: Store and fetch complete view config in and from session config

2020-05-15 Thread Christoph Cullmann
cullmann added a comment. Hmm, right, didn't think about that :( Guess if we want to have this, we need to improve the read/writeConfig functions. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27844 To: kossebau, #kate, loh.tar, cullmann, dhaumann Cc:

D25339: update lineHeight if boundingRect indicates a larger value.

2020-05-09 Thread Christoph Cullmann
cullmann added a comment. F8304597: lineheight.patch see e.g. here for a start of using the right heights inside the renderer. for a dynamically wrapped line, the lines before the last one get now the right height for me. But there are a

D25339: update lineHeight if boundingRect indicates a larger value.

2020-05-09 Thread Christoph Cullmann
cullmann added a comment. In D25339#666877 , @rjvbb wrote: > > Looking at the code, might it make more sense to just move away from the fixed height we have? > > It isn't used that often and in most cases one could just query the height

D29354: Bash: fix comments after escapes

2020-05-09 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:1e8466029c82: Bash: fix comments after escapes (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D29354: Bash: fix comments after escapes

2020-05-09 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Same here ;=) Thanks a lot for the work on all this issues! REPOSITORY R216 Syntax Highlighting BRANCH fix-comments-bash REVISION DETAIL https://phabricator.kde.org/D29354 To:

D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END

2020-05-09 Thread Christoph Cullmann
cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH fix-folding-latex REVISION DETAIL https://phabricator.kde.org/D29521 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END

2020-05-09 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:0b6c88cfc167: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END

2020-05-09 Thread Christoph Cullmann
cullmann added a comment. Looks fine for me, thanks for improvement! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D29521 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack,

D25339: update lineHeight if boundingRect indicates a larger value.

2020-05-09 Thread Christoph Cullmann
cullmann added a comment. Looking at the code, might it make more sense to just move away from the fixed height we have? It isn't used that often and in most cases one could just query the height of the current line. That would solve this issue without needing any hacks for the rendering

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

2020-04-26 Thread Christoph Cullmann
cullmann added a reviewer: Frameworks. cullmann added a comment. I tried the current version. For me this looks OK now. Thought I would like to have more people trying this out before we merge. Some volunteers? Beside this: Thanks for working on this issue. REPOSITORY R39

D28870: Updated test file for Logtalk syntax highlighting

2020-04-25 Thread Christoph Cullmann
cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28870 To: pmoura, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns,

D28870: Updated test file for Logtalk syntax highlighting

2020-04-25 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:559cda73cf57: Updated test file for Logtalk syntax highlighting (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D28796: Update Logtalk language syntax support

2020-04-25 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:bf2664ea7907: Update Logtalk language syntax support (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28796?vs=80017=81172

D28796: Update Logtalk language syntax support

2020-04-25 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, I see, there is an extra request for the new hl test file. Then let's approve this one. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28796

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

2020-04-19 Thread Christoph Cullmann
cullmann added a comment. Hmm, after applying this patch, for me, no text is visible at all. By selecting a bit stuff, one at least sees an outline (CMakeLists.txt of ktexteditor toplevel dir). F8246692: kwrite_no_text.png REPOSITORY R39

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

2020-04-18 Thread Christoph Cullmann
cullmann added a comment. I appreciate work on this issue. I am not sure about how well this "hack" will solve the issue, thought. I will give it a try here in any case. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25339 To: xuetianweng, #ktexteditor,

D28814: TypeScript: add the "awaited" type operator

2020-04-15 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:1f1f03198aa7: TypeScript: add the awaited type operator (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D28814: TypeScript: add the "awaited" type operator

2020-04-15 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks ;=) Even with test. REPOSITORY R216 Syntax Highlighting BRANCH add-awaited-typescript REVISION DETAIL https://phabricator.kde.org/D28814 To: nibags,

D28796: Update Logtalk language syntax support

2020-04-15 Thread Christoph Cullmann
cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Change looks reasonable, but could that testfile be added to our autotests directory? (or the file we have there extended) The current auto test file is

D27844: Store and fetch complete view config in and from session config

2020-04-10 Thread Christoph Cullmann
cullmann added a comment. Yes, please push, thanks! REPOSITORY R39 KTextEditor BRANCH fullviewconfigsessionsupport REVISION DETAIL https://phabricator.kde.org/D27844 To: kossebau, #kate, loh.tar, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack,

D28303: LaTeX: fix math parentheses in optional labels

2020-03-26 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:213d4bb197a3: LaTeX: fix math parentheses in optional labels (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D28303: LaTeX: fix math parentheses in optional labels

2020-03-26 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for the fix + regression test! REPOSITORY R216 Syntax Highlighting BRANCH update-latex REVISION DETAIL https://phabricator.kde.org/D28303 To: nibags,

D27660: Add Inno Setup syntax, including embedded Pascal scripting

2020-03-26 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:517dccc95ecf: Add Inno Setup syntax, including embedded Pascal scripting (authored by zrax, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D27660: Add Inno Setup syntax, including embedded Pascal scripting

2020-03-26 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Cool +1 ;=) Thanks for the contribution. We use that at company, nice to have. REPOSITORY R216 Syntax Highlighting BRANCH innosetup (branched from master) REVISION DETAIL

D28045: Lua: add # as additional deliminator to activate auto-completion with `#something`

2020-03-14 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:b2ace3e804ad: Lua: add # as additional deliminator to activate auto-completion with… (authored by jpoelen, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D28045: Lua: add # as additional deliminator to activate auto-completion with `#something`

2020-03-14 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok ;=) REPOSITORY R216 Syntax Highlighting BRANCH lua (branched from master) REVISION DETAIL https://phabricator.kde.org/D28045 To: jpoelen, #framework_syntax_highlighting,

D28044: C: remove ' as digit separator

2020-03-14 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:755904a6ff2e: C: remove as digit separator (authored by jpoelen, committed by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28044?vs=77614=77615#toc REPOSITORY R216 Syntax

D28044: C: remove ' as digit separator

2020-03-14 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. True, guess I copied too large parts during my fix-up of this. REPOSITORY R216 Syntax Highlighting BRANCH c (branched from master) REVISION DETAIL

D28039: optimize dynamic regex matching

2020-03-14 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:764957b1d23c: optimize dynamic regex matching (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28039?vs=77593=77613 REVISION

D28039: optimize dynamic regex matching

2020-03-14 Thread Christoph Cullmann
cullmann added a comment. First let's have this, the current state is bad ;=) INLINE COMMENTS > dhaumann wrote in rule_p.h:126 > I dislike this protected hack :-) That is called inheritance ;=) I first had a virtual function, but this is much easier and faster. (and just costs a few bytes)

D28039: optimize dynamic regex matching

2020-03-13 Thread Christoph Cullmann
cullmann added a comment. For the example from the bug this makes the difference between ~30 seconds on a 4 Ghz machine to << 1 second ;=) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28039 To: cullmann, dhaumann, vkrause, nibags Cc: kwrite-devel,

D28039: optimize dynamic regex matching

2020-03-13 Thread Christoph Cullmann
cullmann created this revision. cullmann added reviewers: dhaumann, vkrause, nibags. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY allow such matches to be cached, too, by

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

2020-03-13 Thread Christoph Cullmann
cullmann added a comment. Better, but VHDL hl is still very slow, need to take a deeper look into it :/ REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28015 To: cullmann, nibags, dhaumann, vkrause Cc: kwrite-devel, kde-frameworks-devel, rrosch,

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

2020-03-13 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:e6090be50f0d: extend indexer to detect dynamic=true regexes that have no place holders to… (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

2020-03-13 Thread Christoph Cullmann
cullmann added a comment. Yes, I will fix the issues and then commit this as one thingy. Thanks for taking a look :=) My colleague was very unhappy with the VHDL performance :P The highlighting shouldn't take as long as a hardware simulator. REPOSITORY R216 Syntax Highlighting BRANCH

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

2020-03-12 Thread Christoph Cullmann
cullmann updated this revision to Diff 77526. cullmann added a comment. remove useless output of stray azOffset var REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28015?vs=77525=77526 BRANCH master REVISION DETAIL

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

2020-03-12 Thread Christoph Cullmann
cullmann added reviewers: nibags, dhaumann, vkrause. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28015 To: cullmann, nibags, dhaumann, vkrause Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns,

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

2020-03-12 Thread Christoph Cullmann
cullmann created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY see bug 418778 VHDL highlighting is very slow as close to all regexes are marked as dynamic

D27844: Store and fetch complete view config in and from session config

2020-03-12 Thread Christoph Cullmann
cullmann added a comment. Zoom is like all view stuff local, yes, I assume that is often not wanted. But that is a orthogonal issue. The same could be said for "dynamic word wrap", very seldom you want to set that for one view. On the other side, for the global config, one has the

D27929: CMake syntax fixes

2020-03-12 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:39ad168cf350: CMake syntax fixes (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27929?vs=77200=77524 REVISION DETAIL

D27928: [VIM Mode] Add g g commands

2020-03-12 Thread Christoph Cullmann
cullmann added a comment. And btw., thanks a lot for taking care! The vimode for sure has more need for love, if you have time ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27928 To: gikari, #kate, #frameworks, cullmann Cc: cullmann, dhaumann,

D27928: [VIM Mode] Add g g commands

2020-03-12 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:736844969d2b: [VIM Mode] Add gup gdown commands (authored by gikari, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27928?vs=77355=77523

D27928: [VIM Mode] Add g g commands

2020-03-12 Thread Christoph Cullmann
cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH g-up-g-down-commands (branched from master) REVISION DETAIL https://phabricator.kde.org/D27928 To: gikari, #kate, #frameworks, cullmann Cc: cullmann, dhaumann,

D27928: [VIM Mode] Add g g commands

2020-03-12 Thread Christoph Cullmann
cullmann added a comment. I think, one issue is, that and don't work that way in the test framework. I reformulated the test with \down and \up and moved the asserts to verifies. This works for me, will push this, please take a look if that is ok for you, too. REPOSITORY R39

D27928: [VIM Mode] Add g g commands

2020-03-11 Thread Christoph Cullmann
cullmann added a comment. I will try to take a look as soon as I have time, if nobody else is faster. Just to confirm: Your newly added test case doesn't pass or some other test case randomly fails? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27928 To:

D27912: Draw inlineNotes after drawing word wrap marker

2020-03-07 Thread Christoph Cullmann
cullmann closed this revision. cullmann added a comment. Hmm, yes, seems to work again. Let's close this then again. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27912 To: davidre, #ktexteditor, brauch Cc: cullmann, brauch, kwrite-devel,

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 313 - Unstable!

2020-03-07 Thread Christoph Cullmann
Hi, think the change https://phabricator.kde.org/D27912 is responsible for this, re-opened that request again. Greetings Christoph On 2020-03-07 16:53, CI System wrote: BUILD UNSTABLE Build URL

D27912: Draw inlineNotes after drawing word wrap marker

2020-03-07 Thread Christoph Cullmann
cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Hi, could it be that killed the inline notes autotest? https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/313/ REPOSITORY R39 KTextEditor REVISION

D27533: Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

2020-03-07 Thread Christoph Cullmann
cullmann added a comment. Thanks for working on this. Badly scaled stuff is a real eyesore... REPOSITORY R39 KTextEditor BRANCH addmarkinterfacev2 REVISION DETAIL https://phabricator.kde.org/D27533 To: kossebau, #kate, #kdevelop, dhaumann, cullmann Cc: cullmann, anthonyfieroni,

D27893: Use fallback also on Windows not only mac

2020-03-07 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R289:1b93a366da68: Use fallback also on Windows not only mac (authored by vonreth, committed by cullmann). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D27893: Use fallback also on Windows not only mac

2020-03-07 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. Ok, let's have that be in ;=) REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D27893 To: vonreth, broulik, bcooksley, jjazeix, cullmann Cc: kde-frameworks-devel, LeGast00n, cblack,

D27797: Agda: keywords updated to 2.6.0 and fix float points

2020-03-07 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:6903aff4ef92: Agda: keywords updated to 2.6.0 and fix float points (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D27797: Agda: keywords updated to 2.6.0 and fix float points

2020-03-07 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for taking care of this! Let's get that in. REPOSITORY R216 Syntax Highlighting BRANCH update-agda REVISION DETAIL https://phabricator.kde.org/D27797 To: nibags,

D27844: Store and fetch complete view config in and from session config

2020-03-07 Thread Christoph Cullmann
cullmann accepted this revision as: cullmann. cullmann added a comment. This revision is now accepted and ready to land. Hmm, actually not sure why we didn't do that before. I think this change makes sense. Perhaps Dominik has some idea why we didn't do that in the past? I myself think

D27430: [PATCH] General update for CartoCSS syntax highlighting

2020-03-02 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:c13aa9c31167: [PATCH] General update for CartoCSS syntax highlighting (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27430?vs=75757=76793#toc REPOSITORY R216 Syntax

D26211: Port QRegExp to QRegularExpression

2020-03-01 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks, guess that should go in now. REPOSITORY R246 Sonnet BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26211 To:

D26211: Port QRegExp to QRegularExpression

2020-02-29 Thread Christoph Cullmann
cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Actually, one can re-use this regex for all files by moving it before the scope of the loop, or? The match on the other side is allocated per match() call, I would just move

D27693: Add syntax highlighting for Java Properties

2020-02-29 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for this addition and the MIT licensing! REPOSITORY R216 Syntax Highlighting BRANCH add-java-properties REVISION DETAIL https://phabricator.kde.org/D27693 To: nibags,

D27692: TypeScript: add private fields and type-only imports/exports, and some fixes

2020-02-29 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:0daf938b0660: TypeScript: add private fields and type-only imports/exports, and some fixes (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST

D27693: Add syntax highlighting for Java Properties

2020-02-29 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:4a0a0e56cd86: Add syntax highlighting for Java Properties (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D27692: TypeScript: add private fields and type-only imports/exports, and some fixes

2020-02-29 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, let's merge this. Thanks for all the work on that! REPOSITORY R216 Syntax Highlighting BRANCH update-typescript REVISION DETAIL https://phabricator.kde.org/D27692 To:

D27430: [PATCH] General update for CartoCSS syntax highlighting

2020-02-28 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, let's land that. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D27430 To: sommer, #framework_syntax_highlighting, cullmann Cc: cullmann,

D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

2020-02-28 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. I think this should go in now. I think the usage of the API is correct even for HiDPI. In KF6, we should just fold that interface into the main class. REPOSITORY R39 KTextEditor BRANCH addmarkinterfacev2 REVISION DETAIL

D27486: Add FreeCAD FCMacro extension to the python highlighting definition

2020-02-28 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:978e23b2c44c: Add FreeCAD FCMacro extension to the python highlighting definition (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27486?vs=75942=76647#toc REPOSITORY

D27486: Add FreeCAD FCMacro extension to the python highlighting definition

2020-02-28 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, makes sense, will increase version myself. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D27486 To: martonmiklos,

D27580: Updates for CMake 3.17

2020-02-28 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:fb8e0b2777a2: Updates for CMake 3.17 (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27580?vs=76182=76646 REVISION DETAIL

D27580: Updates for CMake 3.17

2020-02-28 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for the update! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D27580 To: turbov, #framework_syntax_highlighting, cullmann Cc: cullmann,

D27714: C++: constinit keyword and std::format syntax for strings. Improvement printf format.

2020-02-28 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:c41ed480a504: C++: constinit keyword and std::format syntax for strings. Improvement printf… (authored by jpoelen, committed by cullmann). CHANGED PRIOR TO COMMIT

D27714: C++: constinit keyword and std::format syntax for strings. Improvement printf format.

2020-02-28 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Nice! Thanks for the improvements ;=) REPOSITORY R216 Syntax Highlighting BRANCH cpp (branched from master) REVISION DETAIL https://phabricator.kde.org/D27714 To: jpoelen,

D27512: README.md: fix example code & code markup

2020-02-19 Thread Christoph Cullmann
cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH fixreadme REVISION DETAIL https://phabricator.kde.org/D27512 To: kossebau, #kate, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson,

D27430: [PATCH] General update for CartoCSS syntax highlighting

2020-02-16 Thread Christoph Cullmann
cullmann added a comment. Hi, nice that you keep working on this and upstream your stuff ;=) Could you provide some test file for this? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D27430 To: sommer, #framework_syntax_highlighting Cc: cullmann,

D27332: try to fix issue with ispellchecker on windows

2020-02-13 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R246:6e2f32b931e3: fix segfault at exit (authored by cullmann). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27332?vs=75536=75646 REVISION DETAIL

D27343: Makefile highlight: fix variable names in "else" conditionals

2020-02-12 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:86e132a3a829: Makefile highlight: fix variable names in else conditionals (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D27343: Makefile highlight: fix variable names in "else" conditionals

2020-02-12 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for the fix! REPOSITORY R216 Syntax Highlighting BRANCH fix-makefile REVISION DETAIL https://phabricator.kde.org/D27343 To: nibags, #framework_syntax_highlighting,

  1   2   3   4   5   6   7   8   9   10   >