Re: portings aids in kf6?

On 2023-01-25 16:56, Jonathan Riddell wrote: Can the team say which, if any, porting aids will continue in kf6? KDELibs4Support KDesignerPlugin KDEWebKit KHtml KJS KJsEmbed KMediaPlayer Kross KXmlRpcClient I would assume none of them that are marked as deprecated: true in the metainfo.yaml

Re: KF5 branches

On 2023-01-08 00:00, David Edmundson wrote: There is now a "kf5" branch in all frameworks repos as discussed last frameworks meeting. Starting now any commits that are also wanted in the next KF5 should be cherry-picked after landing. This does *not* mean master is fully open for going into KF6

Re: Please fix failing unit tests with Windows platform

On 2022-01-24 01:32, Friedrich W. H. Kossebau wrote: Am Montag, 24. Januar 2022, 01:22:05 CET schrieb Albert Astals Cid: Are you going to propose the same for Linux and FreeBSD where we also have long running tests that don't succeed and no one bothers to fix them? Yes, if a test is known to

Re: Gitlab CI for Windows

On 2022-01-04 20:23, Ben Cooksley wrote: On Wed, Jan 5, 2022 at 6:36 AM Christoph Cullmann (cullmann.io [1]) wrote: On 2022-01-04 18:24, Ben Cooksley wrote: Hi all, Next update in this saga appears to be a defect in KDeclarative, which apparently has a hard dependency on KGlobalAccel

Re: Gitlab CI - Inbound

On 2021-09-06 11:48, Ben Cooksley wrote: On Mon, Sep 6, 2021 at 9:00 PM Tom Zander wrote: On zondag 5 september 2021 08:13:09 CEST Ben Cooksley wrote: In terms of the format of the 'Dependencies' section, Playing with kde-build script and noticing the fast growing dependency trees we have t

Raising required Qt version to 5.15.2

Hi, at the moment we require Qt 5.15.0 in Frameworks. .2 introduced some new API functions for e.g. QStringView and some merge requests are blocked due to that: https://invent.kde.org/pim/kpimtextedit/-/merge_requests/11 Would it make sense to raise the bar to 5.15.2 for Frameworks? Beside th

Re: Re KIO workers

On 2021-06-05 21:07, Kevin Ottens wrote: Hello, On Saturday, 5 June 2021 17:51:18 CEST David Faure wrote: On samedi 5 juin 2021 16:29:10 CEST Volker Krause wrote: > Do KIO slaves still need the klauncher/kinit loading mechanism? No. My request for developers to test KIO_FORK_SLAVES=1 for daily

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.15 - Build # 291 - Unstable!

Hi, On 2021-04-05 21:40, Adriaan de Groot wrote: On Monday, 5 April 2021 19:20:08 CEST Ben Cooksley wrote: On Tue, Apr 6, 2021 at 3:33 AM Christoph Cullmann > I reverted my test commit to see if we have still some unpatched 5.15 > with a broken QJSEngine around again. > > Still

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.15 - Build # 291 - Unstable!

Hi, see below build error. I reverted my test commit to see if we have still some unpatched 5.15 with a broken QJSEngine around again. Still, I think it would be great if one could have some patched version in the CI. Could one update there the Qt installation to the latest available patch

Re: Requiring Qt 5.15 for KDE Frameworks 5?

On 2021-03-27 18:09, David Faure wrote: I think we need to be more specific and say what is the minimum compiler version. Maybe we can set g++8 as the minimum and use C++17 language features while avoiding std::filesystem. But only if someone actually cares about keeping gcc8 support :) I'm p

Re: Should syntax-higlighting get 5.79.1 released with the control flow color fix?

On 2021-02-15 23:27, Albert Astals Cid wrote: Hi all, Should we do a new release of syntax-highlighting with 341b6e8c64d1fa8df16fe9c65e185cea3c6a7901 ? 5.79.0 missed it by minutes and given 7a2260a9933cd9838e7dc8ae30c3def2173ba166 was not in any release either, i think it'd make sense to get 5.

Re: Need xcb/xkb help for severe kglobalaccel_x11 issue

On 2021-02-06 10:08, David Faure wrote: Problem mostly fixed by https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/339 but still seeing 15 notifications instead of 1 (already better than 145...). Indeed a single call to /usr/bin/setxkbmap -layout us,fr -option -option compose:caps s

Re: KDE Frameworks 6 - Virtual Sprint setup

On 2021-01-30 12:14, Volker Krause wrote: On Freitag, 29. Januar 2021 15:57:59 CET Adam Szopa wrote: Hello, I've been talking with David Faure about setting up a Sprint focused on KF6 work. Some of the topics would include: - Reviewing the KF6 board (https://phabricator.kde.org/project/board/3

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann abandoned this revision. cullmann added a comment. I have now a working version that handles palette changes, too. https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/79 + usage in Kate https://invent.kde.org/utilities/kate/-/merge_requests/204 We should

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. I need to finalize this, people start to complain more and more about this missing on Windows for Kate/etc... ;( REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25119 To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, ale

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. Hmm, I don't think you need a theme chooser, we just need to watch for the palette change signal and then trigger again the theme name setting based on the background palette. That would be enough to detect bright/dark mode. REPOSITORY R266 Breeze Icons REVISIO

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. I think exporting some namespaced function or such that will do the setting of the theme and calling it would be ok for me. This is anyways an "opt-in" approach people must decide to use. Hannah, what do you think? REPOSITORY R266 Breeze Icons REVISION DETAIL

D25339: update lineHeight if boundingRect indicates a larger value.

cullmann commandeered this revision. cullmann edited reviewers, added: xuetianweng; removed: cullmann. cullmann added a comment. I think the solution we have in current master is ok enough. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25339 To: cullmann, #ktext

D25339: update lineHeight if boundingRect indicates a larger value.

cullmann abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25339 To: cullmann, #ktexteditor, dhaumann, #frameworks, rjvbb, xuetianweng Cc: ahmadsamir, brauch, sars, pshinjo, rjvbb, fakefred, anthonyfieroni, kde-frameworks-devel, kwrite-devel, r

Re: KUserFeedback => Frameworks?

On 2020-09-26 21:52, Christoph Cullmann wrote: Hi, is there any real reason why KUserFeedback is yet no official framework? I just stumbled over this during my try to add it as dependency for the Windows builds of Kate. Given at least the Plasma Desktop itself and Kate uses this now

KUserFeedback => Frameworks?

Hi, is there any real reason why KUserFeedback is yet no official framework? I just stumbled over this during my try to add it as dependency for the Windows builds of Kate. Given at least the Plasma Desktop itself and Kate uses this now, wouldn't it make sense to have it in the regular relea

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

exteditor/autotests/src/script_test_base.cpp(153)] Can you have a look, or forward to someone who can? I think I will mark this one test just as XFAIL, as I think nobody has time to hunt when this regression went in. Greetings Christoph Cheers, David. On lundi 6 juillet 2020 16:28:27 CEST Christoph Cul

D23410: improve word completion to use highlighting to detect word boundaries

cullmann abandoned this revision. cullmann added a comment. At the moment no idea how to fix that without regressions. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D23410 To: cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, d

D24568: Provide clang-format target with a KDE Frameworks style file

cullmann closed this revision. cullmann added a comment. For my 2 wanted changes, I created a new merge request https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/20 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann,

D24826: Enforce 100 chars line width

cullmann added a comment. As said above, I think 100 is a bad idea. Can we close this? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24826 To: romangg, #frameworks, cullmann Cc: winterz, zzag, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, b

D25339: update lineHeight if boundingRect indicates a larger value.

cullmann added a comment. I think we went with the solution in https://phabricator.kde.org/D29789, could we close this? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25339 To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb Cc: ahmadsamir, bra

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

On 2020-07-09 10:03, Christoph Cullmann wrote: On 2020-07-08 00:07, David Faure wrote: On mardi 7 juillet 2020 17:58:26 CEST Christoph Cullmann wrote: On 2020-07-07 12:16, David Faure wrote: > Yep :( > > You'll tell Simon and/or QTBUG-*? I will take a look if I can find some e

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

On 2020-07-08 00:07, David Faure wrote: On mardi 7 juillet 2020 17:58:26 CEST Christoph Cullmann wrote: On 2020-07-07 12:16, David Faure wrote: > Yep :( > > You'll tell Simon and/or QTBUG-*? I will take a look if I can find some existing bug or open a new. Simon left Qt, or? Y

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

On 2020-07-07 12:16, David Faure wrote: Yep :( You'll tell Simon and/or QTBUG-*? I will take a look if I can find some existing bug or open a new. Simon left Qt, or? Greetings Christoph On lundi 6 juillet 2020 16:28:27 CEST Christoph Cullmann wrote: Hi, this shows again a differe

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

Hi, this shows again a different V4 GC error :/ ==3342==ERROR: AddressSanitizer: SEGV on unknown address 0x0028 (pc 0x7f58d0bb98ec bp 0x615f8000 sp 0x7ffe976de5f0 T0) ==3342==The signal is caused by a READ memory access. ==3342==Hint: address points to the zero page. #0 0x7f58d

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

cullmann added a comment. That depends. If somebody else would test this and we can agree that this is a nicer way to hard-code breeze icons compared to having that code in kiconthemes it would make sense. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25119

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

On 2020-05-25 16:34, Christoph Cullmann wrote: On 2020-05-25 16:29, David Faure wrote: Isn't this fixed by https://codereview.qt-project.org/c/qt/qtdeclarative/+/300911 ? (This fix happened because I reported this ktexteditor CI ASAN failure to Simon Haussman, who fixed qtdeclarative)

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

n our bugs, too. I have at the moment here no 5.15 compile/install to test that out. Greetings Christoph Cheers, David. On samedi 23 mai 2020 15:08:28 CEST Christoph Cullmann wrote: Hi, I did a bit research, I think this might be https://bugreports.qt.io/browse/QTBUG-84363 => This makes act

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

Hi, I did a bit research, I think this might be https://bugreports.qt.io/browse/QTBUG-84363 => This makes actually Qt 5.14 completely unusable for KTextEditor/Kate/KWrite/. I run into this kind of crashs during normal editing, too :( I still have no 5.15 build with the fix here, will ne

D28235: Add a simpler example

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. ;=) Actually, I just missed this request, sorry. I think there is no issue with have an extra example. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL http

D29793: Rename Perl6 syntax to Raku

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. I think it makes sense to have just "Raku", the world at large (like me) only recognizes Perl 5 as Perl .P REPOSITORY R216 Syntax Highlighting BRANCH rename-perl6-raku REVISION DE

D29795: Add collaboration guide

cullmann added a comment. I think this is very good thing to have. But perhaps we just should add that to the README.md that is prominently shown on e.g. https://invent.kde.org/frameworks/syntax-highlighting The README anyways already contains a "Adding unit tests for a syntax definition"

D29789: Make text always align with font base line

cullmann closed this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D29789 To: xuetianweng, rjvbb, dhaumann, cullmann Cc: brauch, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhau

D29789: Make text always align with font base line

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Hmm, looks better for me, too. Let's go with this at the moment. If it creates issues, we can still revert it again. Thanks for taking care of this. For the option: some option

D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

cullmann added a comment. Sure, thanks for the improvement! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D29735 To: bewuethr, #framework_syntax_highlighting, dhaumann Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack

D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

This revision was automatically updated to reflect the committed changes. Closed by commit R216:f804af905ef3: Assign "Identifier" attribute to opening double quote instead of "Comment" (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.k

D27844: Store and fetch complete view config in and from session config

cullmann added a comment. Hmm, right, didn't think about that :( Guess if we want to have this, we need to improve the read/writeConfig functions. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27844 To: kossebau, #kate, loh.tar, cullmann, dhaumann Cc: kwrite-

D25339: update lineHeight if boundingRect indicates a larger value.

cullmann added a comment. F8304597: lineheight.patch see e.g. here for a start of using the right heights inside the renderer. for a dynamically wrapped line, the lines before the last one get now the right height for me. But there are a lo

D25339: update lineHeight if boundingRect indicates a larger value.

cullmann added a comment. In D25339#666877 , @rjvbb wrote: > > Looking at the code, might it make more sense to just move away from the fixed height we have? > > It isn't used that often and in most cases one could just query the height of

D29354: Bash: fix comments after escapes

This revision was automatically updated to reflect the committed changes. Closed by commit R216:1e8466029c82: Bash: fix comments after escapes (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29354?vs=8171

D29354: Bash: fix comments after escapes

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Same here ;=) Thanks a lot for the work on all this issues! REPOSITORY R216 Syntax Highlighting BRANCH fix-comments-bash REVISION DETAIL https://phabricator.kde.org/D29354 To: n

D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH fix-folding-latex REVISION DETAIL https://phabricator.kde.org/D29521 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks

D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END

This revision was automatically updated to reflect the committed changes. Closed by commit R216:0b6c88cfc167: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://ph

D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END

cullmann added a comment. Looks fine for me, thanks for improvement! REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D29521 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, do

D25339: update lineHeight if boundingRect indicates a larger value.

cullmann added a comment. Looking at the code, might it make more sense to just move away from the fixed height we have? It isn't used that often and in most cases one could just query the height of the current line. That would solve this issue without needing any hacks for the rendering

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

cullmann added a reviewer: Frameworks. cullmann added a comment. I tried the current version. For me this looks OK now. Thought I would like to have more people trying this out before we merge. Some volunteers? Beside this: Thanks for working on this issue. REPOSITORY R39 KTextEdi

D28870: Updated test file for Logtalk syntax highlighting

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28870 To: pmoura, cullmann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, ngraham, bruns,

D28870: Updated test file for Logtalk syntax highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit R216:559cda73cf57: Updated test file for Logtalk syntax highlighting (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28870?vs=80253&id

D28796: Update Logtalk language syntax support

This revision was automatically updated to reflect the committed changes. Closed by commit R216:bf2664ea7907: Update Logtalk language syntax support (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28796?vs=80017&id=81172 REV

D28796: Update Logtalk language syntax support

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, I see, there is an extra request for the new hl test file. Then let's approve this one. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28796

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

cullmann added a comment. Hmm, after applying this patch, for me, no text is visible at all. By selecting a bit stuff, one at least sees an outline (CMakeLists.txt of ktexteditor toplevel dir). F8246692: kwrite_no_text.png REPOSITORY R39 KTextEd

D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

cullmann added a comment. I appreciate work on this issue. I am not sure about how well this "hack" will solve the issue, thought. I will give it a try here in any case. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D25339 To: xuetianweng, #ktexteditor, cullm

D28814: TypeScript: add the "awaited" type operator

This revision was automatically updated to reflect the committed changes. Closed by commit R216:1f1f03198aa7: TypeScript: add the "awaited" type operator (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28

D28814: TypeScript: add the "awaited" type operator

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks ;=) Even with test. REPOSITORY R216 Syntax Highlighting BRANCH add-awaited-typescript REVISION DETAIL https://phabricator.kde.org/D28814 To: nibags, #framework_syntax_hig

D28796: Update Logtalk language syntax support

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Change looks reasonable, but could that testfile be added to our autotests directory? (or the file we have there extended) The current auto test file is autotests/input/highl

D27844: Store and fetch complete view config in and from session config

cullmann added a comment. Yes, please push, thanks! REPOSITORY R39 KTextEditor BRANCH fullviewconfigsessionsupport REVISION DETAIL https://phabricator.kde.org/D27844 To: kossebau, #kate, loh.tar, cullmann, dhaumann Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_

D28303: LaTeX: fix math parentheses in optional labels

This revision was automatically updated to reflect the committed changes. Closed by commit R216:213d4bb197a3: LaTeX: fix math parentheses in optional labels (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D28303: LaTeX: fix math parentheses in optional labels

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for the fix + regression test! REPOSITORY R216 Syntax Highlighting BRANCH update-latex REVISION DETAIL https://phabricator.kde.org/D28303 To: nibags, #framework_syntax_hi

D27660: Add Inno Setup syntax, including embedded Pascal scripting

This revision was automatically updated to reflect the committed changes. Closed by commit R216:517dccc95ecf: Add Inno Setup syntax, including embedded Pascal scripting (authored by zrax, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricato

D27660: Add Inno Setup syntax, including embedded Pascal scripting

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Cool +1 ;=) Thanks for the contribution. We use that at company, nice to have. REPOSITORY R216 Syntax Highlighting BRANCH innosetup (branched from master) REVISION DETAIL htt

D28045: Lua: add # as additional deliminator to activate auto-completion with `#something`

This revision was automatically updated to reflect the committed changes. Closed by commit R216:b2ace3e804ad: Lua: add # as additional deliminator to activate auto-completion with… (authored by jpoelen, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE htt

D28045: Lua: add # as additional deliminator to activate auto-completion with `#something`

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok ;=) REPOSITORY R216 Syntax Highlighting BRANCH lua (branched from master) REVISION DETAIL https://phabricator.kde.org/D28045 To: jpoelen, #framework_syntax_highlighting, dhau

D28044: C: remove ' as digit separator

This revision was automatically updated to reflect the committed changes. Closed by commit R216:755904a6ff2e: C: remove ' as digit separator (authored by jpoelen, committed by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28044?vs=77614&id=77615#toc REPOSITORY R216 Syntax H

D28044: C: remove ' as digit separator

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. True, guess I copied too large parts during my fix-up of this. REPOSITORY R216 Syntax Highlighting BRANCH c (branched from master) REVISION DETAIL https://phabricator.kde.org/D28

D28039: optimize dynamic regex matching

This revision was automatically updated to reflect the committed changes. Closed by commit R216:764957b1d23c: optimize dynamic regex matching (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28039?vs=77593&id=77613 REVISION D

D28039: optimize dynamic regex matching

cullmann added a comment. First let's have this, the current state is bad ;=) INLINE COMMENTS > dhaumann wrote in rule_p.h:126 > I dislike this protected hack :-) That is called inheritance ;=) I first had a virtual function, but this is much easier and faster. (and just costs a few bytes)

D28039: optimize dynamic regex matching

cullmann added a comment. For the example from the bug this makes the difference between ~30 seconds on a 4 Ghz machine to << 1 second ;=) REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28039 To: cullmann, dhaumann, vkrause, nibags Cc: kwrite-devel, kde

D28039: optimize dynamic regex matching

cullmann created this revision. cullmann added reviewers: dhaumann, vkrause, nibags. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY allow such matches to be cached, too, by guardi

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

cullmann added a comment. Better, but VHDL hl is still very slow, need to take a deeper look into it :/ REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28015 To: cullmann, nibags, dhaumann, vkrause Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

This revision was automatically updated to reflect the committed changes. Closed by commit R216:e6090be50f0d: extend indexer to detect dynamic=true regexes that have no place holders to… (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

cullmann added a comment. Yes, I will fix the issues and then commit this as one thingy. Thanks for taking a look :=) My colleague was very unhappy with the VHDL performance :P The highlighting shouldn't take as long as a hardware simulator. REPOSITORY R216 Syntax Highlighting BRANCH

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

cullmann updated this revision to Diff 77526. cullmann added a comment. remove useless output of stray azOffset var REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28015?vs=77525&id=77526 BRANCH master REVISION DETAIL https://phabricator.kd

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

cullmann added reviewers: nibags, dhaumann, vkrause. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D28015 To: cullmann, nibags, dhaumann, vkrause Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, dems

D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

cullmann created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. cullmann requested review of this revision. REVISION SUMMARY see bug 418778 VHDL highlighting is very slow as close to all regexes are marked as dynamic b

D27844: Store and fetch complete view config in and from session config

cullmann added a comment. Zoom is like all view stuff local, yes, I assume that is often not wanted. But that is a orthogonal issue. The same could be said for "dynamic word wrap", very seldom you want to set that for one view. On the other side, for the global config, one has the settin

D27929: CMake syntax fixes

This revision was automatically updated to reflect the committed changes. Closed by commit R216:39ad168cf350: CMake syntax fixes (authored by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27929?vs=77200&id=77524 REVISION DETAIL https:

D27928: [VIM Mode] Add g g commands

cullmann added a comment. And btw., thanks a lot for taking care! The vimode for sure has more need for love, if you have time ;=) REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27928 To: gikari, #kate, #frameworks, cullmann Cc: cullmann, dhaumann, kwrite-devel

D27928: [VIM Mode] Add g g commands

This revision was automatically updated to reflect the committed changes. Closed by commit R39:736844969d2b: [VIM Mode] Add g g commands (authored by gikari, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27928?vs=77355&id=

D27928: [VIM Mode] Add g g commands

cullmann added a comment. I think, one issue is, that and don't work that way in the test framework. I reformulated the test with \down and \up and moved the asserts to verifies. This works for me, will push this, please take a look if that is ok for you, too. REPOSITORY R39 KTextEdi

D27928: [VIM Mode] Add g g commands

cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH g-up-g-down-commands (branched from master) REVISION DETAIL https://phabricator.kde.org/D27928 To: gikari, #kate, #frameworks, cullmann Cc: cullmann, dhaumann, kwrite-devel,

D27928: [VIM Mode] Add g g commands

cullmann added a comment. I will try to take a look as soon as I have time, if nobody else is faster. Just to confirm: Your newly added test case doesn't pass or some other test case randomly fails? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27928 To: gika

D27912: Draw inlineNotes after drawing word wrap marker

cullmann closed this revision. cullmann added a comment. Hmm, yes, seems to work again. Let's close this then again. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27912 To: davidre, #ktexteditor, brauch Cc: cullmann, brauch, kwrite-devel, kde-frameworks-devel,

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 313 - Unstable!

Hi, think the change https://phabricator.kde.org/D27912 is responsible for this, re-opened that request again. Greetings Christoph On 2020-03-07 16:53, CI System wrote: BUILD UNSTABLE Build URL https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt

D27912: Draw inlineNotes after drawing word wrap marker

cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Hi, could it be that killed the inline notes autotest? https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/313/ REPOSITORY R39 KTextEditor REVISION DET

D27533: Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

cullmann added a comment. Thanks for working on this. Badly scaled stuff is a real eyesore... REPOSITORY R39 KTextEditor BRANCH addmarkinterfacev2 REVISION DETAIL https://phabricator.kde.org/D27533 To: kossebau, #kate, #kdevelop, dhaumann, cullmann Cc: cullmann, anthonyfieroni, dhau

D27893: Use fallback also on Windows not only mac

This revision was automatically updated to reflect the committed changes. Closed by commit R289:1b93a366da68: Use fallback also on Windows not only mac (authored by vonreth, committed by cullmann). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27893?vs

D27893: Use fallback also on Windows not only mac

cullmann accepted this revision. cullmann added a comment. Ok, let's have that be in ;=) REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D27893 To: vonreth, broulik, bcooksley, jjazeix, cullmann Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2

D27797: Agda: keywords updated to 2.6.0 and fix float points

This revision was automatically updated to reflect the committed changes. Closed by commit R216:6903aff4ef92: Agda: keywords updated to 2.6.0 and fix float points (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kd

D27797: Agda: keywords updated to 2.6.0 and fix float points

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for taking care of this! Let's get that in. REPOSITORY R216 Syntax Highlighting BRANCH update-agda REVISION DETAIL https://phabricator.kde.org/D27797 To: nibags, #frame

D27844: Store and fetch complete view config in and from session config

cullmann accepted this revision as: cullmann. cullmann added a comment. This revision is now accepted and ready to land. Hmm, actually not sure why we didn't do that before. I think this change makes sense. Perhaps Dominik has some idea why we didn't do that in the past? I myself think th

D27430: [PATCH] General update for CartoCSS syntax highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit R216:c13aa9c31167: [PATCH] General update for CartoCSS syntax highlighting (authored by cullmann). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27430?vs=75757&id=76793#toc REPOSITORY R216 Synta

D26211: Port QRegExp to QRegularExpression

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks, guess that should go in now. REPOSITORY R246 Sonnet BRANCH l-qregularexpression (branched from master) REVISION DETAIL https://phabricator.kde.org/D26211 To: ahmadsamir,

D26211: Port QRegExp to QRegularExpression

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Actually, one can re-use this regex for all files by moving it before the scope of the loop, or? The match on the other side is allocated per match() call, I would just move

D27693: Add syntax highlighting for Java Properties

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for this addition and the MIT licensing! REPOSITORY R216 Syntax Highlighting BRANCH add-java-properties REVISION DETAIL https://phabricator.kde.org/D27693 To: nibags, #fr

D27692: TypeScript: add private fields and type-only imports/exports, and some fixes

This revision was automatically updated to reflect the committed changes. Closed by commit R216:0daf938b0660: TypeScript: add private fields and type-only imports/exports, and some fixes (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

  1   2   3   4   5   6   7   8   9   10   >