D25328: Always rehiglhight() after definition was changed

2019-11-16 Thread Christoph Cullmann
cullmann added a comment. Hmm, I am not sure this doesn't regress cases that rely on setDefinition being "cheap" for the nop case. Is there no other way to trigger re-highlight for the wanted case? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D25328

D25244: Implement ISpellChecker backend for Windows >= 8

2019-11-16 Thread Christoph Cullmann
cullmann added a comment. Then we can merge this, or? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25244 To: cullmann, #frameworks, vonreth Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25244: Implement ISpellChecker backend for Windows >= 8

2019-11-15 Thread Christoph Cullmann
cullmann added a comment. Ok, thank you! REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25244 To: cullmann, #frameworks, vonreth Cc: mludwig, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25244: Implement ISpellChecker backend for Windows >= 8

2019-11-15 Thread Christoph Cullmann
cullmann added a comment. Some feedback? Else I would just try that. For me it worked fine (obviously). REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25244 To: cullmann, #frameworks, vonreth Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25244: Implement ISpellChecker backend for Windows >= 8

2019-11-10 Thread Christoph Cullmann
cullmann added reviewers: Frameworks, vonreth. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25244 To: cullmann, #frameworks, vonreth Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25244: Implement ISpellChecker backend for Windows >= 8

2019-11-10 Thread Christoph Cullmann
cullmann created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY Provide ISpellChecker backend for Sonnet on Windows This avoids to ship all the hunspell dictionaries for Windows.

D25143: Basic cross-compiling support for parsetrigrams

2019-11-05 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R246:1ada4bec82ea: Basic cross-compiling support for parsetrigrams (authored by vkrause, committed by cullmann). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE

D25139: LaTeX: fix backslash delimiter in some keywords

2019-11-04 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. New result looks better, true! REPOSITORY R216 Syntax Highlighting BRANCH latex-keys-del REVISION DETAIL https://phabricator.kde.org/D25139 To: nibags,

D25122: embedd trigrams.map into shared library

2019-11-04 Thread Christoph Cullmann
cullmann closed this revision. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25122 To: cullmann, dfaure, vonreth, #frameworks, vkrause Cc: nicolasfella, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25122: embedd trigrams.map into shared library

2019-11-04 Thread Christoph Cullmann
cullmann requested review of this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok, then first close this. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25122 To: cullmann, dfaure, vonreth, #frameworks, vkrause Cc:

D25143: Basic cross-compiling support for parsetrigrams

2019-11-04 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks a bit more like the stuff in syntax-highlighting, guess we should try this. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D25143 To:

D25122: embedd trigrams.map into shared library

2019-11-04 Thread Christoph Cullmann
cullmann added a comment. Given I did break it, sorry for the issue at all ;=) But still, the fix is not that nice, not trigrams there at all, like before :/ REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25122 To: cullmann, dfaure, vonreth, #frameworks, vkrause

D25122: embedd trigrams.map into shared library

2019-11-03 Thread Christoph Cullmann
cullmann added a comment. I re-scheduled the build, seems to work for me now. @vkrause : have you some solution to run the trigrams stuff for cross compiles, too? REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25122 To: cullmann, dfaure, vonreth, #frameworks,

D25122: embedd trigrams.map into shared library

2019-11-03 Thread Christoph Cullmann
cullmann added a comment. Fix see https://commits.kde.org/sonnet/be0414de6b921a1b926ea5e6c75ea3df02240379 REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25122 To: cullmann, dfaure, vonreth, #frameworks, vkrause Cc: nicolasfella, kde-frameworks-devel, LeGast00n,

D25122: embedd trigrams.map into shared library

2019-11-03 Thread Christoph Cullmann
cullmann planned changes to this revision. cullmann added a comment. Ok, I see. For cross-compiling the trigrams were never generated... I don't think this is a good idea, but I can guard the resource creation with the same code. Volker: You are more familiar with the Android stuff,

D25122: embedd trigrams.map into shared library

2019-11-03 Thread Christoph Cullmann
cullmann reopened this revision. cullmann added a comment. This revision is now accepted and ready to land. Is that because I moved the target to the other cmake file? The generation process should be unchanged. REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25122

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2019-11-03 Thread Christoph Cullmann
cullmann added a comment. As soon as we use the rcc file for the icons, we set an icon theme name. If you have an icon theme name set, QIcon::fromTheme will do: bool hasUserTheme = QIconLoader::instance()->hasUserTheme(); QIconEngine * const engine = (platformTheme &&

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2019-11-03 Thread Christoph Cullmann
cullmann added a comment. Ok, I traced this now a bit. The KIconLoaderPrivate::createIconImage processing seems already not to work for resource based themes on Linux. To try, e.g. use Kate, add the binary resource icon theme to the right location cp

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2019-11-03 Thread Christoph Cullmann
cullmann added a comment. In D25119#558092 , @broulik wrote: > In D25119#558084 , @cullmann wrote: > > > Hmm, where does that happen? > > >

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2019-11-03 Thread Christoph Cullmann
cullmann added a comment. In D25119#558082 , @broulik wrote: > > If you e.g. want to switch to "breeze-dark" this fails as the icons will not be found. > > But why would you need this anyway? At least with `KIconEngine` we colorize the

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2019-11-03 Thread Christoph Cullmann
cullmann added a comment. This patch will still need some work to make dark mode available. Kate will be able to switch to it via the color theme switcher, as that will just switch over to breeze-dark. Could you elaborate on "Also, our icon loading has kind of evolved and we've

D25122: embedd trigrams.map into shared library

2019-11-03 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R246:0c195d0ff947: embed trigrams.map into shared library (authored by cullmann). REPOSITORY R246 Sonnet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25122?vs=69200=69211 REVISION DETAIL

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2019-11-02 Thread Christoph Cullmann
cullmann added a comment. This patch by itself will not make the dark mode work, but e.g. Kate will be able to use it as the color theme chooser will set breeze-dark as theme and the icons will be "there". Beside this, it avoids loading 20MB of data, as before the resource file got loaded

D25122: embedd trigrams.map into shared library

2019-11-02 Thread Christoph Cullmann
cullmann added reviewers: dfaure, vonreth, Frameworks. cullmann added a comment. Easier to deploy, we just need the shared libs and no extra data files (at least not for sonnet itself). REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D25122 To: cullmann, dfaure,

D25122: embedd trigrams.map into shared library

2019-11-02 Thread Christoph Cullmann
cullmann created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY Easier to deploy sonnet: just install the libraries TEST PLAN make && make test REPOSITORY R246 Sonnet BRANCH

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2019-11-02 Thread Christoph Cullmann
cullmann added a comment. At the moment, the hack in kiconthemes only allows to load one theme. This means you have just "breeze". If you e.g. want to switch to "breeze-dark" this fails as the icons will not be found. REPOSITORY R266 Breeze Icons REVISION DETAIL

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2019-11-02 Thread Christoph Cullmann
cullmann added a comment. At the moment this patch will only create the shared lib if we have binary resources configured. One could always create the lib and only compile in the resources if wanted. That would allow e.g. applications like Kate to always link against this on all

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2019-11-02 Thread Christoph Cullmann
cullmann added a reviewer: rempt. cullmann added a subscriber: rempt. cullmann added a comment. Perhaps @rempt has some input on this, for the cross-platform aspects. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25119 To: cullmann, #frameworks, vonreth,

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2019-11-02 Thread Christoph Cullmann
cullmann added reviewers: Frameworks, vonreth, dfaure. cullmann added a comment. Some reviewers. I am not sure this is the "perfect" solution, but it will make deploying applications a lot easier given just linking against this library provides the icons most of them will need. And

D24989: support multiple rcc files with icons themes

2019-11-02 Thread Christoph Cullmann
cullmann added a comment. See https://phabricator.kde.org/D25119 for the replacement idea. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D24989 To: cullmann, #frameworks, vonreth, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2019-11-02 Thread Christoph Cullmann
cullmann created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY At the moment, one big problem for non-unices is the deployment of icons Close to all things in KDE stuff relies on

D24989: support multiple rcc files with icons themes

2019-11-02 Thread Christoph Cullmann
cullmann abandoned this revision. cullmann added a comment. I think I retract this. I have a nicer way to have this seamless integrated without KIconThemes. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D24989 To: cullmann, #frameworks, vonreth, dfaure Cc:

D25102: VHDL: all keywords are insensitive

2019-11-01 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Yep, I think this is better, thanks! REPOSITORY R216 Syntax Highlighting BRANCH fix-vhdl REVISION DETAIL https://phabricator.kde.org/D25102 To: nibags,

D25054: Add string escape characters to PowerShell syntax.

2019-10-29 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Looks good to me! Thanks! REPOSITORY R216 Syntax Highlighting BRANCH ps-escape (branched from master) REVISION DETAIL https://phabricator.kde.org/D25054 To: zrax, dhaumann,

D25054: Add string escape characters to PowerShell syntax.

2019-10-29 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:3d28d32776c9: Add string escape characters to PowerShell syntax. (authored by zrax, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D25054: Add string escape characters to PowerShell syntax.

2019-10-29 Thread Christoph Cullmann
cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I can push it for you. But I think it would be a good idea to have an unit test extended with the new supported syntax parts. Could you add that? REPOSITORY R216 Syntax

D24982: Small improvements in some XML files

2019-10-29 Thread Christoph Cullmann
cullmann added a comment. Could we perhaps just do some minimal checking like "no dynamic stuff at all" => turn off all captures? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24982 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann Cc:

D24989: support multiple rcc files with icons themes

2019-10-28 Thread Christoph Cullmann
cullmann added a reviewer: dfaure. cullmann added a comment. Will alter the initializer before pushing, if it is clarified if the approach is ok. Given the lack of mmap for resource files on Windows, I actually would prefer to hide the resources in dummy plugins, but I guess it would make

D24989: support multiple rcc files with icons themes

2019-10-27 Thread Christoph Cullmann
cullmann added reviewers: Frameworks, vonreth. cullmann added a comment. To make this usable, we will need to change the way we create the binary resources in breeze-icons and adapt the craft packaging. Then we can use e.g. breeze + breeze dark for app store applications like normally.

D24989: support multiple rcc files with icons themes

2019-10-27 Thread Christoph Cullmann
cullmann created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY Instead of one hard-coded theme, support multiple ones This assumes that the rccs themself contain a /icons/ prefix

D24826: Enforce 100 chars line width

2019-10-21 Thread Christoph Cullmann
cullmann added a comment. See the other task: columnlimit 0 leads to endless long lines and is a unusable default. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24826 To: romangg, #frameworks, cullmann Cc: winterz, zzag, kde-frameworks-devel,

D24826: Enforce 100 chars line width

2019-10-21 Thread Christoph Cullmann
cullmann added a comment. Perhaps easiest way to see what happens: apply it to one of your things and vary the value. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24826 To: romangg, #frameworks, cullmann Cc: kde-frameworks-devel, kde-buildsystem,

D24826: Enforce 100 chars line width

2019-10-21 Thread Christoph Cullmann
cullmann added a comment. It is unfortunately very brutal and in-deed, it can create very long lines if you have matching bad constructs. One can play with stuff like a limit of 160 oder whatever to limit that, but as it brutally hard break and align stuff, with e.g. 100 for my tries, a

D24826: Enforce 100 chars line width

2019-10-21 Thread Christoph Cullmann
cullmann added a comment. As explained in the thread on https://phabricator.kde.org/T11214, this will make the formatting ugly as hell, as if you have long method names, stuff is broken in arbitrary bad ways. I don't want to change that, if nobody can avoid the resulting breakage.

D24568: Provide clang-format target with a KDE Frameworks style file

2019-10-20 Thread Christoph Cullmann
cullmann added a comment. Volker Ok'd it that I used that on the co-maintained KSyntaxHighlighting framework, too. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann, #frameworks, dfaure Cc: zzag, sitter, mwolff, ochurlaud, nalvarez,

D24620: Windows MSVC compile fix

2019-10-20 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R159:1ea2058a09c9: Windows MSVC compile fix (authored by cullmann). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24620?vs=67869=68393 REVISION DETAIL

D24575: Updates from CMake 3.16

2019-10-20 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:dbd14c404867: Updates from CMake 3.16 (authored by cullmann). Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. REPOSITORY R216 Syntax

D24811: tests: fix macos build failure

2019-10-20 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Why not ;=) REPOSITORY R159 KActivities Statistics BRANCH fix-tests-model-boost-include (branched from master) REVISION DETAIL https://phabricator.kde.org/D24811 To:

D24620: Windows MSVC compile fix

2019-10-20 Thread Christoph Cullmann
cullmann added a comment. Can I just push that? Then we no longer need to patch just this one framework for Windows. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D24620 To: cullmann, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24568: Provide clang-format target with a KDE Frameworks style file

2019-10-20 Thread Christoph Cullmann
cullmann added a comment. Ok, I pushed this now. I will use that myself in KTextEditor and Kate instead of my old file and shell script. We can think about what to do with other frameworks now. REPOSITORY R240 Extra CMake Modules REVISION DETAIL

D24568: Provide clang-format target with a KDE Frameworks style file

2019-10-20 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. cullmann marked an inline comment as done. Closed by commit R240:235fcabf5018: Provide clang-format target with a KDE Frameworks style file (authored by cullmann). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST

D24568: Provide clang-format target with a KDE Frameworks style file

2019-10-20 Thread Christoph Cullmann
cullmann added inline comments. INLINE COMMENTS > dfaure wrote in clang-format.cmake:75 > (b) looks good to me, and more importantly, I like the goal of being as close > as possible to the Qt coding style. removed that setting, back to Webkit default of BreakBeforeTernaryOperators: true

D24568: Provide clang-format target with a KDE Frameworks style file

2019-10-20 Thread Christoph Cullmann
cullmann updated this revision to Diff 68369. cullmann added a comment. - keep default of BreakBeforeTernaryOperators = true REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24568?vs=68186=68369 BRANCH master REVISION DETAIL

D24568: Provide clang-format target with a KDE Frameworks style file

2019-10-19 Thread Christoph Cullmann
cullmann added inline comments. INLINE COMMENTS > zzag wrote in clang-format.cmake:75 > I've been always wondering how one should break long ternary operators when > writing KF code. There are several ways to do it > > (a) w/o breaking (BreakBeforeTernaryOperators: false) > > const FooBar

D24568: Provide clang-format target with a KDE Frameworks style file

2019-10-19 Thread Christoph Cullmann
cullmann added a comment. Has somebody tested the current state? I really would like to get this going as in my eyes this will finally put a working solution in place for the coding style enforcing on at least frameworks. One can later still improve stuff like "shall the gitlab

D24620: Windows MSVC compile fix

2019-10-17 Thread Christoph Cullmann
cullmann added a comment. Ok to push that? Would avoid the last patch in craft to build frameworks. REPOSITORY R159 KActivities Statistics REVISION DETAIL https://phabricator.kde.org/D24620 To: cullmann, #frameworks Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24568: Provide clang-format target with a KDE Frameworks style file

2019-10-17 Thread Christoph Cullmann
cullmann added a comment. Without the initializer change, the file works for me reasonable well, tried it again on KTextEditor. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann, #frameworks, dfaure Cc: sitter, mwolff, ochurlaud,

D24568: Provide clang-format target with a KDE Frameworks style file

2019-10-17 Thread Christoph Cullmann
cullmann updated this revision to Diff 68186. cullmann marked an inline comment as done. cullmann added a comment. - avoid collapsing of constructor initializer lines REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24568?vs=68091=68186 BRANCH

D24568: Provide clang-format target with a KDE Frameworks style file

2019-10-17 Thread Christoph Cullmann
cullmann marked an inline comment as done. cullmann added a comment. With BreakConstructorInitializers: BeforeColon you get collapsed stuff like; Range::Range(const KTextEditor::Cursor , const KTextEditor::Cursor c2, MotionType mt) : Range(c1.line(), c1.column(), c2.line(),

D24568: Provide clang-format target with a KDE Frameworks style file

2019-10-16 Thread Christoph Cullmann
cullmann added a comment. In D24568#548490 , @dfaure wrote: > Do we want these, found in https://code.qt.io/cgit/qt/qt5.git/tree/_clang-format? > > # We use template< without space. > SpaceAfterTemplateKeyword: false > > #

D24568: Provide clang-format target with a KDE Frameworks style file

2019-10-16 Thread Christoph Cullmann
cullmann updated this revision to Diff 68091. cullmann marked 4 inline comments as done. cullmann added a comment. - fix coding style issue, we don't want indented case labels - add initial docs - adjust style - just tell the user it will not work REPOSITORY R240 Extra CMake Modules

D24672: GIT_SILENT Run uncrustify-kf5 on the whole tree

2019-10-15 Thread Christoph Cullmann
cullmann added a comment. As an non-framework module, there is no need to follow the frameworks style, if not wanted. REPOSITORY R374 KolourPaint REVISION DETAIL https://phabricator.kde.org/D24672 To: ahmadsamir, kde-frameworks-devel, mkoller Cc: cullmann, ognarb, kde-frameworks-devel

D24568: Provide clang-format target with a KDE Frameworks style file

2019-10-13 Thread Christoph Cullmann
cullmann added a reviewer: dfaure. cullmann added a comment. Perhaps David could give feedback if the file actually captures the intend to do proper KDE Frameworks/libs like formatting. I had a mistake with the indented case statements, that should be fixed. REPOSITORY R240 Extra CMake

D24620: Windows MSVC compile fix

2019-10-13 Thread Christoph Cullmann
cullmann updated this revision to Diff 67869. cullmann added a comment. Missed to add file with proper compiler guard :/ REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24620?vs=67867=67869 REVISION DETAIL

D24620: Windows MSVC compile fix

2019-10-13 Thread Christoph Cullmann
cullmann created this revision. cullmann added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY This patch is since "long" in craft blueprints, can we merge that? TEST PLAN

D24568: Provide clang-format target with a KDE Frameworks style file

2019-10-13 Thread Christoph Cullmann
cullmann retitled this revision from "Provide clang-format target with a common KDE style file" to "Provide clang-format target with a KDE Frameworks style file". REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann, #frameworks Cc:

D24568: Provide clang-format target with a common KDE style file

2019-10-12 Thread Christoph Cullmann
cullmann added a comment. I hope this file implements https://community.kde.org/Policies/Kdelibs_Coding_Style And that is the style all frameworks got astyled with on initial import. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To:

D24568: Provide clang-format target with a common KDE style file

2019-10-12 Thread Christoph Cullmann
cullmann added a comment. In D24568#546227 , @aacid wrote: > > common KDE style file > > There's no such thing as a common KDE style Shall we name it kdelibs coding style? But actually the idea is to have one, as opt in, for the

D24568: Provide clang-format target with a common KDE style file

2019-10-12 Thread Christoph Cullmann
cullmann added a comment. If there are more deviations from the kdelibs/frameworks coding style, please tell me. Otherwise, I am happy with the output of this file for KTextEditor & Kate. For the .clang-format instantiation question: I think it makes sense to instantiate it on

D24568: Provide clang-format target with a common KDE style file

2019-10-12 Thread Christoph Cullmann
cullmann added a reviewer: Frameworks. cullmann marked an inline comment as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann, #frameworks Cc: davidedmundson, dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n,

D24568: Provide clang-format target with a common KDE style file

2019-10-12 Thread Christoph Cullmann
cullmann updated this revision to Diff 67797. cullmann added a comment. - add initial docs REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24568?vs=67796=67797 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24568 AFFECTED

D24568: Provide clang-format target with a common KDE style file

2019-10-12 Thread Christoph Cullmann
cullmann marked an inline comment as done. cullmann added inline comments. INLINE COMMENTS > ognarb wrote in KDEClangFormat.cmake:11 > need doc Added some initial docs REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D24568 To: cullmann Cc: davidedmundson,

D24568: Provide clang-format target with a common KDE style file

2019-10-12 Thread Christoph Cullmann
cullmann updated this revision to Diff 67796. cullmann added a comment. - fix coding style issue, we don't want indented case labels REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24568?vs=67739=67796 BRANCH master REVISION DETAIL

D24568: Provide clang-format target with a common KDE style file

2019-10-12 Thread Christoph Cullmann
cullmann added inline comments. INLINE COMMENTS > davidedmundson wrote in KDEClangFormat.cmake:48 > it's a bit weird to put new files in the source directory when running cmake. > > Copying when running the target clang-format would probably be ok as there > you're already doing an explicit

D24568: Provide clang-format target with a common KDE style file

2019-10-12 Thread Christoph Cullmann
cullmann added a comment. In D24568#545736 , @apol wrote: > I'm not sure how this works, but would it be possible to have a target that only works on a patch? You usually want to make sure what you modified didn't diverge from the code.

D24568: Provide clang-format target with a common KDE style file

2019-10-11 Thread Christoph Cullmann
cullmann created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY Provides a clang-format target if wanted Example usage:

D4363: Don't set gnu style parameter with Clang and MSVC

2019-10-09 Thread Christoph Cullmann
cullmann added a comment. Herald edited subscribers, added: kde-buildsystem, kde-frameworks-devel; removed: Frameworks, Build System. Is this still relevant? If yes, from the diff, looks ok for me. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D4363

D24355: TypeScript: update grammar and fixes

2019-10-09 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Seems fine. Does typescript-react.xml lack a version update? REPOSITORY R216 Syntax Highlighting BRANCH update-typescript REVISION DETAIL https://phabricator.kde.org/D24355

D24357: KateModeMenuList: force the vertical position above the button

2019-10-09 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Ok with that. REPOSITORY R39 KTextEditor BRANCH menu-vertical-position REVISION DETAIL https://phabricator.kde.org/D24357 To: nibags, #ktexteditor, cullmann, dhaumann Cc:

D24492: [FilteredDirIterator] Reduce stack pressure

2019-10-08 Thread Christoph Cullmann
cullmann added a comment. Yes, I think you want the concept of a loop with continue. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D24492 To: hurikhan77, #baloo Cc: cullmann, shubham, kde-frameworks-devel, lots0logs, LeGast00n, fbampaloukas, GB_2, domson,

D24442: ensure winId() not called on non-native widgets

2019-10-07 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R252:93c19fbfa125: ensure winId() not called on non-native widgets (authored by cullmann). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE

D24442: ensure winId() not called on non-native widgets

2019-10-07 Thread Christoph Cullmann
cullmann added a comment. It would be great to have that in 5.63, or I am too late? REPOSITORY R252 Framework Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann, #frameworks, dfaure Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D24442: ensure winId() not called on non-native widgets

2019-10-07 Thread Christoph Cullmann
cullmann added a comment. If nobody objects will push that later, without any window on secondary screen is garbage after palette change. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann, #frameworks, dfaure Cc: broulik,

D24442: ensure winId() not called on non-native widgets

2019-10-06 Thread Christoph Cullmann
cullmann added a reviewer: dfaure. cullmann added a comment. If possible I would like to have this in 5.63, as otherwise any color scheme change will make all Qt applications on the non-primary screen unusable with scaling. REPOSITORY R252 Framework Integration REVISION DETAIL

D24442: ensure winId() not called on non-native widgets

2019-10-06 Thread Christoph Cullmann
cullmann added a comment. Can I merge this? The effect is quiet "evil" here ;=) REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24442: ensure winId() not called on non-native widgets

2019-10-06 Thread Christoph Cullmann
cullmann added a reviewer: Frameworks. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24442: ensure winId() not called on non-native widgets

2019-10-06 Thread Christoph Cullmann
cullmann added a comment. For KRun for me the calls there look properly guarded. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To: cullmann Cc: broulik, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24442: ensure winId() not called on non-native widgets

2019-10-06 Thread Christoph Cullmann
cullmann added a comment. You mean if there are such calls? Can do. Btw., Gwenview doesn't render for me any pictures on the second screen either, but I found there no suspicious code :/ REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D24442 To:

D24442: ensure winId() not called on non-native widgets

2019-10-06 Thread Christoph Cullmann
cullmann created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY if we do that, window will be corrupted BUG: 412675 TEST PLAN Use Kate, change color theme on a second screen

D24403: Small performance improvements suggested by clang-tidy

2019-10-04 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. I think this is ok to merge, I don't see the issue with the QRegExp. (I understand that it stores it result in mutable data in the object, but that patch didn't alter this, just avoids the copying of the regex before this happens,

D24378: WordDetect rule: detect delimiters at the inner edge of the string

2019-10-03 Thread Christoph Cullmann
cullmann accepted this revision. This revision is now accepted and ready to land. REPOSITORY R216 Syntax Highlighting BRANCH fix-worddetect REVISION DETAIL https://phabricator.kde.org/D24378 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause, jpoelen Cc:

D24378: WordDetect rule: detect delimiters at the inner edge of the string

2019-10-03 Thread Christoph Cullmann
cullmann added a comment. Seems reasonable, do we need some doc updates? Or some more verbose description in the XSD? REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D24378 To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, vkrause, jpoelen

D24311: Remove useless variable

2019-09-30 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Yeah, looks useless. REPOSITORY R270 KCodecs BRANCH master REVISION DETAIL https://phabricator.kde.org/D24311 To: aacid, cullmann Cc: cullmann, kde-frameworks-devel, LeGast00n,

D24306: Highlight GeoJSON files as if they were plain JSON

2019-09-30 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Good idea. REPOSITORY R216 Syntax Highlighting BRANCH basic-geojson-support (branched from master) REVISION DETAIL https://phabricator.kde.org/D24306 To: gszymaszek, cullmann

D24211: Add syntax highlighting for SubRip Text (SRT) Subtitles

2019-09-29 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R216:72683653db72: Add syntax highlighting for SubRip Text (SRT) Subtitles (authored by nibags, committed by cullmann). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D24210: KadeModeMenuList: fix memory leaks and others

2019-09-29 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R39:f1d9f086da6f: KadeModeMenuList: fix memory leaks and others (authored by nibags, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D24210: KadeModeMenuList: fix memory leaks and others

2019-09-29 Thread Christoph Cullmann
cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Like that better, thanks! REPOSITORY R39 KTextEditor BRANCH fix-mode-menu REVISION DETAIL https://phabricator.kde.org/D24210 To: nibags, #ktexteditor, dhaumann, cullmann Cc:

D24287: cleanup dbus related objects early enough to avoid hang on program exit

2019-09-28 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes. Closed by commit R288:301b33daff31: cleanup dbus related objects early enough to avoid hang on program exit (authored by cullmann). REPOSITORY R288 KJobWidgets CHANGES SINCE LAST UPDATE

D24287: cleanup dbus related objects early enough to avoid hang on program exit

2019-09-28 Thread Christoph Cullmann
cullmann added a comment. This should be a replacement for D2545 . REPOSITORY R288 KJobWidgets REVISION DETAIL https://phabricator.kde.org/D24287 To: cullmann, dfaure, kfunk Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24287: cleanup dbus related objects early enough to avoid hang on program exit

2019-09-28 Thread Christoph Cullmann
cullmann created this revision. cullmann added reviewers: dfaure, kfunk. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cullmann requested review of this revision. REVISION SUMMARY workaround for issue seen on Windows that at the moment requires Qt patch

  1   2   3   4   5   6   7   8   9   10   >