Re: Should syntax-higlighting get 5.79.1 released with the control flow color fix?

2021-02-15 Thread Christoph Cullmann

On 2021-02-15 23:27, Albert Astals Cid wrote:

Hi all,

Should we do a new release of syntax-highlighting with
341b6e8c64d1fa8df16fe9c65e185cea3c6a7901 ?

5.79.0 missed it by minutes and given
7a2260a9933cd9838e7dc8ae30c3def2173ba166 was not in any release
either, i think it'd make sense to get 5.79.1 out so we don't get
complains that we changed black to Orange and the complains that we
changed Orange to black next month.


I would have no issues with a .1,
guess I am just to ignorant for color changes.

Greetings
Christoph




Cheers,
  Albert


--
Ignorance is bliss...
https://cullmann.io | https://kate-editor.org


Re: Need xcb/xkb help for severe kglobalaccel_x11 issue

2021-02-07 Thread Christoph Cullmann

On 2021-02-06 10:08, David Faure wrote:

Problem mostly fixed by
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/339
but still seeing 15 notifications instead of 1 (already better than 
145...).


Indeed a single call to
/usr/bin/setxkbmap -layout us,fr -option -option compose:caps
sends 12 XCB_XKB_NEW_KEYBOARD_NOTIFY events,
all with changed & XCB_XKB_NKN_DETAIL_KEYCODES, which makes 
kglobalaccel

ungrab+regrab all keys.

Should I add another compression timer in kglobalaccel, or do you think 
this is

fixable in setxkbmap?


I think one should be realistic and just add yet another timer ;=)

Greetings
Christoph

--
Ignorance is bliss...
https://cullmann.io | https://kate-editor.org


Re: KDE Frameworks 6 - Virtual Sprint setup

2021-01-31 Thread Christoph Cullmann

On 2021-01-30 12:14, Volker Krause wrote:

On Freitag, 29. Januar 2021 15:57:59 CET Adam Szopa wrote:

Hello,
I've been talking with David Faure about setting up a Sprint focused 
on KF6

work. Some of the topics would include:
- Reviewing the KF6 board
(https://phabricator.kde.org/project/board/310/[1]): -- Clean up
-- Tagging Junior Jobs
- Working out a structure/process for handling:
-- "Stuck" tasks
-- Unit test regressions
- Decide the 5.15 minimum requirement bump timeline
- Decide on a 6 branching strategy and timeline
- Decide if/how ECM should support multiple Qt versions

That's just an example list - the wiki[1] should include the up to 
date and

detailed topics.

The Sprint will use the KDE BBB instance - same tech that powered last 
years
 Akademy; I'll coordinate that with our sysadmins to have it 
available.


As for the date and length, usually Virtual Sprints are a weekend 
thing. I'd

love to hear from you if that sounds OK, and which weekend would be
workable for you (how soon can we get this started) and your preferred
availability hours. I'll set up a poll later to pinpoint the final 
timing.


Thanks for driving this, I'm in! European hours preferred, any weekend
starting from w6 should be possible.

Count me in, too ;=)
European hours preferred.

Greetings
Christoph

--
Ignorance is bliss...
https://cullmann.io | https://kate-editor.org


D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2021-01-26 Thread Christoph Cullmann
cullmann abandoned this revision.
cullmann added a comment.


  I have now a working version that handles palette changes, too.
  
  https://invent.kde.org/frameworks/breeze-icons/-/merge_requests/79
  
  + usage in Kate
  
  https://invent.kde.org/utilities/kate/-/merge_requests/204
  
  We should discuss further stuff there.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25119

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: brute4s99, nicolasfella, aboyer, sars, wrobelda, davidedmundson, broulik, 
rempt, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2021-01-26 Thread Christoph Cullmann
cullmann added a comment.


  I need to finalize this, people start to complain more and more about this 
missing on Windows for Kate/etc... ;(

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25119

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: brute4s99, nicolasfella, aboyer, sars, wrobelda, davidedmundson, broulik, 
rempt, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2020-11-24 Thread Christoph Cullmann
cullmann added a comment.


  Hmm, I don't think you need a theme chooser, we just need to watch for the 
palette change signal and then trigger again the theme name setting based on 
the background palette.
  That would be enough to detect bright/dark mode.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25119

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: brute4s99, nicolasfella, aboyer, sars, wrobelda, davidedmundson, broulik, 
rempt, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2020-10-31 Thread Christoph Cullmann
cullmann added a comment.


  I think exporting some namespaced function or such that will do the setting 
of the theme and calling it would be ok for me.
  This is anyways an "opt-in" approach people must decide to use.
  Hannah, what do you think?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25119

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: aboyer, sars, wrobelda, davidedmundson, broulik, rempt, 
kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D25339: update lineHeight if boundingRect indicates a larger value.

2020-10-10 Thread Christoph Cullmann
cullmann commandeered this revision.
cullmann edited reviewers, added: xuetianweng; removed: cullmann.
cullmann added a comment.


  I think the solution we have in current master is ok enough.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: cullmann, #ktexteditor, dhaumann, #frameworks, rjvbb, xuetianweng
Cc: ahmadsamir, brauch, sars, pshinjo, rjvbb, fakefred, anthonyfieroni, 
kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, dhaumann


D25339: update lineHeight if boundingRect indicates a larger value.

2020-10-10 Thread Christoph Cullmann
cullmann abandoned this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: cullmann, #ktexteditor, dhaumann, #frameworks, rjvbb, xuetianweng
Cc: ahmadsamir, brauch, sars, pshinjo, rjvbb, fakefred, anthonyfieroni, 
kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, dhaumann


Re: KUserFeedback => Frameworks?

2020-10-09 Thread Christoph Cullmann

On 2020-09-26 21:52, Christoph Cullmann wrote:

Hi,

is there any real reason why KUserFeedback is yet no official 
framework?


I just stumbled over this during my try to add it as dependency for
the Windows builds of Kate.

Given at least the Plasma Desktop itself and Kate uses this now,
wouldn't it make sense to have it in the regular releases?


Hi,

any feedback on this?

Greetings
Christoph

--
Ignorance is bliss...
https://cullmann.io | https://kate-editor.org


KUserFeedback => Frameworks?

2020-09-26 Thread Christoph Cullmann

Hi,

is there any real reason why KUserFeedback is yet no official framework?

I just stumbled over this during my try to add it as dependency for the 
Windows builds of Kate.


Given at least the Plasma Desktop itself and Kate uses this now, 
wouldn't it make sense to have it in the regular releases?


Greetings
Christoph

--
Ignorance is bliss...
https://cullmann.io | https://kate-editor.org


Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

2020-08-22 Thread Christoph Cullmann

On 2020-08-22 00:25, David Faure wrote:

Hi Christoph,

As part of my continuous effort to keep the KF5 CI "green", I
submitted a MR for skipping the crashing tests if Qt is <= 5.15.0 :
https://invent.kde.org/frameworks/ktexteditor/-/merge_requests/18


The question is: does that help? For me it even crashs with 5.15.0, as
Simon's relevant patches are not inside that release.

And I thought I would have seen CI crashs with the Qt 5.15 build, too.



But please note that there's also this actual regression:

https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.15/35/testReport/junit/projectroot/autotests/kateindenttest_testRuby/

Reproduced locally:

---
/d/kde/src/5/frameworks/ktexteditor/autotests/input/indent/ruby/regexp1/expected
   2016-12-14 23:10:25.350229001 +0100
+++
/d/kde/src/5/frameworks/ktexteditor/autotests/input/indent/ruby/regexp1/actual
 2020-08-22 00:11:35.284997275 +0200
@@ -1,2 +1,2 @@
   rx =~ /^hello/
-  foo
+  foo

FAIL!  : IndentTest::testRuby(regexp1) Compared values are not the same
   Actual   (diff.exitCode()): 1
   Expected (EXIT_SUCCESS)   : 0
   Loc:
[/d/kde/src/5/frameworks/ktexteditor/autotests/src/script_test_base.cpp(153)]

Can you have a look, or forward to someone who can?


I think I will mark this one test just as XFAIL, as I think nobody has 
time to hunt when this

regression went in.

Greetings
Christoph



Cheers,
David.

On lundi 6 juillet 2020 16:28:27 CEST Christoph Cullmann wrote:

Hi,

this shows again a different V4 GC error :/

==3342==ERROR: AddressSanitizer: SEGV on unknown address 
0x0028

(pc 0x7f58d0bb98ec bp 0x615f8000 sp 0x7ffe976de5f0 T0)
==3342==The signal is caused by a READ memory access.
==3342==Hint: address points to the zero page.
 #0 0x7f58d0bb98ec in QV4::MarkStack::drain()
(/usr/lib64/libQt5Qml.so.5+0xb28ec)
 #1 0x7f58d0bba1e4 in QV4::MemoryManager::mark()
(/usr/lib64/libQt5Qml.so.5+0xb31e4)
 #2 0x7f58d0bbc37d  (/usr/lib64/libQt5Qml.so.5+0xb537d)
 #3 0x7f58d0bbdb87 in QV4::MemoryManager::allocData(unsigned long)
(/usr/lib64/libQt5Qml.so.5+0xb6b87)
 #4 0x7f58d0bbdbe2 in
QV4::MemoryManager::allocObjectWithMemberData(QV4::VTable const*,
unsigned int) (/usr/lib64/libQt5Qml.so.5+0xb6be2)
 #5 0x7f58d0cd10f0 in
QV4::Runtime::CreateMappedArgumentsObject::call(QV4::ExecutionEngine*)
(/usr/lib64/libQt5Qml.so.5+0x1ca0f0)
 #6 0x7f58bc65b06d  (/memfd:JITCode:QtQml (deleted)+0x6d)

:( Thought 5.15 would have all needed fixes.

Greetings
Christoph

On 2020-07-05 15:47, CI System wrote:
> BUILD UNSTABLE
>
> Build URL
>
>
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQ
>t5.15/4/>
> Project:
>kf5-qt5 SUSEQt5.15
>
> Date of build:
>Sun, 05 Jul 2020 13:40:03 +
>
> Build duration:
>7 min 46 sec and counting
>
> BUILD ARTIFACTS
>
>* abi-compatibility-results.yaml [1]
>* acc/KF5TextEditor-5.72.0.xml [2]
>* compat_reports/KF5TextEditor_compat_report.html [3]
>* logs/KF5TextEditor/5.72.0/log.txt [4]
>
> JUnit Tests
>
>Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0
>
> test(s), Total: 1 test(s)
>
>Name: projectroot Failed: 3 test(s), Passed: 59 test(s), Skipped: 0
>
> test(s), Total: 62 test(s)
>
>* Failed: projectroot.autotests.bug313759
>
>* Failed: projectroot.autotests.kateindenttest_testAda
>
>* Failed: projectroot.autotests.kateindenttest_testPascal
>
>Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5
>
> test(s), Skipped: 0 test(s), Total: 5 test(s)
>
> Cobertura Report
>
> Project Coverage Summary
>
> Name
>
>Packages
>Files
>Classes
>Lines
>Conditionals
>
>Cobertura Coverage Report
>79% (22/28)
>85% (262/307)
>85% (262/307)
>67% (33050/49269)
>49% (14779/30050)
>
>Coverage Breakdown by Package
>
> Name
>
>Files
>Classes
>Lines
>Conditionals
>
>autotests.src
>97% (37/38)
>97% (37/38)
>93% (4798/5140)
>49% (1812/3680)
>
>autotests.src.vimode
>100% (9/9)
>100% (9/9)
>99% (5528/5570)
>58% (984/1708)
>
>src.buffer
>88% (15/17)
>88% (15/17)
>89% (1677/1892)
>74% (1078/1464)
>
>src.completion
>100% (11/11)
>

D23410: improve word completion to use highlighting to detect word boundaries

2020-08-11 Thread Christoph Cullmann
cullmann abandoned this revision.
cullmann added a comment.


  At the moment no idea how to fix that without regressions.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D23410

To: cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D24568: Provide clang-format target with a KDE Frameworks style file

2020-08-11 Thread Christoph Cullmann
cullmann closed this revision.
cullmann added a comment.


  For my 2 wanted changes, I created a new merge request
  https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/20

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24568

To: cullmann, #frameworks, dfaure, broulik, davidedmundson
Cc: zzag, sitter, mwolff, ochurlaud, nalvarez, kossebau, aacid, davidedmundson, 
dhaumann, apol, ognarb, kde-frameworks-devel, kde-buildsystem, LeGast00n, 
cblack, bencreasy, michaelh, ngraham, bruns


D24826: Enforce 100 chars line width

2020-08-11 Thread Christoph Cullmann
cullmann added a comment.


  As said above, I think 100 is a bad idea. Can we close this?

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24826

To: romangg, #frameworks, cullmann
Cc: winterz, zzag, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, 
bencreasy, michaelh, ngraham, bruns


D25339: update lineHeight if boundingRect indicates a larger value.

2020-08-11 Thread Christoph Cullmann
cullmann added a comment.


  I think we went with the solution in https://phabricator.kde.org/D29789, 
could we close this?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: ahmadsamir, brauch, sars, pshinjo, rjvbb, fakefred, anthonyfieroni, 
kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, dhaumann


Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

2020-07-11 Thread Christoph Cullmann

On 2020-07-09 10:03, Christoph Cullmann wrote:

On 2020-07-08 00:07, David Faure wrote:

On mardi 7 juillet 2020 17:58:26 CEST Christoph Cullmann wrote:

On 2020-07-07 12:16, David Faure wrote:
> Yep :(
>
> You'll tell Simon and/or QTBUG-*?

I will take a look if I can find some existing bug or open a new.

Simon left Qt, or?


Yes but I think that was already the case when he fixed the last one 
:-)


I did so some research.

Might this be fixed by

https://code.qt.io/cgit/qt/qtdeclarative.git/commit/src/qml?h=5.15=082247604219316035484cfdc83662936df2edb5

or

https://code.qt.io/cgit/qt/qtdeclarative.git/commit/src/qml?h=5.15=082247604219316035484cfdc83662936df2edb5

At least the backtraces in the referenced bugs look similar.

That isn't in 5.15?

Is there a chance to have the CI use some Qt with these backported?
(or is it already and it is a different issue?)


I talked with Simon and very likely these commits in the 5.15 branch 
would fix our issues.


Is there a change to get a patched Qt for the CI?

If that fixes it, actually, it would be highly important to get these 
fixes in the distro Qt packages,
otherwise all of KDE that uses the QJSEngine (or QML) will just randomly 
crash.


Greetings
Christoph


Greetings
Christoph


--
Ignorance is bliss...
https://cullmann.io | https://kate-editor.org


Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

2020-07-09 Thread Christoph Cullmann

On 2020-07-08 00:07, David Faure wrote:

On mardi 7 juillet 2020 17:58:26 CEST Christoph Cullmann wrote:

On 2020-07-07 12:16, David Faure wrote:
> Yep :(
>
> You'll tell Simon and/or QTBUG-*?

I will take a look if I can find some existing bug or open a new.

Simon left Qt, or?


Yes but I think that was already the case when he fixed the last one 
:-)


I did so some research.

Might this be fixed by

https://code.qt.io/cgit/qt/qtdeclarative.git/commit/src/qml?h=5.15=082247604219316035484cfdc83662936df2edb5

or

https://code.qt.io/cgit/qt/qtdeclarative.git/commit/src/qml?h=5.15=082247604219316035484cfdc83662936df2edb5

At least the backtraces in the referenced bugs look similar.

That isn't in 5.15?

Is there a chance to have the CI use some Qt with these backported?
(or is it already and it is a different issue?)

Greetings
Christoph

--
Ignorance is bliss...
https://cullmann.io | https://kate-editor.org


Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

2020-07-07 Thread Christoph Cullmann

On 2020-07-07 12:16, David Faure wrote:

Yep :(

You'll tell Simon and/or QTBUG-*?


I will take a look if I can find some existing bug or open a new.

Simon left Qt, or?

Greetings
Christoph



On lundi 6 juillet 2020 16:28:27 CEST Christoph Cullmann wrote:

Hi,

this shows again a different V4 GC error :/

==3342==ERROR: AddressSanitizer: SEGV on unknown address 
0x0028

(pc 0x7f58d0bb98ec bp 0x615f8000 sp 0x7ffe976de5f0 T0)
==3342==The signal is caused by a READ memory access.
==3342==Hint: address points to the zero page.
 #0 0x7f58d0bb98ec in QV4::MarkStack::drain()
(/usr/lib64/libQt5Qml.so.5+0xb28ec)
 #1 0x7f58d0bba1e4 in QV4::MemoryManager::mark()
(/usr/lib64/libQt5Qml.so.5+0xb31e4)
 #2 0x7f58d0bbc37d  (/usr/lib64/libQt5Qml.so.5+0xb537d)
 #3 0x7f58d0bbdb87 in QV4::MemoryManager::allocData(unsigned long)
(/usr/lib64/libQt5Qml.so.5+0xb6b87)
 #4 0x7f58d0bbdbe2 in
QV4::MemoryManager::allocObjectWithMemberData(QV4::VTable const*,
unsigned int) (/usr/lib64/libQt5Qml.so.5+0xb6be2)
 #5 0x7f58d0cd10f0 in
QV4::Runtime::CreateMappedArgumentsObject::call(QV4::ExecutionEngine*)
(/usr/lib64/libQt5Qml.so.5+0x1ca0f0)
 #6 0x7f58bc65b06d  (/memfd:JITCode:QtQml (deleted)+0x6d)

:( Thought 5.15 would have all needed fixes.

Greetings
Christoph

On 2020-07-05 15:47, CI System wrote:
> BUILD UNSTABLE
>
> Build URL
>
>https://build.kde.org/job/Frameworks/job/ktexteditor/

job/kf5-qt5%20SUSEQ

>t5.15/4/>
> Project:
>kf5-qt5 SUSEQt5.15
>
> Date of build:
>Sun, 05 Jul 2020 13:40:03 +
>
> Build duration:
>7 min 46 sec and counting
>
> BUILD ARTIFACTS
>
>* abi-compatibility-results.yaml [1]
>* acc/KF5TextEditor-5.72.0.xml [2]
>* compat_reports/KF5TextEditor_compat_report.html [3]
>* logs/KF5TextEditor/5.72.0/log.txt [4]
>
> JUnit Tests
>
>Name: (root) Failed: 0 test(s), Passed: 1 test(s),

Skipped: 0

>
> test(s), Total: 1 test(s)
>
>Name: projectroot Failed: 3 test(s), Passed: 59

test(s), Skipped: 0

>
> test(s), Total: 62 test(s)
>
>* Failed: projectroot.autotests.bug313759
>
>* Failed: projectroot.autotests.kateindenttest_testAda
>
>* Failed: projectroot.autotests.kateindenttest_testPascal
>
>Name: projectroot.autotests.src Failed: 0 test(s),

Passed: 5

>
> test(s), Skipped: 0 test(s), Total: 5 test(s)
>
> Cobertura Report
>
> Project Coverage Summary
>
> Name
>
>Packages
>Files
>Classes
>Lines
>Conditionals
>
>Cobertura Coverage Report
>79% (22/28)
>85% (262/307)
>85% (262/307)
>67% (33050/49269)
>49% (14779/30050)
>
>Coverage Breakdown by Package
>
> Name
>
>Files
>Classes
>Lines
>Conditionals
>
>autotests.src
>97% (37/38)
>97% (37/38)
>93% (4798/5140)
>49% (1812/3680)
>
>autotests.src.vimode
>100% (9/9)
>100% (9/9)
>99% (5528/5570)
>58% (984/1708)
>
>src.buffer
>88% (15/17)
>88% (15/17)
>89% (1677/1892)
>74% (1078/1464)
>
>src.completion
>100% (11/11)
>100% (11/11)
>57% (1788/3134)
>42% (1009/2425)
>
>src.completion.expandingtree
>100% (3/3)
>100% (3/3)
>40% (182/457)
>21% (73/340)
>
>src.dialogs
>0% (0/4)
>0% (0/4)
>0% (0/864)
>0% (0/184)
>
>src.document
>100% (4/4)
>100% (4/4)
>61% (1936/3179)
>48% (1407/2945)
>
>src.export
>0% (0/4)
>0% (0/4)
>0% (0/121)
>0% (0/156)
>
>src.include.ktexteditor
>78% (14/18)
>78% (14/18)
>83% (189/227)
>55% (125/226)
>
>src.inputmode
>100% (8/8)
>100% (8/8)
>63% (192/304)
>51% (39/77)
>
>src.mode
>88% (7/8)
>88% (7/8)
>36% (378/1051)
>16% (146/891)
>
>src.part
>0% (0/1)
>0% (0/1)
>0% (0/7)
> 

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.15 - Build # 4 - Still Unstable!

2020-07-06 Thread Christoph Cullmann

Hi,

this shows again a different V4 GC error :/

==3342==ERROR: AddressSanitizer: SEGV on unknown address 0x0028 
(pc 0x7f58d0bb98ec bp 0x615f8000 sp 0x7ffe976de5f0 T0)

==3342==The signal is caused by a READ memory access.
==3342==Hint: address points to the zero page.
#0 0x7f58d0bb98ec in QV4::MarkStack::drain() 
(/usr/lib64/libQt5Qml.so.5+0xb28ec)
#1 0x7f58d0bba1e4 in QV4::MemoryManager::mark() 
(/usr/lib64/libQt5Qml.so.5+0xb31e4)

#2 0x7f58d0bbc37d  (/usr/lib64/libQt5Qml.so.5+0xb537d)
#3 0x7f58d0bbdb87 in QV4::MemoryManager::allocData(unsigned long) 
(/usr/lib64/libQt5Qml.so.5+0xb6b87)
#4 0x7f58d0bbdbe2 in 
QV4::MemoryManager::allocObjectWithMemberData(QV4::VTable const*, 
unsigned int) (/usr/lib64/libQt5Qml.so.5+0xb6be2)
#5 0x7f58d0cd10f0 in 
QV4::Runtime::CreateMappedArgumentsObject::call(QV4::ExecutionEngine*) 
(/usr/lib64/libQt5Qml.so.5+0x1ca0f0)

#6 0x7f58bc65b06d  (/memfd:JITCode:QtQml (deleted)+0x6d)

:( Thought 5.15 would have all needed fixes.

Greetings
Christoph

On 2020-07-05 15:47, CI System wrote:

BUILD UNSTABLE

 Build URL

https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.15/4/

 Project:
kf5-qt5 SUSEQt5.15

 Date of build:
Sun, 05 Jul 2020 13:40:03 +

 Build duration:
7 min 46 sec and counting

 BUILD ARTIFACTS

* abi-compatibility-results.yaml [1]
* acc/KF5TextEditor-5.72.0.xml [2]
* compat_reports/KF5TextEditor_compat_report.html [3]
* logs/KF5TextEditor/5.72.0/log.txt [4]

 JUnit Tests

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0
test(s), Total: 1 test(s)

Name: projectroot Failed: 3 test(s), Passed: 59 test(s), 
Skipped: 0
test(s), Total: 62 test(s)

* Failed: projectroot.autotests.bug313759

* Failed: projectroot.autotests.kateindenttest_testAda

* Failed: projectroot.autotests.kateindenttest_testPascal

Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5
test(s), Skipped: 0 test(s), Total: 5 test(s)

 Cobertura Report

 Project Coverage Summary

 Name
Packages
Files
Classes
Lines
Conditionals

Cobertura Coverage Report
79% (22/28)
85% (262/307)
85% (262/307)
67% (33050/49269)
49% (14779/30050)

Coverage Breakdown by Package

 Name
Files
Classes
Lines
Conditionals

autotests.src
97% (37/38)
97% (37/38)
93% (4798/5140)
49% (1812/3680)

autotests.src.vimode
100% (9/9)
100% (9/9)
99% (5528/5570)
58% (984/1708)

src.buffer
88% (15/17)
88% (15/17)
89% (1677/1892)
74% (1078/1464)

src.completion
100% (11/11)
100% (11/11)
57% (1788/3134)
42% (1009/2425)

src.completion.expandingtree
100% (3/3)
100% (3/3)
40% (182/457)
21% (73/340)

src.dialogs
0% (0/4)
0% (0/4)
0% (0/864)
0% (0/184)

src.document
100% (4/4)
100% (4/4)
61% (1936/3179)
48% (1407/2945)

src.export
0% (0/4)
0% (0/4)
0% (0/121)
0% (0/156)

src.include.ktexteditor
78% (14/18)
78% (14/18)
83% (189/227)
55% (125/226)

src.inputmode
100% (8/8)
100% (8/8)
63% (192/304)
51% (39/77)

src.mode
88% (7/8)
88% (7/8)
36% (378/1051)
16% (146/891)

src.part
0% (0/1)
0% (0/1)
0% (0/7)
100% (0/0)

src.printing
0% (0/4)
0% (0/4)
0% (0/862)
0% (0/278)

src.render
100% (8/8)
100% (8/8)
77% (950/1227)
67% (610/914)

src.schema
22% (2/9)
22% (2/9)
1% (19/1472)
1% (6/625)

src.script
 

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

2020-06-08 Thread Christoph Cullmann
cullmann added a comment.


  That depends.
  If somebody else would test this and we can agree that this is a nicer way to 
hard-code breeze icons compared to having that code in kiconthemes it would 
make sense.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25119

To: cullmann, #frameworks, vonreth, dfaure, rempt, ndavis, mart, alex-l
Cc: wrobelda, davidedmundson, broulik, rempt, kde-frameworks-devel, LeGast00n, 
cblack, michaelh, ngraham, bruns


Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

2020-06-07 Thread Christoph Cullmann

On 2020-05-25 16:34, Christoph Cullmann wrote:

On 2020-05-25 16:29, David Faure wrote:

Isn't this fixed by
https://codereview.qt-project.org/c/qt/qtdeclarative/+/300911
?

(This fix happened because I reported this ktexteditor CI ASAN failure 
to

Simon Haussman, who fixed qtdeclarative)

IIUC all that's missing is a backport of the fix to 5.14.x, right?
I just left a note in the above gerrit MR to suggest such a backport.


See the comment there.

I think we should skip Qt 5.14 in the CI and just go to the "final"
Qt 5.15 release.

Would that be feasible?

Greetings
Christoph



Hi,

that could be, I did miss that report and did only find the one below.
(https://bugreports.qt.io/browse/QTBUG-84363)

From the backtrace, QTBUG-84363 looks a lot like our crash reports we 
got

in our bugs, too.

I have at the moment here no 5.15 compile/install to test that out.

Greetings
Christoph



Cheers,
David.

On samedi 23 mai 2020 15:08:28 CEST Christoph Cullmann wrote:

Hi,

I did a bit research, I think this might be

https://bugreports.qt.io/browse/QTBUG-84363

=> This makes actually Qt 5.14 completely unusable for
KTextEditor/Kate/KWrite/.

I run into this kind of crashs during normal editing, too :(

I still have no 5.15 build with the fix here, will need to 
investigate

that more.

Seems other users stumble on this for all parts of our products, e.g.

https://bugs.kde.org/show_bug.cgi?id=415872
https://bugs.kde.org/show_bug.cgi?id=414768

Greetings
Christoph

On 2020-05-21 13:09, CI System wrote:
> BUILD UNSTABLE
>
> Build URL
>
>https://build.kde.org/job/Frameworks/job/ktexteditor/

job/kf5-qt5%20SUSEQ

>t5.14/19/>
> Project:
>kf5-qt5 SUSEQt5.14
>
> Date of build:
>Thu, 21 May 2020 10:51:54 +
>
> Build duration:
>17 min and counting
>
> BUILD ARTIFACTS
>
>* abi-compatibility-results.yaml [1]
>* acc/KF5TextEditor-5.71.0.xml [2]
>* compat_reports/KF5TextEditor_compat_report.html [3]
>* logs/KF5TextEditor/5.71.0/log.txt [4]
>
> JUnit Tests
>
>Name: (root) Failed: 0 test(s), Passed: 1 test(s),

Skipped: 0

>
> test(s), Total: 1 test(s)
>
>Name: projectroot Failed: 3 test(s), Passed: 59

test(s), Skipped: 0

>
> test(s), Total: 62 test(s)
>
>* Failed: projectroot.autotests.bug313759
>
>* Failed: projectroot.autotests.kateindenttest_testAda
>
>* Failed: projectroot.autotests.kateindenttest_testPascal
>
>Name: projectroot.autotests.src Failed: 0 test(s),

Passed: 5

>
> test(s), Skipped: 0 test(s), Total: 5 test(s)
>
> Cobertura Report
>
> Project Coverage Summary
>
> Name
>
>Packages
>Files
>Classes
>Lines
>Conditionals
>
>Cobertura Coverage Report
>79% (22/28)
>87% (260/298)
>87% (260/298)
>67% (32994/49195)
>49% (14791/30094)
>
>Coverage Breakdown by Package
>
> Name
>
>Files
>Classes
>Lines
>Conditionals
>
>autotests.src
>97% (37/38)
>97% (37/38)
>93% (4785/5127)
>49% (1812/3680)
>
>autotests.src.vimode
>100% (9/9)
>100% (9/9)
>99% (5526/5568)
>58% (984/1708)
>
>src.buffer
>88% (15/17)
>88% (15/17)
>89% (1677/1892)
>74% (1082/1472)
>
>src.completion
>100% (11/11)
>100% (11/11)
>57% (1785/3131)
>42% (1008/2423)
>
>src.completion.expandingtree
>100% (3/3)
>100% (3/3)
>40% (182/457)
>21% (73/340)
>
>src.dialogs
>0% (0/4)
>0% (0/4)
>0% (0/858)
>0% (0/180)
>
>src.document
>100% (4/4)
>100% (4/4)
>61% (1934/3176)
>48% (1417/2977)
>
>src.export
>0% (0/4)
>0% (0/4)
>0% (0/121)
>0% (0/156)
>
>src.include.ktexteditor
>93% (14/15)
>93% (14/15)
>84% (187/222)
>55% (125/226)
>
>src.inputmode
>100% (8/8)
>100% (8/8)
>63% (192/304)
>51% (39/77)
>
>src.mode
>88% (7/8)

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

2020-05-25 Thread Christoph Cullmann

On 2020-05-25 16:29, David Faure wrote:

Isn't this fixed by
https://codereview.qt-project.org/c/qt/qtdeclarative/+/300911
?

(This fix happened because I reported this ktexteditor CI ASAN failure 
to

Simon Haussman, who fixed qtdeclarative)

IIUC all that's missing is a backport of the fix to 5.14.x, right?
I just left a note in the above gerrit MR to suggest such a backport.


Hi,

that could be, I did miss that report and did only find the one below.
(https://bugreports.qt.io/browse/QTBUG-84363)

From the backtrace, QTBUG-84363 looks a lot like our crash reports we 
got

in our bugs, too.

I have at the moment here no 5.15 compile/install to test that out.

Greetings
Christoph



Cheers,
David.

On samedi 23 mai 2020 15:08:28 CEST Christoph Cullmann wrote:

Hi,

I did a bit research, I think this might be

https://bugreports.qt.io/browse/QTBUG-84363

=> This makes actually Qt 5.14 completely unusable for
KTextEditor/Kate/KWrite/.

I run into this kind of crashs during normal editing, too :(

I still have no 5.15 build with the fix here, will need to investigate
that more.

Seems other users stumble on this for all parts of our products, e.g.

https://bugs.kde.org/show_bug.cgi?id=415872
https://bugs.kde.org/show_bug.cgi?id=414768

Greetings
Christoph

On 2020-05-21 13:09, CI System wrote:
> BUILD UNSTABLE
>
> Build URL
>
>https://build.kde.org/job/Frameworks/job/ktexteditor/

job/kf5-qt5%20SUSEQ

>t5.14/19/>
> Project:
>kf5-qt5 SUSEQt5.14
>
> Date of build:
>Thu, 21 May 2020 10:51:54 +
>
> Build duration:
>17 min and counting
>
> BUILD ARTIFACTS
>
>* abi-compatibility-results.yaml [1]
>* acc/KF5TextEditor-5.71.0.xml [2]
>* compat_reports/KF5TextEditor_compat_report.html [3]
>* logs/KF5TextEditor/5.71.0/log.txt [4]
>
> JUnit Tests
>
>Name: (root) Failed: 0 test(s), Passed: 1 test(s),

Skipped: 0

>
> test(s), Total: 1 test(s)
>
>Name: projectroot Failed: 3 test(s), Passed: 59

test(s), Skipped: 0

>
> test(s), Total: 62 test(s)
>
>* Failed: projectroot.autotests.bug313759
>
>* Failed: projectroot.autotests.kateindenttest_testAda
>
>* Failed: projectroot.autotests.kateindenttest_testPascal
>
>Name: projectroot.autotests.src Failed: 0 test(s),

Passed: 5

>
> test(s), Skipped: 0 test(s), Total: 5 test(s)
>
> Cobertura Report
>
> Project Coverage Summary
>
> Name
>
>Packages
>Files
>Classes
>Lines
>Conditionals
>
>Cobertura Coverage Report
>79% (22/28)
>87% (260/298)
>87% (260/298)
>67% (32994/49195)
>49% (14791/30094)
>
>Coverage Breakdown by Package
>
> Name
>
>Files
>Classes
>Lines
>Conditionals
>
>autotests.src
>97% (37/38)
>97% (37/38)
>93% (4785/5127)
>49% (1812/3680)
>
>autotests.src.vimode
>100% (9/9)
>100% (9/9)
>99% (5526/5568)
>58% (984/1708)
>
>src.buffer
>88% (15/17)
>88% (15/17)
>89% (1677/1892)
>74% (1082/1472)
>
>src.completion
>100% (11/11)
>100% (11/11)
>57% (1785/3131)
>42% (1008/2423)
>
>src.completion.expandingtree
>100% (3/3)
>100% (3/3)
>40% (182/457)
>21% (73/340)
>
>src.dialogs
>0% (0/4)
>0% (0/4)
>0% (0/858)
>0% (0/180)
>
>src.document
>100% (4/4)
>100% (4/4)
>61% (1934/3176)
>48% (1417/2977)
>
>src.export
>0% (0/4)
>0% (0/4)
>0% (0/121)
>0% (0/156)
>
>src.include.ktexteditor
>93% (14/15)
>93% (14/15)
>84% (187/222)
>55% (125/226)
>
>src.inputmode
>100% (8/8)
>100% (8/8)
>63% (192/304)
>51% (39/77)
>
>src.mode
>88% (7/8)
>88% (7/8)
>36% (378/1050)
>16% (146/897)
>
>src.part
>0% (0/1)
>0% (0/1)
>0% (0/7)
>100

Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.14 - Build # 19 - Still Unstable!

2020-05-23 Thread Christoph Cullmann

Hi,

I did a bit research, I think this might be

https://bugreports.qt.io/browse/QTBUG-84363

=> This makes actually Qt 5.14 completely unusable for 
KTextEditor/Kate/KWrite/.


I run into this kind of crashs during normal editing, too :(

I still have no 5.15 build with the fix here, will need to investigate 
that more.


Seems other users stumble on this for all parts of our products, e.g.

https://bugs.kde.org/show_bug.cgi?id=415872
https://bugs.kde.org/show_bug.cgi?id=414768

Greetings
Christoph

On 2020-05-21 13:09, CI System wrote:

BUILD UNSTABLE

 Build URL

https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.14/19/

 Project:
kf5-qt5 SUSEQt5.14

 Date of build:
Thu, 21 May 2020 10:51:54 +

 Build duration:
17 min and counting

 BUILD ARTIFACTS

* abi-compatibility-results.yaml [1]
* acc/KF5TextEditor-5.71.0.xml [2]
* compat_reports/KF5TextEditor_compat_report.html [3]
* logs/KF5TextEditor/5.71.0/log.txt [4]

 JUnit Tests

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0
test(s), Total: 1 test(s)

Name: projectroot Failed: 3 test(s), Passed: 59 test(s), 
Skipped: 0
test(s), Total: 62 test(s)

* Failed: projectroot.autotests.bug313759

* Failed: projectroot.autotests.kateindenttest_testAda

* Failed: projectroot.autotests.kateindenttest_testPascal

Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5
test(s), Skipped: 0 test(s), Total: 5 test(s)

 Cobertura Report

 Project Coverage Summary

 Name
Packages
Files
Classes
Lines
Conditionals

Cobertura Coverage Report
79% (22/28)
87% (260/298)
87% (260/298)
67% (32994/49195)
49% (14791/30094)

Coverage Breakdown by Package

 Name
Files
Classes
Lines
Conditionals

autotests.src
97% (37/38)
97% (37/38)
93% (4785/5127)
49% (1812/3680)

autotests.src.vimode
100% (9/9)
100% (9/9)
99% (5526/5568)
58% (984/1708)

src.buffer
88% (15/17)
88% (15/17)
89% (1677/1892)
74% (1082/1472)

src.completion
100% (11/11)
100% (11/11)
57% (1785/3131)
42% (1008/2423)

src.completion.expandingtree
100% (3/3)
100% (3/3)
40% (182/457)
21% (73/340)

src.dialogs
0% (0/4)
0% (0/4)
0% (0/858)
0% (0/180)

src.document
100% (4/4)
100% (4/4)
61% (1934/3176)
48% (1417/2977)

src.export
0% (0/4)
0% (0/4)
0% (0/121)
0% (0/156)

src.include.ktexteditor
93% (14/15)
93% (14/15)
84% (187/222)
55% (125/226)

src.inputmode
100% (8/8)
100% (8/8)
63% (192/304)
51% (39/77)

src.mode
88% (7/8)
88% (7/8)
36% (378/1050)
16% (146/897)

src.part
0% (0/1)
0% (0/1)
0% (0/7)
100% (0/0)

src.printing
0% (0/4)
0% (0/4)
0% (0/862)
0% (0/278)

src.render
100% (7/7)
100% (7/7)
77% (949/1226)
67% (611/916)

src.schema
29% (2/7)
29% (2/7)
1% (19/1468)
1% (6/625)

src.script
100% (16/16)
100% (16/16)
67% (698/1038)
53% (212/403)

src.search
100% (7/7)
100% (7/7)
74% (/1503)
63% (590/932)

src.spellcheck
57% (4/7)
57% (4/7)
7% (82/1205)
3% (19/696)

src.swapfile
50% (1/2)
50% (1/2)
32% (119/374)
 

D28235: Add a simpler example

2020-05-22 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  ;=) Actually, I just missed this request, sorry.
  
  I think there is no issue with have an extra example.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28235

To: apol, vkrause, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann


D29793: Rename Perl6 syntax to Raku

2020-05-18 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I think it makes sense to have just "Raku", the world at large (like me) only 
recognizes Perl 5 as Perl .P

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  rename-perl6-raku

REVISION DETAIL
  https://phabricator.kde.org/D29793

To: nibags, #framework_syntax_highlighting, #kate, jpoelen, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D29795: Add collaboration guide

2020-05-18 Thread Christoph Cullmann
cullmann added a comment.


  I think this is very good thing to have.
  But perhaps we just should add that to the README.md that is prominently 
shown on e.g. https://invent.kde.org/frameworks/syntax-highlighting
  The README anyways already contains a "Adding unit tests for a syntax 
definition" that could be replaced with this.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29795

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D29789: Make text always align with font base line

2020-05-18 Thread Christoph Cullmann
cullmann closed this revision.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D29789

To: xuetianweng, rjvbb, dhaumann, cullmann
Cc: brauch, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D29789: Make text always align with font base line

2020-05-18 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Hmm, looks better for me, too.
  Let's go with this at the moment.
  If it creates issues, we can still revert it again.
  Thanks for taking care of this.
  
  For the option: some option to allow people to adjust the spacing for e.g. 
better readability is fine (if it works), to have some option that people need 
to fiddle with to have correct rendering at all sounds bad.

REPOSITORY
  R39 KTextEditor

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29789

To: xuetianweng, rjvbb, dhaumann, cullmann
Cc: brauch, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

2020-05-15 Thread Christoph Cullmann
cullmann added a comment.


  Sure, thanks for the improvement!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29735

To: bewuethr, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, 
demsking, vkrause, sars


D29735: Assign "Identifier" attribute to opening double quote instead of "Comment"

2020-05-15 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:f804af905ef3: Assign Identifier attribute to 
opening double quote instead of Comment (authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29735?vs=82808=82955

REVISION DETAIL
  https://phabricator.kde.org/D29735

AFFECTED FILES
  data/syntax/sql-postgresql.xml

To: bewuethr, #framework_syntax_highlighting, dhaumann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, gennad, bmortimer, domson, michaelh, genethomas, ngraham, bruns, 
demsking, vkrause, sars


D27844: Store and fetch complete view config in and from session config

2020-05-15 Thread Christoph Cullmann
cullmann added a comment.


  Hmm, right, didn't think about that :(
  Guess if we want to have this, we need to improve the read/writeConfig 
functions.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27844

To: kossebau, #kate, loh.tar, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D25339: update lineHeight if boundingRect indicates a larger value.

2020-05-09 Thread Christoph Cullmann
cullmann added a comment.


  F8304597: lineheight.patch 
  
  see e.g. here for a start of using the right heights inside the renderer.
  
  for a dynamically wrapped line, the lines before the last one get now the 
right height for me.
  
  But there are a lot more places to handle.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: ahmadsamir, brauch, sars, pshinjo, rjvbb, fakefred, anthonyfieroni, 
kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, dhaumann


D25339: update lineHeight if boundingRect indicates a larger value.

2020-05-09 Thread Christoph Cullmann
cullmann added a comment.


  In D25339#666877 , @rjvbb wrote:
  
  > >   Looking at the code, might it make more sense to just move away from 
the fixed height we have?
  > >   It isn't used that often and in most cases one could just query the 
height of the current line.
  >
  > I'd be all for that, provided it doesn't introduce any regressions in the 
rendered result nor in rendering time.
  >
  > It could be trickier to implement than you think though?
  
  
  It is a non-trivial change.
  But I think any other change, like this, will lead to issues, too, and is 
just a "hack".
  
  I have taken a closer look.
  I assume the lineHeight usages in the renderer are easy to replace with the 
proper "height()" of the individual lines of the layout.
  
  Harder to replace is the use of the lineHeight outside of the renderer.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: ahmadsamir, brauch, sars, pshinjo, rjvbb, fakefred, anthonyfieroni, 
kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, dhaumann


D29354: Bash: fix comments after escapes

2020-05-09 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:1e8466029c82: Bash: fix comments after escapes (authored 
by nibags, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29354?vs=81718=82360

REVISION DETAIL
  https://phabricator.kde.org/D29354

AFFECTED FILES
  autotests/folding/highlight.sh.fold
  autotests/html/highlight.sh.html
  autotests/input/highlight.sh
  autotests/reference/highlight.sh.ref
  autotests/reference/test.bb.ref
  data/syntax/bash.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D29354: Bash: fix comments after escapes

2020-05-09 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Same here ;=) Thanks a lot for the work on all this issues!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-comments-bash

REVISION DETAIL
  https://phabricator.kde.org/D29354

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END

2020-05-09 Thread Christoph Cullmann
cullmann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  fix-folding-latex

REVISION DETAIL
  https://phabricator.kde.org/D29521

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END

2020-05-09 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:0b6c88cfc167: LaTeX: fix folding in \end{...} and in 
regions markers BEGIN-END (authored by nibags, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29521?vs=82244=82359

REVISION DETAIL
  https://phabricator.kde.org/D29521

AFFECTED FILES
  autotests/folding/example.rmd.fold
  autotests/folding/highlight.tex.fold
  autotests/html/highlight.tex.html
  autotests/input/highlight.tex
  autotests/reference/highlight.tex.ref
  data/syntax/latex.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D29521: LaTeX: fix folding in \end{...} and in regions markers BEGIN-END

2020-05-09 Thread Christoph Cullmann
cullmann added a comment.


  Looks fine for me, thanks for improvement!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D29521

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D25339: update lineHeight if boundingRect indicates a larger value.

2020-05-09 Thread Christoph Cullmann
cullmann added a comment.


  Looking at the code, might it make more sense to just move away from the 
fixed height we have?
  It isn't used that often and in most cases one could just query the height of 
the current line.
  That would solve this issue without needing any hacks for the rendering I 
think.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks, rjvbb
Cc: ahmadsamir, brauch, sars, pshinjo, rjvbb, fakefred, anthonyfieroni, 
kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, dhaumann


D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

2020-04-26 Thread Christoph Cullmann
cullmann added a reviewer: Frameworks.
cullmann added a comment.


  I tried the current version.
  For me this looks OK now.
  Thought I would like to have more people trying this out before we merge.
  Some volunteers?
  
  Beside this: Thanks for working on this issue.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann, #frameworks
Cc: anthonyfieroni, kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, 
cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28870: Updated test file for Logtalk syntax highlighting

2020-04-25 Thread Christoph Cullmann
cullmann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D28870

To: pmoura, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28870: Updated test file for Logtalk syntax highlighting

2020-04-25 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:559cda73cf57: Updated test file for Logtalk syntax 
highlighting (authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28870?vs=80253=81174

REVISION DETAIL
  https://phabricator.kde.org/D28870

AFFECTED FILES
  autotests/input/highlight.lgt

To: pmoura, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28796: Update Logtalk language syntax support

2020-04-25 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:bf2664ea7907: Update Logtalk language syntax support 
(authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28796?vs=80017=81172

REVISION DETAIL
  https://phabricator.kde.org/D28796

AFFECTED FILES
  data/syntax/logtalk.xml

To: pmoura, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann


D28796: Update Logtalk language syntax support

2020-04-25 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok, I see, there is an extra request for the new hl test file.
  Then let's approve this one.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D28796

To: pmoura, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann


D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

2020-04-19 Thread Christoph Cullmann
cullmann added a comment.


  Hmm, after applying this patch, for me, no text is visible at all.
  By selecting a bit stuff, one at least sees an outline (CMakeLists.txt of 
ktexteditor toplevel dir).
  
  F8246692: kwrite_no_text.png 

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann
Cc: anthonyfieroni, kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, 
cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D25339: KateRenderer: Use representitive character in CJK to estimate the fontHeight.

2020-04-18 Thread Christoph Cullmann
cullmann added a comment.


  I appreciate work on this issue.
  I am not sure about how well this "hack" will solve the issue, thought.
  I will give it a try here in any case.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D25339

To: xuetianweng, #ktexteditor, cullmann, dhaumann
Cc: anthonyfieroni, kde-frameworks-devel, kwrite-devel, rrosch, LeGast00n, 
cblack, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28814: TypeScript: add the "awaited" type operator

2020-04-15 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:1f1f03198aa7: TypeScript: add the awaited 
type operator (authored by nibags, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28814?vs=80064=80222

REVISION DETAIL
  https://phabricator.kde.org/D28814

AFFECTED FILES
  autotests/folding/test.ts.fold
  autotests/html/test.ts.html
  autotests/input/test.ts
  autotests/reference/test.ts.ref
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28814: TypeScript: add the "awaited" type operator

2020-04-15 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks ;=) Even with test.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-awaited-typescript

REVISION DETAIL
  https://phabricator.kde.org/D28814

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, 
michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28796: Update Logtalk language syntax support

2020-04-15 Thread Christoph Cullmann
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Change looks reasonable, but could that testfile be added to our autotests 
directory? (or the file we have there extended)
  The current auto test file is autotests/input/highlight.lgt I assume.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D28796

To: pmoura, dhaumann, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
domson, michaelh, ngraham, bruns, demsking, sars, dhaumann


D27844: Store and fetch complete view config in and from session config

2020-04-10 Thread Christoph Cullmann
cullmann added a comment.


  Yes, please push, thanks!

REPOSITORY
  R39 KTextEditor

BRANCH
  fullviewconfigsessionsupport

REVISION DETAIL
  https://phabricator.kde.org/D27844

To: kossebau, #kate, loh.tar, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28303: LaTeX: fix math parentheses in optional labels

2020-03-26 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:213d4bb197a3: LaTeX: fix math parentheses in optional 
labels (authored by nibags, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28303?vs=78536=78562

REVISION DETAIL
  https://phabricator.kde.org/D28303

AFFECTED FILES
  autotests/folding/highlight.tex.fold
  autotests/html/highlight.tex.html
  autotests/input/highlight.tex
  autotests/reference/highlight.tex.ref
  data/syntax/latex.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28303: LaTeX: fix math parentheses in optional labels

2020-03-26 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks for the fix + regression test!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  update-latex

REVISION DETAIL
  https://phabricator.kde.org/D28303

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann, jpoelen
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D27660: Add Inno Setup syntax, including embedded Pascal scripting

2020-03-26 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:517dccc95ecf: Add Inno Setup syntax, including embedded 
Pascal scripting (authored by zrax, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27660?vs=77133=78551

REVISION DETAIL
  https://phabricator.kde.org/D27660

AFFECTED FILES
  autotests/folding/setup.iss.fold
  autotests/html/setup.iss.html
  autotests/input/setup.iss
  autotests/reference/setup.iss.ref
  data/syntax/innosetup.xml

To: zrax, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D27660: Add Inno Setup syntax, including embedded Pascal scripting

2020-03-26 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Cool +1 ;=)
  Thanks for the contribution.
  We use that at company, nice to have.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  innosetup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27660

To: zrax, #framework_syntax_highlighting, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28045: Lua: add # as additional deliminator to activate auto-completion with `#something`

2020-03-14 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:b2ace3e804ad: Lua: add # as additional deliminator to 
activate auto-completion with… (authored by jpoelen, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28045?vs=77617=77618

REVISION DETAIL
  https://phabricator.kde.org/D28045

AFFECTED FILES
  data/syntax/lua.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28045: Lua: add # as additional deliminator to activate auto-completion with `#something`

2020-03-14 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok ;=)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  lua (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28045

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28044: C: remove ' as digit separator

2020-03-14 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:755904a6ff2e: C: remove  as digit separator 
(authored by jpoelen, committed by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28044?vs=77614=77615#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28044?vs=77614=77615

REVISION DETAIL
  https://phabricator.kde.org/D28044

AFFECTED FILES
  data/syntax/c.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28044: C: remove ' as digit separator

2020-03-14 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  True, guess I copied too large parts during my fix-up of this.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  c (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28044

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28039: optimize dynamic regex matching

2020-03-14 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:764957b1d23c: optimize dynamic regex matching (authored 
by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28039?vs=77593=77613

REVISION DETAIL
  https://phabricator.kde.org/D28039

AFFECTED FILES
  src/lib/abstracthighlighter.cpp
  src/lib/rule.cpp
  src/lib/rule_p.h

To: cullmann, dhaumann, vkrause, nibags
Cc: mwolff, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28039: optimize dynamic regex matching

2020-03-14 Thread Christoph Cullmann
cullmann added a comment.


  First let's have this, the current state is bad ;=)

INLINE COMMENTS

> dhaumann wrote in rule_p.h:126
> I dislike this protected hack :-)

That is called inheritance ;=)
I first had a virtual function, but this is much easier and faster. (and just 
costs a few bytes)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28039

To: cullmann, dhaumann, vkrause, nibags
Cc: mwolff, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28039: optimize dynamic regex matching

2020-03-13 Thread Christoph Cullmann
cullmann added a comment.


  For the example from the bug this makes the difference between ~30 seconds on 
a 4 Ghz machine to << 1 second ;=)

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D28039

To: cullmann, dhaumann, vkrause, nibags
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28039: optimize dynamic regex matching

2020-03-13 Thread Christoph Cullmann
cullmann created this revision.
cullmann added reviewers: dhaumann, vkrause, nibags.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  allow such matches to be cached, too, by guarding the cache
  with the last used captures
  
  makes VHDL highlighting instantanious for bug 418778
  
  BUG: 418778

TEST PLAN
  make && make test
  
  example from bug 418778 is fast!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28039

AFFECTED FILES
  src/lib/abstracthighlighter.cpp
  src/lib/rule.cpp
  src/lib/rule_p.h

To: cullmann, dhaumann, vkrause, nibags
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

2020-03-13 Thread Christoph Cullmann
cullmann added a comment.


  Better, but VHDL hl is still very slow, need to take a deeper look into it :/

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D28015

To: cullmann, nibags, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

2020-03-13 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:e6090be50f0d: extend indexer to detect dynamic=true 
regexes that have no place holders to… (authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28015?vs=77526=77590

REVISION DETAIL
  https://phabricator.kde.org/D28015

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: cullmann, nibags, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

2020-03-13 Thread Christoph Cullmann
cullmann added a comment.


  Yes, I will fix the issues and then commit this as one thingy.
  Thanks for taking a look :=)
  My colleague was very unhappy with the VHDL performance :P
  The highlighting shouldn't take as long as a hardware simulator.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28015

To: cullmann, nibags, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

2020-03-12 Thread Christoph Cullmann
cullmann updated this revision to Diff 77526.
cullmann added a comment.


  remove useless output of stray azOffset var

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28015?vs=77525=77526

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28015

AFFECTED FILES
  src/indexer/katehighlightingindexer.cpp

To: cullmann, nibags, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

2020-03-12 Thread Christoph Cullmann
cullmann added reviewers: nibags, dhaumann, vkrause.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D28015

To: cullmann, nibags, dhaumann, vkrause
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D28015: extend indexer to detect dynamic=true regexes that have no place holders to adapt

2020-03-12 Thread Christoph Cullmann
cullmann created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
cullmann requested review of this revision.

REVISION SUMMARY
  see bug 418778
  
  VHDL highlighting is very slow as close to all regexes are marked as dynamic
  but most have no place holders used at all
  now the checker detects that
  
  if nobody objects to the logic of this check (I might be confused about other 
side-effects of dynamic),
  then I will adapt the below faults and adjust this request

TEST PLAN
  make && make test
  
  >
  =
  
  
"/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/doxygenlua.xml"
 line 246 broken regex: "--\\[(=*)\\[" problem: dynamic=true but no %\d+ 
placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/latex.xml" 
line 405 broken regex: "(.)" problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/latex.xml" 
line 418 broken regex: "(.)" problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/lua.xml" 
line 472 broken regex: "\\[(=*)\\[" problem: dynamic=true but no %\d+ 
placeholder -1
  
"/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/metafont.xml" 
line 917 broken regex: "(.)" problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/sass.xml" 
line 140 broken regex: "(\\s+)(?=/[*/])" problem: dynamic=true but no %\d+ 
placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/sass.xml" 
line 141 broken regex: "()/[*/]" problem: dynamic=true but no %\d+ placeholder 
-1
  
"/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/sql-postgresql.xml"
 line 1013 broken regex: "\\$([^\\$\\n\\r]*)\\$" problem: dynamic=true but no 
%\d+ placeholder -1
  
"/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/sql-postgresql.xml"
 line 1023 broken regex: "\\$([^\\$\\n\\r]*)\\$" problem: dynamic=true but no 
%\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 222 broken regex: 
"(\\b)architecture\\s+(\\b(?!(?:process|constant|signal|variable))([A-Za-z_][A-Za-z0-9_]*)\\b)\\b"
 problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 226 broken regex: 
"(\\b)package\\s+(\\b(?!(?:process|constant|signal|variable))([A-Za-z_][A-Za-z0-9_]*)\\b)\\s+is\\b"
 problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 228 broken regex: 
"(\\b)package\\s+body\\s+(\\b(?!(?:process|constant|signal|variable))([A-Za-z_][A-Za-z0-9_]*)\\b)\\s+is\\b"
 problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 231 broken regex: 
"(\\b)configuration\\s+(\\b(?!(?:process|constant|signal|variable))([A-Za-z_][A-Za-z0-9_]*)\\b)\\b"
 problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 272 broken regex: 
"(\\b)function\\s+(\\b(?!(?:process|constant|signal|variable))([A-Za-z_][A-Za-z0-9_]*)\\b)\\b"
 problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 287 broken regex: "(\\b)end(\\s+function)?\\b" problem: dynamic=true but 
no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 300 broken regex: 
"(\\b)architecture\\s+(\\b(?!(?:process|constant|signal|variable))([A-Za-z_][A-Za-z0-9_]*)\\b)\\s+of\\s+(\\b(?!(?:process|constant|signal|variable))([A-Za-z_][A-Za-z0-9_]*)\\b)\\s+is"
 problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 304 broken regex: 
"(\\b)end(\\s+architecture)?(\\s+\\b(?!(?:process|constant|signal|variable))([A-Za-z_][A-Za-z0-9_]*)\\b)\\s*;"
 problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 337 broken regex: "(\\b)end(\\s+function)?\\b" problem: dynamic=true but 
no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 349 broken regex: 
"(\\b)(\\b(?!(?:process|constant|signal|variable))([A-Za-z_][A-Za-z0-9_]*)\\b\\s*:\\s*)(if|for).*\\s+generate\\b"
 problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 351 broken regex: 
"(\\b)(\\b(?!(?:process|constant|signal|variable))([A-Za-z_][A-Za-z0-9_]*)\\b\\s*:\\s*)?process\\b"
 problem: dynamic=true but no %\d+ placeholder -1
  "/home/cullmann/projects/kde/src/syntax-highlighting/data/syntax/vhdl.xml" 
line 353 broken regex: 

D27844: Store and fetch complete view config in and from session config

2020-03-12 Thread Christoph Cullmann
cullmann added a comment.


  Zoom is like all view stuff local, yes, I assume that is often not wanted.
  But that is a orthogonal issue.
  The same could be said for "dynamic word wrap", very seldom you want to set 
that for one view.
  On the other side, for the global config, one has the settings dialog, same 
for "zoom", aka font size.

REPOSITORY
  R39 KTextEditor

BRANCH
  fullviewconfigsessionsupport

REVISION DETAIL
  https://phabricator.kde.org/D27844

To: kossebau, #kate, loh.tar, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D27929: CMake syntax fixes

2020-03-12 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:39ad168cf350: CMake syntax fixes (authored by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27929?vs=77200=77524

REVISION DETAIL
  https://phabricator.kde.org/D27929

AFFECTED FILES
  data/generators/cmake.xml.tpl
  data/generators/cmake.yaml
  data/syntax/cmake.xml

To: turbov, #framework_syntax_highlighting, dhaumann
Cc: dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars


D27928: [VIM Mode] Add g g commands

2020-03-12 Thread Christoph Cullmann
cullmann added a comment.


  And btw., thanks a lot for taking care!
  The vimode for sure has more need for love, if you have time ;=)

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27928

To: gikari, #kate, #frameworks, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars


D27928: [VIM Mode] Add g g commands

2020-03-12 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:736844969d2b: [VIM Mode] Add gup gdown 
commands (authored by gikari, committed by cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27928?vs=77355=77523

REVISION DETAIL
  https://phabricator.kde.org/D27928

AFFECTED FILES
  autotests/src/vimode/keys.cpp
  src/vimode/modes/normalvimode.cpp
  src/vimode/modes/visualvimode.cpp

To: gikari, #kate, #frameworks, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars


D27928: [VIM Mode] Add g g commands

2020-03-12 Thread Christoph Cullmann
cullmann accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R39 KTextEditor

BRANCH
  g-up-g-down-commands (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27928

To: gikari, #kate, #frameworks, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars


D27928: [VIM Mode] Add g g commands

2020-03-12 Thread Christoph Cullmann
cullmann added a comment.


  I think, one issue is, that  and  don't work that way in the test 
framework.
  I reformulated the test with \down and \up and moved the asserts to verifies.
  This works for me, will push this, please take a look if that is ok for you, 
too.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27928

To: gikari, #kate, #frameworks
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars


D27928: [VIM Mode] Add g g commands

2020-03-11 Thread Christoph Cullmann
cullmann added a comment.


  I will try to take a look as soon as I have time, if nobody else is faster.
  Just to confirm: Your newly added test case doesn't pass or some other test 
case randomly fails?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27928

To: gikari, #kate, #frameworks
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars


D27912: Draw inlineNotes after drawing word wrap marker

2020-03-07 Thread Christoph Cullmann
cullmann closed this revision.
cullmann added a comment.


  Hmm, yes, seems to work again.
  Let's close this then again.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27912

To: davidre, #ktexteditor, brauch
Cc: cullmann, brauch, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann


Re: KDE CI: Frameworks » ktexteditor » kf5-qt5 SUSEQt5.12 - Build # 313 - Unstable!

2020-03-07 Thread Christoph Cullmann

Hi,

think the change

https://phabricator.kde.org/D27912

is responsible for this, re-opened that request again.

Greetings
Christoph

On 2020-03-07 16:53, CI System wrote:

BUILD UNSTABLE

 Build URL

https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/313/

 Project:
kf5-qt5 SUSEQt5.12

 Date of build:
Sat, 07 Mar 2020 15:43:42 +

 Build duration:
9 min 45 sec and counting

 BUILD ARTIFACTS

* abi-compatibility-results.yaml [1]
* acc/KF5TextEditor-5.68.0.xml [2]
* compat_reports/KF5TextEditor_compat_report.html [3]
* logs/KF5TextEditor/5.68.0/log.txt [4]

 JUnit Tests

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0
test(s), Total: 1 test(s)

Name: projectroot Failed: 1 test(s), Passed: 61 test(s), 
Skipped: 0
test(s), Total: 62 test(s)

* Failed: projectroot.autotests.inlinenote_test

Name: projectroot.autotests.src Failed: 0 test(s), Passed: 5
test(s), Skipped: 0 test(s), Total: 5 test(s)

 Cobertura Report

 Project Coverage Summary

 Name
Packages
Files
Classes
Lines
Conditionals

Cobertura Coverage Report
79% (22/28)
88% (263/298)
88% (263/298)
68% (33258/49174)
50% (14968/30054)

Coverage Breakdown by Package

 Name
Files
Classes
Lines
Conditionals

autotests.src
100% (38/38)
100% (38/38)
93% (4776/5130)
49% (1789/3680)

autotests.src.vimode
100% (9/9)
100% (9/9)
99% (5503/5545)
58% (970/1680)

src.buffer
88% (15/17)
88% (15/17)
90% (1700/1892)
75% (1103/1472)

src.completion
100% (11/11)
100% (11/11)
57% (1785/3131)
42% (1008/2423)

src.completion.expandingtree
100% (3/3)
100% (3/3)
40% (182/457)
21% (73/340)

src.dialogs
0% (0/4)
0% (0/4)
0% (0/855)
0% (0/180)

src.document
100% (4/4)
100% (4/4)
61% (1943/3170)
48% (1430/2965)

src.export
0% (0/4)
0% (0/4)
0% (0/121)
0% (0/156)

src.include.ktexteditor
93% (14/15)
93% (14/15)
91% (201/220)
65% (145/224)

src.inputmode
100% (8/8)
100% (8/8)
63% (192/304)
51% (39/77)

src.mode
88% (7/8)
88% (7/8)
36% (378/1050)
16% (146/897)

src.part
0% (0/1)
0% (0/1)
0% (0/7)
100% (0/0)

src.printing
0% (0/4)
0% (0/4)
0% (0/862)
0% (0/278)

src.render
100% (7/7)
100% (7/7)
77% (947/1224)
67% (612/916)

src.schema
29% (2/7)
29% (2/7)
1% (19/1468)
1% (6/625)

src.script
100% (16/16)
100% (16/16)
69% (716/1038)
56% (226/403)

src.search
100% (7/7)
100% (7/7)
74% (/1503)
63% (590/932)

src.spellcheck
86% (6/7)
86% (6/7)
29% (359/1222)
25% (177/696)

src.swapfile
50% (1/2)
50% (1/2)
32% (119/371)
32% (64/203)

src.syntax
88% (7/8)
88% (7/8)
65% (492/761)
37% (211/576)

src.undo
100% (5/5)
100% (5/5)
88% (652/741)
73% (276/378)

src.utils
95% (36/38)
95% (36/38)
63% (2390/3797)
45% (1009/2266)

src.variableeditor

D27912: Draw inlineNotes after drawing word wrap marker

2020-03-07 Thread Christoph Cullmann
cullmann reopened this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Hi, could it be that killed the inline notes autotest?
  
  
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/313/

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D27912

To: davidre, #ktexteditor, brauch
Cc: cullmann, brauch, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, 
cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann


D27533: Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

2020-03-07 Thread Christoph Cullmann
cullmann added a comment.


  Thanks for working on this.
  Badly scaled stuff is a real eyesore...

REPOSITORY
  R39 KTextEditor

BRANCH
  addmarkinterfacev2

REVISION DETAIL
  https://phabricator.kde.org/D27533

To: kossebau, #kate, #kdevelop, dhaumann, cullmann
Cc: cullmann, anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, 
rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, 
sars


D27893: Use fallback also on Windows not only mac

2020-03-07 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:1b93a366da68: Use fallback also on Windows not only mac 
(authored by vonreth, committed by cullmann).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27893?vs=77095=77176

REVISION DETAIL
  https://phabricator.kde.org/D27893

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: vonreth, broulik, bcooksley, jjazeix, cullmann
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27893: Use fallback also on Windows not only mac

2020-03-07 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.


  Ok, let's have that be in ;=)

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27893

To: vonreth, broulik, bcooksley, jjazeix, cullmann
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27797: Agda: keywords updated to 2.6.0 and fix float points

2020-03-07 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:6903aff4ef92: Agda: keywords updated to 2.6.0 and fix 
float points (authored by nibags, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27797?vs=76814=77175

REVISION DETAIL
  https://phabricator.kde.org/D27797

AFFECTED FILES
  autotests/folding/test.agda.fold
  autotests/html/test.agda.html
  autotests/input/test.agda
  autotests/reference/test.agda.ref
  data/syntax/agda.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D27797: Agda: keywords updated to 2.6.0 and fix float points

2020-03-07 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks for taking care of this!
  Let's get that in.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  update-agda

REVISION DETAIL
  https://phabricator.kde.org/D27797

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D27844: Store and fetch complete view config in and from session config

2020-03-07 Thread Christoph Cullmann
cullmann accepted this revision as: cullmann.
cullmann added a comment.
This revision is now accepted and ready to land.


  Hmm, actually not sure why we didn't do that before.
  I think this change makes sense.
  Perhaps Dominik has some idea why we didn't do that in the past?
  I myself think this change makes sense, but let's wait for Dominik's feedback 
before going forward.

REPOSITORY
  R39 KTextEditor

BRANCH
  fullviewconfigsessionsupport

REVISION DETAIL
  https://phabricator.kde.org/D27844

To: kossebau, #kate, loh.tar, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D27430: [PATCH] General update for CartoCSS syntax highlighting

2020-03-02 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:c13aa9c31167: [PATCH] General update for CartoCSS syntax 
highlighting (authored by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27430?vs=75757=76793#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27430?vs=75757=76793

REVISION DETAIL
  https://phabricator.kde.org/D27430

AFFECTED FILES
  autotests/folding/test.mss.fold
  autotests/html/test.mss.html
  autotests/input/test.mss
  autotests/reference/test.mss.ref
  data/syntax/carto-css.xml

To: sommer, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
gennad, GB_2, bmortimer, domson, michaelh, genethomas, ngraham, bruns, 
demsking, vkrause, sars, dhaumann


D26211: Port QRegExp to QRegularExpression

2020-03-01 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks, guess that should go in now.

REPOSITORY
  R246 Sonnet

BRANCH
  l-qregularexpression (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26211

To: ahmadsamir, cullmann, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D26211: Port QRegExp to QRegularExpression

2020-02-29 Thread Christoph Cullmann
cullmann requested changes to this revision.
cullmann added a comment.
This revision now requires changes to proceed.


  Actually, one can re-use this regex for all files by moving it before the 
scope of the loop, or?
  The match on the other side is allocated per match() call, I would just move 
that inside the inner stuff and just do some
  const auto match = rx

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D26211

To: ahmadsamir, cullmann, apol
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27693: Add syntax highlighting for Java Properties

2020-02-29 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks for this addition and the MIT licensing!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  add-java-properties

REVISION DETAIL
  https://phabricator.kde.org/D27693

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D27692: TypeScript: add private fields and type-only imports/exports, and some fixes

2020-02-29 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:0daf938b0660: TypeScript: add private fields and 
type-only imports/exports, and some fixes (authored by nibags, committed by 
cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27692?vs=76518=76703

REVISION DETAIL
  https://phabricator.kde.org/D27692

AFFECTED FILES
  autotests/folding/test.ts.fold
  autotests/folding/test.tsx.fold
  autotests/html/test.ts.html
  autotests/html/test.tsx.html
  autotests/input/test.ts
  autotests/input/test.tsx
  autotests/reference/highlight.php.ref
  autotests/reference/test.htm.ref
  autotests/reference/test.markdown.ref
  autotests/reference/test.ts.ref
  autotests/reference/test.tsx.ref
  data/syntax/typescript-react.xml
  data/syntax/typescript.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D27693: Add syntax highlighting for Java Properties

2020-02-29 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:4a0a0e56cd86: Add syntax highlighting for Java Properties 
(authored by nibags, committed by cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27693?vs=76512=76704

REVISION DETAIL
  https://phabricator.kde.org/D27693

AFFECTED FILES
  autotests/folding/test.properties.fold
  autotests/html/test.properties.html
  autotests/input/test.properties
  autotests/reference/test.properties.ref
  data/syntax/java-properties.xml

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D27692: TypeScript: add private fields and type-only imports/exports, and some fixes

2020-02-29 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok, let's merge this.
  Thanks for all the work on that!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  update-typescript

REVISION DETAIL
  https://phabricator.kde.org/D27692

To: nibags, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D27430: [PATCH] General update for CartoCSS syntax highlighting

2020-02-28 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok, let's land that.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D27430

To: sommer, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
gennad, GB_2, bmortimer, domson, michaelh, genethomas, ngraham, bruns, 
demsking, vkrause, sars, dhaumann


D27533: [WIP] Add MarkInterfaceV2, to s/QPixmap/QIcon/g for symbols of marks

2020-02-28 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.


  I think this should go in now. I think the usage of the API is correct even 
for HiDPI.
  In KF6, we should just fold that interface into the main class.

REPOSITORY
  R39 KTextEditor

BRANCH
  addmarkinterfacev2

REVISION DETAIL
  https://phabricator.kde.org/D27533

To: kossebau, #kate, #kdevelop, dhaumann, cullmann
Cc: cullmann, anthonyfieroni, dhaumann, kwrite-devel, kde-frameworks-devel, 
rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, 
sars


D27486: Add FreeCAD FCMacro extension to the python highlighting definition

2020-02-28 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:978e23b2c44c: Add FreeCAD FCMacro extension to the python 
highlighting definition (authored by cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27486?vs=75942=76647#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27486?vs=75942=76647

REVISION DETAIL
  https://phabricator.kde.org/D27486

AFFECTED FILES
  data/syntax/python.xml

To: martonmiklos, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann


D27486: Add FreeCAD FCMacro extension to the python highlighting definition

2020-02-28 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Ok, makes sense, will increase version myself.

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D27486

To: martonmiklos, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann


D27580: Updates for CMake 3.17

2020-02-28 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:fb8e0b2777a2: Updates for CMake 3.17 (authored by 
cullmann).

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27580?vs=76182=76646

REVISION DETAIL
  https://phabricator.kde.org/D27580

AFFECTED FILES
  data/generators/cmake.xml.tpl
  data/generators/cmake.yaml
  data/syntax/cmake.xml

To: turbov, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann


D27580: Updates for CMake 3.17

2020-02-28 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Thanks for the update!

REPOSITORY
  R216 Syntax Highlighting

REVISION DETAIL
  https://phabricator.kde.org/D27580

To: turbov, #framework_syntax_highlighting, cullmann
Cc: cullmann, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, 
GB_2, domson, michaelh, ngraham, bruns, demsking, sars, dhaumann


D27714: C++: constinit keyword and std::format syntax for strings. Improvement printf format.

2020-02-28 Thread Christoph Cullmann
This revision was automatically updated to reflect the committed changes.
Closed by commit R216:c41ed480a504: C++: constinit keyword and std::format 
syntax for strings. Improvement printf… (authored by jpoelen, committed by 
cullmann).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27714?vs=76591=76645#toc

REPOSITORY
  R216 Syntax Highlighting

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27714?vs=76591=76645

REVISION DETAIL
  https://phabricator.kde.org/D27714

AFFECTED FILES
  autotests/folding/highlight.cpp.fold
  autotests/html/highlight.cpp.html
  autotests/input/highlight.cpp
  autotests/reference/highlight.cpp.ref
  data/syntax/isocpp.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


D27714: C++: constinit keyword and std::format syntax for strings. Improvement printf format.

2020-02-28 Thread Christoph Cullmann
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  Nice! Thanks for the improvements ;=)

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  cpp (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27714

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, 
domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann


  1   2   3   4   5   6   7   8   9   10   >