Re: Review Request 128193: Deploy the khtml kxmlgui file in a Qt resource file.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128193/ --- (Updated June 16, 2016, 6:10 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Christoph Cullmann and Martin Tobias Holmedahl Sandsmark. Changes --- Submitted with commit cbded94e49340f01467f37b103760c00ec52f30d by Cristian One? to branch master. Repository: khtml Description --- KXmlGui has support for this and this is the recommended way of making a framework platform independent. Diffs - src/CMakeLists.txt a1b90a13abe8e0681087745db1416316bd04f0ac src/khtml.qrc PRE-CREATION Diff: https://git.reviewboard.kde.org/r/128193/diff/ Testing --- Used khtml in KMyMoney on OSX, the rc file was properly located. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128193: Deploy the khtml kxmlgui file in a Qt resource file.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128193/ --- (Updated June 16, 2016, 6:08 a.m.) Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Changes --- Merge the two files under the same qresource element. Repository: khtml Description --- KXmlGui has support for this and this is the recommended way of making a framework platform independent. Diffs (updated) - src/CMakeLists.txt a1b90a13abe8e0681087745db1416316bd04f0ac src/khtml.qrc PRE-CREATION Diff: https://git.reviewboard.kde.org/r/128193/diff/ Testing --- Used khtml in KMyMoney on OSX, the rc file was properly located. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128202: Fix problem with install prefix & application bundles
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128202/#review96550 --- +1 I also noticed this issue. - Cristian Oneț On June 15, 2016, 11:02 p.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128202/ > --- > > (Updated June 15, 2016, 11:02 p.m.) > > > Review request for KDE Frameworks and David Faure. > > > Repository: extra-cmake-modules > > > Description > --- > > Current behavior: Even if you have some own installation prefix like emerge, > ECM assumes all stuff in the global /Applications/KDE > This doesn't work as stuff like kded5 is not found after installation. > Making it relative resolves this issue. > > > Diffs > - > > kde-modules/KDEInstallDirs.cmake f518a4a > > Diff: https://git.reviewboard.kde.org/r/128202/diff/ > > > Testing > --- > > emerge okular works a bit more with this patch, e.g. kde4support is able to > detect kded5. > > > Thanks, > > Christoph Cullmann > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128193: Deploy the khtml kxmlgui file in a Qt resource file.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128193/ --- (Updated June 15, 2016, 8:39 p.m.) Review request for KDE Frameworks, Christoph Cullmann and Martin Tobias Holmedahl Sandsmark. Changes --- Fixed typo. Repository: khtml Description --- KXmlGui has support for this and this is the recommended way of making a framework platform independent. Diffs (updated) - src/CMakeLists.txt a1b90a13abe8e0681087745db1416316bd04f0ac src/khtml.qrc PRE-CREATION Diff: https://git.reviewboard.kde.org/r/128193/diff/ Testing --- Used khtml in KMyMoney on OSX, the rc file was properly located. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128193: Deploy the khtml kxmlgui file in a Qt resource file.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128193/ --- (Updated June 15, 2016, 8:36 p.m.) Review request for KDE Frameworks and Martin Tobias Holmedahl Sandsmark. Changes --- Handle khtml_browser.rc also. Repository: khtml Description --- KXmlGui has support for this and this is the recommended way of making a framework platform independent. Diffs (updated) - src/CMakeLists.txt a1b90a13abe8e0681087745db1416316bd04f0ac src/khtml.qrc PRE-CREATION Diff: https://git.reviewboard.kde.org/r/128193/diff/ Testing --- Used khtml in KMyMoney on OSX, the rc file was properly located. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 128193: Deploy the khtml kxmlgui file in a Qt resource file.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128193/ --- Review request for KDE Frameworks, Christoph Cullmann and Martin Tobias Holmedahl Sandsmark. Repository: khtml Description --- KXmlGui has support for this and this is the recommended way of making a framework platform independent. Diffs - src/CMakeLists.txt a1b90a13abe8e0681087745db1416316bd04f0ac src/khtml.qrc PRE-CREATION Diff: https://git.reviewboard.kde.org/r/128193/diff/ Testing --- Used khtml in KMyMoney on OSX, the rc file was properly located. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Supporting MSVC2010 in ktexteditor framework
2014-11-05 9:58 GMT+02:00 Martin Graesslin mgraess...@kde.org: On Wednesday 05 November 2014 08:53:42 Mirko Boehm wrote: Hi, On 05 Nov 2014, at 04:33, Nicolás Alvarez nicolas.alva...@gmail.com wrote: So, I hereby propose making an exception and bumping the minimum compiler version *for ktexteditor only* to MSVC2012. Opinions? I propose to bump the required compiler versions across the board to compilers that fully 100% implement C++11. It is 2014 and C++14 is finalised. And we are a Free Software project and none of our compilers have any problems with that. I support this. I'm currently facing the problem that at some point we might want kwayland to become a framework to be able to be used in kwindowsystem. But the compiler requirements would not allow it, although it doesn't make any sense for the case of kwayland (nobody is going to use that on Windows). So in stead of adding one exception after the other, just go the full way and raise the requirement. The fact that we don't have a CI to test it just shows even more that we need to raise the minimum requirement. +1, we came to this conclusion when we discussed this issue at Randa (in the KDE SDK group), C++11 rules out MSVC 2010 and there is really no reason to keep backward compatibility. Regards, Cristian Cheers Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Suggestion to ntroduce an application for testing config paths and access to files installed by cmake or created at runtime
Hi, I would like to add that the Windows platform has similar issues QStandardPaths does not match with the paths were cmake installs these files. As a temporary workaround we use this dirty hack [1] (patch Qt) to add the paths where cmake installs stuff to QStandardPaths. We also need to setup the QT_PLUGIN_PATH environment variable which we would need to avoid when deploying applications because, unlike Linux on Windows there is nobody to do it (no KDE session that launches the rest of the applications). Since the two platforms are in kind of the same situation I would like to see a similar solution to these problems. Regards, Cristian [1] https://projects.kde.org/projects/kdesupport/emerge/repository/entry/portage/libs/qt5/qtbase/qtbase-20130714.patch?rev=master 2014-08-22 10:21 GMT+03:00 Marko Käning mk-li...@email.de: Hi devs, in the light of RR 119895 [1] I wanted to ask whether you guys could perhaps come up with a dedicated little test application which should be able to verify all possible file accesses to configs, plugins, read-only and writable data. For the manipulation of QStandardPaths on OSX it would be nice to have such a tool to verify that 1) files installed by cmake indeed land where the application expects them at runtime 2) and that files created at runtime go to where they should go according to the various cmake config variables. 3) all these files can be located and created in a real KF5 installation as well as on a CI system which makes use of isolated install directories for each individual framework/application This would be a runtime test for files installed to locations like - CMAKE_INSTALL_BUNDLEDIR - DATA_INSTALL_DIR - KF5_LIBEXEC_INSTALL_DIR - CMAKE_INSTALL_KXMLGUI5DIR - etc. (don’t know which other ones might be needed, probably a few more!) What do you think about a small test application for this general purpose? Or, can I have that functionality from existing tests of specific frameworks already now? Greets, Marko [1] http://mail.kde.org/pipermail/kde-frameworks-devel/2014-August/018481.html ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kmymoney fails to build on branch framework
Hi Marko, Could you post the whole build log, or search for the 'error:' marker (you just posted a warning). When building in parallel the error could be somewhere in the middle of the build log. Last night I broke the build but it was fixed in the meantime so could you try it again? Regards, Cristian 2014-08-12 0:22 GMT+03:00 Marko Käning mk-li...@email.de: Why is the build failing here with an Alarm clock”? --- /Users/marko/WC/KDECI-builds/kmymoney/kmymoney/views/kmymoneyview.cpp:2287:16: warning: 'KIcon' is deprecated [-Wdeprecated-declarations] frm-setIcon(KIcon(icon)); ^ /opt/kde/install/darwin/mavericks/clang/kf5-qt5/frameworks/kdelibs4support/inst/include/KF5/KDELibs4Support/kicon.h:46:41: note: 'KIcon' declared here class KDELIBS4SUPPORT_DEPRECATED_EXPORT KIcon : public QIcon ^ 55 warnings generated. make[1]: *** [kmymoney/views/CMakeFiles/views.dir/all] Alarm clock: 14 make: *** [all] Error 2 make: INTERNAL: Exiting with 1 jobserver tokens available; should be 7! KDE Continuous Integration Build == Building Project: kmymoney - Branch frameworks ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 119714: Fix the build on Windows using MSVC 2013
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119714/ --- Review request for KDE Frameworks, Christoph Cullmann and Joseph Wenninger. Repository: ktexteditor Description --- The compiler was complaining about ambiguous method resolution using QAbstractItemModel::createIndex (because of the last parameter) so just remove it since QAbstractItemModel::createIndex has a default value for the last parameter in one of the overloads which is just what it's needed. Diffs - src/completion/katekeywordcompletion.cpp e30a64d7de3be0f6470303024b0fd0fc034a12dd Diff: https://git.reviewboard.kde.org/r/119714/diff/ Testing --- Built and run kate. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119714: Fix the build on Windows using MSVC 2013
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119714/ --- (Updated Aug. 11, 2014, 3:46 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Christoph Cullmann and Joseph Wenninger. Repository: ktexteditor Description --- The compiler was complaining about ambiguous method resolution using QAbstractItemModel::createIndex (because of the last parameter) so just remove it since QAbstractItemModel::createIndex has a default value for the last parameter in one of the overloads which is just what it's needed. Diffs - src/completion/katekeywordcompletion.cpp e30a64d7de3be0f6470303024b0fd0fc034a12dd Diff: https://git.reviewboard.kde.org/r/119714/diff/ Testing --- Built and run kate. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119365: Fix the build of KHtml on Windows using MSVC 2013
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119365/ --- (Updated Aug. 1, 2014, 6:27 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, kdewin and Martin Tobias Holmedahl Sandsmark. Repository: khtml Description --- This patch addresses these build issues: 1. Some Qt5::X11Extras were not properly guarded. 2. KDEWin is needed on Windows for 'unistd.h' and others. 3. 'fmod' migth be a macro which will screw up calls to std::fmod Diffs - CMakeLists.txt de34f3c8d7479811d536fbce2114f29a96693087 src/CMakeLists.txt bc7534667d6a39b334d038d55391e784c6527b1c src/html/html_canvasimpl.cpp 18990eaa7ab00316471ecec0e9aa30b394aa4e02 tests/CMakeLists.txt d672fb56feb52da7308e844e0c86460e11778c07 Diff: https://git.reviewboard.kde.org/r/119365/diff/ Testing --- Build run on Windows and Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 119365: Fix the build of KHtml on Windows using MSVC 2013
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119365/ --- Review request for KDE Frameworks, kdewin and Martin Tobias Holmedahl Sandsmark. Repository: khtml Description --- This patch addresses these build issues: 1. Some Qt5::X11Extras were not properly guarded. 2. KDEWin is needed on Windows for 'unistd.h' and others. 3. 'fmod' migth be a macro which will screw up calls to std::fmod Diffs - CMakeLists.txt de34f3c8d7479811d536fbce2114f29a96693087 src/CMakeLists.txt bc7534667d6a39b334d038d55391e784c6527b1c src/html/html_canvasimpl.cpp 18990eaa7ab00316471ecec0e9aa30b394aa4e02 tests/CMakeLists.txt d672fb56feb52da7308e844e0c86460e11778c07 Diff: https://git.reviewboard.kde.org/r/119365/diff/ Testing --- Build run on Windows and Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119275: Fix: Same variable in camelCase and REQUIRED_HEADERS doesn't export all headers
On July 14, 2014, 10:57 p.m., Aleix Pol Gonzalez wrote: Is this because of the usage of list(APPEND)? Maybe using set(.. PARENT_SCOPE) for appending would do the trick as well? Andreas Xavier wrote: Can you confirm that you are seeing the same problem? This is my first time trying to compile KF5 and the problem is most likely to be with my setup. If I know that everyone is experiencing the problem, then I will try to fix it in ecm using set( .. PARENT_SCOPE). I remember running into something similar while building using kdesrc-build. I just suspected that it's something related to my setup since it went away once I manually ran 'make install' from the build directory created by kdesrc-build. While building on Windows using emerge I didn't see this though. - Cristian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119275/#review62358 --- On July 14, 2014, 6 p.m., Andreas Xavier wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119275/ --- (Updated July 14, 2014, 6 p.m.) Review request for KDE Frameworks, Alex Merry and Michael Pyne. Repository: kcoreaddons Description --- Using the same variable name for var1 and var2 in the new ecm_generate_headers() syntax, when it is called more than once only exports the headers from the first invokation of ecm_generate_headers(), where var1 and var2 are defined as follows. ecm_generate_headers(var1 ... REQUIRED_HEADERS var2 ) It doesn't show up in existing builds because cmake doesn't delete old header files. Steps to Replicate the Problem: 1. Delete the existing header files for KCoreAddons and the existing build files. rm -r $KF5/KcoreAddons rm -r your kcoreaddons/build directory 2. Re-build kcoreaddons from a new build dir cmake -DCMAKE_INSTALL_PREFIX=$KF5 .. 3. Check in $KF5/KcoreAddons and there should only be these headers: KAboutData kaboutdata.h kcoreaddons_export.h Solution: This patch solves the problem by changing the name of var2 to KCoreAddons_HEADERS_lowercase and exporting both KCoreAddons_HEADERS and KCoreAddons_HEADERS_lowercase. Extended Solution: If this patch is approved, then I will 1. Submit patches to the other frameworks using ecm_generate_headers() in this fashion. 2. submit a patch to extra-cmake-modules to warn when var1 and var2 have the same name. Diffs - src/lib/CMakeLists.txt 26eb5a1 Diff: https://git.reviewboard.kde.org/r/119275/diff/ Testing --- Compiled kcoreaddons, then checked that all headers generated and exported. Ran unittests. Thanks, Andreas Xavier ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119275: Fix: Same variable in camelCase and REQUIRED_HEADERS doesn't export all headers
On Iulie 14, 2014, 10:57 p.m., Aleix Pol Gonzalez wrote: Is this because of the usage of list(APPEND)? Maybe using set(.. PARENT_SCOPE) for appending would do the trick as well? Andreas Xavier wrote: Can you confirm that you are seeing the same problem? This is my first time trying to compile KF5 and the problem is most likely to be with my setup. If I know that everyone is experiencing the problem, then I will try to fix it in ecm using set( .. PARENT_SCOPE). Cristian Oneț wrote: I remember running into something similar while building using kdesrc-build. I just suspected that it's something related to my setup since it went away once I manually ran 'make install' from the build directory created by kdesrc-build. While building on Windows using emerge I didn't see this though. Alex Merry wrote: I can't reproduce this (and, additionally, the [CI system](http://build.kde.org) does a completely clean build and install every time). Can you post the output of `cmake --version`, please? Andreas Xavier wrote: Entirely my mistake. All of frameworks compiled with no changes. Thank you for taking the time to look at this. I am now running with : cmake version 3.0.20140712-g2eadd1 One nameless Konsole tab over I was running with : cmake version 2.8.12.2 It might be worth noting that with the changes in this patch cmake 2.8.12.2 was able to compile frameworks all the way to KHTML with no complaints. Clearly, I am a cmake novice, but if this patch doesn't break the build with 3.0 and it makes it possible to build it with 2.8.12.2 it might make the overall build more robust. Once again thanks for your time. Michael Pyne wrote: I'll look into whether kdesrc-build is failing on the first-ever-build use case, there's a recently-opened bug about it (bug 337446) so it's very possible. Now this is starting to make sense to me, altough kdesrc-build using extragear/utils/kdesrc-build/kf5-qt5-build-include builds cmake-git maybe it was using up cmake from my system which is 2.8.12.2 and was causing this problem. - Cristian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119275/#review62358 --- On Iulie 15, 2014, 9:36 p.m., Andreas Xavier wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119275/ --- (Updated Iulie 15, 2014, 9:36 p.m.) Review request for KDE Frameworks, Alex Merry and Michael Pyne. Repository: kcoreaddons Description --- Using the same variable name for var1 and var2 in the new ecm_generate_headers() syntax, when it is called more than once only exports the headers from the first invokation of ecm_generate_headers(), where var1 and var2 are defined as follows. ecm_generate_headers(var1 ... REQUIRED_HEADERS var2 ) It doesn't show up in existing builds because cmake doesn't delete old header files. Steps to Replicate the Problem: 1. Delete the existing header files for KCoreAddons and the existing build files. rm -r $KF5/KcoreAddons rm -r your kcoreaddons/build directory 2. Re-build kcoreaddons from a new build dir cmake -DCMAKE_INSTALL_PREFIX=$KF5 .. 3. Check in $KF5/KcoreAddons and there should only be these headers: KAboutData kaboutdata.h kcoreaddons_export.h Solution: This patch solves the problem by changing the name of var2 to KCoreAddons_HEADERS_lowercase and exporting both KCoreAddons_HEADERS and KCoreAddons_HEADERS_lowercase. Extended Solution: If this patch is approved, then I will 1. Submit patches to the other frameworks using ecm_generate_headers() in this fashion. 2. submit a patch to extra-cmake-modules to warn when var1 and var2 have the same name. Diffs - src/lib/CMakeLists.txt 26eb5a1 Diff: https://git.reviewboard.kde.org/r/119275/diff/ Testing --- Compiled kcoreaddons, then checked that all headers generated and exported. Ran unittests. Thanks, Andreas Xavier ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)
On July 13, 2014, 11:17 a.m., Mark Gaiser wrote: src/core/udsentry.cpp, line 72 https://git.reviewboard.kde.org/r/119247/diff/2/?file=289937#file289937line72 I'm not sure if this is the correct approach either. When i'm looking at file.cpp (in kio/src/ioslaves/file/file.cpp) then this very same thing is done. So from a mac/linux perspective, this aproach is fine. However, we also have a specific windows implementation file_win.cpp which is in fact filling the username and group via a slightly different mechanism. On Linux/Mac: we use stat calls. Aka, we are completely in control. On Windows we (why?) use QDirIterator. Each entry is then represented as a QFileInfo which in turn is being used to get the details from inclusing user/group. I can see a few approaches that could work: 1. This version where windows is just out of luck. 2. If windows is used, contruct a QFileInfo and get the user/group from there. Windows users will then have more stat calls in this function. Something we should try to prevent. 3. This version and add a new constructor that takes a QFileInfo object - my preference. ... I think we need to wait for David' opinion on this. If David is OK with point 3 then i will create a patch + test and send a RR for it. Waiting for David's opinion about the best way to fix this. - Cristian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/#review62245 --- On July 13, 2014, 8:35 a.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- (Updated July 13, 2014, 8:35 a.m.) Review request for KDE Frameworks and kdewin. Repository: kio Description --- The KUser(K_UID) constructor could not be mached since st_uid is a 'short' which can't be implicitly cast to a pointer type (K_UID is of type void * on Windows). The same applies to KUserGroup. Here is the compiler output: q:\kio\src\core\udsentry.cpp(72) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUser' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(72) : error C2228: left of '.loginName' must have class/struct/union q:\kio\src\core\udsentry.cpp(72) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments q:\kio\src\core\udsentry.cpp(73) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUserGroup' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(73) : error C2228: left of '.name' must have class/struct/union q:\kio\src\core\udsentry.cpp(73) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments Diffs - src/core/udsentry.cpp c6ac21a1f7b45822bc3454409faf3dbdce7b2acc Diff: https://git.reviewboard.kde.org/r/119247/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- (Updated July 14, 2014, 5:33 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and kdewin. Repository: kio Description --- The KUser(K_UID) constructor could not be mached since st_uid is a 'short' which can't be implicitly cast to a pointer type (K_UID is of type void * on Windows). The same applies to KUserGroup. Here is the compiler output: q:\kio\src\core\udsentry.cpp(72) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUser' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(72) : error C2228: left of '.loginName' must have class/struct/union q:\kio\src\core\udsentry.cpp(72) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments q:\kio\src\core\udsentry.cpp(73) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUserGroup' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(73) : error C2228: left of '.name' must have class/struct/union q:\kio\src\core\udsentry.cpp(73) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments Diffs - src/core/udsentry.cpp c6ac21a1f7b45822bc3454409faf3dbdce7b2acc Diff: https://git.reviewboard.kde.org/r/119247/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- (Updated Iulie 13, 2014, 8:35 a.m.) Review request for KDE Frameworks and kdewin. Repository: kio Description --- The KUser(K_UID) constructor could not be mached since st_uid is a 'short' which can't be implicitly cast to a pointer type (K_UID is of type void * on Windows). The same applies to KUserGroup. Here is the compiler output: q:\kio\src\core\udsentry.cpp(72) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUser' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(72) : error C2228: left of '.loginName' must have class/struct/union q:\kio\src\core\udsentry.cpp(72) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments q:\kio\src\core\udsentry.cpp(73) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUserGroup' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(73) : error C2228: left of '.name' must have class/struct/union q:\kio\src\core\udsentry.cpp(73) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments Diffs - src/core/udsentry.cpp c6ac21a1f7b45822bc3454409faf3dbdce7b2acc Diff: https://git.reviewboard.kde.org/r/119247/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- (Updated Iulie 13, 2014, 8:35 a.m.) Review request for KDE Frameworks. Changes --- Ifdef away the UDS_USER and UDS_GROUP lines. Repository: kio Description --- The KUser(K_UID) constructor could not be mached since st_uid is a 'short' which can't be implicitly cast to a pointer type (K_UID is of type void * on Windows). The same applies to KUserGroup. Here is the compiler output: q:\kio\src\core\udsentry.cpp(72) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUser' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(72) : error C2228: left of '.loginName' must have class/struct/union q:\kio\src\core\udsentry.cpp(72) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments q:\kio\src\core\udsentry.cpp(73) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUserGroup' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(73) : error C2228: left of '.name' must have class/struct/union q:\kio\src\core\udsentry.cpp(73) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments Diffs (updated) - src/core/udsentry.cpp c6ac21a1f7b45822bc3454409faf3dbdce7b2acc Diff: https://git.reviewboard.kde.org/r/119247/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- Review request for KDE Frameworks. Repository: kio Description --- The KUser(K_UID) constructor could not be mached since st_uid is a 'short' which can't be implicitly cast to a pointer type (K_UID is of type void * on Windows). The same applies to KUserGroup. Diffs - src/core/udsentry.cpp c6ac21a1f7b45822bc3454409faf3dbdce7b2acc Diff: https://git.reviewboard.kde.org/r/119247/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- (Updated Iulie 12, 2014, 2:01 p.m.) Review request for KDE Frameworks. Changes --- Added compiler output. Repository: kio Description (updated) --- The KUser(K_UID) constructor could not be mached since st_uid is a 'short' which can't be implicitly cast to a pointer type (K_UID is of type void * on Windows). The same applies to KUserGroup. Here is the compiler output: q:\kio\src\core\udsentry.cpp(72) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUser' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(72) : error C2228: left of '.loginName' must have class/struct/union q:\kio\src\core\udsentry.cpp(72) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments q:\kio\src\core\udsentry.cpp(73) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUserGroup' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(73) : error C2228: left of '.name' must have class/struct/union q:\kio\src\core\udsentry.cpp(73) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments Diffs - src/core/udsentry.cpp c6ac21a1f7b45822bc3454409faf3dbdce7b2acc Diff: https://git.reviewboard.kde.org/r/119247/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/ --- Review request for KDE Frameworks. Repository: kio Description --- IS_ISDIR and S_ISREG are not defined in Visual Studio's 'sys/stat.h'. The macros are defined in kdewin's 'sys/stat.h' but including stat.h will use the file provided Visual Studio so I chose this approach which is also used in Qt. Here is the compiler output: kshorturifilter.cpp q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(389) : error C3861: 'S_ISDIR': identifier not found q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(399) : error C3861: 'S_ISREG': identifier not found Diffs - src/urifilters/shorturi/kshorturifilter.cpp 8341829 Diff: https://git.reviewboard.kde.org/r/119248/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- (Updated Iulie 12, 2014, 2:20 p.m.) Review request for KDE Frameworks and kdewin. Changes --- Add kdewin to the groups. Repository: kio Description --- The KUser(K_UID) constructor could not be mached since st_uid is a 'short' which can't be implicitly cast to a pointer type (K_UID is of type void * on Windows). The same applies to KUserGroup. Here is the compiler output: q:\kio\src\core\udsentry.cpp(72) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUser' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(72) : error C2228: left of '.loginName' must have class/struct/union q:\kio\src\core\udsentry.cpp(72) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments q:\kio\src\core\udsentry.cpp(73) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUserGroup' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(73) : error C2228: left of '.name' must have class/struct/union q:\kio\src\core\udsentry.cpp(73) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments Diffs - src/core/udsentry.cpp c6ac21a1f7b45822bc3454409faf3dbdce7b2acc Diff: https://git.reviewboard.kde.org/r/119247/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/ --- (Updated Iulie 12, 2014, 2:20 p.m.) Review request for KDE Frameworks and kdewin. Changes --- Add kdewin to the groups. Repository: kio Description --- IS_ISDIR and S_ISREG are not defined in Visual Studio's 'sys/stat.h'. The macros are defined in kdewin's 'sys/stat.h' but including stat.h will use the file provided Visual Studio so I chose this approach which is also used in Qt. Here is the compiler output: kshorturifilter.cpp q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(389) : error C3861: 'S_ISDIR': identifier not found q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(399) : error C3861: 'S_ISREG': identifier not found Diffs - src/urifilters/shorturi/kshorturifilter.cpp 8341829 Diff: https://git.reviewboard.kde.org/r/119248/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/ --- Review request for KDE Frameworks and kdewin. Repository: kdelibs4support Description --- Let me begin by saying that this review request was started to highlight current build issues using MSVC 2013 in order to get some feedback about the best way to fix them. That's why I'll explain each issue that was fixed as a comment in the diff (I'll add the comments after I'll publish the review request, it's the only way I can add them). Here is a list of issues: 1. r:\include\QtCore/qlist.h(300) : error C2678: binary '==' : no operator found which takes a left-hand operand of type 'const KNetwork::KResolverEntry' 2. error C2375: 'KCrash::defaultCrashHandler' : redefinition; different linkage 3. error C2487: 'identifier' : member of dll interface class may not be declared with dll interface 4. QStringLiteral does not work when using string concatenation https://bugreports.qt-project.org/browse/QTBUG-28885 5. KEditListBox::CustomEditor linker error caused by missing export Diffs - autotests/kdebug_qcoreapptest.cpp 0bfe5d6f911d3ec6bd6f919a5d666b4eab63e2e8 src/kdecore/k3resolver.h e956c6f05e0fd821bb41dc63bc2f0933b818aafd src/kdemacros.h.cmake c406623401a5e47ecfd45fe135c9f2019f2abe04 src/kdeui/kapplication.cpp 6ffaf6e2c383e781e498b6d2b777366d4c4a53fe src/kdeui/keditlistbox.h e19474b3bb03587421f0afbc20346a8d359417b1 src/kio/netaccess.h 91f3aba055cceddf10a7c48c710356ce04d9939f tests/kprintpreview_test.cpp 79cac037ab38bce89b97e4ede58eb58d821b25f3 Diff: https://git.reviewboard.kde.org/r/119249/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/#review62197 --- src/kdecore/k3resolver.h https://git.reviewboard.kde.org/r/119249/#comment43230 Issue 1: Same as the above. src/kdecore/k3resolver.h https://git.reviewboard.kde.org/r/119249/#comment43231 Issue 1: Same as the above. src/kdemacros.h.cmake https://git.reviewboard.kde.org/r/119249/#comment43229 Issue 1: Use the mechanism discussed here http://lists.kde.org/?l=kde-core-develm=113126965312032w=2 to workaround the full template instantiation issue. src/kdeui/kapplication.cpp https://git.reviewboard.kde.org/r/119249/#comment43232 Issue 2: kaboutdata.h has a forward declaration for being able to declare the namespaced KCrash::defaultCrashHandler as a friend. This is OK until it is included before kcrash.h. MSVC will cosider the first seen declaration (without the export) and will consider the one in kcrash.h a redefinition with different linkage. Please note that this is actually not a KDELibs4Support issue but a KCoreAddons and KCrash interoperability on MSVC issue. src/kdeui/keditlistbox.h https://git.reviewboard.kde.org/r/119249/#comment43233 Issue 5: Nested classes need to be exported to be usable from outside the library (in this case a test). src/kio/netaccess.h https://git.reviewboard.kde.org/r/119249/#comment43234 Issue 3: See http://msdn.microsoft.com/en-us/library/t72ahzw1.aspx Member methods of exported classes should not be exported explicitly. src/kio/netaccess.h https://git.reviewboard.kde.org/r/119249/#comment43235 Issue 3: Same as the above. src/kio/netaccess.h https://git.reviewboard.kde.org/r/119249/#comment43236 Issue 3: Same as the above. src/kio/netaccess.h https://git.reviewboard.kde.org/r/119249/#comment43237 Issue 3: Same as the above. src/kio/netaccess.h https://git.reviewboard.kde.org/r/119249/#comment43238 Issue 3: Same as the above. src/kio/netaccess.h https://git.reviewboard.kde.org/r/119249/#comment43239 Issue 3: Same as the above. src/kio/netaccess.h https://git.reviewboard.kde.org/r/119249/#comment43240 Issue 3: Same as the above. src/kio/netaccess.h https://git.reviewboard.kde.org/r/119249/#comment43241 Issue 3: Same as the above. tests/kprintpreview_test.cpp https://git.reviewboard.kde.org/r/119249/#comment43242 Issue 4: QStringLiteral does not work when using string concatenation https://bugreports.qt-project.org/browse/QTBUG-28885 q:\kdelibs4support\tests\kprintpreview_test.cpp(58) : error C2308: concatenating mismatched strings Concatenating wide Lorem ipsum dolor sit amet, consectetur adipiscing elit. with narrow Nam malesuada massa dolor, sed sollicitudin turpiscongue eu. Pellentesque ac risus felis. Etiam scelerisque It's just a test, do we really need QStringLiteral? - Cristian Oneț On Iulie 12, 2014, 5:02 p.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/ --- (Updated Iulie 12, 2014, 5:02 p.m.) Review request for KDE Frameworks and kdewin. Repository: kdelibs4support Description --- Let me begin by saying that this review request was started to highlight current build issues using MSVC 2013 in order to get some feedback about the best way to fix them. That's why I'll explain each issue that was fixed as a comment in the diff (I'll add the comments after I'll publish the review request, it's the only way I can add them). Here is a list of issues: 1. r:\include\QtCore/qlist.h(300) : error C2678: binary '==' : no operator found which takes a left-hand operand of type 'const KNetwork::KResolverEntry' 2. error C2375: 'KCrash::defaultCrashHandler' : redefinition; different linkage 3. error C2487: 'identifier' : member of dll interface class may not be declared with dll interface 4. QStringLiteral does not work when using string concatenation https://bugreports.qt-project.org/browse/QTBUG-28885 5. KEditListBox::CustomEditor linker error caused by missing export Diffs - autotests/kdebug_qcoreapptest.cpp 0bfe5d6f911d3ec6bd6f919a5d666b4eab63e2e8 src/kdecore/k3resolver.h e956c6f05e0fd821bb41dc63bc2f0933b818aafd src/kdemacros.h.cmake c406623401a5e47ecfd45fe135c9f2019f2abe04 src/kdeui/kapplication.cpp 6ffaf6e2c383e781e498b6d2b777366d4c4a53fe src/kdeui/keditlistbox.h e19474b3bb03587421f0afbc20346a8d359417b1 src/kio/netaccess.h 91f3aba055cceddf10a7c48c710356ce04d9939f tests/kprintpreview_test.cpp 79cac037ab38bce89b97e4ede58eb58d821b25f3 Diff: https
Review Request 119251: Fix a conflict with KCrash where the function is declared as exported
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/ --- Review request for KDE Frameworks and kdewin. Repository: kcoreaddons Description --- On MSVC this could cause a compile error if the compiler would see the forward declaration first because it would consider it a redefinition with different linkage. Found while cbuilding KDELibs4Support on Windows using MSVC, see https://git.reviewboard.kde.org/r/119249/ Diffs - src/lib/kaboutdata.h f0f3e12bf353019d86f582416cec90390de00f88 Diff: https://git.reviewboard.kde.org/r/119251/diff/ Testing --- Build with MSVC 2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013
On Iulie 12, 2014, 5:44 p.m., Alex Merry wrote: src/kdeui/kapplication.cpp, lines 22-24 https://git.reviewboard.kde.org/r/119249/diff/1/?file=289763#file289763line22 Ooh, that's a nasty trap. We should fix this in KCoreAddons, not work around it here. Possibly by using Q_DECL_IMPORT in the forward declaration. Opened https://git.reviewboard.kde.org/r/119251/ - Cristian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/#review62198 --- On Iulie 12, 2014, 5:02 p.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/ --- (Updated Iulie 12, 2014, 5:02 p.m.) Review request for KDE Frameworks and kdewin. Repository: kdelibs4support Description --- Let me begin by saying that this review request was started to highlight current build issues using MSVC 2013 in order to get some feedback about the best way to fix them. That's why I'll explain each issue that was fixed as a comment in the diff (I'll add the comments after I'll publish the review request, it's the only way I can add them). Here is a list of issues: 1. r:\include\QtCore/qlist.h(300) : error C2678: binary '==' : no operator found which takes a left-hand operand of type 'const KNetwork::KResolverEntry' 2. error C2375: 'KCrash::defaultCrashHandler' : redefinition; different linkage 3. error C2487: 'identifier' : member of dll interface class may not be declared with dll interface 4. QStringLiteral does not work when using string concatenation https://bugreports.qt-project.org/browse/QTBUG-28885 5. KEditListBox::CustomEditor linker error caused by missing export Diffs - autotests/kdebug_qcoreapptest.cpp 0bfe5d6f911d3ec6bd6f919a5d666b4eab63e2e8 src/kdecore/k3resolver.h e956c6f05e0fd821bb41dc63bc2f0933b818aafd src/kdemacros.h.cmake c406623401a5e47ecfd45fe135c9f2019f2abe04 src/kdeui/kapplication.cpp 6ffaf6e2c383e781e498b6d2b777366d4c4a53fe src/kdeui/keditlistbox.h e19474b3bb03587421f0afbc20346a8d359417b1 src/kio/netaccess.h 91f3aba055cceddf10a7c48c710356ce04d9939f tests/kprintpreview_test.cpp 79cac037ab38bce89b97e4ede58eb58d821b25f3 Diff: https://git.reviewboard.kde.org/r/119249/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/ --- (Updated Iulie 12, 2014, 7:09 p.m.) Review request for KDE Frameworks and kdewin. Repository: kdelibs4support Description --- Let me begin by saying that this review request was started to highlight current build issues using MSVC 2013 in order to get some feedback about the best way to fix them. That's why I'll explain each issue that was fixed as a comment in the diff (I'll add the comments after I'll publish the review request, it's the only way I can add them). Here is a list of issues: 1. r:\include\QtCore/qlist.h(300) : error C2678: binary '==' : no operator found which takes a left-hand operand of type 'const KNetwork::KResolverEntry' 2. error C2375: 'KCrash::defaultCrashHandler' : redefinition; different linkage 3. error C2487: 'identifier' : member of dll interface class may not be declared with dll interface 4. QStringLiteral does not work when using string concatenation https://bugreports.qt-project.org/browse/QTBUG-28885 5. KEditListBox::CustomEditor linker error caused by missing export Diffs - src/kdecore/k3resolver.h e956c6f05e0fd821bb41dc63bc2f0933b818aafd src/kdemacros.h.cmake c406623401a5e47ecfd45fe135c9f2019f2abe04 src/kdeui/keditlistbox.h e19474b3bb03587421f0afbc20346a8d359417b1 src/kio/netaccess.h 91f3aba055cceddf10a7c48c710356ce04d9939f tests/kprintpreview_test.cpp 79cac037ab38bce89b97e4ede58eb58d821b25f3 Diff: https://git.reviewboard.kde.org/r/119249/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/ --- (Updated Iulie 12, 2014, 7:15 p.m.) Review request for KDE Frameworks and kdewin. Changes --- Add KDELIBS4SUPPORT_DEPRECATED instead of KDELIBS4SUPPORT_DEPRECATED_EXPORT to keep the deprecation warning but to remove the export. Repository: kdelibs4support Description --- Let me begin by saying that this review request was started to highlight current build issues using MSVC 2013 in order to get some feedback about the best way to fix them. That's why I'll explain each issue that was fixed as a comment in the diff (I'll add the comments after I'll publish the review request, it's the only way I can add them). Here is a list of issues: 1. r:\include\QtCore/qlist.h(300) : error C2678: binary '==' : no operator found which takes a left-hand operand of type 'const KNetwork::KResolverEntry' 2. error C2375: 'KCrash::defaultCrashHandler' : redefinition; different linkage 3. error C2487: 'identifier' : member of dll interface class may not be declared with dll interface 4. QStringLiteral does not work when using string concatenation https://bugreports.qt-project.org/browse/QTBUG-28885 5. KEditListBox::CustomEditor linker error caused by missing export Diffs (updated) - src/kdecore/k3resolver.h e956c6f05e0fd821bb41dc63bc2f0933b818aafd src/kdemacros.h.cmake c406623401a5e47ecfd45fe135c9f2019f2abe04 src/kdeui/keditlistbox.h e19474b3bb03587421f0afbc20346a8d359417b1 src/kio/netaccess.h 91f3aba055cceddf10a7c48c710356ce04d9939f tests/kprintpreview_test.cpp 79cac037ab38bce89b97e4ede58eb58d821b25f3 Diff: https://git.reviewboard.kde.org/r/119249/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)
On Iulie 12, 2014, 6:54 p.m., David Faure wrote: Doesn't qplatformdefs.h define this already? David Faure wrote: Ah not exactly, but you can use QT_STAT_DIR and QT_STAT_REG. Yeah, that was my other option, I'm going to update the diff. - Cristian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/#review62202 --- On Iulie 12, 2014, 2:20 p.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/ --- (Updated Iulie 12, 2014, 2:20 p.m.) Review request for KDE Frameworks and kdewin. Repository: kio Description --- IS_ISDIR and S_ISREG are not defined in Visual Studio's 'sys/stat.h'. The macros are defined in kdewin's 'sys/stat.h' but including stat.h will use the file provided Visual Studio so I chose this approach which is also used in Qt. Here is the compiler output: kshorturifilter.cpp q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(389) : error C3861: 'S_ISDIR': identifier not found q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(399) : error C3861: 'S_ISREG': identifier not found Diffs - src/urifilters/shorturi/kshorturifilter.cpp 8341829 Diff: https://git.reviewboard.kde.org/r/119248/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/ --- (Updated Iulie 12, 2014, 7:25 p.m.) Review request for KDE Frameworks and kdewin. Changes --- Update using QT_STAT_DIR and QT_STAT_REG. Repository: kio Description --- IS_ISDIR and S_ISREG are not defined in Visual Studio's 'sys/stat.h'. The macros are defined in kdewin's 'sys/stat.h' but including stat.h will use the file provided Visual Studio so I chose this approach which is also used in Qt. Here is the compiler output: kshorturifilter.cpp q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(389) : error C3861: 'S_ISDIR': identifier not found q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(399) : error C3861: 'S_ISREG': identifier not found Diffs (updated) - src/urifilters/shorturi/kshorturifilter.cpp 8341829 Diff: https://git.reviewboard.kde.org/r/119248/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119251: Fix a conflict with KCrash where the function is declared as exported
On Iulie 12, 2014, 7:26 p.m., Alex Merry wrote: src/lib/kaboutdata.h, line 38 https://git.reviewboard.kde.org/r/119251/diff/1/?file=289784#file289784line38 Normally, it goes before the return type. It presumably still works where you put it, but it looks very odd. You're right, sorry about that, but it do works both ways :). - Cristian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/#review62209 --- On Iulie 12, 2014, 7:30 p.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/ --- (Updated Iulie 12, 2014, 7:30 p.m.) Review request for KDE Frameworks. Repository: kcoreaddons Description --- On MSVC this could cause a compile error if the compiler would see the forward declaration first because it would consider it a redefinition with different linkage. Found while cbuilding KDELibs4Support on Windows using MSVC, see https://git.reviewboard.kde.org/r/119249/ Diffs - src/lib/kaboutdata.h f0f3e12bf353019d86f582416cec90390de00f88 Diff: https://git.reviewboard.kde.org/r/119251/diff/ Testing --- Build with MSVC 2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119251: Fix a conflict with KCrash where the function is declared as exported
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/ --- (Updated Iulie 12, 2014, 7:30 p.m.) Review request for KDE Frameworks. Changes --- Fixed issues. Repository: kcoreaddons Description --- On MSVC this could cause a compile error if the compiler would see the forward declaration first because it would consider it a redefinition with different linkage. Found while cbuilding KDELibs4Support on Windows using MSVC, see https://git.reviewboard.kde.org/r/119249/ Diffs (updated) - src/lib/kaboutdata.h f0f3e12bf353019d86f582416cec90390de00f88 Diff: https://git.reviewboard.kde.org/r/119251/diff/ Testing --- Build with MSVC 2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119251: Fix a conflict with KCrash where the function is declared as exported
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/ --- (Updated Iulie 12, 2014, 7:30 p.m.) Review request for KDE Frameworks and kdewin. Changes --- post-review keeps removing kdewin :). Repository: kcoreaddons Description --- On MSVC this could cause a compile error if the compiler would see the forward declaration first because it would consider it a redefinition with different linkage. Found while cbuilding KDELibs4Support on Windows using MSVC, see https://git.reviewboard.kde.org/r/119249/ Diffs - src/lib/kaboutdata.h f0f3e12bf353019d86f582416cec90390de00f88 Diff: https://git.reviewboard.kde.org/r/119251/diff/ Testing --- Build with MSVC 2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/ --- (Updated July 12, 2014, 7:48 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and kdewin. Repository: kdelibs4support Description --- Let me begin by saying that this review request was started to highlight current build issues using MSVC 2013 in order to get some feedback about the best way to fix them. That's why I'll explain each issue that was fixed as a comment in the diff (I'll add the comments after I'll publish the review request, it's the only way I can add them). Here is a list of issues: 1. r:\include\QtCore/qlist.h(300) : error C2678: binary '==' : no operator found which takes a left-hand operand of type 'const KNetwork::KResolverEntry' 2. error C2375: 'KCrash::defaultCrashHandler' : redefinition; different linkage 3. error C2487: 'identifier' : member of dll interface class may not be declared with dll interface 4. QStringLiteral does not work when using string concatenation https://bugreports.qt-project.org/browse/QTBUG-28885 5. KEditListBox::CustomEditor linker error caused by missing export Diffs - src/kdecore/k3resolver.h e956c6f05e0fd821bb41dc63bc2f0933b818aafd src/kdemacros.h.cmake c406623401a5e47ecfd45fe135c9f2019f2abe04 src/kdeui/keditlistbox.h e19474b3bb03587421f0afbc20346a8d359417b1 src/kio/netaccess.h 91f3aba055cceddf10a7c48c710356ce04d9939f tests/kprintpreview_test.cpp 79cac037ab38bce89b97e4ede58eb58d821b25f3 Diff: https://git.reviewboard.kde.org/r/119249/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119251: Fix a conflict with KCrash where the function is declared as exported
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/ --- (Updated July 12, 2014, 7:49 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and kdewin. Repository: kcoreaddons Description --- On MSVC this could cause a compile error if the compiler would see the forward declaration first because it would consider it a redefinition with different linkage. Found while cbuilding KDELibs4Support on Windows using MSVC, see https://git.reviewboard.kde.org/r/119249/ Diffs - src/lib/kaboutdata.h f0f3e12bf353019d86f582416cec90390de00f88 Diff: https://git.reviewboard.kde.org/r/119251/diff/ Testing --- Build with MSVC 2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)
On Iulie 12, 2014, 7:33 p.m., David Faure wrote: Looks good. Grepping for S_ISDIR shows that kdelibs4support has some more (but no other framework does). The rest is in code the is not compiled on Windows or at least MSVC. - Cristian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/#review62213 --- On Iulie 12, 2014, 7:25 p.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/ --- (Updated Iulie 12, 2014, 7:25 p.m.) Review request for KDE Frameworks and kdewin. Repository: kio Description --- IS_ISDIR and S_ISREG are not defined in Visual Studio's 'sys/stat.h'. The macros are defined in kdewin's 'sys/stat.h' but including stat.h will use the file provided Visual Studio so I chose this approach which is also used in Qt. Here is the compiler output: kshorturifilter.cpp q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(389) : error C3861: 'S_ISDIR': identifier not found q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(399) : error C3861: 'S_ISREG': identifier not found Diffs - src/urifilters/shorturi/kshorturifilter.cpp 8341829 Diff: https://git.reviewboard.kde.org/r/119248/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/ --- (Updated July 12, 2014, 7:55 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and kdewin. Repository: kio Description --- IS_ISDIR and S_ISREG are not defined in Visual Studio's 'sys/stat.h'. The macros are defined in kdewin's 'sys/stat.h' but including stat.h will use the file provided Visual Studio so I chose this approach which is also used in Qt. Here is the compiler output: kshorturifilter.cpp q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(389) : error C3861: 'S_ISDIR': identifier not found q:\kio\src\urifilters\shorturi\kshorturifilter.cpp(399) : error C3861: 'S_ISREG': identifier not found Diffs - src/urifilters/shorturi/kshorturifilter.cpp 8341829 Diff: https://git.reviewboard.kde.org/r/119248/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)
On Iulie 12, 2014, 7:58 p.m., Nicolás Alvarez wrote: Windows has no concept of an integer UID/GID, it uses much longer SIDs to identify users. These are not returned by stat (stat always returns zero in the st_uid member). I would just ifdef away the UDS_USER and UDS_GROUP lines on Windows. That's true, but then is theare a reason to have a KUser(K_UID) constructor on Windows? - Cristian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/#review62224 --- On Iulie 12, 2014, 2:20 p.m., Cristian Oneț wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- (Updated Iulie 12, 2014, 2:20 p.m.) Review request for KDE Frameworks and kdewin. Repository: kio Description --- The KUser(K_UID) constructor could not be mached since st_uid is a 'short' which can't be implicitly cast to a pointer type (K_UID is of type void * on Windows). The same applies to KUserGroup. Here is the compiler output: q:\kio\src\core\udsentry.cpp(72) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUser' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(72) : error C2228: left of '.loginName' must have class/struct/union q:\kio\src\core\udsentry.cpp(72) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments q:\kio\src\core\udsentry.cpp(73) : error C2440: 'function-style-cast' : cannot convert from 'const short' to 'KUserGroup' No constructor could take the source type, or constructor overload resolution was ambiguous q:\kio\src\core\udsentry.cpp(73) : error C2228: left of '.name' must have class/struct/union q:\kio\src\core\udsentry.cpp(73) : error C2661: 'KIO::UDSEntry::insert' : no overloaded function takes 1 arguments Diffs - src/core/udsentry.cpp c6ac21a1f7b45822bc3454409faf3dbdce7b2acc Diff: https://git.reviewboard.kde.org/r/119247/diff/ Testing --- Build with msvc2013 on Windows and gcc-4.8.3 on Linux. Thanks, Cristian Oneț ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
