D28307: Fix build of KGantt

[Dag Andersen]

danders accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R478 KDiagram: Libraries for diagrams

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28307

To: apol, #frameworks, danders
Cc: danders

D28307: Fix build of KGantt

[Dag Andersen]

danders added a comment.


  Ummpf, my mistake, it is the GraphicsItem that needs exporting.

REPOSITORY
  R478 KDiagram: Libraries for diagrams

REVISION DETAIL
  https://phabricator.kde.org/D28307

To: apol, #frameworks
Cc: danders

D28304: Use bold italic at 100% for sect4 titles, and bold 100% for sect5 titles

[Dag Andersen]

danders accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R238 KDocTools

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28304

To: yurchor, #documentation, danders
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

D28304: Use bold italic at 100% for sect4 titles, and bold 100% for sect5 titles

[Dag Andersen]

danders added a comment.


  I got the best result (imho) with this:
  div.sect3 h4 {
  
font-size: 100%;
font-weight: bold;
  
  }
  div.sect4 h5 {
  
font-size: 100%;
font-weight: bold;
  
  }
  
  div.sect5 h6 {
  
font-size: 90%;
font-style: italic;
  
  }
  
  Note the 90% for sect5.
  It seems h6 is almost the same as h5, but h7 is *much* smaller, even smaller 
than text.
  Also suspect defult for sect3 id h5, so set it to h4.

REPOSITORY
  R238 KDocTools

REVISION DETAIL
  https://phabricator.kde.org/D28304

To: yurchor, #documentation, danders
Cc: kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, 
fbampaloukas, GB_2, michaelh, ngraham, bruns, skadinna

T3689: Add abi compliance checker to CI

[Dag Andersen]

danders added a comment.


  In T3689#175818 , @knauss wrote:
  
  > So far I understood abi-dumper is something different - I use 
abi-complience-checker to create those dumps.
  
  
  Afaiu abi-dumper is the new way of creating dumps. From home page:
  "This new way is based on the analysis of the debug-info from binary objects. 
It's more reliable, faster and simple way. "
  Any particular reason for not to use abi-dumper? (Just curious)
  
  Anyway, I compiled both stable and unstable versions myself, created dumps 
with abi-dumper and got a clean bill.
  So I'm pretty certain the problem reported on CI is not correct (but I have 
been wrong before).

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss, danders
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Dag Andersen]

danders added a comment.


  Hmmm. do not know how to proceed with this without the actual libs available.
  I have tried building against a new lib and runing with old lib, with no 
problems.
  I was unsuccesful using abi-dumper on the old lib, so cannot check if it 
gives the same output as for  f7f9ca1a7a8bfd550022ca4aafe3bb2985a1bee4 
 
above.
  I guess I have to live with this atm and see how things shape up in the 
furure...

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss, danders
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez

T3689: Add abi compliance checker to CI

[Dag Andersen]

danders added a comment.


  I get ABI error on use of QPair and QSet in kdiagram:
  
https://build.kde.org/job/Calligra/job/kdiagram/job/kf5-qt5%20SUSEQt5.10/8/artifact/compat_reports/KGantt_compat_report.html#Type_Binary_Problems_Medium
  Afaics these lines have not been changed since last release.
  I have added a public getter to the class, but it does not complain about 
that, so...
  Also it does not complain about similar use in calligra (although not 
*exactly* the same, calligra uses other datatypes)
  Can anybody shed any light on this?

TASK DETAIL
  https://phabricator.kde.org/T3689

To: knauss, danders
Cc: danders, davidedmundson, dfaure, kde-frameworks-devel, bcooksley, sysadmin, 
scarlettclark, aacid, knauss, alexeymin, kaning, blazquez