dweatherill added a comment.
I don't have commit access but please let me know if anything else is needed
before it can be merged.
(for submission)
Name: Dan Weatherill
email: dan.weather...@cantab.net
REPOSITORY
R284 KCompletion
REVISION DETAIL
https://phabricator.kde.org
dweatherill added a comment.
I have updated the description to tag relevant bugs
REPOSITORY
R284 KCompletion
REVISION DETAIL
https://phabricator.kde.org/D9808
To: dweatherill, #frameworks, dhaumann, cullmann, dfaure
Cc: ngraham, mwolff, dfaure, anthonyfieroni, iodelay, vbspam, njensen,
dweatherill edited the summary of this revision.
REPOSITORY
R284 KCompletion
REVISION DETAIL
https://phabricator.kde.org/D9808
To: dweatherill, #frameworks, dhaumann, cullmann, dfaure
Cc: ngraham, mwolff, dfaure, anthonyfieroni, iodelay, vbspam, njensen, geetamc,
Pilzschaf, akshaydeo,
dweatherill added a comment.
as I don't have a developer account, I will need someone else to push it
please :-)
REPOSITORY
R284 KCompletion
REVISION DETAIL
https://phabricator.kde.org/D9808
To: dweatherill, #frameworks, dhaumann, cullmann, dfaure
Cc: mwolff, dfaure, anthonyfieroni,
dweatherill added a comment.
In https://phabricator.kde.org/D9808#189467, @dfaure wrote:
> Sorry to be a pain, but can you also update the description, which still
talks about textEmitted()?
>
> (FYI using `arc diff` to upload the patch would also provide context, but
OK, I can open
dweatherill edited the summary of this revision.
REPOSITORY
R284 KCompletion
REVISION DETAIL
https://phabricator.kde.org/D9808
To: dweatherill, #frameworks, dhaumann, cullmann
Cc: mwolff, dfaure, anthonyfieroni, iodelay, vbspam, njensen, geetamc,
Pilzschaf, akshaydeo, surgenight,
dweatherill added a comment.
from the git history I believe this issue has been in place since before 5.0.
Agree the breakage is worrying, but at the moment the existence of this bug
is breaking stuff I think. At the very least, if the behaviour can't be
changed, the documentation
dweatherill updated this revision to Diff 25163.
dweatherill added a comment.
this updated diff removes the rename, just has fixed and extended unit tests
and the one line fix for not emitting the textChanged signal spuriously.
REPOSITORY
R284 KCompletion
CHANGES SINCE LAST UPDATE
dweatherill added inline comments.
INLINE COMMENTS
> dweatherill wrote in klineedit.cpp:184
> you are absolutely right! My mistake, I intended to rename it to textEdited,
> as this is what the signal we actually want to emit from QLineEdit is, and
> the name textEmitted is spurious.
>
> I do
dweatherill added inline comments.
INLINE COMMENTS
> mwolff wrote in klineedit_unittest.cpp:87
> typo: if the text box is already clear*ed*
ok, it's unclear, but not a typo.
According to QLineEdit documentation, clear() should only emit textChanged when
there is actually text to clear.
So the
dweatherill created this revision.
dweatherill added a reviewer: Frameworks.
dweatherill added a project: KDevelop.
Restricted Application added a project: Frameworks.
dweatherill requested review of this revision.
REVISION SUMMARY
This goes with bug report
11 matches
Mail list logo
