Re: RSIBreak / KIdleTime on Wayland

2020-11-16 Thread David Edmundson
change made: https://invent.kde.org/plasma/kwayland-server/-/merge_requests/133

Re: RSIBreak / KIdleTime on Wayland

2020-11-16 Thread David Edmundson
>If the user was idle for a second (using a KIdleTime timeout), I start my own >idle time counter (counter++ every second). >Then I catch the next resume event (next user input) and reset my counter to 0. That sounds like what I had in mind. > 2) It works with XWayland, but only detects user

Re: RSIBreak / KIdleTime on Wayland

2020-11-15 Thread David Edmundson
> > Yes, I meant that progress bar. > I've had that 1s idle timer idea as well, unfortunately after writing this, > but thank you for confirming that this would indeed work. > I will give that a try and if I can get RSIBreak to a working state on > wayland submit a PR for it. Excellent, thank

Re: RSIBreak / KIdleTime on Wayland

2020-11-15 Thread David Edmundson
> I agree, if we can't make the KIdleTime framework work in Wayland there > should be a way to query the framework if it's going to work or not. Just to make sure that's not misread by others; the framework works for the majority of methods used in the common case, just not this one polling

Re: KDE CI: Frameworks » kxmlgui » kf5-qt5 SUSEQt5.12 - Build # 190 - Still Unstable!

2020-09-30 Thread David Edmundson
My fault. Fix on review. David

Re: kwayland's testRemoteAccess still flaky

2020-08-03 Thread David Edmundson
Urgh, let me just remove that test. No-one will even use that protocol soon anyway.

D26503: [Dialog Shadows] Port to KWindowSystem shadows API

2020-06-11 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH port-to-shadows-api REVISION DETAIL https://phabricator.kde.org/D26503 To: zzag, #plasma, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack,

D28355: Introduce function ecm_install_configured_file

2020-06-08 Thread David Edmundson
davidedmundson added a comment. Moved to invent. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28355 To: davidedmundson, #build_system Cc: apol, kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham,

D28355: Introduce function ecm_install_configured_file

2020-06-08 Thread David Edmundson
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R240:2976b27a6c0b: Introduce function ecm_install_configured_file (authored by davidedmundson). REPOSITORY R240 Extra

D29050: KRunner fix prepare/teardown signals

2020-05-22 Thread David Edmundson
davidedmundson added a comment. > the runner "backend" is used (from the QML side of things). Repo is called milou REPOSITORY R308 KRunner BRANCH krunner_signal_bugfix (branched from master) REVISION DETAIL https://phabricator.kde.org/D29050 To: alex, meven, ngraham, broulik Cc:

D29228: [KProcessRunner] Use only executable name for scope

2020-05-19 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D29228 To: broulik, #frameworks, #plasma, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29811: t/simplify-sending-data-through-socket

2020-05-17 Thread David Edmundson
davidedmundson added a comment. > that would probably mean recompiling most of KDE (Debian has packages for 5.69 only). I will check out your change and see what remains. This isn't a universal rule that always applies, but generally speaking you can just roll back the the frameworks

D29811: t/simplify-sending-data-through-socket

2020-05-17 Thread David Edmundson
davidedmundson added a comment. Your base kcrash is quite out of date - I simplified this method considerably a month ago, which gets rid of the two paths. Also can you check your commit messages, I don't know if it's phab being weird, but they all start with "t/" in the phab UI,

D29034: Add systemd user service file for kded

2020-05-15 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29034 To: broulik, #plasma, #frameworks, davidedmundson Cc: bruns, davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh,

Request for plasma framework patch release

2020-05-14 Thread David Edmundson
We seem to have a common crasher newly introduced in plasma-framework. A dozen reports in a few days. Can I ask for a plasma-framework 5.70.1. with c215c54eced5bd0b195c208dd72bb580e65f8fe4 cherry-picked. Sorry. David

D29742: Avoid potential disconnect of all signals in IconItem

2020-05-14 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:c215c54eced5: Avoid potential disconnect of all signals in IconItem (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D29742: Avoid potential disconnect of all signals in IconItem

2020-05-14 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY m_svgIcon can be null. disconnect(q, nullptr, nullptr,

D29680: Fix modified line marker in kate minimap

2020-05-13 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R39:f2b0dcdefea7: Fix modified line marker in kate minimap (authored by davidedmundson). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29680?vs=82663=82717

D29680: Fix modified line marker in kate minimap

2020-05-12 Thread David Edmundson
davidedmundson added a comment. What about ktexteditor? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D29680 To: davidedmundson, #kate Cc: ngraham, kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, domson, michaelh, bruns, demsking, cullmann, sars,

D29680: Fix modified line marker in kate minimap

2020-05-12 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Kate. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. davidedmundson requested review of this revision. REVISION SUMMARY Our pixmap is the size of the number of lines in

D29409: Add documentation line on KCM translations

2020-05-12 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > cblack wrote in configmodule.h:98 > You probably want to use backticks instead of quotes as this is referring to > something codewise. I don't understand. REPOSITORY R296 KDeclarative REVISION DETAIL

D29668: Do not reject icon theme dir with invalid context/type.

2020-05-11 Thread David Edmundson
davidedmundson added a comment. Seems sensible, given it's valid to have an empty context. I don't know enough about icons to know all possible ill effects. If there's no other comments in a few days consider this a "ship it!" REPOSITORY R302 KIconThemes REVISION DETAIL

D29292: Port KKeySequenceItem to QQC2

2020-05-11 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R296:c730edc8dce4: Port KKeySequenceItem to QQC2 (authored by davidedmundson). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29292?vs=81557=82604 REVISION DETAIL

D29511: Label: Add ping-pong logic

2020-05-07 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. Plasmacomponents is deprecated please see Plasmacomponents3 then see the readme within that and put this somewhere else. 1. Label is a super super super common element we don't want to add any overhead

D29503: Pixel align children of GridViewInternal

2020-05-07 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D29503 To: fvogt, #frameworks, broulik, mart, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack,

D25814: [KColorScheme] Add SeparatorColor

2020-05-06 Thread David Edmundson
davidedmundson added a comment. Relevant link on that last comment: https://bugreports.qt.io/browse/QTBUG-63331 They actively seeked our opinion on colour roles REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D25814 To: ndavis, #frameworks, #vdg Cc:

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-05 Thread David Edmundson
davidedmundson added a comment. > Allow users of KPreviewJob to request a devicePixelRatio for generated thumbnails. At the risk of asking a stupid question, why? As opposed to just having a width and height always be in device pixels. We're always working with pixmaps is there a

D29409: Add documentation line on KCM translations

2020-05-04 Thread David Edmundson
davidedmundson created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D29409 AFFECTED FILES

D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

2020-05-03 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D29374 To: weisi, winterz, davidedmundson Cc: jriddell, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29371: KMainWindow: remove doc paragraph about KGlobal::ref usage

2020-05-02 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D29371 To: dvratil, dfaure, #frameworks, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

D28498: [xdgoutput] Explicitly set version of server interface

2020-05-01 Thread David Edmundson
davidedmundson abandoned this revision. davidedmundson added a comment. All these problems go away with KWaylandServer \o/ REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28498 To: davidedmundson, #kwin Cc: zzag, anthonyfieroni, apol, kde-frameworks-devel,

D29278: Port KWin to KWaylandServer

2020-04-30 Thread David Edmundson
davidedmundson added a comment. > Hmm, I can't build kwin Hit the same thing, we've since fixed that (patch in kwayland-server) REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D29278 To: apol, #kwin, #plasma, #frameworks, davidedmundson Cc: zzag,

D29278: Port KWin to KWaylandServer

2020-04-30 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D29278 To: apol, #kwin, #plasma, #frameworks, davidedmundson Cc: zzag, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev,

D29292: Port KKeySequenceItem to QQC2

2020-04-30 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in KeySequenceItem.qml:57 > Why is it the worst? It keeps us from having to hardcode magic numbers. See task. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D29292 To: davidedmundson, #plasma,

D29292: Port KKeySequenceItem to QQC2

2020-04-29 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > cblack wrote in KeySequenceItem.qml:57 > Are we able to use some form of units? Hardcoding this seems wrong. > Can we use the non-attached version here please since it's not likely It's the worst! > Are we able to use some form of units?

D29292: Port KKeySequenceItem to QQC2

2020-04-29 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY This implicitly fixes a bug where space is used in the shortcut

D29231: Add keyboard_shortcuts_inhibit protocol

2020-04-29 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in keyboard_shortcuts_inhibit_interface.cpp:21 > You've probably meant Q_DECL_HIDDEN, right? > > On an unrelated note: there are valid arguments against nested private > classes so it would be really nice if we revisit this

D29231: Add keyboard_shortcuts_inhibit protocol

2020-04-29 Thread David Edmundson
davidedmundson added a comment. Let's wait for the new kwaylandserver repo before pushing. But ++, looks good. INLINE COMMENTS > keyboard_shortcuts_inhibit_interface.cpp:21 > + > +class KeyboardShortcutsInhibitorInterface::Private : public >

Re: Splitting KWayland

2020-04-28 Thread David Edmundson
That is what I imagined. The protocols section contains some things we can strip down. We shouldn't host anything that's in wayland-protocols like text-input. Also I think there's some dead things like plasma-effects. But we can do that sort of thing anytime before the first release. David

D29256: [server] Introduce mapped() signal

2020-04-28 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland BRANCH introduce-mapped-signal REVISION DETAIL https://phabricator.kde.org/D29256 To: zzag, #kwin, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh,

Re: Splitting KWayland

2020-04-28 Thread David Edmundson
On Tue, 28 Apr 2020, 07:24 Vlad Zahorodnii, wrote: > On 4/27/20 4:12 PM, David Edmundson wrote: > > I don't think we want to remove client or server tests on this one. As > > the client tests covered the server side too > > Hmm, does this mean we are going to keep both the

Re: Splitting KWayland

2020-04-27 Thread David Edmundson
On Mon, Apr 27, 2020 at 2:12 PM David Edmundson wrote: > > > On Mon, Apr 27, 2020 at 1:58 PM Aleix Pol wrote: > >> Hi, >> As discussed in the meeting last week, I've been looking into the split. >> >> Here's what I was thinking of, please tell me if there's

Re: Splitting KWayland

2020-04-27 Thread David Edmundson
On Mon, Apr 27, 2020 at 1:58 PM Aleix Pol wrote: > Hi, > As discussed in the meeting last week, I've been looking into the split. > > Here's what I was thinking of, please tell me if there's something > massively important I'm missing. > > The idea would be to start working on it after kwayland

D28882: Create protocol to manage video feeds

2020-04-27 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > screencast.xml:46 > + > + > + add type = "destructor" so that clients calling this release the resource REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28882 To: apol, #kwin, jgrulich,

D28883: Add wrapper for wl_global_remove

2020-04-24 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R127:c557cdba3a73: Add wrapper for wl_global_remove (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28883?vs=80279=81103 REVISION DETAIL

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

2020-04-23 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D28470 To: kmaterka, #plasma, broulik, apol, davidedmundson, #frameworks Cc: mart, davidre, cblack,

Re: Problems in KWayland causes by API and ABI compatibility promises

2020-04-23 Thread David Edmundson
We had a meeting. It resulted in some final action decisions. These will affect the kwayland folder in frameworks. The meeting was attended by: Kevin Ottens, Vlad Zahorodnii, Aleix Pol, Myself, Benjamin Port who all approved the plan. *Protocols:* We make a new repo. It will contain just

D28882: Create protocol to manage video feeds

2020-04-23 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. In future, it might be faster to put up just the interface xml for review first. -- In terms of wayland protocols this is non-standard. All

D28355: Introduce function ecm_install_configured_file

2020-04-23 Thread David Edmundson
davidedmundson added a dependent revision: D28305: Systemd Startup. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D28355 To: davidedmundson Cc: apol, kossebau, pino, kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack, bencreasy, michaelh, ngraham,

D29034: Add systemd user service file for kded

2020-04-23 Thread David Edmundson
davidedmundson added a dependent revision: D28305: Systemd Startup. REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D29034 To: broulik, #plasma, #frameworks Cc: davidedmundson, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29035: Install service files for kwin

2020-04-23 Thread David Edmundson
davidedmundson added a dependent revision: D28305: Systemd Startup. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D29035 To: broulik, #plasma, #frameworks Cc: davidedmundson, kwin, Orage, cacarry, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D29051: Add ecm_generate_dbus_service_file

2020-04-23 Thread David Edmundson
davidedmundson added a dependent revision: D28305: Systemd Startup. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D29051 To: broulik, #frameworks, davidedmundson, kossebau, kfunk, habacker Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, cblack,

D29102: Prefer QIcon::pixmap(QWindow*, ...) overload

2020-04-22 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Yeah, size is in logical pixels. Multiplying doesn't make sense. I'm sure more high DPI bugs are caused by clients trying to be clever. REPOSITORY R242 Plasma

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

2020-04-22 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D29054 To: bport, zzag, davidedmundson Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29054: [Wayland] Add to PlasmaWindowManagement protocol windows stacking order

2020-04-21 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > plasma-window-management.xml:77 > + > +This event will be sent when stacking order changed > + we also need to send it on bind > plasma-window-management.xml:83 > > > Can we change them all at once. >

D29035: Install service files for kwin

2020-04-21 Thread David Edmundson
davidedmundson added a comment. I'm not sure why we set KillMode Though I'm favour of merging then tweaking some of this, the service files won't do anything till someone pulls them in. Don't push before relevant ECM and relevant p-w patch is in INLINE COMMENTS >

D28499: [LauncherJobs] Emit description

2020-04-21 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28499 To: broulik, #frameworks, davidedmundson Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns

D29034: Add systemd user service file for kded

2020-04-21 Thread David Edmundson
davidedmundson added a comment. We also need to change the installed DBus service file so that we link the two in the unlikely event that kded is called I need to either update the dbus generator macro, or we skip the macro and put the service file in here, the old way INLINE COMMENTS

Re: Problems in KWayland causes by API and ABI compatibility promises

2020-04-20 Thread David Edmundson
On Thu, Apr 16, 2020 at 10:26 PM David Edmundson wrote: > > > Given Doodle's take forever and everyone's probably quarantined > > anyway, I propose we do it just after the Monday Plasma meeting. If > > someone is eager to share an opinion and can't make that, message here

Re: Problems in KWayland causes by API and ABI compatibility promises

2020-04-20 Thread David Edmundson
> > The slight twist on that which we need to be wary of is that client > > code will return shared objects if you request a > > KWaylandClient::PlasmaShellSurface::get(window()) > > for the same window from two places you'll get the same PlasmaShell > > instance returned - and therefore the same

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-04-20 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Assuming VDG are happy, go for it. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi,

D27840: Introduce SettingState* elements to ease KCM writing

2020-04-20 Thread David Edmundson
davidedmundson accepted this revision. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27840 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D27841: Port desktoptheme, icons and workspace KCMs to SettingStateBinding

2020-04-20 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27841 To: ervin, crossi, hchain, meven, bport, davidedmundson, mart, ngraham, #frameworks, #plasma, #vdg Cc: plasma-devel,

D28892: [autotests] Optimistic attempt to fix RemoteAccessTest reilability

2020-04-17 Thread David Edmundson
davidedmundson added a comment. > This seems super complicated. It is :D REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D28892 To: davidedmundson, #kwin, zzag Cc: zzag, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28892: [autotests] Optimistic attempt to fix RemoteAccessTest reilability

2020-04-17 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R127:1b1412943b6b: [autotests] Optimistic attempt to fix RemoteAccessTest reilability (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D28919: Drop delayed second phase

2020-04-17 Thread David Edmundson
davidedmundson added a comment. > @davidedmundson did some bootchart that showed startup is actually faster without this It was probably just noise as it wasn't a full average of N tests, just 2 clean boots. However ksplash removed 100ms earlier. I can attach if needed. As for the

D28900: Fix wayland scanner warnings

2020-04-16 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R240 Extra CMake Modules BRANCH master REVISION DETAIL https://phabricator.kde.org/D28900 To: apol, #build_system, #kwin, #frameworks, davidedmundson Cc: kde-frameworks-devel,

Re: Problems in KWayland causes by API and ABI compatibility promises

2020-04-16 Thread David Edmundson
On Wed, Apr 8, 2020 at 5:10 PM Kevin Ottens wrote: > > Hello, > > On Wednesday, 1 April 2020 14:04:10 CEST David Edmundson wrote: > > Here is a list of active uses of the KWayland::Client API. > > > > frameworks > > plasma-framework (for window position

Re: Problems in KWayland causes by API and ABI compatibility promises

2020-04-16 Thread David Edmundson
> Given Doodle's take forever and everyone's probably quarantined > anyway, I propose we do it just after the Monday Plasma meeting. If > someone is eager to share an opinion and can't make that, message here > and we'll choose something more formally. That didn't really work out. Doodle it is!

D28892: [autotests] Optimistic attempt to fix RemoteAccessTest reilability

2020-04-16 Thread David Edmundson
davidedmundson updated this revision to Diff 80312. davidedmundson added a comment. update REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28892?vs=80311=80312 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28892 AFFECTED FILES

D28892: [autotests] Optimistic attempt to fix RemoteAccessTest reilability

2020-04-16 Thread David Edmundson
davidedmundson updated this revision to Diff 80311. davidedmundson added a comment. spelling REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28892?vs=80310=80311 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28892 AFFECTED FILES

D28892: [autotests] Optimistic attempt to fix RemoteAccessTest reilability

2020-04-16 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: KWin. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY In this test we are waiting on 4 events. 2 things via 2 threads.

D28883: Add wrapper for wl_global_remove

2020-04-16 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY Removes the Global from the registry, but does not delete the

D24956: Consider desktop files with NoDisplay attribute

2020-04-15 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > [14:12] DavidRedondo1: my understanding is that a system might ship "konsole opens with control+t". The UI allows you to remove that. This would remove the entry in

D24956: Consider desktop files with NoDisplay attribute

2020-04-15 Thread David Edmundson
davidedmundson added a comment. kglobalshortcutseditor.cpp needs updating to match I think you're right with your reasoning about NoDisplay, but we do want something to be able to mask system files. From the spec should we be checking Hidden= ? REPOSITORY R268 KGlobalAccel

D20655: Use generated DBus interface

2020-04-14 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. We copy udisks xml already. I don't think it ends up any better. Otherwise we have a compile time dep on a runtime plugin, which inevitably means we need to make

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

2020-04-14 Thread David Edmundson
davidedmundson added a comment. Note there's a unit test for IconItem worth running if you haven't already. The refactor in general makes sense - it's a lot cleaner. Though I'm not sure what our super long term KF6 plan for IconItem is, it'll definitely be changing quite a bit.

D28697: Also relase the window in the destructor

2020-04-09 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH release (branched from master) REVISION DETAIL https://phabricator.kde.org/D28697 To: davidre, broulik, #frameworks, davidedmundson Cc: kde-frameworks-devel,

D28336: Drop klauncher usage from KCrash

2020-04-08 Thread David Edmundson
davidedmundson updated this revision to Diff 79634. davidedmundson added a comment. and merge methods REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28336?vs=78636=79634 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28336 AFFECTED FILES

D28336: Drop klauncher usage from KCrash

2020-04-08 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R285:d8e41e64b7d0: Drop klauncher usage from KCrash (authored by davidedmundson). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28336?vs=79634=79635 REVISION DETAIL

D28636: Use ecm_setup_qtplugin_macro_names

2020-04-06 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner BRANCH useECMSetupQtPluginMacroNames REVISION DETAIL https://phabricator.kde.org/D28636 To: kossebau, #frameworks, broulik, davidedmundson Cc: kde-frameworks-devel, LeGast00n,

D28620: Add readmes clarifying state of plasma component versions

2020-04-06 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:0051a4f919b6: Add readmes clarifying state of plasma component versions (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D28620: Add readmes clarifying state of plasma component versions

2020-04-06 Thread David Edmundson
davidedmundson updated this revision to Diff 79479. davidedmundson added a comment. use .md REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28620?vs=79467=79479 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28620

D28599: [configview] Simplify code / workaround Qt5.15 crash

2020-04-06 Thread David Edmundson
davidedmundson updated this revision to Diff 79469. davidedmundson added a comment. setContextProprerties REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28599?vs=79423=79469 BRANCH master REVISION DETAIL

D28599: [configview] Simplify code / workaround Qt5.15 crash

2020-04-06 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:0417bf61d53a: [configview] Simplify code / workaround Qt5.15 crash (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D28620: Add readmes clarifying state of plasma component versions

2020-04-06 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. TEST PLAN N/A REPOSITORY R242 Plasma Framework (Library) BRANCH

D28606: Add iconSize property to PC2 ToolButton

2020-04-06 Thread David Edmundson
davidedmundson added a comment. > He said he wouldn't accept patches that do that for notifications or KRunner because of the issues with PC3 I doubt that's what was meant. There have definitely been some bad patches that blindly ported to PC3 without adequate testing. That's

D28599: [configview] Simplify code / workaround Qt5.15 crash

2020-04-05 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY QQmlComponent::beginCreate and completeCreate are useful if you

A new playground repo: Kirigami-addons

2020-04-04 Thread David Edmundson
This email is to announce a new pending repo, in playground that I'm hoping to put into kdereview at some point. I've been ridiculously slow with the repository, making promises and then letting people down. I've finally pushed this onto playground in the hope that others can take it to where it

D28570: Add 3mf thumbnail support

2020-04-04 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R320:a5ded8f01e60: Add 3mf thumbnail support (authored by davidedmundson). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28570?vs=79329=79355 REVISION DETAIL

D28574: KRunner: Improve code snippet

2020-04-04 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R308 KRunner BRANCH master REVISION DETAIL https://phabricator.kde.org/D28574 To: alex, #plasma, davidedmundson, broulik, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28570: Add 3mf thumbnail support

2020-04-04 Thread David Edmundson
davidedmundson created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY 3D Modelling Format is based on "Open Packaging Conventions" which is already

D28421: Add static method to check start condition

2020-04-04 Thread David Edmundson
davidedmundson added a comment. That was embarrassing, I shouldn't try and rush. Sorry. Thanks for cleaning up after me. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D28421 To: hchain, davidedmundson, broulik, dfaure, kossebau Cc: kde-frameworks-devel,

D28421: Add static method to check start condition

2020-04-03 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > dfaure wrote in kautostart.h:289 > This is new public API, it's missing @since 5.69 Added. https://commits.kde.org/kservice/ce83ae51bfc88be77573745ed8a4434393b2f9f1 REPOSITORY R309 KService REVISION DETAIL

D28537: [krun] Removed no longer used internal method resolveURLs()

2020-04-03 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH removeunusedresolveURLs REVISION DETAIL https://phabricator.kde.org/D28537 To: kossebau, #frameworks, davidedmundson, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack,

D28498: [xdgoutput] Explicitly set version of server interface

2020-04-03 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > zzag wrote in display.h:297 > You can't introduce another createXdgOutputManager() because it's not > overloaded. You probably need to rename this method, e.g. > createXdgOutputManager2. As you've pasted, it is BC, which is what

D28033: Create ExpandableListItem

2020-04-03 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Tagging is tomorrow, don't merge before then. INLINE COMMENTS > ExpandableListItem.qml:491 > +Item { > +height: actionsList.height > +width:

D28510: [kprocessrunner] Escape hyphen characters in scope names

2020-04-03 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R241:6fba90325237: [kprocessrunner] Escape hyphen characters in scope names (authored by davidedmundson). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

Re: Problems in KWayland causes by API and ABI compatibility promises

2020-04-02 Thread David Edmundson
Kevin, thanks for your input. I think there's a general feeling towards forking the server completely. But we need to decide something concrete, and this ML is dying down. I propose we have a voice/video chat with the objective of agreeing on a concrete plan both short term and for KF6 and then

D28355: Introduce function ecm_install_configured_file

2020-04-02 Thread David Edmundson
davidedmundson updated this revision to Diff 79176. davidedmundson added a comment. extra escape Not needed for the tests, yet weirdly threw an error in plasma... REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28355?vs=79115=79176 BRANCH

  1   2   3   4   5   6   7   8   9   10   >