D19090: Hardcoding the Remaining Time Update Interval

narvaez added a comment. In D19090#413998 , @bruns wrote: > Nitpick - "Hardcoding ..." -> "Hardcode" or better "Use a fixed interval for updating the Remaining Time" Huh, I updated my local commit to use that recommendation but arc

D19090: Hardcoding the Remaining Time Update Interval

narvaez closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19090 To: narvaez, #baloo, bruns Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19090: Hardcoding the Remaining Time Update Interval

narvaez added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19090 To: narvaez, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19090: Hardcoding the Remaining Time Update Interval

narvaez created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. narvaez requested review of this revision. REVISION SUMMARY There is no relation between this number and the batch size of the scheduler. REPOSITORY R293 Baloo

D19007: Wait for DBus Reply Before Performing Computations

narvaez abandoned this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19007 To: narvaez, #baloo, bruns, astippich, poboiko Cc: davidedmundson, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19007: Wait for DBus Reply Before Performing Computations

narvaez added inline comments. INLINE COMMENTS > bruns wrote in monitor.cpp:90 > The batchsize 40 by default, so currently the update interval is 200 files. > 100 or 200 does not matter to much, it is just a crude limiter anyway. > > A better fix would be emit the remaining time directly from

D19007: Wait for DBus Reply Before Performing Computations

narvaez added inline comments. INLINE COMMENTS > davidedmundson wrote in monitor.cpp:90 > That won't fix the issue. > > getBatchSize is still returning a QDBusPendingReply, using the value before > it's loaded will always be zero. It does fix the issue because if getBatchSize returns 0 then

D19007: Wait for DBus Reply Before Performing Computations

narvaez edited the test plan for this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19007 To: narvaez, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19007: Wait for DBus Reply Before Performing Computations

narvaez added a reviewer: Baloo. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D19007 To: narvaez, #baloo Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D19007: Wait for DBus Reply Before Performing Computations

narvaez created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. narvaez requested review of this revision. REVISION SUMMARY If the scheduler has not replied by the time the batch size is used, the default value is 0 and the mod

Re: Review Request 124147: Create Data Dir If it Does Not Exist

that happens only on my computer or if this is something wrong with the code, can somebody confirm? Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124134: Fixing KDED string references

. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124147: Create Data Dir If it Does Not Exist

named kcookiejar inside ~/.local/share and with a regular file named kcookiejar in that location. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124147: Create Data Dir If it Does Not Exist

named kcookiejar in that location. In my setup, the message box is not showing properly but I am not sure if this is somethign that happens only on my computer or if this is something wrong with the code, can somebody confirm? Thanks, David Narváez

Re: Review Request 124147: Create Data Dir If it Does Not Exist

kcookiejar inside ~/.local/share and with a regular file named kcookiejar in that location. In my setup, the message box is not showing properly but I am not sure if this is somethign that happens only on my computer or if this is something wrong with the code, can somebody confirm? Thanks, David

Re: Review Request 124147: Create Data Dir If it Does Not Exist

? Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 124147: Create Data Dir If it Does Not Exist

kded5 with no file named kcookiejar inside ~/.local/share and with a regular file named kcookiejar in that location. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 124147: Create Data Dir If it Does Not Exist

://git.reviewboard.kde.org/r/124147/#review81981 --- On June 22, 2015, 12:27 a.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 124147: Create Data Dir If it Does Not Exist

/ Testing --- Restarted kded5 with no file named kcookiejar inside ~/.local/share and with a regular file named kcookiejar in that location. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Review Request 124147: Create Data Dir If it Does Not Exist

/ioslaves/http/kcookiejar/kcookieserver.cpp ac585a0b04637c485647564d18a89a75d6c11d97 Diff: https://git.reviewboard.kde.org/r/124147/diff/ Testing --- Restarted kded5 with no file named kcookiejar inside ~/.local/share and with a regular file named kcookiejar in that location. Thanks, David

Review Request 124134: Fixing KDED string references

$ kcmshell5 cookies a message would pop up saying the cookies service was not available. After this patch you are able to view and edit your cookies. After this patch I also have ~/.config/kcookiejarrc. Thanks, David Narváez ___ Kde-frameworks

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

5 opens an incognito window and step 6 opens a webapp window (simple window). Step 7 opens the current working directory because local URL handling is broken. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120794/#review69318 --- On Oct. 29, 2014, 1:57 p.m., David Narváez wrote: --- This is an automatically

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

. To reply, visit: https://git.reviewboard.kde.org/r/120794/#review69318 --- On Oct. 29, 2014, 1:57 p.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

:) - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120794/#review69243 --- On Oct. 28, 2014, 5:44 a.m., David Narváez wrote

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

--- On Oct. 28, 2014, 2 p.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120794/ --- (Updated

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

, step 5 opens an incognito window and step 6 opens a webapp window (simple window). Step 7 opens the current working directory because local URL handling is broken. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

window (simple window). Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120794: Implement Unique Mode Properly in Rekonq

list is not empty, the window opened at 1 crashes because the activateRequested signal passes an empty list of arguments - not even the binary name - so QCommandLine parser dies. With this patch, every step opens a new window properly. Thanks, David Narváez

Re: Review Request 119444: Replacing also kicon.h header include

; i mexporters.size(); ++i ) m-addAction( new ExporterAction( doc, w, coll, mexporters[i] ) ); if(coll) Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 119435: Replacing also kaction.h header include

#include vector @@ -41,7 +41,7 @@ public: }; class ExporterAction - : public KAction + : public QAction { Q_OBJECT Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman

Review Request 119457: Script to Fix ecm_install_icons Deprecation Warnings

Attachments Test Repository https://git.reviewboard.kde.org/media/uploaded/files/2014/07/25/f598db77-95a6-4505-b02d-72304b79d65b__iconstest.tgz Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Review Request 119435: Replacing also kaction.h header include

+ : public QAction { Q_OBJECT Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 119444: Replacing also kicon.h header include

] ) ); if(coll) Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115440: Rename KDE4_SERIALIZE_TOOL to KDOCTOOLS_SERIALIZE_TOOL And Add Setter

marked as submitted. Review request for KDE Frameworks and Luigi Toscano. Repository: kdoctools Description --- As described in Review Request 115077 Diffs - KF5DocToolsMacros.cmake 998c200 Diff: https://git.reviewboard.kde.org/r/115440/diff/ Testing --- Thanks, David

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

/ Testing --- Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115440: Rename KDE4_SERIALIZE_TOOL to KDOCTOOLS_SERIALIZE_TOOL And Add Setter

: kdoctools Description --- As described in Review Request 115077 Diffs - KF5DocToolsMacros.cmake 998c200 Diff: https://git.reviewboard.kde.org/r/115440/diff/ Testing --- Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

://git.reviewboard.kde.org/r/115077/#review48693 --- On Jan. 18, 2014, 1:16 p.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 115292: Do Configure Checks in the Correct Language

. - David --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115292/#review48694 --- On Jan. 24, 2014, 1:55 p.m., David Narváez wrote

Re: Review Request 115292: Do Configure Checks in the Correct Language

://git.reviewboard.kde.org/r/115292/#review48694 --- On Jan. 24, 2014, 1:55 p.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org

Review Request 115417: Remove the Check for freeaddrinfo

: kde4support Description --- It is no longer used, see 115292 Diffs - src/ConfigureChecks.cmake 5f7f485 Diff: https://git.reviewboard.kde.org/r/115417/diff/ Testing --- Builds OK after this change, all tests pass. Thanks, David Narváez

Re: Review Request 115417: Remove the Check for freeaddrinfo

and Alex Merry. Repository: kde4support Description (updated) --- It is no longer used, see #115292 Diffs - src/ConfigureChecks.cmake 5f7f485 Diff: https://git.reviewboard.kde.org/r/115417/diff/ Testing --- Builds OK after this change, all tests pass. Thanks, David

Re: Review Request 115292: Do Configure Checks in the Correct Language

-network.h #define HAVE_GETADDRINFO 1 Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115417: Remove the Check for freeaddrinfo

this change, all tests pass. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115292: Do Configure Checks in the Correct Language

/ConfigureChecks.cmake 7c8951f Diff: https://git.reviewboard.kde.org/r/115292/diff/ Testing --- 1. Refreshed builds for ECM and KDE4Support, both building OK 2. $ grep HAVE_GETADDRINFO src/config-network.h #define HAVE_GETADDRINFO 1 Thanks, David Narváez

Re: Review Request 115237: Relocate KDE4_CREATE_HANDBOOK

is created for folder doc. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115239: Relocate KDE4_CREATE_HANDBOOK

--- Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

CMakeLists.txt files of frameworks for that macro, found nothing. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115237: Relocate KDE4_CREATE_HANDBOOK

://git.reviewboard.kde.org/r/115237/diff/ Testing --- Tried using this on a Kig build for frameworks. The warning message is displayed and the doc-handbook target is created for folder doc. Thanks, David Narváez ___ Kde-frameworks-devel mailing list

Re: Review Request 115237: Relocate KDE4_CREATE_HANDBOOK

and the doc-handbook target is created for folder doc. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115239: Relocate KDE4_CREATE_HANDBOOK

: kdoctools Description --- Moved to KDE4Support as discussed in Review Request 115077 Diffs - KF5DocToolsMacros.cmake 5bb0f72 Diff: https://git.reviewboard.kde.org/r/115239/diff/ Testing --- Thanks, David Narváez ___ Kde-frameworks

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

to kde4support. Aleix Pol Gonzalez wrote: I wouldn't rename it indeed. Moving it to KDE4Support can be good indeed, although it kind of defeats the purpose, as you'll need to actually depend on KDE4Support to get the warning. David Narváez wrote: Luigi, your call. Alex Merry

Review Request 115213: Remove KDE4_CREATE_HTML_HANDBOOK

: kdoctools Description --- As discussed in Review Request 115077 Diffs - KF5DocToolsMacros.cmake 191a2c5 Diff: https://git.reviewboard.kde.org/r/115213/diff/ Testing --- Searched all CMakeLists.txt files of frameworks for that macro, found nothing. Thanks, David Narváez

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

to kde4support. Aleix Pol Gonzalez wrote: I wouldn't rename it indeed. Moving it to KDE4Support can be good indeed, although it kind of defeats the purpose, as you'll need to actually depend on KDE4Support to get the warning. David Narváez wrote: Luigi, your call. Alex Merry

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115077/#review47592 --- On Jan. 17, 2014, 3:14 p.m., David Narváez wrote

Re: Review Request 115077: Rename Macros in KF5DocTools to KDE5_

/ Testing --- Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115065: kdoctools renames to add 5 namespace to prevent clashes with kdelibs4

/pf215b902 - David Narváez On Jan. 17, 2014, 11:30 a.m., Jonathan Riddell wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115065

Review Request 115077: Rename Macros in KF5DocTools to KDE5_

: kdoctools Description --- Part of the overall task of removing mentions of KDE4 from the code. Diffs - KF5DocToolsMacros.cmake 191a2c5 Diff: https://git.reviewboard.kde.org/r/115077/diff/ Testing --- Thanks, David Narváez ___ Kde

Re: Review Request 113792: Fix Build of KDNSSD with DNSSD Backend

KDNSSD with -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 2. Build Builds successfully. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113818: Add Remaining Tier 2 Builds to Superbuild

. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113818: Add Remaining Tier 2 Builds to Superbuild

superbuild for dnssd, kjobwidgets, kwallet and dependencies. 2. Build. Builds successfully. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

and -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 Configures OK in both cases. Builds OK in case 1, does not build yet in case 2. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

and -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 Configures OK in both cases. Builds OK in case 1, does not build yet in case 2. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 113792: Fix Build of KDNSSD with DNSSD Backend

/mdnsd-domainbrowser.cpp 21c359e tier2/dnssd/src/CMakeLists.txt c71ade2 tier2/dnssd/CMakeLists.txt 13497d1 Diff: http://git.reviewboard.kde.org/r/113792/diff/ Testing --- 1. Configure KDNSSD with -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 2. Build Builds successfully. Thanks, David

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

--- On Nov. 7, 2013, 1:30 p.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113657

Re: Review Request 113657: Fix Standalone Configuration of DNSSD

in case 1, does not build yet in case 2. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 113642: Fix warnings about annotations in DBus XML for KWallet

'com.trolltech.QtDBus.QtTypeName.Out0' found; suggest updating to 'org.qtproject.QtDBus.QtTypeName.Out0' Warning: deprecated annotation 'com.trolltech.QtDBus.QtTypeName.Out0' found; suggest updating to 'org.qtproject.QtDBus.QtTypeName.Out0' Thanks, David Narváez ___ Kde

Re: Review Request 113643: Fix Standalone Configuration for KJobWidgets

://git.reviewboard.kde.org/r/113643/diff/ Testing --- 1. Configure a standalone build Before this patch the configuration would complain of missing find_packages for KCore Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org

Re: Review Request 113643: Fix Standalone Build for KJobWidgets

source dir. Diffs (updated) - tier2/kjobwidgets/CMakeLists.txt 98bd0a1 Diff: http://git.reviewboard.kde.org/r/113643/diff/ Testing --- 1. Configure a standalone build Before this patch the configuration would complain of missing find_packages for KCore Thanks, David Narváez

Re: Review Request 113642: Fix warnings about annotations in DBus XML for KWallet

'com.trolltech.QtDBus.QtTypeName.Out0' found; suggest updating to 'org.qtproject.QtDBus.QtTypeName.Out0' Warning: deprecated annotation 'com.trolltech.QtDBus.QtTypeName.Out0' found; suggest updating to 'org.qtproject.QtDBus.QtTypeName.Out0' Thanks, David Narváez

Re: Review Request 113643: Fix Standalone Build for KJobWidgets

/ Testing --- 1. Configure a standalone build Before this patch the configuration would complain of missing find_packages for KCore Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman