Re: How to sort TableModel QML Type

2020-10-19 Thread David Redondo
Am Samstag, 17. Oktober 2020, 20:38:43 CEST schrieb chiasa.men: > Is there a way to sort a TableModel without relying on c++ code? Hi, we have QSortFilterProxyModel bindings in KItemModels, which makes it easy to create and use such a proxy model from Qml: https://api.kde.org/frameworks/

Re: IconDialog customLocation

2020-10-09 Thread David Redondo
Hi, copy pasting my response from https://bugs.kde.org/show_bug.cgi?id=427434 : I think you want to set "user: true". The name of this property comes from KIconDialog [1] which is wrapped by IconDialog [2] Best regards, David [1]

Re: Breakage in Breeze Icons

2020-07-21 Thread David Redondo
I fixed the build now. There was a symlink to a removed file which cmake -E copy_directory didn't like. Regards, David

D29281: Deprecate defunct functions

2020-07-14 Thread David Redondo
davidre added a comment. This caused https://bugs.kde.org/show_bug.cgi?id=423003. I removed excluding the virtual method from the build in https://invent.kde.org/frameworks/krunner/commit/8f7ce559b84ee0c21de0256e6591793e4b95f411 REPOSITORY R308 KRunner REVISION DETAIL

D29463: Fix Kirigami.Units.devicePixelRatio=1.3 when it should be 1.0 at 96dpi

2020-06-08 Thread David Redondo
davidre added a comment. Ping REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29463 To: Zren, #kirigami, mart Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29802: Require out-of-source builds

2020-05-16 Thread David Redondo
davidre accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH require-in-source-build (branched from master) REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre Cc: ltoscano, davidre,

D29802: Require in-source build

2020-05-16 Thread David Redondo
davidre requested changes to this revision. davidre added a comment. This revision now requires changes to proceed. I don't think we want to require in source builds REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb,

D28208: Move sni icon handling logic from data engine to applet

2020-05-11 Thread David Redondo
davidre updated this revision to Diff 82519. davidre added a comment. - fix REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28208?vs=82492=82519 BRANCH sni (branched from master) REVISION DETAIL https://phabricator.kde.org/D28208 AFFECTED

D28208: Move sni icon handling logic from data engine to applet

2020-05-11 Thread David Redondo
davidre updated this revision to Diff 82492. davidre added a comment. - Rebase without test REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28208?vs=78982=82492 BRANCH sni (branched from master) REVISION DETAIL

D28624: Print a warning if runner is incompatible with KRunner

2020-04-29 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R308:e56def21a286: Print a warning if runner is incompatible with KRunner (authored by davidre). REPOSITORY R308 KRunner CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28624?vs=79487=81486

D28093: [breeze-icons] add TeamViewer tray icons

2020-04-28 Thread David Redondo
davidre added a comment. Couldn't we put the tray icon in the plasma theme? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28093 To: rocka, #vdg, ngraham, ndavis Cc: davidre, IlyaBizyaev, ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, michaelh,

D29232: [WIP][RFC]Introduce the Header color set

2020-04-28 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > ndavis wrote in kcolorscheme.cpp:271 > Why is that? The only one that might is Active, but that's not really used > much right now. Because the new colors are the replacement for theses colors. I thought one of those might map to this

D29232: [WIP][RFC]Introduce the Header color set

2020-04-27 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > kcolorscheme.cpp:271 > static const DecoDefaultColors defaultDecorationColors = { > { 61, 174, 233 }, // Focus > { 147, 206, 233 }, // Hover I would have expected at least of one the new colors to have the same value as this one.

D29011: Fix variable mixup

2020-04-20 Thread David Redondo
davidre abandoned this revision. davidre added a comment. Oh I diffed the wrong repo... REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D29011 To: davidre, #breeze, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29011: Fix variable mixup

2020-04-20 Thread David Redondo
davidre added reviewers: Breeze, Plasma. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D29011 To: davidre, #breeze, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29011: Fix variable mixup

2020-04-20 Thread David Redondo
davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Caused icons to be not longer recolored when changing the color scheme until an application is started again TEST

D28856: Save disabling of desktop file components in kglobalshortcutsrc

2020-04-16 Thread David Redondo
davidre updated this revision to Diff 80265. davidre added a comment. Don't parse the disabledGroup as component REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28856?vs=80206=80265 BRANCH disable (branched from master) REVISION DETAIL

D28856: Save disabling of desktop file components in kglobalshortcutsrc

2020-04-16 Thread David Redondo
davidre marked 4 inline comments as done. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D28856 To: davidre, davidedmundson, fvogt, meven Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28856: Save disabling of desktop file components in kglobalshortcutsrc

2020-04-15 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > globalshortcutsregistry.cpp:274 > +auto disabledComponents = KConfigGroup(&_config, > "disabledComponents").readEntry("disabled", QStringList()); > for (const QString : groupList) > { good point >

D28856: Save disabling of desktop file components in kglobalshortcutsrc

2020-04-15 Thread David Redondo
davidre updated this revision to Diff 80206. davidre added a comment. foo REPOSITORY R268 KGlobalAccel CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28856?vs=80205=80206 BRANCH disable (branched from master) REVISION DETAIL https://phabricator.kde.org/D28856 AFFECTED

D28856: Save disabling of desktop file components in kglobalshortcutsrc

2020-04-15 Thread David Redondo
davidre created this revision. davidre added reviewers: davidedmundson, fvogt, meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Works for writable and not writable files. Additional positive

D24956: Consider desktop files with NoDisplay attribute

2020-04-15 Thread David Redondo
davidre added a comment. In D24956#648991 , @meven wrote: > In D24956#648968 , @davidedmundson wrote: > > > > [14:12] DavidRedondo1: my understanding is that a system might ship "konsole opens

D28699: Add startCapture method

2020-04-10 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R296:5eb3c795a8f2: Add startCapture method (authored by davidre). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28699?vs=79691=79764 REVISION DETAIL

D28699: Add startCapture method

2020-04-09 Thread David Redondo
davidre created this revision. davidre added reviewers: Frameworks, davidedmundson, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Starts capturing as if the user clicked on the main

D28697: Also relase the window in the destructor

2020-04-09 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R296:6c5619ffebae: Also relase the window in the destructor (authored by davidre). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28697?vs=79688=79690 REVISION

D28697: Also relase the window in the destructor

2020-04-09 Thread David Redondo
davidre created this revision. davidre added reviewers: broulik, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Otherwise the keyboard is never released when the item is destroyed while

D27848: Remove the panel tooltip icon

2020-04-06 Thread David Redondo
davidre added a comment. In D27848#643045 , @ngraham wrote: > See the parent task. > > This component doesn't only darw system tray tooltips but rather tooltips for all panel widgets. The idea was that we don't want icons in *any* of these

D28624: Print a warning if runner is incompatible with KRunner

2020-04-06 Thread David Redondo
davidre created this revision. davidre added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Useful for finding out why runner isn't loaded even though it's enabled in

D27848: Remove the panel tooltip icon

2020-04-06 Thread David Redondo
davidre added a comment. I think this was done at the wrong level. If we don't want icons in the systray then the way would be to net set the property in the systray and not ignore the property in the generic component but keep the property for api stability purposes. Now we have a

D28203: Move corner fold to top right in 24 icons

2020-04-04 Thread David Redondo
davidre accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis, ngraham, davidre Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28203: Move corner fold to top right in 24 icons

2020-04-04 Thread David Redondo
davidre closed this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis, ngraham, davidre Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28470: [PlasmaCore.IconItem] Refactor source handling for different types

2020-04-04 Thread David Redondo
davidre added a comment. In D28470#640468 , @cblack wrote: > Splitting into multiple classes seems like a good idea, but "strategy"? Seems like an odd choice of name to me. I had assumed it's because of

D28203: Move corner fold to top right in 24 icons

2020-04-04 Thread David Redondo
davidre added a comment. Seems @kossebau was faster ;) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis, ngraham, davidre Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28203: Move corner fold to top right in 24 icons

2020-04-04 Thread David Redondo
davidre requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis, ngraham, davidre Cc: davidre, kossebau, ngraham, kde-frameworks-devel, LeGast00n, cblack,

D28203: Move corner fold to top right in 24 icons

2020-04-04 Thread David Redondo
davidre reopened this revision. davidre added a comment. This broke the build. Please note that tagging is today REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis, ngraham Cc: davidre, kossebau, ngraham, kde-frameworks-devel,

D28223: Add "Stat" prefix to StatDetails Enum entries

2020-03-24 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > global.h:322 > /// No field returned, useful to check if a file exists > -NoDetails = 0x0, > +StatNoDetails = 0x0, > /// Filename, access, type, size, linkdest I think this enum was not released yet REPOSITORY R241 KIO

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-19 Thread David Redondo
davidre added a comment. In D27617#630440 , @ilya-fedin wrote: > In D27617#629987 , @ngraham wrote: > > > Would it help this use case if we moved the Telegram icon into the Plasma theme for now,

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-19 Thread David Redondo
davidre added a comment. In D27617#630336 , @IlyaBizyaev wrote: > In D27617#630228 , @ngraham wrote: > > > So... how do we fix this so that you can use a nice monochrome Breeze icon in your system

D28130: Introduce api for passive notifications

2020-03-19 Thread David Redondo
davidre added a comment. I wonder if it's for the use case wehere an InlineMessage doesn't work does it need to contain actions? REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D28130 To: mart Cc: davidre, broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28033: Create ExpandableListItem

2020-03-13 Thread David Redondo
davidre added a comment. In D28033#627192 , @ngraham wrote: > In D28033#627184 , @cblack wrote: > > > In D28033#627180 , @davidre wrote: > > > > > I

D28033: Create ExpandableListItem

2020-03-13 Thread David Redondo
davidre added a comment. I would love if we could find a way to show that the item is expandable REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28033 To: ngraham, #vdg, #plasma Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27940: Add a KCapacityBar::State enum and attribute to allow display different status

2020-03-09 Thread David Redondo
davidre added a comment. Yes that's a problem that KColorScheme currently lives in KConfigWidgets. Maybe similiar to D27038 and D27039 ? Hopefully we can achieve T12218

D27912: Draw inlineNotes after drawing word wrap marker

2020-03-07 Thread David Redondo
davidre added a comment. Seems in https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/314/ the test passed again? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27912 To: davidre, #ktexteditor, brauch Cc: cullmann, brauch,

D27912: Draw inlineNotes after drawing word wrap marker

2020-03-07 Thread David Redondo
davidre added a comment. In D27912#623891 , @brauch wrote: > I also don't understand this. Even if the painting somehow changes, e.g. because some painter state is set which wasnt set before (which I do not see to be the case here), that should

D27912: Draw inlineNotes after drawing word wrap marker

2020-03-07 Thread David Redondo
davidre added a comment. FAIL! : InlineNoteTest::testInlineNote() Compared values are not the same Actual (newCoordCol04): QPoint(51,1) Expected (coordCol04) : QPoint(33,1) I have node idea why the test would be failing. It complains that a coordinateToCursor changed. My

D27912: Draw inlineNotes after drawing word wrap marker

2020-03-07 Thread David Redondo
davidre added a comment. In D27912#623871 , @cullmann wrote: > Hi, could it be that killed the inline notes autotest? > > https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/313/ Sorry I will take a look

D27912: Draw inlineNotes after drawing word wrap marker

2020-03-07 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R39:875d4da5475f: Draw inlineNotes after drawing word wrap marker (authored by davidre). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27912?vs=77168=77173

D27912: Draw inlineNotes after drawing word wrap marker

2020-03-07 Thread David Redondo
davidre retitled this revision from "Draw inlineNotes after drawing caret" to "Draw inlineNotes after drawing word wrap marker". davidre edited the summary of this revision. davidre edited the test plan for this revision. davidre added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor

D27912: Draw inlineNotes after drawing word wrap marker

2020-03-07 Thread David Redondo
davidre edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D27912 To: davidre, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, rrosch, LeGast00n, cblack, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D27912: Draw inlineNotes after drawing caret

2020-03-07 Thread David Redondo
davidre created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. davidre requested review of this revision. REVISION SUMMARY Normal text is column inlined so the caret even though drawn last doesn't go over anything. Inline

D27589: Try to apply the colorscheme of the current theme to QIcons

2020-03-02 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R242:b7fa6e0e916b: Try to apply the colorscheme of the current theme to QIcons (authored by davidre). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

2020-02-25 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R252:d3a1b5148008: [KStyle] Set the color of KMessageWidgets to the correct one from the current… (authored by davidre). REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE

D27038: [KMessageWidget] Allow the style to change our palette

2020-02-25 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R236:d946fb71ea22: [KMessageWidget] Allow the style to change our palette (authored by davidre). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D27038: [KMessageWidget] Allow the style to change our palette

2020-02-25 Thread David Redondo
davidre updated this revision to Diff 76408. davidre added a comment. Rebase REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27038?vs=74701=76408 BRANCH polish REVISION DETAIL https://phabricator.kde.org/D27038 AFFECTED FILES

D27540: KCModule: Indicate when a setting has been changed from the default value

2020-02-25 Thread David Redondo
davidre added a comment. That title is now not optimal isn't it? 1. It's not only in KCModule 2. It also shows unsaved settings REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg Cc: iasensio,

D27589: Try to apply the colorscheme of the current theme to QIcons

2020-02-24 Thread David Redondo
davidre updated this revision to Diff 76284. davidre added a comment. - Introduce Plasma::Theme::palette REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27589?vs=76197=76284 BRANCH qiconcolor (branched from master) REVISION DETAIL

D27557: Auto-generate 24px monochrome icons

2020-02-24 Thread David Redondo
davidre added a comment. I disagree but it's not my call REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27557 To: ngraham, #vdg, ndavis, #frameworks, sitter Cc: davidre, bcooksley, kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27557: Auto-generate 24px monochrome icons

2020-02-24 Thread David Redondo
davidre added a comment. Also we need to have this on Windows, too. Breeze-icons is part of Frameworks and these were exported/installed files. A user could easily have a reference to one of the files somewhere. REPOSITORY R266 Breeze Icons REVISION DETAIL

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-02-24 Thread David Redondo
davidre edited the summary of this revision. davidre added a reviewer: Fuchs. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27617 To: rocka, #vdg, Fuchs Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27589: Try to apply the colorscheme of the current theme to QIcons

2020-02-23 Thread David Redondo
davidre edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH qiconcolor (branched from master) REVISION DETAIL https://phabricator.kde.org/D27589 To: davidre, #plasma, cblack Cc: wbauer, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D27589: Try to apply the colorscheme of the current theme to QIcons

2020-02-23 Thread David Redondo
davidre added a comment. In D27589#616106 , @wbauer wrote: > Sounds like it would fix https://bugs.kde.org/show_bug.cgi?id=417780 ? Yes seems like the exact bug REPOSITORY R242 Plasma Framework (Library) BRANCH qiconcolor (branched

D27038: [KMessageWidget] Allow the style to change our palette

2020-02-23 Thread David Redondo
davidre added a comment. In D27038#616095 , @apol wrote: > But then now we are not refreshing the palette when it changes outside, no? > > How about adding a boolean value when it's already happening to prevent the infinite recursion?

D27589: Try to apply the colorscheme of the current theme to QIcons

2020-02-22 Thread David Redondo
davidre edited the test plan for this revision. davidre added a reviewer: Plasma. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27589 To: davidre, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27589: Try to apply the colorscheme of the current theme to QIcons

2020-02-22 Thread David Redondo
davidre created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY Before icons loaded internally with QIcon::fromTheme were being colored with the colors from the current global

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

2020-02-22 Thread David Redondo
davidre added a comment. Ping REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D27039 To: davidre, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27038: [KMessageWidget] Allow the style to change our palette

2020-02-22 Thread David Redondo
davidre added a comment. Ping REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D27038 To: davidre, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-02-22 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R236:835c64d1b693: [KMessageWidget] Draw it with QPainter instead of using stylesheet (authored by davidre). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D27540: Status indicator for individual widgets in KCModule

2020-02-21 Thread David Redondo
davidre added a comment. In D27540#615129 , @ervin wrote: > In D27540#615105 , @davidre wrote: > > > In D27540#615092 , @ervin wrote: > > > > > In

D27540: Status indicator for individual widgets in KCModule

2020-02-21 Thread David Redondo
davidre added a reviewer: VDG. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: Status indicator for individual widgets in KCModule

2020-02-21 Thread David Redondo
davidre added a comment. In D27540#615092 , @ervin wrote: > In D27540#615061 , @davidre wrote: > > > How does it look? Will this be opt in for other users of KConfigDialogManager? > > > I'd

D27540: Status indicator for individual widgets in KCModule

2020-02-21 Thread David Redondo
davidre added a comment. The editmarks should probably respect the visibility of the associated widget. In this picture I use a invisble lineedit to manage the settings of the QButtonGroup beneath (QButtonGroup isn't supported by KCOnfigDialogManager) F8117874: grafik.png

D27540: Status indicator for individual widgets in KCModule

2020-02-21 Thread David Redondo
davidre added a comment. How does it look? Will this be opt in for other users of KConfigDialogManager? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport Cc: davidre, kde-frameworks-devel,

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-02-20 Thread David Redondo
davidre added a comment. So I think this is ready to be merged and I would do so this weekend REPOSITORY R236 KWidgetsAddons BRANCH no-css (branched from master) REVISION DETAIL https://phabricator.kde.org/D27035 To: davidre, #frameworks, ngraham, cfeck Cc: apol, cfeck, dhaumann,

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-02-19 Thread David Redondo
davidre updated this revision to Diff 76018. davidre marked 4 inline comments as done. davidre added a comment. Code style and typos REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27035?vs=75717=76018 BRANCH no-css (branched from master)

D27463: KconfigXT: Add a value attribute to Enum field choices

2020-02-19 Thread David Redondo
davidre added a comment. Could you also add documentation to whatever https://api.kde.org/frameworks/kconfig/html/kconfig_compiler.html is generated from? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27463 To: meven, ervin, bport, crossi, #frameworks Cc:

D27463: KconfigXT: Add a value attribute to Enum field choices

2020-02-17 Thread David Redondo
davidre added a comment. If you touch the xsd do you neeed to increase the version number? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27463 To: meven, ervin, bport, crossi, #frameworks Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-02-14 Thread David Redondo
davidre updated this revision to Diff 75717. davidre added a comment. remove debug remains REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27035?vs=75716=75717 BRANCH no-css (branched from master) REVISION DETAIL

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-02-14 Thread David Redondo
davidre updated this revision to Diff 75716. davidre added a comment. Explicitly set TextColor and palettes of the labels and react to parent changes . For example necessary for konsole that uses stylesheet which break palette propagation and reparents the widget after creation.

D27315: Fix size of the header in GridViewKCM

2020-02-13 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R296:d9b52d900471: Fix size of the header in GridViewKCM (authored by davidre). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27315?vs=75445=75642 REVISION

D27315: Fix size of the header in GridViewKCM

2020-02-11 Thread David Redondo
davidre edited the test plan for this revision. davidre added a reviewer: broulik. REPOSITORY R296 KDeclarative REVISION DETAIL https://phabricator.kde.org/D27315 To: davidre, mart, broulik Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27315: Fix size of the header in GridViewKCM

2020-02-11 Thread David Redondo
davidre created this revision. davidre added a reviewer: mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidre requested review of this revision. REVISION SUMMARY The same as in SimpleKCM and ScrollviewKCM REPOSITORY R296 KDeclarative BRANCH

D27272: Add status icons: data-error, data-warning, data-information

2020-02-10 Thread David Redondo
davidre added a comment. In D27272#608602 , @ngraham wrote: > I think the emblem icons look great in your "After" screenshot. > > Wouldn't it be easier to have KDevelop use these emblem icons from their current names rather than symlinking

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-02-07 Thread David Redondo
davidre added a comment. Ping, how should I proceed? REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D27035 To: davidre, #frameworks, ngraham Cc: cfeck, dhaumann, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D25123: New yakuake logo/icon

2020-02-06 Thread David Redondo
davidre added a comment. If you land this please update the summary before. No need to have all the variants in the commit message it should be about the actual change. Thanks :) REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D25123 To: mglb, #vdg, #yakuake,

D26951: Remove old code that is not used anymore

2020-02-02 Thread David Redondo
davidre added a comment. I just took a look at KSelector and it actually inherits minimum and maximum properties from QAbstractSlider so we could just drop these custom properties for KF6 REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D26951 To: davidre,

D26951: Remove old code that is not used anymore

2020-02-02 Thread David Redondo
This revision was automatically updated to reflect the committed changes. Closed by commit R265:db859852b577: Remove old code that is not used anymore (authored by davidre). REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26951?vs=74856=74857 REVISION

D26951: Remove old code that is not used anymore

2020-02-02 Thread David Redondo
davidre updated this revision to Diff 74856. davidre added a comment. Update comment REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26951?vs=74450=74856 BRANCH arcpatch-D26951 REVISION DETAIL https://phabricator.kde.org/D26951 AFFECTED FILES

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-31 Thread David Redondo
davidre added a comment. Something like this: F8059669: Screenshot_20200131_163146.PNG REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D27035 To: davidre, #frameworks, ngraham Cc: cfeck, dhaumann, ngraham,

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-31 Thread David Redondo
davidre added a comment. In D27035#604026 , @ngraham wrote: > Uh-oh, now it looks like this in Konsole: F8056116: Screenshot_20200131_064332.png > > Compare to the current appearance: F8056130:

D27064: API dox: tell default values of KMessageWidget's wordWrap/closeButtonVisible

2020-01-31 Thread David Redondo
davidre accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons BRANCH mentiondefaults REVISION DETAIL https://phabricator.kde.org/D27064 To: kossebau, davidre Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27064: API dox: tell default values of KMessageWidget's wordWrap/closeButtonVisible

2020-01-31 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > kmessagewidget.h:258 > * > + * By default the close button is set to be invisible. > + * I think the close button is visible by default, isn't it? REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-31 Thread David Redondo
davidre added a comment. In D27035#603619 , @dhaumann wrote: > Better :) with corners I mean the 1-3 pixels left due to the rounding corners. These pixels were once also drawn as background although they are outside of the frame. It may be a

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-31 Thread David Redondo
davidre updated this revision to Diff 74766. davidre marked an inline comment as done. davidre added a comment. Use parentWidget() REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27035?vs=74714=74766 BRANCH no-css (branched from master) REVISION

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-31 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > kmessagewidget.cpp:317 > +constexpr float alpha = 0.2; > +const auto parentWidget = qobject_cast(parent()); > +const QColor parentWindowColor = (parentWidget ? parentWidget->palette() > : qApp->palette()).color(QPalette::Window); I

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread David Redondo
davidre added inline comments. INLINE COMMENTS > kmessagewidget.cpp:39 > + > +constexpr int borderSize = 2; > + I don't think so: > internal linkage > [...] > variables, variable templates (since C++14), functions, or function templates > declared static; > non-volatile non-template (since

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread David Redondo
davidre added a comment. Kate with this patch and Oxygen style: F8030118: Screenshot_20200130_181731.PNG The misplacement I spotted earlier is specific to QtCurve and also happens with the current KMessageWidget. REPOSITORY R236 KWidgetsAddons

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread David Redondo
davidre updated this revision to Diff 74714. davidre added a comment. Draw opaque and mix the colors manually again. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27035?vs=74697=74714 BRANCH no-css (branched from master) REVISION DETAIL

D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme

2020-01-30 Thread David Redondo
davidre updated this revision to Diff 74713. davidre added a comment. Fix code style REPOSITORY R252 Framework Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27039?vs=74704=74713 BRANCH messagewidget (branched from master) REVISION DETAIL

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread David Redondo
davidre added a comment. In D27035#603460 , @dhaumann wrote: > Does that also work in Kate for floating messages like when the search wraps? What I want to know is whether the corners behind the green frame are transparent in this case, or

D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet

2020-01-30 Thread David Redondo
davidre added a comment. In D27035#603460 , @dhaumann wrote: > Does that also work in Kate for floating messages like when the search wraps? What I want to know is whether the corners behind the green frame are transparent in this case, or

  1   2   3   >