D6197: Add basic KAuth support to file ioslave

2017-06-19 Thread Elias Probst
eliasp added inline comments. INLINE COMMENTS > file.h:107 > +}; > +bool execWithRoot(const QString , const QString , const > QVariant , PriviledgeWarning warning); > +void endPriviledgeOp(); I find `execWithRoot()` to be a bit misleading, as the goal shouldn't be to always

Re: What environment variable defines where krunner looks for libkdeinit5_$app.so

2015-06-06 Thread Elias Probst
On 06/06/2015 11:31 PM, David Faure wrote: Problem number 2: this kdeinit5 dlopen stuff is supposed to be optional, kdeinit should fallback to executing the binary, otherwise. I.e. this code is supposed to clear libpath and keep only execpath, and find it (kwrite) in $PATH. Related bug:

Review Request 121949: Add name of consumer to kservice_desktop_to_json() deprecation warning.

2015-01-09 Thread Elias Probst
() in your CMake code. ``` This makes it definitely far easier to update the affected applications. Thanks, Elias Probst ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121949: Add name of consumer to kservice_desktop_to_json() deprecation warning.

2015-01-09 Thread Elias Probst
use kcoreaddons_desktop_to_json() for Konsole Profiles instead of kservice_desktop_to_json() in your CMake code. ``` This makes it definitely far easier to update the affected applications. Thanks, Elias Probst ___ Kde-frameworks-devel mailing list

Review Request 121953: Add filename to KPluginInfo::property() deprecation notice.

2015-01-09 Thread Elias Probst
instead. ``` Thanks, Elias Probst ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121953: Add filename to KPluginInfo::property() deprecation notice.

2015-01-09 Thread Elias Probst
KPluginInfo::pluginName() in /usr/lib64/qt5/plugins/plasma/dataengine/plasma_engine_tasks.so instead. ``` Thanks, Elias Probst ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 121958: Deprecate kservice_desktop_to_json(), use kcoreaddons_desktop_to_json().

2015-01-09 Thread Elias Probst
, Elias Probst ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121958: Deprecate kservice_desktop_to_json(), use kcoreaddons_desktop_to_json().

2015-01-09 Thread Elias Probst
://git.reviewboard.kde.org/r/121958/diff/ Testing --- Builds + installs as expected Thanks, Elias Probst ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120267: Don't run kioexec if we are already running it

2014-10-03 Thread Elias Probst
much about the quality of the patch -- needs someone with some more domain-specific knowledge to give you a ship it. - Elias Probst On Sept. 18, 2014, 4:33 p.m., Maarten De Meyer wrote: --- This is an automatically generated e-mail

Compression of SVG(Z)s in git repositories

2014-09-02 Thread Elias Probst
I've noticed, that (except of only a very few) nearly all SVG files are committed as SVGZ to our git repositories. This has IMHO several drawbacks: - every change will be stored as a single atomic blob - git's internal packfile compression and deduplication can't be used - no diffs for changes

Re: Compression of SVG(Z)s in git repositories

2014-09-02 Thread Elias Probst
On 09/02/2014 12:48 PM, Martin Gräßlin wrote: On Tuesday 02 September 2014 12:27:11 Sebastian Kügler wrote: On Monday, September 01, 2014 12:59:04 Elias Probst wrote: I've noticed, that (except of only a very few) nearly all SVG files are committed as SVGZ to our git repositories. This has

Re: What to do with autostart scripts? (kinit / ksmserver problem)

2014-09-02 Thread Elias Probst
On 08/19/2014 09:48 PM, David Faure wrote: What do the gurus say on this? I'd pick option 1 - do it all in ksmserver. I'd vote against this and vote for: - only *.desktop files The reason: in the long term, we're going to add support for systemd user-sessions. This will bring a huge cleanup

Re: Review Request 118853: Log name + size of not found icons in debug output

2014-06-23 Thread Elias Probst
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118853/#review60646 --- On June 21, 2014, 2:53 a.m., Elias Probst wrote

Review Request 118853: Log name + size of not found icons in debug output

2014-06-20 Thread Elias Probst
for size 48 Thanks, Elias Probst ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 118841: Add notify to colorGroup property

2014-06-19 Thread Elias Probst
properties: ColorScope::colorGroup - Elias Probst On June 19, 2014, 9:34 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118841

Usage of ~/.config vs ~/.config/kde.org

2014-05-03 Thread Elias Probst
Currently all KF5/Workspaces configuration files end up in ~/.config. Looking at my personal ~/.config, it seems that nearly all other applications and desktop-environments make use of a subdirectory to prevent spamming the toplevel directory and isolate the related config files nicely. Compared