D12002: Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway

2018-05-16 Thread Fabian Kosmale
This revision was automatically updated to reflect the committed changes. Closed by commit R302:49f871844632: Check if group LastGroup, as KIconEffect doesnt handle UserGroup anyway (authored by fabiank). Restricted Application edited subscribers, added: kde-frameworks-devel; removed:

D11998: Ensure that the model is set when resetResizing is called

2018-04-07 Thread Fabian Kosmale
This revision was automatically updated to reflect the committed changes. Closed by commit R241:bff960d67162: Ensure that the model is set when resetResizing is called (authored by fabiank). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11998?vs=31525=31578

D11993: Tweak column widths in tree view of file open/save dialogs

2018-04-06 Thread Fabian Kosmale
fabiank added a comment. I'm to tired to test this myself, but could you please test this with the edge case where some file names are so long that they don't fit in the view? Also, Stretch disables manual resizing, right?' If that is also deemed useful, we could adapt the solution from

D12002: Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway

2018-04-06 Thread Fabian Kosmale
fabiank added reviewers: mart, dfaure, mlaurent. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D12002 To: fabiank, mart, dfaure, mlaurent Cc: #frameworks, michaelh, ngraham, bruns

D12002: Check if group < LastGroup, as KIconEffect doesn't handle UserGroup anyway

2018-04-06 Thread Fabian Kosmale
fabiank created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. fabiank requested review of this revision. TEST PLAN Run the steps described in the testplan of D12001 . Without the

D11998: Ensure that the model is set when resetResizing is called

2018-04-06 Thread Fabian Kosmale
fabiank added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11998 To: fabiank, dfaure Cc: #frameworks, michaelh, ngraham, bruns

D11998: Ensure that the model is set when resetResizing is called

2018-04-06 Thread Fabian Kosmale
fabiank created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. fabiank requested review of this revision. REVISION SUMMARY Previously, KDirOperatorDetailView::setModel called resetResizing before QTreeView::setModel

D11768: Add Desktop and Downloads to the default list of Places

2018-03-29 Thread Fabian Kosmale
fabiank added a comment. In D11768#236349 , @ngraham wrote: > In Neon and Kubuntu, ~/Desktop exists for a new user by default. Is this not the case in other distros? I'm not sure what is currently done, but I'm pretty sure in Chakra we

D10927: Apply fixes to simple clazy warnings

2018-03-04 Thread Fabian Kosmale
This revision was automatically updated to reflect the committed changes. Closed by commit R284:29e7a1d89278: Apply fixes to simple clazy warnings (authored by fabiank). REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10927?vs=28288=28597 REVISION DETAIL

D10927: Apply fixes to simple clazy warnings

2018-02-28 Thread Fabian Kosmale
fabiank retitled this revision from "Use const methods to prevent container from detaching KHistoryComboBox: reserve list before populating it" to "Apply fixes to simple clazy warnings". fabiank edited the summary of this revision. REPOSITORY R284 KCompletion REVISION DETAIL