D24015: Added scripts to create a webfont out of all breeze action icons

[Fabian Riethmayer]

fabianr closed this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24015

To: fabianr, ndavis, ognarb
Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24015: Added scripts to create a webfont out of all breeze action icons

[Fabian Riethmayer]

fabianr added inline comments.

INLINE COMMENTS

> ognarb wrote in Gruntfile.js:13
> why not true?

From
https://www.npmjs.com/package/grunt-webfont

> optimize
> 
> Type: boolean Default: true
> 
> If false the SVGO optimization will not be used. This is useful in cases 
> where the optimizer will produce faulty web fonts by removing relevant SVG 
> paths or attributes.

Since we create a pretty large webfont and some icons are quiet complicated, I 
set it to false for the moment, to minimize the chance for broken glyphs.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24015

To: fabianr, ndavis
Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24015: Added scripts to create a webfont out of all breeze action icons

[Fabian Riethmayer]

fabianr added a reviewer: ndavis.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D24015

To: fabianr, ndavis
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24015: Added scripts to create a webfont out of all breeze action icons

[Fabian Riethmayer]

fabianr created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
fabianr requested review of this revision.

REVISION SUMMARY
  Added a grunt task for generating (web)fonts out of the breeze action svg 
icons

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24015

AFFECTED FILES
  .gitignore
  webfont/Gruntfile.js
  webfont/README
  webfont/package.json
  webfont/yarn.lock

To: fabianr
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D17906: [kirigami] Do not use light font styles for headings (2/3)

[Fabian Riethmayer]

fabianr added a comment.


  In D17906#388294 , @filipf wrote:
  
  > Updating an another computer to Frameworks 5.53 and Qt 5.12 I get the same 
problem.
  >
  > F6531867: image.png 
  >
  > F6531893: image.png 
  >
  > For me this represented a massive regression, and there's bound to be more 
people in a similar situation. We can't have this happening.
  
  
  You are not using the default font, are you?

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: fabianr, rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, 
plasma-devel, dkardarakos, apol, davidedmundson, hein

D17906: [kirigami] Do not use light font styles for headings (2/3)

[Fabian Riethmayer]

fabianr added a comment.


  The HIG states: "When the visual design calls for an area of exceptional 
focus, a larger typeface size may be used. In this case use a Light typeface 
weight to keep the stroke width similar to other styles throughout the 
interface"
  
  I think, if you want to have something like F6531451: 
Screenshot_20190107_145258.png  you 
should use your own special sized label. And if you want to add so much focus 
on a text, it can be unique in its font size.
  
  To me it seams the predefined Header[1-4] are mainly to be used for regular 
content and chrome?

REPOSITORY
  R169 Kirigami

BRANCH
  no-light-headings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17906

To: filipf, ngraham, #plasma, #vdg, #frameworks
Cc: fabianr, rooty, #frameworks, ngraham, #plasma, #vdg, abetts, mart, 
plasma-devel, dkardarakos, apol, davidedmundson, hein

D17190: Add level api from Kirigami.Heading

[Fabian Riethmayer]

fabianr edited the summary of this revision.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D17190

To: mart, #plasma, #vdg
Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D8056: Improve usability of "Open With" dialog by adding option to filter the application tree

[Fabian Riethmayer]

fabianr added a comment.


  Not really on topic, but could you change the label for the "Advanced 
options" to something more meaningful, eg "Terminal options" ? The HIG 
recommends not to use the label "Advanced options", but " Use a descriptive 
label so that it reflects the functionality. "

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D8056

To: simgunz, dfaure, #frameworks, #vdg, ngraham
Cc: fabianr, abetts, ngraham, alexeymin, #frameworks