D29802: Require out-of-source builds

2020-05-17 Thread Filip Fila
filipf accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  require-in-source-build (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29802

To: ngraham, #frameworks, #vdg, ognarb, davidre, apol, nicolasfella, ndavis, 
tfella, filipf
Cc: ltoscano, davidre, kde-frameworks-devel, LeGast00n, cblack, michaelh, 
ngraham, bruns


D29740: [PC3 Button] Don't remain in a pressed state after press

2020-05-14 Thread Filip Fila
filipf added a comment.


  The more I think about this the more it feels like a workaround. Presuming 
QQC2's behavior of leaving a pressed button focused after press is correct, 
perhaps we are at fault for providing the same svg for `focus-background` and 
`pressed`.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  dont-remain-pressed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29740

To: filipf, davidedmundson, mart, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29740: [PC3 Button] Don't remain in a pressed state after press

2020-05-14 Thread Filip Fila
filipf added a dependent revision: D29741: [Logout] Port to QQC2 and PC3.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29740

To: filipf, davidedmundson, mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29740: [PC3 Button] Don't remain in a pressed state after press

2020-05-14 Thread Filip Fila
filipf edited the summary of this revision.
filipf edited the test plan for this revision.
filipf added reviewers: davidedmundson, mart, Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29740

To: filipf, davidedmundson, mart, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29740: [PC3 Button] Don't remain in a pressed state after press

2020-05-14 Thread Filip Fila
filipf created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
filipf requested review of this revision.

REVISION SUMMARY
  We have two interfering button background items right now:
  
  - surfaceNormal when it has activeFocus and is using using the 
"focus-background" item
  - surfacePressed
  
  After a button is pressed surfacePressed correctly disappears but 
surfaceNormal remains in the "focus-background" state, thereby making the 
button still look pressed.
  
  The problem is that the button still has activeFocus even after a press.
  
  To solve this we switch the "focus-background" to only show up on 
visualFocus. Per Qt documentation on visual Focus:
  "In general, for visualizing key focus, this property is preferred over 
Item::activeFocus. This ensures that key focus is only visualized when 
interacting with keys - not when interacting via touch or mouse."
  
  Given that we have surfacePressed for focus accomplished with a mouse or 
touch, visualFocus will only detect tabbing and therefore the button no longer 
remains pressed after a press and behaves like its PC2 counterpart.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  dont-remain-pressed (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29740

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml

To: filipf
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


Re: Adding a patch to 5.70

2020-05-03 Thread Filip Fila
Thank you, David!

On Sun, May 3, 2020 at 7:08 PM David Faure  wrote:

> On Sunday, May 3, 2020 6:31:44 PM CEST Filip Fila wrote:
> > Dear Frameworks maintainers,
> >
> > Would it be possible to add this (https://phabricator.kde.org/D29352)
> patch
> > to the 5.70 release?
> >
> > The change concerns not breaking third-party Plasma themes, and as Nate
> > explained "If this doesn't land in Frameworks 5.70, Plasma 5.19 users run
> > the risk of being hit by it, as 5.70 is the frameworks dependency for
> that
> > Plasma release."
>
> OK, done:
>
> plasma-framework v5.70.0-rc2
> fe45d59e250d1c7f4579f54fec52437ebb0e5d03
> cb8289d495e4df19056ce8814dacd8a0afe93bff1edb0352028c6b6e47364ba5
> sources/plasma-framework-5.70.0.tar.xz
>
>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
>
>
>


Adding a patch to 5.70

2020-05-03 Thread Filip Fila
Dear Frameworks maintainers,

Would it be possible to add this (https://phabricator.kde.org/D29352) patch
to the 5.70 release?

The change concerns not breaking third-party Plasma themes, and as Nate
explained "If this doesn't land in Frameworks 5.70, Plasma 5.19 users run
the risk of being hit by it, as 5.70 is the frameworks dependency for that
Plasma release."

Sorry to trouble you :/
Filip


D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

2020-05-03 Thread Filip Fila
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:1b1018e68703: [Plasmoid Heading] Draw the heading only 
when there is an SVG in the theme (authored by filipf).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29352?vs=81711=81808

REVISION DETAIL
  https://phabricator.kde.org/D29352

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml

To: filipf, #vdg, #plasma, niccolove, ngraham
Cc: ngraham, niccolove, kde-frameworks-devel, LeGast00n, cblack, michaelh, bruns


D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

2020-05-01 Thread Filip Fila
filipf edited the test plan for this revision.
filipf added reviewers: VDG, Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D29352

To: filipf, #vdg, #plasma
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D29352: [Plasmoid Heading] Draw the heading only when there is an SVG in the theme

2020-05-01 Thread Filip Fila
filipf created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
filipf requested review of this revision.

REVISION SUMMARY
  We're the only theme with the appropriate heading svgs that make the headers 
and footers look as they should.
  
  All the other themes fall back to Breeze, which is not a good look for some 
of them:
  
  - the heading is too jarring compared to applet background
  - the heading does not extend all the way vertically and horizontally
  
  To solve this, to avoid degrading unmaintained themes and to give themes a 
chance to adjust on their own terms, this patch makes the heading visible only 
when the needed SVG exists in the theme.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  heading-only-if-svg-exists (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29352

AFFECTED FILES
  src/declarativeimports/plasmaextracomponents/qml/PlasmoidHeading.qml

To: filipf
Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns


D28353: Changed contrast effect values to have more transparency, and then changed transparency accordingly

2020-04-28 Thread Filip Fila
filipf added a comment.


  LGTM

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D28353

To: niccolove, #vdg, #plasma, cblack
Cc: filipf, ngraham, cblack, kde-frameworks-devel, LeGast00n, michaelh, bruns


D27299: Vertically center tooltip icon/image

2020-02-10 Thread Filip Fila
filipf accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  vertically-center-tooltip-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27299

To: ngraham, #vdg, #plasma, filipf
Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns


D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-10 Thread Filip Fila
filipf added a comment.


  Right, I also noticed the color-aware theme now has somewhat more pronounced 
discrepancy between the panel and the popups when dark color schemes are used.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, 
manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, 
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart


D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-09 Thread Filip Fila
filipf added a comment.


  Arcpatched and compiled and I was getting an overly transparent Breeze Dark:
  
  F8094138: image.png 
  
  It was only when I turned Contrast Effect off and then on again that I was 
seeing what's in the test plan.
  
  We should still investigate this because I also reproduced it in a different 
install.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove, ndavis, ngraham, cblack
Cc: cblack, ndavis, filipf, ngraham, davidedmundson, kde-frameworks-devel, 
manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, 
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ZrenBot, firef, 
bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart


D27122: Tweaked contrast effect values, adjusted transparency accordingly, switched from Background to ViewBackground

2020-02-03 Thread Filip Fila
filipf added a comment.


  I really like this all in all, and the light version looks ready to go.
  
  The transparency in the dark one if fine IMO, it's just that the Breeze Dark 
color scheme should be somewhat darker and then the Plasma theme would also be 
darker.
  
  What's more important is we try to blend in the panel with the popup like in 
the light version.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D27122

To: niccolove
Cc: filipf, ngraham, davidedmundson, kde-frameworks-devel, manueljlin, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, 
Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, michaelh, crozbo, ndavis, 
ZrenBot, firef, bruns, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart


D25015: Update breeze theme shadows

2020-01-23 Thread Filip Fila
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:35351ba3f299: Update breeze theme shadows (authored by 
niccolove, committed by filipf).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25015?vs=74153=74206

REVISION DETAIL
  https://phabricator.kde.org/D25015

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/translucent/dialogs/background.svg
  src/desktoptheme/breeze/translucent/widgets/panel-background.svg
  src/desktoptheme/breeze/translucent/widgets/tooltip.svg
  src/desktoptheme/breeze/widgets/panel-background.svg
  src/desktoptheme/breeze/widgets/tooltip.svg

To: niccolove, #vdg, ngraham, The-Feren-OS-Dev, ndavis
Cc: The-Feren-OS-Dev, mart, broulik, cblack, ndavis, manueljlin, ngraham, 
filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D25999: Add optional subtitle to grid delegate

2019-12-14 Thread Filip Fila
filipf added a comment.


  ^ No, it seems to be GridDelegate actually.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D25999

To: ngraham, #vdg, #plasma, davidedmundson
Cc: filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D25999: Add optional subtitle to grid delegate

2019-12-14 Thread Filip Fila
filipf added a comment.


  In D25999#577780 , @ngraham wrote:
  
  > It does, because we can't know in advance whether or not any delegates will 
set a subtitle. Actually... can we know this?
  
  
  Yeah if we could it wouldn't be bad to add a condition.
  
  Although honestly after testing this live I don't really mind the added 
padding from a visual POV.
  
  There's a content overflow problem in the colors KCM now though:
  
  F7818412: image.png 
  
  It's only related to the change in GridViewInternal.qml.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D25999

To: ngraham, #vdg, #plasma, davidedmundson
Cc: filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D25999: Add optional subtitle to grid delegate

2019-12-14 Thread Filip Fila
filipf added a comment.


  Thanks, I'll tweak my patch to use this.
  
  Does the implementation increase the horizontal spacing between delegates 
even if there are no subtitles present?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D25999

To: ngraham, #vdg, #plasma, davidedmundson
Cc: filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D25999: Add optional subtitle to grid delegate

2019-12-14 Thread Filip Fila
filipf added a dependent revision: D25785: [Plasma Style KCM] Add a color-wheel 
sign denoting the theme supports the system color scheme.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D25999

To: ngraham, #vdg, #plasma, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D25927: [PC3] Complete plasma progress bar animation

2019-12-13 Thread Filip Fila
filipf accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25927

To: davidedmundson, filipf
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D25926: [PC3] Only show progress bar indicator when the ends won't overlap

2019-12-13 Thread Filip Fila
filipf accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25926

To: davidedmundson, #plasma, filipf
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-13 Thread Filip Fila
filipf added a comment.


  In D25699#576444 , @fvogt wrote:
  
  > This fixed the button label, but the menu itself is unsuable due to a black 
text on dark background: 
https://openqa.opensuse.org/tests/1110939#step/start_wayland_plasma5/21
  
  
  We've had several bugs due to the QQC2 and PC3 port and with the (LTS) 
release date being closer, we've reverted that port for now.
  
  We'll have to figure this out at some point in the future though.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham, davidedmundson
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns


D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-11 Thread Filip Fila
filipf added a comment.


  Let's track the arrow issue in: https://bugs.kde.org/show_bug.cgi?id=415049

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham, davidedmundson
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns


D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-11 Thread Filip Fila
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:e4e1613b0fe7: [PC3 ToolButton] Have the label take into 
account complementary color schemes (authored by filipf).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25699?vs=70789=71268

REVISION DETAIL
  https://phabricator.kde.org/D25699

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: filipf, #plasma, ngraham, davidedmundson
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns


D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-11 Thread Filip Fila
filipf edited the summary of this revision.
filipf edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham, davidedmundson
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns


D25814: [KColorScheme] Add SeparatorColor

2019-12-09 Thread Filip Fila
filipf added a comment.


  In D25814#574389 , @ngraham wrote:
  
  > In D25814#574380 , @ndavis wrote:
  >
  > > FWIW, Adwaita Dark uses dark separators, but GNOME doesn't use nearly as 
many icons as we do. F7806761: Screenshot_20191209_155912.png 

  >
  >
  > To me, this image really shows how good the dark separators look. I don't 
think the fact that our UIs are more icon-heavy is a significant factor here. 
Unlike GNOME, we tend to use ToolButtons, which have no outline until hovered 
over. So in fact there are probably fewer lines with the separator color in our 
Toolbutton-heavy UIs compared to GNOME.
  
  
  Already asked in VDG, but repeating here: how would we handle dark separators 
on really dark color schemes?
  
  This is the most downloaded color scheme and it won't work well with dark 
separators: https://store.kde.org/p/1294011/

REPOSITORY
  R265 KConfigWidgets

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg
Cc: ngraham, davidedmundson, filipf, cfeck, hpereiradacosta, 
kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D25822: Add manual test for changing colorscope in components

2019-12-09 Thread Filip Fila
filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  Thanks again :)

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25822

To: davidedmundson, filipf
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D25822: Add manual test for changing colorscope in components

2019-12-09 Thread Filip Fila
filipf added a comment.


  In D25822#574271 , @ngraham wrote:
  
  > Nice. Does this fix or obsolete D25699 ?
  
  
  No, this just for easier testing of all the components with the complementary 
theme.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25822

To: davidedmundson, filipf
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D25822: Add manual test for changing colorscope in components

2019-12-09 Thread Filip Fila
filipf added a comment.


  Thanks! It will be easier to test now.
  
  I noticed some issues with certain tests, although most seem to have already 
existed:
  
  - busyindicator3.qml -> loads, but complains about a binding loop detected 
for `implicitHeight`
  - button3.qml -> doesn't load, says `Label` is not a type
  - checkbox3.qml -> doesn't load, says `Label `is not a type
  - **combobox.qml -> doesn't load, says it cannot assign object to list 
property `children` **
  - **progressbar.qml -> loads but complains that `root` is not defined **
  - **progressbar3.qml -> loads but complains that `barSvg` is not defined**
  - **radiobutton.qml -> doesn't load, say it expects token `,` at line 9**
  - radiobutton3.qml -> doesn't load, says `Label` is not a type
  
  The ones in bold seem to be related to this patch, but I can fix all of this 
in a separate patch after this one.

INLINE COMMENTS

> radiobutton.qml:8
> +ComponentBase {
>  {
>  Grid {

Two curly braces.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25822

To: davidedmundson, filipf
Cc: ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns


D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-09 Thread Filip Fila
filipf added subscribers: davidedmundson, mart.
filipf added a comment.


  Yeah, PC2 ToolButton has this so it loads the arrow: 
https://github.com/KDE/plasma-framework/blob/master/src/declarativeimports/plasmastyle/ToolButtonStyle.qml#L110
  
  For PC3 I guess we would have to hack it in in the sddm-theme code...
  
  @mart and @davidedmundson are there plans for PC3 to have a menu property 
like PC2?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham
Cc: mart, davidedmundson, fvogt, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns


D25820: SimpleScreenRecorder icon added

2019-12-08 Thread Filip Fila
filipf added a comment.


  I agree, I think brighter and slightly less saturated colors would look nice.
  
  Thank you for adding this btw, the old icon doesn't fit in.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D25820

To: vinzenzv, #vdg, ndavis
Cc: filipf, ndavis, kde-frameworks-devel, LeGast00n, fbampaloukas, GB_2, 
trickyricky26, michaelh, ngraham, bruns


D25814: [KColorScheme] Add SeparatorColor

2019-12-08 Thread Filip Fila
filipf added a comment.


  I think this is useful. Every once in a while we get opinionated people who 
think light separators are awful in the Breeze Dark scheme (I would hate dark 
ones on the other hand) or even some ricer people who want to turn off 
separators (which they could do now by matching it with window color I guess).
  
  Implementation-wise there definitely always needs to be a fallback value so 
we don't break third-party color-schemes.

REPOSITORY
  R265 KConfigWidgets

BRANCH
  separator-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25814

To: ndavis, #frameworks, #vdg, dfaure
Cc: filipf, cfeck, hpereiradacosta, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns


D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-07 Thread Filip Fila
filipf added a comment.


  In D25699#573713 , @fvogt wrote:
  
  > The check for the prefix was added in 
`bf1d1cc6b2ad37cb586f44b56fa2438ed3a5dbfc`, while the `control.flat` one got 
added much earlier.
  >
  > The labels are visible again with just the `control.flat` condition, but 
the prefix one might be needed as well for non-breeze themes.
  >
  > There's a part missing though, the triangle (visible on 
https://openqa.opensuse.org/tests/1105226#step/start_wayland_plasma5/21) is 
gone. That seems to be a feature lost with PC3 :-(
  
  
  Thanks for looking into the patch.
  
  Yeah, the triangle seems to be missing :/ possibly because PC2 has a menu 
property and PC3 doesn't... I will investigate further.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham
Cc: fvogt, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-07 Thread Filip Fila
filipf edited the summary of this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D25340: Added background colors to active and inactive icon view

2019-12-06 Thread Filip Fila
filipf added a comment.


  In D25340#563400 , @ndavis wrote:
  
  > This diff is against commit 467d721cc96258b54048c0dd1508d16e03c0cd55, which 
isn't in git master. Do I actually need that commit for this patch to work?
  
  
  A similar issue still exists, but it does apply against master.
  
  Gave this is a quick spin and it definitely looks like an improvement.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25340

To: niccolove, #vdg, ngraham
Cc: filipf, manueljlin, ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns


D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-02 Thread Filip Fila
filipf edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-02 Thread Filip Fila
filipf edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-02 Thread Filip Fila
filipf edited the test plan for this revision.
filipf added a reviewer: Plasma.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25699

To: filipf, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D25699: [PC3 ToolButton] Have the label take into account complementary color schemes

2019-12-02 Thread Filip Fila
filipf created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
filipf requested review of this revision.

REVISION SUMMARY
  We've ported the SDDM theme to PC3 and now have black labels in PC3 
ToolButtons (keyboard and session button).
  
  The SDDM theme uses a complementary color scheme, which is something the PC2 
ToolButton respects and turns the labels white.
  
  Therefore I just copy pasted PC2's label color code to its PC3 counterpart: 
https://github.com/KDE/plasma-framework/blob/master/src/declarativeimports/plasmastyle/ToolButtonStyle.qml

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  ok-text-colo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25699

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/ToolButton.qml

To: filipf
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D25015: Update breeze theme shadows

2019-11-27 Thread Filip Fila
filipf added a comment.


  My impression is that the rounding is currently just faked by the shadow. So 
when the shadow gets lighter, it becomes more obvious that the object itself 
isn't really rounded.
  
  F7787609: image.png 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg, ngraham
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns


D25015: Update breeze theme shadows

2019-11-17 Thread Filip Fila
filipf added a comment.


  +1

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns


D25015: Update breeze theme shadows

2019-11-06 Thread Filip Fila
filipf added a comment.


  Before:
  F7746042: Screenshot_20191107_083508.png 

  
  After:
  F7746044: Screenshot_20191107_083534.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns


D25015: Update breeze theme shadows

2019-11-06 Thread Filip Fila
filipf added a comment.


  There's definitely a difference, whereas the shadows are now rough and dark 
this is subtler.
  
  I'd suggest testing this patch with a light color scheme and then switching 
to the unpatched theme plus testing against light backgrounds to notice the 
changes.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns


D25015: Update breeze theme shadows

2019-11-06 Thread Filip Fila
filipf added a comment.


  I'd prefer the shadows to have equal strength all around, I couldn't get used 
to weaker shadows in the corners.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: manueljlin, ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns


D25015: Update breeze theme shadows

2019-10-28 Thread Filip Fila
filipf added a comment.


  Testing it. Usability wise the strength is perfectly fine; the shadows still 
do their job.
  
  Visually it's a definitive improvement for me.
  
  Only thing I'm not sure of is the weaker strength in the corners, but I'm 
going to keep testing to see if it's just a matter of getting used to it.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg
Cc: filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D24593: Modified breeze shadows

2019-10-13 Thread Filip Fila
filipf added a comment.


  > b) radial gradients instead of linear on the four sides to make the center 
darker than the angles.
  
  Other than this, they look great to me. I think they should be uniformly 
dispersed.
  
  One of the things with shadows is that the user shouldn't really notice them. 
With the radial style I can't help but notice there's shadows missing in the 
corners.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, bruns


D23627: Make notification icons use outline style

2019-09-01 Thread Filip Fila
filipf added a comment.


  +1, looks good, thanks for centering the clapper as well

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D23627

To: ndavis, #vdg, #plasma
Cc: filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns


D23286: Prevent dragging SimpleKCM contents outside view

2019-08-20 Thread Filip Fila
filipf added a comment.


  +1 visually
  
  If the behavior is important on mobile let's keep it there of course, but on 
desktop it feel out of place.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D23286

To: GB_2, #plasma, #frameworks, #vdg
Cc: filipf, broulik, #vdg, #frameworks, kde-frameworks-devel, #plasma, 
LeGast00n, GB_2, michaelh, ngraham, bruns


D23285: Prevent dragging QQC2 ComboBox contents outside menu

2019-08-20 Thread Filip Fila
filipf accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  prevent-dragging-qqc2-combobox-contents-outside-menu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23285

To: GB_2, #plasma, #frameworks, #vdg, filipf
Cc: #vdg, #frameworks, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D22822: Add "users-other" icon

2019-07-31 Thread Filip Fila
filipf added a reviewer: ndavis.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D22822

To: GB_2, #vdg, ndavis
Cc: kde-frameworks-devel, #vdg, LeGast00n, sbergeron, michaelh, ngraham, bruns


D22827: Scrollview - Don't fill the parent with the view

2019-07-30 Thread Filip Fila
filipf added a comment.


  Also fixes the Virtual Desktops KCM fwiw
  
  F7120294: image.png 
  
  F7120298: image.png 

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22827

To: davidre, mart
Cc: filipf, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns


D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

2019-07-04 Thread Filip Fila
filipf accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R296 KDeclarative

BRANCH
  grid-delegate-rectangle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg, filipf
Cc: filipf, GB_2, ngraham, kde-frameworks-devel, LeGast00n, michaelh, bruns


D22108: [TabBar] Remove exterior margins

2019-06-30 Thread Filip Fila
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:97272465a8b4: [TabBar] Remove exterior margins (authored 
by filipf).

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22108?vs=60704=60896

REVISION DETAIL
  https://phabricator.kde.org/D22108

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/TabBar.qml

To: filipf, #vdg, #plasma, ngraham, ndavis
Cc: ndavis, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D21813: RFC: Consider adding more padding to the desktop theme

2019-06-30 Thread Filip Fila
filipf added a comment.


  friendly ping
  
  @ndavis would you be willing to give it a go at making a proper patch for 
this (i.e. editing the Breeze svg)?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: martinsotirov, abetts, ndavis, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns


D22108: [TabBar] Remove exterior margins

2019-06-27 Thread Filip Fila
filipf added a comment.


  In D22108#487218 , @ndavis wrote:
  
  > 1+ visually. How does it look with a vertical panel?
  
  
  Still not gliding on the line, but that should be resolved in Kickoff somehow:
  
  F6938487: image.png 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D22108

To: filipf, #vdg, #plasma, ngraham
Cc: ndavis, apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D22108: [TabBar] Remove exterior margins

2019-06-27 Thread Filip Fila
filipf added a comment.


  In D22108#487140 , @apol wrote:
  
  > Makes sense to me, but why are the computer icons different? ^^'
  
  
  Some bug in Kickoff or with the icon, sometimes (maybe after you change a 
desktop theme) it shows the laptop icon, and then after a while the monitor 
icon. Should have made another screenshot but oh well :P

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D22108

To: filipf, #vdg, #plasma, ngraham
Cc: apol, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D22108: [TabBar] Remove exterior margins

2019-06-26 Thread Filip Fila
filipf edited the test plan for this revision.
filipf added reviewers: VDG, Plasma, ngraham.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D22108

To: filipf, #vdg, #plasma, ngraham
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D22108: [TabBar] Remove exterior margins

2019-06-26 Thread Filip Fila
filipf created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This allows us to glide active tabbar indicators on lines, which we cannot do 
now in Kickoff due to this limitation in the control.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  remove-tabbar-margins (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22108

AFFECTED FILES
  src/declarativeimports/plasmacomponents/qml/TabBar.qml

To: filipf
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D22102: Implement apply-on-double-click for all grid view KCM delegates

2019-06-26 Thread Filip Fila
filipf added a comment.


  Generally +1, but let's disable it for destructive kcms.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D22102

To: ngraham, #plasma, #vdg, mart, broulik
Cc: filipf, mglb, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D21907: Show feedback inline when creating new files or folders

2019-06-20 Thread Filip Fila
filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  Looks good from a visual and usability POV.

REPOSITORY
  R241 KIO

BRANCH
  better-new-file-folder-info (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21907

To: ngraham, #vdg, #frameworks, shubham, filipf
Cc: filipf, squeakypancakes, dhaumann, aacid, meven, kde-frameworks-devel, 
LeGast00n, michaelh, ngraham, bruns


D21919: Change joystick settings icon to game controller

2019-06-20 Thread Filip Fila
filipf accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  joystick-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21919

To: ndavis, #vdg, ngraham, filipf
Cc: usta, davidedmundson, kde-frameworks-devel, LeGast00n, michaelh, ngraham, 
bruns


D21813: RFC: Consider adding more padding to the desktop theme

2019-06-17 Thread Filip Fila
filipf added a comment.


  In D21813#481152 , @martinsotirov 
wrote:
  
  > I think Plasma needs a whole lot more padding all over the place, not just 
in the notifications, but I guess there must be some kind of compromise with 
all the people who like more cramped UIs.
  
  
  And in this case it would be easier if we implemented the changes in the 
desktop theme rather than in code because those wanting more cramped UIs could 
just use a different desktop theme (fork an old version e.g.).

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: martinsotirov, abetts, ndavis, kde-frameworks-devel, LeGast00n, michaelh, 
ngraham, bruns


D21813: RFC: Consider adding more padding to the desktop theme

2019-06-14 Thread Filip Fila
filipf added a comment.


  In D21813#479950 , @ndavis wrote:
  
  > Besides the notifications, where does this add padding?
  
  
  OSDs as far as I can tell, which are also actually not that roomy:
  
  F6890931: Screenshot_20190615_021457.png 

  
  Before:
  F6890933: Screenshot_20190615_021448.png 

  
  After:
  F6890935: Screenshot_20190615_021522.png 


REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: ndavis, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D21813: RFC: Consider adding more padding to the desktop theme

2019-06-14 Thread Filip Fila
filipf edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D21813: RFC: Consider adding more padding to the desktop theme

2019-06-14 Thread Filip Fila
filipf edited the test plan for this revision.
filipf added reviewers: Plasma, VDG, ngraham, broulik.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21813

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D21813: RFC: Consider adding more padding to the desktop theme

2019-06-14 Thread Filip Fila
filipf created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Instead of tweaking every plasmoid, add a bit more padding to the desktop 
theme.
  
  This would be an alternative solution to D21134 
.
  
  Another postive aspect of this approach is we wouldn't be tweaking paddings 
solely for our desktop theme.
  
  NOTE: The patch is just a copy-paste of Arc-color's background.svg so don't 
judge it based on the different corners or landability. It's meant to encourage 
discussion.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  more-padding-to-desktop-theme (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21813

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg

To: filipf
Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns


D21415: Fix the alignment of the label of the toolbutton

2019-06-01 Thread Filip Fila
filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  This is indeed not working as in PC2 so the change seems to be OK.
  
  I used the following code to test in qmlscene
  
import QtQuick 2.12
import org.kde.plasma.components 3.0 as PlasmaComponents

Rectangle {
width: 50
height: childrenRect.height
color: "black"

PlasmaComponents.ToolButton {
text: "1"
width: parent.width
}
}

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D21415

To: dkardarakos, #plasma, #vdg, filipf
Cc: filipf, ngraham, kde-frameworks-devel, michaelh, bruns


D21523: Add 22px notifications icons

2019-06-01 Thread Filip Fila
filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  Looks good, but also just a few words to the description about why we need 
this.

REPOSITORY
  R266 Breeze Icons

BRANCH
  notifications-22px (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21523

To: ndavis, #vdg, filipf
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns


D21521: Make Breeze Dark use same Kolourpaint icon as Breeze

2019-06-01 Thread Filip Fila
filipf accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  kolourpaint-app (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21521

To: ndavis, #vdg, filipf
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D21378: Make Breeze Light/Dark use more system colors

2019-05-24 Thread Filip Fila
filipf added a comment.


  In D21378#469611 , @ndavis wrote:
  
  > In D21378#469607 , @filipf wrote:
  >
  > > So I have a light widget color scheme, but I want to be using a dark 
Plasma theme. My color scheme is a bit funky and when I use Breeze Dark it 
doesn't respect my colors. So this is a good solution, +1 for the idea.
  > >
  > > I gave it a quick spin with Breeze Dark however and it's just not picking 
up some color schemes. It remains stuck on the colors of some previous scheme 
that worked. This seems to be random and may be a bug originating elsewhere so 
I'm hitting accept.
  >
  >
  > After changing the system colorscheme, did you try restarting plasmashell 
or switching to a different desktop theme and switching back? I'll admit, it's 
a bit janky, but it should work if you do that. It definitely seems like a bug 
that originates from elsewhere.
  
  
  Restarting plasmashell yes, switching to a different theme nope. But I did 
now and that seems to be working.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  less-custom-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart, filipf
Cc: filipf, lavender, kde-frameworks-devel, michaelh, ngraham, bruns


D21378: Make Breeze Light/Dark use more system colors

2019-05-24 Thread Filip Fila
filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  So I have a light widget color scheme, but I want to be using a dark Plasma 
theme. My color scheme is a bit funky and when I use Breeze Dark it doesn't 
respect my colors. So this is a good solution, +1 for the idea.
  
  I gave it a quick spin with Breeze Dark however and it's just not picking up 
some color schemes. It remains stuck on the colors of some previous scheme that 
worked. This seems to be random and may be a bug originating elsewhere so I'm 
hitting accept.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  less-custom-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21378

To: ndavis, #vdg, #plasma, mart, filipf
Cc: filipf, lavender, kde-frameworks-devel, michaelh, ngraham, bruns


D15814: show all borders for pop up windows in a dock

2019-05-04 Thread Filip Fila
filipf added a reviewer: VDG.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D15814

To: mvourlakos, #plasma, broulik, davidedmundson, kossebau, #vdg
Cc: kossebau, abetts, broulik, ngraham, kde-frameworks-devel, michaelh, bruns


D20977: [KeySequenceItem] Make the clear button have the same height as shortcut button

2019-05-03 Thread Filip Fila
This revision was automatically updated to reflect the committed changes.
Closed by commit R296:a2e42b49: [KeySequenceItem] Make the clear button 
have the same height as shortcut button (authored by filipf).

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20977?vs=57420=57458

REVISION DETAIL
  https://phabricator.kde.org/D20977

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/KeySequenceItem.qml

To: filipf, #vdg, ngraham, #frameworks, broulik, davidedmundson
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns


D20977: [KeySequenceItem] Make the clear button have the same height as shortcut button

2019-05-02 Thread Filip Fila
filipf edited the summary of this revision.
filipf edited the test plan for this revision.
filipf added reviewers: VDG, ngraham, Frameworks.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20977

To: filipf, #vdg, ngraham, #frameworks
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D20977: [KeySequenceItem] Make the clear button have the same height as shortcut button

2019-05-02 Thread Filip Fila
filipf created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Because the shortcut button has text inside it, its height is increased, 
which leaves the clear button shorter. We want the clear button to follow the 
shortcut's button height and to then readjust its width so it's a square.

REPOSITORY
  R296 KDeclarative

BRANCH
  same-button-height (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20977

AFFECTED FILES
  src/qmlcontrols/kquickcontrols/KeySequenceItem.qml

To: filipf
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

2019-04-29 Thread Filip Fila
filipf added a comment.


  Which still leaves you with fixing the gaps when there's not thumbnail. I'd 
suggest to do:
  
  `radius: thumbnailAvailable ? 0 : Kirigami.Units.smallSpacing / 2`
  
  and call it a day :P

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: filipf, GB_2, ngraham, kde-frameworks-devel, michaelh, bruns


D20140: [GridDelegate] Fix gaps in corners of thumbnailArea highlight

2019-04-29 Thread Filip Fila
filipf added a comment.


  You can fix the rounding bleeding into image previews by doing the following 
at line 116:
  
  `radius: thumbnailAvailable ? 0 : Kirigami.Units.smallSpacing`
  
  F6800947: image.png 

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D20140

To: ndavis, #plasma, #vdg
Cc: filipf, GB_2, ngraham, kde-frameworks-devel, michaelh, bruns


D19812: Add a web page to view and compare icons of different sizes

2019-04-26 Thread Filip Fila
filipf added a comment.


  In D19812#456848 , @ngraham wrote:
  
  > What is this giant javascript file with no whitespace that you're adding? I 
really don't like how it's formatted in such a way that makes the code 
practically impossible to read. This would be the perfect place to sneak in 
malware (not saying you or the author have done this, but that this kind of 
obfuscated code is a perfect vector for it).
  
  
  I have to strongly second this sentiment. What's the source of the 
`vue.min.js` file? At the very least code shouldn't be formatted this way, and 
if this was the base file I'm seeing it's not in its original form: 
https://github.com/vuejs/vue/blob/dev/dist/vue.js

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D19812

To: guoyunhe, ngraham, #vdg, ndavis, #breeze
Cc: filipf, trickyricky26, GB_2, pino, bcooksley, ngraham, 
kde-frameworks-devel, michaelh, bruns


D20672: Add an icon for Thunderbolt KCM

2019-04-18 Thread Filip Fila
filipf added a comment.


  In D20672#452757 , @ngraham wrote:
  
  > Even better! I think that gradient ends up a bit too light on top though. 
Let's make it a bit more subtle.
  
  
  +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20672

To: yurchor, #vdg
Cc: filipf, ngraham, kde-frameworks-devel, michaelh, bruns


D20673: [Properties dialog] Use the string "Free space" instead of "Disk usage"

2019-04-18 Thread Filip Fila
filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  Makes more sense.

REPOSITORY
  R241 KIO

BRANCH
  improve-free-space-string (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20673

To: ngraham, #vdg, filipf
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns


D20392: Use more appropriate "Alternatives" icon and text

2019-04-08 Thread Filip Fila
filipf accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  use-new-alternatives-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20392

To: ngraham, #vdg, #plasma, GB_2, filipf
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D20342: Update KDE logo to be closer to original

2019-04-08 Thread Filip Fila
filipf accepted this revision as: filipf.
filipf added a comment.
This revision is now accepted and ready to land.


  Looks good to me.

REPOSITORY
  R266 Breeze Icons

BRANCH
  update-kde-logo-to-be-closer-to-original (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D20342

To: GB_2, #vdg, #kde_promo, filipf
Cc: abetts, ndavis, filipf, ngraham, #kde_promo, kde-frameworks-devel, #vdg, 
michaelh, bruns


D20342: Update KDE logo to be closer to original

2019-04-08 Thread Filip Fila
filipf added a comment.


  So what I'm seeing is that the gradient has been toned down, which also 
results in a slight color change in general. FWIW I like the older version more 
because the new one seems flat(ter) in comparison. Not to long ago someone in 
VDG actually remarked that the official logo is kind of flat so if possible it 
would be cool IMO if we could add a gradient to it and keep these icons the way 
they were.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20342

To: GB_2, #vdg, #kde_promo
Cc: abetts, ndavis, filipf, ngraham, #kde_promo, kde-frameworks-devel, #vdg, 
michaelh, bruns


D15872: Fix Oxygen background gradient for QML modules

2019-04-04 Thread Filip Fila
filipf added a reviewer: Plasma.

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D15872

To: hwti, mart, #vdg, #plasma
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns


D15872: Fix Oxygen background gradient for QML modules

2019-04-04 Thread Filip Fila
filipf added a comment.


  Ping.
  
  Is this actually what's been causing the following problem?
  
  F6753947: image.png 

REPOSITORY
  R295 KCMUtils

REVISION DETAIL
  https://phabricator.kde.org/D15872

To: hwti, mart, #vdg
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns


D20063: Sublime Merge Icon.

2019-03-26 Thread Filip Fila
filipf added a comment.


  Looks good. Since it's a proprietary program just check if they have any 
restrictions about having to use their icons. And yep, the xmlerrors file 
should be removed.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D20063

To: otavva, #vdg, ndavis
Cc: filipf, ngraham, #vdg, kde-frameworks-devel, arvidhansson, ian, hannahk, 
Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, rooty, 
trickyricky26, mglb, michaelh, crozbo, ndavis, firef, bruns, skadinna, 
aaronhoneycutt, mbohlender


D17469: Give applications-games and input-gaming more contrast with Breeze Dark

2019-03-16 Thread Filip Fila
filipf accepted this revision.

REPOSITORY
  R266 Breeze Icons

BRANCH
  arcpatch-D17469 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17469

To: ndavis, #breeze, #vdg, guoyunhe, ngraham, rooty, filipf
Cc: rooty, abetts, ngraham, pstefan, ndavis, kde-frameworks-devel, michaelh, 
bruns


D19530: Avoid fractionals in GridDelegate sizes and alignments

2019-03-05 Thread Filip Fila
filipf added a comment.


  In D19530#424922 , @rooty wrote:
  
  > A lot easier on the eyes now, really nice fix
  >
  > This'll be landing in 5.16?
  
  
  KF 5.57 as far as I can tell.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19530

To: davidedmundson, #plasma, ngraham, rooty
Cc: rooty, ngraham, filipf, kde-frameworks-devel, michaelh, bruns


D19530: Avoid fractionals in GridDelegate sizes and alignments

2019-03-04 Thread Filip Fila
filipf added a comment.


  David this really does fix it! Previews are nice and sharp everywhere now.
  
  See before:
  F6657490: Screenshot_20190304_173527.png 

  
  And after:
  F6657492: Screenshot_20190304_231358.png 

  
  Notice how e.g. the 4 squares are sharp now?

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D19530

To: davidedmundson, #plasma
Cc: filipf, kde-frameworks-devel, michaelh, ngraham, bruns


D18986: [breeze-icons] Add video camera icons

2019-02-18 Thread Filip Fila
filipf added a comment.


  It's perhaps not the most used video camera design, but I'm cool with this. I 
too wouldn't use the Plasma icon; it makes more sense to put some multimedia 
icon there.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18986

To: rooty, #vdg, hein, ndavis
Cc: filipf, trickyricky26, ngraham, kde-frameworks-devel, michaelh, bruns


D19020: [breeze-icons] Revamp system.svgz

2019-02-18 Thread Filip Fila
filipf added a comment.


  I think the current revision is quite nice. We could always pick apart 
details and other potential solutions, but the icons get the point across and 
look good.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D19020

To: rooty, #vdg, #plasma, ngraham, abetts
Cc: filipf, trickyricky26, ndavis, broulik, kde-frameworks-devel, michaelh, 
ngraham, bruns


D19047: [GridDelegate] Fix long labels blending into each other

2019-02-15 Thread Filip Fila
filipf edited the summary of this revision.

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19047

To: filipf, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D19047: [GridDelegate] Fix long labels blending into each other

2019-02-15 Thread Filip Fila
filipf added a comment.


  In D19047#413025 , @ngraham wrote:
  
  > +1, definitely the correct fix.
  >
  > Let's land this now and then we can work on the UI improvement of enabling 
multi-line strings in another patch.
  
  
  Okay! :)

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19047

To: filipf, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D19047: [GridDelegate] Fix long labels blending into each other

2019-02-15 Thread Filip Fila
filipf created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This patch anchors the GridDelegate's label width and height to the
  thumbnail, as opposed to the parent.
  
  NOTE: I'm running into issues making lables have two lines , but I could
  implement that if someone would help me.
  
  BUG: 404389
  FIXED-IN: 5.56

REPOSITORY
  R296 KDeclarative

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19047

AFFECTED FILES
  src/qmlcontrols/kcmcontrols/qml/GridDelegate.qml

To: filipf
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D19047: [GridDelegate] Fix long labels blending into each other

2019-02-15 Thread Filip Fila
filipf edited the summary of this revision.
filipf edited the test plan for this revision.
filipf added reviewers: Frameworks, ngraham, VDG.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D19047

To: filipf, #frameworks, ngraham, #vdg
Cc: kde-frameworks-devel, michaelh, ngraham, bruns


D18940: Add battery icons

2019-02-12 Thread Filip Fila
filipf added a comment.


  Nice. Shouldn't the plug here be green, same as everywhere else?
  
  F6611280: image.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D18940

To: ndavis, #vdg, hein
Cc: filipf, trickyricky26, kde-frameworks-devel, hein, michaelh, ngraham, bruns


D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

2019-02-04 Thread Filip Fila
filipf added a comment.


  Round buttons looked nice, but the square buttons fit in a lot more with 
Breeze.
  
  As for the color, in a vacuum I think the dark buttons look better, but 
contextually they feel weird to me as well. We're used to everything following 
the color scheme.
  
  Inline vs. vertical offset seems like a tomayto tomatoh thing. The offset 
does seem a bit snazzier a bit though, but I don't seem to able to articulate 
why exactly.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: ndavis, andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, 
ngraham, bruns


D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

2019-02-01 Thread Filip Fila
filipf added a comment.


  ^ I agree, I really like that emblems solution now that I've seen it.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: andreask, filipf, abetts, GB_2, kde-frameworks-devel, michaelh, ngraham, 
bruns


D18649: [GridViewKCM] improve contrast and legibility for delegates' inline hover buttons

2019-02-01 Thread Filip Fila
filipf added a comment.


  There's definitely a legibility issue here. I do, however, think the gradient 
is a sleeker solution. The problem for me has actually been with the icons 
themselves. They're too scrawny and become more legible when thicker:
  
  F6582065: Screenshot_20190202_001342.png 

  
  Especially when they're like this:
  
  F6582057: Screenshot_20190202_001403.png 

  
  My fave solution would be to tweak the icons (maybe have special ones just 
for this use case) and to strengthen the gradient more. But this solution here 
works as well and it's not a big deal.

REPOSITORY
  R296 KDeclarative

REVISION DETAIL
  https://phabricator.kde.org/D18649

To: ngraham, #vdg, #plasma, broulik
Cc: filipf, abetts, GB_2, kde-frameworks-devel, michaelh, ngraham, bruns


  1   2   >