Would a min dep Qt 5.14 be more real-worldish? (Re: PSA: Frameworks depends on Qt 5.13 now)

2020-11-27 Thread Friedrich W. H. Kossebau
Am Freitag, 27. November 2020, 00:21:04 CET schrieb Nicolas Fella: > Hi, > > per our Qt dependency policy [0] Frameworks depends on Qt 5.13 6 months > after the release of Qt 5.15, which is now. Clueless question: why jump to Qt 5.13 and not Qt 5.14? >From the discussion at least in

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

2020-11-02 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kconfigloader.cpp:87 > + > +if (reader.isEndDocument()) > +return false; This logic is inverted., no? We should be at token document end when reader.atEnd() turns true. In any case on successful parse this condition is met here and

D19338: New location for KNSRC files

2020-10-30 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D19338#676680 , @asturmlechner wrote: > Hm, why was this new variable KDE_INSTALL_KNSRCDIR not put into KDEInstallDirs? On the other hand it makes sense that module-specific variables are provided by the

D29281: Deprecate defunct functions

2020-07-14 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D29281#675955 , @davidre wrote: > This caused https://bugs.kde.org/show_bug.cgi?id=423003. I removed excluding the virtual method from the build in >

PSA: Qt logging category names of all KF modules have changed for KF >= 5.73 (current master)

2020-07-13 Thread Friedrich W. H. Kossebau
Hi, as of this morning, latest master branch of all KDE Frameworks modules has seen a change of all the Qt logging category names they define, to now follow standardized patterns. Those are described over at https://community.kde.org/Frameworks/Frameworks_Logging_Policy So everyone running

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-06-22 Thread Friedrich W. H. Kossebau
kossebau closed this revision. REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D29747 To: kossebau, #frameworks, svuorela, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-06-22 Thread Friedrich W. H. Kossebau
kossebau added a comment. Okay :) Hm, need to update 71 to 72 though first, doing now. REPOSITORY R280 Prison BRANCH fullydeprecateminimumsize REVISION DETAIL https://phabricator.kde.org/D29747 To: kossebau, #frameworks, svuorela, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack,

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-06-22 Thread Friedrich W. H. Kossebau
kossebau added a comment. Ping... :) REPOSITORY R280 Prison REVISION DETAIL https://phabricator.kde.org/D29747 To: kossebau, #frameworks, svuorela, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Moving ring-kde to unmaintained (was: Re: Shift for parts of the CI system to Qt 5.15)

2020-06-20 Thread Friedrich W. H. Kossebau
Am Samstag, 20. Juni 2020, 12:25:42 CEST schrieb Ben Cooksley: > On Sat, Jun 20, 2020 at 8:13 PM Volker Krause wrote: > > On Saturday, 20 June 2020 08:20:18 CEST Ben Cooksley wrote: > > > - ring-kde > > > > build errors seem to be in stuff downloaded by cmake!? > > Indeed, this seems to be a

D27396: support icon.width/height

2020-06-19 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kossebau wrote in TabButton.qml:61 > @mart Why did you remove the color here? Seems unrelated to size? > This broke things e.g. with Breeze Dark (as can be seen e.g. with the > weather widget's tab buttons (use BBC service to have tabs).

D27396: support icon.width/height

2020-06-19 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > TabButton.qml:61 > opacity: enabled || control.highlighted || control.checked ? 1 : > 0.4 > -color: control.activeFocus && !control.down ? > theme.highlightedTextColor : theme.buttonTextColor >

Re: New Framework Review: KDAV

2020-06-18 Thread Friedrich W. H. Kossebau
Am Freitag, 19. Juni 2020, 01:16:20 CEST schrieb Friedrich W. H. Kossebau: > Will commit the ECMAddQch stuff once https://invent.kde.org/pim/kdav/-/ > merge_requests/1 is in, to not block this more due to resulting new merge > conflicts. And while I was typing & sending, th

Re: New Framework Review: KDAV

2020-06-18 Thread Friedrich W. H. Kossebau
Am Samstag, 4. April 2020, 16:20:21 CEST schrieb Kevin Ottens: > Overall apidox would likely need a big pass of cleanups as well. I locally prepared the addition of ECMAddQch usage for KDAV tonight, and while testing the output already did some small bits of minor cleanup (consistent casing of

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-06-01 Thread Friedrich W. H. Kossebau
kossebau added a comment. Thanks for starting the discussion about the spec, by what I saw on the mailinglist. Hopefully that soon gets traction by others. To not have that block this improvement, you could in parallel for now use a "kde" namespaced directories, say "*@kde2x/", where

D29051: Add ecm_generate_dbus_service_file

2020-05-29 Thread Friedrich W. H. Kossebau
kossebau added a comment. A unit test would be good to have. The test for ECMGeneratePkgConfigFile might be a sample for this. INLINE COMMENTS > ECMGenerateDBusServiceFile.cmake:17 > +# > +# A D-Bus service file ``.service` will will be generated and > installed > +# in the relevant D-Bus

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

2020-05-25 Thread Friedrich W. H. Kossebau
kossebau closed this revision. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D29003 To: junghans, kossebau, dfaure, apol Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

2020-05-25 Thread Friedrich W. H. Kossebau
kossebau added a comment. Looking at D28915 , seems you are only collecting to earn push rights so far :), so going to push for you with the author info taken from there. REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D29003

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-25 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D29397#673830 , @ngraham wrote: > The approach makes sense then. I agree that making high DPI a part of the FDO spec would be nice, but IMO that shouldn't block this. The approach currently taken is logical and it

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-25 Thread Friedrich W. H. Kossebau
kossebau added a comment. @meven Have you already got in contact with the other users/maintainers of he thumnbail cache spec about the idea to extend it with support for high dpi? If not, please consider to do so, so things will also work cross-toolkit/platforms in the future there, by

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-05-24 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D29747#671169 , @svuorela wrote: > I think we should wait a bit with formally deprecating. I like add the new, wait a bit, then deprecate. `@deprecated since 5.69 Prefer preferredSize() or trueMinimumSize().`

D28528: UDSEntry: add constructor variant with std::initializer_list

2020-05-24 Thread Friedrich W. H. Kossebau
kossebau abandoned this revision. kossebau added a comment. As I am not sure about the risk introduced by the just-works-currently alignment in the union, I would rather discard this patch for now. Going from union to having both fields increases the runtime for what I measured, despite

D29003: Use Q_EMIT and build with QT_NO_KEYWORDS

2020-05-24 Thread Friedrich W. H. Kossebau
kossebau added a comment. @junghans Hi. Do you have push rights, or do you need someone to merge your patch? REPOSITORY R275 KItemModels REVISION DETAIL https://phabricator.kde.org/D29003 To: junghans, kossebau, dfaure, apol Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack,

D29600: Fix build with KF set to EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT

2020-05-24 Thread Friedrich W. H. Kossebau
kossebau closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D29600 To: kossebau, #plasma, mart, apol Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29574: Use KSERVICE_DEPRECATED_VERSION_BELATED

2020-05-24 Thread Friedrich W. H. Kossebau
kossebau closed this revision. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D29574 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29281: Deprecate defunct functions

2020-05-22 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > abstractrunner.h:154 > * is called, the runner should return true > + * @deprecated Since 5,0, this feature has been defunct > */ Should be "5.0", not "5,0" here in the API dox text and elsewhere, no? (dot instead of

D29797: Unbreak generation with dep diagrams with Python 3 (break Py2)

2020-05-19 Thread Friedrich W. H. Kossebau
kossebau closed this revision. REPOSITORY R264 KApiDox REVISION DETAIL https://phabricator.kde.org/D29797 To: kossebau, #frameworks, ochurlaud, ognarb, cblack, winterz, francescorios Cc: asturmlechner, kde-frameworks-devel, kde-doc-english, LeGast00n, cblack, gennad, fbampaloukas,

D29797: Unbreak generation with dep diagrams with Python 3 (break Py2)

2020-05-19 Thread Friedrich W. H. Kossebau
kossebau retitled this revision from "[RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )" to "Unbreak generation with dep diagrams with Python 3 (break Py2)". kossebau edited the summary of this revision. REPOSITORY R264 KApiDox BRANCH makedepworkwithpython3

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

2020-05-19 Thread Friedrich W. H. Kossebau
kossebau added a comment. Patch worked fine also on real server run the last two nights. So going to push later today once at my respective development setup. Will push as is, given safe_load() is now also used without any conditions for the new invent.kde.org git helper :) so doing as the

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

2020-05-17 Thread Friedrich W. H. Kossebau
kossebau added reviewers: winterz, francescorios. REPOSITORY R264 KApiDox BRANCH makedepworkwithpython3 REVISION DETAIL https://phabricator.kde.org/D29797 To: kossebau, #frameworks, ochurlaud, ognarb, cblack, winterz, francescorios Cc: asturmlechner, kde-frameworks-devel,

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

2020-05-17 Thread Friedrich W. H. Kossebau
kossebau added a comment. Bah, I patched the wrong kapidox on the server, so last nights run still failed. Oh well... not sure I will have time in the evening for processing this patch, but at least now getting the diff applied also on the right kapidox, so next server check tomorrow.

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

2020-05-16 Thread Friedrich W. H. Kossebau
kossebau added a comment. I just applied the diff as-is to the working checkout of kapidox on the server, to see if the patch also works for the setup of the nightly run, other than my separate testing which might have missed any special environment setup. So tomorrow before noon CEST we

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

2020-05-16 Thread Friedrich W. H. Kossebau
kossebau added a comment. Thanks for the (first) review :) Open questions I have are these: a) how to properly check for the presence of the yaml.safe_load() method? and whether to support a fallback to load() otherwise? It was only introduced at a certain version of pyyaml b) by

D29797: [RAW PATCH] Unbreak generation with dep diagrams with Python 3 (& break P2 :) )

2020-05-16 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, ochurlaud, ognarb. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY This patch makies kapidox work

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

2020-05-16 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kcolorcombo.cpp:222 > +namedColors.reserve(colors.size()); > +for (auto color : colors) { > +namedColors.append({QString(), color}); `auto& ` as we just want a reference, avoids a copy constructor call each time. >

D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

2020-05-16 Thread Friedrich W. H. Kossebau
kossebau added a comment. Isn't the recommendation to rather avoid using things like QPair, and instead used properly defined structs? And ideally non-nested ones, to help with cases of forward declarations? Even QPair's API dox says so: "The advent of C++11 automatic variable type

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

2020-05-15 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > openurljob.h:119 > + * a different implementation on Windows. > + * > + * @param b whether to only show the "open with" dialog. Please mention explicit what the default is (false), to remove any ambiguity. Some other setters might

D29558: Add KIO::OpenUrlJob::setShowOpenWithDialog as replacement for KRun::displayOpenWithDialog

2020-05-15 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > ahmadsamir wrote in openurljob.h:120 > It seems that we shouldn't end @param with a ".", according to @kossebau > anyway... You meant, according to

Re: Request for ktexteditor patch release

2020-05-15 Thread Friedrich W. H. Kossebau
Am Freitag, 15. Mai 2020, 12:03:08 CEST schrieb David Faure: > On vendredi 15 mai 2020 11:01:04 CEST Friedrich W. H. Kossebau wrote: > > Hi, > > > > I would like to ask for a 5.70 patch release for ktexteditor, with > > 972da14f486a83556e192d09bb1

Request for ktexteditor patch release

2020-05-15 Thread Friedrich W. H. Kossebau
Hi, I would like to ask for a 5.70 patch release for ktexteditor, with 972da14f486a83556e192d09bb18a2500728895a cherry-picked. Not a crasher, but preventing the pickup of any global view setting changes after a kate/kdevelop session close & open cycle for existing document views, which has

D27844: Store and fetch complete view config in and from session config

2020-05-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D27844#671380 , @dhaumann wrote: > I suggest to revert, and send a notification with the change to kde-distro-packa...@kde.org to avoid that many users break their configuration. Okay, doing now. REPOSITORY

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-05-14 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D29747#671169 , @svuorela wrote: > I think we should wait a bit with formally deprecating. I like add the new, wait a bit, then deprecate. So you propose to also remove the `@deprecated` from the API dox?

D27844: Store and fetch complete view config in and from session config

2020-05-14 Thread Friedrich W. H. Kossebau
kossebau added a comment. Seems this change has some sideeffects I did not experience when I played with this, but which are now uncovering as it hits people usinjg KF 5.70 : config seems to write any settings, also the ones inherited from global defaults, as view-specific settings, and

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-05-14 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > abstractbarcode.h:69 > */ > +PRISON_DEPRECATED_VERSION_BELATED(5, 71, 5, 69, "Use preferredSize() or > trueMinimumSize()") > QSizeF minimumSize() const; D29573 bringing _BELATED only landed a

D29747: Deprecate AbstractBarcode::minimumSize() also for the compiler

2020-05-14 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, svuorela, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R280 Prison BRANCH fullydeprecateminimumsize REVISION DETAIL

D27989: Add a new set of barcode size functions

2020-05-14 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D27989#670659 , @vkrause wrote: > There's two remaining users in everything covered by lxr, the Plasma clipboard (patch in review: https://phabricator.kde.org/D29478) and KDE PIM (which now depends on a sufficiently

D29708: Introduce EXCLUDE_DEPRECATED_BEFORE_AND_AT

2020-05-13 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R241:391351a6be0e: Introduce EXCLUDE_DEPRECATED_BEFORE_AND_AT (authored by kossebau). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29708?vs=82730=82806 REVISION DETAIL

D29707: Remove deprecation tag from SlaveBase::config() for now

2020-05-13 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R241:c7b164496354: Remove deprecation tag from SlaveBase::config() for now (authored by kossebau). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29707?vs=82729=82799

D27989: Add a new set of barcode size functions

2020-05-13 Thread Friedrich W. H. Kossebau
kossebau added a comment. > minimumSize() becomes deprecated by this, the deprecation macros will > follow once the current users have been adjusted. IMHO you should add the macros from the start, otherwise it will be only forgotten later, as there is no mechanism to remind you. And

D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED()

2020-05-13 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R240:cc8bccadcdb9: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED() (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D29708: Introduce EXCLUDE_DEPRECATED_BEFORE_AND_AT

2020-05-13 Thread Friedrich W. H. Kossebau
kossebau added a comment. @dfaure So far I had no idea how to introduce a simple variant of the deprecation macros to support just disabling latest. For one would this make things more complex as there would be yet another approach. And things would be also become a bit unreliable on the

D29708: Introduce EXCLUDE_DEPRECATED_BEFORE_AND_AT

2020-05-13 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, dfaure, meven, ahmadsamir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Not all versions of the past will work as value,

D29707: Remove deprecation tag from SlaveBase::config() for now

2020-05-13 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, meven, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY There is no migration path for all current usages of config()

D23523: [SlaveBase] Use QMap instead of KConfig to store ioslave config

2020-05-13 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > slavebase.h:355 > */ > -KConfigGroup *config(); > +KIOCORE_DEPRECATED KConfigGroup *config(); > Given there are still a few usages of config() left which seem not easily replaceable, it would be better to remove the deprecation

D29414: Be noisy about deprecated KPageWidgetItem::setHeader(empty-non-null string)

2020-05-11 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R236:a5692448a750: Be noisy about deprecated KPageWidgetItem::setHeader(empty-non-null string) (authored by kossebau).

Re: kcoreaddons_add_plugin executable/plugin directory conflict

2020-05-11 Thread Friedrich W. H. Kossebau
Am Montag, 11. Mai 2020, 10:21:10 CEST schrieb Daniel Vrátil: > Hi all, > > I'm moving some plugins in kaddressbook and I ran into a problem with > kcoreaddons_add_plugin: Problem found because you require ECM >= 5.38, triggering the use of the CMAKE_BUILD_DIR/bin as executable artifact

D28765: KSettings::Dialog: add support for KPluginInfos without a KService

2020-05-10 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > dfaure wrote in kcmoduleinfo.h:131 > It's complicated. > > 1. If you use the QString constructor, you know service() is usable. That's > the case for all users of KCModuleInfo except KCModuleLoader. [Not that there > are many] > > 2. Even

D29600: Fix build with KF set to EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT

2020-05-10 Thread Friedrich W. H. Kossebau
kossebau added a comment. Building all of KF with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT set, so dropping any deprecated API from the build, serves as a small sanity check to see if the future (like KF6) is well prepared and there is no hidden undeprecated functional dependency on

D29600: Fix build with KF set to EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT

2020-05-10 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Plasma, mart, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY NO_CHANGELOG REPOSITORY R242 Plasma Framework (Library) BRANCH

D29572: Build with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT

2020-05-09 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R309:c8c10b76931a: Build with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT (authored by kossebau). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29572?vs=82392=82403

D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED()

2020-05-09 Thread Friedrich W. H. Kossebau
kossebau added a dependent revision: D29574: Use KSERVICE_DEPRECATED_VERSION_BELATED. REPOSITORY R240 Extra CMake Modules BRANCH addbelated REVISION DETAIL https://phabricator.kde.org/D29573 To: kossebau, #frameworks, #build_system, dfaure Cc: kde-frameworks-devel, kde-buildsystem,

D29574: Use KSERVICE_DEPRECATED_VERSION_BELATED

2020-05-09 Thread Friedrich W. H. Kossebau
kossebau added a dependency: D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED(). REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D29574 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham,

D29574: Use KSERVICE_DEPRECATED_VERSION_BELATED

2020-05-09 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R309 KService BRANCH usebelated REVISION DETAIL

D29573: ECMGenerateExportHeader: add generation of *_DEPRECATED_VERSION_BELATED()

2020-05-09 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, Build System, dfaure. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Now and then tagging some

D29572: Build with EXCLUDE_DEPRECATED_BEFORE_AND_AT=CURRENT

2020-05-09 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY To also support EXCLUDE_DEPRECATED_BEFORE_AND_AT=5.69.0 properly some

D29561: Add missing compiler deprecation tag for 5-args KServiceAction constructor

2020-05-09 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R309:429c80c96142: Add missing compiler deprecation tag for 5-args KServiceAction constructor (authored by kossebau). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE

D29561: Add missing compiler deprecation tag for 5-args KServiceAction constructor

2020-05-09 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R309 KService BRANCH addmissingdeprecationtag REVISION DETAIL

D29370: Use UI marker context in more tr() calls

2020-05-08 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R289:d256eaf8d8ed: Use UI marker context in more tr() calls (authored by kossebau). REPOSITORY R289 KNotifications

D29369: Use UI marker context in more tr() calls

2020-05-08 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R294:1d8d223745eb: Use UI marker context in more tr() calls (authored by kossebau). REPOSITORY R294 KBookmarks CHANGES

D29368: Use UI marker context in more tr() calls

2020-05-08 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R284:5b08593fc0c4: Use UI marker context in more tr() calls (authored by kossebau). REPOSITORY R284 KCompletion CHANGES

D29367: Use UI marker context in more tr() calls

2020-05-08 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R276:df9e5d3bb765: Use UI marker context in more tr() calls (authored by kossebau). REPOSITORY R276 KItemViews CHANGES

D29363: Use UI marker context in more tr() calls

2020-05-08 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R236:5904c475cb37: Use UI marker context in more tr() calls (authored by kossebau). CHANGED PRIOR TO COMMIT

D29414: Be noisy about deprecated KPageWidgetItem::setHeader(empty-non-null string)

2020-05-08 Thread Friedrich W. H. Kossebau
kossebau added a comment. Ping? If no-one objects would push upcoming Monday, May 11th. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29414 To: kossebau, #frameworks, cfeck Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29541: KBookmarkMenuTest: extend unittest to cover undeprecated API

2020-05-08 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R294:50c5c2fd7e5c: KBookmarkMenuTest: extend unittest to cover undeprecated API (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29541?vs=82300=82308#toc REPOSITORY R294

D29541: KBookmarkMenuTest: extend unittest to cover undeprecated API

2020-05-08 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, nicolasfella, dfaure, ahmadsamir. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R294 KBookmarks BRANCH

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-08 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D29397#666134 , @meven wrote: > In D29397#666132 , @kossebau wrote: > > > For another stupid question (the first one was already asked by someone else and answered :)

D29397: KPreviewJob : Support for DeviceRatioPixel

2020-05-08 Thread Friedrich W. H. Kossebau
kossebau added a comment. For another stupid question (the first one was already asked by someone else and answered :) ): Given some generated thumbnails are cached, does the thumbnail cache specification support logical resolution? How would cached thumbnails work cross-screen?

D29363: Use UI marker context in more tr() calls

2020-05-05 Thread Friedrich W. H. Kossebau
kossebau added a comment. Thanks Albert (& Luigi) for review. With no-one objecting, I would proceed to push this upcoming WE, 9/10th May, to be early in the cycle still. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29363 To: kossebau, #frameworks,

D29427: [KBookmarkMenu] Assign m_actionCollection early to prevent crash

2020-05-04 Thread Friedrich W. H. Kossebau
kossebau added a comment. 5.70 wants this as appended commit, no? REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D29427 To: ahmadsamir, #frameworks, dfaure, kossebau, nicolasfella Cc: rikmills, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28800: Always create actioncollection

2020-05-04 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kbookmarkmenu.cpp:69 > { > m_actionCollection = actionCollection; > } This resetting of m_actionCollection in the constructor taking an actionCollection still results in issues, as this KBookmarkMenu constructor taking an

D29414: Be noisy about deprecated KPageWidgetItem::setHeader(empty-non-null string)

2020-05-04 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R236 KWidgetsAddons BRANCH warnaboutdeprecatedemptynonnullheader REVISION

D29390: Respect QIcon::fallbackSearchpaths()

2020-05-03 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > aacid wrote in kiconloader.cpp:1142 > I just realized that function is private, not really easy to use :/ > > anyhow do you think we should remove svgz? > > Also i think using > > const QStringList extensions = { QStringLiteral(".png"), >

D29391: Introduce setWindow and CloseWhenWindowActivated

2020-05-03 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > knotification.h:582 > > +/** Sets the window associated with this notification. > + * This is relevant when using the CloseWhenWindowActivated flag. And some remarks from a local API docs pedant :) Please place the text not on the

D29385: Introduce KIO::OpenUrlJob, a rewrite and replacement for KRun

2020-05-03 Thread Friedrich W. H. Kossebau
kossebau added a comment. Quick first nitpicks from initial scan what this patch is about, without having looked closer. INLINE COMMENTS > openurljobtest.cpp:108 > +{ > +std::for_each(m_filesToRemove.begin(), m_filesToRemove.end(), [](const > QString & f) { > +QFile::remove(f);

D29369: Use UI marker context in more tr() calls

2020-05-03 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > aacid wrote in kbookmarkmenu.cpp:288 > @title:inmenu? Nope, this is a normal action/menu entry, the variable name is misleading here a bit. See below e.g. for the slot added. REPOSITORY R294 KBookmarks REVISION DETAIL

D29347: KAuthorized: export method to reload restrictions

2020-05-03 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kauthorized.cpp:247 > > -static void initUrlActionRestrictions() > +KCONFIGCORE_EXPORT void reloadUrlActionRestrictions() > { Please also add a note next to this that it is for unit test, so people are not wondering about this random

D29370: Use UI marker context in more tr() calls

2020-05-02 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, Localization, broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R289 KNotifications BRANCH usemoreuicontextmarker REVISION

D29369: Use UI marker context in more tr() calls

2020-05-02 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, Localization. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Also fix lowercase "toolbar" in action text to Title

D29368: Use UI marker context in more tr() calls

2020-05-02 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, Localization. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R284 KCompletion BRANCH usemoreuicontextmarker REVISION DETAIL

D29367: Use UI marker context in more tr() calls

2020-05-02 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, Localization, davidedmundson. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Also align placeholder string of

D29363: Use UI marker context in more tr() calls

2020-05-02 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 81744. kossebau added a comment. also done for ui files REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29363?vs=81742=81744 BRANCH usemoreuicontextmarker REVISION DETAIL https://phabricator.kde.org/D29363

D29363: Use UI marker context in more tr() calls

2020-05-02 Thread Friedrich W. H. Kossebau
kossebau added a comment. Given the amounts of changes only to be applied directly after a KF tagging, to give translators as much time as possible to catch up. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D29363 To: kossebau, #frameworks, #localization,

D29363: Use UI marker context in more tr() calls

2020-05-02 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, Localization, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Also fix some tooltip text styles to follow KDE HIG

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

2020-04-30 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D29299#660620 , @pino wrote: > In D29299#660614 , @kossebau wrote: > > > One does not need to define KDE_INSTALL_LOCALEDIR oneself. One only needs to use

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

2020-04-30 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D29299#660519 , @pino wrote: > In D29299#660505 , @kossebau wrote: > > > Because people do strange things, and I prefer to rather not break their card house unless

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

2020-04-30 Thread Friedrich W. H. Kossebau
kossebau added a comment. Because people do strange things, and I prefer to rather not break their card house unless necessary. Only looking at the undeprecated variable second should be fine, no? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29299 To: kossebau,

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

2020-04-30 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D29299#660468 , @pino wrote: > In D29299#660466 , @kossebau wrote: > > > In D29299#660465 , @pino wrote: > > > > > Also,

D29303: Make KI18N_INSTALL() compatible to KDE_INSTALL_DIRS_NO_DEPRECATED

2020-04-30 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: ilic, heikobecker. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY LOCALE_INSTALL_DIR is a deprecated variable from KDEInstallDirs, which

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

2020-04-30 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D29299#660453 , @pino wrote: > The problem is that ki18n_install() is rarely used manually, and generally it is appended by the release scripts to the top-level CMakeLists.txt file that goes into the tarballs.

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

2020-04-30 Thread Friedrich W. H. Kossebau
kossebau added a comment. The patch should not require existing users to adapt (though personally I would favour explit DESTINATION args, perhaps a KF6 time thing). That is also why there is no warning emitted in case the DESTINATION is not passed. So nothing should need to be changed

D29299: Make KI18N_INSTALL() not rely on only LOCALE_INSTALL_DIR

2020-04-30 Thread Friedrich W. H. Kossebau
kossebau added reviewers: aacid, ltoscano. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29299 To: kossebau, ilic, heikobecker, #frameworks, aacid, ltoscano Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

  1   2   3   4   5   6   7   8   9   10   >