Re: Quick Charts in KDE Review

2019-11-07 Thread Friedrich W. H. Kossebau
Am Montag, 21. Oktober 2019, 15:22:23 CET schrieb Arjen Hiemstra: > Hi, > > Quick Charts has been moved to KDE review. The intent is to make it a > Tier 1 framework. Any chance the official name can be "KQuickCharts"? "Quick Charts" is a generic name which only asks for being misunderstood, is

Re: HEADS-UP: from now do new deprecations in KF API by *_DEPRECATED_* macros only using upcoming version number

2019-11-06 Thread Friedrich W. H. Kossebau
Am Mittwoch, 6. November 2019, 16:13:28 CET schrieb David Edmundson: > >Any chance this is about KGamma and you ran clazy with a Qt 5.14 copy > >locally? > It was! Okay :) So no new holes to fix then discovered. > >So here repeating the recommendation done by a few, which project > >maintainers

Re: HEADS-UP: from now do new deprecations in KF API by *_DEPRECATED_* macros only using upcoming version number

2019-11-06 Thread Friedrich W. H. Kossebau
Am Mittwoch, 6. November 2019, 14:14:41 CET schrieb David Edmundson: > I just found a slight issue when using _DEPRECATED_SINCE. > > If one of two overloaded Q_SIGNALS is deprecated, clazy will blindly > port the signal without an overload as to the compiler only one signal > exists. This then

Re: HEADS-UP: from now do new deprecations in KF API by *_DEPRECATED_* macros only using upcoming version number

2019-11-06 Thread Friedrich W. H. Kossebau
Am Mittwoch, 6. November 2019, 14:14:41 CET schrieb David Edmundson: > I just found a slight issue when using _DEPRECATED_SINCE. > > If one of two overloaded Q_SIGNALS is deprecated, clazy will blindly > port the signal without an overload as to the compiler only one signal > exists. This then

D24979: KRunner: port away from deprecated KF5 API

2019-11-05 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R308:7bbd29591094: KRunner: port away from deprecated KF5 API (authored by dfaure, committed by kossebau). CHANGED PRIOR

D24979: KRunner: port away from deprecated KF5 API

2019-11-05 Thread Friedrich W. H. Kossebau
kossebau commandeered this revision. kossebau edited reviewers, added: dfaure; removed: kossebau. kossebau added a comment. This revision now requires review to proceed. @dfaure I allow myself to take over here given your are off the next days and I would like to get this off the table :)

D24979: KRunner: port away from deprecated KF5 API

2019-11-03 Thread Friedrich W. H. Kossebau
kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Untested, but looks okay, besides the unneeded #f in the sources. INLINE COMMENTS > abstractrunner.cpp:327 > > +#if PLASMA_ENABLE_DEPRECATED_SINCE(5, 28) // Plasma::Package is

HEADS-UP: from now do new deprecations in KF API by *_DEPRECATED_* macros only using upcoming version number

2019-11-03 Thread Friedrich W. H. Kossebau
Hi, with KF 5.64 now branched and thus the new deprecation macros going to be released for the first time, now please make sure when in the future marking API as deprecated to use the correct current version, i.e. the one where the deprecation will be made public the first time. So if pushing

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

2019-11-03 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R240:879769daf047: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings (authored by kossebau). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

2019-11-03 Thread Friedrich W. H. Kossebau
kossebau added a comment. Merci, will land later tonight. Bonnes vacances :) REPOSITORY R240 Extra CMake Modules BRANCH enableallqtkfdeprecationwarningsforframeworks REVISION DETAIL https://phabricator.kde.org/D24990 To: kossebau, #frameworks, #build_system, apol, dfaure Cc: dfaure,

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

2019-11-03 Thread Friedrich W. H. Kossebau
kossebau added a subscriber: dfaure. kossebau added a comment. @dfaure Hi. Any chance you you can sneak in before you are away (enjoy :) ) to remove the "-DQT_DEPRECATED_WARNINGS_SINCE=0x06" from all the KF modules in the next days? Otherwise would land this here with just the

D25039: Fix Clazy performance issues, const

2019-11-01 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D25039#557609 , @meven wrote: > Feel free to do the code removal, Done now, as I had the files still open. REPOSITORY R241 KIO BRANCH arcpatch-D25039 REVISION DETAIL https://phabricator.kde.org/D25039

D23801: Port kpac from QtScript

2019-11-01 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > carewolf wrote in script.cpp:316 > Sure, as I said, I only write it this way because a copy should be taken, and > while Qt can work around declaring an async argument as a reference, I still > consider it bad style to make that mistake. > >

D25039: Fix Clazy performance issues, const

2019-11-01 Thread Friedrich W. H. Kossebau
kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Not tested, only read code. Looks good to me. Please remove the newInstance method in a direct commit before, and drop change from this patch. (If you prefer, can do the remove commit

D25039: Fix Clazy performance issues, const

2019-10-31 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > ahmadsamir wrote in ftp.cpp:1376 > IIUC, the compiler will use a temporary object to hold the return of > tempurl.fileName(). > > The temporary is used to initialize filename, and then it's gone: > const QString filename = tempurl.filename(); >

D25039: Fix Clazy performance issues, const

2019-10-31 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > ftp.cpp:1376 > QString parentDir; > -QString filename = tempurl.fileName(); > +const QString = tempurl.fileName(); > Q_ASSERT(!filename.isEmpty()); `QUrl::fileName()` returns a value QString, so just const QString filename

D23801: Port kpac from QtScript

2019-10-31 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > carewolf wrote in script.cpp:316 > Invokables can be called asynchronously (queued), if you take a reference and > the isn't evaluated immediatly the reference might be invalid by the time the > call is evaluated. With queued signals, any

D23801: Port kpac from QtScript

2019-10-30 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > carewolf wrote in script.cpp:316 > Not really. I prefer to do it that way for invokable as the value will be > copied, but const ref works too. So why would it be preferable to have the value be copied there? In general, one prefers to avoid

D25039: Fix Clazy performance issues, const &, noexcept

2019-10-30 Thread Friedrich W. H. Kossebau
kossebau added a comment. As excuse for bad drive-by comment, here now hopefully making up a bit by giving some in-detail review, please see in-line comments. No idea about exceptions. I would the noexcept also make a different commit, for more separation of concerns. When looking

D23801: Port kpac from QtScript

2019-10-30 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > script.cpp:316 > // @returns true if @p str matches the shell @p pattern > -QScriptValue ShExpMatch(QScriptContext *context, QScriptEngine *engine) > +Q_INVOKABLE QJSValue ShExpMatch(QString str, QString patternStr) > { Hi @carewolf . Curious:

D25039: Fix Clazy performance issues, const &, noexcept

2019-10-30 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kossebau wrote in slavebase.h:351 > Would be a proper change, but sadly also changes the signature of a API under > ABI promise, so here and in all other public API places not possibe. > Can be only done when breaking the ABI with KF6. > >

D25039: Fix Clazy performance issues, const &, noexcept

2019-10-30 Thread Friedrich W. H. Kossebau
kossebau added a comment. (Quick drive-by comment only as I had this in a search result...) INLINE COMMENTS > slavebase.h:351 > */ > -bool configValue(QString key, bool defaultValue) const; > +bool configValue(const QString , bool defaultValue) const; > Would be a proper

D25059: KPluginSelector: use new KAboutPluginDialog

2019-10-30 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > anthonyfieroni wrote in kpluginselector.cpp:799-803 > Can you guard for nullptr? The pluginEntry? That would be inconsistent with the rest of the code here, which does no such checks. We should be relatively safe here, as the slot should be

D24965: KConfigWidgets: port away from KF5 deprecated API

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Tired given the time, but let's see if I get things straight this time: Given KF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00, in the API of KConfig we just see

D24966: KXmlGui: port away from KF5 deprecated API

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau added a comment. To leave KAboutData::programIconData as a deprecated property and instead turn to use KPluginMetaData where the iconName property is undisputed in its usefullnes, I have now uploaded 3 patches for view; - D25063 : Add

D25063: Deprecate KAboutData::fromPluginMetaData, now there is KAboutPluginDialog

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, apol, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Depends on D25058

D25058: Add KAboutPluginDialog, to be used with KPluginMetaData

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau added a dependent revision: D25063: Deprecate KAboutData::fromPluginMetaData, now there is KAboutPluginDialog. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25058 To: kossebau, #frameworks, apol, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25059: KPluginSelector: use new KAboutPluginDialog

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, dfaure, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Depends on D25058

D25058: Add KAboutPluginDialog, to be used with KPluginMetaData

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau added a dependent revision: D25059: KPluginSelector: use new KAboutPluginDialog. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25058 To: kossebau, #frameworks, apol, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25058: Add KAboutPluginDialog, to be used with KPluginMetaData

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, apol, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY When showing an About dialog for a plugin, so far a

D24966: KXmlGui: port away from KF5 deprecated API

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau added a comment. Playing with reviving my programIconName undeprecation patch (by adding a new property iconName w/ setter/getter), and looking through the rest of the API, I though now think that we should keep KAboutData untouched and leave it for metadata about programs, while

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kossebau wrote in statjob.h:181 > I wonder if this should not be rather a member of StatJob, instead of being > on generic KIO namespace level. > It feels unbalanced to have the enum being in the class, but a util flag set > not. Actually,

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > jobremotetest.cpp:70 > { > -KIO::Job *job = KIO::stat(url, KIO::StatJob::DestinationSide, 0, > KIO::HideProgressInfo); > +KIO::Job *job = KIO::stat(url, KIO::StatJob::DestinationSide, > KIO::StatJob::Basic, KIO::HideProgressInfo); >

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > statjob.h:96 > + > /** > * Selects the level of @p details we want. All deprecated API should be also wrapped in visibility controls., so same #if/#endif also here. Basic structure: if deprecated api should be visible to compiler

D25010: [StatJob] Use A QFlag to specify the details returned by statJob

2019-10-29 Thread Friedrich W. H. Kossebau
kossebau added a comment. Now that is a quick turn-around, +1 for doing the work :) No time myself to look at this closely the next days, also not that much into KIO, but here some quick feedback with an API police hat on. Would be also good to have some patches which make use of

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

2019-10-28 Thread Friedrich W. H. Kossebau
kossebau added a comment. As said, I do not think this would be "better" code. And it's violating a bit the goal of zero cost abstractions, given this adds runtime need which could be avoided compared to the old code. When using the I18N_NOOP, one has to know what you do and when you later

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

2019-10-28 Thread Friedrich W. H. Kossebau
kossebau added a comment. Looking at deprecated API usage in Okteta, I came over the use of some use of I18N_NOOP2 as well. The use-case there though seems pretty fine to me, porting to I18NC_NOOP will complicate the logic without further need, as the context is the same for all strings in

D24999: [KIO::stat] Add a KF6 TODO to make details a Bitmask

2019-10-28 Thread Friedrich W. H. Kossebau
kossebau added a comment. It's actually an approach to be preferred in such cases, as it moves some of the work to be done at creating KF6 and porting to its new API for users of KF to now and the time span until KF6, keeping the unavoidable hurdle at the actual KF5->KF6 change as small as

D24999: [KIO::stat] Add a KF6 TODO to make details a Bitmask

2019-10-28 Thread Friedrich W. H. Kossebau
kossebau added a comment. Instead of the TODO one could already add an overload of the method now, and deprecate the current one. So that in KF6 times the deprecated could be dumped, and there would just be the preferred variant. REPOSITORY R241 KIO REVISION DETAIL

Re: [sysadmin/release-tools/frameworks/5.0] /: KF5: auto-increase QT_DISABLE_DEPRECATED_BEFORE when upgrading the min Qt version

2019-10-28 Thread Friedrich W. H. Kossebau
Am Sonntag, 27. Oktober 2019, 11:26:51 CET schrieb David Faure: > On dimanche 27 octobre 2019 03:07:01 CET Friedrich W. H. Kossebau wrote: > > Am Freitag, 25. Oktober 2019, 00:35:46 CET schrieb David Faure: > > > On jeudi 24 octobre 2019 22:24:55 CEST Friedrich W. H. Kossebau

D24974: KService: fix kded compilation with -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00

2019-10-27 Thread Friedrich W. H. Kossebau
kossebau added a comment. Alternatively kded could be build with additionally `-DKSERVICE_DISABLE_DEPRECATED_BEFORE_AND_AT=0x05`. So it will would be still hidden to anyone else who uses -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x050x00 REPOSITORY R309 KService REVISION DETAIL

D24966: KXmlGui: port away from KF5 deprecated API

2019-10-27 Thread Friedrich W. H. Kossebau
kossebau added a comment. Actually I have a WIP undeprecation patch somewhere, which reduced the deprecation to notes with setApplicationData/appliactionData, Guess I should pick this from the attic, clean up and share, REPOSITORY R263 KXmlGui REVISION DETAIL

D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings

2019-10-27 Thread Friedrich W. H. Kossebau
kossebau created this revision. kossebau added reviewers: Frameworks, Build System. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. kossebau requested review of this revision. REPOSITORY R240 Extra CMake Modules BRANCH

D24979: KRunner: port away from deprecated KF5 API

2019-10-27 Thread Friedrich W. H. Kossebau
kossebau requested changes to this revision. kossebau added a comment. This revision now requires changes to proceed. One of the Interesting challenges with all the cross-library deprecation visibility control setup. Let me try to collect requirements: - Plasma::Package is part of

Re: [sysadmin/release-tools/frameworks/5.0] /: KF5: auto-increase QT_DISABLE_DEPRECATED_BEFORE when upgrading the min Qt version

2019-10-27 Thread Friedrich W. H. Kossebau
Am Freitag, 25. Oktober 2019, 00:35:46 CET schrieb David Faure: > On jeudi 24 octobre 2019 22:24:55 CEST Friedrich W. H. Kossebau wrote: > > BTW, we want to also set > > > > -DQT_DEPRECATED_WARNINGS_SINCE=0x06 > > > > otherwise the deprecations done with

D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

2019-10-26 Thread Friedrich W. H. Kossebau
kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. Good with me. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24971 To: dfaure, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24965: KConfigWidgets: port away from KF5 deprecated API

2019-10-26 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kossebau wrote in kstandardaction_p.h:103 > Hm, KStandardShortcut::SaveOptions_DEPRECATED_DO_NOT_USE should not be needed > to be used here. > Does the use of KF_DISABLE_DEPRECATED_BEFORE_AND_AT trigger this? If so, IMHO >

D24965: KConfigWidgets: port away from KF5 deprecated API

2019-10-26 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kstandardaction_p.h:103 > #if KCONFIGWIDGETS_BUILD_DEPRECATED_SINCE(5, 38) > -{ SaveOptions, KStandardShortcut::SaveOptions, "options_save_options", > I18N_NOOP(" Settings"), nullptr, nullptr }, > +{ SaveOptions,

D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

2019-10-26 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > CMakeLists.txt:96 > add_definitions(-DQT_DEPRECATED_WARNINGS_SINCE=0x06) > +add_definitions(-DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x053f00) > add_definitions(-DQT_NO_FOREACH) Given KCOreAddons does not link against other KF modules, this

D24971: KCoreAddons: make programIconName() available to KConfigWidgets and KXmlGui

2019-10-26 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kaboutdata.h:944 > > -#if KCOREADDONS_ENABLE_DEPRECATED_SINCE(5, 2) > +#if KCOREADDONS_BUILD_DEPRECATED_SINCE(5, 2) > /** Possibly best to document why only BUILD, pointing out infrastructure code supporting legacy code needs to always

D24965: KConfigWidgets: port away from KF5 deprecated API

2019-10-26 Thread Friedrich W. H. Kossebau
kossebau added a comment. So seems I missed to make clear what I meant, next try :) The goal is: make clients (e.g. apps) which are still using this method to set the app icon aware by a compiler warning that they should port their code to use QApplication::setWindowIcon. For that we

D24965: KConfigWidgets: port away from KF5 deprecated API

2019-10-26 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D24965#554393 , @dfaure wrote: > So basically we just use //KF6 TODO REMOVE for programIconName, but still use the macro around setProgramIconName? Works for me. Yes, remove the

D24965: KConfigWidgets: port away from KF5 deprecated API

2019-10-26 Thread Friedrich W. H. Kossebau
kossebau added a comment. This falls into a category I also saw elsewhere doing all the patches, where the same API is used from two sides: the client side, like application code, and the serving side, like infrastructure. While we want to tell the client side, stop using this and for

D24966: KXmlGui: port away from KF5 deprecated API

2019-10-26 Thread Friedrich W. H. Kossebau
kossebau added a comment. For backward-compatibility, we want to support this still, no? See D24965#554354 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D24966 To: dfaure, kossebau, elvisangelaccio, vkrause Cc:

D24965: KConfigWidgets: port away from KF5 deprecated API

2019-10-26 Thread Friedrich W. H. Kossebau
kossebau added a comment. While being deprecated, there might be code still using it, and you are killing support for that now, which is backwards-incompatibel. IMHO the support should be kept. And we want to rather have a generic way to disable the warning here (still TODO to have

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

2019-10-25 Thread Friedrich W. H. Kossebau
kossebau accepted this revision. kossebau added a comment. This revision is now accepted and ready to land. In D24892#553597 , @vkrause wrote: > In D24892#552838 , @kossebau wrote: > > > Looks good.

Re: [sysadmin/release-tools/frameworks/5.0] /: KF5: auto-increase QT_DISABLE_DEPRECATED_BEFORE when upgrading the min Qt version

2019-10-24 Thread Friedrich W. H. Kossebau
Am Donnerstag, 24. Oktober 2019, 22:16:47 CEST schrieb David Faure: > Git commit fb4639b0b5f2a51d124949d59b9a327bf66c8f04 by David Faure. > Committed on 24/10/2019 at 20:15. > Pushed by dfaure into branch 'frameworks/5.0'. > > KF5: auto-increase QT_DISABLE_DEPRECATED_BEFORE when upgrading the min

D24841: Use modern way to set the C/CXX standard

2019-10-23 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D24841#552842 , @vonreth wrote: > Where are those tests running? I'm only aware of https://build.kde.org/job/Frameworks/job/extra-cmake-modules/ The tests are currntly sadly skipped on CI, compare T11858

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

2019-10-23 Thread Friedrich W. H. Kossebau
kossebau added a comment. Looks good. Perfect would be if you tested KIconThemes with EXCLUDE_DEPRECATED_BEFORE_AND_AT set to hexnumber(5.64.0), to see if there is no internal usage still happening, like with autotests which might need to support such a build with

D24764: Deprecate KIconTheme::assignIconsToContextMenu

2019-10-22 Thread Friedrich W. H. Kossebau
kossebau added a comment. As KIconThems supports EXCLUDE_DEPRECATED_BEFORE_AND_AT., you want to also wrap the implementation of assignIconsToContextMenu, with #if KICONTHEMES_BUILD_DEPRECATED_SINCE(5, 64) (look out for _BUILD_). Seems you are a candidate to answer the email

Heads-up for developers working _on_ KF modules: how to mark deprecated API from now on

2019-10-21 Thread Friedrich W. H. Kossebau
Hi, tldr; For deprecated API of KDE Frameworks modules please use ECMGenerateExportHeader and the respective macros to mark & wrap deprecated API, otherwise the whole effort breaks down. Question: where would you expect the documentation for how to do this? The introduction of

D24261: Modernize code: use range-based for loop in more places

2019-10-20 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R263:3836ef74bc2c: Modernize code: use range-based for loop in more places (authored by kossebau). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24261?vs=67047=68389

D24663: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-20 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D24663#550883 , @romangg wrote: > It's ok that you pushed. Can you give a link to your preferred resource for me to read up on ECMGenerateExportHeader? Not too comprehensive if possible. For one there are the

D24663: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-19 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R127:1fb1906ac5c2: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO

D24663: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-19 Thread Friedrich W. H. Kossebau
kossebau added a comment. Reviewed myself once more and will be pushing now, given this is fairly straightforward after all, so the KF_* flags can be enabled next. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D24663 To: kossebau, #kwin Cc: zzag,

D24671: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-19 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R290:d03f2d7114c4: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R290

D24671: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-19 Thread Friedrich W. H. Kossebau
kossebau added a comment. Reviewed myself once more and will be pushing now, given this is fairly straightforward after all, so the KF_* flags can be enabled next. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D24671 To: kossebau, #frameworks, #plasma, mart, apol

D24700: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-18 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R249:d6c413a0b779: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24700?vs=68059=68275

D24261: Modernize code: use range-based for loop in more places

2019-10-18 Thread Friedrich W. H. Kossebau
kossebau added a comment. Ping? REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D24261 To: kossebau, dfaure Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24678: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-18 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R242:df7f98189060: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24678?vs=68001=68273#toc REPOSITORY R242

D24671: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-18 Thread Friedrich W. H. Kossebau
kossebau added a comment. @apol Hi. Any chance you can give this a review soon, given this is almost the last one remaining before the complete of all (affected) KF modules to ECMGenerateExportHeader is done, and we can enable the respective KF_* macros? REPOSITORY R290 KPackage REVISION

D24496: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-18 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R237:fb37084b3e7c: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24496?vs=67735=68261#toc REPOSITORY R237

D24684: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-18 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R241:aa5b0d89b2ed: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24684?vs=68210=68257#toc REPOSITORY R241 KIO

D24681: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-18 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R304:0d0b688643d8: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24681?vs=68006=68254#toc REPOSITORY R304

D24673: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-18 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R296:00bc9b132e66: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE

D24650: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-18 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R235:f79367c1aff3: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R235 Attica CHANGES SINCE LAST UPDATE

D24684: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-18 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > dfaure wrote in global.h:105 > LOL 3.4 was long ago ;) > > good find :) Thankfully phabricator and its locate-file, go-to-version-before-commit & tags listing for commit was helpful here to good degrees, so that usually tool < 1 min to find

D24684: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-18 Thread Friedrich W. H. Kossebau
kossebau edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24684 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24684: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-18 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D24684#549785 , @dfaure wrote: > The commit log says KIOKIOFILEWIDGETS with KIO duplicated, that's a typo in the commit log, but only there, right? Typo indeed, fixed. INLINE COMMENTS > dfaure wrote in

D24684: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-18 Thread Friedrich W. H. Kossebau
kossebau edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24684 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24684: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-18 Thread Friedrich W. H. Kossebau
kossebau added a comment. Ping... would be happy if this one could get reviewed ASAP, so we have the patches for all of KF modules in and can enable the group KF_* macros, so people can conveniently use -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0Xxx in their projects :) REPOSITORY R241

D24663: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-18 Thread Friedrich W. H. Kossebau
kossebau added a comment. @zzag Hi. Any chance you can have time to review this today/the WE? One of the last ECMGenerateExportHeader patches. I would be happy if we could have all in ASAP so we can enable the KF_* macros and test them in git master for two weeks before 5.64 gets tagged

D24684: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-17 Thread Friedrich W. H. Kossebau
kossebau updated this revision to Diff 68210. kossebau added a comment. update to latest master and new deprecated API REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24684?vs=68021=68210 BRANCH useECMGenerateExportHeader REVISION DETAIL

D24610: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-17 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R276:95d6613e23b4: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R276

D24497: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-17 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R265:bf157dfa4d76: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24497?vs=68010=68203#toc REPOSITORY R265

D24617: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-17 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R293:7c58c615206e: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R293

D24707: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-17 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R269:02721f6c30fa: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24707?vs=68073=68188#toc REPOSITORY R269

D24611: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-17 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R286:7e971bfd6d2a: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D24600: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-17 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R275:c03781b0a6b7: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R275 KItemModels CHANGES SINCE LAST UPDATE

D24608: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-17 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R302:f046410b316f: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24608?vs=67843=68167#toc REPOSITORY R302

D24466: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-17 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R263:808bd05b37e4: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24466?vs=67733=68160#toc REPOSITORY R263

D24466: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-17 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kossebau wrote in kactioncollection.h:308 > Fixed to `KXMLGUI_ENABLE_DEPRECATED_SINCE`, as `slotActionHighlighted` is a > virtual method, which the compiler needs to always know about. Eh, fixed to KXMLGUI_BUILD_DEPRECATED_SINCE actually :)

D24466: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-17 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kactioncollection.h:308 > > +#if KXMLGUI_ENABLE_DEPRECATED_SINCE(5, 0) > /** Fixed to `KXMLGUI_ENABLE_DEPRECATED_SINCE`, as `slotActionHighlighted` is a virtual method, which the compiler needs to always know about. REPOSITORY R263

D24495: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-17 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R284:adb16c18d98c: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R284 KCompletion CHANGES SINCE LAST UPDATE

D24710: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-17 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R301:2f0fffb70604: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R301 KEmoticons CHANGES SINCE LAST UPDATE

D24466: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-17 Thread Friedrich W. H. Kossebau
kossebau added a comment. @dfaure Any remaining issues from your side, or is your +1 available as well now? :) REPOSITORY R263 KXmlGui BRANCH deprecatedapi REVISION DETAIL https://phabricator.kde.org/D24466 To: kossebau, #frameworks, dfaure, mlaurent Cc: kde-frameworks-devel,

D24537: Icons for windy weather

2019-10-17 Thread Friedrich W. H. Kossebau
kossebau added a subscriber: spstarr. kossebau added a comment. Good work with the icons. Seems there is also need for snow + wind, @vkrause & @spstarr can and hopefully tell you more. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24537 To: cblack,

D24599: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-16 Thread Friedrich W. H. Kossebau
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R270:76460e89854f: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). REPOSITORY R270

D24643: Use ECMGenerateExportHeader to manage deprecated API better

2019-10-16 Thread Friedrich W. H. Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R268:b6a1e260c42a: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24643?vs=67925=68104#toc REPOSITORY R268

D23927: Improve naming of KTitleWidget icon methods

2019-10-16 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D23927#548607 , @kossebau wrote: > Any chance you could pik this up and complete? Thing is, the deprecated API is also still used internally,so anything but deprecated. Actually the new API calls the "deprecated"

  1   2   3   4   5   6   7   8   9   10   >