D14435: Fix KTimeComboBox input mask for AM/PM times

2018-08-03 Thread Glenn Watson
glennw added a comment. Yes, you got the address and the reference correct - that sounds like it would have been quite the project! REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D14435 To: glennw, cfeck, mlaurent Cc: ngraham, kde-frameworks-devel, michaelh,

D14435: Fix KTimeComboBox input mask for AM/PM times

2018-08-01 Thread Glenn Watson
glennw updated this revision to Diff 38890. glennw added a comment. Switched test to use QVERIFY(). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14435?vs=38748=38890 REVISION DETAIL https://phabricator.kde.org/D14435 AFFECTED FILES

D14435: Fix KTimeComboBox input mask for AM/PM times

2018-07-30 Thread Glenn Watson
glennw updated this revision to Diff 38748. glennw added a comment. Updated to include test for 24hr locales. REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14435?vs=38685=38748 REVISION DETAIL https://phabricator.kde.org/D14435 AFFECTED FILES

D14435: Fix KTimeComboBox input mask for AM/PM times

2018-07-28 Thread Glenn Watson
glennw updated this revision to Diff 38685. glennw added a comment. Added an autotest to ensure that the line edit mask is updated correctly. A couple of notes about the test results below: - I tried to set the current locale in the new test to ensure it reproduces. The setLocale()

D14435: Fix KTimeComboBox input mask for AM/PM times

2018-07-28 Thread Glenn Watson
glennw added reviewers: cfeck, mlaurent. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D14435 To: glennw, cfeck, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14435: Fix KTimeComboBox input mask for AM/PM times

2018-07-28 Thread Glenn Watson
glennw created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. glennw requested review of this revision. REVISION SUMMARY In some cases, the strings returned from amText() and pmText() may differ in case to