D18864: FlatBuffers schema syntax highlighting

2019-02-11 Thread Harald Fernengel
This revision was automatically updated to reflect the committed changes. Closed by commit R216:926feb55fa02: FlatBuffers schema syntax highlighting (authored by harald). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18864?vs=51331=51398

D18864: FlatBuffers schema syntax highlighting

2019-02-10 Thread Harald Fernengel
harald marked 2 inline comments as done. harald added a comment. In D18864#408305 , @dhaumann wrote: > Hi Harald, nice hearing from you. Patch looks good and can almost go in as is. But could you address the two comments and also add a test file

D18864: FlatBuffers schema syntax highlighting

2019-02-10 Thread Harald Fernengel
harald updated this revision to Diff 51331. harald added a comment. Added test, license and highlighting of attributes REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18864?vs=51217=51331 BRANCH flatbuffers (branched from master) REVISION

D18864: FlatBuffers schema syntax highlighting

2019-02-08 Thread Harald Fernengel
harald created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. harald requested review of this revision. REVISION SUMMARY Support for FlatBuffers schema, for grammar see

D16801: Fix build on macOS

2018-11-13 Thread Harald Fernengel
harald abandoned this revision. harald added a comment. Abandoned, already fixed by https://phabricator.kde.org/D16862 REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D16801 To: harald Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16801: Fix build on macOS

2018-11-13 Thread Harald Fernengel
harald removed a reviewer: apol. This revision now requires review to proceed. REPOSITORY R268 KGlobalAccel REVISION DETAIL https://phabricator.kde.org/D16801 To: harald, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16801: Fix build on macOS

2018-11-10 Thread Harald Fernengel
harald created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. harald requested review of this revision. REVISION SUMMARY On macOS, I'm getting the following error: CMake Error at src/runtime/plugins/CMakeLists.txt:1 (if): if

Re: Review Request 130138: Set QT_NO_EXCEPTIONS when building *.mm files

2017-06-01 Thread Harald Fernengel
Testing --- Thanks, Harald Fernengel

Re: Review Request 130139: Set QT_NO_EXCEPTIONS for *.mm files

2017-06-01 Thread Harald Fernengel
' with exceptions disabled Diffs - src/kdeinit/CMakeLists.txt f00dd77baa95dbe7583e08760302951446aff387 Diff: https://git.reviewboard.kde.org/r/130139/diff/ Testing --- Thanks, Harald Fernengel

Re: Review Request 130139: Set QT_NO_EXCEPTIONS for *.mm files

2017-06-01 Thread Harald Fernengel
- Harald --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130139/#review103244 --- On May 25, 2017, 11:37 a.m., Harald Fernen

Re: Review Request 123075: do not require X11 on Mac OS X

2017-06-01 Thread Harald Fernengel
, Harald Fernengel

Review Request 130139: Set QT_NO_EXCEPTIONS for *.mm files

2017-05-25 Thread Harald Fernengel
f00dd77baa95dbe7583e08760302951446aff387 Diff: https://git.reviewboard.kde.org/r/130139/diff/ Testing --- Thanks, Harald Fernengel

Review Request 130138: Set QT_NO_EXCEPTIONS when building *.mm files

2017-05-25 Thread Harald Fernengel
ren't used in the code, let's just build without. Diffs - src/plugins/nsspellchecker/CMakeLists.txt f8c99d1ea080b1e28f60c57f8f588ed059c96711 Diff: https://git.reviewboard.kde.org/r/130138/diff/ Testing --- Thanks, Harald Fernengel

Re: Review Request 125390: Fix build on Mac OS X

2015-09-29 Thread Harald Fernengel
marked as submitted. Review request for KDE Frameworks and Alex Merry. Changes --- Submitted with commit 0f8592f27064ba92485928a0de074c58118414aa by Harald Fernengel to branch master. Repository: kdesignerplugin Description --- Qt 5.5 requires Qt5UiPlugin framework

Re: Review Request 125337: Mark kconfig-compiler as non-gui tool

2015-09-25 Thread Harald Fernengel
marked as submitted. Review request for KDE Frameworks, Aleix Pol Gonzalez and Matthew Dawson. Changes --- Submitted with commit 83b223025670494116349382144780143f6e9563 by Harald Fernengel to branch master. Repository: kconfig Description --- Makes sure that it doens't create

Review Request 125390: Fix build on Mac OS X

2015-09-25 Thread Harald Fernengel
15db23db3c275c231487d8bafc8fb3f4df624905 Diff: https://git.reviewboard.kde.org/r/125390/diff/ Testing --- Thanks, Harald Fernengel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 125337: Mark kconfig-compiler as non-gui tool

2015-09-21 Thread Harald Fernengel
, Harald Fernengel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 123075: do not require X11 on Mac OS X

2015-03-19 Thread Harald Fernengel
: kdesu Description --- do not require X11 on Mac OS X Diffs - CMakeLists.txt 9623483d6f11f9cdb7d7dc19decfd7cf5e86d079 Diff: https://git.reviewboard.kde.org/r/123075/diff/ Testing --- Thanks, Harald Fernengel ___ Kde-frameworks-devel

Re: Review Request 119567: Also find catalog files that are symlinks

2015-02-12 Thread Harald Fernengel
://git.reviewboard.kde.org/r/119567/diff/ Testing --- Builds on Mac OS X Thanks, Harald Fernengel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119567: Also find catalog files that are symlinks

2014-08-10 Thread Harald Fernengel
://git.reviewboard.kde.org/r/119567/#review63656 --- On Aug. 1, 2014, 5:58 p.m., Harald Fernengel wrote: --- This is an automatically generated e-mail. To reply, visit: https

Review Request 119567: Also find catalog files that are symlinks

2014-08-01 Thread Harald Fernengel
fixes the build on Mac OS X. Diffs - src/docbookl10nhelper.cpp 6eecb376cab6e3ba03e9548b3402eaa5e5530198 src/xslt.cpp 3c81a172b00458419fc2f310cbdf76eb357336fc Diff: https://git.reviewboard.kde.org/r/119567/diff/ Testing --- Builds on Mac OS X Thanks, Harald Fernengel

Re: Review Request 115977: RFC: Install KArchive as Mac OS X Framework

2014-04-14 Thread Harald Fernengel
: https://git.reviewboard.kde.org/r/115977/diff/ Testing --- 'make install' on Mac OS X Thanks, Harald Fernengel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115977: RFC: Install KArchive as Mac OS X Framework

2014-03-24 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115977/#review51936 --- On Feb. 23, 2014, 7:15 p.m., Harald Fernengel wrote

Re: Review Request 115982: Add a tool that creates a Mac OS X icns (icon) file from a svg file

2014-03-04 Thread Harald Fernengel
/CMakeLists.txt PRE-CREATION src/CMakeLists.txt 76932ca87c7de2dc25398e1fca8916426ce7e566 Diff: https://git.reviewboard.kde.org/r/115982/diff/ Testing --- Builds on Mac OS X Thanks, Harald Fernengel ___ Kde-frameworks-devel mailing list Kde

Re: Review Request 115752: Change DATA_INSTALL_DIR on Mac OS X

2014-03-04 Thread Harald Fernengel
/KDEInstallDirs.cmake 9ff23540f00a2794b1ebd842656c3d61b047a500 Diff: https://git.reviewboard.kde.org/r/115752/diff/ Testing --- Tested with homebrew tap at https://github.com/haraldF/homebrew-kf5 Thanks, Harald Fernengel ___ Kde-frameworks-devel mailing list

Review Request 115977: RFC: Install KArchive as Mac OS X Framework

2014-02-23 Thread Harald Fernengel
OS X Thanks, Harald Fernengel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Mac OS X Frameworks Frameworks

2014-02-23 Thread Harald Fernengel
Hi, TL;DR Do we want to do build KDE Frameworks as Mac OS X Frameworks? Long Story: on Mac OS X, libraries are typically deployed as Frameworks (e.g. a directory containing the shared library, headers, resources and meta data). A framework can be simply draggeddropped to Xcode projects and

Review Request 115982: Add a tool that creates a Mac OS X icns (icon) file from a svg file

2014-02-23 Thread Harald Fernengel
: https://git.reviewboard.kde.org/r/115982/diff/ Testing --- Builds on Mac OS X Thanks, Harald Fernengel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 115752: Change DATA_INSTALL_DIR on Mac OS X

2014-02-14 Thread Harald Fernengel
/r/115752/diff/ Testing --- Tested with homebrew tap at https://github.com/haraldF/homebrew-kf5 Thanks, Harald Fernengel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115541: Build fix for Mac OS X

2014-02-12 Thread Harald Fernengel
frameworks. Note - this might not be the best solution, but we need one in order to deploy on Mac OS X :) Diffs - src/CMakeLists.txt 676c8a8e78420371bba19414b3f090180a49758d Diff: https://git.reviewboard.kde.org/r/115541/diff/ Testing --- Only on Mac OS X Thanks, Harald Fernengel

Review Request 115699: Build on Mac OS X

2014-02-12 Thread Harald Fernengel
f2dc2b1b3d22fa38cfe6af4a7761c148f840620d Diff: https://git.reviewboard.kde.org/r/115699/diff/ Testing --- Compiles on Mac OS X. Thanks, Harald Fernengel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

2014-02-12 Thread Harald Fernengel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115684/#review49655 --- Ship it! Ship It! - Harald Fernengel On Feb. 11, 2014, 10

Re: Review Request 115684: Generate local forwarding headers under a local subdir, to fix clash on Mac OS X.

2014-02-12 Thread Harald Fernengel
://git.reviewboard.kde.org/r/115684/ --- (Updated Feb. 11, 2014, 10:15 p.m.) Review request for Build System, Extra Cmake Modules, KDE Frameworks, and Harald Fernengel. Repository: extra-cmake-modules Description --- Generate

Re: Review Request 115699: Build on Mac OS X

2014-02-12 Thread Harald Fernengel
/kapplication.cpp 47e4983c7392a0d60036ae86d976ae689a40d54a src/kdeui/kmenubar.cpp f2dc2b1b3d22fa38cfe6af4a7761c148f840620d Diff: https://git.reviewboard.kde.org/r/115699/diff/ Testing --- Compiles on Mac OS X. Thanks, Harald Fernengel ___ Kde

Review Request 115708: Build on Mac OS X

2014-02-12 Thread Harald Fernengel
5c824941359a68eb8dc54836d05db1fdb217bf6a Diff: https://git.reviewboard.kde.org/r/115708/diff/ Testing --- Building on Mac OS X Thanks, Harald Fernengel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde

Re: Review Request 115708: Build on Mac OS X

2014-02-12 Thread Harald Fernengel
/#comment34965 Note - cmake is documented to replace the COMMAND by the actual command, as we added it with add_executable before. Still, I would like someone to test this on non Mac OS X platforms :) - Harald Fernengel On Feb. 12, 2014, 9:46 p.m., Harald Fernengel wrote

Re: Review Request 115209: Fix KDoctools build on Windows

2014-02-12 Thread Harald Fernengel
and it fixes the build also on Mac OS X :) Nicely done! - Harald Fernengel On Jan. 22, 2014, 3:12 p.m., Alexander Richardson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115209

Re: Review Request 115708: Build on Mac OS X

2014-02-12 Thread Harald Fernengel
the executable has a .exe suffix Diffs - src/CMakeLists.txt 5c824941359a68eb8dc54836d05db1fdb217bf6a Diff: https://git.reviewboard.kde.org/r/115708/diff/ Testing --- Building on Mac OS X Thanks, Harald Fernengel ___ Kde-frameworks

Re: Review Request 115541: Build fix for Mac OS X

2014-02-10 Thread Harald Fernengel
/kde_frameworks/include/KF5/KParts/KParts/ReadWritePart -- Up-to-date: /d/kde/inst/kde_frameworks/include/KF5/KParts/kparts/readwritepart.h Since there is no filename clash, what is the issue if these end up in the same folder on Mac OSX? Harald Fernengel wrote: Here's the layout

Re: Review Request 115541: Build fix for Mac OS X

2014-02-08 Thread Harald Fernengel
/#review49240 --- On Feb. 7, 2014, 7:37 p.m., Harald Fernengel wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115541

Review Request 115541: Build fix for Mac OS X

2014-02-07 Thread Harald Fernengel
on Mac OS X :) Diffs - src/CMakeLists.txt 676c8a8e78420371bba19414b3f090180a49758d Diff: https://git.reviewboard.kde.org/r/115541/diff/ Testing --- Only on Mac OS X Thanks, Harald Fernengel ___ Kde-frameworks-devel mailing list Kde

Review Request 115494: Build on Mac OS X

2014-02-05 Thread Harald Fernengel
://git.reviewboard.kde.org/r/115494/diff/ Testing --- It compiles again on Mac OS X :) Thanks, Harald Fernengel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 115494: Build on Mac OS X

2014-02-05 Thread Harald Fernengel
/operations.h a54f366330b937a027d478cbe018a7c1c21c1625 Diff: https://git.reviewboard.kde.org/r/115494/diff/ Testing --- It compiles again on Mac OS X :) Thanks, Harald Fernengel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

Re: Review Request 115494: Build on Mac OS X

2014-02-05 Thread Harald Fernengel
src/kjs/operations.h a54f366 Diff: https://git.reviewboard.kde.org/r/115494/diff/ Testing --- It compiles again on Mac OS X :) Thanks, Harald Fernengel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org

Re: Review Request 115502: Fix math function checks

2014-02-05 Thread Harald Fernengel
:) - Harald Fernengel On Feb. 5, 2014, 5:03 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115502/ --- (Updated

Re: Review Request 115494: Build on Mac OS X

2014-02-05 Thread Harald Fernengel
://git.reviewboard.kde.org/r/115494/diff/ Testing --- It compiles again on Mac OS X :) Thanks, Harald Fernengel ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel