D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

2019-11-15 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > feverfew wrote in krun.cpp:598 > Yes, but note later I need to then change the values in the `QList` outside > of the for loop, hence why I store the index in a struct associated with the > reply. How would I do that easily with a range based for

D24641: Collect more information from version control systems

2019-11-15 Thread Harald Sitter
sitter added a comment. This is starting to look really good. All functions will need documenting in the header of that file so they show up on api.kde.org, see other modules for examples. INLINE COMMENTS > ECMSourceVersionControl.cmake:61 > + >

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

2019-11-15 Thread Harald Sitter
sitter added a comment. some style complaints. Looks great other than that  INLINE COMMENTS > krun.cpp:583 > +const QUrl url = urls[i]; > +if (KIO::DesktopExecParser::isProtocolInSupportedList(url, > appSupportedProtocols)) > +continue; Coding style

D25308: when kioslave5 couldn't be found in libexec-ish locations try $PATH

2019-11-14 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY on windows we install the binary to bin/ where software that uses kio can find it

D25170: make the libssh finder ensure the new ssh target is set

2019-11-14 Thread Harald Sitter
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R320:24506c2af8d1: make the libssh finder ensure the new ssh target is set (authored by sitter). REPOSITORY R320 KIO

D23384: [WIP] Adding support for mounting KIOFuse URLs for applications that don't use KIO

2019-11-06 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > desktopexecparser.cpp:314 > +org::kde::KIOFuse kiofuse_iface(QStringLiteral("org.kde.KIOFuse"), > +QStringLiteral("/org/kde/KIOFuse"), > +QDBusConnection::sessionBus()); align

D25159: Fix linking to libssh 0.9.1

2019-11-06 Thread Harald Sitter
sitter added a comment. D25170 for when that lands REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25159 To: arojas, apol, sitter, fvogt Cc: nisavid, fvogt, sitter, asn, apol, asturmlechner, kde-frameworks-devel, kfm-devel,

D25170: make the libssh finder ensure the new ssh target is set

2019-11-06 Thread Harald Sitter
sitter added a comment. NB: depends on https://gitlab.com/libssh/libssh-mirror/merge_requests/71 getting landed. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D25170 To: sitter Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n,

D25170: make the libssh finder ensure the new ssh target is set

2019-11-06 Thread Harald Sitter
sitter created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY starting with 0.9.2 the libssh cmake config defines a new ssh imported target, use this as the new

Re: Notice of intention to remove tests from KCrash and KNotifications

2019-11-06 Thread Harald Sitter
On Wed, Nov 6, 2019 at 8:07 AM Ben Cooksley wrote: > > On Tue, Nov 5, 2019 at 11:50 PM Harald Sitter wrote: > > > > I get where you are coming from, but honestly, none of this makes > > pushing unreviewed commits that disable the entire test collection of > > an ent

D25159: Fix linking to libssh 0.9.1

2019-11-05 Thread Harald Sitter
sitter added a comment. In D25159#559016 , @asn wrote: > We moved from a manually generated libssh-config.cmake to install(EXPORTS libssh-config) and it does things completely different. > > I'm currently trying to fix it. However better

D25159: Fix linking to libssh 0.9.1

2019-11-05 Thread Harald Sitter
sitter added subscribers: asn, sitter. sitter accepted this revision. sitter added a comment. I think there's a smarter way of dealing with this somewhere in our finder, not blocking though. I'll take a look when I find a minute. @asn it seems to me the cmake config broke compat between

Re: Notice of intention to remove tests from KCrash and KNotifications

2019-11-05 Thread Harald Sitter
he's back from QtWS. On Tue, Nov 5, 2019 at 12:10 PM Adrian Chaves wrote: > > Would it make sense to re-enable those tests in the code repositories > but disable CI for the corresponding repositories until someone > addressed the issues affecting overall CI? > > On 2019-11-05 11

D25153: disable kcrashtest and its helper executable test_crasher on windows

2019-11-05 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R285:d3b83d931176: disable kcrashtest and its helper executable test_crasher on windows (authored by sitter). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE

D25154: actually set a dependency between kcrashtest and test_crasher

2019-11-05 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R285:cc0d3c8b7977: actually set a dependency between kcrashtest and test_crasher (authored by sitter). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE

D25152: Reenable the tests and only disable krcrashtest on windows

2019-11-05 Thread Harald Sitter
sitter added a comment. Heh, sorry  D25153 for reference. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D25152 To: ahmadsamir, #frameworks, sitter Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: Notice of intention to remove tests from KCrash and KNotifications

2019-11-05 Thread Harald Sitter
On Tue, Nov 5, 2019 at 11:11 PM Harald Sitter wrote: > > > > Perhaps you need to find a minion to do these changes for you then or > > read up on cmake and/or put these changes through review, because for > > KCrash you also disabled and unrelated test :| > > It wou

D25154: actually set a dependency between kcrashtest and test_crasher

2019-11-05 Thread Harald Sitter
sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the former uses the latter to actualy conduct its test. without the declared dependency `make kcrashtest` would not

D25153: disable kcrashtest and its helper executable test_crasher on windows

2019-11-05 Thread Harald Sitter
sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY test_crasher gets stuck in a loop breaking the CI system. let's disable the entire test until someone finds the

Re: Notice of intention to remove tests from KCrash and KNotifications

2019-11-05 Thread Harald Sitter
Perhaps you need to find a minion to do these changes for you then or read up on cmake and/or put these changes through review, because for KCrash you also disabled and unrelated test :| On Tue, Nov 5, 2019 at 10:24 AM Ben Cooksley wrote: > > On Tue, Nov 5, 2019 at 1:20 AM Harald Sitter

Re: Notice of intention to remove tests from KCrash and KNotifications

2019-11-04 Thread Harald Sitter
Wouldn't the more appropriate workaround then be to disable the test on windows? On Mon, Nov 4, 2019 at 10:57 AM Ben Cooksley wrote: > > On Mon, Nov 4, 2019 at 10:53 PM David Edmundson > wrote: > > > > Given kcrashtest passes locally, can you please confirm that by > > "remove" you mean disable

D25079: [CopyJob] Increase the amount of data sendfile can copy at once

2019-10-30 Thread Harald Sitter
sitter added a comment. TBH, I would move away from the hardcoding in general try to sendfile size_of_file and `if n < size` use n as new count for the next cycle. The second cycle will use the maximum regardless of what the specific kernel version has as maximum. The maximum is an

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

2019-10-25 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R241:de3ca85f058e: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24827?vs=68526=68741

D24908: fix default shortcut detection

2019-10-25 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R263:e9387f561fa2: fix default shortcut detection (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24908?vs=68652=68740#toc REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE

D24887: WIP slave command behavior assertion system

2019-10-25 Thread Harald Sitter
sitter added a comment. About the list of unexpected signals in forCommand(): It looks that at least http, ftp, and sftp do call connected() as part of various commands. e.g. all do it during get(). Does that make sense? connected() refers to openConnection() in its documentation, and

D24908: fix default shortcut detection

2019-10-24 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > aacid wrote in kshortcuteditwidget.cpp:72 > this is wrong, isn't it? > > Or at least behaviour changing, before m_defaultLabel was set to None, when > defaultText was empty. Now it's not? it's initialized to None via the ctor at line 68 already.

D24908: fix default shortcut detection

2019-10-24 Thread Harald Sitter
sitter added a comment. Supposedly, I was being lazy though since there is no pre existing test and I don't exactly know if there's anything to watch out for when testing widgets (as in: I've never written a widget test before). REPOSITORY R263 KXmlGui REVISION DETAIL

D24641: Collect more information from version control systems

2019-10-24 Thread Harald Sitter
sitter added a comment. Hm, how about separate functions though? With a single stat any given build still needs N process forks even when they only want 1 value. In D24641#548394 , @thomasfischer wrote: > To clarify

D24908: fix default shortcut detection

2019-10-24 Thread Harald Sitter
sitter added a reviewer: dfaure. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D24908 To: sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24908: fix default shortcut detection

2019-10-24 Thread Harald Sitter
sitter edited the test plan for this revision. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D24908 To: sitter Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24908: fix default shortcut detection

2019-10-24 Thread Harald Sitter
sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY When the default shortcut is empty the UI string "None" is used to indicate that. Alas, when mapping QKeySequences to

D23537: extend state verification to open connection commands

2019-10-23 Thread Harald Sitter
sitter abandoned this revision. sitter added a comment. Replaced by D24887 which instead creates a more generic system to verify slave behavior. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23537 To: sitter, dfaure Cc: fsitter,

D24887: WIP slave command behavior assertion system

2019-10-23 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY This implements a simple expectation system covering slave commands. At its heart sits

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

2019-10-22 Thread Harald Sitter
sitter updated this revision to Diff 68526. sitter added a comment. remove warning REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24827?vs=68428=68526 BRANCH assert-for-git REVISION DETAIL https://phabricator.kde.org/D24827 AFFECTED FILES

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

2019-10-22 Thread Harald Sitter
sitter marked 3 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24827 To: sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

2019-10-22 Thread Harald Sitter
sitter edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24827 To: sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

2019-10-22 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > dfaure wrote in CMakeLists.txt:49 > It does, but people can still pass -DCMAKE_BUILD_TYPE=Release, or > RelWithDebInfo (as I do for profiling). > > Won't this give them the warning below then, even if they don't set the > KIO_ASSERT_SLAVE_STATES

D23537: extend state verification to open connection commands

2019-10-21 Thread Harald Sitter
sitter added a comment. I've actually started work on a more general system for this. Will update soon. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23537 To: sitter, dfaure Cc: fsitter, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23537: extend state verification to open connection commands

2019-10-21 Thread Harald Sitter
sitter planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23537 To: sitter, dfaure Cc: fsitter, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

2019-10-21 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY testing high level functionality of a bunch of relevant slaves yielded no obvious

D24568: Provide clang-format target with a KDE Frameworks style file

2019-10-17 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > KDEClangFormat.cmake:53 > +# try to find clang-format in path > +find_program(KDE_CLANG_FORMAT_EXECUTABLE clang-format) > + I'm pretty sure you need to check the version the exectuable. When I use 6.0 I get ctors smushed into one line.

D24487: fix password error condition handling of smb mount

2019-10-17 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:45b1327a6dac: fix password error condition handling of smb mount (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24487?vs=67483=68112

D24655: give all pointers in slavebase a default init to nullptr

2019-10-15 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R241:c2bd18f17e61: give all pointers in slavebase a default init to nullptr (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24655?vs=67944=67947

D24655: give all pointers in slavebase a default init to nullptr

2019-10-15 Thread Harald Sitter
sitter created this revision. sitter added reviewers: dfaure, meven. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY lest they don't get initialized and then end up crashing should get get deleted

D24641: Collect more information from version control systems

2019-10-15 Thread Harald Sitter
sitter added a comment. Do we have a request for this outside kbibtex? My attitude towards adding things to ECM is always "is there more than one user". ECM_SOURCE_VERSION_CONTROL_COMMIT_COUNT seems very specific and opinionated (what's origin? does it count commits in merges? also the

D24631: exclude ioslaves directory from api docs

2019-10-14 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R241:d05d03f2f13e: exclude ioslaves directory from api docs (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24631?vs=67895=67900 REVISION DETAIL

D24631: exclude ioslaves directory from api docs

2019-10-14 Thread Harald Sitter
sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY they do not feature (public) api TEST PLAN kapidox_generate no longer lists slave classes that happen to have

D24558: fix proxy setting loading

2019-10-14 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R241:d1a3b9d08158: fix proxy setting loading (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24558?vs=67702=67880 REVISION DETAIL

D24559: simplify the url parsing

2019-10-14 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R241:c904cbcb9876: simplify the url parsing (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24559?vs=67703=67881 REVISION DETAIL

D24560: remove legacy space handling code

2019-10-14 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R241:c372fa3c4236: remove legacy space handling code (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24560?vs=67704=67882 REVISION DETAIL

D23579: port ftp slave to new error reporting system

2019-10-14 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. sitter marked 3 inline comments as done. Closed by commit R241:c86eedf0f92d: port ftp slave to new error reporting system (authored by sitter). CHANGED PRIOR TO COMMIT

D23579: port ftp slave to new error reporting system

2019-10-11 Thread Harald Sitter
sitter edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23579 To: sitter, dfaure Cc: anthonyfieroni, dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24560: remove legacy space handling code

2019-10-11 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the raw data in kioslaverc uses the format "$url $port", this format isn't being read

D24559: simplify the url parsing

2019-10-11 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY all urls need to have their ports stripped and text set, so de-duplicate the shared

D24558: fix proxy setting loading

2019-10-11 Thread Harald Sitter
sitter added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24558 To: sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24558: fix proxy setting loading

2019-10-11 Thread Harald Sitter
sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY when the flag isn't set we'd set the text to urlStr, urlStr however was the original string *with* the port. since we

D23579: port ftp slave to new error reporting system

2019-10-11 Thread Harald Sitter
sitter updated this revision to Diff 67697. sitter added a comment. move away from helper functions to redirect to q-> and instaed call via q-> directly REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23579?vs=67695=67697 BRANCH ftp REVISION DETAIL

D23579: port ftp slave to new error reporting system

2019-10-11 Thread Harald Sitter
sitter retitled this revision from "WIP: port ftp slave to new error reporting system" to "port ftp slave to new error reporting system". sitter edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23579 To: sitter, dfaure Cc:

D23579: WIP: port ftp slave to new error reporting system

2019-10-11 Thread Harald Sitter
sitter updated this revision to Diff 67695. sitter marked 24 inline comments as done. sitter added a comment. - rebase - ftpSendCmd now returns a bool (continues to require_result) - openConnection now emits opened() - listDir now finalize()s - debug-- - ftpSendCmd's lazy login now

Re: Akonadi SchemaVersionTable is broken with PostgreSQL Version 12 changes

2019-10-10 Thread Harald Sitter
Hey, Please file bug reports about issues: https://bugs.kde.org/enter_bug.cgi?product=Akonadi On Thu, Oct 10, 2019 at 12:29 AM Stuart wrote: > > Dear development team, > > As per the PostgreSQL release documents: > E.1. Release 12 >

D24487: fix password error condition handling of smb mount

2019-10-08 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: dfaure. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY this was previously wrong in two ways: 1. errors from the

D24387: improve error reporting for when kpasswdserver is unreachable

2019-10-08 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:5a8705548fae: improve error reporting for when kpasswdserver is unreachable (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D24387: improve error reporting for when kpasswdserver is unreachable

2019-10-08 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > dfaure wrote in kio_smb_mount.cpp:72 > (pre-existing: shouldn't this call `error` rather than `finished`?) Ah yes, I was thinking the same thing but didn't manage to find a reasonable way to use this feature so it's hard to test. I'll write my

D24387: improve error reporting for when kpasswdserver is unreachable

2019-10-04 Thread Harald Sitter
sitter edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D24387 To: sitter, #frameworks, dfaure Cc: ngraham, kde-frameworks-devel, kfm-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew,

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

2019-10-03 Thread Harald Sitter
sitter added a comment. My point is that your lamentations have nothing to do with this class but with Q*Animation on your system. So you need to find out what's wrong and talk to Qt. I am 100% against a workaround that degrades the user experience when the bug isn't even in this class.

D24387: improve error reporting for when kpasswdserver is unreachable

2019-10-03 Thread Harald Sitter
sitter created this revision. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY previously we'd not forward the errors coming out of the password dialog helper and instead

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

2019-10-03 Thread Harald Sitter
sitter added a comment. The demo doesn't even use this widget breeze F7506213: Peek 2019-10-03 13-46.gif oxygen F7506215: Peek 2019-10-03 13-45.gif REPOSITORY R236 KWidgetsAddons REVISION DETAIL

D22375: new class KBusyIndicatorWidget similar to QtQuick's BusyIndicator

2019-10-03 Thread Harald Sitter
sitter added a comment. F7505620: Peek 2019-10-03 12-23.gif REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D22375 To: sitter, cfeck, apol Cc: rjvbb, ngraham, kossebau, broulik, kde-frameworks-devel, apol, LeGast00n,

D24159: new module ECMSourceVersionControl

2019-10-01 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R240:f3f4893b5bd2: new module ECMSourceVersionControl (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24159?vs=4=67114 REVISION

D23579: WIP: port ftp slave to new error reporting system

2019-09-24 Thread Harald Sitter
sitter edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D23579 To: sitter, dfaure Cc: anthonyfieroni, dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23579: WIP: port ftp slave to new error reporting system

2019-09-24 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > dfaure wrote in ftptest.cpp:186 > what's bad quot? > > Is this test about a bug, or the job failing is what we want? That was meant to read quota. I've changed it to QVERIFY(!job->exec()); as per your earlier comment. > dfaure wrote in

D23579: WIP: port ftp slave to new error reporting system

2019-09-24 Thread Harald Sitter
sitter updated this revision to Diff 66747. sitter marked 31 inline comments as done. sitter added a comment. address numerous comments (marked done on phab) REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23579?vs=64989=66747 BRANCH ftp REVISION DETAIL

D24159: new module ECMSourceVersionControl

2019-09-23 Thread Harald Sitter
sitter created this revision. sitter added reviewers: kde-buildsystem, dfaure. Herald added projects: Frameworks, Build System. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY simply sets a variable when the source is under version

D24076: add a simple smoke test for slaves by using kioclient5

2019-09-23 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:6bdc413c720b: add a simple smoke test for slaves by using kioclient5 (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24076?vs=66452=66655

D24076: add a simple smoke test for slaves by using kioclient5

2019-09-23 Thread Harald Sitter
sitter added a comment. In D24076#534627 , @feverfew wrote: > I won't review, but would like to note I think that with KIOFuse, in conjuction with fio we can do some really complex testing on KIO, correct me if

D24076: add a simple smoke test for slaves by using kioclient5

2019-09-19 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: dfaure. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY this is meant to give a fairly generic way to easily test core

D23579: WIP: port ftp slave to new error reporting system

2019-08-30 Thread Harald Sitter
sitter created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY This system is a bit inspired by an earlier patch I threw together in a half hour to prevent the actual logic code from

D23344: assert slave command finality

2019-08-29 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R241:830c56744f2b: assert slave command finality (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23344?vs=64826=64928 REVISION DETAIL

D23344: assert slave command finality

2019-08-29 Thread Harald Sitter
sitter added a comment. Shoes! I meant shoes!  REPOSITORY R241 KIO BRANCH assert REVISION DETAIL https://phabricator.kde.org/D23344 To: sitter, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23552: ECM: remove set_package_properties from FindCanberra

2019-08-28 Thread Harald Sitter
sitter added a comment. No objections from me. This was explicitly suggested during review though, so I'd like @cgiboudeaux to approve this. INLINE COMMENTS > FindCanberra.cmake:95 > > include(FeatureSummary) > Can be removed as well. REPOSITORY R240 Extra CMake Modules REVISION

D23537: extend state verification to open connection commands

2019-08-28 Thread Harald Sitter
sitter added a comment. I do wonder if maybe it would make sense to revise the verification system to be based off of a list of allowed/forbidden functions that may be called during a command. e.g. for open the requirements are actually more complicated than this diff establishes. It

D23537: extend state verification to open connection commands

2019-08-28 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY - open/seek/read/write: may not call finished (only error) - close: must reach

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

2019-08-28 Thread Harald Sitter
sitter added a comment. @dfaure this is actually a different beast altogether, the current state validation is only run on the API for all slaves, seek/read/write are run in a completely different loop which I see isn't being verified at all. I'll add it in a separate diff once the

D23344: assert slave command finality

2019-08-28 Thread Harald Sitter
sitter updated this revision to Diff 64826. sitter added a comment. some days one has to wonder how I manage to put on shows. fix warning branch as per David's comments to actually do nothing when the cond was matched REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

2019-08-27 Thread Harald Sitter
sitter added a comment. SlaveBase (which the slaves derive from) runs a command loop, out of this command loop come the actual calls to the API functions. So, in said command loop we can verify which state the slave is in before and more importantly after any API call. Specifically about

D23207: Fixing implementation of FileJob interface in smb/sftp slaves

2019-08-27 Thread Harald Sitter
sitter added a comment. Not knowing the background here at a glance I would argue that SlaveBase in KIO should be getting state verification on all of this,. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23207 To: feverfew, chinmoyr, fvogt, sitter, dfaure Cc:

D23344: assert slave command finality

2019-08-27 Thread Harald Sitter
sitter updated this revision to Diff 64744. sitter added a comment. - wrap in custom assert defines that either assert or qwarn based on a cmake option - new cmake option KIO_ASSERT_SLAVE_STATES enables the asserts. the option is only on by default when run on jenkins - fix a bunch of

D23381: Allow splitting lists using ;

2019-08-26 Thread Harald Sitter
sitter added a comment. Shouldn't you be using KConfigGroup::readXdgListEntry? KConfig is strangely conflicted with it's default assumption being that you want the legacy comma lists so if you want xdg-style lists you need to call different functions altogether. That said I think Kai and I

D21795: [KAuth] Add support for action details in Polkit1 backend.

2019-08-26 Thread Harald Sitter
sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. Unfortunately I've noticed a huge blocker... polkit-qt-1 with the `checkAuthorizationWithDetails` change is not actually released. That needs fixing :|

D23344: assert slave command finality

2019-08-24 Thread Harald Sitter
sitter added a comment. Yeah, it's certainly a very aggressive change. I also think we need this to be outside kdeinit5, otherwise unit tests won't crash since they generally should fork directly. That being said, as a first step maybe we can have this enabled on the CI and see if existing

D23348: force applicationDirPath into first position when finding plugins

2019-08-22 Thread Harald Sitter
sitter added a comment. That is a solvable problem, there's a property to control where things end up in the build tree: `set_target_properties(kio_ftp PROPERTIES LIBRARY_OUTPUT_DIRECTORY "${CMAKE_BINARY_DIR}/bin/kf5/kio")` REPOSITORY R244 KCoreAddons REVISION DETAIL

D23348: force applicationDirPath into first position when finding plugins

2019-08-22 Thread Harald Sitter
sitter added a comment. Perhaps the answer actually is that QT_PLUGIN_PATH should not be necessary ;) This is a bit of a chicken and egg problem. When our software can't find plugins automatically we resort to QT_PLUGIN_PATH, but then because we use QT_PLUGIN_PATH we can't just break it

D23348: force applicationDirPath into first position when finding plugins

2019-08-22 Thread Harald Sitter
sitter abandoned this revision. sitter added a comment. Agh, you are very right of course. Things are never easy :/ REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D23348 To: sitter, mpyne, dfaure Cc: cullmann, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D23348: force applicationDirPath into first position when finding plugins

2019-08-22 Thread Harald Sitter
sitter created this revision. sitter added reviewers: mpyne, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY applicationDirPath technically is already part of libraryPaths BUT it's position

D23344: assert slave command finality

2019-08-22 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY this changes existing qwarnings in state verification logic to be assertive in order

D23262: disable autouic again - it breaks builds

2019-08-20 Thread Harald Sitter
sitter added a comment. https://gitlab.kitware.com/cmake/cmake/issues/19615 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D23262 To: sitter, apol, nicolasfella, cullmann Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh,

D23262: disable autouic again - it breaks builds

2019-08-19 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R240:557e5d898bf9: disable autouic again - it breaks builds (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23262?vs=64039=64042

D22805: set autorcc and autouic by default

2019-08-19 Thread Harald Sitter
sitter abandoned this revision. sitter added a comment. D23262 REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D22805 To: sitter, apol, nicolasfella Cc: cullmann, nicolasfella, cgiboudeaux, vkrause, kossebau, apol,

D23262: disable autouic again - it breaks builds

2019-08-19 Thread Harald Sitter
sitter created this revision. sitter added reviewers: apol, nicolasfella, cullmann. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY autouic (like automoc) assumes that

D22805: set autorcc and autouic by default

2019-08-19 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R240:60ca1a27e539: set autorcc and autouic by default (authored by sitter). REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22805?vs=64033=64037 REVISION

  1   2   3   4   5   6   7   8   >