Re: Merge tags in master branch?

2020-11-23 Thread Harald Sitter
Hej On 23.11.20 16:11, Bhushan Shah wrote: > Hello, > > So I have one question regarding the how we do the framework versioning. > Namely the tags, > > So currently some packages have a versioned tags on their master branch, > > i.e > > karchive: > > ➜ git describe > v5.76.0-1-g7304c28 > >

D28745: Skip caching thumbnails on encrypted filesystems

2020-10-09 Thread Harald Sitter
sitter added a comment. > Could this be delegated onto someone who knows Solid or should I try figuring it out by myself? Alas, I'm not sure there is anyone who feels responsible enough for solid, so you'll probably have to give it a go yourself. REPOSITORY R320 KIO Extras REVISION

D28745: Skip caching thumbnails on encrypted filesystems

2020-10-08 Thread Harald Sitter
sitter added a comment. In D28745#676452 , @marcingu wrote: > !PING. > I need help from someone with good understanding of Solid to continue. > > I'm don't know how to determinate if StorageAccess device is encrypted or not. I wanted to

D28855: put minimumkeepsize actually in the netpref KCM

2020-09-05 Thread Harald Sitter
sitter abandoned this revision. sitter added a comment. moved to https://invent.kde.org/frameworks/kio/-/merge_requests/123 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28855 To: sitter, ngraham, dfaure Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack,

Re: Extend metainfo.yaml files with License Information

2020-08-18 Thread Harald Sitter
On Mon, Aug 17, 2020 at 8:24 PM Andreas Cord-Landwehr wrote: > > Thanks! I will answer inline: > > On Montag, 17. August 2020 17:47:40 CEST Harald Sitter wrote: > [...] > > > **First question:** Shall we only list ONE or ALL licenses, same for the > > > license

Re: Extend metainfo.yaml files with License Information

2020-08-17 Thread Harald Sitter
On Mon, Aug 17, 2020 at 2:16 PM Andreas Cord-Landwehr wrote: > > Hi, I am currently looking into extending our metainfo.yaml files to provide > information about the outbound licenses of the artefacts that are provided by > a framework. Here a few examples: > > Attica: Provides libattica, which

D7563: Add privilegeExecution field to file protocol description

2020-08-10 Thread Harald Sitter
sitter added a comment. In D7563#676151 , @cblack wrote: > In D7563#674682 , @sitter wrote: > > > This really cannot land right now IMHO. Dolphin can actually deadlock itself because it uses way too

D7563: Add privilegeExecution field to file protocol description

2020-08-06 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > file_unix.cpp:1372 > +break; > +default: > +Q_UNREACHABLE(); I'd advise handling default cases. The compiler can no longer warn of unhandled enum values when default is used. Instead I'd convert the entire switch into a

Re: Policy on forward declarations for things from external libraries

2020-08-03 Thread Harald Sitter
On Fri, Jul 31, 2020 at 5:56 PM Vlad Zahorodnii wrote: > > Howdy, > > From time to time, I find myself in a situation where a code reviewer > suggests to replace #include with the corresponding class > forward declaration. Such discussions usually get us nowhere because > neither the code

Re: xml_mimetypes5 and kcoreaddons

2020-07-20 Thread Harald Sitter
On Sun, Jul 19, 2020 at 1:56 PM David Faure wrote: > > On mercredi 15 juillet 2020 12:24:34 CEST Harald Sitter wrote: > > On Wed, Jul 15, 2020 at 12:39 AM David Faure wrote: > > > On mardi 14 juillet 2020 19:35:41 CEST Albert Astals Cid wrote: > > > > El dimart

Re: xml_mimetypes5 and kcoreaddons

2020-07-15 Thread Harald Sitter
On Wed, Jul 15, 2020 at 12:39 AM David Faure wrote: > > On mardi 14 juillet 2020 19:35:41 CEST Albert Astals Cid wrote: > > El dimarts, 14 de juliol de 2020, a les 15:14:38 CEST, Jonathan Riddell va > escriure: > > > We're playing with translations in neon packages and looking at > > >

D7563: Add privilegeExecution field to file protocol description

2020-06-05 Thread Harald Sitter
sitter requested changes to this revision. sitter added a comment. This revision now requires changes to proceed. This really cannot land right now IMHO. Dolphin can actually deadlock itself because it uses way too much nested event looping and will be entirely unresponsive to mouse inputs

D29745: look for kded as runtime dep

2020-06-02 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R241:15869b83200f: look for kded as runtime dep (authored by sitter). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29745?vs=82839=83201 REVISION DETAIL

Re: Recent breakage in kwallet

2020-05-26 Thread Harald Sitter
here's my understanding of the problem: firstly, this is likely only a problem on debian-derived systems. and also only with blowfish debian has this patch [1] which on *actual* little endian systems (x86,arm64...) would run the conditional branches. the thing to note is that not only QBO is

D29381: Thumbnail text: use libmagic to detect encoding

2020-05-20 Thread Harald Sitter
sitter added a comment. Browsing the code it looks like it mmaps the file though? And when I add some strategic sleeping I can verify that file goes towards shared memory. Oh, I suppose the trouble is that load gets called each ::create? Simply wrap it in a cpp class and static scope it

D29381: Thumbnail text: use libmagic to detect encoding

2020-05-19 Thread Harald Sitter
sitter added a comment. LGTM. Seeing as I don't have much background knowledge I'm not comfortable accepting though. I guess if nobody comes up with better options by next week feel free to land. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29381 To: meven,

D29743: sftp: map sftp_open error to kio error

2020-05-15 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:07e44cb1b536: sftp: map sftp_open error to kio error (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29743?vs=82835=82903 REVISION DETAIL

D29745: look for kded as runtime dep

2020-05-14 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY kded is called over dbus to talk to the proxyscout, and also to track uidelegate

D29743: sftp: map sftp_open error to kio error

2020-05-14 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: feverfew. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY sftp gives out more relevant errors such as

D29634: sftp: break large writes into multiple requests

2020-05-14 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:1df6174834bb: sftp: break large writes into multiple requests (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29634?vs=82723=82834

D29526: Thumbnails: make thumbnail generation dpr-aware

2020-05-13 Thread Harald Sitter
sitter added a comment. You do seem to calculate the deviceWidth and height an awful lot, it makes reading a bit clunky. I'd much rather have the multiplication done once and then always use the var instead. In fact, perhaps it'd make sense to have createV3 feed the values into the

D29634: sftp: break large writes into multiple requests

2020-05-13 Thread Harald Sitter
sitter edited the test plan for this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29634 To: sitter, ngraham, meven Cc: meven, feverfew, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n,

D29634: sftp: break large writes into multiple requests

2020-05-13 Thread Harald Sitter
sitter updated this revision to Diff 82723. sitter added a comment. - rejigger write segmentation into new sftpWrite function used by both the put() and write() - fix length calculation - refine buf size comment REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D29634: sftp: break large writes into multiple requests

2020-05-12 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > meven wrote in kio_sftp.cpp:58 > Why not change it now to 32 * 1024 then ? > I guess you tested this value works at least with openssh. > > I guess the best solution would be to ask/figure out the server buffer size. > > What does gvfs, or other

D29634: sftp: break large writes into multiple requests

2020-05-11 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY servers have arbitrary limits that we should stay below. to ensure

D29461: Fix kio-extras build on Windows

2020-05-06 Thread Harald Sitter
sitter added a comment. Pid changes look fine, though perhaps we should just throw those two lines away? With Qt5 logging the pid is fairly pointless because one can simply set QT_MESSAGE_PATTERN to include the pid when necessary https://doc.qt.io/qt-5/qtglobal.html#qSetMessagePattern

D29381: Thumbnail text: use libmagic to detect encoding

2020-05-05 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > meven wrote in textcreator.cpp:38 > Without libmagic, it is current state basically UTF-8 with bom detection > otherwise local codec. > > I did not test exhaustive encodings so I wanted to let the door open for > users to not rely on libmagic. >

D29381: Thumbnail text: use libmagic to detect encoding

2020-05-04 Thread Harald Sitter
sitter added a comment. I have zero background knowledge here, but it really feels like there must be an existing solution to this problem other than libmagic. Like how does kate figure out the encoding of a text file. INLINE COMMENTS > Findlibmagic.cmake:1 > +# - Try to find libssh > +#

D29149: Fix kio-extras compilation with -DQT_NO_CAST_TO_ASCII

2020-04-24 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > dfaure wrote in CMakeLists.txt:60 > Isn't that what I did here? Now all of kio-extras gets that flag. > > And BTW everything built by kdesrc-build actually builds with this flag > (since I have it in my kdesrc-buildrc). But that doesn't allow

D29149: Fix kio-extras compilation with -DQT_NO_CAST_TO_ASCII

2020-04-24 Thread Harald Sitter
sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Sure, I was referring to the smb module, not even kio-extras as a whole. ^^ Anyway, diff looks reasonable. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL

D29149: Fix kio-extras compilation with -DQT_NO_CAST_TO_ASCII

2020-04-24 Thread Harald Sitter
sitter added a comment. Shouldn't we just make the entire thing QT_NO_CAST_TO_ASCII by default? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29149 To: dfaure, thiago, sitter Cc: kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, aprcela,

D29063: Fix testpackage-appstream: XDG_DATA_DIRS needs to be explicitly extended

2020-04-21 Thread Harald Sitter
sitter added a comment. Looks reasonable. @apol thoughts? REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D29063 To: kossebau, #frameworks, mart, apol, sitter, bcooksley Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D28909: smb: port to Result system to force serialization of error/finish condition

2020-04-20 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > dfaure wrote in kio_smb.h:96 > Whenever we port a 3rd slave to it ;-) Sure, if you think it's solid enough from an API POV. I was thinking that we should amend the slavebase API for KF6 in general. Instead of having error/finished/opened all

D6794: assert the testpackage appstream data validates

2020-04-19 Thread Harald Sitter
sitter added a comment. @bcooksley I would think the CI image needs to ship some general purpose schemas. install https://software.opensuse.org/package/gsettings-desktop-schemas I guess. If it's still not working right with that installed I can take a look at what's missing. The

D28909: smb: port to Result system to force serialization of error/finish condition

2020-04-17 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: dfaure. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY the Result system was originally introduced to the FTP slave and now

D28855: put minimumkeepsize actually in the netpref KCM

2020-04-15 Thread Harald Sitter
sitter added a comment. Coding style is actually wildly inconsistent in that file, so I've stuck to what similar other lines have. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28855 To: sitter, ngraham, dfaure Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack,

D28855: put minimumkeepsize actually in the netpref KCM

2020-04-15 Thread Harald Sitter
sitter added a comment. And didn't we have a better spinny box for byte units somewhere? Where the user can put `1 byte` or `1 kib` or `1 gib` and the box knows what to do? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28855 To: sitter, ngraham, dfaure Cc:

D28855: put minimumkeepsize actually in the netpref KCM

2020-04-15 Thread Harald Sitter
sitter added a comment. F8240046: Screenshot_20200415_164836.png I'm very open for better labels, it's a horrible concept to explain in a few words. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D28855 To: sitter, ngraham,

D28855: put minimumkeepsize actually in the netpref KCM

2020-04-15 Thread Harald Sitter
sitter updated this revision to Diff 80204. sitter added a comment. improve label a tad REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28855?vs=80203=80204 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28855 AFFECTED FILES

D28855: put minimumkeepsize actually in the netpref KCM

2020-04-15 Thread Harald Sitter
sitter created this revision. sitter added reviewers: ngraham, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY I didn't even know it was a thing! by the looks of it the setting only applies

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

2020-04-08 Thread Harald Sitter
sitter added a comment. Hm. So, this is a bit complicated I've noticed. Let's consider the following cases: - `desktop:` is not a local file but can set and read dir icons without penalty - `camera:` is not a local file AND `Class=:local` BUT (I think?) cannot set dir icons as it

D28679: [KPropertiesDialog] Disable changing dir icon on samba shares

2020-04-08 Thread Harald Sitter
sitter added a comment. Looks reasonable. Though... Shouldn't that rather be any protocol that isn't `file`? Or at least all that are remote? (assuming we have a way of telling which slaves are remote) If I open sftp it also shows no dir icons yet lets me set one. REPOSITORY R241 KIO

D28336: Drop klauncher usage from KCrash

2020-04-08 Thread Harald Sitter
sitter accepted this revision. sitter added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kcrash.cpp:627 > > void KCrash::startProcess(int argc, const char *argv[], bool waitAndExit) > { This seems to serve no purpose anymore. startProcessInternal could

D28463: do not install testengine

2020-04-06 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R242:6e39c1de5bb3: do not install testengine (authored by sitter). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28463?vs=78974=79464 REVISION

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

2020-04-06 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:daec307b59e9: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D27804: smb: add hack to support spaces in workgroup names

2020-04-06 Thread Harald Sitter
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R320:f40191a147c9: smb: add hack to support spaces in workgroup names (authored by sitter). CHANGED PRIOR TO COMMIT

D27902: smb: figure out the best host to use for the UDS_URL

2020-04-06 Thread Harald Sitter
sitter abandoned this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27902 To: sitter, ngraham, dfaure Cc: meven, kde-frameworks-devel, kfm-devel, azyx, nikolaik, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas, alexde, GB_2, Codezela,

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

2020-04-03 Thread Harald Sitter
sitter updated this revision to Diff 79234. sitter added a comment. chop instead of convoluted remove REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28513?vs=79220=79234 BRANCH smb-lazy-resolve REVISION DETAIL https://phabricator.kde.org/D28513

D27504: smb faster copy to local

2020-04-03 Thread Harald Sitter
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R320:46b5fb425c14: smb: fast copy (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D27504: smb faster copy to local

2020-04-03 Thread Harald Sitter
sitter edited the summary of this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To: sitter, ngraham, cfeck, #frameworks, #dolphin Cc: mmustac, meven, hallas, anthonyfieroni, asturmlechner, kde-frameworks-devel, kfm-devel, nikolaik, pberestov,

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

2020-04-03 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > kossebau wrote in kio_smb_browse.cpp:239 > `QString::remove()` operates on the object itself, no need to assign back to > host. > > Besides, why not use `QString::chop(wsdSuffix.size())` ? Mh. Good point indeed, I'll move to chop. Thanks!

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

2020-04-03 Thread Harald Sitter
sitter updated this revision to Diff 79220. sitter added a comment. reshuffle: instead of using .local directly use a fake .kio-disocvery-wsd suffix. look for that at listing time and redirect to name.local or name as appropriate this prevents dnssd results form incorrectly getting run

D28513: smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries

2020-04-03 Thread Harald Sitter
sitter retitled this revision from "smb: use prettyname.local for hostname of wsdiscoveries" to "smb: use prettyname.kio-discovery-wsd for hostname of wsdiscoveries". sitter edited the summary of this revision. REPOSITORY R320 KIO Extras BRANCH smb-lazy-resolve REVISION DETAIL

D28513: smb: use prettyname.local for hostname of wsdiscoveries

2020-04-03 Thread Harald Sitter
sitter added a comment. Stable was the plan, yes. I've thought of some complications with this approach though. Actually a combination of two 1. the .local match also applies to dnssd 2. all linux VMs I've checked wouldn't be able to resolve netbios names natively as the relevant

D28513: smb: use prettyname.local for hostname of wsdiscoveries

2020-04-02 Thread Harald Sitter
sitter added a comment. Competes with D27902 While this diff runs the risk of not being able to resolve 100% of the time (sans ip address fallback in listDir) it has the huge advantage that discovery isn't getting super slow when multiple wsd hosts are

D28513: smb: use prettyname.local for hostname of wsdiscoveries

2020-04-02 Thread Harald Sitter
sitter created this revision. sitter added reviewers: ngraham, meven. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY previously we simply used the ip address. this is fairly

D28488: [Fstab] Ensure uniqueness for all filesystem types

2020-04-02 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:131 > I got the impression you liked being lax. Guess only when the shoe is on the > other foot. I do like being lax! I literally gave you a ship it despite your comment being literally wrong. Picking on useless

D28488: [Fstab] Ensure uniqueness for all filesystem types

2020-04-02 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:131 > You let the old comment pass without any further remarks, but now you start > nitpicking? > > From the acessibility viewpoint of the mount, it is unique. The previous comment was factually correct, it never

D28488: [Fstab] Ensure uniqueness for all filesystem types

2020-04-02 Thread Harald Sitter
sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid BRANCH fix_comment REVISION DETAIL https://phabricator.kde.org/D28488 To: bruns, #frameworks, meven, broulik, sitter Cc: broulik, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28488: [Fstab] Ensure uniqueness for all filesystem types

2020-04-02 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:131 > The first mount is no longer visible, it is shadowed by the first one. You > can not read any files from it or write to it. You can not unmount it. The comment is still wrong. REPOSITORY R245 Solid

D28488: [Fstab] Ensure uniqueness for all filesystem types

2020-04-02 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > bruns wrote in fstabhandling.cpp:131 > Of course they are - you can just mount one fs at a path at any time. λ ajax ~ → sudo mount -t cifs //bear.local/foo /mnt -o user=me λ ajax ~ → sudo mount -t cifs //bear.local/foo /mnt -o

D28488: [Fstab] Ensure uniqueness for all filesystem types

2020-04-02 Thread Harald Sitter
sitter requested changes to this revision. sitter added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > fstabhandling.cpp:131 > +// for different users. Make sure it is unique by appending the > +// mountpoint (which is unique). > +return source +

D28476: Samba: Ensure to differenciate mounts sharing the same source

2020-04-01 Thread Harald Sitter
sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. You know, I may have noticed this when working on kinfocenter and then quickly forgotten about it again  Good stuff! REPOSITORY R245 Solid BRANCH master REVISION DETAIL

D28463: do not install testengine

2020-03-31 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: mart. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY by default users have to opt out of BUILD_TESTING meaning everyone would by default

D28129: Read the new message string after rather than before

2020-03-27 Thread Harald Sitter
sitter accepted this revision. sitter added a comment. Mind the comment about the +2 please. Other than that looks reasonable. INLINE COMMENTS > backtraceparsergdb.cpp:215 > +case BacktraceLine::Info: > +d->m_infoLines << line.toString().mid(KCRASH_INFO_MESSAGE.size() + >

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

2020-03-26 Thread Harald Sitter
sitter added a comment. In D28161#634951 , @ahmadsamir wrote: > > Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client > > That's confusing; but OK, I'll

D28161: [kio-extras] Port some QRegExp usage to QRegularExpression

2020-03-26 Thread Harald Sitter
sitter added a comment. Looks good to me, not that this means much with regular expressions. The lack of tests on this stuff makes me sad :(( Please don't touch kdsoap-ws-discovery-client though. It's not maintained here -> https://gitlab.com/caspermeijn/kdsoap-ws-discovery-client

D27902: smb: figure out the best host to use for the UDS_URL

2020-03-25 Thread Harald Sitter
sitter added a comment. I've actually had a better idea! Well kinda and it may be trickier to do. We could move the resolution dance to actual resolution time so it stops having impact on discovery. i.e. we just always use `"smb://" + m_prettyName + ".local"` as UDS_URL for discovery.

D27873: sftp: do not show creation time when we do not know it

2020-03-25 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:b13449a13b00: sftp: do not show creation time when we do not know it (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27873?vs=78352=78444

D27872: sftp: fix partial transfer resuming when copying to local

2020-03-25 Thread Harald Sitter
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit R320:8a04e1009130: sftp: fix partial transfer resuming when copying to local (authored by sitter). CHANGED PRIOR TO

D27873: sftp: do not show creation time when we do not know it

2020-03-24 Thread Harald Sitter
sitter updated this revision to Diff 78352. sitter added a comment. . REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27873?vs=77080=78352 BRANCH sftp-ctime REVISION DETAIL https://phabricator.kde.org/D27873 AFFECTED FILES sftp/kio_sftp.cpp To:

D27504: smb faster copy to local

2020-03-23 Thread Harald Sitter
sitter added a comment. Any opinions on landing this for 20.04 still? It is technically a bugfix. It is also practically a whole lot of risky code, making me rather uneasy about putting it in past beta. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27504 To:

D28129: Read the new message string after rather than before

2020-03-23 Thread Harald Sitter
sitter added a comment. Mh. Not quite what I had in mind but I suppose it makes sense this way. I think we need a test case for the highlighter though :| It totally blows up in my face when I trace a running dolphin because toskip isn't quite right. INLINE COMMENTS >

D28188: breeze-icons autotests: skip symlinks in the builddir

2020-03-22 Thread Harald Sitter
sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D28188 To: dfaure, sitter, bshah, lbeltrame Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27927: Use more flexible shebang

2020-03-19 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R266:485e7be3b7ef: Use more flexible shebang (authored by tcberner, committed by sitter). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27927?vs=77198=78011

D28129: Read the new message string after rather than before

2020-03-19 Thread Harald Sitter
sitter added a comment. Quick recap from what we talked about on telegram: putting the print after the bt is most definitely going to throw off the backtrace parsing logic, so doing it this way would require extensive changes there, which is a dangerous place to make extensive changes. Or

D18878: Force NT1 protocol when listing smb:// network [work in progress]

2020-03-19 Thread Harald Sitter
sitter removed a reviewer: sitter. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18878 To: mikhailnov, #dolphin, #frameworks, broulik Cc: sitter, ngraham, acrouthamel, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, fbampaloukas,

D25984: Load translations

2020-03-19 Thread Harald Sitter
sitter removed a reviewer: sitter. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid Cc: mart, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra

D27871: sftp: fix seekPos + file resuming when part file is of size 11

2020-03-19 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:d8cf85ec2f0f: sftp: fix seekPos + file resuming when part file is of size 11 (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D28078: guard against duplicated service discoveries

2020-03-19 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:ba96d3b93a96: smb: guard against duplicated service discoveries (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28078?vs=77737=77990

D28123: move setErrorMessage definition out of the linux ifdef

2020-03-18 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R285:91129f291efd: move setErrorMessage definition out of the linux ifdef (authored by sitter). REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28123?vs=77910=77913

D28123: move setErrorMessage definition out of the linux ifdef

2020-03-18 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY rather obvious in retrospect. the definition is OS-independent, the declaration

D28121: Use libcanberra as primary means of previewing the sound

2020-03-18 Thread Harald Sitter
sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Your `if(` style is now inconsistent with the `endif(`. Code LGTM REPOSITORY R305 KNotifyConfig REVISION DETAIL https://phabricator.kde.org/D28121 To: broulik, #frameworks, sitter

D28095: Bump required version of KF5 to 5.69.0

2020-03-17 Thread Harald Sitter
sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R871 DrKonqi BRANCH l-kcrash (branched from master) REVISION DETAIL https://phabricator.kde.org/D28095 To: ahmadsamir, #frameworks, dfaure, apol, sitter Cc: kde-frameworks-devel, plasma-devel,

D28078: guard against duplicated service discoveries

2020-03-16 Thread Harald Sitter
sitter added a comment. FTR: this could technically still dupe with smbc native NT1 listing, except smbc would list workgroups while we list services, so this should generally not be duplicative information. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D28078

D28078: guard against duplicated service discoveries

2020-03-16 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY if both dnssd and wsdiscovery have the same server on offer we'd

D27804: smb: add hack to support spaces in workgroup names

2020-03-16 Thread Harald Sitter
sitter added a comment. Yep. I'm 100% certain of this. The library in fact has no API that returns a complete URL or anything near a complete URL. It's using dirent-inspired API to let us iterate/stat paths and only ever returns paths relative to whatever input it got, from those paths we

D27520: add readdirplus2 support for samba>=4.12

2020-03-16 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:ec40cd6ef3f4: add readdirplus2 support for samba=4.12 (authored by sitter). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D27520?vs=76048=77717#toc REPOSITORY R320 KIO Extras CHANGES SINCE

D27872: sftp: fix partial transfer resuming when copying to local

2020-03-16 Thread Harald Sitter
sitter added a comment. ping REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27872 To: sitter, ngraham, feverfew, bruns Cc: bruns, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela,

D27873: sftp: do not show creation time when we do not know it

2020-03-16 Thread Harald Sitter
sitter added a comment. ping REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27873 To: sitter, ngraham, bruns Cc: bruns, kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew,

D27902: smb: figure out the best host to use for the UDS_URL

2020-03-16 Thread Harald Sitter
sitter added a comment. ping REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D27902 To: sitter, ngraham, dfaure Cc: kde-frameworks-devel, kfm-devel, pberestov, iasensio, fprice, LeGast00n, cblack, MrPepe, fbampaloukas, alexde, GB_2, Codezela, feverfew, meven,

D27804: smb: add hack to support spaces in workgroup names

2020-03-16 Thread Harald Sitter
sitter added a comment. In D27804#621988 , @sitter wrote: > In D27804#621970 , @thiago wrote: > > > Still want to see that round-trip. > > > But why? Converting an smbcUrl to a QUrl would

D28014: smb: do not double finish

2020-03-16 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes. Closed by commit R320:8252861157a2: smb: do not double finish (authored by sitter). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28014?vs=77502=77714 REVISION DETAIL

D28061: Reduce unneeded dependencies

2020-03-16 Thread Harald Sitter
sitter accepted this revision. REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D28061 To: apol, #frameworks, davidedmundson, sitter Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D21466: Recommend rebooting after installing Samba

2020-03-13 Thread Harald Sitter
sitter edited the summary of this revision. REPOSITORY R432 File Sharing (Samba) integration BRANCH recommend-rebooting (branched from master) REVISION DETAIL https://phabricator.kde.org/D21466 To: ngraham, #vdg, #frameworks, #dolphin, apol, sitter Cc: anthonyfieroni, sitter, bruns

D27986: Allow providing an error message from the application

2020-03-13 Thread Harald Sitter
sitter added a comment. Looks alright to me now.  REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D27986 To: apol, #frameworks, sitter, dfaure Cc: dfaure, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27986: Allow providing an error message from the application

2020-03-13 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > kcrash.cpp:107 > + > +static char *s_kcrashErrorMessage; > Q_GLOBAL_STATIC(KCrash::CoreConfig, s_coreConfig) Still needs to be set to nullptr. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D27986 To: apol, #frameworks,

D27986: Allow providing an error message from the application

2020-03-13 Thread Harald Sitter
sitter added inline comments. INLINE COMMENTS > kcrash.cpp:107 > + > +static char* s_kcrashErrorMessage; > Q_GLOBAL_STATIC(KCrash::CoreConfig, s_coreConfig) - on wrong side of space needs defining to nullptr > kcrash.cpp:994 > +{ > +s_kcrashErrorMessage =

D28014: smb: do not double finish

2020-03-12 Thread Harald Sitter
sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY finish() must not be called twice yet previously the case branches

D21466: Recommend rebooting after installing Samba

2020-03-12 Thread Harald Sitter
sitter accepted this revision. This revision is now accepted and ready to land. REPOSITORY R432 File Sharing (Samba) integration BRANCH recommend-rebooting (branched from master) REVISION DETAIL https://phabricator.kde.org/D21466 To: ngraham, #vdg, #frameworks, #dolphin, apol, sitter Cc:

  1   2   3   4   5   6   7   8   9   10   >