D7884: - Increase size of trailing mark

This revision was automatically updated to reflect the committed changes. Closed by commit R39:92ec63dd1b07: - Increase size of trailing mark (authored by helio). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7884?vs=20330=20903 REVISION DETAIL

D7884: - Increase size of trailing mark

helio added a comment. In https://phabricator.kde.org/D7884#154232, @sars wrote: > I'm OK with an option for this. The only problem, with the option in the screen-shot, is that it could be interpreted as also effecting the tabulator mark. I did not changed the current behavior,

D7884: - Increase size of trailing mark

helio added a comment. Ping ? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc: cullmann, anthonyfieroni, dhaumann, sars, #frameworks

D7884: - Increase size of trailing mark

helio updated this revision to Diff 20330. helio added a comment. Rebase on current master REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7884?vs=19888=20330 BRANCH big_trailing REVISION DETAIL https://phabricator.kde.org/D7884 AFFECTED FILES

D7884: - Increase size of trailing mark

helio added a comment. In https://phabricator.kde.org/D7884#148489, @cullmann wrote: > I would rather go with the "make the markers much larger but less contrast" solution than a setting for their size. > Perhaps we really just need to look at how other editors do that. >

D7884: - Increase size of trailing mark

helio added a comment. Fixed requests REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc: cullmann, anthonyfieroni, dhaumann, sars, #frameworks

D7884: - Increase size of trailing mark

helio updated this revision to Diff 19888. helio marked 3 inline comments as done. helio added a comment. - Moved calc logic to updateMarkerSize - Fix identation - Make value properly float - Update view when apply pressed REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D7884: - Increase size of trailing mark

helio added a comment. Is not that simple. Change only the color is fine, but then the effect is almost imperceptible, Right now from home i'm using a 25' 2560x1440 resolution with fonts in size 10. Is a regular monitor, not the most expensive. Even changing the color a single pixel is

D7884: - Increase size of trailing mark

helio added a comment. F3921383: configsize.png REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc: sars, #frameworks, cullmann, dhaumann

D7884: - Increase size of trailing mark

helio updated this revision to Diff 19786. helio added a comment. - Make size configurable keeping the original default REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7884?vs=19686=19786 BRANCH big_trailing REVISION DETAIL

D7884: - Increase size of trailing mark

helio added a comment. Result of change using kdevelop F3918646: screenshot.png REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc: #frameworks, cullmann, sars, dhaumann

D7884: - Increase size of trailing mark

helio updated this revision to Diff 19686. helio added a comment. - Using same code guideline as previous entry REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7884?vs=19685=19686 BRANCH big_trailing REVISION DETAIL

D7884: - Increase size of trailing mark

helio added reviewers: mwolff, kfunk. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D7884 To: helio, mwolff, kfunk Cc: #frameworks, cullmann, sars, dhaumann

D7884: - Increase size of trailing mark

helio created this revision. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY On HiDPI screens and/or usage of small fonts current size of marker is so small making it almost invisible, even with a saturated color

Review Request 120421: - Update cmake files to match official polkit package, then enabling to use different include direcories

--- - Update cmake files to match official polkit package, then enabling to use different include direcories Diffs - src/ConfigureChecks.cmake 70b9f7d22c7b30f92868d36d07b12a3a3a650655 Diff: https://git.reviewboard.kde.org/r/120421/diff/ Testing --- Thanks, Helio Castro

Re: Review Request 120421: - Update cmake files to match official polkit package, then enabling to use different include direcories

--- On Sept. 29, 2014, 12:59 p.m., Helio Castro wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120421

Re: Review Request 120421: - Update cmake files to match official polkit package, then enabling to use different include direcories

On Sept. 29, 2014, 1:36 p.m., Aleix Pol Gonzalez wrote: Shouldn't include directories be dragged by polkit-qt? Maybe we should fix polkit-qt cmake files to do so? Helio Castro wrote: Nope, this is not automatic and we're talking about polkit-qt5-1. If you look on the cmake file

Re: Review Request 120421: - Update cmake files to match official polkit package, then enabling to use different include direcories

: https://git.reviewboard.kde.org/r/120421/diff/ Testing --- Thanks, Helio Castro ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel