Re: Splitting KGlobalAccel interface and runtime

Nevermind. rebuilt and everything seems to be working for now. On Mon, Mar 6, 2023 at 10:02 AM Jeremy Whiting wrote: > Was something decided about this? I ask because I went and built > frameworks kf6 over the weekend with kdesrc-build into /usr/local/ with my > existing arch package

Re: Splitting KGlobalAccel interface and runtime

Was something decided about this? I ask because I went and built frameworks kf6 over the weekend with kdesrc-build into /usr/local/ with my existing arch packages in /usr, etc. and afterwards the kf5 version of yakuake can no longer receive keyboard shortcuts (to hide/show, etc.) It's entirely

D15481: Fix 'Impossible to use knsrc file for uploads from non standard location'

whiting accepted this revision. whiting added a comment. This revision is now accepted and ready to land. Looks good to me. Thanks for doing that fix. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D15481 To: habacker, whiting Cc: whiting,

D7968: Forward QComboBox signals instead of QComboBox lineedit signals

whiting added a comment. Hey all, this change breaks Kompare https://bugs.kde.org/show_bug.cgi?id=390024 which watches a KUrlRequester's textChanged signal to update a button's enabled state. We are not seeing the textChanged signal on the KUrlRequester anymore when programatically setting

Re: Review Request 128814: Add Qt5Network as a public dependency.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128814/#review98825 --- Ship it! Ship It! - Jeremy Whiting On Sept. 1, 2016

Re: Review Request 128740: uncompress archives in subfolders

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128740/#review98570 --- Ship it! Ship It! - Jeremy Whiting On Aug. 23, 2016, 8

Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

marked as submitted. Review request for KDE Frameworks, David Faure and Richard Moore. Changes --- Submitted with commit 9746ff5553db0f3e869b0a9970e1304554e6f7fe by Jeremy Whiting to branch master. Repository: knewstuff Description --- When an application uses TargetDir

Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

n location. Diffs (updated) - src/core/installation.cpp a027418 Diff: https://git.reviewboard.kde.org/r/128219/diff/ Testing --- No testing done yet, will write a unit test of some kind if this is the right direction. Thanks, Jeremy Whiting

Re: Review Request 128451: KNewFileMenu: fix creating symlinks with a relative target.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128451/#review97731 --- Ship it! Ship It! - Jeremy Whiting On July 21, 2016, 3

Re: Review Request 128494: KPropertiesDialog: simplify button box usage, fix behavior on Esc

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128494/#review97728 --- Ship it! Ship It! - Jeremy Whiting On July 21, 2016, 3

Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

which would create > > problems. > > - "//" > > - "./" > > - "../etc" > > - and so on > > > > But this is a setting written by the app developer, not by the person > > uploading knewstuff data, so we can ass

Re: Review Request 128317: Make the download dialog fail when *all* categories are missing, not just one

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128317/#review96956 --- Ship it! Ship It! - Jeremy Whiting On June 29, 2016, 5

Re: Review Request 128219: No longer allow installing to generic data folder because of security hole.

t to tweak the .knsrc files by hand to introduce a security vulnerability. Though if they wanted to do that there are much easier ways to do it. - Jeremy --- This is an automatically generated e-mail. To reply, visit: htt

Review Request 128219: No longer allow installing to generic data folder because of security hole.

--- No testing done yet, will write a unit test of some kind if this is the right direction. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 128057: Don't initialize KNS3::DownloadManager with the wrong categories

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128057/#review96108 --- Ship it! Ship It! - Jeremy Whiting On May 30, 2016, 9

Re: Review Request 127997: Extend KNS3::Entry public API

. If the former, it looks good to me ship it. - Jeremy Whiting On May 24, 2016, 5:25 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 127900: Fix redirection of absolut Urls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127900/#review95440 --- Ship it! Ship It! - Jeremy Whiting On May 12, 2016, 11

Re: Review Request 127887: Improve usage of Qt APIs

. - Jeremy Whiting On May 11, 2016, 5:01 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126948: Simplify attica plugin look-up and initialization

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126948/#review91908 --- Ship it! Ship It! - Jeremy Whiting On Feb. 1, 2016, 12

Re: Review Request 126039: When configfile is loaded from resource, do not issue file not found error

. - Jeremy Whiting On Nov. 12, 2015, 4:15 p.m., Andrew McCann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: KNotifications filters

Yeah, that makes sense. Ok will do. On Sun, Dec 6, 2015 at 3:37 AM, David Faure <fa...@kde.org> wrote: > On Thursday 24 September 2015 20:35:24 Jeremy Whiting wrote: >> If so I guess the logical place for it would be a TTS group in >> kdeglobals, does that make sens

Re: Maintenance of api.kde.org

Alex, Last time I checked api.kde.org was generated by scripts in the websites/quality-kde-org git repository. It includes instructions for installing it locally, though the instructions are a bit outdated. I think perl's setup scripts have changed since it was written since I needed to tweak the

Re: Review Request 125884: Set default value for WheelScrollLines

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125884/#review87824 --- Ship it! Ship It! - Jeremy Whiting On Oct. 30, 2015, 3

Re: Review Request 125767: Make KConfigWidgets self contained, bundle the one global file in a resource

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125767/#review87363 --- Ship it! Ship It! - Jeremy Whiting On Oct. 23, 2015, 12

Re: [KDE/Mac] Question about goal of Windows/Mac frameworks

Yeah, if we go that direction on mac it would be fine for bundled Qt, but not for shared Qt. It would make all applications that use qt5-mac or qt5-kde or whatnot use linuxy paths or not. It's a runtime switch, so not very helpful if you've installed stuff to linuxy paths and then let the user

Re: Review Request 125656: Drop empty files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125656/#review87199 --- Ship it! Ship It! - Jeremy Whiting On Oct. 21, 2015, 4:29

Re: Question about goal of Windows/Mac frameworks

Christoph, I'm not trying to argue against having applications come in complete bundles at all. That is a worthy goal also actually, it's just not the direction I was headed in. You've made a lot more progress in this regard than I had though tbh. I see the kdewin installer as something that went

Re: Question about goal of Windows/Mac frameworks

Christoph. I have had similar goals for a while, but haven't reached the point that I was having much success yet in that regard. One thing to keep in mind when developing installers, Qt Installer Framework. I did a quick test with attica on OS X I can put on reviewboard to see what you think. I

Re: Policy for Dependencies

I'd like to weigh in a bit here too. I agree with Boud and Christoph, most users (developers of applications) of KF5 that aren't KDE community members will be building the frameworks themselves. At my last job we built Qt ourselves on all the platforms we targetted and shipped shared libraries

Review Request 125521: Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed from GPL 2+ to LGPL 2+ with author's permission.

/kdropwidgetdecorator.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/125521/diff/ Testing --- It builds, the headers I expect are in the right places, etc. I just noticed I'm not exporting the class though, will fix that and reupload. Thanks, Jeremy Whiting

Re: Review Request 125521: Added KDropWidgetDecorator copied from DropWidget in kile sources. Relicensed from GPL 2+ to LGPL 2+ with author's permission.

though, will fix that and reupload. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: KTabWidget vs QTabWidget

Thanks, First patch here: https://git.reviewboard.kde.org/r/125521/. After that I'll try using it in Kile and Okular, see how that goes. On Thu, Sep 24, 2015 at 11:47 PM, Michel Ludwig <michel.lud...@gmail.com> wrote: > > On 09/25/2015 01:57 AM, Jeremy Whiting wrote: >> >

Re: [KDE/Mac] [OS X] adding a link module to all KF5 targets

That does sound like a bit more interesting question. Browsing through http://lxr.kde.org/ident?_i=QStandardPaths&_remember=1 (quite a long list...) a couple of things come to mind. First anything that's using QStandardPaths isn't necessarily using any frameworks at all. Looking at

KNotifications filters

Hey all, I've discussed this a bit with Eike previously, but thought I'd try a wider audience to get some more ideas. When we used to have kttsd/jovie it had the concept of filters that it would use for different applications speech to normalize what gets sent to the synthesizer. In this way

Re: KTabWidget vs QTabWidget

Toscano <luigi.tosc...@tiscali.it> wrote: > Jeremy Whiting ha scritto: >> In looking at what is using KTabWidget it seems there's a drop in >> replacement for what we are doing in >> http://lxr.kde.org/source/extragear/office/kile/src/kileviewmanager.h >> in Dro

Re: [KDE/Mac] [OS X] adding a link module to all KF5 targets

Rene, Back to your original question I don't think there is such a place, besides patching QtCore itself. Many of the frameworks and applications use KI18n, but some don't I don't think there's a common location that every application linking against KF5 libraries uses. BR, Jeremy On Wed, Sep

Re: KTabWidget vs QTabWidget

and use it where old code was using KTabWidget? BR, Jeremy On Tue, Sep 22, 2015 at 12:47 AM, David Faure <fa...@kde.org> wrote: > On Monday 21 September 2015 20:16:01 Jeremy Whiting wrote: >> David, >> >> I've been considering what you mean. I think I understand, but wanted

Re: KTabWidget vs QTabWidget

to in KDELibs4 times. BR, Jeremy On Sat, Sep 19, 2015 at 8:49 AM, David Faure <fa...@kde.org> wrote: > On Friday 18 September 2015 18:46:24 Jeremy Whiting wrote: >> Hey all, >> >> In looking into fixing the remaining issues in Okular's frameworks >> branch I realized t

KTabWidget vs QTabWidget

Hey all, In looking into fixing the remaining issues in Okular's frameworks branch I realized that in part of the effort to port it away from KDELibs4Support it got some functionality removed. It was ported from KTabWidget to QTabWidget but QTabWidget doesn't seem to support drag and drop the way

Re: ksycoca and kbuildsycoca, the next step

That sounds like a good solution to all the problems you presented initially indeed. Nice work. On Sun, Sep 6, 2015 at 3:43 PM, David Faure wrote: > On Sunday 06 September 2015 13:52:37 David Faure wrote: >> >> Any idea on how to avoid cache-rebuild ping pong? >> >> I can only

Re: Review Request 124872: Default to Breeze colors

On Aug. 24, 2015, 12:13 a.m., Martin Gräßlin wrote: I must say I'm rather shocked at how this is implemented. Would it be possible to move the defaults into our QPT plugin, so that these defaults are only applied if running on a platform with our plugin, otherwise it picks Qt

Re: Review Request 124872: Default to Breeze colors

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124872/#review84166 --- Ship it! Ship It! - Jeremy Whiting On Aug. 21, 2015, 3:35

Re: knotifications tier

It should be auto generated every evening. The code that generates it is in kde:websites/quality-kde-org git repo. I spent a bit of time looking into how it all works for a gardening project (that I never did blog about results, mostly because I didn't make any final conclusions). I set up a local

Re: Notes to developers: what KAboutData::setApplicationData() is

Jaroslaw, On Thu, Jun 18, 2015 at 3:20 AM, Jaroslaw Staniek stan...@kde.org wrote: Hi If you look at apps ported to KF5, KAboutData::setApplicationData() is used but there are also redundant lines in main(), at least these: app.setApplicationName(aboutData.componentName());

Re: Review Request 123692: autotests: Use QTEST_GUILESS_MAIN

fails. - Jeremy Whiting On May 8, 2015, 1:15 p.m., Heiko Becker wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123692

Re: Proposal: move KWalletManager inside KWallet framework

Then do like the rest of the projects do and branch 14.04 if that hasn't happened already... No? On Tue, May 26, 2015 at 3:56 PM, Valentin Rusu k...@rusu.info wrote: * Albert Astals Cid aa...@kde.org [2015-05-26 23:52:18 +0200]: El Dimarts, 26 de maig de 2015, a les 23:31:38, Valentin Rusu va

Re: Review Request 123794: Implement find previous in KTextEdit.

, then unswitch directions. Looks good. - Jeremy Whiting On May 14, 2015, 3:59 p.m., David Faure wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123794

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

: https://git.reviewboard.kde.org/r/123742/#review80299 --- On May 13, 2015, 7 a.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

and Jeremy Whiting. Changes --- Reordered lines as per Kevin's suggestion. I agree this looks a bit better. Repository: knewstuff Description --- Make ECM missing message explain a) what ECM is, and b) where to find it. Diffs (updated) - CMakeLists.txt

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

On May 13, 2015, 7:10 a.m., Aleix Pol Gonzalez wrote: CMakeLists.txt, line 8 https://git.reviewboard.kde.org/r/123742/diff/3/?file=368712#file368712line8 I insist, feature_sumary goes at the bottom. (and is already there) Is it needed to have it twice? Jeremy Whiting wrote

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

marked as submitted. Review request for KDE Frameworks and Jeremy Whiting. Changes --- Submitted with commit 01c3f36cf657e0e7e68631e14f884de9a3b3ebcd by Jeremy Whiting to branch master. Repository: knewstuff Description --- Make ECM missing message explain a) what ECM is, and b

Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123742/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

and Jeremy Whiting. Repository: knewstuff Description (updated) --- Make ECM missing message explain a) what ECM is, and b) where to find it. Diffs (updated) - CMakeLists.txt cb23ccb8a9b0421a554b41234c3d9ced3965d378 Diff: https://git.reviewboard.kde.org/r/123742/diff/ Testing

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

, visit: https://git.reviewboard.kde.org/r/123742/#review80270 --- On May 12, 2015, 6:28 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit

Re: Review Request 123742: knewstuff: Add verbose ecm message when ECM isn't found.

--- On May 12, 2015, 3:19 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123742

kbuildsycoca5 crashing

Hey all, Somehow kbuildsycoca5 is crashing here lately. I nuked my whole kde prefix (/usr/local) and rebuilt with packaged qt from my distro (arch). But kbuildsycoca5 is crashing every time I run it with some issue in QByteArray. Has anyone seen this lately/before or know how I can get past it?

Re: kbuildsycoca5 crashing

It sure isn't. I've also tried nuking ~/.cache/ksycoca5* and such. Same result. ~/.cache is owned by me and has decent permissions also. On Sun, May 10, 2015 at 6:21 AM, Bhushan Shah bhus...@gmail.com wrote: On Sun, May 10, 2015 at 5:43 PM, Jeremy Whiting jpwhit...@kde.org wrote: Somehow

Re: kbuildsycoca5 crashing

, Jeremy On Sun, May 10, 2015 at 7:49 AM, Jeremy Whiting jpwhit...@kde.org wrote: Yep, it's Qt5. After rebuilding everything trying to log into a plasma session I get startkde: could not sync environment to dbus in .xsession-errors, not much before that besides a bad dbus call. Seems very

Re: kbuildsycoca5 crashing

10, 2015 at 8:45 AM, David Faure fa...@kde.org wrote: On Sunday 10 May 2015 08:24:48 Jeremy Whiting wrote: Rebuilt kservice (and nuked my build folder and /usr/local just to be doubly sure.) kbuildsycoca5 still crashes with this same backtrace, no idea why. Could it be a bug in QtCore? Arch

Re: kbuildsycoca5 crashing

in particular I should check? On Sun, May 10, 2015 at 8:45 AM, David Faure fa...@kde.org wrote: On Sunday 10 May 2015 08:24:48 Jeremy Whiting wrote: Rebuilt kservice (and nuked my build folder and /usr/local just to be doubly sure.) kbuildsycoca5 still crashes with this same backtrace, no idea why

Re: kbuildsycoca5 crashing

Yep, it's Qt5. After rebuilding everything trying to log into a plasma session I get startkde: could not sync environment to dbus in .xsession-errors, not much before that besides a bad dbus call. Seems very similar to https://bugzilla.redhat.com/show_bug.cgi?id=1191171 I've never thought

Re: kbuildsycoca5 crashing

, 2015 at 8:04 AM, David Faure fa...@kde.org wrote: On Sunday 10 May 2015 07:49:48 Jeremy Whiting wrote: ==2883== Address 0x is not stack'd, malloc'd or (recently) free'd This must be a miscompilation, I see no other reason for the refcount of a QByteArray to be at address 0x

Re: kbuildsycoca5 crashing

tuesday from within a plasma 5 session instead of this fallback gnome session :) (and have konversation running again also...) thanks, Jeremy On Sun, May 10, 2015 at 9:46 AM, Albert Astals Cid aa...@kde.org wrote: El Diumenge, 10 de maig de 2015, a les 08:57:28, Jeremy Whiting va escriure: Also

Re: kbuildsycoca5 crashing

\o/ KService built with a downgraded (4.9.1) g++ works fine. Sorry for the noise. Should be able to detect this sort of problem quickly in the future though. I'll stick with non testing arch for the time being. On Sun, May 10, 2015 at 10:07 AM, Jeremy Whiting jpwhit...@kde.org wrote: I only

Re: Versioning of Frameworks

Christian, David isn't the only one with these thoughts. I agree with everything he said, and was thinking about the dependency zoo also, but couldn't form the words until I read what he wrote. That's exactly what I was thinking. It would be like the old rpm dependency hell from early linux days

Re: Review Request 123421: [KNewStuff] Use KDE_INSTALL_DATADIR_KF5 instead of DATA_INSTALL_DIR for future co-installability

) so I'll let him weigh in. It may require the users of KMoreTools to update their code I believe. - Jeremy Whiting On April 18, 2015, 1:45 p.m., Hrvoje Senjan wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123335/#review79085 --- Ship it! Ship It! - Jeremy Whiting On April 12, 2015, 3

Re: Review Request 122910: Introduce KMoreTools

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122910/#review78995 --- Ship it! Ship It! - Jeremy Whiting On April 15, 2015, 2

Re: Review Request 122910: Introduce KMoreTools

On April 15, 2015, 2:39 p.m., Jeremy Whiting wrote: Ship It! Gregor Mi wrote: As KMoreTools is going to be part of KNewStuff it should be using KNEWSTUFF_EXPORT not KSERVICE_EXPORT. The install dir now looks like this: http://wstaw.org/m/2015/04/15/plasma-desktopVd2099

Re: Review Request 122910: Introduce KMoreTools

be using KNEWSTUFF_EXPORT not KSERVICE_EXPORT. I'd also prefer the classes to be separated into their own header files, but that's a style thing, up to you. - Jeremy Whiting On April 12, 2015, 5:54 a.m., Gregor Mi wrote

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

most dialogs working after Lukas' fix, but the one launched from chromium via kdialog still hung after that. This should fix that (I'll test it later today) - Jeremy Whiting On April 12, 2015, 3:20 a.m., David Rosca wrote

Re: Review Request 123335: Fix native file dialogs from widgets QFileDialog

On April 12, 2015, 10:43 a.m., Jeremy Whiting wrote: Looks good to me. The explanation makes sense also. I did see most dialogs working after Lukas' fix, but the one launched from chromium via kdialog still hung after that. This should fix that (I'll test it later today) Yep

Re: Jenkins CI help for compile failures!

kspeech is deprecated, we need to remove it's use in knights looks like. It's interface file never got released with kf5. On Thu, Apr 9, 2015 at 12:29 PM, Scarlett Clark sgcl...@kubuntu.org wrote: KF5 knights fails to compile with: 23:47:49 make[2]: *** No rule to make target

Re: Review Request 123075: do not require X11 on Mac OS X

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123075/#review3 --- Ship it! Ship It! - Jeremy Whiting On March 19, 2015, 4

Fwd: frameworkintegration QFileDialog bug

Adding frameworks list. -- Forwarded message -- From: Jeremy Whiting jpwhit...@kde.org Date: Mon, Mar 16, 2015 at 8:57 PM Subject: frameworkintegration QFileDialog bug To: kdelibs kde-core-de...@kde.org Hey all, We have a strange bug in frameworkintegration https://bugs.kde.org

Re: What's the point of tiers if we bend the definition of them?

+1 On Mon, Mar 16, 2015 at 4:16 PM, Albert Astals Cid aa...@kde.org wrote: We have KPackage depending on kdoctools but since it's optional we pretend it's not a real dependency and call KPackage tier2 What's in it for us other than lying to ourselves? What's so bad about KPackage being tier

Re: Review Request 122918: revert 2ee76f0 to fix QtQuickControls

On March 15, 2015, 2:21 a.m., Frederik Gladhorn wrote: Without testing anything, I think that this will break QWidget's file dialog when set to modal. Iirc this breaks for example the open dialogs in qt creator. Yeah, that's the wrong approach, though I'm not sure what the right one is

Re: Review Request 122953: Let KNewStuff be useable w/o searching for private deps

to build with knewstuff and kio and karchive aren't present, it wont run properly. Is this to make stuff that uses knewstuff build when the dependencies are there, but their headers are missing or something? - Jeremy Whiting On March 14, 2015, 1:06 p.m., Hrvoje Senjan wrote

Re: Review Request 122953: Let KNewStuff be useable w/o searching for private deps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122953/#review77476 --- Ship it! Ship It! - Jeremy Whiting On March 14, 2015, 1

Re: Review Request 122955: Let KNotifyConfig be useable w/o searching for private deps

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122955/#review77478 --- Ship it! Ship It! - Jeremy Whiting On March 14, 2015, 1

Re: Review Request 122751: Let ecm_configure_package_config_file manage path variables.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122751/#review76758 --- Ship it! Ship It! - Jeremy Whiting On Feb. 28, 2015, 3:23

Re: Review Request 120649: Encode the URIs which end up in DTD files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120649/#review76781 --- Ship it! Ship It! - Jeremy Whiting On Oct. 19, 2014, 6:13

Re: Review Request 120648: Encode the URIs which end up in DTD files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review76782 --- Ship it! Ship It! - Jeremy Whiting On Oct. 19, 2014, 6:12

Re: Review Request 122555: knotifications: Add optional dependency on Qt5TextToSpeech for speech notifications.

--- On Feb. 12, 2015, 8:11 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122555

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

/122554/#review75983 --- On Feb. 12, 2015, 8:06 p.m., Jeremy Whiting wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122554

Re: Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

the changes aren't taking effect imediately yet. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 122555: knotifications: Add optional dependency on Qt5TextToSpeech for speech notifications.

isn't refreshing/reloading the config when it is changed. Otherwise this works fine when QtSpeech is available. QtSpeech is still in development, so this change is added as an optional dependency. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing

Review Request 122555: knotifications: Add optional dependency on Qt5TextToSpeech for speech notifications.

this change is added as an optional dependency. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 122554: knotifyconfig: Add optional dependency on QtSpeech to reenable speaking notifications.

). Similarly, after disabling this notification, messages are still spoken until restarting the application. I checked and the konversation.notifyrc file is getting updated, but for some reason the changes aren't taking effect imediately yet. Thanks, Jeremy Whiting

Re: OSX/CI: kde-baseapps fails to build on branch frameworks

2015, at 23:17 , Jeremy Whiting jpwhit...@kde.org wrote: Exactly, whoever added that code either needs to find a Qt 5.3 way to do the same, or bump the requirement. who is in charge of kde-baseapps? I’d like to get this going on OSX with Qt 5.3.2 again, or at least see the project set its

Re: OSX/CI: kde-baseapps fails to build on branch frameworks

Seems that's from Qt 5.4 This enum was introduced or modified in Qt 5.4. in the QUrl::UserInputResolutionOptions documentation. On Tue, Feb 10, 2015 at 3:07 PM, Marko Käning mk-li...@email.de wrote: To make kde-baseapps build again on OSX/CI I have removed poppler from its dependencies in

Re: OSX/CI: kde-baseapps fails to build on branch frameworks

Exactly, whoever added that code either needs to find a Qt 5.3 way to do the same, or bump the requirement. On Tue, Feb 10, 2015 at 3:15 PM, Marko Käning mk-li...@email.de wrote: Hi Jeremy, On 10 Feb 2015, at 23:10 , Jeremy Whiting jpwhit...@kde.org wrote: Seems that's from Qt 5.4 This enum

Re: Review Request 122493: Use qRound rather than C++11 std::lround.

/qmlcontrols/kquickcontrolsaddons/plotter.cpp 67ce63a943234b167165b0f3986f974bba5ff0cf Diff: https://git.reviewboard.kde.org/r/122493/diff/ Testing --- kdeclarative is able to build on OS X 10.7 with the built in XCode compiler and standard library. Thanks, Jeremy Whiting

Re: Review Request 122481: Fix use of environ for OS X

X 10.7 Diffs - src/widgets/kurlcompletion.cpp 1871c49a936e2ca322286e23ad6fe976ae2c7044 Diff: https://git.reviewboard.kde.org/r/122481/diff/ Testing --- kio builds with this patch on OS X 10.7 and 10.10 Thanks, Jeremy Whiting ___ Kde

Re: Review Request 122493: Use qRound rather than C++11 std::lround.

67ce63a943234b167165b0f3986f974bba5ff0cf Diff: https://git.reviewboard.kde.org/r/122493/diff/ Testing --- kdeclarative is able to build on OS X 10.7 with the built in XCode compiler and standard library. Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Fixing and regulating certain types of search fields across KF5 apps

Eike, On Mon, Feb 9, 2015 at 1:03 PM, Eike Hein h...@kde.org wrote: Hi, we currently have numerous dynamic search fields across KDE apps that, for performance reasons, disregard input shorter than a particular QString::length(). Examples are KMail and some things in KRunner. It's a common

Review Request 122481: Fix use of environ for OS X

1871c49a936e2ca322286e23ad6fe976ae2c7044 Diff: https://git.reviewboard.kde.org/r/122481/diff/ Testing --- kio builds with this patch on OS X 10.7 and 10.10 Thanks, Jeremy Whiting ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https

C++11 policy in frameworks?

Hey all, In trying to get kf5 built on an older machine with clang 3.7 I've hit an isuse with kdeclarative. A few days ago some code was checked into it that uses std::lround which isn't available on clang's stdlib implementation yet. Should this change to floor or ciel, or is there an #ifdef we

Re: C++11 policy in frameworks?

confused though This is (should not) be a problem with the compiler version - this is a library function. Which version of libc++ is it using? (it might be using the old system's one instead of the latest release or something) Cheerio, Ivan On 8 February 2015 at 21:59, Jeremy Whiting jpwhit

Re: Review Request 122481: Fix use of environ for OS X

Diffs (updated) - src/widgets/kurlcompletion.cpp 1871c49a936e2ca322286e23ad6fe976ae2c7044 Diff: https://git.reviewboard.kde.org/r/122481/diff/ Testing --- kio builds with this patch on OS X 10.7 and 10.10 Thanks, Jeremy Whiting ___ Kde

  1   2   3   >