jsalatas added a comment.
In https://phabricator.kde.org/D6473#124300, @dhaumann wrote:
> So the question is: Why is the cursor not updated? If we can answer this,
we may be able to either find that this patch is correct, or that the root of
the real issue lies somewhere else...
jsalatas added a comment.
In https://phabricator.kde.org/D6473#124287, @kfunk wrote:
> Could you add a test in e.g. autotests/src/searchbar_test.cpp?
Sure! will do it later...
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D6473
To: jsalatas,
jsalatas added a comment.
ping?
:)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D6473
To: jsalatas, #ktexteditor
Cc: ltoscano, kwrite-devel, #frameworks
jsalatas edited the summary of this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D6473
To: jsalatas, #ktexteditor
Cc: ltoscano, kwrite-devel, #frameworks
jsalatas added a comment.
In https://phabricator.kde.org/D6473#121136, @ltoscano wrote:
> If the review is accepted and you want to close the bug, replace
>
> Fixes bug 381080
> https://bugs.kde.org/show_bug.cgi?id=381080
>
> with simply
>
> BUG: 381080
Thanks!
jsalatas created this revision.
Restricted Application added subscribers: Frameworks, kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Fixes bug 381080
https://bugs.kde.org/show_bug.cgi?id=381080
TEST PLAN
The problem was that it looked for multiline
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:c9cb3e9761f3: Expose additional internal View's
functionality to the public API (authored by jsalatas).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
jsalatas marked 9 inline comments as done.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4947
To: jsalatas, #frameworks, tfry, mwolff, #ktexteditor, cullmann
Cc: cullmann, dhaumann, anthonyfieroni, mwolff, kwrite-devel
jsalatas marked 2 inline comments as done.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4947
To: jsalatas, #frameworks, tfry, mwolff, #ktexteditor, cullmann
Cc: cullmann, dhaumann, anthonyfieroni, mwolff, kwrite-devel
jsalatas added a comment.
In https://phabricator.kde.org/D4947#95893, @cullmann wrote:
> Sorry for late response, thanks for ping!
No worries :)
> First about the interface you added: I think that it is ok the way, beside
for the enum values I would go for CamelCase like all
jsalatas updated this revision to Diff 12598.
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4947?vs=12416=12598
REVISION DETAIL
https://phabricator.kde.org/D4947
AFFECTED FILES
src/include/ktexteditor/view.h
src/utils/ktexteditor.cpp
jsalatas added a comment.
ping?
:)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4947
To: jsalatas, #frameworks, tfry, mwolff, #ktexteditor
Cc: cullmann, dhaumann, anthonyfieroni, mwolff, kwrite-devel
jsalatas added a comment.
In https://phabricator.kde.org/D4947#94562, @dhaumann wrote:
> Reading this API, I still have some general thoughts:
> This is the first time we expose the concept of "visible lines". So far,
this only exists internally in katetextfolding.h/cpp. By itself,
jsalatas updated this revision to Diff 12416.
jsalatas edited the summary of this revision.
jsalatas added a comment.
According to @cullmann's and @dhaumann's feedback created the `enum LineType`
and also renamed `firstVisibleLine()` and `lastVisibleLine()` to
`firstDisplayedLine()` and
jsalatas updated this revision to Diff 12412.
jsalatas added a comment.
in `firstVisibleLine()` and `lastVisibleLine()` provide the option for real
lines (in cases of folded text).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4947?vs=12396=12412
jsalatas updated this revision to Diff 12396.
jsalatas added a comment.
Implemented additional functions as non-virtuals, according to @cullmann's
suggestion.
It's much better and cleaner this way!
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
jsalatas added a comment.
ping?
:)
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4947
To: jsalatas, #frameworks, tfry, mwolff, #ktexteditor
Cc: dhaumann, anthonyfieroni, mwolff, kwrite-devel
jsalatas updated this revision to Diff 12253.
jsalatas added a comment.
Diff updated. Hope I addressed all issues :\
See some additional comments/clarifications below:
In https://phabricator.kde.org/D4947#92889, @mwolff wrote:
> should be scrollToPos, c -> cursor, and make the
jsalatas added a comment.
Thank you all for your feedback. I'll update soon
INLINE COMMENTS
> mwolff wrote in view.h:479
> why is this not the document end pos? because of virtual cursors? if so,
> please rename this to `viewEndCursor()` or similar, I don't see why this
> should be
jsalatas added a comment.
In https://phabricator.kde.org/D4947#92995, @anthonyfieroni wrote:
> Milian had in mind that you can take charge of Kompare and implement your
ideas rather than release new app. :)
lol! OK! Got it! I guess I can do that, although my initial motivation is
jsalatas added a comment.
In https://phabricator.kde.org/D4947#92889, @mwolff wrote:
> You will have to create a separate interface for this, similar to what we
have done in the past, with a TODO note that this should be merged in time for
KF6.
You mean an interface similar to
jsalatas created this revision.
Restricted Application added a subscriber: kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
I'm creating a diff/patch frontend similar to Kompare but using KTextEditor
to display/edit source/destination files. In order to be
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:2df4c40ea27a: Added font and on-the-fly-spellcheck options
in ConfigInterface (authored by jsalatas).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
jsalatas added a comment.
In https://phabricator.kde.org/D4940#92656, @dhaumann wrote:
> Looks good, please commit. Do you have commit rights, or should I commit
for you?
Committed. Thanks!
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4940
To:
jsalatas added a comment.
In https://phabricator.kde.org/D4940#92646, @dhaumann wrote:
> In general, looks good, but please also extend the documentat in
src/include/configinterface.h, and add an updated patch here again :-)
Ooops! My bad :)
Added
> And thinking about it
jsalatas updated this revision to Diff 12182.
jsalatas added a comment.
Added documentation for the new options in configinterface.h
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4940?vs=12180=12182
REVISION DETAIL
https://phabricator.kde.org/D4940
jsalatas created this revision.
Restricted Application added a subscriber: kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
- Added "font" option in View's ConfigInterface
- Added "on-the-fly-spellcheck" option in View's ConfigInterface
TEST PLAN
Tested in
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:ba03878378a4: Remember file type set by user over sessions
(authored by jsalatas).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4802?vs=11836=11862
REVISION
jsalatas created this revision.
Restricted Application added a subscriber: kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
File type set by user is being reset after opening a session and reloading
(https://phabricator.kde.org/F5) a file with file type set by
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:16d90fd266df: Reset filetype when opening url (authored by
jsalatas).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4699?vs=11800=11823
REVISION DETAIL
jsalatas requested review of this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4699
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jsalatas, #frameworks, dhaumann, #framework_syntax_hightlighting,
#ktexteditor
Cc:
jsalatas added a comment.
In https://phabricator.kde.org/D4699#89262, @cullmann wrote:
> Don't we need to honor "m_reloading" to avoid to do this on document
reloads?
You are right! We need to check `m_reloading` in cases of multiple
consecutive reloads :)
REPOSITORY
R39
jsalatas updated this revision to Diff 11800.
jsalatas added a comment.
Honor "m_reloading" to avoid to avoid reseting the file type on document
reloads as suggested by @cullmann
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4699?vs=11575=11800
jsalatas added a comment.
In https://phabricator.kde.org/D4699#89262, @cullmann wrote:
> Don't we need to honor "m_reloading" to avoid to do this on document
reloads?
`KTextEditor::DocumentPrivate::documentReload()` is keeping
m_fileTypeSetByUser to a local variable (`byUser`)
jsalatas added a comment.
In https://phabricator.kde.org/D4699#89179, @dhaumann wrote:
> Looks reasonable to me as well... I don't see any negative side effects, so
should be fine from my side.
> @cullmann Can you confirm?
Let's wait for a second opinion before committing this
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:acc3aec084d2: Added getter for word-count configuration
value (authored by jsalatas).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4696?vs=11568=11734
jsalatas added a comment.
In https://phabricator.kde.org/D4696#89174, @dhaumann wrote:
> Indeed the getter case is missing, please commit. (Can you commit yourself,
or should I take care of this?)
Yes I can commit. Will do it later
Thanks!
REPOSITORY
R39 KTextEditor
jsalatas retitled this revision from "Reset filetype when opening url" to
"[KTextEditor] Reset filetype when opening url".
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4699
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
jsalatas created this revision.
Restricted Application added a subscriber: kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Seems reasonable to me that when calling `openUrl` it should be reset to its
original filetype and highlighting mode.
TEST PLAN
none
jsalatas created this revision.
jsalatas added a project: KTextEditor.
Restricted Application added a subscriber: kwrite-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Just adding the read part of "word-count"which was missing from
KTextEditor::ConfigInterface
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:1858d6fafb58: Consistent conversion from/to cursor to/from
coordinates (authored by jsalatas).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D4538?vs=11494=11507
jsalatas updated this revision to Diff 11494.
jsalatas added a comment.
1. I abandoned the 3rd issue I mention in the summary about the line
`scrollPos(max, max.column(), calledExternally);` as I could neither verify nor
disprove if this was intended or not.
2. In `cursorToCoordinate()`
jsalatas added a reviewer: KTextEditor.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4538
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jsalatas, #frameworks, #plasma, #ktexteditor
Cc: plasma-devel, kwrite-devel, lesliezhai,
jsalatas updated the summary for this revision.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D4538
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: jsalatas, #frameworks, #plasma
Cc: plasma-devel, kwrite-devel, lesliezhai,
jsalatas created this revision.
jsalatas added reviewers: Frameworks, Plasma.
jsalatas set the repository for this revision to R39 KTextEditor.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: kwrite-devel, plasma-devel.
REVISION SUMMARY
This
On 2017-01-24 04:03 PM, Christoph Feck wrote:
On 24.01.2017 19:45, John Salatas wrote:
On 2017-01-24 10:40 AM, Christoph Feck wrote:
On 24.01.2017 09:01, John Salatas wrote:
I just built a trigram data file (attached) for Greek language using
a
wikipedia dump as corpus. Can I just push
On 2017-01-24 10:40 AM, Christoph Feck wrote:
On 24.01.2017 09:01, John Salatas wrote:
I just built a trigram data file (attached) for Greek language using a
wikipedia dump as corpus. Can I just push it to sonnet's git or do I
need to generate a differential review in phabricator or something
Hi.
I just built a trigram data file (attached) for Greek language using a
wikipedia dump as corpus. Can I just push it to sonnet's git or do I
need to generate a differential review in phabricator or something?
Thanks!
--
John Salatas
Ïο 0
αι1
Î
This revision was automatically updated to reflect the committed changes.
Closed by commit R246:c7f0b1453720: Fix segfault in trigrams generation and
expose MAXGRAMS constant in the header (authored by jsalatas).
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
jsalatas created this revision.
jsalatas added a reviewer: Plasma.
jsalatas set the repository for this revision to R246 Sonnet.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
REVISION SUMMARY
This patch fixes a
50 matches
Mail list logo
