D28020: New class ProcessLauncherJob in KIOGui

2020-04-18 Thread Jonah Brüchert
jbbgameich added a comment. Sorry for using this diff to ask this question, I couldn't find you in kde-devel. Would it be possible to expose the finished signal of QProcess in KIO::ApplicationLauncherJob? I need something like this to close the startup feedback in the Plasma Mobile

D28110: PersonsModel: Fix PersonVCardRole

2020-03-17 Thread Jonah Brüchert
This revision was automatically updated to reflect the committed changes. Closed by commit R307:b6b86f158254: PersonsModel: Fix PersonVCardRole (authored by jbbgameich). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28110?vs=77869=77870 REVISION DETAIL

D28110: PersonsModel: Fix PersonVCardRole

2020-03-17 Thread Jonah Brüchert
jbbgameich updated this revision to Diff 77869. jbbgameich added a comment. Use AbstractContact::VCardProperty REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28110?vs=77868=77869 BRANCH fix-personsmodel-vcard (branched from master) REVISION DETAIL

D28110: PersonsModel: Fix PersonVCardRole

2020-03-17 Thread Jonah Brüchert
jbbgameich created this revision. jbbgameich added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jbbgameich requested review of this revision. REPOSITORY R307 KPeople BRANCH fix-personsmodel-vcard (branched from master) REVISION

D27838: Port to new QML Connections syntax

2020-03-04 Thread Jonah Brüchert
jbbgameich added a reviewer: Frameworks. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D27838 To: jbbgameich, #frameworks Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D27528: Adapt action numbering in Android to work like in KNotifications

2020-02-21 Thread Jonah Brüchert
jbbgameich added a comment. Once the diff is landed, it will be commited with the email address you set up in your KDE Identity account afaik. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D27528 To: cacahueto, #frameworks, nicolasfella, vkrause Cc:

D27528: Adapt action numbering in Android to work like in KNotifications

2020-02-20 Thread Jonah Brüchert
jbbgameich added reviewers: nicolasfella, vkrause. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D27528 To: cacahueto, #frameworks, nicolasfella, vkrause Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D25620: Register ActionType enum with metaobject system

2019-12-03 Thread Jonah Brüchert
jbbgameich added a comment. Ping REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25620 To: jbbgameich, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25620: Register ActionType enum with metaobject system

2019-11-30 Thread Jonah Brüchert
jbbgameich added inline comments. INLINE COMMENTS > apol wrote in personactionsmodel_p.h:24 > Why do we need the include? The enum ist defined in that header. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25620 To: jbbgameich, apol Cc: kde-frameworks-devel,

D25620: Register ActionType enum with metaobject system

2019-11-29 Thread Jonah Brüchert
jbbgameich added a reviewer: apol. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25620 To: jbbgameich, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25620: Register ActionType enum with metaobject system

2019-11-29 Thread Jonah Brüchert
jbbgameich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jbbgameich requested review of this revision. REPOSITORY R307 KPeople BRANCH actions-meta-enum (branched from master) REVISION DETAIL https://phabricator.kde.org/D25620

D25265: Support adding a contact to a specific backend

2019-11-15 Thread Jonah Brüchert
jbbgameich added inline comments. INLINE COMMENTS > apol wrote in datasourcemodel.h:43 > Use DisplayRole for this? I intend to add an actual display role later. Strictly speaking this is the id used by KPeople and not anything that should be shown to the user ideally. REPOSITORY R307

D25312: Document configuration file path on Android

2019-11-15 Thread Jonah Brüchert
This revision was automatically updated to reflect the committed changes. Closed by commit R289:61cc70fd3cff: Document configuration file path on Android (authored by jbbgameich). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25312?vs=69768=69801

D25312: Document configuration file path on Android

2019-11-14 Thread Jonah Brüchert
jbbgameich added a reviewer: vkrause. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D25312 To: jbbgameich, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25312: Document configuration file path on Android

2019-11-14 Thread Jonah Brüchert
jbbgameich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jbbgameich requested review of this revision. REVISION SUMMARY It's pretty hard right now to find out the search path on android for new developers. REPOSITORY R289

D15364: Plasma style: Remove hardcoded textFormat

2019-11-12 Thread Jonah Brüchert
jbbgameich closed this revision. jbbgameich added a comment. I think this was fixed in another way already. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15364 To: jbbgameich, #plasma, davidedmundson Cc: broulik, davidedmundson, svuorela,

D22599: Make first and last name available separately

2019-11-12 Thread Jonah Brüchert
jbbgameich abandoned this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22599 To: jbbgameich, #plasma:_mobile, apol Cc: pino, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25265: Support adding a contact to a specific backend

2019-11-11 Thread Jonah Brüchert
jbbgameich added a reviewer: Plasma: Mobile. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25265 To: jbbgameich, apol, #plasma:_mobile Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25265: Support adding a contact to a specific backend

2019-11-11 Thread Jonah Brüchert
jbbgameich updated this revision to Diff 69608. jbbgameich added a comment. Use more future proof roleNames and Enum REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25265?vs=69603=69608 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25265

D25265: Support adding a contact to a specific backend

2019-11-11 Thread Jonah Brüchert
jbbgameich added a reviewer: apol. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D25265 To: jbbgameich, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25265: Support adding a contact to a specific backend

2019-11-11 Thread Jonah Brüchert
jbbgameich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jbbgameich requested review of this revision. REVISION SUMMARY - Add overload of PersonPluginManager::addContact that takes a pluginId - Add a DataSourceModel that can later

D24046: Allow triggering sort from QML

2019-11-09 Thread Jonah Brüchert
jbbgameich added a comment. Can we get one of the two ways accepted so we can progress on the phonebook merge request? REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D24046 To: nicolasfella, apol Cc: jbbgameich, broulik, kde-frameworks-devel, LeGast00n, GB_2,

D24046: Allow triggering sort from QML

2019-10-05 Thread Jonah Brüchert
jbbgameich added a comment. why not Q_INVOKABLE void sort(int column, Qt::SortOrder order = Qt::AscendingOrder) override { QSortFilterProxyModel::sort(column, order); } instead of adding a new function? REPOSITORY R307 KPeople REVISION DETAIL

D23764: Make it possible to delete contacts from backends

2019-09-07 Thread Jonah Brüchert
This revision was automatically updated to reflect the committed changes. Closed by commit R307:0514c4d0cc17: Make it possible to delete contacts from backends (authored by jbbgameich). REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23764?vs=6=65563

D23764: Make it possible to delete contacts from backends

2019-09-07 Thread Jonah Brüchert
jbbgameich added a dependent revision: D23765: Implement deleting a contact. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D23764 To: jbbgameich, apol, #plasma:_mobile Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23764: Make it possible to delete contacts from backends

2019-09-07 Thread Jonah Brüchert
jbbgameich edited the test plan for this revision. jbbgameich added reviewers: apol, Plasma: Mobile. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D23764 To: jbbgameich, apol, #plasma:_mobile Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23764: Make it possible to delete contacts from backends

2019-09-07 Thread Jonah Brüchert
jbbgameich updated this revision to Diff 6. jbbgameich added a comment. fix typo REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23764?vs=65552=6 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23764 AFFECTED FILES

D23764: Make it possible to delete contacts from backends

2019-09-07 Thread Jonah Brüchert
jbbgameich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jbbgameich requested review of this revision. REVISION SUMMARY Adds a new deleteContact function REPOSITORY R307 KPeople BRANCH master REVISION DETAIL

D22968: Make it possible to modify contacts

2019-08-30 Thread Jonah Brüchert
jbbgameich accepted this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22968 To: apol, #frameworks, jbbgameich, bshah Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22968: Make it possible to modify contacts

2019-08-29 Thread Jonah Brüchert
jbbgameich added inline comments. INLINE COMMENTS > peopleqmlplugin.cpp:64 > qmlRegisterUncreatableType(uri, 1, 0, "ActionType", > QStringLiteral("You cannot create ActionType")); > +qmlRegisterSingletonType(uri, 1, 0, > "Manager", [] (QQmlEngine*, QJSEngine*) -> QObject* { return new

D22720: Apply busy indicator duration change of D22646 to the QQC2 style

2019-07-24 Thread Jonah Brüchert
This revision was automatically updated to reflect the committed changes. Closed by commit R242:31cd4f8d8ee8: Apply busy indicator duration change of D22646 to the QQC2 style (authored by jbbgameich). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D22720: Apply busy indicator duration change of D22646 to the QQC2 style

2019-07-24 Thread Jonah Brüchert
jbbgameich edited the summary of this revision. jbbgameich added reviewers: VDG, Plasma: Mobile. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D22720 To: jbbgameich, #vdg, #plasma:_mobile Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh,

D22720: Apply busy indicator duration change of D22646 to the QQC2 style

2019-07-24 Thread Jonah Brüchert
jbbgameich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jbbgameich requested review of this revision. REVISION SUMMARY Match the duration (2 seconds) that was set in D22630 . REPOSITORY R242

D22599: Make first and last name available separately

2019-07-21 Thread Jonah Brüchert
jbbgameich added a comment. In case a, all first names would probably be in a string separated by spaces, same for multiple last names. In case c, I guess only the last name would be set maybe. I have been only working with the KContacts based vcard backend, where givenName and

D22599: Make first and last name available separately

2019-07-20 Thread Jonah Brüchert
jbbgameich added reviewers: Plasma: Mobile, apol. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22599 To: jbbgameich, #plasma:_mobile, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22599: Make first and last name available separately

2019-07-20 Thread Jonah Brüchert
jbbgameich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jbbgameich requested review of this revision. REVISION SUMMARY Required for the Plasma Mobile phonebook app where both are separate fields REPOSITORY R307 KPeople BRANCH

D22425: personsmodel: Add phoneNumber

2019-07-15 Thread Jonah Brüchert
jbbgameich closed this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22425 To: jbbgameich, #plasma:_mobile, #kde_pim, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22425: personsmodel: Add phoneNumber

2019-07-13 Thread Jonah Brüchert
jbbgameich added a comment. Does that mean it's ready to land now? REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22425 To: jbbgameich, #plasma:_mobile, #kde_pim, apol Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22425: personsmodel: Add phoneNumber

2019-07-13 Thread Jonah Brüchert
jbbgameich updated this revision to Diff 61686. jbbgameich added a comment. Put PhoneNumberRole after GroupsRole REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22425?vs=61671=61686 BRANCH personsmodel-phoneNumber (branched from master) REVISION DETAIL

D22425: personsmodel: Add phoneNumber

2019-07-12 Thread Jonah Brüchert
jbbgameich added a reviewer: KDE PIM. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22425 To: jbbgameich, #plasma:_mobile, #kde_pim Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22425: personsmodel: Add phoneNumber

2019-07-12 Thread Jonah Brüchert
jbbgameich added a reviewer: Plasma: Mobile. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D22425 To: jbbgameich, #plasma:_mobile Cc: kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D22425: personsmodel: Add phoneNumber

2019-07-12 Thread Jonah Brüchert
jbbgameich updated this revision to Diff 61671. jbbgameich added a comment. fix indentation REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22425?vs=61670=61671 BRANCH personsmodel-phoneNumber (branched from master) REVISION DETAIL

D22425: personsmodel: Add phoneNumber

2019-07-12 Thread Jonah Brüchert
jbbgameich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jbbgameich requested review of this revision. REVISION SUMMARY This is intended to provide shared code for plasma-phone-components and spacebar. TEST PLAN The phoneNumber

D15364: Plasma style: Remove hardcoded textFormat

2018-09-19 Thread Jonah Brüchert
jbbgameich added a comment. @davidedmundson I'm not yet used to the KDE Phabricator workfolow... do I need to do anything else to get this patch landed / included? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15364 To: jbbgameich, #plasma,

D15364: Plasma style: Remove hardcoded textFormat

2018-09-09 Thread Jonah Brüchert
jbbgameich added a comment. On Plasma Mobile all applications use the Plasma Style for QtQuickControls 2. (kaidan is also a Plasma Mobile application) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D15364 To: jbbgameich, #plasma Cc: svuorela,

D15364: Plasma style: Remove hardcoded textFormat

2018-09-09 Thread Jonah Brüchert
jbbgameich added a comment. @ngraham The screenshot is from Kaidan. It's using QtQuickControls 2 with the Plasma Style, so not PlasmaComponents direcltly. I don't think it's possible to set the textFormat for this tooltip in QtQuickControls 2 unfortunately. @svuorela So it seems like

D15364: Plasma style: Remove hardcoded textFormat

2018-09-09 Thread Jonah Brüchert
jbbgameich added a comment. @ngraham I noticed the issue when using the QtQuickControls 2 style. All other styles I know don't require setting the textFormat, only the Plasma Style. Of course all QQC2 applications could just set the textFormat, but it's not possible in all cases. For

D15364: Plasma style: Remove hardcoded textFormat

2018-09-08 Thread Jonah Brüchert
jbbgameich created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. jbbgameich requested review of this revision. REVISION SUMMARY This fixes all texts being displayed as Text.PlainText if not explicitly overriden. REPOSITORY R242 Plasma