Re: LibKF6Breeze Icons and KIconLoader

[Jonathan Riddell]

I neon me and David R tracked it down to some optimization probably
with the dh_dwz tool from Debian packaging tools, this is the "DWARF
optimization and duplicate removal tool" part of the toolchain.

And with the discussion here Christoph has yesterday replaced the use
of qt_add_big_resources() with qt_add_resources() which also makes the
problem go away.
https://invent.kde.org/frameworks/breeze-icons/-/commit/fa44b11bc2b36d5c3cfc5c3403ea75b2fff57253

So beware use of qt_add_big_resources() it seems to be fragile to optimising.

Jonathan

Re: LibKF6Breeze Icons and KIconLoader

[Jonathan Riddell]

> have no such issues, but does for you the current code in KIconThemes
> and
> KBreezeIcons work? (e.g. if one doesn't revert but uses the master
> state)

No master is equally broken when made into a .deb and equally works
when compiled manually.

Jonathan

LibKF6Breeze Icons and KIconLoader

[Jonathan Riddell]

Has anyone had issues with Breeze loading using Frameworks 6.2 or
master building the libKF6BreezeIcons.so.6 library in breeze-icons.
In neon we found that the icons did not load in Plasma and System
Settings and other QML apps.  The Breeze theme was not available for
selection in System Settings but Breeze Dark was available for
selection.

This only happened in the packaged build.  A manual build was fine.
Building the package and copying the library in manually from the
build was fine.  But building the package and copying the library in
manually from the final package broke it.  So there's something about
the way the .deb packaging gets made that seems to break a path or
some other aspect of the library.

The error on output from apps when using the broken library is
"kf.config.core: Created a KConfigGroup on an inaccessible config
location :/icons/breeze/index.theme Icon Theme"

For now I've done a workaround of reverting to KIconLoader 6.1.

Bug used was https://bugs.kde.org/show_bug.cgi?id=487374

Jonathan

Frameworks 6.1 Released

[Jonathan Riddell]

KDE Frameworks 6.1 is released for distros and packagers

https://kde.org/announcements/frameworks/6/6.1.0/

Re: Frameworks 6.1 tars available

[Jonathan Riddell]

extra-cmake-modules 6.1.0 tar has been updated ahead of release on Friday

extra-cmake-modules;master;7e68938f075a0423e3744358be9c4e77c6922104;extra-cmake-modules-6.1.0.tar.xz;76c9edf00807e6cf8d4ae35f5195b4bc3fe94648d976fef532bf7f97d86388bd

   http://download.kde.org/stable/plasma/6.1.0/extra-cmake-modules-6.1.0.tar.xz";>extra-cmake-modules-6.1.0
   333kB
-   
a51fb26baea9f6828884bfe6671d1cda840bd7f8c8bba904b7abb2160c2fedd2
+   
76c9edf00807e6cf8d4ae35f5195b4bc3fe94648d976fef532bf7f97d86388bd

http://embra.edinburghlinux.co.uk/~jr/tmp/frameworks-6.1.0-release-data
http://embra.edinburghlinux.co.uk/~jr/tmp/extra-cmake-modules-6.1.0-changes_report.html

On Mon, 8 Apr 2024 at 12:09, Antonio Rojas  wrote:
>
> El viernes, 5 de abril de 2024 13:31:32 (CEST), Jonathan Riddell escribió:
>
> > Tars for KDE Frameworks 6.1 are available for pre-release packaging,
>
> > release is due next Friday 12 April
>
>
> Hello,
>
>  Please consider a respin of extra-cmake-modules to include 
> 7e68938f075a0423e3744358be9c4e77c6922104
>
>
>  It fixes the default CMAKE_INSTALL_PREFIX value with cmake>=3.29.1.
>
>
>
>

Frameworks 6.1 tars available

[Jonathan Riddell]

Tars for KDE Frameworks 6.1 are available for pre-release packaging,
release is due next Friday 12 April

http://embra.edinburghlinux.co.uk/~jr/tmp/frameworks-6.1.0-release-data

Jonathan

Frameworks 6.0.0 is out!

[Jonathan Riddell]

Frameworks 6.0.0 is out!  Congrats everyone.

At the meeting yesterday we decided to keep with the 1 monthly schedule.
I'll try to nudge people into creating a release team so it's not all
dependent on 1 person.

David Faure: we talked about having KF5 releases on a less frequent
release, maybe every 2 or 3 months.  Do you have an opinion here?

We spoke about making a bugfix release of 6.0 in two or three weeks time
which would mean making Git Frameworks/6.0 branches so bugfixes can go
there.  I've not done this yet but do let me know if I should.

Jonathan

Re: KDE Frameworks 6.0.0 tars

[Jonathan Riddell]

Updated frameworks 6.0 tars tonight are
baloo-6.0.0
ea21e88d1fe252d2dc95e0b7ae8891594822ccdd898e7aa56d46ed9ecd626a41
http://embra.edinburghlinux.co.uk/~jr/tmp/baloo-6.0.0-changes_report.html

kfilemetadata-6.0.0
cf130dc1b32a31a19213f3e1ac67f2180cb7931240e5c755211686e93792f393
http://embra.edinburghlinux.co.uk/~jr/tmp/kfilemetadata-6.0.0-changes_report.html

knewstuff-6.0.0
0299dba980590bd7c74870a74c6bb6ca732af478ab2c9ba414943f62ea0be0fa
http://embra.edinburghlinux.co.uk/~jr/tmp/knewstuff-6.0.0-changes_report.html

Jonathan

Re: KDE Frameworks 6.0.0 tars

[Jonathan Riddell]

kstatusnotifieritem respin up
http://embra.edinburghlinux.co.uk/~jr/tmp/kstatusnotifieritem-6.0.0-changes_report.html

   http://download.kde.org/stable/frameworks/6.0/kstatusnotifieritem-6.0.0.tar.xz
">kstatusnotifieritem-6.0.0
   46kB
-
f64d46c340f455fb3354d41ed73c23766e0256943de3a316fbc56c3b51020095
+
b426176d2cbc6fe80c758b6c476a47341d89a92cbb3355c2be37428a41772907

Re: KDE Frameworks 6.0.0 tars

[Jonathan Riddell]

KAuth respin now up

http://embra.edinburghlinux.co.uk/~jr/tmp/kauth-6.0.0-changes_report.html#SGMLDocuments

   http://download.kde.org/stable/frameworks/6.0/kauth-6.0.0.tar.xz";>kauth-6.0.0

   2.1MB
-
  
fef974fb82f1564b520636c98dd537c2367a964ffc0fadfe34d3a42ed4ef991c
+
  
66046698d2584692d5397a6ec808b2c9f8b7882a0f85233be9cd69283d03c768



On Thu, 22 Feb 2024 at 09:33, Jonathan Riddell  wrote:

>   http://download.kde.org/stable/plasma/6.0.0/ktexteditor-6.0.0.tar.xz";>ktexteditor-6.0.0
>
>2.6MB
> -
>   
> 086c502231cd95861e47bcdad9e79bcbf200fd4c508b239af9ca6e78223f60b8
> +
>   
> 620266c1d288d09f7aee4d2bc8b141c73555d5f033c452bcd2e2db2064b8fd42
>
>
> http://embra.edinburghlinux.co.uk/~jr/tmp/ktexteditor-6.0.0-changes_report.html
>
> On Wed, 21 Feb 2024 at 11:44, Jonathan Riddell  wrote:
>
>> Tars for KDE Frameworks 6.0.0 are now available for packagers, release
>> due next Wednesday
>>
>> http://embra.edinburghlinux.co.uk/~jr/tmp/6.0.0-release-data
>>
>>
>>

Re: KDE Frameworks 6.0.0 tars

[Jonathan Riddell]

   http://download.kde.org/stable/plasma/6.0.0/ktexteditor-6.0.0.tar.xz";>ktexteditor-6.0.0

   2.6MB
-
  
086c502231cd95861e47bcdad9e79bcbf200fd4c508b239af9ca6e78223f60b8
+
  
620266c1d288d09f7aee4d2bc8b141c73555d5f033c452bcd2e2db2064b8fd42

http://embra.edinburghlinux.co.uk/~jr/tmp/ktexteditor-6.0.0-changes_report.html

On Wed, 21 Feb 2024 at 11:44, Jonathan Riddell  wrote:

> Tars for KDE Frameworks 6.0.0 are now available for packagers, release due
> next Wednesday
>
> http://embra.edinburghlinux.co.uk/~jr/tmp/6.0.0-release-data
>
>
>

Fwd: KDE Frameworks 6.0.0 tars

[Jonathan Riddell]

Tars for KDE Frameworks 6.0.0 are now available for packagers, release due
next Wednesday

http://embra.edinburghlinux.co.uk/~jr/tmp/6.0.0-release-data

KDE's 6th Megarelease RC 2

[Jonathan Riddell]

The tars for the final pre-release of the megarelease bundle are now
available for packaging
https://kde.org/announcements/megarelease/6/rc2/

KDE's 6th Megarelease RC 1

[Jonathan Riddell]

Release Candidate 1 for KDE's 6th Megarelease is now available for
packaging and testing
https://kde.org/announcements/megarelease/6/rc1/

It contains the release candidate for KDE Frameworks 6, Plasma 6 and all
the apps in KDE Gear.

Please review the release notes before packaging and testing
https://community.kde.org/Frameworks/6.0_Release_notes
https://community.kde.org/Plasma/Plasma_6.0_Release_notes
https://community.kde.org/KDE_Gear/24.02_Release_notes

KDE's 6th MegaRelease Beta 2

[Jonathan Riddell]

A second beta of Plasma 6, Frameworks 6 and KDE Gear 24.04 is out for
packaging and testing

https://kde.org/announcements/megarelease/6/beta2/

Re: Collection of packaging notes

[Jonathan Riddell]

On Fri, 10 Nov 2023 at 10:55, Christophe Marin  wrote:

> 3 different issues appeared with plasma 6 alpha:
>
>
- The CMake config names are identical for certain core libraries:
> KDecoration2, KPipeWire, KScreenLocker, KsysGuard, LayerShellQt,
> LibKWorkspace,
>  LibTaskManager (and Breeze but it's slightly less problematic)
>
> - The CMake config files for DBus interface are not versioned:
> KRunnerAppDBusInterface, KWinDBusInterface, KSMServerDBusInterface,
> ScreenSaverDBusInterface
>

As discussed on Matrix our assumption is that Plasma 5 and 6 aren't
packaged together, a single version of Plasma should be packaged only with
the same version.


> - The libksysguard  libraries soversion weren't bumped. It's not only a
> problem for
> building plasma 5 and plasma 6. KSysguard is also an optional dependency
> for kdevelop.
>

I've bumped the soversions in libksysguard now. (I'll look at doing the
KFification for kuserfeedback too.)

I've also release noted that ksysguard the app is dead and should be
removed from distros, it hasn't been released for over 2 years and hasn't
been ported.

Jonathan

Frameworks 6 Alpha modules list

[Jonathan Riddell]

It's been agreed I'll make the release tomorrow, I'm updating version
numbers now. Here's the diff compared to KF5

+++ git-repositories-for-release-frameworks 2023-11-07
15:53:32.674589130 +
-kactivities
-kactivities-stats
+kcolorscheme
-kdelibs4support
-kdesignerplugin
-kdewebkit
-kemoticons
-khtml
-kinit
-kjs
-kjsembed
-kmediaplayer
-kross
+kstatusnotifieritem
+ksvg
+ktexttemplate
+kuserfeedback
-kwayland
-kxmlrpcclient
-oxygen-icons5
-plasma-framework

and complete one

attica
baloo
bluez-qt
breeze-icons
extra-cmake-modules
frameworkintegration
kapidox
karchive
kauth
kbookmarks
kcalendarcore
kcmutils
kcodecs
kcolorscheme
kcompletion
kconfig
kconfigwidgets
kcontacts
kcoreaddons
kcrash
kdav
kdbusaddons
kdeclarative
kded
kdesu
kdnssd
kdoctools
kfilemetadata
kglobalaccel
kguiaddons
kholidays
ki18n
kiconthemes
kidletime
kimageformats
kio
kirigami
kitemmodels
kitemviews
kjobwidgets
knewstuff
knotifications
knotifyconfig
kpackage
kparts
kpeople
kplotting
kpty
kquickcharts
krunner
kservice
kstatusnotifieritem
ksvg
ktexteditor
ktexttemplate
ktextwidgets
kunitconversion
kuserfeedback
kwallet
kwidgetsaddons
kwindowsystem
kxmlgui
modemmanager-qt
networkmanager-qt
prison
purpose
qqc2-desktop-style
solid
sonnet
syndication
syntax-highlighting
threadweave

Frameworks 6 release scripts

[Jonathan Riddell]

I've started the process of adapting the Plasma release scripts to
Frameworks (and other stuff generally hopefully).

https://invent.kde.org/sdk/releaseme/  work/frameworks branch

I've updated the scripts to get a list of repos and to make the tars.
Still to be done are stuff like updating the version numbers and Qt
versions, making web pages, changelogs and well everything else.

Here's the tars I got it to make, can someone check one or more of them to
see if they look correct and if the list of tars looks correct?
http://embra.edinburghlinux.co.uk/~jr/tmp/frameworks-5.245.0/

oxygen-icons5 needs renamed to oxygen-icons but that's done in gitlab I've
asked sysadmin to do that.

I know I'm probably not going to get anywhere but I'd advocate again
dropping oxygen-icons (and oxygen from Plasma) and do standalone releases,
it's the majority of disk space and creation time for these tars

This includes kuserfeedback which probably needs more framework-ification

> ncdu
  229.4 MiB [##]  oxygen-icons5-5.245.0.tar.xz
  15.1 MiB [  ]  kimageformats-5.245.0.tar.xz
   4.1 MiB [  ]  kwidgetsaddons-5.245.0.tar.xz
   3.3 MiB [  ]  syntax-highlighting-5.245.0.tar.xz
   3.3 MiB [  ]  kio-5.245.0.tar.xz
   3.0 MiB [  ]  knewstuff-5.245.0.tar.xz

Is this useful?  Should we use it for the release next Wednesday?  In which
case I'll continue with the rest of the work

Jonathan

Re: Collection of packaging notes

[Jonathan Riddell]

>
> If not, then why not fix any misnaming while we change names anyway.
>

Go for it :)

Jonathan

Re: Collection of packaging notes

[Jonathan Riddell]

Thanks for your e-mail.  It covers more than Frameworks so I'm including
release-team@ too.

One quick question, is naming non-frameworks libKF6foo really a problem we
need to fix?  Given all the other issues...

Jonathan


On Wed, 1 Nov 2023 at 10:55, Christophe Marin  wrote:

> Hello,
>
> With various alpha coming out soon, here are the notes added to my
> packages
> when I started packaging snapshots and still present.
>
> I'm well aware that some of these modules won't be present in the first
> releases.
>
> First, the most annoying issue:
> Plasma still didn't bump all their libraries soname. That's a major
> annoyance
> for packagers.
>
> - Conflicting files (not mentioned in the other thread)
> kcm_trash.desktop is installed by both kio (kf5) and kio-extras (kf6)
>
> - Conflicting translation catalog names:
> plasma-integration (plasmaintegration5)
> kuserfeedback
>
> - Misnamed libraries:
> kmail-account-wizard (liblibaccountwizard.so)
> ktextaddons (liblibvoskspeechtotext.so)
>
> - Non frameworks modules installing libKF*.so
> ktextaddons (various libraries)
> konqueror (libKF6Konq.so)
> libksane (libKF5Sane5.so)
> kweathercore (libKF6KWeatherCore.so)
> libktorrent (libKF5Torrent.so)
> libkexiv2 (libKF6KExiv2.so)
> libkdcraw (libKF6KDcraw.so)
> baloo-widgets (libKF6BalooWidgets.so)
> kmoretools (libKF6MoreTools.so)
> libkscreen (libKF6Screen.so, libKF6ScreenDpms.so)
>
> - Wrong install location for knewstuff files:
> khangman
> kturtle
>
> - Wrong install location for CMake files:
> qqc2-breeze-style (still uses KF5QQC2BreezeStyle)
>
> - old install location:
> kalgebra (/usr/share/katepart5. Note: syntax-highlighting won't ignore the
> file, but it's not the default location)
> ksystemlog (/usr/share/kxmlgui5/ksystemlog)
>
> - Modules still using QQC1:
> kdeplasma-addons (applets/fifteenPuzzle)
>
> - build dependency issues:
> plasma5support (links and requires QtGui but doesn't search for it at
> build
> time)
> kinfocenter (requires kpackage at build time but doesn't seem to need it)
>
>
> Christophe
>
>
>
>

Re: KUserFeedback as framework for KF6

[Jonathan Riddell]

I'm bumping this thread because this needs done pronto.  There's no
objections but also frameworks has quite exacting needs so it would be nice
to have a confirmation it would be good to include from someone who knows
about ABI needs etc.  But I'll include it when I get these release scripts
looked into.

Jonathan


On Sat, 15 Jul 2023 at 21:39,  wrote:

> Hi,
>
> several of our projects use it, like Plasma and Kate.
>
> Can we make it a framework for KF6?
>
> Then we have finally regular releases that include bug fixes.
>
> Is there some opposition to do that?
> I asked in the past but there was just no reaction.
>
> Greetings
> Christoph
>

Frameworks 6 alpha

[Jonathan Riddell]

We chatted about the alpha release due next Wednesday in the Frameworks
meeting today.

>From my notes:

- Frameworks would like do be part of this release

- Nico F, Alex S, David E are release spods

- There's not been any work on doing the tooling.  There's a desire to move
to releaseme for tooling.  Jonathan uses this plus a load of supporting
scripts for Plasma and will look at adapting that for Frameworks and come
up with a proposal

- Plasma would like to take over release of plasma-framework, kwayland and
kactivities and that presumably means also kactivities-stats.  There was
discussion on the problem of moving the gitlab entries for this while 5
releases are still ongoing so it's probably best to just leave that for now.

- oxygen-icons5 tar should be renamed oxygen-icons (again probably leave
gitlab repo renaming until later)
- We didn't discuss it but kirigami2 tar should also be renamed to kirigami

Does that seem right?

Anything else?

Jonathan

Re: KF6 overlapping files

[Jonathan Riddell]

Here's a current list

'/usr/share/dbus-1/system.d/org.kde.kf5auth.conf' → libkf5auth-data
'/etc/xdg/ui/ui_standards.rc' → libkf5xmlgui-data
'/etc/xdg/accept-languages.codes' → kio
'/etc/xdg/kshorturifilterrc' → kio
'/usr/bin/kcookiejar5' → kio
'/usr/share/dbus-1/services/org.kde.kcookiejar5.service' → kio
'/usr/share/dbus-1/services/org.kde.kiod5.service' → kio
'/usr/share/dbus-1/services/org.kde.kioexecd.service' → kio
'/usr/share/dbus-1/services/org.kde.kpasswdserver.service' → kio
'/usr/share/dbus-1/services/org.kde.kssld5.service' → kio
'/usr/share/kconf_update/filepicker.upd' → kio
'/etc/xdg/autostart/baloo_file.desktop' → baloo-kf5
'/usr/lib/systemd/user/kde-baloo.service' → baloo-kf5
'/usr/share/plasma/desktoptheme/breeze-dark/colors' → plasma-framework
'/usr/share/plasma/desktoptheme/breeze-dark/metadata.json' →
plasma-framework
'/usr/share/plasma/desktoptheme/breeze-dark/plasmarc' → plasma-framework
'/usr/share/plasma/desktoptheme/breeze-light/colors' → plasma-framework
'/usr/share/plasma/desktoptheme/breeze-light/metadata.json' →
plasma-framework
'/usr/share/plasma/desktoptheme/breeze-light/plasmarc' → plasma-framework
'/usr/share/plasma/desktoptheme/default/dialogs/background.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/akonadi.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/akregator.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/amarok.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/applications.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/apport.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/audio.svgz' → plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/battery.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/bookmarks.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/cantata.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/computer.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/configure.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/device.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/disk.svgz' → plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/distribute.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/document.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/drive.svgz' → plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/edit.svgz' → plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/fcitx.svgz' → plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/go.svgz' → plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/ime.svgz' → plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/input.svgz' → plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/kalarm.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/kdeconnect.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/keyboard.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/kget.svgz' → plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/kgpg.svgz' → plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/kleopatra.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/klipper.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/kmail.svgz' → plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/konv_message.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/konversation.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/kopete.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/korgac.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/kpackagekit.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/kruler.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/kteatime.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/ktorrent.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/kup.svgz' → plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/list.svgz' → plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/mail.svgz' → plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/media.svgz' → plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/mobile.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/network.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/notification.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/osd.svgz' → plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/phone.svgz' → plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/plasmavault.svgz' →
plasma-framework
'/usr/share/plasma/desktoptheme/default/icons/plasmavault_error.

Re: Phonon Backends

[Jonathan Riddell]

Indeed, we seem to have the capitalised headers but lower-case "phonon"
includes back with the changes Harald has recently made, phonon-vlc and
dolphin etc now compile again.  Qt 5 and Qt 6 now seem to need separate
compiles.

Jonathan


On Fri, 21 Jul 2023 at 10:20, Volker Krause  wrote:

> On Wednesday, 19 July 2023 16:46:55 CEST Jonathan Riddell wrote:
> > Hola, I see Volker has stopped installing the capitalised headers for
> > Phonon.
> >
> > This breaks the build of phonon-vlc.  Are there any plans to update it?
>
> phonon-vlc uses lower-case namespace includes, so I rather suspect this is
> unintended fallout from https://invent.kde.org/libraries/phonon/-/
> merge_requests/14
> <https://invent.kde.org/libraries/phonon/-/merge_requests/14> which
> should have been fixed meanwhile.
>
> Adding a Qt6 CI job for phonon-vlc would also help I guess.
>
> Regards,
> Volker

Phonon Backends

[Jonathan Riddell]

Hola, I see Volker has stopped installing the capitalised headers for
Phonon.

This breaks the build of phonon-vlc.  Are there any plans to update it?

(I'm not sure if this is the right place to discuss Phonon.)

Jonathan

KF6 overlapping files

[Jonathan Riddell]

I thought I'd give an update on current overlapping files since our
automated setup isn't running just now..

 kf6-kxmlgui (0.0+p22.04+tunstable+git20230708.0126-0) over
(0.0+p22.04+tunstable+git20230701.0107-0) ...
'/etc/xdg/ui/ui_standards.rc' libkf5xmlgui-data

 kf6-kio (0.0+p22.04+tunstable+git20230711.0449-0) over
(0.0+p22.04+tunstable+git20230703.0257-0) ...
'/etc/xdg/accept-languages.codes' kio
'/etc/xdg/kshorturifilterrc' kio
'/usr/bin/kcookiejar5' kio
'/usr/share/dbus-1/services/org.kde.kcookiejar5.service' kio
'/usr/share/dbus-1/services/org.kde.kiod5.service' kio
'/usr/share/dbus-1/services/org.kde.kioexecd.service' kio
'/usr/share/dbus-1/services/org.kde.kpasswdserver.service' kio
'/usr/share/dbus-1/services/org.kde.kssld5.service' kio
'/usr/share/kconf_update/filepicker.upd' kio

 kf6-baloo (0.0+p22.04+tunstable+git20230711.0216-0) over
(0.0+p22.04+tunstable+git20230701.0101-0) ...
'/etc/xdg/autostart/baloo_file.desktop' baloo-kf5
'/usr/lib/systemd/user/kde-baloo.service' baloo-kf5

 kf6-kglobalaccel-dev (0.0+p22.04+tunstable+git20230705.0803-0) over
(0.0+p22.04+tunstable+git20230701.0128-0) ...
'/usr/share/dbus-1/interfaces/kf5_org.kde.KGlobalAccel.xml'
libkf5globalaccel-dev
'/usr/share/dbus-1/interfaces/kf5_org.kde.kglobalaccel.Component.xml'
libkf5globalaccel-dev

 kf6-kwallet (0.0+p22.04+tunstable+git20230708.0144-0) over
(0.0+p22.04+tunstable+git20230703.0249-0) ...
'/usr/bin/kwallet-query' libkf5wallet-bin
'/usr/bin/kwalletd5' libkf5wallet-bin
'/usr/share/applications/org.kde.kwalletd5.desktop' libkf5wallet-bin
'/usr/share/dbus-1/services/org.kde.kwalletd5.service' libkf5wallet-bin
'/usr/share/man/man1/kwallet-query.1.gz' libkf5wallet-bin


 kf6-knotifications-dev (0.0+p22.04+tunstable+git20230708.0123-0) over
(0.0+p22.04+tunstable+git20230703.0121-0) ...
'/usr/share/dbus-1/interfaces/kf5_org.kde.StatusNotifierItem.xml'
libkf5notifications-dev
'/usr/share/dbus-1/interfaces/kf5_org.kde.StatusNotifierWatcher.xml'
libkf5notifications-dev

 kf6-kguiaddons (0.0+p22.04+tunstable+git20230711.0102-0) over
(0.0+p22.04+tunstable+git20230701.0112-0) ...
'/usr/bin/kde-geo-uri-handler' libkf5guiaddons-bin
'/usr/share/applications/google-maps-geo-handler.desktop'
libkf5guiaddons-data
'/usr/share/applications/openstreetmap-geo-handler.desktop'
libkf5guiaddons-data
'/usr/share/applications/qwant-maps-geo-handler.desktop'
libkf5guiaddons-data
'/usr/share/applications/wheelmap-geo-handler.desktop' libkf5guiaddons-data

 kf6-kauth (0.0+p22.04+tunstable+git20230705.0759-0) over
(0.0+p22.04+tunstable+git20230630.0252-0) ...
'/usr/share/dbus-1/system.d/org.kde.kf5auth.conf' libkf5auth-data

Re: KCGroups in KDEreview

[Jonathan Riddell]

I opened an issue in line with the new kdereview process

https://invent.kde.org/libraries/kcgroups/-/issues/1

Jonathan


On Sat, 21 Nov 2020 at 00:38, Albert Astals Cid  wrote:

> El divendres, 20 de novembre de 2020, a les 14:55:16 CET, Henri Chain va
> escriure:
> > Hello everyone,
> >
> > KCgroups has been moved to KDEReview !
> > What is that, you ask ? It's a library that wraps the systemd dbus API
> to
> > expose a higher-level concept of desktop application and allow control
> of its
> > system resource usage (CPU, RAM, IO, etc).
> >
> > It relies on the recent ability of plasma to launch applications in
> their own
> > systemd scopes, with correspond to cgroups and provides a more robust
> > definition for an application (more details at
> https://lwn.net/Articles/834329/
> > ) .
> >
> > The main use of the library is to expose related resource control
> settings for
> > those applications, at a user space level that other KDE applications
> and
> > frameworks can use, including consumption straight from QML as
> demonstrated in
> > the test application.
> >
> > KCgroups is intended to become a (Tier 1) framework. A first user of
> this
> > library might be the foreground window CPU booster daemon that is
> available
> > here:
> https://invent.kde.org/libraries/kcgroups/-/tree/work/foreground-booster
> >
> > Packages are already available for both Neon and Arch Linux.
> >
> > Looking forward to your feedback and ideas for using this,
>
> I'm a bit scared about your optional class being there all in the main
> namespace. I'd suggest putting in some "namespace kcgroups{}" or name it
> kcgoptional or something.
>
> you have a few properties without NOTIFY, ideally you should either add it
> if they can change or mark them as CONSTANT if they can't.
>
> Cheers,
>   Albert
>
>
> > Henri
> >
> >
> >
>
>
>
>
>

Re: version numbers towards kf6

[Jonathan Riddell]

Use whatever you like for your distro but for neon we have the not very
elegant

5.92.0+p22.04+tunstable+git20230613.2104-0 for git master frameworks build

frameworks version, ubuntu version, neon edition, date.time, build number.

Of course the frameworks version is meaningless there, it's just where I
took the first packaging from, I'll update that once the frameworks get
releases.

Jonathan

Re: kf6 deconflictor progress

[Jonathan Riddell]

I've updated the deconflictor now

https://build.neon.kde.org/job/test_kf6_deconflictor/lastSuccessfulBuild/artifact/conflict-report.json/*view*/

On Tue, 2 May 2023 at 09:35, David Edmundson 
wrote:

> On Fri, Apr 28, 2023 at 5:59 PM Jonathan Riddell  wrote:
> >
> > The deconflictor job we run in neon still has a bunch of files
> overlapping between kf5 and kf6
> >
> > https://build.neon.kde.org/job/test_kf6_deconflictor/
> >
> >
> https://build.neon.kde.org/job/test_kf6_deconflictor/9/artifact/conflict-report.json/*view*/
> >
> > Is there any progress being made in fixing this?
>
> Any, yes.
> Obviously it's not done yet.
>
> I'm not sure this report is up to date:
>
> "/usr/kf6/bin/kglobalaccel5",
> "/usr/bin/kglobalaccel5"
>
> I can't see us installing that.
>
> > We'd like to move the neon packages into /usr which would break our
> deconflicting report job.
>
> You know how to make progress faster :)
>
> > Jonathan
> >
>

kf6 deconflictor progress

[Jonathan Riddell]

The deconflictor job we run in neon still has a bunch of files overlapping
between kf5 and kf6

https://build.neon.kde.org/job/test_kf6_deconflictor/

https://build.neon.kde.org/job/test_kf6_deconflictor/9/artifact/conflict-report.json/*view*/

Is there any progress being made in fixing this?

We'd like to move the neon packages into /usr which would break our
deconflicting report job.

Jonathan

Re: kf6 vs. kf5 conflict report

[Jonathan Riddell]

Also from kxmlgui is a clash
/etc/xdg/ui/ui_standards.rc

Jonathan

kirigami2 and oxygen-icons5 in kf6

[Jonathan Riddell]

A while ago it was agreed that tars and git repos should have the same
names, which does many everyone's life easier.

https://markmail.org/message/jr4za6d7c2n7bw73#query:+page:1+mid:z67hzcbjmx5brqiv+state:results

There's one outlier which is kirigami where the tar is named kirigami2
https://invent.kde.org/frameworks/kirigami

That was to make it co-installable with kirigami 1 but nothing uses that
now so it can be dropped.  Can I suggest renaming "kirigami2" tar to be
"kirigami" again?

Another place where version numbers are used in the git/tar name is
oxygen-icons
https://invent.kde.org/frameworks/oxygen-icons5
I can't even remember why that has the 5 in it but now that Qt5 support is
dropped it seems obsolete, can I suggest renaming this to "oxygen-icons"?

Jonathan

Re: portings aids in kf6?

[Jonathan Riddell]

On Thu, 26 Jan 2023 at 17:02, Volker Krause  wrote:

>
> And add KEmoticons to that list, that's also deprecated (but not marked as
> a
> porting aid).


[:'-(

portings aids in kf6?

[Jonathan Riddell]

Can the team say which, if any, porting aids will continue in kf6?

KDELibs4Support
KDesignerPlugin
KDEWebKit
KHtml
KJS
KJsEmbed
KMediaPlayer
Kross
KXmlRpcClient

kquickcharts

[Jonathan Riddell]

*What might need doing for me to compile kquickcharts master branch?*




*https://build.neon.kde.org/job/jammy_unstable_kf6_kquickcharts_bin_amd64/25/console
15:51:32*
[ 29%] Building CXX object
src/CMakeFiles/QuickChartsStatic.dir/datasource/ModelHistorySource.cpp.o*15:51:35*
In file included from
/usr/include/c++/11/bits/stl_algobase.h:71,*15:51:35*
from /usr/include/c++/11/array:40,*15:51:35*  from
/usr/include/c++/11/tuple:39,*15:51:35*  from
/usr/include/x86_64-linux-gnu/qt6/QtCore/qtypeinfo.h:9,*15:51:35*
from
/usr/include/x86_64-linux-gnu/qt6/QtCore/qglobal.h:1397,*15:51:35*
 from
/usr/include/x86_64-linux-gnu/qt6/QtCore/qcontainertools_impl.h:14,*15:51:35*
 from
/usr/include/x86_64-linux-gnu/qt6/QtCore/qhash.h:8,*15:51:35*
from 
/usr/include/x86_64-linux-gnu/qt6/QtCore/qabstractitemmodel.h:8,*15:51:35*
 from
/usr/include/x86_64-linux-gnu/qt6/QtCore/QAbstractItemModel:1,*15:51:35*
 from
/workspace/build/src/datasource/ModelSource.h:11,*15:51:35*
  from /workspace/build/src/datasource/ModelHistorySource.h:11,*15:51:35*
 from
/workspace/build/src/datasource/ModelHistorySource.cpp:8:*15:51:35*
/usr/include/c++/11/bits/predefined_ops.h: In instantiation of
‘constexpr bool
__gnu_cxx::__ops::_Iter_less_iter::operator()(_Iterator1, _Iterator2)
const [with _Iterator1 = QList::const_iterator; _Iterator2 =
QList::const_iterator]’:*15:51:35*
/usr/include/c++/11/bits/stl_algo.h:5624:12:   required from
‘constexpr _ForwardIterator std::__min_element(_ForwardIterator,
_ForwardIterator, _Compare) [with _ForwardIterator =
QList::const_iterator; _Compare =
__gnu_cxx::__ops::_Iter_less_iter]’*15:51:35*
/usr/include/c++/11/bits/stl_algo.h:5648:43:   required from
‘constexpr _FIter std::min_element(_FIter, _FIter) [with _FIter =
QList::const_iterator]’*15:51:35*
/workspace/build/src/datasource/ModelHistorySource.cpp:53:29:
required from here*15:51:35*
/usr/include/c++/11/bits/predefined_ops.h:45:23: error: no match for
‘operator<’ (operand types are ‘const QVariant’ and ‘const
QVariant’)*15:51:35*45 |   { return *__it1 < *__it2;
}*15:51:35*   |~~~^~~~

kitemmodels kf6 build failure

[Jonathan Riddell]

Building kitemmodels I get this failure, where might it have gone?

*15:27:15* [ 86%] Building CXX object
src/qml/CMakeFiles/itemmodelsplugin.dir/plugin.cpp.o*15:27:15* In file
included from /workspace/build/src/qml/plugin.cpp:17:*15:27:15*
/workspace/build/src/qml/kconcatenaterowsproxymodel_qml.h:11:10: fatal
error: KConcatenateRowsProxyModel: No such file or directory*15:27:15*
   11 | #include *15:27:15*   |
  ^~~~

beware KF5 5.100 version checks

[Jonathan Riddell]

This week I got most confused by files moving around again in our
packages.  It turns out several apps have checks on ECM version for new
KDEInstallDirs that were added around ECM 5.57.  If the app uses

if(${ECM_VERSION} STRGREATER "5.57.0")

It will break with KF5 5.100

Instead it should use

if(${ECM_VERSION} VERSION_GREATER "5.57.0")

Or just depend on a newer ECM version, a few apps we've found had these
broken version checks but depended on a newer ECM version anyway so the
test can be removed.

Examples:
https://invent.kde.org/office/tellico/-/merge_requests/6/diffs
https://invent.kde.org/graphics/okular/-/merge_requests/666/diffs

Jonathan

Frameworks 5 releases for 2022

[Jonathan Riddell]

I've created a schedule of releases for KF5 for 2022 using the
second-saturday as previously.

https://community.kde.org/Schedules/Frameworks

(I did this because it's needed for Plasma releases.)  I've added it to
phab and my google calendar.

https://calendar.google.com/calendar/u/0?cid=MDMxZ2tncWcxaGpmOGxjbWowZW0xZDJzajhAZ3JvdXAuY2FsZW5kYXIuZ29vZ2xlLmNvbQ
https://phabricator.kde.org/calendar/query/KhNLCxe1xjoI/2021/11/

This is presumably all subject to changes if and when KF6 development means
it's no longer worth releasing KF5.

Jonathan

Re: Would distributions have an issue if KF 5.77+ would require Qt >= 5.14 (instead of >= 5.13 as of now)?

[Jonathan Riddell]

Not from KDE neon of course, we're on 5.15.  And not from the KDE snaps
build either.  But I suppose there's more than just Linux distros to
consider as we ship apps using KDE frameworks on Flatpak, Android, Windows,
even Mac to ponder too.

Jonathan


On Tue, 1 Dec 2020 at 12:14, Friedrich W. H. Kossebau 
wrote:

> Hi,
>
> last week KDE Frameworks master saw a bump in the required/expected
> minimal Qt
> version to Qt 5.13, following rules once agreed and noted here:
> https://community.kde.org/Frameworks/Policies#Frameworks_Qt_requirements
>
> I would like to challenge that former decision though and propose to
> instead
> go straight to Qt 5.14 as minimum requirement now.
>
>
> QUESTION:
> Would any of the distributions have an issue with requiring Qt 5.14
> instead of
> Qt 5.13?
>
>
> From some quick checks using https://repology.org/ it seems that any
> distribution versions which currently use Qt 5.13 have also settled on
> some
> older KF version, so will not update to just KF 5.77 and thus be screwed.
>
> Motivation:
> * KDE CI not setup ATM to cover builds with Qt 5.13 (no build, no unit
> tests)
> * Qt 5.14 added some new API, chance to miss out when using that in new
> code
> * C++: no need to write #if QT_VERSION < QT_VERSION_CHECK(5, 14, 0)
> variants
> * QML: no need to do hard-to-read generation tricks to support < Qt 5.14
> * Qt 5.13 went out-of-support in June
> * App bundle builders would rather use some recent Qt 5.14/5.15
>
> So by restraining to Qt 5.13 as minimum version IMHO we would make/keep
> life
> complicated for KF contributors without adding any value for anyone.
>
> With most of KDE Frameworks in my local checkout:
> grep "QT_VERSION_CHECK(5, 14, 0)"  frameworks/*/src -r 2>/dev/null | \
> grep "QT_VERSION " | wc -l
> gives me "92", so there are quite some code variants which need support in
> current code.
>
> From the emails at least in
> https://mail.kde.org/pipermail/kde-frameworks-devel/2020-July/112712.html
> I could not see a discussion whether Qt 5.13 makes
> sense at all now, seems mainly the algorithm was applied. I propose to
> match
> the result to known real world needs now. Or teach me what I have missed
> here
> :)
>
> Cheers
> Friedrich
>
>
>

Frameworks releases in 2021

[Jonathan Riddell]

The future is nearly here so I've updated the Frameworks release schedule
for 2021 based on the same first + second saturday of the month formula.

https://community.kde.org/Schedules/Frameworks
https://phabricator.kde.org/calendar/
https://calendar.google.com/calendar?cid=MDMxZ2tncWcxaGpmOGxjbWowZW0xZDJzajhAZ3JvdXAuY2FsZW5kYXIuZ29vZ2xlLmNvbQ

Jonathan

xml_mimetypes5 and kcoreaddons

[Jonathan Riddell]

We're playing with translations in neon packages and looking at kcoreaddons
the tars have
xml_mimetypes5
But we can't see anything in the code which uses this.  Do these
translations get used?

Jonathan

D29374: UK, Scotland: Fix syntax error by adding category of Early May Bank Holiday

[Jonathan Riddell]

jriddell added a comment.


  thanks :)

REPOSITORY
  R175 KHolidays

REVISION DETAIL
  https://phabricator.kde.org/D29374

To: weisi, winterz
Cc: jriddell, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

Re: Quick Charts in KDE Review

[Jonathan Riddell]

There's a file called LICENSE which contains a copy of the LGPL 2.1

But all the files with an explicit licence seem to be GPL 2+3+KDEeV

Please decide which licence you want to apply and if it's GPL 2+3+KDEeV
remove LICENSE and put a copy of the GPL 2 called COPYING which is our
normal practice.

Jonathan

On Mon, 21 Oct 2019 at 14:39, Arjen Hiemstra  wrote:

> Hi,
>
> Quick Charts has been moved to KDE review. The intent is to make it a
> Tier 1 framework.
>
> Quick Charts is a QML module that implements a set of high-performance,
> GPU accelerated
> charts. Currently the main user of it is a new KSysGuard UI I have been
> working on, but
> once it is part of Frameworks I also hope to convert several bits of
> Plasma to using it.
>
> - Arjen
>

D21063: Symlink arrow-*-double to go-*-skip

[Jonathan Riddell]

jriddell added a comment.


  I've reverted this commit as it breaks compilation
  
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/78/console
  [ 79%] Generating res/breeze-icons.qrc
  15:58:48  Error copying directory from 
"/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 SUSEQt5.12/icons" to 
"/home/jenkins/workspace/Frameworks/breeze-icons/kf5-qt5 
SUSEQt5.12/build/icons/res".
  
  
https://build.kde.org/job/Frameworks/job/breeze-icons/job/kf5-qt5%20SUSEQt5.12/

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D21063

To: ndavis, #vdg, ngraham
Cc: jriddell, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

This revision was automatically updated to reflect the committed changes.
Closed by commit R299:2e8ce30c9498: handle wrong password when using sudo which 
asks for another password (authored by jriddell).

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=49986&id=49988

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/config-kdesutest.h.cmake
  autotests/kdesutest.cpp
  autotests/su
  autotests/sudo
  src/suprocess.cpp

To: jriddell, sitter, fvogt
Cc: starbuck, fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell updated this revision to Diff 49986.
jriddell added a comment.


  Don't use friend class

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=49459&id=49986

BRANCH
  arcpatch-D10716

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/config-kdesutest.h.cmake
  autotests/kdesutest.cpp
  autotests/su
  autotests/sudo
  src/suprocess.cpp

To: jriddell, sitter, fvogt
Cc: starbuck, fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell marked an inline comment as done.

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter, fvogt
Cc: starbuck, fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell marked 3 inline comments as done.

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter, fvogt
Cc: starbuck, fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell updated this revision to Diff 49459.
jriddell added a comment.


  - make test lgpl, link configcore instead of service

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=49457&id=49459

BRANCH
  arcpatch-D10716

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/config-kdesutest.h.cmake
  autotests/kdesutest.cpp
  autotests/su
  autotests/sudo
  src/suprocess.cpp
  src/suprocess.h

To: jriddell, sitter, fvogt
Cc: starbuck, fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell updated this revision to Diff 49457.
jriddell added a comment.


  - style fixes whitespace

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=49456&id=49457

BRANCH
  arcpatch-D10716

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/config-kdesutest.h.cmake
  autotests/kdesutest.cpp
  autotests/su
  autotests/sudo
  src/suprocess.cpp
  src/suprocess.h

To: jriddell, sitter, fvogt
Cc: starbuck, fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell updated this revision to Diff 49456.
jriddell added a comment.


  - make string const, follow normal code style of pointer * being with 
variable name not the type

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=49454&id=49456

BRANCH
  arcpatch-D10716

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/config-kdesutest.h.cmake
  autotests/kdesutest.cpp
  autotests/su
  autotests/sudo
  src/suprocess.cpp
  src/suprocess.h

To: jriddell, sitter, fvogt
Cc: starbuck, fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell updated this revision to Diff 49454.
jriddell added a comment.


  - revert enum, make strings const, add licence header

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=49442&id=49454

BRANCH
  arcpatch-D10716

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/config-kdesutest.h.cmake
  autotests/kdesutest.cpp
  autotests/su
  autotests/sudo
  src/suprocess.cpp
  src/suprocess.h

To: jriddell, sitter, fvogt
Cc: starbuck, fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell updated this revision to Diff 49442.
jriddell marked 2 inline comments as done.
jriddell added a comment.


  - Just use 0 instead - the enum isnt meant for that apparently.

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=49440&id=49442

BRANCH
  arcpatch-D10716

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/config-kdesutest.h.cmake
  autotests/kdesutest.cpp
  autotests/su
  autotests/sudo
  src/suprocess.cpp
  src/suprocess.h

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell marked an inline comment as done.

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell updated this revision to Diff 49440.
jriddell added a comment.


  - only build tests if BUILD_TESTING is set
  - use QStringLiteral

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=49244&id=49440

BRANCH
  arcpatch-D10716

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/config-kdesutest.h.cmake
  autotests/kdesutest.cpp
  autotests/su
  autotests/sudo
  src/suprocess.cpp
  src/suprocess.h

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell marked an inline comment as done.
jriddell added inline comments.

INLINE COMMENTS

> fvogt wrote in suprocess.h:75
> Still necessary?

yes
autotests/kdesutest.cpp:40:45: error: ‘KDESu::SuProcess::SuErrors ok’ is 
private within this context

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell added inline comments.

INLINE COMMENTS

> fvogt wrote in su:28
> That won't work anywhere else and requires that the binary is installed when 
> running tests.

Not sure what you mean by won't work anywhere else, it'll work using the 
kdesu_stub which is built by the local compile.  It doens't need kdesu_stub to 
be installed.

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell marked 3 inline comments as done.

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell marked an inline comment as done.
jriddell added a comment.


  > Is it necessary to write the mock su/sudo in python? That introduces a big 
and mostly unnecessary dependency on python.
  
  Nope but that's what was easiest for me and I'm out of energy for this
  
  > By adding a new constructor to SuCommand which allows to specify the full 
path to su/sudo, testing would be much easier. It might be usable outside of 
the tests as well.
  
  I looked at that but I'd be scared of introducing binary incompatiblity.  
This approach covers the current needs.
  
  > The testcases would be simpler if it used QTESTDATA and rows for the 
su/sudo and correct/incorrect password cases
  
  Something else I need to learn about.

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell updated this revision to Diff 49244.
jriddell added a comment.


  - remove unused variable
  - remove unused include
  - use QStandardPaths::setTestModeEnabled
  - tidy up includes and defines
  - refactor out config setting to remove duplication

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=49175&id=49244

BRANCH
  arcpatch-D10716

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/config-kdesutest.h.cmake
  autotests/kdesutest.cpp
  autotests/su
  autotests/sudo
  src/suprocess.cpp
  src/suprocess.h

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell updated this revision to Diff 49175.
jriddell added a comment.


  - set XDG_CONFIG_HOME to put kdesutestrc not in running users config dir

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=49173&id=49175

BRANCH
  arcpatch-D10716

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/config-kdesutest.h.cmake
  autotests/kdesutest.cpp
  autotests/su
  autotests/sudo
  src/suprocess.cpp
  src/suprocess.h

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell updated this revision to Diff 49173.
jriddell added a comment.


  - write out path to kdesu_stub and su command from the tests to a config 
rather than setting it within the suprocess class, allows for other testing 
possibilities and binary relateability

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=49164&id=49173

BRANCH
  arcpatch-D10716

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/config-kdesutest.h.cmake
  autotests/kdesutest.cpp
  autotests/su
  autotests/sudo
  src/suprocess.cpp
  src/suprocess.h

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell updated this revision to Diff 49164.
jriddell added a comment.


  - in stub su and sudo use passed argument to find kdesu_stub and in suprocess 
pass local kdesu_stub for test mode

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=49163&id=49164

BRANCH
  arcpatch-D10716

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/config-kdesutest.h.cmake
  autotests/kdesutest.cpp
  autotests/su
  autotests/sudo
  src/suprocess.cpp
  src/suprocess.h

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell updated this revision to Diff 49163.
jriddell added a comment.


  - use locally built kdesu_stub

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=49091&id=49163

BRANCH
  arcpatch-D10716

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/config-kdesutest.h.cmake
  autotests/kdesutest.cpp
  autotests/su.cmake
  autotests/sudo.cmake
  src/suprocess.cpp
  src/suprocess.h

To: jriddell, sitter, fvogt
Cc: fvogt, kde-frameworks-devel, michaelh, ngraham, bruns

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell updated this revision to Diff 49091.
jriddell added a comment.


  - add a stub sudo for testing

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=27859&id=49091

BRANCH
  arcpatch-D10716

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/config-kdesutest.h.cmake
  autotests/kdesutest.cpp
  autotests/su
  autotests/sudo
  src/suprocess.cpp
  src/suprocess.h

To: jriddell, sitter
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

Re: KDE Frameworks web page

[Jonathan Riddell]

On Tue, Dec 11, 2018 at 11:01:22AM +0300, Alexander Potashev wrote:
> пн, 10 дек. 2018 г. в 16:43, Jonathan Riddell :
> >
> > Frameworks has no web page and the announcements still point to the
> > 5.0 announcement for more information.
> >
> > So here's a proposal for adding to kde.org/products/
> >
> > https://www.kde.org/products/frameworks/
> 
> Hi,
> 
> Nice work!
> 
> Now nitpicking:
> 
> 1. The titles ending in fullstop look weird:
> "Features."
> "Organisation."
> "Get The Frameworks."

Changed that (it was copying what was on the kirigami page).

> 2. Text on the blue grid under "Organisation" is not very readable.

Works for me.  Again it's copying what's on the Kirigami page.  Suggestions 
welcome but the page needs some colour to break it up.

> 
> 3. I heard that "organisation" is British English, should be
> "organiZation" for the US variant.

Fixed

> 4. Can't find no direct link nor straightforward way to go to Git
> repos or download source tarballs. I think these must be easy to
> access, since KF5 is a developer-oriented product.

I added 'download' to the release announcement link which seems to be
the best way to point the visitor to the newest release.

KDE Frameworks web page

[Jonathan Riddell]

Frameworks has no web page and the announcements still point to the
5.0 announcement for more information.

So here's a proposal for adding to kde.org/products/

https://www.kde.org/products/frameworks/

Are the highlights still the best we can choose?

Are there any example applications we can show using a KDE Framework
outwith KDE?

There's links at the bottom for getting the frameworks, are they the best ones?

Phab item:
https://phabricator.kde.org/T10175

Jonathan

Re: Framework Announcement Webpages

[Jonathan Riddell]

I found the template, here's an update for the new design

On Tue, 20 Nov 2018 at 10:09, Jonathan Riddell  wrote:
>
> Hola David, the Framework announcement webpages still use the old
> website theme.  Can I help in updating it to the new theme? I'm not
> sure the process in creating the pages.
>
> https://www.kde.org/announcements/kde-frameworks-5.51.0.php
>
> Jonathan
Index: kde-frameworks-template.bottom
===
--- kde-frameworks-template.bottom	(revision 1526711)
+++ kde-frameworks-template.bottom	(working copy)
@@ -51,5 +51,7 @@
 
 
+
+ "Release of KDE Frameworks 5.1.0",
+'cssFile' => '/content/home/portal.css'
+]);
+
+require('../aether/header.php');
+$site_root = "../";
+$release = '5.1.0';
 ?>
 
+
+
+
 

Framework Announcement Webpages

[Jonathan Riddell]

Hola David, the Framework announcement webpages still use the old
website theme.  Can I help in updating it to the new theme? I'm not
sure the process in creating the pages.

https://www.kde.org/announcements/kde-frameworks-5.51.0.php

Jonathan

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

[Jonathan Riddell]

jriddell added a comment.


  I can recreate the problem with 1.3 branch build of kdeconnect-kde in a 
virtualmachine install of KDE neon user edition
  The problem remains when building and installing it with the D16692 
 patch
  
  Building 1.3 branch on KDE neon developer edition I can not recreate the 
problem.  So the problem may be in some other area such as kio framework.

REPOSITORY
  R224 KDE Connect

REVISION DETAIL
  https://phabricator.kde.org/D16692

To: eduisters, #kde_connect, #frameworks, albertvaka
Cc: jriddell, nicolasfella, albertvaka, kdeconnect, shivanshukantprasad, 
skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, 
yannux, Danial0_0, johnq, Pitel, adeen-s, SemperPeritus, daniel.z.tg, jeanv, 
seebauer, bugzy, MayeulC, menasshock, tctara, apol

Re: ABI break in KNewStuff

[Jonathan Riddell]

Now reverted

On Sat, 15 Sep 2018 at 11:56, David Edmundson
 wrote:
>
> >2ad3e66d81b63495a59d012f673af7bd854b53d7 is not included in the latest 
> >KNewStuff release 5.50,
>
> Oh. Thank goodness for people running various CI builds.
> @packagers, sorry for the noise
>
> @Jonathan
> That's handy. Go ahead and revert.

Re: ABI break in KNewStuff

[Jonathan Riddell]

On Fri, Sep 14, 2018 at 06:05:26PM +0100, David Edmundson wrote:
> Packagers,
> 
> There's an ABI break in KNewStuff 5.55
> 
> (2ad3e66d81b63495a59d012f673af7bd854b53d7)
> 
> It's released now, I don't think we have any option as fixing it would mean we
> have 2 ABI breaks.
> 
> Can people please rebuild everything that depends on it. Especially
> plasma-discover.
> 
> See https://bugs.kde.org/398412 which is getting multiple reports a day.

2ad3e66d81b63495a59d012f673af7bd854b53d7 is not included in the latest 
KNewStuff release 5.50, it can be safely reverted from Git

Jonathan

D13302: check for needed version of libavcode, libavformat and libavutil

[Jonathan Riddell]

jriddell accepted this revision.
jriddell added a comment.
This revision is now accepted and ready to land.


  latest patch works well in neon

REPOSITORY
  R286 KFileMetaData

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13302

To: mgallien, romangg, adridg, jriddell
Cc: jriddell, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns

Re: KDE Frameworks 5.47.0

[Jonathan Riddell]

On Sat, Jun 02, 2018 at 09:57:08PM +0200, David Faure wrote:
> Dear packagers,
> 
> KDE Frameworks 5.47.0 has been uploaded to the usual place.

KFileMetaData continues not to compile

Jonathan

Re: kfilemetadata compile failure

[Jonathan Riddell]

On Thu, Apr 26, 2018 at 08:31:46AM +0200, Kevin Funk wrote:
> On Wednesday, 25 April 2018 14:34:58 CEST Jonathan Riddell wrote:
> > kfilemetadata does not compile in KDE neon from git master currently
> > 
> > /workspace/build/src/extractors/ffmpegextractor.cpp:97:15: error:
> > ‘AVCodecParameters’ does not name a type
> > 12:27:35  const AVCodecParameters* codec = stream->codecpar;
> > 
> > https://build.neon.kde.org/job/xenial_unstable_kde_kfilemetadata_bin_amd64/1
> > 45/console
> 
> Raised a concern on the resp. Phab Diff (to ping the responsible people):
>   https://phabricator.kde.org/R286:037208a787e0c2412ab616ff1573c323a2346d2d

This compile failure is still in the shortly to be released kfilemetadata tar

https://build.neon.kde.org/job/xenial_release_kde_kfilemetadata_bin_amd64/37/console
14:11:40 /workspace/build/src/extractors/ffmpegextractor.cpp:97:15: error: 
‘AVCodecParameters’ does not name a type
14:11:40  const AVCodecParameters* codec = stream->codecpar;

Jonathan

k18n 5.45 update

[Jonathan Riddell]

Could we get a .1 update to k18n to include this fix?

https://cgit.kde.org/ki18n.git/commit/?id=9c32bdab29b345976eee3b9c1c4bebd76cdcdde2
https://phabricator.kde.org/D12216

It is causing issue with some packager of plasma-workspace 5.12.5

Jonathan

kfilemetadata compile failure

[Jonathan Riddell]

kfilemetadata does not compile in KDE neon from git master currently

/workspace/build/src/extractors/ffmpegextractor.cpp:97:15: error:
‘AVCodecParameters’ does not name a type
12:27:35  const AVCodecParameters* codec = stream->codecpar;

https://build.neon.kde.org/job/xenial_unstable_kde_kfilemetadata_bin_amd64/145/console

It may be expecting a newer version of ffmpeg

Jonathan

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell added a comment.


  Add test.  This uses the real sudo and su on your system, I fear that 
creating a stub replacement wouldn't be necessarily a reliable recreation.  It 
does mean adding your own password.h with #defines for your user and root 
password

REPOSITORY
  R299 KDESu

REVISION DETAIL
  https://phabricator.kde.org/D10716

To: jriddell, sitter
Cc: #frameworks, michaelh

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell updated this revision to Diff 27859.
jriddell added a comment.


  - remove debugging

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=27858&id=27859

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  .gitignore
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/kdesutest.cpp
  src/suprocess.cpp
  src/suprocess.h

To: jriddell, sitter
Cc: #frameworks, michaelh

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell updated this revision to Diff 27858.
jriddell added a comment.


  - add test
  - allow passwords to be separate
  - remove debugging

REPOSITORY
  R299 KDESu

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10716?vs=27691&id=27858

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  .gitignore
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/kdesutest.cpp
  src/suprocess.cpp
  src/suprocess.h

To: jriddell, sitter
Cc: #frameworks, michaelh

D10716: handle wrong password when using sudo which asks for another password

[Jonathan Riddell]

jriddell created this revision.
jriddell added a reviewer: sitter.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
jriddell requested review of this revision.

REVISION SUMMARY
  handle wrong password when using sudo which asks for another password
  
  https://bugs.kde.org/show_bug.cgi?id=389049

TEST PLAN
  build and run with sudo and su options, test password and no, test diff 
languages

REPOSITORY
  R299 KDESu

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10716

AFFECTED FILES
  src/suprocess.cpp

To: jriddell, sitter
Cc: #frameworks, michaelh

Re: KGlobalAccel regression in latest frameworks release

[Jonathan Riddell]

I've tagged v5.38.1 and released a tar with the change reverted.  I've
not reverted it in master branch so it will need to be fixed or
reverted before 5.39.0

Jonthan

Re: KGlobalAccel regression in latest frameworks release

[Jonathan Riddell]

This patch?
https://phabricator.kde.org/D6234

I think reverting it for now and me or David can make a 5.38.1 release would be 
easiest

Jonathan


On Wed, Sep 13, 2017 at 06:23:48PM +0200, Martin Flöser wrote:
> Hi all,
> 
> unfortunately I have to inform you that KGlobalAccel has a severe
> regression [1] in the latest framework release resulting in many
> shortcuts no longer functioning.
> 
> As the current frameworks release is the one the next Plasma release
> is going to depend on, we need to act quickly. In the current state
> I would say a release of Plasma requiring this frameworks version is
> an absolute no-no, this is release blocking. I'm saying this as the
> maintainer of kglobalaccel and of the most affected application
> KWin.
> 
> Following recommendations from my side:
> * distributions who have not yet shipped out the latest frameworks
> release should hold back kglobalaccel and maybe kwindowsystem
> * in KGlobalAccel we need to get a fix for it, I'm not able to
> provide it, though.
> * Otherwise I would suggest that the change in KGlobalAccel gets
> reverted
> 
> Due to the fact that Plasma depends on this release we must act
> quickly and do a bug fix release for frameworks even if this is
> uncommon and against the practice.
> 
> Sorry for any inconveniences.
> 
> Martin Flöser
> KGlobalAccel maintainer
> 
> [1] https://bugs.kde.org/show_bug.cgi?id=384597

qqc2-desktop-style as framework

[Jonathan Riddell]

I've moved qqc2-desktop-style to frameworks from kde/workspace, please
move the translations to follow

Jonathan

D6972: Add CC BY-SA 4.0 International

[Jonathan Riddell]

jriddell accepted this revision.
jriddell added a comment.
This revision is now accepted and ready to land.


  thanks

REPOSITORY
  R238 KDocTools

BRANCH
  add-ccbysa4

REVISION DETAIL
  https://phabricator.kde.org/D6972

To: ltoscano, jriddell
Cc: jriddell, lueck, #frameworks, #documentation, skadinna

Re: Kirigami in Frameworks

[Jonathan Riddell]

On 21 June 2017 at 15:00, Marco Martin  wrote:
> As there were no replies for quite a while, i assume there are no
> particular objections.
>
> so, how to proceed? what needs to be doe to do the actual move?

Does it comply with the policies (as much as they are relevant for QML)?
https://community.kde.org/Frameworks/Policies

Get David Faure to give his approval then see what the reponse to my
"who is authorised to move repos around?" thead is.
https://marc.info/?l=kde-core-devel&m=149806172721190&w=2

Jonathan

D5615: fix include path in KF5PackageMacros.cmake

[Jonathan Riddell]

jriddell abandoned this revision.
jriddell added a comment.


  submitted

REVISION DETAIL
  https://phabricator.kde.org/D5615

To: jriddell, #frameworks, mart
Cc: apol

D5615: fix include path in KF5PackageMacros.cmake

[Jonathan Riddell]

jriddell added a comment.


  works if I add a .cmake to the end of the include() value

REVISION DETAIL
  https://phabricator.kde.org/D5615

To: jriddell, #frameworks, mart
Cc: apol

D5615: fix include path in KF5PackageMacros.cmake

[Jonathan Riddell]

jriddell updated this revision to Diff 13865.
jriddell added a comment.


  without changing include path

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5615?vs=13863&id=13865

REVISION DETAIL
  https://phabricator.kde.org/D5615

AFFECTED FILES
  KF5PackageMacros.cmake

To: jriddell, #frameworks, mart
Cc: apol

D5615: fix include path in KF5PackageMacros.cmake

[Jonathan Riddell]

jriddell created this revision.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  KF5PackageMacros.cmake uses ECM without setting the include path so it can't 
be found.  This isn't usually seen as usually something else will set the path 
before this.
  
  
http://build.neon.kde.org/job/xenial_unstable_frameworks_kpackage_lintcmake/2/console

TEST PLAN
  minimal cmakelists file which includes this file

REPOSITORY
  R290 KPackage

REVISION DETAIL
  https://phabricator.kde.org/D5615

AFFECTED FILES
  KF5PackageMacros.cmake

To: jriddell, #frameworks, mart

D5003: Update docs to Frameworks API

[Jonathan Riddell]

This revision was automatically updated to reflect the committed changes.
Closed by commit R283:91b73de5bfbc: Update docs to Frameworks API (authored by 
jriddell).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D5003?vs=12366&id=12544#toc

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5003?vs=12366&id=12544

REVISION DETAIL
  https://phabricator.kde.org/D5003

AFFECTED FILES
  src/kauthaction.h
  src/kauthactionreply.h
  src/kauthexecutejob.h
  src/kauthhelpersupport.h

To: jriddell, leinir
Cc: #frameworks

D5003: Update docs to Frameworks API

[Jonathan Riddell]

jriddell marked an inline comment as done.
jriddell added a comment.


  added some info to kauthexecutejob.h about AuthStatus
  
  data() does get the data returned by the action (not direct return I guess) 
as well as set during the action, updated.

INLINE COMMENTS

> leinir wrote in kauthexecutejob.h:82
> Returned isn't semantically right, here, though the term "helper" is a bit 
> ambiguous... What is meant by "sent by the helper" is more to the point "send 
> by the helper using HelperSupport::progressStep(QVariant)"... which is 
> somewhat clunky, but explains more properly what is going on here. Return 
> would suggest that it is only done at the end, whereas this can, 
> specifically, be done multiple times (basically, every time 
> progressStep(QVariant) is called). So... perhaps changing this to be 
> something like
> 
>   /**
>* Use this to get the data set by HelperSupport::progressStep(QVariant)
>* This function is particularly useful once the
>* job has completed. During execution, simply
>* read the data in the newData signal.
>* @see ExecuteJob::newData
>* returns the data sent by the helper
>*/

it can also be set by the return of the auth action so I mentioned both

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D5003

To: jriddell, leinir
Cc: #frameworks

D5003: Update docs to Frameworks API

[Jonathan Riddell]

jriddell updated this revision to Diff 12366.
jriddell added a comment.


  - mention statusChanged

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5003?vs=12365&id=12366

BRANCH
  docs

REVISION DETAIL
  https://phabricator.kde.org/D5003

AFFECTED FILES
  src/kauthaction.h
  src/kauthactionreply.h
  src/kauthexecutejob.h
  src/kauthhelpersupport.h

To: jriddell, leinir
Cc: #frameworks

D5003: Update docs to Frameworks API

[Jonathan Riddell]

jriddell updated this revision to Diff 12365.
jriddell marked an inline comment as done.
jriddell added a comment.


  - better description for kauthexecutejob data

REPOSITORY
  R283 KAuth

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5003?vs=12359&id=12365

BRANCH
  docs

REVISION DETAIL
  https://phabricator.kde.org/D5003

AFFECTED FILES
  src/kauthaction.h
  src/kauthactionreply.h
  src/kauthexecutejob.h
  src/kauthhelpersupport.h

To: jriddell, leinir
Cc: #frameworks

D5003: Update docs to Frameworks API

[Jonathan Riddell]

jriddell created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  Update API docs

TEST PLAN
  Read them

REPOSITORY
  R283 KAuth

BRANCH
  docs

REVISION DETAIL
  https://phabricator.kde.org/D5003

AFFECTED FILES
  src/kauthaction.h
  src/kauthactionreply.h
  src/kauthexecutejob.h
  src/kauthhelpersupport.h

To: jriddell, leinir
Cc: #frameworks

D5001: Add support for killing a KAuth::ExecuteJob

[Jonathan Riddell]

jriddell accepted this revision.
jriddell added a comment.
This revision is now accepted and ready to land.


  yep works well in my example

REPOSITORY
  R283 KAuth

REVISION DETAIL
  https://phabricator.kde.org/D5001

To: leinir, #frameworks, jriddell
Cc: jriddell

[Differential] [Accepted] D4570: [UDisks 2 Device] Add description for Floppy Disk

[Jonathan Riddell]

jriddell accepted this revision.
jriddell added a comment.
This revision is now accepted and ready to land.


  Genius, this solves the final problem in KDE and will be a killer feature in 
the next Frameworks release

REPOSITORY
  R245 Solid

REVISION DETAIL
  https://phabricator.kde.org/D4570

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, jriddell, #plasma
Cc: plasma-devel, #frameworks, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

cbz mimetype

[Jonathan Riddell]

Comic book files of the .cbz format don't want to open in Okular in
Neon dev-unstable or user now, the same has been confirmed in opensuse
tumbleweed.

I'm testing with file
http://embra.edinburghlinux.co.uk/~jr/tmp/comic.cbz  The same file
works fine in Peruse.

Looking in Dolphin it says the file is a Zip archive, could there be a
problem with the mimetype recognition?

https://bugs.kde.org/show_bug.cgi?id=374133

Jonathan

Re: Review Request 129560: More utempter path searching

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129560/
---

(Updated Nov. 28, 2016, 9:50 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Rohan Garg.


Changes
---

Submitted with commit 053ee8add12db44e6eaa68fd02e34ef1b97ba528 by Jonathan 
Riddell to branch master.


Repository: kpty


Description
---

Debian stable still has it in /usr/lib/utempter/ so search there

Also I don't think it wants to use CMAKE_PREFIX_PATH which is empty by default, 
I think this was intended to be CMAKE_INSTALL_PREFIX

old review: https://git.reviewboard.kde.org/r/129090/


Diffs
-

  cmake/FindUTEMPTER.cmake c5a1e41 

Diff: https://git.reviewboard.kde.org/r/129560/diff/


Testing
---

now it finds utempter in Debian stable (jessie)


Thanks,

Jonathan Riddell

Re: Review Request 129560: More utempter path searching

[Jonathan Riddell]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129560/
---

(Updated Nov. 25, 2016, 4:34 p.m.)


Review request for KDE Frameworks and Rohan Garg.


Repository: kpty


Description
---

Debian stable still has it in /usr/lib/utempter/ so search there

Also I don't think it wants to use CMAKE_PREFIX_PATH which is empty by default, 
I think this was intended to be CMAKE_INSTALL_PREFIX

old review: https://git.reviewboard.kde.org/r/129090/


Diffs (updated)
-

  cmake/FindUTEMPTER.cmake c5a1e41 

Diff: https://git.reviewboard.kde.org/r/129560/diff/


Testing
---

now it finds utempter in Debian stable (jessie)


Thanks,

Jonathan Riddell