D22346: Should we install bluezqt_dbustypes.h?

2019-07-09 Thread José Manuel Santamaría Lema
joselema created this revision. joselema added reviewers: drosca, mweichselbaumer. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. joselema requested review of this revision. REVISION SUMMARY Hi, while doing packaging work on bluez-qt for Kubuntu, we det

D16742: Fix iconitemtest regression

2018-11-08 Thread José Manuel Santamaría Lema
joselema closed this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16742 To: joselema, mart, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D16742: Fix iconitemtest regression

2018-11-08 Thread José Manuel Santamaría Lema
joselema added a commit: R242:ed1724c63e9f: Summary: After this commit https://cgit.kde.org/plasma-framework.git/commit/?. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D16742 To: joselema, mart, apol Cc: kde-frameworks-devel, michaelh, ngraham, brun

D16733: Capture package metadata before install start

2018-11-08 Thread José Manuel Santamaría Lema
joselema removed a commit: R242:ed1724c63e9f: Summary: After this commit https://cgit.kde.org/plasma-framework.git/commit/?. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D16733 To: davidedmundson, apol Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns

D16742: Fix iconitemtest regression

2018-11-07 Thread José Manuel Santamaría Lema
joselema created this revision. joselema added reviewers: mart, apol. Herald added a project: Frameworks. Herald removed a subscriber: Frameworks. joselema requested review of this revision. REVISION SUMMARY Hi, after this commit https://cgit.kde.org/plasma-framework.git/commit/?id=9f086

D12363: Fix autotest regression after adding SkipSwitcher to API

2018-04-19 Thread José Manuel Santamaría Lema
joselema edited the summary of this revision. REPOSITORY R278 KWindowSystem REVISION DETAIL https://phabricator.kde.org/D12363 To: joselema, graesslin, hein, sharvey Cc: rikmills, #frameworks, michaelh, bruns

D12363: Fix autotest regression after adding SkipSwitcher to API

2018-04-19 Thread José Manuel Santamaría Lema
joselema created this revision. joselema added reviewers: graesslin, hein, sharvey. joselema added a project: Frameworks. Restricted Application added a subscriber: Frameworks. joselema requested review of this revision. REVISION SUMMARY Hi, I think since this change: https://phabricator.

D12234: Update unit tests after removing "this month" and "last month" items

2018-04-19 Thread José Manuel Santamaría Lema
This revision was automatically updated to reflect the committed changes. Closed by commit R241:b526f154d0de: Update unit tests after removing "this month" and "last month" items (authored by joselema). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12234?vs=32215

D12234: Update unit tests after removing "this month" and "last month" items

2018-04-15 Thread José Manuel Santamaría Lema
joselema created this revision. joselema added a reviewer: davidedmundson. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. joselema requested review of this revision. REVISION SUMMARY Hi, I think since this change https://phabricato

D12144: Fix kpackage autotests - add donation url to test data

2018-04-15 Thread José Manuel Santamaría Lema
This revision was automatically updated to reflect the committed changes. Closed by commit R290:84f64a27fa60: Add donate urls to test data (authored by joselema). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12144?vs=31965&id=32200 REVISION DETAIL https:

D12144: Fix kpackage autotests - add donation url to test data

2018-04-12 Thread José Manuel Santamaría Lema
joselema added a subscriber: rikmills. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D12144 To: joselema, apol, aacid Cc: rikmills, #frameworks, michaelh, ngraham, bruns

D12144: Fix kpackage autotests - add donation url to test data

2018-04-12 Thread José Manuel Santamaría Lema
joselema created this revision. joselema added reviewers: apol, aacid. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. joselema requested review of this revision. REVISION SUMMARY Hi, Right now the unit tests from kpackage master br

Review Request 129628: knewstuff - install missing headers

2016-12-08 Thread José Manuel Santamaría Lema
iewboard.kde.org/r/129628/diff/ Testing --- I just ran a test from the kubuntu package meant to check that all the needed headers are available. Thanks, José Manuel Santamaría Lema

Re: Review Request 129032: Don't 'inline' public functions to avoid ABI breakage.

2016-09-28 Thread José Manuel Santamaría Lema
marked as submitted. Review request for KDE Frameworks and David Faure. Changes --- Submitted with commit 89f8bcf00fc2fc17527d7bb4e0e2aea51f8776cb by José Manuel Santamaría Lema to branch master. Repository: kio Description --- Don't 'inline' public functio

Re: Review Request 129032: Don't 'inline' public functions to avoid ABI breakage.

2016-09-26 Thread José Manuel Santamaría Lema
ine it (this includes moving a member function's body to the class definition, even without the inline keyword). The proposed patch moves the functions implementation from the .h file to the .cpp file so this way the binary compatibility is kept. Thanks, José Manuel Santamaría Lema

Re: Review Request 118263: Port polkit-kde-agent to KF5::KDELibs4Support and KF5::IconThemes

2014-07-29 Thread José Manuel Santamaría Lema
right before this one find_package(KF5 REQUIRED KDELibs4Support IconThemes) - José Manuel Santamaría Lema On Jul. 3, 2014, 8:48 a.m., Martin Bříza wrote: > > --- > This is an automatically generated e-mail. To reply,