D23619: Introduce cloning and replication of output devices

[Kamil Piwowarski]

kpiwowarski added inline comments.

INLINE COMMENTS

> outputdevice.xml:318
> + +summary="change due to hotplug of involved devices"/>
> +

It's not the same ;)

  None= 0,
  Explicit= 1 << 0,
  Hotplug = 1 << 1,
  Dpms= 1 << 2,
  Enablement  = 1 << 3

> outputdevice.xml:330
> + +summary="property switched into up state"/>
> +

> down

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23619

To: romangg, #kwin
Cc: kpiwowarski, zzag, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

[Kamil Piwowarski]

kpiwowarski abandoned this revision.
kpiwowarski added a comment.


  Fixed by R159:9b47babb6c41 


REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D10691

To: kpiwowarski, #plasma, #frameworks, hein, ivan
Cc: ivan, plasma-devel, #frameworks, ragreen, Pitel, michaelh, ZrenBot, 
ngraham, bruns, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

[Kamil Piwowarski]

kpiwowarski added a comment.


  @ivan When database is broken additionaly kactivitymanagerd is in endless 
loop of creating and closing processes. Each KF5 application prints to console 
message: "KActivities: FATAL ERROR: Failed to contact the activity manager 
daemon"
  
  Maybe it would be good to display dialog from kactivitymanagerd and ask user 
to fix (remove and create again) database instead of creating new processes 
infinitialy? It would fix the source of the problem which is broken database (I 
only wonder why the database is broken).
  
  I think that for now it's more important to fix crash and then help user to 
fix database. Additionally at this moment I think I don't have good C++ skills 
to fix that another way :(

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D10691

To: kpiwowarski, #plasma, #frameworks, hein, ivan
Cc: ivan, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10691: [kactivities-stats] Fix plasmashell crash when database is broken

[Kamil Piwowarski]

kpiwowarski retitled this revision from "Fix plasmashell crash when database is 
broken" to "[kactivities-stats] Fix plasmashell crash when database is broken".

REPOSITORY
  R159 KActivities Statistics

REVISION DETAIL
  https://phabricator.kde.org/D10691

To: kpiwowarski, #plasma, #frameworks
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10691: Fix plasmashell crash when database is broken

[Kamil Piwowarski]

kpiwowarski created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
kpiwowarski requested review of this revision.

REVISION SUMMARY
  BUG:390774

TEST PLAN
  Compiled and plasmashell doesn't crash when open kicker

REPOSITORY
  R159 KActivities Statistics

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10691

AFFECTED FILES
  src/common/database/Database.cpp

To: kpiwowarski
Cc: #frameworks, michaelh