D29502: kwidgetsaddons: Add a named colors support in KColorCombo.

hindenburg added a comment. What's the status of this? Did it get moved to invent MR? REPOSITORY R236 KWidgetsAddons BRANCH named_color_support REVISION DETAIL https://phabricator.kde.org/D29502 To: araujoluis, tcanabrava, patrickelectric, hindenburg, ngraham, #vdg Cc: kossebau, cbla

D24811: tests: fix macos build failure

This revision was automatically updated to reflect the committed changes. Closed by commit R159:196b04531764: tests: fix macos build failure (authored by hindenburg). REPOSITORY R159 KActivities Statistics CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24811?vs=68384&id=68394 REVISI

D24811: tests: fix macos build failure

hindenburg created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hindenburg requested review of this revision. REVISION SUMMARY Add boost include similiar to autotests/CMakeLists.txt TEST PLAN make && make tests bin/KActivitiesStatsTestA

D20169: Add profile support interface for TerminalInterface

This revision was automatically updated to reflect the committed changes. Closed by commit R306:11547a552d6b: Add profile support interface for TerminalInterface (authored by mschiller, committed by hindenburg). REPOSITORY R306 KParts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20

D20169: Add profile support interface for TerminalInterface

hindenburg accepted this revision. This revision is now accepted and ready to land. REPOSITORY R306 KParts BRANCH terminal-interface-profiles (branched from master) REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhauman

D20169: Add profile support interface for TerminalInterface

hindenburg edited the summary of this revision. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks, cfeck, hein Cc: dhaumann, pino, LeGast00n, michaelh, ngraham, bruns

D20169: Add profile support interface for TerminalInterface

hindenburg added a comment. In D20169#473105 , @mschiller wrote: > ping I was waiting until the next release of frameworks is out. 5.59 Sat June 1st, 2019 (expected) Sat June 8th, 2019 REPOSITORY R306 KParts REVISION DETAIL

D20169: Add profile support interface for TerminalInterface

hindenburg added a comment. I would prefer using TerminalInterfaceV2 in the current file instead of a new file. It would make using it much easier to use, document, etc and when kf6 comes out, easier to re-combine. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D201

D20169: Add profile support interface for TerminalInterface

hindenburg added a comment. Can someone from the frameworks group clarify if this can be committed for the next release 5.58 next month? I know years ago, we had a TerminalInterfaceV2 because the interface was changed. https://community.kde.org/Schedules/Frameworks REPOSITORY R306 KP

D20169: Add profile support interface for TerminalInterface

hindenburg added a reviewer: Frameworks. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D20169 To: mschiller, hindenburg, #konsole, #frameworks Cc: michaelh, ngraham, bruns

D19092: Add bison minimum version of 2.4.1 due to %code

This revision was automatically updated to reflect the committed changes. Closed by commit R309:6b46411622b0: Add bison minimum version of 2.4.1 due to %code (authored by hindenburg). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19092?vs=51902&id=55031 REV

D19092: Add bison minimum version of 2.4.1 due to %code

hindenburg added a comment. Is it OK to commit this now? It looks like the next tagging is April 6th REPOSITORY R309 KService BRANCH bison_min_version (branched from master) REVISION DETAIL https://phabricator.kde.org/D19092 To: hindenburg, #frameworks, winterz Cc: winterz, kde-frame

D19092: Add bison minimum version of 2.4.1 due to %code

hindenburg added a comment. ping? REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D19092 To: hindenburg, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19318: compile without foreach

hindenburg added a comment. There's a FOREACH still in the macpoller.cpp file REPOSITORY R274 KIdleTime REVISION DETAIL https://phabricator.kde.org/D19318 To: mlaurent, dfaure Cc: hindenburg, kde-frameworks-devel, michaelh, ngraham, bruns

D19551: [knotifications] compile without foreach

hindenburg added a comment. In D19551#436264 , @kossebau wrote: > This sadly breaks build with at least older versions of Phonon, as they have foreach loop in their public headers. Ditto, the Mac build fails here now as well due to this.

D19298: Make it compile without foreach

hindenburg added a comment. On Mac, this change gives this error (after removing -DQT_NO_FOREACH) - the recent changes did not fix the error below - f9b835c66a1facfcd6257fe84d3c7e8ead508353 builds fine. Undefin

D19298: Make it compile without foreach

hindenburg added a comment. FYI, this breaks mac building since there's a foreach in src/backends/mac/kauth-policy-gen-mac.cpp; also a few under src/backends/fake REPOSITORY R283 KAuth REVISION DETAIL https://phabricator.kde.org/D19298 To: mlaurent, dfaure Cc: hindenburg, kde-frameworks

D19092: Add bison minimum version of 2.4.1 due to %code

hindenburg added a reviewer: Frameworks. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D19092 To: hindenburg, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D19092: Add bison minimum version of 2.4.1 due to %code

hindenburg created this revision. Herald added a project: Frameworks. hindenburg requested review of this revision. REVISION SUMMARY Some Mac OS versions have bison 2.3 even though it is very old. %code is first handled in bison version 2.4; gnu site has 2.4.1 as the earliest 2.4.x version.

D16919: Re-add DBus test

hindenburg added a comment. Yes, I was actually surprised I managed to get it all to run. Are there official docs on how to setup an ci image and run applications? If not, it would be helpful. REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D16919 To: davidedmunds

D16919: Re-add DBus test

hindenburg added a comment. In D16919#364934 , @bcooksley wrote: > Yes, that is basically what the CI does so should be a pretty good method of reproducing it's results. > Did you run "make tests" / "ctest" or did you use the run-tests.py scr

D16919: Re-add DBus test

hindenburg added a comment. In D16919#364587 , @bcooksley wrote: > When you did your reproduction attempt @hindenburg did you use the binaries the CI system itself uses, or did you build Frameworks, etc yourself? I used the script in the

D16919: Re-add DBus test

hindenburg added a comment. I manage to build the docker kdeorg/ci-suse-qt59 image - and of course the tests pass - so I'm not sure how to help now. I've already disabled this test again to avoid the sysadmins having more work to do. REPOSITORY R319 Konsole REVISION DETAIL https://pha

D16919: Re-add DBus test

hindenburg added a comment. yea - feel free to commit any changes related to this yourself if you want. REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D16919 To: davidedmundson, #konsole, #frameworks, hindenburg Cc: hindenburg, konsole-devel, ngraham, maximilianocuri

D16919: Re-add DBus test

This revision was automatically updated to reflect the committed changes. Closed by commit R319:3eb9a34f62c8: Re-add DBus test (authored by davidedmundson, committed by hindenburg). REPOSITORY R319 Konsole CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16919?vs=45568&id=45591 REVISI

D16919: Re-add DBus test

hindenburg accepted this revision. hindenburg added a comment. This revision is now accepted and ready to land. Thanks so much for looking into this. REPOSITORY R319 Konsole BRANCH master REVISION DETAIL https://phabricator.kde.org/D16919 To: davidedmundson, #konsole, #frameworks, hin

D4975: Prevent misdetection of EOF on Linux

hindenburg added a comment. Thanks, this needs to get reviewed by the framework team that handles KPty. REPOSITORY R291 KPty REVISION DETAIL https://phabricator.kde.org/D4975 To: Lekensteyn, #konsole, hindenburg Cc: #frameworks

Re: Review Request 129281: [Konsole] Render text at primary font's baseline

> On Nov. 9, 2016, 12:22 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > looks good to me, but I think hindenburg should ack it (might want to add > > him to reviewers) > > Christoph Feck wrote: > Pretty sure "konsole" reviewers group includes the maintainer, but I > would actually pref

kwindowsystem crashes

There are a number of lines that division by zero could happen in frameworks/kwindowsystem/src/platforms/xcb/kwindowsystem.cpp if displayGeometry returns a 0 QRect. I think that is what is happening with bug 349512. viewportToDesktop, viewportWindowToDesktop, desktopToViewport I’m not clear

Review Request 125531: Mark KProcess::pid() as depreciated

.html#pid Diffs - src/lib/io/kprocess.h d57061c src/lib/io/kprocess.cpp 1df61c0 Diff: https://git.reviewboard.kde.org/r/125531/diff/ Testing --- tests pass Thanks, Kurt Hindenburg ___ Kde-frameworks-devel mailing list Kde-frameworks-

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

> On Sep 16, 2015, at 2:54 AM, David Faure wrote: > > On Tuesday 15 September 2015 22:50:50 Kurt Hindenburg wrote: >> >>> On Sep 15, 2015, at 2:07 PM, Marko Käning wrote: >>> >>> Hi kdesignerplugin devs, >>> >>> On 14 Sep 2015, a

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

> On Sep 15, 2015, at 2:07 PM, Marko Käning wrote: > > Hi kdesignerplugin devs, > > On 14 Sep 2015, at 15:00 , Kurt Hindenburg wrote: >> >> It appears the QT_VERSION check in d53ec9b97d7b353ea4cce54d5ecae3c93b933ddd >> is not enough when using Qt 5.4.x

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

> On Sep 14, 2015, at 8:36 AM, Kurt Hindenburg > wrote: > > >> On Sep 14, 2015, at 5:54 AM, Alex Merry wrote: >> >> On 2015-09-14 00:42, Kurt Hindenburg wrote: >>>> On Sep 13, 2015, at 5:43 PM, Marko Käning wrote: >>>> Hi devs, >>

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

> On Sep 14, 2015, at 5:54 AM, Alex Merry wrote: > > On 2015-09-14 00:42, Kurt Hindenburg wrote: >>> On Sep 13, 2015, at 5:43 PM, Marko Käning wrote: >>> Hi devs, >>> the other day I had built version 5.13 successfully on a OSX/MacPorts-based >>>

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

> On Sep 13, 2015, at 5:43 PM, Marko Käning wrote: > > Hi devs, > > the other day I had built version 5.13 successfully on a OSX/MacPorts-based > VM. > And so I wanted to try the same with the newest 5.14 just now, but failed! :( > > Any idea why those three interfaces are undefined? > Hi,

Re: Can someone verify this? Massive folders only show about 1000 entries in KF/Qt 5.2.

is an up to date system using project-neon5-qt5 and kdelibs-frameworks compiled last week. QMake version 3.0 Using Qt version 5.2.0 in /opt/project-neon5/lib This on a Qt5/KF5 only virtual box. Kurt _ Kurt Hindenburg kurt.hindenb...@gmail.com ___

Re: Review Request 113091: Adapt to new changes in kdelibs bookmarks, quick fix for building

tting the same klocale issues as well. You can add the group konsole or me to any Konsole patches. - Kurt Hindenburg On Oct. 4, 2013, 2:35 p.m., Casian Andrei wrote: > > --- > This is an automatically generated e-mail. To reply,

Review Request 110646: Move kfontutils to KGUIAddons

s/src/fonts/kfontutils.h Diffs - kdeui/CMakeLists.txt dcbcb4f staging/kguiaddons/src/CMakeLists.txt 1e7e3a0 staging/kguiaddons/src/fonts/kfontutils.h d23b8bd Diff: http://git.reviewboard.kde.org/r/110646/diff/ Testing --- build - no tests for this

Re: make test failures

On May 24, 2013, at 5:12 AM, David Faure wrote: > On Thursday 23 May 2013 21:22:33 Kurt Hindenburg wrote: >>> Hmm, probably there, actually: >>> kde4support/src/kdecore/kstandarddirs.cpp: 290: return >>> QFile::decodeName("lib" KDELIBSU

Re: make test failures

ave.endsWith( "lib" KDELIBSUFF "/kde5/libexec/kioslave" EXT, PATH_SENSITIVITY )' returned FALSE. () Loc: [/home/kurthindenburg/kf5/src/5/kdelibs-frameworks/staging/kde4support/autotests/kstandarddirstest.cpp(291)] _ Kurt Hindenburg kurt.hindenb...@gmail.com __

Re: make test failures

On May 23, 2013, at 2:42 PM, David Faure wrote: > On Thursday 23 May 2013 09:53:53 Kurt Hindenburg wrote: >> Hello, I'm running a VM built from lubuntu with no Qt4/KDE4 installed. >> >> One change I had to make was to the plugin variable to add the >&g

make test failures

Hello, I'm running a VM built from lubuntu with no Qt4/KDE4 installed. One change I had to make was to the plugin variable to add the i386-linux-gnu part. /home/kurthindenburg/kf5/kde_frameworks/lib/i386-linux-gnu/plugins:/home/kurthindenburg/kf5/qt5/plugins: It could be that I have something n