Re: Rollout of Gitlab CI

On jeudi 30 septembre 2021 08:40:04 CEST Ben Cooksley wrote: > On Thu, Sep 30, 2021 at 7:10 PM Laurent Montel wrote: > > Hi, > > Hi Laurent, > > I added in .kde-ci.yml > > > 'kde/pim/akonadi-contacts': '@latest' > > 'frameworks/kcontacts': '@stab

Re: Rollout of Gitlab CI

:08 CEST Ben Cooksley wrote: > Hi all, -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel: France +33 (0)4 90 84 08 53, http://www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts

D28967: [KRichTextEditor] Add support for headings

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH heading (branched from master) REVISION DETAIL https://phabricator.kde.org/D28967 To: poboiko, #frameworks, mlaurent Cc: mlaurent, kde-frameworks-devel, LeGast00n, cblack,

D28967: [KRichTextEditor] Add support for headings

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > krichtexteditorui.rc:2 > > > increase version. => 14 REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D28967 To: poboiko,

D28854: [KRichTextWidget] Add support for headings

mlaurent added inline comments. INLINE COMMENTS > poboiko wrote in krichtextedit.cpp:346 > Yes, that's true. I agree it's a bit confusing, but that's the case with HTML > too, which I had in mind (see screenshot, it's Chrome) > F8241667: scr1.png > > For

D19913: [plasma-framework] make it compiles without foreach

mlaurent updated this revision to Diff 80344. mlaurent added a comment. Use m_menu->addActions(m_dropActions); REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19913?vs=80182=80344 BRANCH compile_without_foreach (branched from master)

D19913: [plasma-framework] make it compiles without foreach

This revision was automatically updated to reflect the committed changes. Closed by commit R242:48f60533b922: [plasma-framework] make it compiles without foreach (authored by mlaurent). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D19913: [plasma-framework] make it compiles without foreach

mlaurent added a comment. Ping ?:) REPOSITORY R242 Plasma Framework (Library) BRANCH compile_without_foreach (branched from master) REVISION DETAIL https://phabricator.kde.org/D19913 To: mlaurent, dfaure Cc: ahmadsamir, nicolasfella, broulik, apol, kde-frameworks-devel, LeGast00n,

D28854: [KRichTextWidget] Add support for headings

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R310 KTextWidgets BRANCH textwidget-heading (branched from master) REVISION DETAIL https://phabricator.kde.org/D28854 To: poboiko, #frameworks, mlaurent,

D28854: [KRichTextWidget] Add support for headings

mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. Can you improve autotest KRichTextEditTest ? INLINE COMMENTS > krichtextedit.cpp:346 > +// level=2 look the same > +int sizeAdjustment = boundedLevel > 0 ? 5 -

D19913: [plasma-framework] make it compiles without foreach

mlaurent updated this revision to Diff 80182. mlaurent added a comment. Fix comment REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19913?vs=80170=80182 BRANCH compile_without_foreach (branched from master) REVISION DETAIL

D19913: [plasma-framework] make it compiles without foreach

mlaurent retitled this revision from "[plasma-desktop] make it compiles without foreach" to "[plasma-framework] make it compiles without foreach". REPOSITORY R242 Plasma Framework (Library) BRANCH compile_without_foreach (branched from master) REVISION DETAIL

D19913: [plasma-desktop] make it compiles without foreach

mlaurent updated this revision to Diff 80170. mlaurent added a comment. Fix David comment REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19913?vs=80169=80170 BRANCH compile_without_foreach (branched from master) REVISION DETAIL

D19913: [plasma-desktop] make it compiles without foreach

mlaurent updated this revision to Diff 80169. mlaurent added a comment. Port last element to for(...:...) REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19913?vs=80168=80169 BRANCH compile_without_foreach (branched from master)

D19913: [plasma-desktop] make it compiles without foreach

mlaurent updated this revision to Diff 80168. mlaurent added a comment. Rebase against master REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19913?vs=55796=80168 BRANCH compile_without_foreach (branched from master) REVISION DETAIL

D25660: Decouple KBookmarksMenu from KActionCollection

mlaurent added a comment. In D25660#635693 , @dfaure wrote: > @mlaurent AFAICS you removed the deprecation macro completely in master, and left it (with 0x06) in release/20.04? nope or I missed to forward port in 20.04. So it's an

Re: KDE CI: Applications » kreversi » kf5-qt5 FreeBSDQt5.13 - Build # 26 - Still Failing!

h IMHO is very valuable, sadly of the kind nobody will really > notice due to Qt6/KF6 porting life being easier for them without knowing > how bad it would have been, you will stay an unsung hero). > I have no simple idea yet how to enable a similar approach yet again. > Passing "-Wer

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

mlaurent added a comment. Did you test to compile with flags == 5.68.0 ? I tested it with kdepim and I need to adapt it. -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0x054400 is 5.68.0 ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25010 To: meven, #frameworks, dfaure,

D25010: [StatJob] Use A QFlag to specify the details returned by StatJob

mlaurent added a comment. "/compile/kde5/framework/kde/kdegames/kjumpingcube/game.cpp:582:63: erreur: impossible de convertir « KIO::StatJob::DestinationSide » de «  KIO::StatJob::StatSide » vers « KIO::JobFlags » {aka « QFlags »} 582 | KIO::StatJob* statJob = KIO::stat(url,

D27863: Fix "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R268 KGlobalAccel BRANCH somefix REVISION DETAIL https://phabricator.kde.org/D27863 To: fvogt, #frameworks, mlaurent Cc: ahmadsamir, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

mlaurent added a comment. if splitting is already done why this code re-call "m_desktopFile.desktopGroup().readEntry(QStringLiteral("Exec"), QString())" ? > QProcess::startDetached(commands, parts) no ? === REPOSITORY R268 KGlobalAccel

D27863: Revert "Make it compile against last qt5.15 without deprecated method. QProcess::execute(QString) is deprecated"

mlaurent added inline comments. INLINE COMMENTS > kserviceactioncomponent.cpp:72 > } else { > - > QProcess::startDetached(m_desktopFile.desktopGroup().readEntry(QStringLiteral("Exec"), > QString()), QStringList()); > + >

D27591: KAbstractFileItemActionPlugin: Add missing quotes in code example

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D27591 To: alex, elvisangelaccio, #frameworks, mlaurent Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham,

D27459: Port QLinkedList which is deprecated in qt5.15

This revision was automatically updated to reflect the committed changes. Closed by commit R263:c5863523f3aa: Port QLinkedList which is deprecated in qt5.15 (authored by mlaurent). REPOSITORY R263 KXmlGui CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27459?vs=75830=75936 REVISION

D27459: Port QLinkedList which is deprecated in qt5.15

mlaurent added a reviewer: dfaure. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D27459 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27459: Port QLinkedList which is deprecated in qt5.15

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port QLinkedList (deprecated in qt5.15) REPOSITORY R263 KXmlGui BRANCH port_QLinkedList (branched from master)

D27270: Use ecm_qt_install_logging_categories over manual categories files

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R174 KContacts BRANCH generateqtlogcatfile REVISION DETAIL https://phabricator.kde.org/D27270 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel, LeGast00n,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

mlaurent added a comment. In D27150#608491 , @kossebau wrote: > In D27150#608318 , @mlaurent wrote: > > > Yep you need to create a file name "foo.renamecategories" where you change the categorie

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

mlaurent added a comment. Yep you need to create a file name "foo.renamecategories" where you change the categorie name old module namenew module name = for example "log_mailfilteragent org.kde.pim.mailfilteragent" in kmail What do you need

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

mlaurent added a comment. I don't see other case. For me your macro works for all case that we can implement. No other idea. But avoiding to create by hand the file is a good idea. I never successed to create a macro for it So thanks REPOSITORY R240 Extra CMake Modules BRANCH

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Seems ok for me :) REPOSITORY R240 Extra CMake Modules BRANCH addautomaticcategoriesgeneration REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system,

D27150: Add ecm_qt_install_logging_categories & ecm_qt_export_logging_category

mlaurent added a comment. Seems ok for me REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D27150 To: kossebau, #build_system, #frameworks, broulik, mlaurent Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D27151: Use ecm_qt_install_logging_categories over manual categories file

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Seems ok for me. REPOSITORY R244 KCoreAddons BRANCH generateqtlogcatfile REVISION DETAIL https://phabricator.kde.org/D27151 To: kossebau, #build_system, #frameworks, broulik,

Re: Banning QNetworkAccessManager

llowRedirectsAttribute, true); " Doesn't exist it's a enum from QnetworkRequest::RedirectPolicy And FollowRedirectsAttribute is old value It seems that we need to use QnetworkRequest::NoLessSafeRedirectPolicy directly no ? -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Soft

D27010: QApplication::globalStrut() will be removed in qt6. It's deprecated in qt5.15 It seems that it's not necessary to expand to globalStruct as it never return 0 for theses widget

This revision was automatically updated to reflect the committed changes. Closed by commit R236:9b77746a6b1e: QApplication::globalStrut() will be removed in qt6. Its deprecated in qt5.15… (authored by mlaurent). REPOSITORY R236 KWidgetsAddons CHANGES SINCE LAST UPDATE

D27010: QApplication::globalStrut() will be removed in qt6. It's deprecated in qt5.15 It seems that it's not necessary to expand to globalStruct as it never return 0 for theses widget

mlaurent added a comment. ping ?:) REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D27010 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D27010: QApplication::globalStrut() will be removed in qt6. It's deprecated in qt5.15 It seems that it's not necessary to expand to globalStruct as it never return 0 for theses widget

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY QApplication::globalStrut() will be removed in qt6 REPOSITORY R236 KWidgetsAddons BRANCH remove_globalStrut

D27010: QApplication::globalStrut() will be removed in qt6. It's deprecated in qt5.15 It seems that it's not necessary to expand to globalStruct as it never return 0 for theses widget

mlaurent added a reviewer: dfaure. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D27010 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

This revision was automatically updated to reflect the committed changes. Closed by commit R237:87471e14b370: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader (authored by mlaurent). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

mlaurent updated this revision to Diff 74428. mlaurent added a comment. Use QStringRef here too REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26890?vs=74406=74428 BRANCH port_QXmlStreamReader (branched from master) REVISION DETAIL

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

mlaurent updated this revision to Diff 74406. mlaurent added a comment. Use QStringRef::compare REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26890?vs=74349=74406 BRANCH port_QXmlStreamReader (branched from master) REVISION DETAIL

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

mlaurent marked 4 inline comments as done. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26890 To: mlaurent, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

mlaurent updated this revision to Diff 74349. mlaurent added a comment. We need to open QIODevice. Now all works correctly after rebuilding all REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26890?vs=74348=74349 BRANCH port_QXmlStreamReader (branched

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

mlaurent updated this revision to Diff 74348. mlaurent added a comment. Trim better calling toString() REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26890?vs=74295=74348 BRANCH port_QXmlStreamReader (branched from master) REVISION DETAIL

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

mlaurent edited the test plan for this revision. mlaurent added a reviewer: dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26890 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26890: QXmlInputSource is deprecated in qt5.15. Port it to QXmlStreamReader

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY QXmlInputSource is deprecated in qt5.15 REPOSITORY R237 KConfig BRANCH port_QXmlStreamReader (branched from

D26860: Readapt code to new kconfig code

mlaurent closed this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26860 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26860: Readapt code to new kconfig code

mlaurent added a comment. Yep done :) REPOSITORY R237 KConfig BRANCH port_endl (branched from master) REVISION DETAIL https://phabricator.kde.org/D26860 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26860: Readapt code to new kconfig code

mlaurent added a comment. it replace D26432 I don't know why it created a new version REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26860 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26432: Port endl to std::cout/std::cerr or "\n" + flush when necessary. In qt5.15 endl is namespaced.

mlaurent abandoned this revision. mlaurent added a comment. created a new one D26860 REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26432 To: mlaurent, dfaure, tcanabrava Cc: anthonyfieroni, kde-frameworks-devel, LeGast00n,

D26860: Readapt code to new kconfig code

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port endl to "\n" as it's qt namespaced TEST PLAN autotest ok REPOSITORY R237 KConfig BRANCH port_endl

D26860: Readapt code to new kconfig code

mlaurent added a reviewer: dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26860 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26623: KEMailSettings: group names in kconfig files should not be localized

mlaurent added a comment. It's not used in kmail it seems. we use this class in kmail-account-wizard only. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26623 To: meven, #frameworks, ervin, dfaure Cc: mlaurent, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26701: Add KFileCustomDialog constructor with a startDir parameter.

mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. it's ok for me. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26701 To: dfaure, broulik, pino, mlaurent Cc: alexeymin, kde-frameworks-devel,

D26737: QJsonDocument::fromBinaryData is deprecated in qt5.15. We need to port to QCborValue::fromCbor

This revision was automatically updated to reflect the committed changes. Closed by commit R495:c0bc818c744e: QJsonDocument::fromBinaryData is deprecated in qt5.15. We need to port to… (authored by mlaurent). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE

D26736: QHash::insertMulti is deprecated in qt5.15 => port to QMultiHash

This revision was automatically updated to reflect the committed changes. Closed by commit R242:1e5966147de1: QHash::insertMulti is deprecated in qt5.15 = port to QMultiHash (authored by mlaurent). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D26737: QJsonDocument::fromBinaryData is deprecated in qt5.15. We need to port to QCborValue::fromCbor

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY QJsonDocument::fromBinaryData is deprecated in qt5.15 Port to QCborValue::fromCbor REPOSITORY R495 Purpose

D26736: QHash::insertMulti is deprecated in qt5.15 => port to QMultiHash

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port to QMultiHash REPOSITORY R242 Plasma Framework (Library) BRANCH use_multihash (branched from master)

D26614: Remove extra flush when we close file it will flush

This revision was automatically updated to reflect the committed changes. Closed by commit R269:aed4416be700: Remove extra flush when we close file it will flush (authored by mlaurent). REPOSITORY R269 BluezQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26614?vs=73365=73378

D26614: Remove extra flush when we close file it will flush

mlaurent added a reviewer: dfaure. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D26614 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26614: Remove extra flush when we close file it will flush

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Remove extra flush REPOSITORY R269 BluezQt BRANCH remove_extra_flush (branched from master) REVISION DETAIL

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R269:d08e77529bd1: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not… (authored by mlaurent).

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

mlaurent added a comment. From me I am ok with David comment for this code it's not necessary to have a flush() many time. Adding \n is enough for me. Regards REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D26320 To: mlaurent, dfaure Cc: kossebau, apol,

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

mlaurent added a comment. No change needed ? I will commit in two days if no complains. REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D26320 To: mlaurent, dfaure Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26496: Log categories: fix format adding DEFAULT_SEVERITY

mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. But you're wrong "log_kdebugsettings: In this file: "/home/meven/kde/usr/etc/xdg/kio.categories" this line "kf5.kio.cookiejar kcookiejar (KIO)" still use old format. We

D26450: Port to QMultiHash as QHash::insertMulti is deprecated

This revision was automatically updated to reflect the committed changes. Closed by commit R244:837621e0e305: Port to QMultiHash as QHash::insertMulti is deprecated (authored by mlaurent). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D26464: Port qrand to QRandomGenerator (qrand is deprecated in qt5.15)

This revision was automatically updated to reflect the committed changes. Closed by commit R242:b387faa93526: Port qrand to QRandomGenerator (qrand is deprecated in qt5.15) (authored by mlaurent). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D26465: Port endl to \n Not necessary to flush as QTextStream uses QFile which flush when it's deleted

This revision was automatically updated to reflect the committed changes. Closed by commit R242:3f30f91fb04c: Port endl to \n Not necessary to flush as QTextStream uses QFile which flush… (authored by mlaurent). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D26463: Port endl as \n or std::cout ... std::endl when we wrote directly on console or flush QTextStream when it's a qstring

This revision was automatically updated to reflect the committed changes. Closed by commit R39:9aeb3bef288f: Port endl as \n or std::cout ... std::endl when we wrote directly on console or… (authored by mlaurent). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE

D26465: Port endl to \n Not necessary to flush as QTextStream uses QFile which flush when it's deleted

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port endl to \n REPOSITORY R242 Plasma Framework (Library) BRANCH port_endl (branched from master) REVISION

D26465: Port endl to \n Not necessary to flush as QTextStream uses QFile which flush when it's deleted

mlaurent added a reviewer: dfaure. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D26465 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26464: Port qrand to QRandomGenerator (qrand is deprecated in qt5.15)

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port to QRandomGenerator REPOSITORY R242 Plasma Framework (Library) BRANCH port_QRandomGenerator (branched from

D26463: Port endl as \n or std::cout ... std::endl when we wrote directly on console or flush QTextStream when it's a qstring

mlaurent added a reviewer: dfaure. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D26463 To: mlaurent, dfaure Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D26463: Port endl as \n or std::cout ... std::endl when we wrote directly on console or flush QTextStream when it's a qstring

mlaurent created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. mlaurent requested review of this revision. REVISION SUMMARY Port endl as it's Qt:: namespaced in qt5.15 REPOSITORY R39 KTextEditor BRANCH port_endl

D26450: Port to QMultiHash as QHash::insertMulti is deprecated

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port to QMultiHash REPOSITORY R244 KCoreAddons BRANCH port_multi_hash (branched from master) REVISION DETAIL

D26450: Port to QMultiHash as QHash::insertMulti is deprecated

mlaurent added a reviewer: dfaure. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D26450 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26432: Port endl to std::cout/std::cerr or "\n" + flush when necessary. In qt5.15 endl is namespaced.

mlaurent added inline comments. INLINE COMMENTS > dfaure wrote in kconfig_compiler.cpp:694 > Why? Surely the QTextStream destructor (which is called here) will take care > of that. I think that it was a problem when QTextStream used QString which doesn't flush it. code is a QString

D26449: [PoC] Port to KRecentFileMenu

mlaurent added a comment. So you need to increase kf5 dependancy no ? REPOSITORY R36 Ark REVISION DETAIL https://phabricator.kde.org/D26449 To: nicolasfella, #ark, #frameworks Cc: mlaurent, kde-utils-devel, fbampaloukas, tctara

D26432: Port endl to std::cout/std::cerr or "\n" + flush when necessary. In qt5.15 endl is namespaced.

mlaurent added a reviewer: dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D26432 To: mlaurent, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26432: Port endl to std::cout/std::cerr or "\n" + flush when necessary. In qt5.15 endl is namespaced.

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port endl as in qt5.15 it's namespaced REPOSITORY R237 KConfig BRANCH port_endl (branched from master)

D26420: Add a logging category to smb ioslave

mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH arcpatch-D26358 REVISION DETAIL https://phabricator.kde.org/D26420 To: meven, #frameworks, mlaurent Cc: mlaurent, kde-frameworks-devel, kfm-devel, pberestov, iasensio,

D26420: Add a logging category to smb ioslave

mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:27 > +IDENTIFIER KIO_SMB_LOG > +CATEGORY_NAME log_kio_smb) > + indent > kio_smb.cpp:36 > >

D26303: Remove endl in qDebug as it's already add "\n" + port to Qt::endl in qt5.15

This revision was automatically updated to reflect the committed changes. Closed by commit R309:128ed7ce3a1e: Remove endl in qDebug as its already add \n + port to Qt::endl in qt5.15 (authored by mlaurent). REPOSITORY R309 KService CHANGES SINCE LAST UPDATE

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

mlaurent added a comment. So what I need to change in this patch ? (if I need to change a code :) ) REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D26320 To: mlaurent, dfaure Cc: kossebau, apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26303: Remove endl in qDebug as it's already add "\n" + port to Qt::endl in qt5.15

mlaurent added a comment. Ping ?:) REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D26303 To: mlaurent, dfaure Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26372: In qt5.15 QHash::insertMulti is deprecated now we need to use QMultiHash

This revision was automatically updated to reflect the committed changes. Closed by commit R286:a5f8bfc9bf14: In qt5.15 QHash::insertMulti is deprecated now we need to use QMultiHash (authored by mlaurent). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D26373: Port endl to \n

This revision was automatically updated to reflect the committed changes. Closed by commit R290:011c329fa4f3: Port endl to \n (authored by mlaurent). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26373?vs=72639=72663 REVISION DETAIL

D26373: Port endl to \n

mlaurent added reviewers: dfaure, apol. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D26373 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26373: Port endl to \n

mlaurent created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port endl to \n + flush when necessary REPOSITORY R290 KPackage BRANCH port_endl (branched from master)

D26372: In qt5.15 QHash::insertMulti is deprecated now we need to use QMultiHash

mlaurent added a reviewer: dfaure. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D26372 To: mlaurent, dfaure Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham,

D26372: In qt5.15 QHash::insertMulti is deprecated now we need to use QMultiHash

mlaurent created this revision. Herald added projects: Frameworks, Baloo. Herald added subscribers: Baloo, kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Port to QMultiHash REPOSITORY R286 KFileMetaData BRANCH use_qmultihash (branched from master)

D26301: Remove endl in qDebug it's already add \n at the end + port endl + flush when necessary

This revision was automatically updated to reflect the committed changes. Closed by commit R294:2d40d4f5f0f1: Remove endl in qDebug its already add \n at the end + port endl + flush when… (authored by mlaurent). REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE

D26302: Port endl to "\n" + flush at the end

This revision was automatically updated to reflect the committed changes. Closed by commit R298:f9e10975740d: Port endl to \n + flush at the end (authored by mlaurent). REPOSITORY R298 KDesignerPlugin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26302?vs=72593=72604 REVISION

D26320: endl is Qt:: namespaced in qt5.15. Port to \n and flush when QTextStream is not on a QFile

mlaurent added a comment. nm -gDC libQt5Core.so.5.15.0 | grep endl 00336680 T endl(QTextStream&) 00336500 T QTextStreamFunctions::endl(QTextStream&) 003361e0 T Qt::endl(QTextStream&) REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D26320

D26301: Remove endl in qDebug it's already add \n at the end + port endl + flush when necessary

mlaurent added a reviewer: apol. REPOSITORY R294 KBookmarks REVISION DETAIL https://phabricator.kde.org/D26301 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26301: Remove endl in qDebug it's already add \n at the end + port endl + flush when necessary

mlaurent updated this revision to Diff 72594. mlaurent added a comment. Merge "\n" + use '\n' REPOSITORY R294 KBookmarks CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26301?vs=72417=72594 BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL

D26302: Port endl to "\n" + flush at the end

mlaurent added a reviewer: apol. REPOSITORY R298 KDesignerPlugin REVISION DETAIL https://phabricator.kde.org/D26302 To: mlaurent, dfaure, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26302: Port endl to "\n" + flush at the end

mlaurent updated this revision to Diff 72593. mlaurent added a comment. Merge \n and use '\n' REPOSITORY R298 KDesignerPlugin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26302?vs=72418=72593 BRANCH port_endl_qt5.15 (branched from master) REVISION DETAIL

D26318: Port endl to "\n" flush at the end + use const'ref in loop

This revision was automatically updated to reflect the committed changes. Closed by commit R266:6ed68fd17385: Port endl to \n flush at the end + use constref in loop (authored by mlaurent). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D26299: endl is namespaced in qt5.15

This revision was automatically updated to reflect the committed changes. Closed by commit R280:99009fc60051: endl is namespaced in qt5.15 (authored by mlaurent). REPOSITORY R280 Prison CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26299?vs=72510=72591 REVISION DETAIL

  1   2   3   4   5   6   7   8   >