Re: Merge tags in master branch?

2020-11-23 Thread Luigi Toscano
Harald Sitter ha scritto: > Hej > > On 23.11.20 16:11, Bhushan Shah wrote: >> Hello, >> >> So I have one question regarding the how we do the framework versioning. >> Namely the tags, >> >> So currently some packages have a versioned tags on their master branch, >> >> i.e >> >> karchive: >> >> ➜

D28861: Sonnet add Malayalam trigram

2020-10-01 Thread Luigi Toscano
ltoscano changed the visibility from "All Users" to "Public (No Login Required)". REPOSITORY R246 Sonnet REVISION DETAIL https://phabricator.kde.org/D28861 To: aiswaryak, #frameworks Cc: kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29802: Require in-source build

2020-05-16 Thread Luigi Toscano
ltoscano added a comment. I believe a few sentences in the the commit message contradicts each other. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D29802 To: ngraham, #frameworks, #vdg, ognarb, davidre Cc: ltoscano, davidre, kde-frameworks-devel, LeGast00n,

D29711: Create kcmshell.openSystemSettings() and kcmshell.openInfoCenter() functions

2020-05-13 Thread Luigi Toscano
ltoscano added a comment. In D29711#670470 , @ngraham wrote: > In D29711#670458 , @cfeck wrote: > > > Sorry if I don't understand the scope, but does this mean I am forced to install systemsettings

D29575: holidayregion.cpp - provide translatable strings for the German regions.

2020-05-09 Thread Luigi Toscano
ltoscano added a comment. In D29575#667175 , @winterz wrote: > I'm guessing it's ok to depend on K5I18N ? KHolidays is a Tier 1 framework, so it can't depend on KI18n. Just use QCoreApplication::translate as used already in

Re: Information regarding upcoming Gitlab Migration: clarifications

2020-05-01 Thread Luigi Toscano
Ben Cooksley ha scritto: > On Fri, May 1, 2020 at 4:38 PM Nate Graham wrote: >> >> >> >> On 4/30/20 5:59 PM, Aleix Pol wrote: >>> El jue., 30 de abr. de 2020 a la(s) 18:15, Albert Astals Cid Am I the only person that just has all the repos on the same folder? I thought it was the

D27419: Update Japanese holidays

2020-02-16 Thread Luigi Toscano
ltoscano added a comment. Just did it: https://commits.kde.org/kholidays/263bc0f2d601bcf9a5d3632f8535e0bbd8f50255 REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D27419 To: nhiga, dvratil, winterz, cgiboudeaux Cc: ltoscano, aacid, #kde_pim, kde-frameworks-devel,

D27419: Update Japanese holidays

2020-02-16 Thread Luigi Toscano
ltoscano added a comment. Please revert and commit it with the correct authorship. REPOSITORY R175 KHolidays REVISION DETAIL https://phabricator.kde.org/D27419 To: nhiga, dvratil, winterz, cgiboudeaux Cc: ltoscano, aacid, #kde_pim, kde-frameworks-devel, LeGast00n, cblack, fbampaloukas,

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2020-01-15 Thread Luigi Toscano
ltoscano added a comment. In D24423#594728 , @guoyunhe wrote: > if we copy `applications.menu` to plasma-workspace and patch it there, it will only be shipped with future plasma releases. Isn't it going to conflict with the

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2020-01-15 Thread Luigi Toscano
ltoscano added a comment. In D24423#594718 , @guoyunhe wrote: > Then how about I copy this file `applications.menu` to plasma-workspace? After one or two years, we can delete this file from frameworks. But for compatibility, it will exist in

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2020-01-15 Thread Luigi Toscano
ltoscano added a comment. The question is the same. What happens with older Plasma with newer Frameworks? It may be that nothing really breaks, of course. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc: davidedmundson,

D24932: Add button to open the folder in filelight to view more details

2019-12-31 Thread Luigi Toscano
ltoscano added a comment. As a reference for the future: this change broke the two weeks string freeze - which we haven't enforced so strongly in the past months, but please keep an eye on it. Expecially this time of the year with many countries on vacation. REPOSITORY R241 KIO REVISION

D26317: Port endl to "\n". endl in qt5.15 is namespaced. We don't need to flush as when QFile is deleted it flush data

2019-12-31 Thread Luigi Toscano
ltoscano added a comment. In D26317#585315 , @aacid wrote: > Isn't it better to just use `Qt::endl` ? > > I think it's much clearer to understand `Qt::endl` than `QLatin1Char('\n')` > > But if we prefer to change to use \n it should be

D26306: Define more documentation search paths (also custom)

2019-12-30 Thread Luigi Toscano
ltoscano added subscribers: asturmlechner, maximilianocuria, rikmills, arojas, rdieter, lbeltrame, cgiboudeaux. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D26306 To: ltoscano Cc: cgiboudeaux, lbeltrame, rdieter, arojas, rikmills, maximilianocuria, asturmlechner,

D26306: Define more documentation search paths (also custom)

2019-12-30 Thread Luigi Toscano
ltoscano created this revision. Herald added projects: Frameworks, Documentation. Herald added subscribers: kde-doc-english, kde-frameworks-devel. ltoscano requested review of this revision. REVISION SUMMARY New search paths: - (GenericDataLocation)/help - a custom path (absolute path),

D26167: Update holidays and add flagdays and namedays for Sweden

2019-12-22 Thread Luigi Toscano
ltoscano added a comment. Try to use [easter] + 50 days Example (from Italian holidays): "Ascensione (Chiesa Cattolica)" religious on ((year >= 1977) ? ([easter] + 42 days): noop) https://cgit.kde.org/kholidays.git/tree/holidays/plan2/holiday_it_it?#n47 REPOSITORY R175

D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts"

2019-12-06 Thread Luigi Toscano
ltoscano added a comment. Oh sorry, I missed that. It's the kind of information I wouldn't expect in the commit message. REPOSITORY R265 KConfigWidgets BRANCH configure-keyboard-shortcuts (branched from master) REVISION DETAIL https://phabricator.kde.org/D25793 To: ngraham, #vdg,

D25793: Rename "Configure Shortcuts" to "Configure Keyboard Shortcuts"

2019-12-06 Thread Luigi Toscano
ltoscano added a comment. Please commit it after the commit for the new Frameworks is made (so probably from Sunday onwards). REPOSITORY R265 KConfigWidgets BRANCH configure-keyboard-shortcuts (branched from master) REVISION DETAIL https://phabricator.kde.org/D25793 To: ngraham,

D25630: Port to json metadata

2019-11-30 Thread Luigi Toscano
ltoscano added inline comments. INLINE COMMENTS > ktp_integration_module.json:3 > +"KPlugin": { > +"Description": "Module providing deeper integration of Instant > Messaging with KDE.", > +"Name": "Telepathy Integration Module", I can't comment on the rest of the reivew,

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2019-11-24 Thread Luigi Toscano
ltoscano added a comment. Maybe pinging a few Plasma people may be more effective, or though a mailing list thread. I don't know. REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc: ngraham, ltoscano, kde-frameworks-devel,

D25435: [Network Ioslave] Add Display name to network:/

2019-11-22 Thread Luigi Toscano
ltoscano added inline comments. INLINE COMMENTS > Messages.sh:2 > +#! /usr/bin/env bash > +$XGETTEXT *.cpp -o $podir/kio5_network.pot This does not work as it is, because it does not look into the subdirectories. Hint for testing:

Re: Bulk replacement of projects.kde.org on Frameworks modules

2019-11-16 Thread Luigi Toscano
Luigi Toscano ha scritto: > Hi, > basically all Frameworks components reference the ECM website > using the old projects.kde.org URL, which is long gone and > it is just a (partial) redirect. > > See for example: > > set_package_properties(ECM PROPERTIES TYPE REQUIRED

Re: Bulk replacement of projects.kde.org on Frameworks modules

2019-11-11 Thread Luigi Toscano
Elvis Angelaccio ha scritto: > > > On 11/11/19 22:52, Luigi Toscano wrote: >> Hi, >> basically all Frameworks components reference the ECM website >> using the old projects.kde.org URL, which is long gone and >> it is just a (partial) redirect. >> >>

Bulk replacement of projects.kde.org on Frameworks modules

2019-11-11 Thread Luigi Toscano
Hi, basically all Frameworks components reference the ECM website using the old projects.kde.org URL, which is long gone and it is just a (partial) redirect. See for example: set_package_properties(ECM PROPERTIES TYPE REQUIRED DESCRIPTION "Extra CMake Modules." URL

D25225: Symlink microphone to audio-input-microphone on all sizes

2019-11-10 Thread Luigi Toscano
This revision was automatically updated to reflect the committed changes. Closed by commit R267:99f892b26058: Symlink microphone to audio-input-microphone on all sizes (authored by ltoscano). REPOSITORY R267 Oxygen Icons CHANGES SINCE LAST UPDATE

D25225: Symlink microphone to audio-input-microphone on all sizes

2019-11-08 Thread Luigi Toscano
ltoscano created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ltoscano requested review of this revision. REVISION SUMMARY Right now microphone.png (which is a fall-back for icons like microphone-sensitivity-{muted,low,medium,high})

Re: Quick Charts in KDE Review

2019-10-22 Thread Luigi Toscano
Jonathan Riddell ha scritto: > There's a file called LICENSE which contains a copy of the LGPL 2.1 > > But all the files with an explicit licence seem to be GPL 2+3+KDEeV > > Please decide which licence you want to apply and if it's GPL 2+3+KDEeV remove > LICENSE and put a copy of the GPL 2

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

2019-10-15 Thread Luigi Toscano
ltoscano added a comment. In D24477#547779 , @ndavis wrote: > For some reason, Arc made me the committer and the author instead of just the committer. Maybe because patches sent through the phabricator web interface have no authorship

D24423: Rename "Internet" category to "Network" and remove "Internet>Terminal" sub-category

2019-10-05 Thread Luigi Toscano
ltoscano added a comment. I wonder how to untangle this dependency, because a change in Frameworks can't (shouldn't?) depend on a change in a consumer (yes, same issues as toys). REPOSITORY R309 KService REVISION DETAIL https://phabricator.kde.org/D24423 To: guoyunhe, #frameworks Cc:

D24384: Move Amusement to Games directory instead of Games > Toys

2019-10-03 Thread Luigi Toscano
ltoscano added a comment. Can you please at least remove the steam example from the commit message, as it is not relevant (it is a downstream change) and remove the reference to the bug? Does it also mean that kf5-toys.directory is not used anymore? (not sure whether it can't be removed

D7446: [Places panel] Revamp the Recently Saved section

2019-09-06 Thread Luigi Toscano
ltoscano added a comment. In D7446#526741 , @ngraham wrote: > And maybe we should also discuss moving kio-extras to the frameworks release cycle. It's not an app so I'm not sure it makes sense to have it distributed with KDE Applications right

D23730: Add new protocol for 7z archives

2019-09-05 Thread Luigi Toscano
ltoscano added a comment. Does it work when the older KIO is installed? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D23730 To: nhiga, meven Cc: ltoscano, meven, ngraham, kfm-devel, kde-frameworks-devel, iasensio, fprice, LeGast00n, MrPepe, fbampaloukas,

Re: Proposing Quick Charts as a new framework

2019-09-02 Thread Luigi Toscano
Arjen Hiemstra ha scritto: > Hi, > > I have been working on a library the past few months that provides a QtQuick > module for rendering gpu-accelerated charts. It currently lives in a > playground > repository, here: https://invent.kde.org/kde/kf5quickcharts . I would like for > this library to

D23465: Add new non standard mime type for ROOT cern files

2019-08-26 Thread Luigi Toscano
ltoscano added a comment. The idea is good, but it should be proposed to shared-mime-info repository instead. As far as I remember from the previous discussions, this file is meant to contain a limited number of entities and possibiy disappear over time. REPOSITORY R244 KCoreAddons

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

2019-08-26 Thread Luigi Toscano
ltoscano accepted this revision. ltoscano added a comment. This revision is now accepted and ready to land. (sorry, time off) thanks! REPOSITORY R238 KDocTools BRANCH kdeinstalldirs REVISION DETAIL https://phabricator.kde.org/D23229 To: asturmlechner, #frameworks, ltoscano Cc:

D23119: Fix dates being on the wrong locale when setting an application language individually

2019-08-20 Thread Luigi Toscano
ltoscano added inline comments. INLINE COMMENTS > asemke wrote in kxmlgui_unittest.cpp:1089 > does this test work? The name of the month is "январь" in russian, not > "января". Declensions: https://en.wiktionary.org/wiki/%D1%8F%D0%BD%D0%B2%D0%B0%D1%80%D1%8C#Declension REPOSITORY R263

D23229: KF5DocToolsMacros.cmake: Use non-deprecated KDEInstallDirs variables

2019-08-17 Thread Luigi Toscano
ltoscano added a comment. I can't check now, but I think the case were "the deprecated variable is set, but the new one is not, then the old one is used" should be considered. INLINE COMMENTS > KF5DocToolsMacros.cmake:236 > +if (NOT KDE_INSTALL_MANDIR) > +set(KDE_INSTALL_MANDIR

D22715: Save and load page margins

2019-07-27 Thread Luigi Toscano
ltoscano added subscribers: aacid, ltoscano. ltoscano added a comment. I think @aacid recently (well, some time ago) worked on the Qt printing code and he may at least have an idea of the status of this. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D22715 To:

D22698: Support passing target to ki18n_wrap_ui macro

2019-07-26 Thread Luigi Toscano
ltoscano added a comment. In D22698#502791 , @daandemeyer wrote: > @alexmerry I think I added the wrong reviewer for this. I noticed your name in the git blame of `k18n_wrap_ui`, perhaps you know who I should add as a reviewer for ki18n

D22689: Replace QString::null with QString

2019-07-24 Thread Luigi Toscano
ltoscano added a comment. I can see that several frameworks can't build anymore on build.kde.org after the change. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D22689 To: aacid, apol, nicolasfella Cc: ltoscano, nicolasfella, kde-frameworks-devel, LeGast00n,

D22659: Fix bracket

2019-07-22 Thread Luigi Toscano
ltoscano added a comment. This should be backported to Applications/19.08. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22659 To: vonreth, brute4s99 Cc: ltoscano, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas, alexde,

D9033: man ioslave: asserts trying to display pam(8)

2019-07-18 Thread Luigi Toscano
This revision was automatically updated to reflect the committed changes. Closed by commit R320:87215e7ea765: man ioslave: asserts trying to display pam(8) (authored by marten, committed by ltoscano). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE

D7820: man ioslave: spurious numbers included in clang(1) man page

2019-07-10 Thread Luigi Toscano
ltoscano added a comment. Apologize for the long delay - I can't reproduce the issue with the current master. The mentioned structure of the clang man page seems to be the same (clang 8). Adding @mkoller too. REPOSITORY R320 KIO Extras REVISION DETAIL

D7820: man ioslave: spurious numbers included in clang(1) man page

2019-07-10 Thread Luigi Toscano
ltoscano added a reviewer: mkoller. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D7820 To: marten, #plasma, kfm-devel, mkoller Cc: kde-frameworks-devel, plasma-devel, fprice, LeGast00n, jraleigh, fbampaloukas, alexde, GB_2, feverfew, ragreen, Pitel, meven,

D9033: man ioslave: asserts trying to display pam(8)

2019-07-10 Thread Luigi Toscano
ltoscano added a comment. Apologize for the long delay. It looks like that the fix still applies and works according the comment. I added @mkoller, the historical maintainer of kio-man, who can probably validate the change better than me, but let's try to push this for the upcoming KDE

D9033: man ioslave: asserts trying to display pam(8)

2019-07-10 Thread Luigi Toscano
ltoscano added a reviewer: mkoller. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D9033 To: marten, #plasma, kfm-devel, mkoller Cc: kde-frameworks-devel, apol, plasma-devel, fprice, LeGast00n, jraleigh, gennad, fbampaloukas, alexde, GB_2, feverfew, ragreen, Pitel,

D22107: Add MediaTransport API

2019-06-27 Thread Luigi Toscano
ltoscano added inline comments. INLINE COMMENTS > mweichselbaumer wrote in a2dp-codecs.h:33 > Yes, this has also been fixed by bluez as of 2018-12-28. Will it work with older versions of bluez? REPOSITORY R269 BluezQt REVISION DETAIL https://phabricator.kde.org/D22107 To:

D17595: Upstream Dolphin's file rename dialog

2019-05-10 Thread Luigi Toscano
ltoscano added inline comments. INLINE COMMENTS > meven wrote in renamefiledialog.h:5 > We can email Peter Penz to ask about doing a license change. > > I wish we would ask its contributors to allow the kde foundation to update > code distribution license on their behalf, provided the license

D19812: Add a web page to view and compare icons of different sizes

2019-04-26 Thread Luigi Toscano
ltoscano added a comment. The documentation website of krita is a different type of repository. This project is going to be distributed and compiled by the distributions, and many of them will have to patch out the minified javascript and replace it with a dependency on a proper packaged

D20806: Add HiDPI support

2019-04-25 Thread Luigi Toscano
ltoscano added a comment. The KSane library is not a framework. REPOSITORY R382 KSane Library REVISION DETAIL https://phabricator.kde.org/D20806 To: volkov, sars, #frameworks Cc: ltoscano, ngraham

Re: MacOS Builds - KArchive & KDocTools

2019-04-24 Thread Luigi Toscano
Ben Cooksley ha scritto: Hi all, While getting Mac builds back on their feet this morning we've run into a rather terminal build failure issue, centering around KArchive and KDocTools. The issue is struck during the build of KDocTools, when the linking of libKF5DocTools.dylib fails with the

D17500: Get mobipocket extractor up-to-date, but keep disabled

2019-04-11 Thread Luigi Toscano
ltoscano added a comment. The proposed solution to remove the loop is moving the extractor to the kdegraphics-mobipocket repository. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: ltoscano, mgallien, aacid,

D17500: Get mobipocket extractor up-to-date, but keep disabled

2019-04-09 Thread Luigi Toscano
ltoscano added a comment. So no plans for moving it to kdegraphics-mobipocket? It's a dependency loop. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D17500 To: astippich, bruns Cc: ltoscano, mgallien, aacid, kde-frameworks-devel, #baloo, gennad, domson,

D19092: Add bison minimum version of 2.4.1 due to %code

2019-03-29 Thread Luigi Toscano
ltoscano added a comment. Ups, sorry! So according https://community.kde.org/Schedules/Frameworks there are no special provisions when the change doesn't touch translatable strings and the change is properly tested. REPOSITORY R309 KService BRANCH bison_min_version (branched from

D19092: Add bison minimum version of 2.4.1 due to %code

2019-03-29 Thread Luigi Toscano
ltoscano added a comment. Not on the 19.04 branch, the dependency freeze happened few weeks ago - you may want to ask to release-team@ for an exception if you think it's important there too. REPOSITORY R309 KService BRANCH bison_min_version (branched from master) REVISION DETAIL

D19696: Add blender thumbnailer

2019-03-12 Thread Luigi Toscano
ltoscano added a comment. In D19696#429476 , @broulik wrote: > Since this one is a bit more specific, perhaps it should indeed go into kdegraphics-thumbnailers, don't really mind. I think I have asked this often before but is

D19696: Add blender thumbnailer

2019-03-11 Thread Luigi Toscano
ltoscano added a comment. I have my usual question: shouldn't this go into kdegraphics-thumbnailers? kio-extras shouldn't be a "dump everything which is not somewhere else". REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D19696 To: chinmoyr, #frameworks Cc:

D19557: Update design to look more similar to kde.org

2019-03-10 Thread Luigi Toscano
ltoscano accepted this revision. ltoscano added a comment. This revision is now accepted and ready to land. Thank you! And sorry for the ping-pong. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation, yurchor,

D19557: Update css

2019-03-10 Thread Luigi Toscano
ltoscano added a comment. In D19557#428619 , @ognarb wrote: > In D19557#428618 , @ltoscano wrote: > > > In D19557#428617 , @ognarb wrote: > > > > >

D19557: Update css

2019-03-10 Thread Luigi Toscano
ltoscano added a comment. In any case, please change the commit message. When this is committed and rechecked in one year from now, the aspect of the linked website may not be relevant anymore and the images are not visible when you run git log. Please describe what the change is about.

D19557: Update css

2019-03-10 Thread Luigi Toscano
ltoscano added a comment. In D19557#428617 , @ognarb wrote: > They use the old link for the image, also the jpg version instead of the png. I tested with new page and old page and the result is visually the same. But do the existing

D19557: Update css

2019-03-10 Thread Luigi Toscano
ltoscano requested changes to this revision. ltoscano added a comment. This revision now requires changes to proceed. No, wait a minute. What happens with pages which are not regenerated? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg,

D19557: Update css

2019-03-10 Thread Luigi Toscano
ltoscano accepted this revision. ltoscano added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D19557 To: ognarb, #vdg, #documentation, yurchor, ltoscano Cc: yurchor, rooty,

D19557: Update css

2019-03-10 Thread Luigi Toscano
ltoscano requested changes to this revision. ltoscano added a comment. This revision now requires changes to proceed. Can you please not overwrite top-kde.jpg too, or at least use the same size? Because the change of size may be a problem for existing users (if any, but I consider those

D19646: Redesign KDE Connect and bluetooth config pages

2019-03-10 Thread Luigi Toscano
ltoscano added a comment. Less technical note: I think that the commit message should not really about KDE Connect, as the change is reflected on all Purpose's users. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D19646 To: nicolasfella, #vdg, apol,

D19557: Update css

2019-03-10 Thread Luigi Toscano
ltoscano added a subscriber: yurchor. ltoscano added a comment. On the graphical side I'm not the most qualified to talk :) Apart from the VDG, I'm sure that @yurchor can give some hints, as he manages the templates used to generate the PDFs. From the technical point of view, I

D19335: [kdoctools] make it compile without foreach

2019-02-26 Thread Luigi Toscano
ltoscano added a comment. Isn't it a duplicate of D19271 ? REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19335 To: mlaurent, dfaure Cc: ltoscano, kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns,

D19224: Only report DocBookXML as found if it was actually found

2019-02-22 Thread Luigi Toscano
ltoscano accepted this revision. ltoscano added a comment. This revision is now accepted and ready to land. Right, sorry. REPOSITORY R238 KDocTools BRANCH master REVISION DETAIL https://phabricator.kde.org/D19224 To: apol, #frameworks, ltoscano Cc: kde-frameworks-devel,

D19224: Only report DocBookXML as found if it was actually found

2019-02-22 Thread Luigi Toscano
ltoscano added a comment. Sorry, I forgot to save a comment. INLINE COMMENTS > FindDocBookXML4.cmake:88 > +else() > +message(WARNING "${found_dir}: Could not find docbookx.dtd in > ${CMAKE_SYSTEM_PREFIX_PATH} with suffixes ${DTD_PATH_LIST}") > +endif() Isn't ${found_dir}

D19224: Only report DocBookXML as found if it was actually found

2019-02-22 Thread Luigi Toscano
ltoscano requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D19224 To: apol, #frameworks, ltoscano Cc: kde-frameworks-devel, kde-doc-english, gennad, michaelh, ngraham, bruns, skadinna

D19054: Port cross-compilation support to KF5_HOST_TOOLING

2019-02-15 Thread Luigi Toscano
ltoscano added subscribers: habacker, ltoscano. ltoscano added a comment. I trust @vkrause that this complicated part works, but I need to ask @habacker too, as he contributed part of the cross-compiling code. If anyone else from the #windows

D18883: Add PDF thumbnailer

2019-02-09 Thread Luigi Toscano
ltoscano added a comment. Why can't this go to kdegraphics-thumbnailer? Kio-extras shouldn't be, IMHO, a "drop everything which does not fit elsewhere" REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D18883 To: broulik, dfaure, aacid, jtamate Cc: ltoscano,

D17956: DocumentPrivate: Fix broken doc links in qCWarning

2019-01-04 Thread Luigi Toscano
ltoscano resigned from this revision. ltoscano added a comment. This revision is now accepted and ready to land. Fine by me regarding the change; I can't answer to the question whether the warning should be localized or not (maybe not), so I'm resigning from the review to not block it

D17956: DocumentPrivate: Fix broken doc links in qCWarning

2019-01-04 Thread Luigi Toscano
ltoscano requested changes to this revision. ltoscano added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > katedocument.cpp:4592 > "Please replace with > 'remove-trailing-spaces modified;', see " > -

D17649: Let docbookl10nhelper executable name follow conventions of checkXML on Windows

2018-12-18 Thread Luigi Toscano
ltoscano added a comment. The file is not meant to be installed (unless INSTALL_INTERNAL_TOOLS is exported), and in general it should not exist in the same build root of its kdelibs 4.x counterpart. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D17649 To:

D17620: Make setHelp() public

2018-12-16 Thread Luigi Toscano
ltoscano added a comment. There may be another way: add a new public method which wraps the protected one, and when moving to KF6 a) make setHelp public and b) deprecate the new wrapper. I think - suggestions needed REPOSITORY R265 KConfigWidgets REVISION DETAIL

D17500: Restore mobipocket extractor

2018-12-14 Thread Luigi Toscano
ltoscano added a comment. In D17500#376854 , @astippich wrote: > In D17500#376221 , @aacid wrote: > > > In D17500#375753 , @astippich wrote: > > > > >

D14998: Add AppImage thumbnailer

2018-12-06 Thread Luigi Toscano
ltoscano added a comment. In D14998#372293 , @probono wrote: > Can it be included/installed in KDE neon? You should ask on Neon request channels. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14998 To:

D17079: Provide a qqc2/kirigami-based about page

2018-11-22 Thread Luigi Toscano
ltoscano added a comment. In D17079#364157 , @mart wrote: > I think this ui should really go into KCoreAddons itself. Would it be accepted there? kcoreaddons is tier1 just like kirigami. Why not create a new Frameworks, kirigami-addons

D17079: Provide a qqc2/kirigami-based about page

2018-11-21 Thread Luigi Toscano
ltoscano added a comment. That's a great idea! Would it be possible: - to also (optionally) support the translators' information, like in the current about box? (probably in a future patch, but maybe some groundwork is needed here) - to move this about page to some common

D16751: Various grammar and capitalization fixes for UI consistency

2018-11-15 Thread Luigi Toscano
ltoscano added a comment. Please see the comments in D16749 and D16750 , many of them apply also here. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D16751 To: snoordhuis, #vdg, #localization Cc:

D16395: Update the "About KDE" text

2018-10-24 Thread Luigi Toscano
ltoscano added a comment. In D16395#347938 , @rizzitello wrote: > Why does this dialog not say anything about the version of KDE. There is *no* version of KDE. KDE is only the community. It's clearly stated in that message. >

D16395: Update the "About KDE" text

2018-10-24 Thread Luigi Toscano
ltoscano added a comment. I'd say that the respecting the string freeze this time makes sense, as we need a bit more time to discuss this. Maybe the promo team can help too, as this is an important message. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D16395 To:

D15927: Use specified Perl interpreter instead of relying on PATH

2018-10-21 Thread Luigi Toscano
This revision was automatically updated to reflect the committed changes. Closed by commit R238:1caa28ea5614: Use specified Perl interpreter instead of relying on PATH (authored by zrax, committed by ltoscano). REPOSITORY R238 KDocTools CHANGES SINCE LAST UPDATE

D15927: Use specified Perl interpreter instead of relying on PATH

2018-10-04 Thread Luigi Toscano
ltoscano accepted this revision. ltoscano added a comment. This revision is now accepted and ready to land. Uhm, I guess than this can go in then. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D15927 To: zrax, ltoscano Cc: ltoscano, vonreth, kde-doc-english,

D15795: Fix warnings about deprecated install dirs

2018-09-27 Thread Luigi Toscano
ltoscano added inline comments. INLINE COMMENTS > KDEInstallDirs.cmake:564 > "documentation bundles generated using kdoctools" > -HTML_INSTALL_DIR) > +KDE_INSTALL_DOCBUNDLEDIR) > _define_relative(KCFGDIR DATAROOTDIR "config.kcfg" I'm going to comment only on this, but the others

D15718: Do not index the path if the path has no execute permissions.

2018-09-24 Thread Luigi Toscano
ltoscano requested changes to this revision. ltoscano added a comment. I agree with all the objections raised so far, and I'm not sure about the rationale of this change. I'd like to add one point: In D15718#330844 , @smithjd wrote: > In

Re: Quality of Frameworks announcements

2018-09-11 Thread Luigi Toscano
On Sunday, 9 September 2018 16:07:43 CEST Yuri Chornoivan wrote: > Hi, > > I think that several latest Frameworks announcements are not of even medium > quality. It is hard to translate them because the commit messages list looks > like some kind of puzzle. This is a good point, but the i18n

Re: KDE apps have missing icons when not on Breeze

2018-08-29 Thread Luigi Toscano
Albert Astals Cid ha scritto: El dimecres, 29 d’agost de 2018, a les 21:13:03 CEST, Albert Vaca va escriure: Do you think it's a good idea to ask packagers to make KIconThemes depend on Breeze icons? I think depend is probably "too strong", but recommend for sure. Did you also consider to

D15131: add acronym ASCII to general.entities

2018-08-28 Thread Luigi Toscano
ltoscano accepted this revision. This revision is now accepted and ready to land. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D15131 To: lueck, ltoscano Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D15105: add JSON to general.entities

2018-08-27 Thread Luigi Toscano
ltoscano accepted this revision as: ltoscano. REPOSITORY R238 KDocTools REVISION DETAIL https://phabricator.kde.org/D15105 To: lueck, #documentation, yurchor, ltoscano Cc: kde-frameworks-devel, kde-doc-english, michaelh, ngraham, bruns, skadinna

D14896: Fix bzip main page

2018-08-17 Thread Luigi Toscano
ltoscano closed this revision. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D14896 To: ltoscano, svuorela Cc: svuorela, kde-frameworks-devel, michaelh, ngraham, bruns

D14896: Fix bzip main page

2018-08-17 Thread Luigi Toscano
ltoscano created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ltoscano requested review of this revision. REVISION SUMMARY The known domain is lost: https://lwn.net/Articles/762264/ https://lwn.net/Articles/762340/ REPOSITORY R243

D14817: Convert manual install test to an autotest

2018-08-14 Thread Luigi Toscano
ltoscano added a comment. This worked with Qt 5.9 on the CI and locally with 5.10 too, but the CI seems to be unhappy for openSUSE/Qt 5.10 and Windows/Qt 5.10 (it works on openSUSE/Qt 5.9 and FreeBSD/Qt 5.10): - https://build.kde.org/job/Frameworks%20kdoctools%20kf5-qt5%20SUSEQt5.10/46/

D14643: Bump the minimum logging category to Warning

2018-08-06 Thread Luigi Toscano
ltoscano abandoned this revision. ltoscano added a comment. Thanks for confirming. I will work on setting the default to Info for Frameworks components when it's not the case already, and tuning the debug messages. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D14643

D14643: Bump the minimum logging category to Warning

2018-08-06 Thread Luigi Toscano
ltoscano added a comment. I was under the impression that we were generally moving towards less chatty components by default, which included having Warning as minimum default level. Unfortunately I don't remember anymore how I've got this idea, but I remember some patches setting the

D14572: Check the build directory for po/ as well

2018-08-06 Thread Luigi Toscano
ltoscano accepted this revision. ltoscano added a comment. It was basically already approved, and it already made sense. The only requested change (a comment) was applied. REPOSITORY R249 KI18n BRANCH arcpatch-D14572 REVISION DETAIL https://phabricator.kde.org/D14572 To: apol,

D14643: Bump the minimum logging category to Warning

2018-08-05 Thread Luigi Toscano
ltoscano created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. ltoscano requested review of this revision. REVISION SUMMARY Also, break the long statements when needed, trying to follow the style of the rest

D14528: Android: Make sure we're looking for .mo files in the right path

2018-08-01 Thread Luigi Toscano
ltoscano added a comment. Is this a possible Qt bug where the output of QStandardPaths should be tuned on Android? REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D14528 To: apol, #frameworks, ilic, ckertesz Cc: ltoscano, kde-frameworks-devel, michaelh, ngraham, bruns

D9446: WIP: Allow to autogenerate and install categories file

2018-06-28 Thread Luigi Toscano
ltoscano added a comment. In D9446#284288 , @cgiboudeaux wrote: > > There are several issues that need fixes: > > - Installation dir for categories, /etc/xdg on linux has always been wrong. categories are not config files

  1   2   3   4   5   6   7   >